From 9b2752021245f9a3cfdfbc531eab2176d891240d Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Tue, 14 Dec 2021 21:59:26 +0000 Subject: [PATCH 01/66] Make all walkers use a walker that understand v0.1 and v0.2 formats --- meta/folder.groovy | 137 ++++++++++++++++++--------------------------- 1 file changed, 54 insertions(+), 83 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index dd3a1b7..adf124a 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -893,31 +893,6 @@ class MetaInfo extends GISJsonSerialised { saveJsonSerialised(metafilepath) return artifactlist } - - // Recurse tree of meta looking for release info and accumulate path - Pass by reference unavailable in Groovy/Java - private ArrayList releasewalkerp(int maxdepth, ArrayList releasemetacollection, String pathsofar) { - if (maxdepth > 0) { - if (releaseinfo.releaserepoURL) { - RelatedMetaInfo rmi = new RelatedMetaInfo_v0_1(script, pathsofar, this) - releasemetacollection.add(rmi) - } - if (pathsofar) { - pathsofar += "/" - } - for (relatedmetainfo in associatedmeta) { - MetaInfo othermeta = relatedmetainfo.meta - String newpathsofar = pathsofar + relatedmetainfo.offsetpath - releasemetacollection = othermeta.releasewalkerp(maxdepth - 1, releasemetacollection, newpathsofar) - } - } - return releasemetacollection - } - - ArrayList releasewalker(int maxdepth, String startpath = "") { - ArrayList releasemetacollection = new ArrayList() - releasemetacollection = releasewalkerp(maxdepth, releasemetacollection, startpath) - return releasemetacollection - } String componentidentifier() { return productinfo.productname + "_" + productinfo.subcomponentname @@ -939,44 +914,6 @@ class MetaInfo extends GISJsonSerialised { return buildstampinfo.buildstamp + "-" + jenkinsbuildinfo.buildnumber } - Map putwithshortestoffsetpath(Map releasemetacollection, String uniquestring, RelatedMetaInfo relatedmetainfo) { - if (releasemetacollection.containsKey(uniquestring)) { - def existingentry = releasemetacollection[uniquestring] - if (existingentry.offsetpath.size() > relatedmetainfo.offsetpath.size()) { - releasemetacollection.put(uniquestring, relatedmetainfo) - } - } else { - releasemetacollection.put(uniquestring, relatedmetainfo) - } - return releasemetacollection - } - - Map releasewalkerunique(int maxdepth, String startpath = "") { - def ArrayList releasemetacollection = new ArrayList() - releasemetacollection = releasewalkerp(maxdepth, releasemetacollection, startpath) - - def Map releasemetauniquecollection = new LinkedHashMap() - for (relatedmetainfo in releasemetacollection) { - def String uniquestring = relatedmetainfo.meta.componentidentifier() - releasemetauniquecollection = putwithshortestoffsetpath(releasemetauniquecollection, uniquestring, relatedmetainfo) - } - - return releasemetauniquecollection - } - - Map releasewalkerversionunique(int maxdepth, String startpath = "") { - ArrayList releasemetacollection = new ArrayList() - releasemetacollection = releasewalkerp(maxdepth, releasemetacollection, startpath) - - def Map releasemetaversionuniquecollection = new LinkedHashMap() - for (relatedmetainfo in releasemetacollection) { - def String uniquestring = relatedmetainfo.meta.componentversionuniqueidentifier() - releasemetaversionuniquecollection = putwithshortestoffsetpath(releasemetaversionuniquecollection, uniquestring, relatedmetainfo) - } - - return releasemetaversionuniquecollection - } - def openchildmeta(String gatheredpath, RelatedMetaInfo relatedmetainfo) { def MetaInfo mi = new MetaInfo(script) @@ -1004,40 +941,44 @@ class MetaInfo extends GISJsonSerialised { return childmetainfo } - def walkrelated_v0_1(ArrayList metacollection, String comment = '', int level = 0) { + def walkrelated_v0_1(ArrayList metacollection, String comment = '', int level = 0, boolean limiteddepth = false, int maxdepth = 0) { def results = [ 'metacollection' : metacollection, 'comment': comment ] - results.metacollection.add(this) - results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' - for (relatedmetainfo in associatedmeta) { - if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { - def MetaInfo othermeta = relatedmetainfo.meta - results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1) - } else { - script.error("There is non v0.1 format related meta info under v0.1 related meta info") + if (!limiteddepth || maxdepth > 0) { + results.metacollection.add(this) + results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' + for (relatedmetainfo in associatedmeta) { + if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { + def MetaInfo othermeta = relatedmetainfo.meta + results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, limiteddepth, maxdepth - 1) + } else { + script.error("There is non v0.1 format related meta info under v0.1 related meta info") + } } } return [ 'metacollection' : results.metacollection, 'comment': results.comment ] } - def walkrelated(ArrayList metacollection, String comment = '', int level = 0, String gatheredpath = '') { + def walkrelated(ArrayList metacollection, String comment = '', int level = 0, String gatheredpath = '', boolean limiteddepth = false, int maxdepth = 0) { def results = [ 'metacollection' : metacollection, 'comment': comment ] - results.metacollection.add(this) - results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' - for (relatedmetainfo in associatedmeta) { - if (relatedmetainfo.format == '0.2') { - def childmetainfo = openchildmeta(gatheredpath, relatedmetainfo) - if (childmetainfo.imported) { - results = childmetainfo.childmeta.walkrelated(results.metacollection, results.comment, level + 1, childmetainfo.nextpath) + if (!limiteddepth || maxdepth > 0) { + results.metacollection.add(this) + results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' + for (relatedmetainfo in associatedmeta) { + if (relatedmetainfo.format == '0.2') { + def childmetainfo = openchildmeta(gatheredpath, relatedmetainfo) + if (childmetainfo.imported) { + results = childmetainfo.childmeta.walkrelated(results.metacollection, results.comment, level + 1, childmetainfo.nextpath, limiteddepth, maxdepth - 1) + } + } else if (relatedmetainfo.format == '0.1') { + def MetaInfo othermeta = relatedmetainfo.meta + results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, limiteddepth, maxdepth - 1) } - } else if (relatedmetainfo.format == '0.1') { - def MetaInfo othermeta = relatedmetainfo.meta - results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1) } } return [ 'metacollection' : results.metacollection, 'comment': results.comment ] @@ -1048,6 +989,36 @@ class MetaInfo extends GISJsonSerialised { return walkrelated(metacollection) } + ArrayList releasewalker(int maxdepth, String startpath = '') { + def ArrayList metacollection = new ArrayList() + def results = walkrelated(metacollection, '', 0, startpath, true, maxdepth) + return results.metacollection + } + + Map releasewalkerversionunique(int maxdepth, String startpath = '') { + def ArrayList metacollection = releasewalker(maxdepth, startpath) + + def Map versionuniquecollection = new LinkedHashMap() + for (metainfo in metacollection) { + def String uniquestring = metainfo.componentversionuniqueidentifier() + versionuniquecollection.put(uniquestring, metainfo) + } + + return versionuniquecollection + } + + Map releasewalkerunique(int maxdepth, String startpath = '') { + def ArrayList metacollection = releasewalker(maxdepth, startpath) + + def Map uniquecollection = new LinkedHashMap() + for (metainfo in metacollection) { + def String uniquestring = metainfo.componentidentifier() + uniquecollection.put(uniquestring, metainfo) + } + + return uniquecollection + } + MetaInfo getNewMetaObject(script) { return new MetaInfo(script) } From 1ee2be62fff8ed870aee9433252fa30800d2bd40 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:11:39 +0000 Subject: [PATCH 02/66] Use importer to get build artifacts to release --- release/release.groovy | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/release/release.groovy b/release/release.groovy index 42357fc..5c9925e 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -23,18 +23,15 @@ pipeline { stage('Get build artifact meta') { steps { script { + importer = load("${autobuilder.commonscripts()}/import/importer.groovy") + BUILD_ARTIFACTS = "${WORKSPACE}/build_artifacts" - copyArtifacts( - filter: 'meta/**', - projectName: BUILD_JOB, - selector: [ - $class: 'ParameterizedBuildSelector', - parameterName: BUILD_JOB_SELECTOR - ], - target: BUILD_ARTIFACTS - ) - def mfs = autobuilderscript.getmetafolderscript() - buildmeta = mfs.metafromfolder(BUILD_ARTIFACTS) + + def importoptions = importer.getNewImportOptions() + importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) + importoptions.setincrementversionnumber(false) + importoptions.setfilter('meta/**') + buildmeta = importer.artifactimport(meta, controlimportoptions, BUILD_ARTIFACTS) } } } From 7d8e910d202e2ee029d7d5dc91cdf48afb10575b Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:12:47 +0000 Subject: [PATCH 03/66] Use importer to get build artifacts to release --- release/release.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/release.groovy b/release/release.groovy index 5c9925e..918c386 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -31,7 +31,7 @@ pipeline { importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) importoptions.setincrementversionnumber(false) importoptions.setfilter('meta/**') - buildmeta = importer.artifactimport(meta, controlimportoptions, BUILD_ARTIFACTS) + buildmeta = importer.artifactimport(meta, importoptions, BUILD_ARTIFACTS) } } } From 96621af758c19411cdd68230ac773f140b76c511 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:27:21 +0000 Subject: [PATCH 04/66] Use importer to get build artifacts to release --- release/release.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/release.groovy b/release/release.groovy index 918c386..17f5185 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -25,7 +25,7 @@ pipeline { script { importer = load("${autobuilder.commonscripts()}/import/importer.groovy") - BUILD_ARTIFACTS = "${WORKSPACE}/build_artifacts" + BUILD_ARTIFACTS = "${WORKSPACE}" def importoptions = importer.getNewImportOptions() importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) From aff9e3e106c195703501e06f633fe178503cb7aa Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:31:46 +0000 Subject: [PATCH 05/66] Use importer to get build artifacts to release --- release/release.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/release.groovy b/release/release.groovy index 17f5185..8f7d129 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -25,7 +25,7 @@ pipeline { script { importer = load("${autobuilder.commonscripts()}/import/importer.groovy") - BUILD_ARTIFACTS = "${WORKSPACE}" + BUILD_ARTIFACTS = '.' def importoptions = importer.getNewImportOptions() importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) From f3a0f9fcc95a886543e22e0611c6c188484b423f Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:35:17 +0000 Subject: [PATCH 06/66] Use importer to get build artifacts to release --- release/release.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/release/release.groovy b/release/release.groovy index 8f7d129..daf42aa 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -31,6 +31,7 @@ pipeline { importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) importoptions.setincrementversionnumber(false) importoptions.setfilter('meta/**') + importoptions.clean(false) buildmeta = importer.artifactimport(meta, importoptions, BUILD_ARTIFACTS) } } From fc34f642388f769ae727dd3c73bfe4bfd6e5009f Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:37:12 +0000 Subject: [PATCH 07/66] Use importer to get build artifacts to release --- release/release.groovy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/release/release.groovy b/release/release.groovy index daf42aa..2c168b9 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -25,13 +25,12 @@ pipeline { script { importer = load("${autobuilder.commonscripts()}/import/importer.groovy") - BUILD_ARTIFACTS = '.' + BUILD_ARTIFACTS = 'build' def importoptions = importer.getNewImportOptions() importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) importoptions.setincrementversionnumber(false) importoptions.setfilter('meta/**') - importoptions.clean(false) buildmeta = importer.artifactimport(meta, importoptions, BUILD_ARTIFACTS) } } From 135fddb356051307cf93e02d2e90bd47a0be84df Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:41:45 +0000 Subject: [PATCH 08/66] Use importer to get build artifacts to release --- release/release.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/release/release.groovy b/release/release.groovy index 2c168b9..20f520c 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -31,6 +31,7 @@ pipeline { importoptions.jenkinsjob(BUILD_JOB, BUILD_JOB_SELECTOR) importoptions.setincrementversionnumber(false) importoptions.setfilter('meta/**') + importoptions.setappendtoparentmeta(false) buildmeta = importer.artifactimport(meta, importoptions, BUILD_ARTIFACTS) } } From e35826fb24014d77f52fae247010b775c190da5e Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:45:18 +0000 Subject: [PATCH 09/66] Use importer to get build artifacts to release --- release/do.groovy | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/release/do.groovy b/release/do.groovy index e0b9471..3430342 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -396,13 +396,16 @@ def releasecomponent(toplevelbuildmeta, buildinfo, String otherreleasetags, Stri repoandtagsappend("\n") } -def releasehierarchy(buildmeta, String maxdepth, String otherreleasetags, String dryrunpush) { +def releasehierarchy(buildfolder, buildmeta, String maxdepth, String otherreleasetags, String dryrunpush) { def int md = maxdepth.toInteger() resetfolders() preconditions() // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfo = buildmeta.releasewalkerunique(md) + def componentReleaseInfo + dir(buildfolder) { + componentReleaseInfo = buildmeta.releasewalkerunique(md) + } echo "Unique components:" def String versioncomponent = "" for (key in componentReleaseInfo.keySet()) { From b64672cc94017ad76223e26e9eaa9b801e1ab2fc Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:47:28 +0000 Subject: [PATCH 10/66] Use importer to get build artifacts to release --- release/release.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/release.groovy b/release/release.groovy index 20f520c..2324b60 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -42,7 +42,7 @@ pipeline { def releaser = load("${autobuilder.commonscripts()}/release/do.groovy") // Place the top level build stamp on all OTHER_RELEASE_TAGS = "${buildmeta.globalreleasetag()},${OTHER_RELEASE_TAGS}" - (summarystring, markunstable, unstablereason) = releaser.releasehierarchy(buildmeta, MAX_META_DEPTH, OTHER_RELEASE_TAGS, DRY_RUN_PUSH) + (summarystring, markunstable, unstablereason) = releaser.releasehierarchy(BUILD_ARTIFACTS, buildmeta, MAX_META_DEPTH, OTHER_RELEASE_TAGS, DRY_RUN_PUSH) if (markunstable) { env.unstablereason = unstablereason currentBuild.result = 'UNSTABLE' From f41768212cc3352a3e01e424d118253a5b31f870 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 14:56:32 +0000 Subject: [PATCH 11/66] Use importer to get build artifacts to release --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index adf124a..88e05e5 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -991,7 +991,7 @@ class MetaInfo extends GISJsonSerialised { ArrayList releasewalker(int maxdepth, String startpath = '') { def ArrayList metacollection = new ArrayList() - def results = walkrelated(metacollection, '', 0, startpath, true, maxdepth) + def results = walkrelated(metacollection, 'meta', 0, startpath, true, maxdepth) return results.metacollection } From 82dc66da2f754714e99b91e9e29845ff7dcfb37b Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 21:34:55 +0000 Subject: [PATCH 12/66] Use importer to get build artifacts to release --- meta/folder.groovy | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/folder.groovy b/meta/folder.groovy index 88e05e5..499535a 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -942,6 +942,7 @@ class MetaInfo extends GISJsonSerialised { } def walkrelated_v0_1(ArrayList metacollection, String comment = '', int level = 0, boolean limiteddepth = false, int maxdepth = 0) { + script.echo("walkrelated_v0_1 Iteration:\nLevel: ${level}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") def results = [ 'metacollection' : metacollection, 'comment': comment @@ -962,6 +963,7 @@ class MetaInfo extends GISJsonSerialised { } def walkrelated(ArrayList metacollection, String comment = '', int level = 0, String gatheredpath = '', boolean limiteddepth = false, int maxdepth = 0) { + script.echo("walkrelated Iteration:\nLevel: ${level}\nGathered path: ${gatheredpath}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") def results = [ 'metacollection' : metacollection, 'comment': comment From 5b350028ea1a0391199b6f014a389dc31e69cd04 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 22:02:04 +0000 Subject: [PATCH 13/66] Try to walk through build meta items --- release/do.groovy | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/release/do.groovy b/release/do.groovy index 3430342..563a49f 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -402,10 +402,7 @@ def releasehierarchy(buildfolder, buildmeta, String maxdepth, String otherreleas preconditions() // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfo - dir(buildfolder) { - componentReleaseInfo = buildmeta.releasewalkerunique(md) - } + def componentReleaseInfo = buildmeta.releasewalkerunique(md, buildfolder) echo "Unique components:" def String versioncomponent = "" for (key in componentReleaseInfo.keySet()) { From 99aa54ae8e6908083bbf02a1f49e62ddb12f956b Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 22:13:33 +0000 Subject: [PATCH 14/66] Try to walk through build meta items --- meta/folder.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 499535a..3f60bfa 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -998,7 +998,7 @@ class MetaInfo extends GISJsonSerialised { } Map releasewalkerversionunique(int maxdepth, String startpath = '') { - def ArrayList metacollection = releasewalker(maxdepth, startpath) + def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}") def Map versionuniquecollection = new LinkedHashMap() for (metainfo in metacollection) { @@ -1010,7 +1010,7 @@ class MetaInfo extends GISJsonSerialised { } Map releasewalkerunique(int maxdepth, String startpath = '') { - def ArrayList metacollection = releasewalker(maxdepth, startpath) + def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}") def Map uniquecollection = new LinkedHashMap() for (metainfo in metacollection) { From b973208999feeea379038cc13a2297495fc02c5b Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 15 Dec 2021 22:20:07 +0000 Subject: [PATCH 15/66] Try to walk through build meta items --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index 563a49f..d131173 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -411,7 +411,7 @@ def releasehierarchy(buildfolder, buildmeta, String maxdepth, String otherreleas echo versioncomponent // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md) + def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder) echo "Version unique components:" def String versionuniquecomponent = "" for (key in componentReleaseInfoVersionUnique.keySet()) { From ece26703656703826e0ab36307710b30d0181031 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Thu, 16 Dec 2021 15:39:32 +0000 Subject: [PATCH 16/66] Make the walkers carry more meta data --- meta/folder.groovy | 111 +++++++++++++++++++++++++++++++-------------- 1 file changed, 76 insertions(+), 35 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 3f60bfa..fb10cbd 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -914,16 +914,32 @@ class MetaInfo extends GISJsonSerialised { return buildstampinfo.buildstamp + "-" + jenkinsbuildinfo.buildnumber } - def openchildmeta(String gatheredpath, RelatedMetaInfo relatedmetainfo) { + class CollectedMeta { + private MetaInfo metainfo + private String accumulatedpath + + CollectedMeta(MetaInfo metainfo, String accumulatedpath = '') { + this.metainfo = metainfo + this.accumulatedpath = accumulatedpath + } + } + + def openchildmeta(String gatheredpath, String gatheredmetapath, RelatedMetaInfo relatedmetainfo) { def MetaInfo mi = new MetaInfo(script) - def String nextpath + def String nextgatheredpath if (gatheredpath == '') { - nextpath = "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" + nextgatheredpath = "${relatedmetainfo.offsetpath}" } else { - nextpath = "${gatheredpath}/${relatedmetainfo.offsetpath}" + nextgatheredpath = "${gatheredpath}/${relatedmetainfo.offsetpath}" } - def importedmetafile = "${nextpath}/${METAFILENAME}" + def String nextgatheredmetapath + if (gatheredmetapath == '') { + nextgatheredmetapath = "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" + } else { + nextgatheredmetapath = "${gatheredmetapath}/${relatedmetainfo.offsetpath}" + } + def importedmetafile = "${nextgatheredmetapath}/${METAFILENAME}" def boolean imported if (script.fileExists(importedmetafile)) { mi.deserialiseJson(importedmetafile) @@ -935,25 +951,38 @@ class MetaInfo extends GISJsonSerialised { def childmetainfo = [ 'imported': imported, - 'nextpath': nextpath, + 'nextgatheredpath': nextgatheredpath, + 'nextgatheredmetapath': nextgatheredmetapath, 'childmeta': mi ] return childmetainfo } - def walkrelated_v0_1(ArrayList metacollection, String comment = '', int level = 0, boolean limiteddepth = false, int maxdepth = 0) { - script.echo("walkrelated_v0_1 Iteration:\nLevel: ${level}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") + def walkrelated_v0_1(ArrayList metacollection, + String comment = '', + int level = 0, + String gatheredpath = '', + String gatheredmetapath = '', + boolean limiteddepth = false, + int maxdepth = 0) { + script.echo("walkrelated_v0_1 Iteration:\nLevel: ${level}\nGathered path: ${gatheredpath}\nGathered meta path: ${gatheredmetapath}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") def results = [ 'metacollection' : metacollection, 'comment': comment ] if (!limiteddepth || maxdepth > 0) { - results.metacollection.add(this) + results.metacollection.add(new CollectedMeta(this, gatheredpath)) results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' for (relatedmetainfo in associatedmeta) { if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta - results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, limiteddepth, maxdepth - 1) + results = othermeta.walkrelated_v0_1(results.metacollection, + results.comment, + level + 1, + "${gatheredpath}/${relatedmetainfo.offsetpath}", + "${gatheredmetapath}/${relatedmetainfo.offsetpath}", + limiteddepth, + maxdepth - 1) } else { script.error("There is non v0.1 format related meta info under v0.1 related meta info") } @@ -962,24 +991,36 @@ class MetaInfo extends GISJsonSerialised { return [ 'metacollection' : results.metacollection, 'comment': results.comment ] } - def walkrelated(ArrayList metacollection, String comment = '', int level = 0, String gatheredpath = '', boolean limiteddepth = false, int maxdepth = 0) { - script.echo("walkrelated Iteration:\nLevel: ${level}\nGathered path: ${gatheredpath}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") + def walkrelated(ArrayList metacollection, + String comment = '', + int level = 0, + String gatheredpath = '', + String gatheredmetapath = '', + boolean limiteddepth = false, + int maxdepth = 0) { + script.echo("walkrelated Iteration:\nLevel: ${level}\nGathered path: ${gatheredpath}\nGathered meta path: ${gatheredmetapath}\nLimited depth: ${limiteddepth}\nMax depth: ${maxdepth}") def results = [ 'metacollection' : metacollection, 'comment': comment ] if (!limiteddepth || maxdepth > 0) { - results.metacollection.add(this) + results.metacollection.add(new CollectedMeta(this, gatheredpath)) results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' for (relatedmetainfo in associatedmeta) { if (relatedmetainfo.format == '0.2') { - def childmetainfo = openchildmeta(gatheredpath, relatedmetainfo) + def childmetainfo = openchildmeta(gatheredpath, gatheredmetapath, relatedmetainfo) if (childmetainfo.imported) { - results = childmetainfo.childmeta.walkrelated(results.metacollection, results.comment, level + 1, childmetainfo.nextpath, limiteddepth, maxdepth - 1) + results = childmetainfo.childmeta.walkrelated(results.metacollection, + results.comment, + level + 1, + childmetainfo.nextgatheredpath + childmetainfo.nextgatheredmetapath, + limiteddepth, + maxdepth - 1) } } else if (relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta - results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, limiteddepth, maxdepth - 1) + results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, gatheredpath, gatheredmetapath, limiteddepth, maxdepth - 1) } } } @@ -987,23 +1028,23 @@ class MetaInfo extends GISJsonSerialised { } def allrelatedmeta() { - ArrayList metacollection = new ArrayList() + ArrayList metacollection = new ArrayList() return walkrelated(metacollection) } - ArrayList releasewalker(int maxdepth, String startpath = '') { - def ArrayList metacollection = new ArrayList() - def results = walkrelated(metacollection, 'meta', 0, startpath, true, maxdepth) + ArrayList releasewalker(int maxdepth, String startpath = '', String startmetapath = '') { + def ArrayList metacollection = new ArrayList() + def results = walkrelated(metacollection, 'meta', 0, startpath, startmetapath, true, maxdepth) return results.metacollection } - Map releasewalkerversionunique(int maxdepth, String startpath = '') { - def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}") + Map releasewalkerversionunique(int maxdepth, String startpath = '', String startmetapath = '') { + def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}", startmetapath) - def Map versionuniquecollection = new LinkedHashMap() - for (metainfo in metacollection) { - def String uniquestring = metainfo.componentversionuniqueidentifier() - versionuniquecollection.put(uniquestring, metainfo) + def Map versionuniquecollection = new LinkedHashMap() + for (metaitem in metacollection) { + def String uniquestring = metaitem.metainfo.componentversionuniqueidentifier() + versionuniquecollection.put(uniquestring, metaitem) } return versionuniquecollection @@ -1013,9 +1054,9 @@ class MetaInfo extends GISJsonSerialised { def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}") def Map uniquecollection = new LinkedHashMap() - for (metainfo in metacollection) { - def String uniquestring = metainfo.componentidentifier() - uniquecollection.put(uniquestring, metainfo) + for (metaitem in metacollection) { + def String uniquestring = metaitem.metainfo.componentidentifier() + uniquecollection.put(uniquestring, metaitem) } return uniquecollection @@ -1027,15 +1068,15 @@ class MetaInfo extends GISJsonSerialised { def findAssociatedMeta(String productname, String subcomponentname) { def results = [ - 'matchedmeta' : getNewMetaObject(this), + 'matchedmetaitem' : new CollectedMeta(this), 'matchfound' : false ] def walkresults = allrelatedmeta() - for (dependentmeta in walkresults.metacollection) { - if (dependentmeta.productinfo.productname == productname && - dependentmeta.productinfo.subcomponentname == subcomponentname) { - script.echo("Found matching component: ${dependentmeta.globalreleasetag()}") - results.matchedmeta = dependentmeta + for (dependentmetaitem in walkresults.metacollection) { + if (dependentmetaitem.metainfo.productinfo.productname == productname && + dependentmetaitem.metainfo.productinfo.subcomponentname == subcomponentname) { + script.echo("Found matching component: ${dependentmetaitem.metainfo.globalreleasetag()}") + results.matchedmetaitem = dependentmetaitem results.matchfound = true break } From 053b39b3df1bbf2f344cdc8ba7701f7fe94f038f Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 11:23:05 +0000 Subject: [PATCH 17/66] Make the walkers carry more meta data --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index fb10cbd..0fd0d8e 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1013,7 +1013,7 @@ class MetaInfo extends GISJsonSerialised { results = childmetainfo.childmeta.walkrelated(results.metacollection, results.comment, level + 1, - childmetainfo.nextgatheredpath + childmetainfo.nextgatheredpath, childmetainfo.nextgatheredmetapath, limiteddepth, maxdepth - 1) From 93ad1bea33bd4304e831232dca66af2ee683b69a Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 11:50:07 +0000 Subject: [PATCH 18/66] Make the walkers carry more meta data --- meta/folder.groovy | 8 ++++---- release/do.groovy | 6 +++--- release/release.groovy | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 0fd0d8e..1c6441b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1039,7 +1039,7 @@ class MetaInfo extends GISJsonSerialised { } Map releasewalkerversionunique(int maxdepth, String startpath = '', String startmetapath = '') { - def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}", startmetapath) + def ArrayList metacollection = releasewalker(maxdepth, startpath, "${startmetapath}/${METAFOLDERNAME}") def Map versionuniquecollection = new LinkedHashMap() for (metaitem in metacollection) { @@ -1050,10 +1050,10 @@ class MetaInfo extends GISJsonSerialised { return versionuniquecollection } - Map releasewalkerunique(int maxdepth, String startpath = '') { - def ArrayList metacollection = releasewalker(maxdepth, "${startpath}/${METAFOLDERNAME}") + Map releasewalkerunique(int maxdepth, String startpath = '', String startmetapath = '') { + def ArrayList metacollection = releasewalker(maxdepth, startpath, "${startmetapath}/${METAFOLDERNAME}") - def Map uniquecollection = new LinkedHashMap() + def Map uniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentidentifier() uniquecollection.put(uniquestring, metaitem) diff --git a/release/do.groovy b/release/do.groovy index d131173..133d425 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -396,13 +396,13 @@ def releasecomponent(toplevelbuildmeta, buildinfo, String otherreleasetags, Stri repoandtagsappend("\n") } -def releasehierarchy(buildfolder, buildmeta, String maxdepth, String otherreleasetags, String dryrunpush) { +def releasehierarchy(String buildfolder, String metafolder, buildmeta, String maxdepth, String otherreleasetags, String dryrunpush) { def int md = maxdepth.toInteger() resetfolders() preconditions() // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfo = buildmeta.releasewalkerunique(md, buildfolder) + def componentReleaseInfo = buildmeta.releasewalkerunique(md, buildfolder, metafolder) echo "Unique components:" def String versioncomponent = "" for (key in componentReleaseInfo.keySet()) { @@ -411,7 +411,7 @@ def releasehierarchy(buildfolder, buildmeta, String maxdepth, String otherreleas echo versioncomponent // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder) + def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder metafolder) echo "Version unique components:" def String versionuniquecomponent = "" for (key in componentReleaseInfoVersionUnique.keySet()) { diff --git a/release/release.groovy b/release/release.groovy index 2324b60..82af511 100644 --- a/release/release.groovy +++ b/release/release.groovy @@ -42,7 +42,7 @@ pipeline { def releaser = load("${autobuilder.commonscripts()}/release/do.groovy") // Place the top level build stamp on all OTHER_RELEASE_TAGS = "${buildmeta.globalreleasetag()},${OTHER_RELEASE_TAGS}" - (summarystring, markunstable, unstablereason) = releaser.releasehierarchy(BUILD_ARTIFACTS, buildmeta, MAX_META_DEPTH, OTHER_RELEASE_TAGS, DRY_RUN_PUSH) + (summarystring, markunstable, unstablereason) = releaser.releasehierarchy('', BUILD_ARTIFACTS, buildmeta, MAX_META_DEPTH, OTHER_RELEASE_TAGS, DRY_RUN_PUSH) if (markunstable) { env.unstablereason = unstablereason currentBuild.result = 'UNSTABLE' From 61e2834a1b7c11a77eb0b7675579cb7e044ce073 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 11:58:52 +0000 Subject: [PATCH 19/66] Make the walkers carry more meta data --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index 133d425..2f175ea 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -411,7 +411,7 @@ def releasehierarchy(String buildfolder, String metafolder, buildmeta, String ma echo versioncomponent // Walk the meta information to a max depth, looking for components to release - def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder metafolder) + def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder, metafolder) echo "Version unique components:" def String versionuniquecomponent = "" for (key in componentReleaseInfoVersionUnique.keySet()) { From 4b72bba43e0082fc7beca9399122248e9287771c Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 12:29:11 +0000 Subject: [PATCH 20/66] Make the walkers carry more meta data --- meta/folder.groovy | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 1c6441b..eef608d 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -917,10 +917,12 @@ class MetaInfo extends GISJsonSerialised { class CollectedMeta { private MetaInfo metainfo private String accumulatedpath + private String accumulatedmetapath - CollectedMeta(MetaInfo metainfo, String accumulatedpath = '') { + CollectedMeta(MetaInfo metainfo, String accumulatedpath = '', String accumulatedmetapath = '') { this.metainfo = metainfo this.accumulatedpath = accumulatedpath + this.accumulatedmetapath = accumulatedmetapath } } @@ -971,7 +973,7 @@ class MetaInfo extends GISJsonSerialised { 'comment': comment ] if (!limiteddepth || maxdepth > 0) { - results.metacollection.add(new CollectedMeta(this, gatheredpath)) + results.metacollection.add(new CollectedMeta(this, gatheredpath, gatheredmetapath)) results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' for (relatedmetainfo in associatedmeta) { if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { @@ -1004,7 +1006,7 @@ class MetaInfo extends GISJsonSerialised { 'comment': comment ] if (!limiteddepth || maxdepth > 0) { - results.metacollection.add(new CollectedMeta(this, gatheredpath)) + results.metacollection.add(new CollectedMeta(this, gatheredpath, gatheredmetapath)) results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' for (relatedmetainfo in associatedmeta) { if (relatedmetainfo.format == '0.2') { @@ -1038,13 +1040,25 @@ class MetaInfo extends GISJsonSerialised { return results.metacollection } + Map putwithshortestoffsetpath(Map releasemetacollection, String uniquestring, CollectedMeta metaitem) { + if (releasemetacollection.containsKey(uniquestring)) { + def existingentry = releasemetacollection[uniquestring] + if (existingentry.accumulatedpath.size() > metaitem.accumulatedpath.size()) { + releasemetacollection.put(uniquestring, metaitem) + } + } else { + releasemetacollection.put(uniquestring, metaitem) + } + return releasemetacollection + } + Map releasewalkerversionunique(int maxdepth, String startpath = '', String startmetapath = '') { def ArrayList metacollection = releasewalker(maxdepth, startpath, "${startmetapath}/${METAFOLDERNAME}") def Map versionuniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentversionuniqueidentifier() - versionuniquecollection.put(uniquestring, metaitem) + versionuniquecollection = putwithshortestoffsetpath(uniquestring, metaitem) } return versionuniquecollection @@ -1056,7 +1070,7 @@ class MetaInfo extends GISJsonSerialised { def Map uniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentidentifier() - uniquecollection.put(uniquestring, metaitem) + versionuniquecollection = putwithshortestoffsetpath(uniquestring, metaitem) } return uniquecollection From dcd5fe6382f62202e124b296edb500c5d3b1e3ba Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 12:31:24 +0000 Subject: [PATCH 21/66] Make the walkers carry more meta data --- meta/folder.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index eef608d..9934287 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1058,7 +1058,7 @@ class MetaInfo extends GISJsonSerialised { def Map versionuniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentversionuniqueidentifier() - versionuniquecollection = putwithshortestoffsetpath(uniquestring, metaitem) + versionuniquecollection = putwithshortestoffsetpath(versionuniquecollection, uniquestring, metaitem) } return versionuniquecollection @@ -1070,7 +1070,7 @@ class MetaInfo extends GISJsonSerialised { def Map uniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentidentifier() - versionuniquecollection = putwithshortestoffsetpath(uniquestring, metaitem) + versionuniquecollection = putwithshortestoffsetpath(versionuniquecollection, uniquestring, metaitem) } return uniquecollection From 55a087b237e35f3a0363bc0db933162ed88b34ad Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 12:32:48 +0000 Subject: [PATCH 22/66] Make the walkers carry more meta data --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 9934287..fb27e64 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1070,7 +1070,7 @@ class MetaInfo extends GISJsonSerialised { def Map uniquecollection = new LinkedHashMap() for (metaitem in metacollection) { def String uniquestring = metaitem.metainfo.componentidentifier() - versionuniquecollection = putwithshortestoffsetpath(versionuniquecollection, uniquestring, metaitem) + uniquecollection = putwithshortestoffsetpath(uniquecollection, uniquestring, metaitem) } return uniquecollection From a342a0f482410c9eb50f6729267e14baf9c60066 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 12:40:42 +0000 Subject: [PATCH 23/66] Alter release process to handle new meta walker info --- release/do.groovy | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/release/do.groovy b/release/do.groovy index 2f175ea..8a2ea61 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -112,10 +112,10 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde // Copy relevant artifacts to temp folder summaryappend("Artifacts: ") def boolean result = true - for (artifactfilter in buildinfo.meta.releaseinfo.releaseitems) { + for (artifactfilter in buildinfo.metainfo.releaseinfo.releaseitems) { def filterpath = artifactfilter - if (buildinfo.offsetpath) { - filterpath = buildinfo.offsetpath + '/' + artifactfilter + if (buildinfo.accumulatedpath) { + filterpath = buildinfo.accumulatedpath + '/' + artifactfilter } // Copy relevant artifacts to temp folder echo "Copying artifacts: ${filterpath} to ${tempfolder}" @@ -136,7 +136,7 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde } if (result) { // Move relevant artifacts from temp folder to release position - def originalrootdir = tempfolder + "/" + buildinfo.offsetpath + def originalrootdir = tempfolder + "/" + buildinfo.accumulatedpath dir(originalrootdir) { sh("mv * ${repofolder}") } @@ -375,7 +375,7 @@ def gitrelease(buildmeta, previousreleasemeta, String releaserepo, String source } def releasecomponent(toplevelbuildmeta, buildinfo, String otherreleasetags, String dryrunpush) { - def buildmeta = buildinfo.meta + def buildmeta = buildinfo.metainfo def uriconverted = gh.uniquereporootname(buildmeta.gitinfo.remoteurl) def String uniquefolder = "${buildmeta.productinfo.productname}_${buildmeta.productinfo.subcomponentname}_${uriconverted}" def String uniquefolderforrepo = "${releaserepofolder}/${uniquefolder}" @@ -427,7 +427,7 @@ def releasehierarchy(String buildfolder, String metafolder, buildmeta, String ma for (key in componentReleaseInfo.keySet()) { def buildinfo = componentReleaseInfo[key] - if (!buildinfo.jenkinsbuildinfo.isFullBuild()) { + if (!buildinfo.metainfo.jenkinsbuildinfo.isFullBuild()) { error "The subcomponent: ${buildinfo.componentidentifier()} is not a full build (Some artifacts are missing)" } } From 206e0f30a1849f87fe8b302e224a06dd25cc4e52 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:10:08 +0000 Subject: [PATCH 24/66] Alter release process to handle new meta walker info --- release/do.groovy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/release/do.groovy b/release/do.groovy index 8a2ea61..a521427 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -118,14 +118,14 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde filterpath = buildinfo.accumulatedpath + '/' + artifactfilter } // Copy relevant artifacts to temp folder - echo "Copying artifacts: ${filterpath} to ${tempfolder}" + echo "Copying artifacts: Filter path: ${filterpath} to ${tempfolder} from job: ${toplevelbuildmeta.jenkinsbuildinfo.buildjobname} #${toplevelbuildmeta.jenkinsbuildinfo.buildnumber}" try { copyArtifacts( filter: filterpath, projectName: toplevelbuildmeta.jenkinsbuildinfo.buildjobname, selector: [ $class: 'ParameterizedBuildSelector', - parameterName: "${toplevelbuildmeta.jenkinsbuildinfo.buildnumber}" + parameterName: "${toplevelbuildmeta.jenkinsbuildinfo.buildnumber}" ], target: tempfolder ) @@ -138,7 +138,7 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde // Move relevant artifacts from temp folder to release position def originalrootdir = tempfolder + "/" + buildinfo.accumulatedpath dir(originalrootdir) { - sh("mv * ${repofolder}") + sh("mv -v * ${repofolder}") } } summaryappend("${artifactfilter},") From 0b057d0a0e748898aa869ade3f03d3c762c3e349 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:26:48 +0000 Subject: [PATCH 25/66] Alter release process to handle new meta walker info --- release/do.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/release/do.groovy b/release/do.groovy index a521427..ca7b84e 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -134,6 +134,7 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde result = false summaryappend("Does not exist:") } + error("Debugging") if (result) { // Move relevant artifacts from temp folder to release position def originalrootdir = tempfolder + "/" + buildinfo.accumulatedpath From 2fe1414c19ccdbe105575df964dfc62b71d256ea Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:30:57 +0000 Subject: [PATCH 26/66] Alter release process to handle new meta walker info --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index ca7b84e..d5b43ed 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -134,7 +134,6 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde result = false summaryappend("Does not exist:") } - error("Debugging") if (result) { // Move relevant artifacts from temp folder to release position def originalrootdir = tempfolder + "/" + buildinfo.accumulatedpath @@ -143,6 +142,7 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde } } summaryappend("${artifactfilter},") + error("Debugging") } return result } From af1c49958a82af57995d8e77b9d0723306ffad1a Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:34:51 +0000 Subject: [PATCH 27/66] Alter release process to handle new meta walker info --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index d5b43ed..8c25fc2 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -142,8 +142,8 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde } } summaryappend("${artifactfilter},") - error("Debugging") } + error("Debugging") return result } From 2f8ac675867242232ca2003c8866b3bf7c19743f Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:41:50 +0000 Subject: [PATCH 28/66] Alter release process to handle new meta walker info --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index 8c25fc2..e7d936d 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -143,7 +143,6 @@ def boolean getcomponentartifacts(toplevelbuildmeta, buildinfo, String repofolde } summaryappend("${artifactfilter},") } - error("Debugging") return result } @@ -359,6 +358,7 @@ def gitrelease(buildmeta, previousreleasemeta, String releaserepo, String source releasegitpush(dryrunpush) } } + error("Debugging") dir(sourcerepo) { def String srcbuildstamptag = buildmeta.globalreleasetag() def String buildsha = buildmeta.gitinfo.gitrevision From 8ccca6aa15ba6375c808f0c462a735a44162fac8 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 13:57:54 +0000 Subject: [PATCH 29/66] Alter release process to handle new meta walker info --- release/do.groovy | 1 - 1 file changed, 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index e7d936d..a521427 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -358,7 +358,6 @@ def gitrelease(buildmeta, previousreleasemeta, String releaserepo, String source releasegitpush(dryrunpush) } } - error("Debugging") dir(sourcerepo) { def String srcbuildstamptag = buildmeta.globalreleasetag() def String buildsha = buildmeta.gitinfo.gitrevision From 236aa6fe68c8f94dbc235ff95da4b436f3593b5a Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 14:11:41 +0000 Subject: [PATCH 30/66] Alter release process to handle new meta walker info --- release/do.groovy | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/release/do.groovy b/release/do.groovy index a521427..87eb9ae 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -412,13 +412,18 @@ def releasehierarchy(String buildfolder, String metafolder, buildmeta, String ma // Walk the meta information to a max depth, looking for components to release def componentReleaseInfoVersionUnique = buildmeta.releasewalkerversionunique(md, buildfolder, metafolder) - echo "Version unique components:" - def String versionuniquecomponent = "" + def String versionuniquecomponent = '' + def String versionwithpathscomponent = '' for (key in componentReleaseInfoVersionUnique.keySet()) { versionuniquecomponent += "${key}\n" + versionwithpathscomponent = "${key}: path: ${componentReleaseInfoVersionUnique[key].accumulatedpath} meta path: ${componentReleaseInfoVersionUnique[key].accumulatedmetapath}\n" } + echo 'Version unique components:' echo versionuniquecomponent + echo 'Version unique components with paths:' + echo versionwithpathscomponent + if (DO_INTEGRITY_CHECK == "true") { if (componentReleaseInfo.size() != componentReleaseInfoVersionUnique.size()) { error "There are 2 or more versions of the same component being used in this hierarchy: Is this correct? (If you ignore this issue, you will get an error much later because the system cannot tag 2 different commits of the associated source code with the same label)" From 9d4b6ecf836405b1e75247a29909f86cdddb98eb Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 14:13:12 +0000 Subject: [PATCH 31/66] Alter release process to handle new meta walker info --- release/do.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/do.groovy b/release/do.groovy index 87eb9ae..c61f1dd 100644 --- a/release/do.groovy +++ b/release/do.groovy @@ -416,7 +416,7 @@ def releasehierarchy(String buildfolder, String metafolder, buildmeta, String ma def String versionwithpathscomponent = '' for (key in componentReleaseInfoVersionUnique.keySet()) { versionuniquecomponent += "${key}\n" - versionwithpathscomponent = "${key}: path: ${componentReleaseInfoVersionUnique[key].accumulatedpath} meta path: ${componentReleaseInfoVersionUnique[key].accumulatedmetapath}\n" + versionwithpathscomponent += "${key}: path: ${componentReleaseInfoVersionUnique[key].accumulatedpath} meta path: ${componentReleaseInfoVersionUnique[key].accumulatedmetapath}\n" } echo 'Version unique components:' echo versionuniquecomponent From 29f666075f68d3769ac2149952d8f74859683eee Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 14:22:30 +0000 Subject: [PATCH 32/66] Alter release process to handle new meta walker info --- meta/folder.groovy | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index fb27e64..39b8d85 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1043,7 +1043,9 @@ class MetaInfo extends GISJsonSerialised { Map putwithshortestoffsetpath(Map releasemetacollection, String uniquestring, CollectedMeta metaitem) { if (releasemetacollection.containsKey(uniquestring)) { def existingentry = releasemetacollection[uniquestring] - if (existingentry.accumulatedpath.size() > metaitem.accumulatedpath.size()) { + def existingentrypathlength = existingentry.accumulatedpath.split('/').size() + def newentrypathlength = metaitem.accumulatedpath.split('/').size() + if (existingentrypathlength > newentrypathlength) { releasemetacollection.put(uniquestring, metaitem) } } else { From 5e1a008d8f043c3d0ad9309ed7a34734f742a078 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 15:12:33 +0000 Subject: [PATCH 33/66] Alter release process to handle new meta walker info --- check/do_meta.groovy | 6 +++--- differences/dometahierarchy.groovy | 8 ++++---- publish/do.groovy | 4 ++-- publish/publishitems.groovy | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/check/do_meta.groovy b/check/do_meta.groovy index 7bfe2d1..4b8a89e 100644 --- a/check/do_meta.groovy +++ b/check/do_meta.groovy @@ -52,8 +52,8 @@ def checkhierarchy(buildmeta, String maxdepth, String buildpathroot) { echo "All components:" def String componentinfo = "" for (entry in buildinfo) { - def name = entry.meta.componentversionuniqueidentifier() - def offsetpath = entry.offsetpath + def name = entry.metainfo.componentversionuniqueidentifier() + def offsetpath = entry.accumulatedpath def abspath = "${buildpathroot}/${offsetpath}" componentinfo += "Name: ${name} \t\t\t\tPath: ${offsetpath} \t\t\t\tFile exists in import: ${fileExists(abspath)}\n" } @@ -65,7 +65,7 @@ def checkhierarchy(buildmeta, String maxdepth, String buildpathroot) { def String versioncomponent = "" for (key in componentReleaseInfo.keySet()) { def buildinfo2 = componentReleaseInfo[key] - def offsetpath = buildinfo2.offsetpath + def offsetpath = buildinfo2.accumulatedpath def abspath = "${buildpathroot}/${offsetpath}" versioncomponent += "Key: ${key} \t\t\tPath: ${offsetpath} \t\t\tFile exists in import: ${fileExists(abspath)}\n" } diff --git a/differences/dometahierarchy.groovy b/differences/dometahierarchy.groovy index 6280960..40394d5 100644 --- a/differences/dometahierarchy.groovy +++ b/differences/dometahierarchy.groovy @@ -95,8 +95,8 @@ def showmetaitems(metaitems) { String info = '' for (key in metaitems.keySet()) { def relatedmetainfo = metaitems[key] - def offsetpath = relatedmetainfo.offsetpath - info += "Name: ${key}\t\t\t\tPath: ${offsetpath}\n" + def accumulatedpath = relatedmetainfo.accumulatedpath + info += "Name: ${key}\t\t\t\tPath: ${accumulatedpath}\n" } echo info } @@ -768,8 +768,8 @@ def compare(earlymetaitems, latermetaitems, key) { boolean result = true; echo "Collecting changes between early and later versions of component: ${key}" - def earlymeta = earlymetaitems[key].meta - def latermeta = latermetaitems[key].meta + def earlymeta = earlymetaitems[key].metainfo + def latermeta = latermetaitems[key].metainfo summaryappend("${earlymeta.productinfo.productname} ${earlymeta.productinfo.subcomponentname}: Changed: ") diff --git a/publish/do.groovy b/publish/do.groovy index 1b227f4..9f5bd21 100644 --- a/publish/do.groovy +++ b/publish/do.groovy @@ -60,7 +60,7 @@ gh = load("${autobuilder.commonscripts()}/versioncontrol/git.groovy") def getcomponentartifacts(releaseinfo, String repofolder, itempathstopublish) { summaryappend("Artifacts: ") - def releasemeta = releaseinfo.meta + def releasemeta = releaseinfo.metainfo def String componentURL = releasemeta.releaseinfo.releaserepoURL def String revision = "refs/tags/${releasemeta.buildstampinfo.buildstamp}_${releasemeta.jenkinsbuildinfo.buildnumber}" def publishableitems = releasemeta.publishableinfo @@ -113,7 +113,7 @@ def copydirectory(File dirFrom, File dirTo) { } def recallcomponent(String productline, releaseinfo, String softwarerelease, itempathstopublish) { - def releasemeta = releaseinfo.meta + def releasemeta = releaseinfo.metainfo def String uniquefolderforrepo = uniqueabsoluterreleasefolder(productline, releaserepofolder, softwarerelease, releasemeta) summaryappend("${releasemeta.productinfo.productname} ${releasemeta.productinfo.subcomponentname}: ") diff --git a/publish/publishitems.groovy b/publish/publishitems.groovy index 677970e..06e5fba 100644 --- a/publish/publishitems.groovy +++ b/publish/publishitems.groovy @@ -89,7 +89,7 @@ class PublishableItemsSelection { } def outputDescription(menuitems, releaseinfo) { - def meta = releaseinfo.meta + def meta = releaseinfo.metainfo for (publishableitem in meta.publishableinfo) { menuitems.add("${meta.productinfo.productname} ${meta.productinfo.subcomponentname} ${publishableitem.filepath}") @@ -97,7 +97,7 @@ class PublishableItemsSelection { } def outputSelection(menuitems, releaseinfo) { - def meta = releaseinfo.meta + def meta = releaseinfo.metainfo for (publishableitem in meta.publishableinfo) { menuitems.add("${meta.productinfo.productname}#${meta.productinfo.subcomponentname}#${publishableitem.filepath}") From 2a7e94b301eccd0dd89c159bf457a75768e1c436 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 16:30:27 +0000 Subject: [PATCH 34/66] Debug components --- meta/folder.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/folder.groovy b/meta/folder.groovy index 39b8d85..d5b6b7f 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1089,6 +1089,7 @@ class MetaInfo extends GISJsonSerialised { ] def walkresults = allrelatedmeta() for (dependentmetaitem in walkresults.metacollection) { + script.echo("Comparing: ${dependentmetaitem.metainfo.productinfo.productname} ${dependentmetaitem.metainfo.productinfo.subcomponentname}") if (dependentmetaitem.metainfo.productinfo.productname == productname && dependentmetaitem.metainfo.productinfo.subcomponentname == subcomponentname) { script.echo("Found matching component: ${dependentmetaitem.metainfo.globalreleasetag()}") From d945efb8b76503a38d106fbe4f270e7b8c17c5ef Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 16:53:24 +0000 Subject: [PATCH 35/66] Help the meta walker find the meta data for a child --- meta/folder.groovy | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index d5b6b7f..c3db541 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1029,9 +1029,9 @@ class MetaInfo extends GISJsonSerialised { return [ 'metacollection' : results.metacollection, 'comment': results.comment ] } - def allrelatedmeta() { + def allrelatedmeta(String metapath) { ArrayList metacollection = new ArrayList() - return walkrelated(metacollection) + return walkrelated(metacollection, '', 0, '', metapath) } ArrayList releasewalker(int maxdepth, String startpath = '', String startmetapath = '') { @@ -1082,12 +1082,12 @@ class MetaInfo extends GISJsonSerialised { return new MetaInfo(script) } - def findAssociatedMeta(String productname, String subcomponentname) { + def findAssociatedMeta(String parentmetapath, String productname, String subcomponentname) { def results = [ 'matchedmetaitem' : new CollectedMeta(this), 'matchfound' : false ] - def walkresults = allrelatedmeta() + def walkresults = allrelatedmeta(parentmetapath) for (dependentmetaitem in walkresults.metacollection) { script.echo("Comparing: ${dependentmetaitem.metainfo.productinfo.productname} ${dependentmetaitem.metainfo.productinfo.subcomponentname}") if (dependentmetaitem.metainfo.productinfo.productname == productname && From f554d5bd6ce258ed2f8623efc8d470b2ce0ef528 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 17:01:19 +0000 Subject: [PATCH 36/66] Help the meta walker find the meta data for a child --- import/importer.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/import/importer.groovy b/import/importer.groovy index 0e2ca17..8ed4263 100644 --- a/import/importer.groovy +++ b/import/importer.groovy @@ -342,12 +342,12 @@ def artifactimport(meta, } // Import the artifacts of a named child component found below parent meta's hierarchy -def artifactimport(meta, parentmeta, String childproduct, String childsubcomponent, importoptions, String destinationfolder) { +def artifactimport(meta, parentmeta, String parentmetapath, String childproduct, String childsubcomponent, importoptions, String destinationfolder) { // Import from parent meta def childmeta = meta.getNewMetaObject() def childmeta2 echo "Finding meta associated with child: Product: ${childproduct} Sub-component: ${childsubcomponent}" - def findresults = parentmeta.findAssociatedMeta(childproduct, childsubcomponent) + def findresults = parentmeta.findAssociatedMeta(parentmetapath, childproduct, childsubcomponent) if (findresults.matchfound) { childmeta = findresults.matchedmeta if (childmeta.releaseinfo.released) { From 16061cfcc6950dcd5f1cd43e3afc8bef707efd3f Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 17:11:49 +0000 Subject: [PATCH 37/66] Help the meta walker find the meta data for a child --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index c3db541..bffa75f 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1031,7 +1031,7 @@ class MetaInfo extends GISJsonSerialised { def allrelatedmeta(String metapath) { ArrayList metacollection = new ArrayList() - return walkrelated(metacollection, '', 0, '', metapath) + return walkrelated(metacollection, '', 0, '', "${metapath}/${METAFOLDERNAME}") } ArrayList releasewalker(int maxdepth, String startpath = '', String startmetapath = '') { From 40054880d4ab1a4a9acbc54d3d60fca9f62c4c76 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 17:39:58 +0000 Subject: [PATCH 38/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index bffa75f..2b84781 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1020,7 +1020,7 @@ class MetaInfo extends GISJsonSerialised { limiteddepth, maxdepth - 1) } - } else if (relatedmetainfo.format == '0.1') { + } else if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, gatheredpath, gatheredmetapath, limiteddepth, maxdepth - 1) } From d93eb4bc236d9be47c9082cc1fdcf17756d124fe Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 18:03:19 +0000 Subject: [PATCH 39/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 2b84781..1c85658 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -600,10 +600,12 @@ class MetaInfo extends GISJsonSerialised { abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { private String format + private String offsetpath - RelatedMetaInfo(script, format) { + RelatedMetaInfo(script, format, offsetpath) { super(script) this.format = format + this.offsetpath = offsetpath } abstract void deserialiseJson(rawmeta) @@ -612,15 +614,17 @@ class MetaInfo extends GISJsonSerialised { String format() { return format } + + String getoffsetpath() { + return offsetpath + } } class RelatedMetaInfo_v0_1 extends RelatedMetaInfo { - String offsetpath - MetaInfo meta + private MetaInfo meta RelatedMetaInfo_v0_1(script, offsetpath = "", MetaInfo meta = null) { - super(script, '0.1') - this.offsetpath = offsetpath + super(script, '0.1', offsetpath) this.meta = meta } @@ -638,16 +642,16 @@ class MetaInfo extends GISJsonSerialised { ] return data } + + String get } class RelatedMetaInfo_v0_2 extends RelatedMetaInfo { private String importpath - private String offsetpath RelatedMetaInfo_v0_2(script, importpath = "", offsetpath = "") { - super(script, '0.2') + super(script, '0.2', offsetpath) this.importpath = importpath - this.offsetpath = offsetpath } void deserialiseJson(rawmeta) { @@ -1009,6 +1013,7 @@ class MetaInfo extends GISJsonSerialised { results.metacollection.add(new CollectedMeta(this, gatheredpath, gatheredmetapath)) results.comment += "${level} ".padRight(level * 4) + globalreleasetag() + '\n' for (relatedmetainfo in associatedmeta) { + script.echo("Related meta info: ${relatedmetainfo.offsetpath} format: ${relatedmetainfo.format}") if (relatedmetainfo.format == '0.2') { def childmetainfo = openchildmeta(gatheredpath, gatheredmetapath, relatedmetainfo) if (childmetainfo.imported) { From f09c84e5ec6404478eb92ae21c0ed0ad9e0d883e Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 18:13:50 +0000 Subject: [PATCH 40/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 1c85658..7dd4521 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -600,7 +600,7 @@ class MetaInfo extends GISJsonSerialised { abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { private String format - private String offsetpath + protected String offsetpath RelatedMetaInfo(script, format, offsetpath) { super(script) From f44dc09dab4eb08b89c14298c0cc9032dd3ed355 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 18:28:34 +0000 Subject: [PATCH 41/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 7dd4521..cccc456 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -600,7 +600,7 @@ class MetaInfo extends GISJsonSerialised { abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { private String format - protected String offsetpath + private String offsetpath RelatedMetaInfo(script, format, offsetpath) { super(script) @@ -618,6 +618,10 @@ class MetaInfo extends GISJsonSerialised { String getoffsetpath() { return offsetpath } + + void setoffsetoffsetpath(String offsetpath) { + this.offsetpath = offsetpath + } } class RelatedMetaInfo_v0_1 extends RelatedMetaInfo { @@ -629,7 +633,7 @@ class MetaInfo extends GISJsonSerialised { } void deserialiseJson(rawmeta) { - offsetpath = rawmeta['offsetpath'] + setoffsetoffsetpath(rawmeta['offsetpath']) meta = new MetaInfo(script) meta.deserialiseJson(rawmeta['meta']) } @@ -637,7 +641,7 @@ class MetaInfo extends GISJsonSerialised { LinkedHashMap serialisationdata() { def data = [ 'format' : format, - 'offsetpath' : offsetpath, + 'offsetpath' : getoffsetpath(), 'meta' : meta.serialisationdata(), ] return data @@ -656,13 +660,13 @@ class MetaInfo extends GISJsonSerialised { void deserialiseJson(rawmeta) { //format = rawmeta['format'] - offsetpath = rawmeta['offsetpath'] + setoffsetoffsetpath(rawmeta['offsetpath']) } LinkedHashMap serialisationdata() { def data = [ 'format' : format, - 'offsetpath' : offsetpath, + 'offsetpath' : getoffsetpath(), ] return data } From cd43ecf33aba1e6c91e492ac0984cc1b4069620e Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Fri, 17 Dec 2021 18:37:18 +0000 Subject: [PATCH 42/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index cccc456..712795b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -600,7 +600,7 @@ class MetaInfo extends GISJsonSerialised { abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { private String format - private String offsetpath + String offsetpath RelatedMetaInfo(script, format, offsetpath) { super(script) From 6e3c993d3e0c3f49f6f768a585c4a9864b09d4aa Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 18:02:11 +0000 Subject: [PATCH 43/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 712795b..0b6128b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -600,32 +600,26 @@ class MetaInfo extends GISJsonSerialised { abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { private String format - String offsetpath RelatedMetaInfo(script, format, offsetpath) { super(script) this.format = format this.offsetpath = offsetpath } - - abstract void deserialiseJson(rawmeta) - abstract LinkedHashMap serialisationdata() String format() { return format } - String getoffsetpath() { - return offsetpath - } - - void setoffsetoffsetpath(String offsetpath) { - this.offsetpath = offsetpath - } + abstract void deserialiseJson(rawmeta) + abstract LinkedHashMap serialisationdata() + abstract String getoffsetpath() + abstract void setoffsetpath(String offsetpath) } class RelatedMetaInfo_v0_1 extends RelatedMetaInfo { private MetaInfo meta + private String offsetpath RelatedMetaInfo_v0_1(script, offsetpath = "", MetaInfo meta = null) { super(script, '0.1', offsetpath) @@ -633,7 +627,7 @@ class MetaInfo extends GISJsonSerialised { } void deserialiseJson(rawmeta) { - setoffsetoffsetpath(rawmeta['offsetpath']) + setoffsetpath(rawmeta['offsetpath']) meta = new MetaInfo(script) meta.deserialiseJson(rawmeta['meta']) } @@ -647,11 +641,18 @@ class MetaInfo extends GISJsonSerialised { return data } - String get + String getoffsetpath() { + return offsetpath + } + + void setoffsetpath(String offsetpath) { + this.offsetpath = offsetpath + } } class RelatedMetaInfo_v0_2 extends RelatedMetaInfo { private String importpath + private String offsetpath RelatedMetaInfo_v0_2(script, importpath = "", offsetpath = "") { super(script, '0.2', offsetpath) @@ -660,7 +661,7 @@ class MetaInfo extends GISJsonSerialised { void deserialiseJson(rawmeta) { //format = rawmeta['format'] - setoffsetoffsetpath(rawmeta['offsetpath']) + setoffsetpath(rawmeta['offsetpath']) } LinkedHashMap serialisationdata() { @@ -670,6 +671,14 @@ class MetaInfo extends GISJsonSerialised { ] return data } + + String getoffsetpath() { + return offsetpath + } + + void setoffsetpath(String offsetpath) { + this.offsetpath = offsetpath + } } private ProductInfo productinfo From 7e63a317c07b99a77ac76e3f3875f9601ee78388 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 18:21:30 +0000 Subject: [PATCH 44/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 0b6128b..76dae26 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -599,16 +599,11 @@ class MetaInfo extends GISJsonSerialised { } abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { - private String format + String format - RelatedMetaInfo(script, format, offsetpath) { + RelatedMetaInfo(script, format) { super(script) this.format = format - this.offsetpath = offsetpath - } - - String format() { - return format } abstract void deserialiseJson(rawmeta) @@ -622,7 +617,8 @@ class MetaInfo extends GISJsonSerialised { private String offsetpath RelatedMetaInfo_v0_1(script, offsetpath = "", MetaInfo meta = null) { - super(script, '0.1', offsetpath) + super(script, '0.1') + this.offsetpath = offsetpath this.meta = meta } @@ -655,8 +651,9 @@ class MetaInfo extends GISJsonSerialised { private String offsetpath RelatedMetaInfo_v0_2(script, importpath = "", offsetpath = "") { - super(script, '0.2', offsetpath) + super(script, '0.2') this.importpath = importpath + this.offsetpath = offsetpath } void deserialiseJson(rawmeta) { From 95506b8d8a6f045ce727e5a6c6c1c85f33b63f3d Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 18:26:02 +0000 Subject: [PATCH 45/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 76dae26..fc1e072 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -595,7 +595,8 @@ class MetaInfo extends GISJsonSerialised { interface IRelatedMetaInfo { abstract void deserialiseJson(rawmeta) abstract LinkedHashMap serialisationdata() - abstract String format() + abstract String getoffsetpath() + abstract void setoffsetpath(String offsetpath) } abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { From 25938cefe32f899ef876546625fe6688d7381d4c Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 18:34:36 +0000 Subject: [PATCH 46/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 4 ---- 1 file changed, 4 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index fc1e072..7016b0b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -595,8 +595,6 @@ class MetaInfo extends GISJsonSerialised { interface IRelatedMetaInfo { abstract void deserialiseJson(rawmeta) abstract LinkedHashMap serialisationdata() - abstract String getoffsetpath() - abstract void setoffsetpath(String offsetpath) } abstract class RelatedMetaInfo extends GISJsonSerialised implements IRelatedMetaInfo { @@ -609,8 +607,6 @@ class MetaInfo extends GISJsonSerialised { abstract void deserialiseJson(rawmeta) abstract LinkedHashMap serialisationdata() - abstract String getoffsetpath() - abstract void setoffsetpath(String offsetpath) } class RelatedMetaInfo_v0_1 extends RelatedMetaInfo { From c76a1d68e51ad427a8f55871f93d50a2f299656e Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 18:51:19 +0000 Subject: [PATCH 47/66] Handle v0.1 imported associated meta --- meta/folder.groovy | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 7016b0b..1919d1b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -620,7 +620,7 @@ class MetaInfo extends GISJsonSerialised { } void deserialiseJson(rawmeta) { - setoffsetpath(rawmeta['offsetpath']) + offsetpath = rawmeta['offsetpath'] meta = new MetaInfo(script) meta.deserialiseJson(rawmeta['meta']) } @@ -628,19 +628,11 @@ class MetaInfo extends GISJsonSerialised { LinkedHashMap serialisationdata() { def data = [ 'format' : format, - 'offsetpath' : getoffsetpath(), + 'offsetpath' : offsetpath, 'meta' : meta.serialisationdata(), ] return data } - - String getoffsetpath() { - return offsetpath - } - - void setoffsetpath(String offsetpath) { - this.offsetpath = offsetpath - } } class RelatedMetaInfo_v0_2 extends RelatedMetaInfo { @@ -655,24 +647,16 @@ class MetaInfo extends GISJsonSerialised { void deserialiseJson(rawmeta) { //format = rawmeta['format'] - setoffsetpath(rawmeta['offsetpath']) + offsetpath = rawmeta['offsetpath'] } LinkedHashMap serialisationdata() { def data = [ 'format' : format, - 'offsetpath' : getoffsetpath(), + 'offsetpath' : offsetpath, ] return data } - - String getoffsetpath() { - return offsetpath - } - - void setoffsetpath(String offsetpath) { - this.offsetpath = offsetpath - } } private ProductInfo productinfo From 670d7b22abadc922ada2f8e80538c7a3ada56661 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 19:22:20 +0000 Subject: [PATCH 48/66] Handle v0.1 imported associated meta --- import/importer.groovy | 2 +- meta/folder.groovy | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/import/importer.groovy b/import/importer.groovy index 8ed4263..39b31c6 100644 --- a/import/importer.groovy +++ b/import/importer.groovy @@ -349,7 +349,7 @@ def artifactimport(meta, parentmeta, String parentmetapath, String childproduct, echo "Finding meta associated with child: Product: ${childproduct} Sub-component: ${childsubcomponent}" def findresults = parentmeta.findAssociatedMeta(parentmetapath, childproduct, childsubcomponent) if (findresults.matchfound) { - childmeta = findresults.matchedmeta + childmeta = findresults.matchedmetaitem.metainfo if (childmeta.releaseinfo.released) { importoptions.releaserepo(childmeta.releaseinfo.releaserepoURL, childmeta.releasetag()) } else { diff --git a/meta/folder.groovy b/meta/folder.groovy index 1919d1b..e2a4cbd 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1018,7 +1018,13 @@ class MetaInfo extends GISJsonSerialised { } } else if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta - results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, gatheredpath, gatheredmetapath, limiteddepth, maxdepth - 1) + results = othermeta.walkrelated_v0_1(results.metacollection, + results.comment, + level + 1, + gatheredpath, + gatheredmetapath, + limiteddepth, + maxdepth - 1) } } } From 8e53968fbdfa588507b4d93c5a7f96e30d6077b6 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 20:38:30 +0000 Subject: [PATCH 49/66] Type parameters to archive method --- artifacts/archiver.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/artifacts/archiver.groovy b/artifacts/archiver.groovy index 78bee55..bafba02 100644 --- a/artifacts/archiver.groovy +++ b/artifacts/archiver.groovy @@ -6,7 +6,7 @@ enum Store { this.JENKINS = Store.JENKINS this.ARTIFACTSERVER = Store.JENKINS -def archive(meta, artifactlist, Store store = JENKINS ) { +def archive(MetaInfo meta, String artifactlist, Store store = JENKINS) { echo "Archiving artifacts to store: ${store}" meta.copyrelatedmeta() if (store == JENKINS) { From 1a111411353902deb9fc6ba76824559c501a2a4e Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sat, 18 Dec 2021 21:03:34 +0000 Subject: [PATCH 50/66] Type parameters to archive method --- meta/folder.groovy | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index e2a4cbd..9ddeb7c 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -872,10 +872,10 @@ class MetaInfo extends GISJsonSerialised { return METAFOLDERNAME } - String generateartifacts(ArrayList releasedfromhere = new ArrayList(), // These items are recorded in meta as released from here - ArrayList releasedfromsubmeta = new ArrayList(), // These items are not recorded in meta as released from here - String metafilepath ="${METAFOLDERNAME}/${METAFILENAME}" - ) { + def String generateartifacts(ArrayList releasedfromhere = new ArrayList(), // These items are recorded in meta as released from here + ArrayList releasedfromsubmeta = new ArrayList(), // These items are not recorded in meta as released from here + String metafilepath ="${METAFOLDERNAME}/${METAFILENAME}" + ) { def String artifactlist = METAARTIFACTS releaseinfo.addReleaseItem(METAARTIFACTS) for (releaseitem in releasedfromhere) { From 0a0df4d88a2f7608002bb06ba2d21adc851017a7 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 13:23:20 +0000 Subject: [PATCH 51/66] Load module before cleaning --- copy/all.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/copy/all.groovy b/copy/all.groovy index 9b95eb6..0b7d862 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -54,6 +54,7 @@ pipeline { stage('Archiving artifacts') { steps { script { + artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") def includes = '**/*' def excludes = "${IMPORTS}/*" echo "Archiving artifacts: Includes: ${includes} Excludes: ${excludes}" @@ -65,7 +66,6 @@ pipeline { 'autobuild', ] cleaner.clean(cleanfolders) - artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") artifactarchiver.archive(artifacts: includes) } } From ab0d724399e4f476f584af9bfab18b40ba60c184 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 13:39:47 +0000 Subject: [PATCH 52/66] Load module before cleaning --- copy/all.groovy | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/copy/all.groovy b/copy/all.groovy index 0b7d862..920c80b 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -54,19 +54,15 @@ pipeline { stage('Archiving artifacts') { steps { script { - artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") def includes = '**/*' def excludes = "${IMPORTS}/*" echo "Archiving artifacts: Includes: ${includes} Excludes: ${excludes}" - // This does not work: artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") - // This does not work: artifactarchiver.archive(artifacts: includes, excludes: excludes) - // so cleanfolders = [ IMPORTS, 'autobuild', ] cleaner.clean(cleanfolders) - artifactarchiver.archive(artifacts: includes) + archiveArtifacts(artifacts: includes) } } } From 07a8a9d6a3059f250b058b7cf1e41e97dae7e625 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 18:21:23 +0000 Subject: [PATCH 53/66] Use indirect artifact archiver --- copy/all.groovy | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/copy/all.groovy b/copy/all.groovy index 920c80b..518f593 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -54,15 +54,19 @@ pipeline { stage('Archiving artifacts') { steps { script { - def includes = '**/*' + def artifacts = ['**/*'] + def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") + def artifactlist = meta.generateartifacts(artifacts) def excludes = "${IMPORTS}/*" - echo "Archiving artifacts: Includes: ${includes} Excludes: ${excludes}" + echo "Archiving artifacts: Includes: ${artifacts} Excludes: ${excludes}" + cleanfolders = [ IMPORTS, 'autobuild', ] cleaner.clean(cleanfolders) - archiveArtifacts(artifacts: includes) + + artifactarchiver.archive(meta, artifactlist) } } } From 6b35583fd2565683a197829f481c5521aef0af11 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 21:13:30 +0000 Subject: [PATCH 54/66] Use clean while moving imported info --- copy/all.groovy | 31 +++++++++++-------------------- copy/logic.groovy | 39 +++++++++++++++++++++++++-------------- 2 files changed, 36 insertions(+), 34 deletions(-) diff --git a/copy/all.groovy b/copy/all.groovy index 518f593..aab479c 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -5,6 +5,8 @@ pipeline { steps { script { meta = load("${WORKSPACE}/autobuild/Common_scripts/autobuilder.groovy").startnonbuild(this) + + importer = load("${autobuilder.commonscripts()}/import/importer.groovy") } } } @@ -23,7 +25,6 @@ pipeline { stage('Import source artifacts') { steps { script { - importer = load("${autobuilder.commonscripts()}/import/importer.groovy") def copyoptions = importer.getNewImportOptions() copyoptions.source( SOURCE_ARTIFACT_LOCATION, @@ -37,9 +38,14 @@ pipeline { } } } - stage('Copy source artifacts') { + stage('Archiving artifacts') { steps { script { + def artifactlist = meta.generateartifacts(['**/*']) + def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") + + cleaner.clean(['meta', 'autobuild']) + dir(IMPORTS) { fileOperations([ fileCopyOperation(excludes: '', @@ -48,23 +54,8 @@ pipeline { targetLocation: WORKSPACE) ]) } - } - } - } - stage('Archiving artifacts') { - steps { - script { - def artifacts = ['**/*'] - def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") - def artifactlist = meta.generateartifacts(artifacts) - def excludes = "${IMPORTS}/*" - echo "Archiving artifacts: Includes: ${artifacts} Excludes: ${excludes}" - - cleanfolders = [ - IMPORTS, - 'autobuild', - ] - cleaner.clean(cleanfolders) + + cleaner.clean([IMPORTS]) artifactarchiver.archive(meta, artifactlist) } @@ -85,4 +76,4 @@ pipeline { echo 'Succeeded build' } } -} \ No newline at end of file +} diff --git a/copy/logic.groovy b/copy/logic.groovy index 0a28a22..bf90a71 100644 --- a/copy/logic.groovy +++ b/copy/logic.groovy @@ -13,22 +13,25 @@ pipeline { stage('Clean exports') { steps { script { - env.LOGICDEST = "${WORKSPACE}/logic" + LOGICDEST = 'logic' cleanfolders = [ LOGICDEST, - "${WORKSPACE}/embedded_logic", ] cleaner = load("${autobuilder.commonscripts()}/clean/clean.groovy") cleaner.clean(cleanfolders) } } } - stage('Copying logic artifacts') { + stage('Import source artifacts') { steps { script { - sh('env') def logicoptions = importer.getNewImportOptions() - logicoptions.source(LOGIC_ARTIFACT_LOCATION, LOGIC_ARTIFACT_PROJECT, LOGIC_ARTIFACT_BUILD_SELECTOR, LOGIC_ARTIFACT_RELEASE_REPO, LOGIC_ARTIFACT_RELEASE_REVISION) + logicoptions.source( + LOGIC_ARTIFACT_LOCATION, + LOGIC_ARTIFACT_PROJECT, + LOGIC_ARTIFACT_BUILD_SELECTOR, + LOGIC_ARTIFACT_RELEASE_REPO, + LOGIC_ARTIFACT_RELEASE_REVISION) importer.artifactimport(meta, logicoptions, LOGICDEST) } } @@ -36,14 +39,22 @@ pipeline { stage('Archiving artifacts') { steps { script { - def artifactlist = meta.generateartifacts(["embedded_logic/**"]) - sh """ - rm -v -rf meta - # The following is removing a deprecated folder - rm -v -rf diff - mv -v "logic"/* . - """ - artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") + def artifactlist = meta.generateartifacts(['**/*']) + def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") + + cleaner.clean(['meta', 'autobuild']) + + dir(LOGICDEST) { + fileOperations([ + fileCopyOperation(excludes: '', + flattenFiles: false, + includes: '**/*', + targetLocation: WORKSPACE) + ]) + } + + cleaner.clean([LOGICDEST]) + artifactarchiver.archive(meta, artifactlist) } } @@ -63,4 +74,4 @@ pipeline { echo 'Succeeded build' } } -} \ No newline at end of file +} From c3c7b802938939e255c81b15aa33c72fea169da0 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 21:43:27 +0000 Subject: [PATCH 55/66] Use clean while moving imported info --- copy/all.groovy | 2 ++ 1 file changed, 2 insertions(+) diff --git a/copy/all.groovy b/copy/all.groovy index aab479c..37a47e6 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -45,6 +45,8 @@ pipeline { def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") cleaner.clean(['meta', 'autobuild']) + + error('Debugging') dir(IMPORTS) { fileOperations([ From a06ac842b9a4ca4c03469eac9a7d56e3c6bbcf4d Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 21:45:33 +0000 Subject: [PATCH 56/66] Use clean while moving imported info --- copy/all.groovy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/copy/all.groovy b/copy/all.groovy index 37a47e6..486a627 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -45,8 +45,6 @@ pipeline { def artifactarchiver = load("${autobuilder.commonscripts()}/artifacts/archiver.groovy") cleaner.clean(['meta', 'autobuild']) - - error('Debugging') dir(IMPORTS) { fileOperations([ @@ -57,6 +55,7 @@ pipeline { ]) } + error('Debugging') cleaner.clean([IMPORTS]) artifactarchiver.archive(meta, artifactlist) From d7893d9160ac5b0388a7f56f55a447ff05b67021 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Sun, 19 Dec 2021 21:53:41 +0000 Subject: [PATCH 57/66] Use clean while moving imported info --- copy/all.groovy | 1 - 1 file changed, 1 deletion(-) diff --git a/copy/all.groovy b/copy/all.groovy index 486a627..aab479c 100644 --- a/copy/all.groovy +++ b/copy/all.groovy @@ -55,7 +55,6 @@ pipeline { ]) } - error('Debugging') cleaner.clean([IMPORTS]) artifactarchiver.archive(meta, artifactlist) From c9eb0c698c80a7e8c3c20cc1f9b3b10bbdc5e0f4 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 13:52:31 +0000 Subject: [PATCH 58/66] Don't create folders for imported artifacts that don't have meta --- meta/folder.groovy | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 9ddeb7c..6e6767b 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -825,16 +825,15 @@ class MetaInfo extends GISJsonSerialised { if (script.fileExists(importedmetafile)) { script.echo("Deserialising meta at file: ${importedmetafile} (destpath: ${destpath})") mi.deserialiseJson(importedmetafile) + + RelatedMetaInfo rmi = new RelatedMetaInfo_v0_2(script, importedmetafile, adjustedpath) + if (appendtoparentmeta) { + associatedmeta.add(rmi) + } } else { script.echo("Could not deserialise meta at file: ${importedmetafile} (destpath: ${destpath})- Does not exist") mi.addConfigurationInfo('', givenRepo, givenRevision, givenSHA) } - - RelatedMetaInfo rmi = new RelatedMetaInfo_v0_2(script, importedmetafile, adjustedpath) - if (appendtoparentmeta) { - associatedmeta.add(rmi) - } - return mi } From 01d66c2d893609b513a78f7d75dedb7ac6820d99 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 14:47:22 +0000 Subject: [PATCH 59/66] Don't create folders for imported artifacts that don't have meta --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 6e6767b..f43237c 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -832,7 +832,7 @@ class MetaInfo extends GISJsonSerialised { } } else { script.echo("Could not deserialise meta at file: ${importedmetafile} (destpath: ${destpath})- Does not exist") - mi.addConfigurationInfo('', givenRepo, givenRevision, givenSHA) + addConfigurationInfo('', givenRepo, givenRevision, givenSHA) } return mi } From d3e5eb91acf81b01723fbc42111e1321b6f92461 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 15:55:07 +0000 Subject: [PATCH 60/66] Correct build integrity checking --- meta/folder.groovy | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index f43237c..96a37f8 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1030,9 +1030,11 @@ class MetaInfo extends GISJsonSerialised { return [ 'metacollection' : results.metacollection, 'comment': results.comment ] } - def allrelatedmeta(String metapath) { + def allrelatedmeta(String metapath = '') { ArrayList metacollection = new ArrayList() - return walkrelated(metacollection, '', 0, '', "${metapath}/${METAFOLDERNAME}") + + def startmetapath = (metapath == '' ? METAFOLDERNAME : "${metapath}/${METAFOLDERNAME}") + return walkrelated(metacollection, '', 0, '', startmetapath) } ArrayList releasewalker(int maxdepth, String startpath = '', String startmetapath = '') { From 09b3c99bfe52c44397a813d8373cc80fa7d64bfd Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 16:46:50 +0000 Subject: [PATCH 61/66] Correct initial gather paths --- meta/folder.groovy | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 96a37f8..e6bd3c5 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -923,18 +923,8 @@ class MetaInfo extends GISJsonSerialised { def openchildmeta(String gatheredpath, String gatheredmetapath, RelatedMetaInfo relatedmetainfo) { def MetaInfo mi = new MetaInfo(script) - def String nextgatheredpath - if (gatheredpath == '') { - nextgatheredpath = "${relatedmetainfo.offsetpath}" - } else { - nextgatheredpath = "${gatheredpath}/${relatedmetainfo.offsetpath}" - } - def String nextgatheredmetapath - if (gatheredmetapath == '') { - nextgatheredmetapath = "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" - } else { - nextgatheredmetapath = "${gatheredmetapath}/${relatedmetainfo.offsetpath}" - } + def String nextgatheredpath = (gatheredpath == '' ? relatedmetainfo.offsetpath : "${gatheredpath}/${relatedmetainfo.offsetpath}") + def String nextgatheredmetapath = (gatheredmetapath == '' ? "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" : "${gatheredmetapath}/${relatedmetainfo.offsetpath}" def importedmetafile = "${nextgatheredmetapath}/${METAFILENAME}" def boolean imported if (script.fileExists(importedmetafile)) { @@ -972,11 +962,13 @@ class MetaInfo extends GISJsonSerialised { for (relatedmetainfo in associatedmeta) { if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta + def String nextgatheredpath = (gatheredpath == '' ? relatedmetainfo.offsetpath : "${gatheredpath}/${relatedmetainfo.offsetpath}") + def String nextgatheredmetapath = (gatheredmetapath == '' ? gatheredmetapath : "${gatheredmetapath}/${relatedmetainfo.offsetpath}") results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, - "${gatheredpath}/${relatedmetainfo.offsetpath}", - "${gatheredmetapath}/${relatedmetainfo.offsetpath}", + nextgatheredpath, + nextgatheredmetapath, limiteddepth, maxdepth - 1) } else { @@ -1032,9 +1024,7 @@ class MetaInfo extends GISJsonSerialised { def allrelatedmeta(String metapath = '') { ArrayList metacollection = new ArrayList() - - def startmetapath = (metapath == '' ? METAFOLDERNAME : "${metapath}/${METAFOLDERNAME}") - return walkrelated(metacollection, '', 0, '', startmetapath) + return walkrelated(metacollection, '', 0, '', metapath) } ArrayList releasewalker(int maxdepth, String startpath = '', String startmetapath = '') { From f171e520b7685d35acfd605b3f96dd99dc0cc946 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 16:47:52 +0000 Subject: [PATCH 62/66] Correct initial gather paths --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index e6bd3c5..aa1d673 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -924,7 +924,7 @@ class MetaInfo extends GISJsonSerialised { def MetaInfo mi = new MetaInfo(script) def String nextgatheredpath = (gatheredpath == '' ? relatedmetainfo.offsetpath : "${gatheredpath}/${relatedmetainfo.offsetpath}") - def String nextgatheredmetapath = (gatheredmetapath == '' ? "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" : "${gatheredmetapath}/${relatedmetainfo.offsetpath}" + def String nextgatheredmetapath = (gatheredmetapath == '' ? "${relatedmetainfo.offsetpath}/${METAFOLDERNAME}" : "${gatheredmetapath}/${relatedmetainfo.offsetpath}") def importedmetafile = "${nextgatheredmetapath}/${METAFILENAME}" def boolean imported if (script.fileExists(importedmetafile)) { From 6053dbc4a93c847070dfde3524cdc10a95413956 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 17:27:32 +0000 Subject: [PATCH 63/66] Correct initial gather paths --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index aa1d673..883e690 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -963,7 +963,7 @@ class MetaInfo extends GISJsonSerialised { if (!relatedmetainfo.format || relatedmetainfo.format == '0.1') { def MetaInfo othermeta = relatedmetainfo.meta def String nextgatheredpath = (gatheredpath == '' ? relatedmetainfo.offsetpath : "${gatheredpath}/${relatedmetainfo.offsetpath}") - def String nextgatheredmetapath = (gatheredmetapath == '' ? gatheredmetapath : "${gatheredmetapath}/${relatedmetainfo.offsetpath}") + def String nextgatheredmetapath = (gatheredmetapath == '' ? relatedmetainfo.offsetpath : "${gatheredmetapath}/${relatedmetainfo.offsetpath}") results = othermeta.walkrelated_v0_1(results.metacollection, results.comment, level + 1, From d5ecbe17d4948da2a8103046d68d269a938d7c8a Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 23:01:03 +0000 Subject: [PATCH 64/66] Add log --- import/importer.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/import/importer.groovy b/import/importer.groovy index 39b31c6..0e88a21 100644 --- a/import/importer.groovy +++ b/import/importer.groovy @@ -347,6 +347,7 @@ def artifactimport(meta, parentmeta, String parentmetapath, String childproduct, def childmeta = meta.getNewMetaObject() def childmeta2 echo "Finding meta associated with child: Product: ${childproduct} Sub-component: ${childsubcomponent}" + echo "From Parent meta identifier: ${parentmeta.componentidentifier} and parent meta path: ${parentmetapath}" def findresults = parentmeta.findAssociatedMeta(parentmetapath, childproduct, childsubcomponent) if (findresults.matchfound) { childmeta = findresults.matchedmetaitem.metainfo From af70f7e083ecdec2812ce86b19d3245368b13612 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 23:04:05 +0000 Subject: [PATCH 65/66] Add log --- import/importer.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/import/importer.groovy b/import/importer.groovy index 0e88a21..a35598c 100644 --- a/import/importer.groovy +++ b/import/importer.groovy @@ -347,7 +347,7 @@ def artifactimport(meta, parentmeta, String parentmetapath, String childproduct, def childmeta = meta.getNewMetaObject() def childmeta2 echo "Finding meta associated with child: Product: ${childproduct} Sub-component: ${childsubcomponent}" - echo "From Parent meta identifier: ${parentmeta.componentidentifier} and parent meta path: ${parentmetapath}" + echo "From Parent meta identifier: ${parentmeta.componentidentifier()} and parent meta path: ${parentmetapath}" def findresults = parentmeta.findAssociatedMeta(parentmetapath, childproduct, childsubcomponent) if (findresults.matchfound) { childmeta = findresults.matchedmetaitem.metainfo From 4b3e84c72d851b2ed499558d02b72dc26aa41f23 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Mon, 20 Dec 2021 23:14:41 +0000 Subject: [PATCH 66/66] Alter path to start finding --- import/importer.groovy | 2 +- meta/folder.groovy | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/import/importer.groovy b/import/importer.groovy index a35598c..8bb565a 100644 --- a/import/importer.groovy +++ b/import/importer.groovy @@ -347,7 +347,7 @@ def artifactimport(meta, parentmeta, String parentmetapath, String childproduct, def childmeta = meta.getNewMetaObject() def childmeta2 echo "Finding meta associated with child: Product: ${childproduct} Sub-component: ${childsubcomponent}" - echo "From Parent meta identifier: ${parentmeta.componentidentifier()} and parent meta path: ${parentmetapath}" + echo "From parent meta identifier: ${parentmeta.componentidentifier()} and parent meta path: ${parentmetapath}" def findresults = parentmeta.findAssociatedMeta(parentmetapath, childproduct, childsubcomponent) if (findresults.matchfound) { childmeta = findresults.matchedmetaitem.metainfo diff --git a/meta/folder.groovy b/meta/folder.groovy index 883e690..f72b502 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -1080,7 +1080,7 @@ class MetaInfo extends GISJsonSerialised { 'matchedmetaitem' : new CollectedMeta(this), 'matchfound' : false ] - def walkresults = allrelatedmeta(parentmetapath) + def walkresults = allrelatedmeta("${parentmetapath}/${METAFOLDERNAME}") for (dependentmetaitem in walkresults.metacollection) { script.echo("Comparing: ${dependentmetaitem.metainfo.productinfo.productname} ${dependentmetaitem.metainfo.productinfo.subcomponentname}") if (dependentmetaitem.metainfo.productinfo.productname == productname &&