From 9acab85d20426521d31cca1eee4ef5310318e8ca Mon Sep 17 00:00:00 2001 From: Damian Smith Date: Tue, 14 Aug 2018 12:56:58 +0100 Subject: [PATCH] HMBXR5601-395 sanitise the commit comment for control characters --- release_to_git/conditional_add.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release_to_git/conditional_add.py b/release_to_git/conditional_add.py index 1b90f34..8de947c 100644 --- a/release_to_git/conditional_add.py +++ b/release_to_git/conditional_add.py @@ -205,7 +205,8 @@ def gitAddCommitTagAll(versionNumber): # Git commit commitComment = versionNumber if "COMMIT_COMMENT" in os.environ : - commitComment = commitComment + ' :: ' + os.environ["COMMIT_COMMENT"] + import unicodedata + commitComment = commitComment + ' :: ' + "".join(ch for ch in os.environ["COMMIT_COMMENT"] if unicodedata.category(ch)[0]!="C") # Cleans up non printable characters print("git committing local repo: ", localRepoPath, " Comment: ", commitComment) spout = subprocess.check_output([gitExecutable, "commit", "-a", "-m", commitComment], stderr = subprocess.STDOUT) print("Result: ", spout.decode('utf-8'))