From b77403c92f93fcf6f729751cc39b3de5086d2ed3 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 17 Jun 2020 11:16:28 +0100 Subject: [PATCH 1/2] Remove redundant parameter --- meta/folder.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index f600155..4e7dc99 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -184,14 +184,14 @@ class BuildStampInfo extends GISJsonSerialised { script.echo("Build stamp now ${buildstamp}") } - void set(String buildstampprefix, int revision) { + void set(String buildstampprefix, int revision = 0) { buildstampprefix += buildstampprefix.endsWith('.') ? '' : '.' this.buildstampprefix = buildstampprefix this.buildstamp = buildstampprefix + "0" changerevision(revision) } - void set(String buildstampprefix, String revision) { + void set(String buildstampprefix, String revision = '0') { set(buildstampprefix, revision.toInteger()) } From 5559b50a78444bf359529bb3418e6d5b23e735e1 Mon Sep 17 00:00:00 2001 From: Dan Hawkins Date: Wed, 17 Jun 2020 11:19:22 +0100 Subject: [PATCH 2/2] Remove redundant parameter --- meta/folder.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/folder.groovy b/meta/folder.groovy index 4e7dc99..aac8b6c 100644 --- a/meta/folder.groovy +++ b/meta/folder.groovy @@ -184,7 +184,7 @@ class BuildStampInfo extends GISJsonSerialised { script.echo("Build stamp now ${buildstamp}") } - void set(String buildstampprefix, int revision = 0) { + void set(String buildstampprefix, int revision) { buildstampprefix += buildstampprefix.endsWith('.') ? '' : '.' this.buildstampprefix = buildstampprefix this.buildstamp = buildstampprefix + "0"