From 4eaced409288cd858b5d8484eb2ebc21144b79da Mon Sep 17 00:00:00 2001 From: seanmartinsmith <114885497+seanmartinsmith@users.noreply.github.com> Date: Fri, 8 May 2026 11:20:11 -0400 Subject: [PATCH] test(setup): use filepath.Join in TestGeminiSettingsPaths assertions (#3555) Test hardcoded forward-slash path literals against output from filepath.Join, so it failed on Windows even though the production code (geminiProjectSettingsPath, geminiGlobalSettingsPath) was correct. Matches the existing pattern from TestMuxProjectAgentsPath and TestMuxGlobalAgentsPath in the same package, which compare filepath.Join(...) on both sides. Fixes #3554 --- cmd/bd/setup/gemini_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/bd/setup/gemini_test.go b/cmd/bd/setup/gemini_test.go index 83f5948b9..19570ae09 100644 --- a/cmd/bd/setup/gemini_test.go +++ b/cmd/bd/setup/gemini_test.go @@ -468,12 +468,12 @@ func TestHasGeminiBeadsHooks(t *testing.T) { func TestGeminiSettingsPaths(t *testing.T) { projectPath := geminiProjectSettingsPath("/my/project") - if projectPath != "/my/project/.gemini/settings.json" { - t.Errorf("unexpected project path: %s", projectPath) + if want := filepath.Join("/my/project", ".gemini", "settings.json"); projectPath != want { + t.Errorf("project path = %q, want %q", projectPath, want) } globalPath := geminiGlobalSettingsPath("/home/user") - if globalPath != "/home/user/.gemini/settings.json" { - t.Errorf("unexpected global path: %s", globalPath) + if want := filepath.Join("/home/user", ".gemini", "settings.json"); globalPath != want { + t.Errorf("global path = %q, want %q", globalPath, want) } }