#7478 deleted the frozen 15-shard proxied and 20-shard embedded manifest blocks and refreshed most comments that described pr-risk.yml's retired fork/push jobs as still running. Finish the #7382 adoption follow-ups on what survived: the Close3/Close4 split is cited as #7173 (bd-ojckcg), and the remaining present-tense references to the legacy jobs (bazel.yml's embedded-lane rationale and cmd-dolt lane note, BUILD.bazel's socat note, TESTING.md's socat paragraph) now say the jobs are retired (bd-g2w5rp). bd-3lht (the hand-held 15-shard header round-trip) is moot: the block no longer exists. Comments and docs only; no shard assignment, workflow step or BUILD setting changes. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
parent
7838c4b449
commit
70b44da7cc
4 changed files with 15 additions and 14 deletions
6
.github/workflows/bazel.yml
vendored
6
.github/workflows/bazel.yml
vendored
|
|
@ -1372,8 +1372,8 @@ jobs:
|
|||
# scripts/ci/embedded_storage_test_durations.json -- up from an earlier,
|
||||
# smaller test surface's ~7-10k estimate) on one runner, several hours
|
||||
# per run on the pool whose job cap this track exists to relieve, and it
|
||||
# proves nothing pr-risk.yml's embedded jobs (which do run for forks) do
|
||||
# not.
|
||||
# proved nothing pr-risk.yml's embedded jobs (which ran for forks before
|
||||
# #7353 retired them) did not.
|
||||
#
|
||||
# Shard counts: storage (40): its tests are serial, so a shard's wall
|
||||
# time is the sum of its tests, and CI shards run ~1.3-1.6x the rbe-west
|
||||
|
|
@ -2422,7 +2422,7 @@ jobs:
|
|||
# integration-tagged cmd/bd suite (//cmd/bd:bd_dolt_server_test, 32
|
||||
# shards, the slowest tests pinned to 16 of them) against a hermetic dolt sql-server, i.e. the Dolt-gated cmd/bd
|
||||
# tests (TestCLI_*, TestInit*, the store-backed suites) that every other
|
||||
# lane and legacy job skips with BEADS_TEST_SKIP=dolt or leaves out of its
|
||||
# lane skips with BEADS_TEST_SKIP=dolt or leaves out of its
|
||||
# manifest; plus the differential regression suite
|
||||
# (//tests/regression:regression_test, 14 shards: the candidate
|
||||
# bd_for_tests against the catalog-pinned v0.49.6 release, formerly
|
||||
|
|
|
|||
|
|
@ -1583,7 +1583,7 @@ sh_test(
|
|||
"BEADS_TEST_REQUIRE_DOLT_CONTAINER": "1",
|
||||
# The external-unix / outage-matrix subtests bridge endpoints with
|
||||
# socat, which the workers have: fail rather than skip if it is
|
||||
# missing (requireSocat). The legacy GitHub lane leaves this unset.
|
||||
# missing (requireSocat). The retired GitHub lane left this unset.
|
||||
"BEADS_TEST_REQUIRE_SOCAT": "1",
|
||||
# The 4-vCPU runner shape: -test.parallel defaults to GOMAXPROCS, and
|
||||
# the job runs 4 tests at once, not one per worker core (39
|
||||
|
|
|
|||
|
|
@ -359,14 +359,14 @@ func TestProxiedServerCloseB(t *testing.T) {
|
|||
})
|
||||
}
|
||||
|
||||
// TestProxiedServerClose3 was split off TestProxiedServerClose (as
|
||||
// TestProxiedServerClose2 was before it) so that no single top-level suite
|
||||
// carries 23 bd-init subtests: that one parent alone cost ~2060
|
||||
// slot-seconds under -test.parallel=4 and pushed its 15-shard legacy shard
|
||||
// past go test's 15m timeout on every run (gastownhall/beads#7151). Those
|
||||
// 23 now sit in TestProxiedServerClose, TestProxiedServerCloseB,
|
||||
// TestProxiedServerClose3 and TestProxiedServerClose4. Its own second half
|
||||
// is TestProxiedServerClose4.
|
||||
// TestProxiedServerClose3 was split off TestProxiedServerClose in
|
||||
// gastownhall/beads#7173 (as TestProxiedServerClose2 was before it) so that
|
||||
// no single top-level suite carries 23 bd-init subtests: that one parent
|
||||
// alone cost ~2060 slot-seconds under -test.parallel=4 and pushed its shard
|
||||
// of the since-retired 15-shard legacy jobs past go test's 15m timeout on
|
||||
// every run. Those 23 now sit in TestProxiedServerClose,
|
||||
// TestProxiedServerCloseB, TestProxiedServerClose3 and
|
||||
// TestProxiedServerClose4. Its own second half is TestProxiedServerClose4.
|
||||
func TestProxiedServerClose3(t *testing.T) {
|
||||
requireSharedProxiedServer(t)
|
||||
t.Parallel()
|
||||
|
|
@ -512,7 +512,7 @@ func TestProxiedServerClose3(t *testing.T) {
|
|||
// all 12 of its bd-init subtests in one parent, whichever 15-shard legacy
|
||||
// shard hosted Close3 timed out in turn (6, then 1) while shard 5 dropped to
|
||||
// 5m, so the remaining weight is carried as two parents of six on two shards
|
||||
// (gastownhall/beads#7151).
|
||||
// (gastownhall/beads#7173).
|
||||
func TestProxiedServerClose4(t *testing.T) {
|
||||
requireSharedProxiedServer(t)
|
||||
t.Parallel()
|
||||
|
|
|
|||
|
|
@ -192,7 +192,8 @@ failure (per test and in every `TestMain`) instead of a skip; lanes that
|
|||
exist to run the Dolt suites set it. `BEADS_TEST_REQUIRE_SOCAT=1` does the
|
||||
same for the proxied subtests that bridge an external endpoint with `socat`
|
||||
(external-unix, the outage/reconnect matrix); `//cmd/bd:bd_proxied_test`
|
||||
sets it, and the legacy GitHub proxied jobs, which have no `socat`, do not.
|
||||
sets it; the legacy GitHub proxied jobs retired in #7353 had no `socat`
|
||||
and left it unset.
|
||||
|
||||
Under Bazel, `bazel test //... --config=doltserver` runs the Dolt-backed
|
||||
domain, uow, tracker, doctor/fix, protocol and testutil suites on the `local`
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue