From 73f2ab613b749a4e6f4ccd5894b3c63dfd8081d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?coffeegoddd=E2=98=95=EF=B8=8F=E2=9C=A8?= Date: Wed, 29 Apr 2026 16:35:16 -0700 Subject: [PATCH] /{cmd,internal}: maybe fix tool tip closed store bug --- cmd/bd/create.go | 7 +++++-- internal/storage/embeddeddolt/store.go | 7 +++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/cmd/bd/create.go b/cmd/bd/create.go index 6b56b6e27..a5f6e6019 100644 --- a/cmd/bd/create.go +++ b/cmd/bd/create.go @@ -393,8 +393,11 @@ var createCmd = &cobra.Command{ _ = store.Close() // Best effort cleanup on error path } - // Replace store for remainder of create operation - store = targetStore + // Replace store for remainder of create operation. + // Must use setStore to sync cmdCtx.Store — a bare `store = targetStore` + // leaves cmdCtx.Store pointing at the closed original, which causes + // "store is closed" in PostRun tip auto-commit (GH#tip-closed-bug). + setStore(targetStore) } // Check for conflicting flags diff --git a/internal/storage/embeddeddolt/store.go b/internal/storage/embeddeddolt/store.go index fbc900a04..445a7b336 100644 --- a/internal/storage/embeddeddolt/store.go +++ b/internal/storage/embeddeddolt/store.go @@ -53,6 +53,13 @@ type EmbeddedDoltStore struct { // errClosed is returned when a method is called after Close. var errClosed = errors.New("embeddeddolt: store is closed") +// IsClosed reports whether the store has been closed. Implements +// storage.LifecycleManager so that callers (e.g., maybeAutoCommit) can +// skip operations on a closed store without triggering errClosed. +func (s *EmbeddedDoltStore) IsClosed() bool { + return s.closed.Load() +} + // Option configures optional behavior for New. type Option func(*options)