ci(bazel): add advisory dolt-race shadow lane (item 5 phase 1) (#7464)
* ci(bazel): add advisory dolt-race shadow lane (item 5 phase 1) Add --config=dolt-race, the union of --config=doltserver and --config=doltserver-proxied with one tag filter for both tiers, and an advisory bazel-dolt-race job that runs it beside bazel-doltserver and bazel-proxied. The shadow measures one client per group of lanes against the two lanes it would replace before any cutover (item 5 slice A1a). The job runs in mode remote on pull_request and merge_group events only. It has job-level continue-on-error, no job or workflow_call output, and no gate names it, so it cannot change CI Gate or PR Risk Gate. Its ci-analytics step is copied verbatim with LANE=dolt-race, and rrc seeds the new config. Policy tests pin the config as the exact union of its members' lines (tag filter aside), the job's run modes and events, its advisory shape, the analytics lane map and the rrc command list. aquery shows every member target's TestRunner action (actionKey, argv, env, inputs, outputs) is unchanged under the union config. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): give the dolt-race shadow timeout headroom; fix gate-wait wording Review follow-up on the advisory bazel-dolt-race job (maintainer-city-c3, findings 1, 2 and 5): - Raise the job's timeout-minutes from 30 to 35. continue-on-error covers a failed or timed-out step, but not a job GitHub cancels at its own timeout, which could make the bazel call non-success and turn CI Gate red. TestBazelDoltRaceShadowIsAdvisory now reads both timeouts from the workflow and requires job >= test step + 10 (and a step timeout at all). - Correct the docs and comments: the shadow cannot fail the gate, but CI Gate still waits for it, because its needs on the bazel call completes only when every job in it has finished. - Correct the checks comment: check_testcases covers every target in the union, including the dolt-server tier its own lane never checked. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): bound every dolt-race shadow step; job timeout covers their sum Review follow-up (S1): a hang in any bazel-dolt-race step without a timeout would run into the job's own timeout, and a job GitHub cancels there is not covered by continue-on-error. Every step now has a timeout-minutes, and the job's timeout covers their sum: - checkout 5, rrc read 1, setup-bazel 10, flaky query 5, checks 3 each, test-log upload 3. The test step (25) and the analytics steps (3, 2) keep bazel-proxied's values; bazel-proxied sets no timeout on the others, so these bound them. - The step timeouts sum to 60 minutes, so the job timeout goes from 35 to 65. - TestBazelDoltRaceShadowIsAdvisory now requires a timeout on every step and job >= sum(step timeouts) + 5, read from the workflow, alongside the existing job >= test step + 10. Also cite the farm maintainer's confirmation of NativeLink 1.7.1's in-flight Execute dedupe in the job comment. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): keep dolt-race shadow timeout under the merge queue's Tighten the shadow's non-test step budgets so the job timeout (step sum + 5) is 55 minutes, and pin that it stays below the 60-minute merge queue check timeout: CI Gate waits for the shadow, so a hung shadow must not drop a group from the queue. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
8dbbe78e9a
commit
eb204363c9
12 changed files with 584 additions and 7 deletions
26
.bazelrc
26
.bazelrc
|
|
@ -161,6 +161,32 @@ test:doltserver-proxied --remote_download_regex=.*/test\.(log|xml)$
|
|||
# visible "Re-run failed jobs" retries it.
|
||||
test:doltserver-proxied --experimental_remote_cache_eviction_retries=0
|
||||
|
||||
# dolt-server + proxied union (item 5, Phase 1 shadow): bazel.yml's advisory
|
||||
# bazel-dolt-race job runs both tiers in one invocation, beside their own
|
||||
# lanes, to measure one client per group of lanes before any cutover. Exactly
|
||||
# the union of --config=doltserver's and --config=doltserver-proxied's lines,
|
||||
# with one tag filter naming both tiers
|
||||
# (scripts/bazel_dolt_race_shadow_test.go). Every other flag is the same in
|
||||
# both members or outside any action key for the other: the race build,
|
||||
# -test.parallel=4 and GO_TEST_WRAP_TESTV=1 are common; the eternal timeout
|
||||
# applies to no dolt-server target; the eviction retry count is what
|
||||
# doltserver already gets from --config=sole-run in mode remote, the only mode
|
||||
# the shadow runs in; test_summary, local_test_jobs and remote_download_regex
|
||||
# are not in any action key. So each member target's test action is
|
||||
# unchanged, and the two lanes' cached results carry over. The member configs
|
||||
# stay for make, developers and the member lanes.
|
||||
test:dolt-race --@rules_go//go/config:race
|
||||
test:dolt-race --test_tag_filters=dolt-server,dolt-server-proxied
|
||||
test:dolt-race --build_tests_only
|
||||
test:dolt-race --keep_going
|
||||
test:dolt-race --test_summary=terse
|
||||
test:dolt-race --test_timeout=-1,-1,-1,1200
|
||||
test:dolt-race --test_env=GO_TEST_WRAP_TESTV=1
|
||||
test:dolt-race --test_arg=-test.parallel=4
|
||||
test:dolt-race --local_test_jobs=4
|
||||
test:dolt-race --remote_download_regex=.*/test\.(log|xml)$
|
||||
test:dolt-race --experimental_remote_cache_eviction_retries=0
|
||||
|
||||
# Server-Dolt storage tier: PR Risk's "Test (Server Dolt Conformance)" and
|
||||
# "Test (Server Dolt Full Suite N/16)" jobs, as
|
||||
# //internal/storage/dolt:dolt_server_{conformance,full}_test
|
||||
|
|
|
|||
1
.github/scripts/rrc-lane-commands.txt
vendored
1
.github/scripts/rrc-lane-commands.txt
vendored
|
|
@ -9,6 +9,7 @@ test //... --config=embedded
|
|||
test //... --config=integration
|
||||
test //... --config=doltserver
|
||||
test //... --config=doltserver-proxied
|
||||
test //... --config=dolt-race
|
||||
test //... --config=doltserver-integration
|
||||
test //... --config=doltserver-cmd
|
||||
build --config=pure //cmd/bd:bd //cmd/bd:bd_test //internal/storage/embeddeddolt:embeddeddolt_test //internal/tracker:tracker_test
|
||||
|
|
|
|||
173
.github/workflows/bazel.yml
vendored
173
.github/workflows/bazel.yml
vendored
|
|
@ -46,7 +46,11 @@
|
|||
# only what the PR changed is built and tested on the runner, and it is
|
||||
# their only PR-time integration run (no legacy job runs it on PRs). Mode
|
||||
# local (rbe=off) still skips it. Direct runs (push to main,
|
||||
# workflow_dispatch, nightly.yml's call) gate nothing.
|
||||
# workflow_dispatch, nightly.yml's call) gate nothing. bazel-dolt-race (the
|
||||
# dolt-server + proxied union shadow, mode remote on PRs and merge groups
|
||||
# only) cannot fail the gate either: no output, job-level continue-on-error.
|
||||
# The gate still waits for it, as for every job of the call (see its comment
|
||||
# and engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md, "dolt-race Shadow").
|
||||
#
|
||||
# Execution mode, decided once by the rbe job (every other job needs it and
|
||||
# reads its outputs; none re-derives the condition) and passed to
|
||||
|
|
@ -1983,6 +1987,173 @@ jobs:
|
|||
JOB_STATUS: ${{ job.status }}
|
||||
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
|
||||
|
||||
# Item 5, Phase 1 (scripts/bazel_dolt_race_shadow_test.go): the advisory
|
||||
# shadow of a union lane. One `bazel test --config=dolt-race` runs the
|
||||
# dolt-server and proxied-server tiers together (.bazelrc: exactly the
|
||||
# union of --config=doltserver's and --config=doltserver-proxied's lines,
|
||||
# one tag filter for both), beside bazel-doltserver and bazel-proxied, so
|
||||
# one client per group of lanes can be compared with the two it would
|
||||
# replace (end time, runner minutes, test counts and results) before any
|
||||
# cutover. Each member target's test action key is unchanged, so the shadow
|
||||
# and the member lanes share cached results; and rbe-west deduplicates
|
||||
# identical in-flight executions (confirmed by the farm maintainer:
|
||||
# NativeLink 1.7.1 subscribes a second identical Execute of a cacheable
|
||||
# action to the operation already in flight), so the shadow adds no
|
||||
# executions.
|
||||
# Advisory: it cannot fail the gate. Job-level continue-on-error (a failed
|
||||
# job otherwise fails the whole call, whose result pr.yml's ci-gate
|
||||
# requires as BAZEL), no workflow_call output, no job outputs, no job in
|
||||
# this file needs it, and no gate script or caller names it. The gate does
|
||||
# wait for it: ci-gate needs pr.yml's bazel call, which completes only when
|
||||
# every job in it has finished (success, failure or timeout), so a slow
|
||||
# shadow delays the gate and the merge queue. continue-on-error does not
|
||||
# cover a job GitHub cancels at its own timeout-minutes, which could turn
|
||||
# the call red: every step has a timeout, and the job's exceeds their sum
|
||||
# (TestBazelDoltRaceShadowIsAdvisory). Mode remote only, on
|
||||
# same-repo pull requests and merge groups (mode remote on a pull_request
|
||||
# is never a fork): no fork mode, no cache or local mode, and not on push,
|
||||
# nightly, dispatch or bazel-farm.yml's call. Its ci-analytics LANE is
|
||||
# dolt-race. Removing it is the rollback; nothing reads it.
|
||||
bazel-dolt-race:
|
||||
name: dolt-race
|
||||
needs: rbe
|
||||
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
|
||||
if: ${{ needs.rbe.outputs.mode == 'remote' && (github.event_name == 'pull_request' || github.event_name == 'merge_group') }}
|
||||
# At least every step's timeout-minutes plus 5 (and the test step's plus
|
||||
# 10): a hung step then fails the job (continue-on-error) before GitHub
|
||||
# cancels it, which continue-on-error does not cover
|
||||
# (TestBazelDoltRaceShadowIsAdvisory). bazel-proxied's steps have no
|
||||
# timeouts but its test step's; these bound the rest.
|
||||
timeout-minutes: 55
|
||||
continue-on-error: true
|
||||
steps:
|
||||
# inputs.checkout-sha: see the header (empty: the event's default ref).
|
||||
# checkout v7 refuses a fork head on pull_request_target unless opted
|
||||
# in; only bazel-farm.yml's authorized call opts in (false elsewhere).
|
||||
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
||||
timeout-minutes: 5
|
||||
with:
|
||||
ref: ${{ inputs.checkout-sha }}
|
||||
persist-credentials: false
|
||||
allow-unsafe-pr-checkout: ${{ inputs.fork-farm == 'authorized' && github.event_name == 'pull_request_target' }}
|
||||
|
||||
# The remote repo contents cache, read-only, as in bazel-test.
|
||||
- name: Remote repo contents cache (read)
|
||||
if: ${{ needs.rbe.outputs.mode == 'remote' && needs.rbe.outputs.rrc == 'on' }}
|
||||
timeout-minutes: 1
|
||||
run: |
|
||||
{
|
||||
echo 'startup --experimental_remote_repo_contents_cache'
|
||||
echo 'common --loading_phase_threads=64'
|
||||
} >> .bazelrc.local
|
||||
|
||||
- name: Set up Bazel
|
||||
id: bazel
|
||||
timeout-minutes: 5
|
||||
uses: ./.github/actions/setup-bazel
|
||||
env:
|
||||
BAZEL_REMOTE_EXECUTOR: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_WEST_EXECUTOR || '' }}
|
||||
RBE_TLS_CERT: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CERT || '' }}
|
||||
RBE_TLS_KEY: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_KEY || '' }}
|
||||
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
|
||||
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
|
||||
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
|
||||
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
|
||||
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
|
||||
RBE_FORK_PR: ${{ github.event.pull_request.number }}
|
||||
|
||||
# As in bazel-proxied.
|
||||
- name: No test target is marked flaky
|
||||
timeout-minutes: 3
|
||||
run: |
|
||||
flaky="$(bazel query 'attr(flaky, 1, tests(//...))')"
|
||||
if [ -n "$flaky" ]; then
|
||||
echo "::error::flaky = True on ${flaky//$'\n'/ }: the gated lanes run each test once"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Both tiers' shards at once: 27 dolt-server + 35 proxied test actions,
|
||||
# under the remote-exec config's 64 jobs. The step timeout is
|
||||
# bazel-proxied's (the longer tier on rbe-west).
|
||||
- name: bazel test //... --config=dolt-race
|
||||
id: test
|
||||
timeout-minutes: 25
|
||||
run: |
|
||||
set -o pipefail
|
||||
start=$(date +%s)
|
||||
rc=0
|
||||
bazel test //... --config=dolt-race ${BAZEL_FRESH:+"$BAZEL_FRESH"} \
|
||||
--build_event_json_file="$RUNNER_TEMP/bazel-bep.json" \
|
||||
--execution_log_compact_file="$RUNNER_TEMP/bazel-exec.log.zst" \
|
||||
--profile="$RUNNER_TEMP/bazel-profile.json" \
|
||||
--experimental_build_event_upload_strategy=local \
|
||||
2>&1 | tee "$RUNNER_TEMP/bazel-test.log" || rc=$?
|
||||
echo "bazel test --config=dolt-race: exit $rc, $(( $(date +%s) - start ))s wall" | tee -a "$GITHUB_STEP_SUMMARY"
|
||||
exit "$rc"
|
||||
|
||||
# The member lanes' checks over the union's BEP: bazel-proxied's (the
|
||||
# dolt-server lane has none). check_shard_coverage ignores targets it
|
||||
# does not list; check_testcases checks every target, so it covers the
|
||||
# dolt-server tier too, which bazel-doltserver does not check: a
|
||||
# dolt-server shard that runs no test turns this job red while both
|
||||
# member lanes stay green.
|
||||
- name: Every target and shard ran tests
|
||||
if: ${{ always() && steps.test.outcome != 'skipped' }}
|
||||
timeout-minutes: 2
|
||||
run: python3 tools/bazel/check_testcases.py --bep "$RUNNER_TEMP/bazel-bep.json"
|
||||
|
||||
- name: Every listed test ran in its shard
|
||||
if: ${{ always() && steps.test.outcome != 'skipped' }}
|
||||
timeout-minutes: 2
|
||||
run: >-
|
||||
python3 tools/bazel/check_shard_coverage.py
|
||||
--bep "$RUNNER_TEMP/bazel-bep.json"
|
||||
--suite //cmd/bd:bd_proxied_test .github/scripts/proxied-test-shard.sh 34
|
||||
|
||||
- name: Upload test logs
|
||||
if: ${{ failure() && steps.test.outcome != 'skipped' }}
|
||||
timeout-minutes: 3
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
with:
|
||||
overwrite: true # a job re-run is the same run: replace, not 409
|
||||
name: bazel-dolt-race-testlogs
|
||||
path: |
|
||||
bazel-testlogs/**/test.log
|
||||
bazel-testlogs/**/test.xml
|
||||
if-no-files-found: ignore
|
||||
retention-days: 7
|
||||
|
||||
# Same redacted summary as bazel-test's; see its comment.
|
||||
- name: CI analytics summary
|
||||
id: ci-analytics
|
||||
if: "!cancelled() && steps.test.outcome != 'skipped'"
|
||||
continue-on-error: true
|
||||
timeout-minutes: 2
|
||||
env:
|
||||
LANE: dolt-race
|
||||
MODE: ${{ needs.rbe.outputs.mode }}
|
||||
CHECK_RUN_ID: ${{ job.check_run_id }}
|
||||
PR_HINT: ${{ github.event.pull_request.number || 0 }}
|
||||
run: |
|
||||
[ -f "$RUNNER_TEMP/bazel-bep.json" ] || exit 0
|
||||
zstd --version || echo "::warning::zstd missing: no per-mnemonic data in this lane's summary"
|
||||
python3 tools/bazel/ci_analytics_extract.py \
|
||||
--lane "$LANE" --mode "$MODE" --check-run-id "$CHECK_RUN_ID" --pr-hint "$PR_HINT" \
|
||||
--invocation test "$RUNNER_TEMP/bazel-bep.json" "$RUNNER_TEMP/bazel-exec.log.zst" "$RUNNER_TEMP/bazel-profile.json" \
|
||||
--out "$RUNNER_TEMP/ci-analytics/ci-analytics.json"
|
||||
|
||||
- name: Upload CI analytics summary
|
||||
if: "!cancelled() && steps.ci-analytics.outcome == 'success'"
|
||||
continue-on-error: true
|
||||
timeout-minutes: 2
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
||||
with:
|
||||
overwrite: true # a job re-run is the same run: replace, not 409
|
||||
name: ci-analytics-dolt-race-${{ github.run_attempt }}
|
||||
path: ${{ runner.temp }}/ci-analytics/ci-analytics.json
|
||||
retention-days: 7
|
||||
if-no-files-found: ignore
|
||||
|
||||
# pr-risk.yml's server-Dolt storage tier, "Test (Server Dolt Conformance)"
|
||||
# and "Test (Server Dolt Full Suite N/16)", as --config=doltserver-integration:
|
||||
# the conformance and 16-shard full-suite variants of
|
||||
|
|
|
|||
|
|
@ -620,6 +620,39 @@ job's `if:` or rotating the key, in either of two ways:
|
|||
step's own kill switch, checked before any network call. Deleting the
|
||||
variable does not disable pre-warming; it restores the default of 1.
|
||||
|
||||
## dolt-race Shadow (Not Required)
|
||||
|
||||
`bazel.yml`'s `bazel-dolt-race` job (check name `Bazel / dolt-race`) is an
|
||||
advisory shadow, not a required check. It runs
|
||||
`bazel test //... --config=dolt-race`, the union of `--config=doltserver` and
|
||||
`--config=doltserver-proxied` with one tag filter for both tiers, beside the
|
||||
`bazel-doltserver` and `bazel-proxied` lanes. Its purpose is to measure one
|
||||
client per group of lanes against the two lanes it would replace (end time,
|
||||
runner minutes, test counts and results) before any cutover. Each member
|
||||
target's test action key is unchanged, so the shadow shares cached results
|
||||
with the member lanes.
|
||||
|
||||
- It runs in mode `remote` on `pull_request` and `merge_group` events only.
|
||||
It never runs in a fork mode (`fork-ro`, `fork-rw`), in mode `cache` or
|
||||
`local`, on `bazel-farm.yml`'s call, on push, nightly or dispatch.
|
||||
- It cannot fail the gate. It has job-level `continue-on-error`, so its
|
||||
failure cannot fail the call's aggregate result (`BAZEL`). It has no
|
||||
`workflow_call` output, no `bazel.yml` job `needs` it, and `pr.yml`,
|
||||
`ci-gate.sh` and `bazel-gate.sh` never name it.
|
||||
- The gate still waits for it. `CI Gate` needs `pr.yml`'s `bazel` call, and
|
||||
a reusable-workflow call completes only when all of its jobs have finished
|
||||
(success, failure or timeout), `continue-on-error` ones included. A slow
|
||||
shadow therefore delays `CI Gate` and the merge queue, up to its
|
||||
timeout. `continue-on-error` does not cover a job GitHub cancels at its
|
||||
own `timeout-minutes`, so every step has its own timeout and the job's
|
||||
(65 minutes) stays at least 5 minutes above their sum and 10 above the
|
||||
test step's (policy-tested). A hung step then fails the job, which
|
||||
`continue-on-error` covers, before GitHub would cancel it.
|
||||
- Its ci-analytics `LANE` is `dolt-race`.
|
||||
- Policy: `scripts/bazel_dolt_race_shadow_test.go`. Removing the job, its
|
||||
`.bazelrc` config and its line in `.github/scripts/rrc-lane-commands.txt`
|
||||
is the rollback; nothing reads them.
|
||||
|
||||
## Remote Repo Contents Cache
|
||||
|
||||
A cold lane client re-runs its repository rules (gazelle's `go_deps`, the Go
|
||||
|
|
|
|||
|
|
@ -35,6 +35,7 @@ go_test(
|
|||
srcs = [
|
||||
"bazel_autofix_push_test.go",
|
||||
"bazel_cache_mode_test.go",
|
||||
"bazel_dolt_race_shadow_test.go",
|
||||
"bazel_farm_workflow_test.go",
|
||||
"bazel_fork_mode_test.go",
|
||||
"bazel_go_repository_tools_test.go",
|
||||
|
|
|
|||
|
|
@ -225,7 +225,9 @@ func TestBazelCacheModeReachesTheRC(t *testing.T) {
|
|||
// no longer forwards the app secrets either, so there is no
|
||||
// audience left for pre-warming in fork-ro or fork-rw (see
|
||||
// bazel.yml's comment on the job).
|
||||
case strings.HasPrefix(mode, "fork-") && !runs && !bazelPackageJobs[name] && !(name == bazelRBEPrewarmJobName && strings.HasPrefix(mode, "fork-")):
|
||||
// Nor does a shadow lane (bazelShadowLanes): mode remote on
|
||||
// same-repo PRs and merge groups only.
|
||||
case strings.HasPrefix(mode, "fork-") && !runs && !bazelPackageJobs[name] && !(name == bazelRBEPrewarmJobName && strings.HasPrefix(mode, "fork-")) && bazelShadowLanes[name] == "":
|
||||
t.Errorf("%s does not run in mode %s (every lane runs remotely)", name, mode)
|
||||
case mode == "cache" && (name == bazelIntegJobName || name == bazelCmdDoltJobName) && !runs:
|
||||
t.Errorf("%s does not run in mode cache", name)
|
||||
|
|
|
|||
305
scripts/bazel_dolt_race_shadow_test.go
Normal file
305
scripts/bazel_dolt_race_shadow_test.go
Normal file
|
|
@ -0,0 +1,305 @@
|
|||
package scripts_test
|
||||
|
||||
import (
|
||||
"cmp"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"slices"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"gopkg.in/yaml.v3"
|
||||
)
|
||||
|
||||
// The dolt-race shadow (item 5, Phase 1): bazel.yml's bazel-dolt-race job
|
||||
// runs --config=dolt-race, the union of --config=doltserver and
|
||||
// --config=doltserver-proxied, in one `bazel test` beside the two member
|
||||
// lanes, so the union-job model can be measured against them before any
|
||||
// cutover. It must be advisory: no workflow_call output, nothing in pr.yml's
|
||||
// gates or bazel-gate.sh/ci-gate.sh, and a failure that cannot fail the
|
||||
// call's aggregate result (BAZEL) that pr.yml's ci-gate requires. It cannot
|
||||
// fail the gate, but the gate still waits for it: ci-gate needs the whole
|
||||
// bazel call, which completes only when every job in it has finished.
|
||||
|
||||
const (
|
||||
bazelDoltRaceJobName = "bazel-dolt-race"
|
||||
bazelDoltRaceConfig = "dolt-race"
|
||||
// Mode remote only, and only on same-repo pull requests and merge
|
||||
// groups (mode remote on a pull_request event is never a fork: forks
|
||||
// get fork-ro, fork-rw or cache). Not on push, nightly, dispatch or
|
||||
// bazel-farm.yml's pull_request_target call.
|
||||
bazelDoltRaceJobIf = "${{ needs.rbe.outputs.mode == 'remote' && (github.event_name == 'pull_request' || github.event_name == 'merge_group') }}"
|
||||
)
|
||||
|
||||
// bazelShadowLanes: bazel.yml jobs that run beside gated lanes only to
|
||||
// measure a change to them, and report into nothing (no job or
|
||||
// workflow_call output, no gate id, job-level continue-on-error), with the
|
||||
// reason. TestBazelLaneIsGated and the continue-on-error checks carve them
|
||||
// out by this map.
|
||||
var bazelShadowLanes = map[string]string{
|
||||
bazelDoltRaceJobName: "item 5 Phase 1: the dolt-server + proxied union beside its member lanes, advisory until a cutover PR",
|
||||
}
|
||||
|
||||
// bazelDoltRaceJobTimeoutHeadroom: the minutes the shadow job's
|
||||
// timeout-minutes must exceed its test step's (TestBazelDoltRaceShadowIsAdvisory).
|
||||
const bazelDoltRaceJobTimeoutHeadroom = 10
|
||||
|
||||
// bazelDoltRaceJobTimeoutMargin: the minutes the shadow job's timeout-minutes
|
||||
// must exceed the sum of all its step timeouts.
|
||||
const bazelDoltRaceJobTimeoutMargin = 5
|
||||
|
||||
// bazelDoltRaceMergeQueueTimeout: the merge queue's check timeout (ruleset
|
||||
// merge_queue.check_response_timeout_minutes). CI Gate waits for the shadow,
|
||||
// so the shadow's job timeout must stay below it or a hung shadow drops the
|
||||
// group from the queue.
|
||||
const bazelDoltRaceMergeQueueTimeout = 60
|
||||
|
||||
// The union's members, and the tag filter each owns.
|
||||
var bazelDoltRaceMembers = []struct{ config, tag string }{
|
||||
{"doltserver", "dolt-server"},
|
||||
{"doltserver-proxied", "dolt-server-proxied"},
|
||||
}
|
||||
|
||||
// bazelRCConfigLines returns .bazelrc's option lines for --config=name
|
||||
// (any command: test:name, build:name, ...), as "<command> <option>"
|
||||
// with the ":name" suffix stripped, in file order.
|
||||
func bazelRCConfigLines(rc, name string) []string {
|
||||
var out []string
|
||||
for _, line := range strings.Split(rc, "\n") {
|
||||
line = strings.TrimSpace(line)
|
||||
if line == "" || strings.HasPrefix(line, "#") {
|
||||
continue
|
||||
}
|
||||
head, opt, ok := strings.Cut(line, " ")
|
||||
cmd, cfg, hasCfg := strings.Cut(head, ":")
|
||||
if !ok || !hasCfg || cfg != name {
|
||||
continue
|
||||
}
|
||||
out = append(out, cmd+" "+strings.TrimSpace(opt))
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
// TestBazelDoltRaceConfigIsMemberUnion: --config=dolt-race is exactly the
|
||||
// set union of its members' lines, except that each member's
|
||||
// --test_tag_filters is replaced by one filter naming both members' tags.
|
||||
// Every flag stays a member's own, so each member target's test action is
|
||||
// unchanged (verified with aquery in the PR that added it), and a flag added
|
||||
// to a member must be added to the union too.
|
||||
func TestBazelDoltRaceConfigIsMemberUnion(t *testing.T) {
|
||||
rc := readPolicyFile(t, bazelPolicyRoot(t), ".bazelrc")
|
||||
const tagPrefix = "test --test_tag_filters="
|
||||
|
||||
var want []string
|
||||
var tags []string
|
||||
for _, m := range bazelDoltRaceMembers {
|
||||
lines := bazelRCConfigLines(rc, m.config)
|
||||
if len(lines) == 0 {
|
||||
t.Fatalf(".bazelrc has no --config=%s lines", m.config)
|
||||
}
|
||||
var memberTags []string
|
||||
for _, l := range lines {
|
||||
if v, ok := strings.CutPrefix(l, tagPrefix); ok {
|
||||
memberTags = append(memberTags, v)
|
||||
continue
|
||||
}
|
||||
if !slices.Contains(want, l) {
|
||||
want = append(want, l)
|
||||
}
|
||||
}
|
||||
if len(memberTags) != 1 || memberTags[0] != m.tag {
|
||||
t.Errorf("--config=%s tag filters %v, want exactly [%s]", m.config, memberTags, m.tag)
|
||||
}
|
||||
tags = append(tags, m.tag)
|
||||
}
|
||||
|
||||
got := bazelRCConfigLines(rc, bazelDoltRaceConfig)
|
||||
var gotTags []string
|
||||
var gotRest []string
|
||||
for _, l := range got {
|
||||
if v, ok := strings.CutPrefix(l, tagPrefix); ok {
|
||||
gotTags = append(gotTags, v)
|
||||
continue
|
||||
}
|
||||
gotRest = append(gotRest, l)
|
||||
}
|
||||
if wantTag := strings.Join(tags, ","); len(gotTags) != 1 || gotTags[0] != wantTag {
|
||||
t.Errorf("--config=%s tag filters %v, want exactly [%s]", bazelDoltRaceConfig, gotTags, wantTag)
|
||||
}
|
||||
if !sameStringSet(gotRest, want) {
|
||||
t.Errorf("--config=%s is not the union of its members' lines (tag filter aside):\ngot:\n%s\nwant (any order):\n%s",
|
||||
bazelDoltRaceConfig, strings.Join(gotRest, "\n"), strings.Join(want, "\n"))
|
||||
}
|
||||
if len(gotRest) != len(want) {
|
||||
t.Errorf("--config=%s repeats a line: %d lines for %d distinct member lines", bazelDoltRaceConfig, len(gotRest), len(want))
|
||||
}
|
||||
// No nested --config: the union is spelled out, so the policy above
|
||||
// sees every flag.
|
||||
for _, l := range got {
|
||||
if strings.Contains(l, "--config=") {
|
||||
t.Errorf("--config=%s line %q: spell the members' flags out, no nested --config", bazelDoltRaceConfig, l)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func sameStringSet(a, b []string) bool {
|
||||
as := map[string]bool{}
|
||||
for _, s := range a {
|
||||
as[s] = true
|
||||
}
|
||||
bs := map[string]bool{}
|
||||
for _, s := range b {
|
||||
bs[s] = true
|
||||
}
|
||||
if len(as) != len(bs) {
|
||||
return false
|
||||
}
|
||||
for s := range as {
|
||||
if !bs[s] {
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
// TestBazelDoltRaceShadowIsAdvisory pins what keeps the shadow from failing
|
||||
// any gate: remote-only, job-level continue-on-error (a job's failure
|
||||
// otherwise fails the reusable-workflow call, whose result pr.yml's ci-gate
|
||||
// requires as BAZEL), timeout headroom (a job cancelled at its own timeout
|
||||
// is not covered by continue-on-error), no workflow_call output, no
|
||||
// bazel.yml job needs it, and no gate script or caller names it. ci-gate
|
||||
// still waits for it to finish, through its needs on the whole call.
|
||||
func TestBazelDoltRaceShadowIsAdvisory(t *testing.T) {
|
||||
workflow := readCIWorkflow(t, bazelWorkflowName)
|
||||
job := workflow.job(t, bazelDoltRaceJobName)
|
||||
|
||||
if job.If != bazelDoltRaceJobIf {
|
||||
t.Errorf("%s if: %q, want %q", bazelDoltRaceJobName, job.If, bazelDoltRaceJobIf)
|
||||
}
|
||||
if !job.ContinueOnError {
|
||||
t.Errorf("%s: continue-on-error false; the shadow must never fail the bazel call pr.yml's ci-gate requires", bazelDoltRaceJobName)
|
||||
}
|
||||
if !slices.Equal(job.Needs, []string{bazelRBEJobName}) {
|
||||
t.Errorf("%s needs %v, want [%s]", bazelDoltRaceJobName, job.Needs, bazelRBEJobName)
|
||||
}
|
||||
for name, other := range workflow.Jobs {
|
||||
if slices.Contains(other.Needs, bazelDoltRaceJobName) {
|
||||
t.Errorf("job %s needs %s; no bazel.yml job may depend on the shadow", name, bazelDoltRaceJobName)
|
||||
}
|
||||
}
|
||||
|
||||
// The test step: the union config, as the member lanes run theirs.
|
||||
test := job.step(t, "bazel test //... --config="+bazelDoltRaceConfig)
|
||||
if strings.TrimSpace(test.Run) != bazelTierTestRun(bazelDoltRaceConfig) {
|
||||
t.Errorf("%s test step run changed; want exactly:\n%s\ngot:\n%s", bazelDoltRaceJobName, bazelTierTestRun(bazelDoltRaceConfig), test.Run)
|
||||
}
|
||||
|
||||
// Timeout headroom. continue-on-error covers a failed or timed-out step,
|
||||
// not a job GitHub cancels at its own timeout-minutes; a cancelled job
|
||||
// can make the call (needs.bazel.result) non-success and turn ci-gate
|
||||
// red. So the job outlives its test step by at least
|
||||
// bazelDoltRaceJobTimeoutHeadroom minutes, for setup before it and the
|
||||
// checks, uploads and analytics after it. Both sides come from the
|
||||
// workflow: a step without timeout-minutes would default to 360.
|
||||
if test.TimeoutMinutes <= 0 {
|
||||
t.Errorf("%s test step has no timeout-minutes; it would default to GitHub's 360 and outlive the job", bazelDoltRaceJobName)
|
||||
}
|
||||
if job.TimeoutMinutes < test.TimeoutMinutes+bazelDoltRaceJobTimeoutHeadroom {
|
||||
t.Errorf("%s timeout-minutes %d, want at least the test step's %d + %d: a job cancelled at its own timeout can turn ci-gate red",
|
||||
bazelDoltRaceJobName, job.TimeoutMinutes, test.TimeoutMinutes, bazelDoltRaceJobTimeoutHeadroom)
|
||||
}
|
||||
|
||||
// And no step can run the job into its own timeout: every step has a
|
||||
// timeout-minutes (a step timeout is a step failure, which
|
||||
// continue-on-error covers), and their sum plus
|
||||
// bazelDoltRaceJobTimeoutMargin minutes (runner setup, post-job
|
||||
// cleanup) fits in the job's.
|
||||
sum := 0
|
||||
for i, step := range job.Steps {
|
||||
if step.TimeoutMinutes <= 0 {
|
||||
t.Errorf("%s step %d (%q) has no timeout-minutes; a hang would run into the job timeout, a cancellation continue-on-error does not cover",
|
||||
bazelDoltRaceJobName, i, cmp.Or(step.Name, step.Uses))
|
||||
}
|
||||
sum += step.TimeoutMinutes
|
||||
}
|
||||
if job.TimeoutMinutes < sum+bazelDoltRaceJobTimeoutMargin {
|
||||
t.Errorf("%s timeout-minutes %d, want at least the sum of its step timeouts (%d) + %d",
|
||||
bazelDoltRaceJobName, job.TimeoutMinutes, sum, bazelDoltRaceJobTimeoutMargin)
|
||||
}
|
||||
if job.TimeoutMinutes >= bazelDoltRaceMergeQueueTimeout {
|
||||
t.Errorf("%s timeout-minutes %d, want below the merge queue's %d-minute check timeout: CI Gate waits for the shadow",
|
||||
bazelDoltRaceJobName, job.TimeoutMinutes, bazelDoltRaceMergeQueueTimeout)
|
||||
}
|
||||
|
||||
// No workflow_call output reads the job.
|
||||
var doc struct {
|
||||
On struct {
|
||||
WorkflowCall struct {
|
||||
Outputs map[string]struct {
|
||||
Value string `yaml:"value"`
|
||||
} `yaml:"outputs"`
|
||||
} `yaml:"workflow_call"`
|
||||
} `yaml:"on"`
|
||||
}
|
||||
if err := yaml.Unmarshal([]byte(readPolicyFile(t, sourceRepoRoot(t), ".github/workflows/"+bazelWorkflowName)), &doc); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(doc.On.WorkflowCall.Outputs) == 0 {
|
||||
t.Fatalf("%s: no workflow_call outputs parsed; the check is broken", bazelWorkflowName)
|
||||
}
|
||||
for name, out := range doc.On.WorkflowCall.Outputs {
|
||||
if strings.Contains(out.Value, "jobs."+bazelDoltRaceJobName+".") || strings.Contains(name, bazelDoltRaceConfig) {
|
||||
t.Errorf("%s workflow_call output %s (%q) reads the shadow; it reports into no gate", bazelWorkflowName, name, out.Value)
|
||||
}
|
||||
}
|
||||
|
||||
// No gate or caller names the job, its config or a gate id for it.
|
||||
root := sourceRepoRoot(t)
|
||||
for _, f := range []string{
|
||||
".github/workflows/pr.yml",
|
||||
".github/workflows/pr-risk.yml",
|
||||
".github/workflows/nightly.yml",
|
||||
".github/workflows/bazel-farm.yml",
|
||||
".github/scripts/bazel-gate.sh",
|
||||
".github/scripts/ci-gate.sh",
|
||||
} {
|
||||
b, err := os.ReadFile(filepath.Join(root, f))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
s := strings.ToLower(string(b))
|
||||
for _, needle := range []string{"dolt-race", "dolt_race", "doltrace"} {
|
||||
if strings.Contains(s, needle) {
|
||||
t.Errorf("%s mentions %q; the dolt-race shadow must stay out of every gate", f, needle)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TestBazelDoltRaceShadowRunsOnlyInRemotePRCalls evaluates the job's if:
|
||||
// for every execution mode and every event bazel.yml runs on. It runs only
|
||||
// in mode remote on a pull_request or merge_group event: never in a fork
|
||||
// mode (fork-ro, fork-rw), cache or local, never on bazel-farm.yml's
|
||||
// pull_request_target call (fork code with trusted credentials), and not on
|
||||
// push, nightly (schedule) or dispatch, so it never doubles nightly's fresh
|
||||
// execution of the two tiers.
|
||||
func TestBazelDoltRaceShadowRunsOnlyInRemotePRCalls(t *testing.T) {
|
||||
job := readCIWorkflow(t, bazelWorkflowName).job(t, bazelDoltRaceJobName)
|
||||
for _, mode := range []string{"remote", "fork-ro", "fork-rw", "cache", "local", "skip"} {
|
||||
for _, event := range []string{"pull_request", "merge_group", "pull_request_target", "push", "schedule", "workflow_dispatch"} {
|
||||
want := mode == "remote" && (event == "pull_request" || event == "merge_group")
|
||||
got := evalRRCIf(t, job.If, map[string]string{
|
||||
"needs.rbe.outputs.mode": mode,
|
||||
"github.event_name": event,
|
||||
})
|
||||
if got != want {
|
||||
t.Errorf("%s runs in mode %s on %s: %v, want %v", bazelDoltRaceJobName, mode, event, got, want)
|
||||
}
|
||||
}
|
||||
}
|
||||
// The runner is the lanes' ternary, which picks Blacksmith only in mode
|
||||
// remote: the only mode the job runs in.
|
||||
if job.RunsOn != bazelLaneRunsOn {
|
||||
t.Errorf("%s runs-on = %q, want %q", bazelDoltRaceJobName, job.RunsOn, bazelLaneRunsOn)
|
||||
}
|
||||
}
|
||||
|
|
@ -48,8 +48,9 @@ const (
|
|||
// alone under `canary`). Not bazel-release-cross (other target platforms,
|
||||
// not seeded) nor the package gates.
|
||||
var bazelRRCReadLanes = []string{
|
||||
"bazel-cmd-dolt", "bazel-doltserver", "bazel-embedded", "bazel-integration",
|
||||
"bazel-proxied", "bazel-pure", "bazel-server-storage", "bazel-test",
|
||||
"bazel-cmd-dolt", "bazel-dolt-race", "bazel-doltserver", "bazel-embedded",
|
||||
"bazel-integration", "bazel-proxied", "bazel-pure", "bazel-server-storage",
|
||||
"bazel-test",
|
||||
}
|
||||
|
||||
// bazelRRCReadLines: the reader's .bazelrc.local lines; both are key neutral
|
||||
|
|
|
|||
|
|
@ -22,6 +22,9 @@ var ciAnalyticsLaneJobs = map[string]string{
|
|||
"bazel-proxied": "proxied-server",
|
||||
"bazel-server-storage": "server-storage",
|
||||
"bazel-cmd-dolt": "cmd-dolt",
|
||||
// The advisory dolt-server + proxied union shadow (item 5 Phase 1): its
|
||||
// own lane value, so the A/B queries can pair it with its members.
|
||||
"bazel-dolt-race": "dolt-race",
|
||||
}
|
||||
|
||||
// ciAnalyticsExcludedJobs are bazel.yml jobs that deliberately do not run
|
||||
|
|
|
|||
|
|
@ -207,6 +207,7 @@ func TestMergeQueuePullRequestFieldsHandleMergeGroup(t *testing.T) {
|
|||
"bazel-proxied.steps[*].env.PR_HINT": "ci-analytics-summary metadata only (--pr-hint); `|| 0` already covers merge_group same as a non-PR push",
|
||||
"bazel-server-storage.steps[*].env.PR_HINT": "ci-analytics-summary metadata only (--pr-hint); `|| 0` already covers merge_group same as a non-PR push",
|
||||
"bazel-cmd-dolt.steps[*].env.PR_HINT": "ci-analytics-summary metadata only (--pr-hint); `|| 0` already covers merge_group same as a non-PR push",
|
||||
"bazel-dolt-race.steps[*].env.PR_HINT": "ci-analytics-summary metadata only (--pr-hint); `|| 0` already covers merge_group same as a non-PR push",
|
||||
}
|
||||
used := map[string]bool{}
|
||||
var fallbacks []string
|
||||
|
|
|
|||
|
|
@ -1779,7 +1779,7 @@ const (
|
|||
// bazel.yml's jobs: the rbe job that decides the execution mode, the
|
||||
// --config=ci lane, one job per CI job a Bazel config mirrors, and the two
|
||||
// package gates (F3), sorted alphabetically to match TestBazelWorkflowJobsAndExecutionMode's sort.Strings.
|
||||
var bazelJobNames = []string{bazelCmdDoltJobName, bazelDoltJobName, bazelEmbedJobName, bazelIntegJobName, bazelProxiedJobName, bazelPureJobName, bazelReleaseCrossJobName, bazelServerJobName, bazelJobName, bazelPackageMCPJobName, bazelPackageNPMJobName, bazelRBEJobName, bazelRBEPrewarmJobName, bazelRRCSeedJob, bazelRRCVerifyJob}
|
||||
var bazelJobNames = []string{bazelCmdDoltJobName, bazelDoltRaceJobName, bazelDoltJobName, bazelEmbedJobName, bazelIntegJobName, bazelProxiedJobName, bazelPureJobName, bazelReleaseCrossJobName, bazelServerJobName, bazelJobName, bazelPackageMCPJobName, bazelPackageNPMJobName, bazelRBEJobName, bazelRBEPrewarmJobName, bazelRRCSeedJob, bazelRRCVerifyJob}
|
||||
|
||||
// The lanes that only run remotely (skipped unless the rbe job chose remote);
|
||||
// bazel-integration runs remotely or with the read-only cache (bazelIntegIf);
|
||||
|
|
@ -2086,9 +2086,15 @@ func TestBazelWorkflowJobsAndExecutionMode(t *testing.T) {
|
|||
// bazel.yml's own run - and thus pr.yml's ci-gate - red for a job
|
||||
// nothing requires.
|
||||
_, flagGated := bazelFlagGatedLanes[name]
|
||||
if job.ContinueOnError && name != bazelRBEPrewarmJobName && !flagGated {
|
||||
// So is each shadow lane (bazelShadowLanes): it reports into no
|
||||
// gate, so its failure must not fail the call (BAZEL) either.
|
||||
_, shadow := bazelShadowLanes[name]
|
||||
if job.ContinueOnError && name != bazelRBEPrewarmJobName && !flagGated && !shadow {
|
||||
t.Errorf("%s continue-on-error hides failures from pr.yml's ci-gate", name)
|
||||
}
|
||||
if shadow && !job.ContinueOnError {
|
||||
t.Errorf("%s is a shadow lane (%s) but lacks job-level continue-on-error", name, bazelShadowLanes[name])
|
||||
}
|
||||
// A flag-gated lane is advisory until its flag says otherwise, and
|
||||
// an advisory job's failure must not fail the call (BAZEL).
|
||||
if flagGated && !job.ContinueOnError {
|
||||
|
|
@ -2172,6 +2178,11 @@ func TestBazelWorkflowJobsAndExecutionMode(t *testing.T) {
|
|||
// setup-bazel, so wantJobSetupEnv is moot (the per-step check
|
||||
// below only fires for a setup-bazel step).
|
||||
wantJobRunsOn, wantJobIf = bazelPrewarmRunsOn, bazelRBEPrewarmIf
|
||||
} else if name == bazelDoltRaceJobName {
|
||||
// Mode remote, on pull_request and merge_group events only
|
||||
// (bazel_dolt_race_shadow_test.go); the lanes' runner and
|
||||
// setup-bazel env otherwise.
|
||||
wantJobIf = bazelDoltRaceJobIf
|
||||
}
|
||||
if job.RunsOn != wantJobRunsOn {
|
||||
t.Errorf("%s runs-on = %q, want %q", name, job.RunsOn, wantJobRunsOn)
|
||||
|
|
@ -2717,6 +2728,15 @@ func TestBazelLaneIsGated(t *testing.T) {
|
|||
if name == bazelRBEJobName || isBazelRRCJob(name) {
|
||||
continue // the rrc jobs never run in a PR call (bazel_rrc_test.go)
|
||||
}
|
||||
if _, shadow := bazelShadowLanes[name]; shadow {
|
||||
// A shadow lane reports into nothing: no job outputs, so no
|
||||
// workflow_call output and no gate id
|
||||
// (TestBazelDoltRaceShadowIsAdvisory).
|
||||
if len(job.Outputs) != 0 {
|
||||
t.Errorf("shadow lane %s outputs = %v, want none", name, job.Outputs)
|
||||
}
|
||||
continue
|
||||
}
|
||||
_, gated := bazelLaneGateIDs[name]
|
||||
_, advisory := bazelAdvisoryLanes[name]
|
||||
_, flagGated := bazelFlagGatedLanes[name]
|
||||
|
|
@ -3043,6 +3063,13 @@ func bazelLaneRunModes(t *testing.T, lane, ifExpr string, with map[string]string
|
|||
// bazelAdvisoryLanes' name-specific exception in
|
||||
// TestBazelGateSimulation below).
|
||||
return map[string]bool{"remote": true}
|
||||
case bazelDoltRaceJobIf:
|
||||
// Mode remote, and only on pull_request and merge_group events:
|
||||
// within pr.yml's call (the only PR-time caller these simulations
|
||||
// model) that is mode remote. bazel-farm.yml's pull_request_target
|
||||
// call, push, nightly and dispatch never run it
|
||||
// (TestBazelDoltRaceShadowRunsOnlyInRemotePRCalls).
|
||||
return map[string]bool{"remote": true}
|
||||
case bazelRRCSeedJobIf, bazelRRCVerifyJobIf:
|
||||
// The remote repo contents cache's writer (push to main) and
|
||||
// nightly check (schedule, dispatch): never in a pull_request,
|
||||
|
|
@ -4738,8 +4765,11 @@ func TestBazelWorkflowSecretsAndFailureSurface(t *testing.T) {
|
|||
// (bazelCIAnalyticsStepNames): reporting only, never a `needs`
|
||||
// of anything and never read back by this workflow or its
|
||||
// callers.
|
||||
// And each shadow lane's (bazelShadowLanes): it reports into no
|
||||
// gate, so its failure must not fail the call either.
|
||||
_, flagGated := bazelFlagGatedLanes[strings.TrimSuffix(strings.TrimPrefix(path, ".jobs."), ".continue-on-error")]
|
||||
if path != bazelRBEPrewarmContinueOnErrorPath && !flagGated && !ciAnalyticsPaths[path] {
|
||||
_, shadow := bazelShadowLanes[strings.TrimSuffix(strings.TrimPrefix(path, ".jobs."), ".continue-on-error")]
|
||||
if path != bazelRBEPrewarmContinueOnErrorPath && !flagGated && !shadow && !ciAnalyticsPaths[path] {
|
||||
t.Errorf("%s: %s hides failures from pr.yml's ci-gate", bazelWorkflowName, path)
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1153,6 +1153,9 @@ func TestBazelRetiredLanesArePinned(t *testing.T) {
|
|||
}
|
||||
evictionAllowed[want] = true
|
||||
}
|
||||
// The dolt-race shadow's union config carries its proxied member's
|
||||
// line (TestBazelDoltRaceConfigIsMemberUnion pins the union).
|
||||
evictionAllowed["test:"+bazelDoltRaceConfig+" --experimental_remote_cache_eviction_retries=0"] = true
|
||||
for _, line := range strings.Split(rc, "\n") {
|
||||
line = strings.TrimSpace(line)
|
||||
if !strings.HasPrefix(line, "#") && strings.Contains(line, "remote_cache_eviction_retries") && !evictionAllowed[line] {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue