test(storage): waive the participation-generation contracts on the http leg

main's #7247 (6d21d337ad, "a served http conformance leg") registered a
fourth leg, http, after this PR's original base. The PR's seven
RunParticipationGeneration* entrypoints are neither wired nor waived there,
so TestEveryLegWiresEveryRoleContract/http fails on the rebased branch.

ParticipationGenerationFixture toggles the store's own versioned-history
write flag and reads the raw participation_generation column back: store
write-fence bookkeeping (design §16.2b), not a publicops role the HTTP
client serves. Waive the seven cases on http with a named reason, the same
waiver the donnabox fork carries (09e7ce05af), and keep the gap visible
until a supported HTTP surface is designed and tested.

go test ./internal/storage/ -run TestEveryLegWiresEveryRoleContract now
passes on dolt, embeddeddolt, http and uow.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Julian Knutsen 2026-10-18 02:46:49 +00:00
commit edd3b72a1a

View file

@ -120,6 +120,14 @@ func init() {
"RunLifecycleUpdateExpectedVersionSingleWinnerWithDisjointColumnsUnderConcurrency": issuePatchFieldsNotOnUpdateWireWaiverReason,
"RunLifecycleUpdateExpectedVersionSingleWinnerAcrossUpdateAndCloseUnderConcurrency": issuePatchFieldsNotOnUpdateWireWaiverReason,
"RunParticipationGenerationCreateWithFlagOffLeavesLegacyNull": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationCreateWithFlagOnStampsAValue": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationFenceIgnoresSchemaSkewHatch": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationProceedsForPromotedRecord": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationSkipsUpdateOnLegacyRecord": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationWispPersistenceMoveBeginsHistory": participationGenerationRawStoreWaiverReason,
"RunParticipationGenerationWispPromotionBeginsHistory": participationGenerationRawStoreWaiverReason,
})
}
@ -333,6 +341,20 @@ const issuePatchFieldsNotOnUpdateWireWaiverReason = "PENDING, not permanent (tra
"closing the rest of the gap means publishing spec_id and owner on IssuePatchBody, which is a wire change " +
"to the write role (S4b), not something this leg's test wiring can bind around today"
// participationGenerationRawStoreWaiverReason covers the seven
// ParticipationGenerationFixture cases: a storage capability, not a claim the
// HTTP client serves.
//
// ParticipationGenerationFixture (backend/conformance/
// dualwrite_participation_generation_contract.go) toggles the store's own
// versioned-history write flag and reads the raw participation_generation
// column and issue_versions rows back — the store's own write-fence
// bookkeeping (design §16.2b), not a publicops role. The http leg is a remote
// client with no write flag to toggle and no raw column to read; the server it
// dials runs the fence in its own store, which the store legs already pin.
// Keep the gap visible until a supported HTTP surface is designed and tested.
const participationGenerationRawStoreWaiverReason = "ParticipationGeneration exercises a store write flag and raw generation column that the HTTP client does not expose"
// TestEveryLegWiresEveryRoleContract fails when a backend leg skips a role
// contract the conformance package exports.
//