Commit graph

2,545 commits

Author SHA1 Message Date
Medhat Galal
99565c0d25 Merge remote-tracking branch 'upstream/main' into AI/import-path-config-upstream
# Conflicts:
#	cmd/bd/config.go
#	cmd/bd/init_templates.go
#	docs/CLI_REFERENCE.md
#	docs/CONFIG.md
#	website/docs/cli-reference/config.md
#	website/versioned_docs/version-1.0.0/cli-reference/config.md
#	website/versioned_docs/version-1.0.4/cli-reference/config.md
2026-05-22 00:40:02 -04:00
Julian Knutsen
220e552a46
fix(init): tighten Dolt marker handling (#4083) 2026-05-21 20:00:36 -07:00
matt wilkie
3988db7e0d
fix(init): make JSONL auto-export opt-in (#4063)
* fix(init): make JSONL auto-export opt-in

Default export.auto and export.git-add to false for new repos, make the init prompt opt-in, and update docs/tests to describe JSONL as an optional viewer/interchange/backup export rather than core sync behavior.

Fixes GH#4062

* refactor(auto-export): check commit before throttle

Move cheap Dolt commit change detection ahead of the auto-export throttle and extract the throttle decision into a tested helper. This keeps the default-off design while carrying the compatible part of Jeremy Longshore's GH#4061 refactor.

Based-on: 313e1f8258

Co-authored-by: jeremylongshore <jeremylongshore@users.noreply.github.com>

* docs: regenerate versioned CLI references
* docs: call out JSONL export opt-in change

---------

_codex-gpt-5.5-medium on behalf of CI Bot_
_codex-gpt-5.5-high on behalf of matt wilkie_
Co-authored-by: CI Bot <ci@beads.test>
2026-05-21 16:21:00 -07:00
Julian Knutsen
8ba0b468df fix(init): surface marker write failures 2026-05-21 22:55:27 +00:00
Julian Knutsen
f4c3adf768 fix(init): mark server-mode Dolt dirs compatible 2026-05-21 22:55:27 +00:00
Stephanie Jarmak
05c7835e9d
feat(storage): honor .beads/config.yaml types.custom in server-side validation (#4024) (#4026)
* feat(storage): honor .beads/config.yaml types.custom in server-side validation (#4024)

ResolveCustomTypesInTx previously consulted config.GetCustomTypesFromYAML
only in a narrow error-fallback path: when both the custom_types table AND
the types.custom config-string read had failed. As a result, a project that
declared types.custom in .beads/config.yaml (the version-controlled config
shape that downstream wrappers like gastownhall/gascity expect) could not
create or update beads of those types — server-side schema validation
rejected them because it never saw the YAML entries.

Overlay model (per #4024's proposed behavior):
  - Built-in types stay as the enforced floor (handled by IsValidWithCustom).
  - Database custom_types are the next layer (operator-/agent-installed types).
  - .beads/config.yaml types.custom is the topmost union-add (project-extension
    types declared in version-controlled config).
  - A bead whose type is in none of the three still fails validation cleanly.

Extracts mergeWithYAMLCustomTypes(dbTypes, yamlGetter) as a pure helper so
the union logic is unit-testable without sql.Tx mocking. The new helper:
  - Preserves order: DB types first, YAML-only types appended in declared order.
  - Dedupes whitespace-trimmed entries.
  - Drops empty/whitespace-only entries.
  - Tolerates nil getter and nil dbTypes.

Tests in internal/storage/issueops/config_helpers_test.go:
  - TestMergeWithYAMLCustomTypes — 7 table cases: both empty, yaml-only,
    db-only, db+disjoint-yaml union, db+overlapping-yaml dedup, yaml
    internal-dup dedup, whitespace dropping.
  - TestMergeWithYAMLCustomTypes_NilGetter — explicit nil-getter guard.

The pre-existing ResolveCustomTypesInTx error-fallback path is preserved:
when the config-string read errors AND YAML has types, return the YAML
overlay anyway with the original error — so a stable-bd project running
pre-#3691 doesn't lose its types.custom validation just because the
config-string read errored.

Downstream context: this unblocks gastownhall/gascity#2154 (the Gas City
side, which writes types.custom into .beads/config.yaml via
gc-beads-bd.sh's ensure_types_custom_in_yaml). Once this lands and bd
deployments adopt the fixed build, Gas City projects no longer need the
fallback workaround of mirroring types.custom into the database side.

* fix: address PR #4026 review findings (#4024)

Two findings from Copilot review:

1. ResolveCustomTypesInTx returned the YAML overlay alongside a non-nil
   error when the in-tx config-string read failed. In-tx callers
   (NewBatchContext, UpdateIssueInTx) treat any error as fatal, so the
   YAML-fallback path was effectively unreachable on pre-migration /
   degraded DBs — defeating the #4024 overlay goal precisely in the
   scenario the overlay was meant to cover. Mirror
   ResolveCustomStatusesDetailedInTx: when YAML supplies types, return
   them with a nil error; otherwise propagate the DB error. Extracted
   into customTypesYAMLFallback for unit testing without sql.Tx mocking.

2. getConfigList (the helper backing GetCustomTypesFromYAML /
   GetInfraTypesFromYAML / GetCustomStatusesFromYAML) used
   viper.GetString + comma-split, which silently ignored the YAML
   sequence form named in #4024 (`types: { custom: [step, wisp] }`).
   List-form .beads/config.yaml declarations therefore yielded an empty
   overlay. Try viper.GetStringSlice first (supports both block-list
   and inline-flow syntaxes), keeping the comma-split fallback for the
   legacy `types.custom = "step,wisp"` string form.

Tests: TestCustomTypesYAMLFallback covers the fallback decision;
TestGetCustomTypesFromYAML_ListForm and TestGetCustomTypesFromYAML_InlineListForm
pin both YAML sequence syntaxes.

Refs: gastownhall/beads#4024

---------

Co-authored-by: sjarmak <stephanie.jarmak1@gmail.com>
2026-05-21 10:26:53 -07:00
Julian Knutsen
09a3890877
fix(storage): preserve mixed issue and wisp reads (#3991)
* fix(schema): avoid sweeping dirty data during migrations

* fix: guard schema migration dirty commits (bd-wisp-g6c0g)

* fix(storage): preserve mixed issue and wisp reads

* fix(schema): unstage old tables before migrations

* test(dolt): add generated column cascade repro

* Repair PR 3991 rebase against current storage schema
2026-05-21 06:50:42 -07:00
Julian Knutsen
35b9bbb6a0
fix(schema): unify migration advisory lock path (#4031) 2026-05-20 23:38:14 -07:00
Medhat Galal
eea1cce5ab Merge remote-tracking branch 'upstream/main' into AI/import-path-config-upstream
# Conflicts:
#	docs/CONFIG.md
2026-05-21 02:05:29 -04:00
coffeegoddd☕️✨
479445c9d6 /internal/storage: cleanup 2026-05-20 14:58:19 -07:00
coffeegoddd☕️✨
b1e4652edf /internal/storage/{domain,uow}: dependency 2026-05-20 14:50:25 -07:00
coffeegoddd☕️✨
34ad562689 /internal/storage: remove some comments 2026-05-20 14:25:47 -07:00
coffeegoddd☕️✨
54b83a389f /internal/storage/domain: consolidate 2026-05-20 14:23:42 -07:00
coffeegoddd☕️✨
a873d5e82a /internal/storage/domain/db: handle wisps too 2026-05-20 14:14:55 -07:00
coffeegoddd☕️✨
d56ca3893a /internal/storage/domain/db: dependency 2026-05-20 13:51:18 -07:00
coffeegoddd☕️✨
e346490a2d /internal/storage/domain/db: comments 2026-05-20 13:37:55 -07:00
coffeegoddd☕️✨
93b63c7a65 /internal/storage/domain: add event 2026-05-20 13:19:59 -07:00
coffeegoddd☕️✨
5a1d5b4334 /internal/storage/domain/db: issue 2026-05-20 13:10:38 -07:00
coffeegoddd☕️✨
e8fb231ac6 /internal/storage/{uow,domain}: wip stubs 2026-05-20 12:34:37 -07:00
Julian Knutsen
8517ba1afa
test: add perf reference benchmarks (#4032)
* test: add perf reference benchmarks

* test: tighten perf reference benchmarks

* Fix perf benchmark review findings (bd-fsgqsj)
2026-05-19 18:39:13 -07:00
coffeegoddd☕️✨
ba36b678c3 /{cmd,internal}: more cleanup 2026-05-19 16:00:25 -07:00
coffeegoddd☕️✨
e9ece3a127 /{cmd,internal}: cleanup 2026-05-19 15:47:57 -07:00
coffeegoddd☕️✨
98be00c92e /{cmd,internal}: refactoring 2026-05-19 15:37:37 -07:00
coffeegoddd☕️✨
4fcbd58825 /{cmd,internal}: wip, implementing init with proxied-server 2026-05-19 14:17:14 -07:00
Dustin Brown
c79177073a
Merge pull request #4039 from coffeegoddd/db/remove-generated-column
refactor(deps): resolve depends_on_id via typed columns at read time
2026-05-19 13:46:10 -07:00
coffeegoddd☕️✨
3b1d3b3df9 /internal/storage/issueops/dependencies.go: remove comment 2026-05-19 13:11:24 -07:00
coffeegoddd☕️✨
cc0f80c8d4 /internal/storage/issueops/ready_work_test.go: fix tests 2026-05-19 12:57:22 -07:00
coffeegoddd☕️✨
b456ec58fc /{cmd,internal}: some cleanup 2026-05-19 12:47:34 -07:00
coffeegoddd☕️✨
44d3288107 /internal/storage/issueops/ready_work.go: fix ready work query 2026-05-19 12:43:26 -07:00
coffeegoddd☕️✨
4d3228517f /{cmd,internal}: get debug mode working 2026-05-19 11:48:10 -07:00
coffeegoddd☕️✨
eee26a7329 /internal/storage/{dolt,issueops}: more fixes 2026-05-19 11:45:17 -07:00
coffeegoddd☕️✨
9106148705 /internal/storage/issueops/dependencies.go: fix formatting 2026-05-19 11:04:51 -07:00
coffeegoddd☕️✨
fee553f612 /internal/storage/{dolt,issueops,schema}: remove comments 2026-05-19 11:02:40 -07:00
Medhat Galal
507b2a1fb5 Add configurable JSONL import path 2026-05-19 13:37:32 -04:00
coffeegoddd☕️✨
c2cbfd3fbb /{cmd,internal}: some fixes 2026-05-19 10:17:51 -07:00
coffeegoddd☕️✨
d15c7572f4 /{cmd,internal}: remove depends_on_id 2026-05-19 10:17:49 -07:00
Julian Knutsen
e569c7488b
fix: materialize local table schemas for branch tests (#4014)
* fix: materialize local table schemas for branch tests

* fix: harden dependency target rename
2026-05-19 09:22:35 -07:00
Julian Knutsen
0bf33da634
perf(ready): narrow deferred-parent child filtering (#4001)
* perf(ready): narrow deferred parent filtering

* fix: address ready review findings (bd-wisp-r6076f)
2026-05-18 11:47:18 -07:00
matt wilkie
d7d3dad580
fix(dolt): adopt git origin on first push (#3940)
* fix(dolt): adopt git origin on first push

bd dolt push now wires an existing git origin when no Dolt remote is configured, while init without origin stays local and doctor shows the concrete adoption command. This keeps refs/dolt/data sync discoverable without treating plain remotes as existing Dolt history.\n\n_kilocode-openai/gpt-5.5- on behalf of maphew_

* fix(dolt): address origin adoption review nits

Share Dolt remote URL normalization between the push adoption path and doctor guidance, fail before mutating Dolt state when no beads workspace is selected, and cover CheckRemoteConsistency's adoption detail.

_codex-gpt-5-medium on behalf of maphew_
2026-05-18 10:43:51 -07:00
Julian Knutsen
ad7674d117
perf(get): query primary issues before wisp fallback (#4003)
* perf(get): query primary issues before wisp fallback

* fix(get): propagate wisp label lookup errors (bd-wisp-6fcee9)
2026-05-18 03:37:02 -07:00
Julian Knutsen
83f49c027c
perf(ready): restrict blocked dependency scans to active IDs (#4002)
* perf(ready): restrict blocked dependency scan to active IDs

* test(ready): cover blocked dependency scan review fixes (bd-wisp-fmyceu)
2026-05-17 15:06:19 -07:00
Julian Knutsen
a4ebe8ffec
perf(deps): scan one cycle table for same-storage edges (#4004)
* perf(deps): narrow recursive cycle checks

* fix(deps): keep mixed-table cycle detection

* fix(deps): preserve mixed-table wisp cycle scans
2026-05-17 15:06:01 -07:00
Julian Knutsen
376a24ad17
fix(schema): serialize Dolt schema migrations (#4005)
* fix(schema): serialize Dolt schema migrations

* fix(schema): harden migration lock handling (bd-wisp-5pl1m9)
2026-05-17 15:05:43 -07:00
Jim Wordelman
42a2772fe4
refactor(ui): extract markdown rendering to internal/uimd package (#4009)
* refactor(ui): extract markdown rendering to internal/uimd package

Move RenderMarkdown out of internal/ui into a new internal/uimd package
so callers that don't need markdown don't pay the ~4.6 MB chroma/glamour
init cost on every bd subprocess.

Update callers: cmd/bd/show.go, show_display.go, show_children.go,
comments.go.

Closes be-ow4w54

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: release gate PASS for be-ow4w54 (uimd markdown extract)

* docs: narrow uimd release gate scope (bd-wisp-msz5y1)

---------

Co-authored-by: Jim Wordelman <jim@wordelman.name>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
2026-05-17 15:05:25 -07:00
Dustin Brown
c72581c8bb
Merge pull request #4017 from coffeegoddd/db/schema-lock
/internal/storage/schema/schema.go: advisory lock for concurrent inits
2026-05-17 12:59:17 -07:00
coffeegoddd☕️✨
0d27f4161b /internal/storage/schema/schema.go: fix panic 2026-05-17 12:44:51 -07:00
coffeegoddd☕️✨
4c0338ee5a /internal/storage/schema/schema.go: use query context 2026-05-17 09:09:38 -07:00
coffeegoddd☕️✨
beb2969ae7 /internal/storage/schema/schema.go: panic on failure to unlock 2026-05-17 08:57:33 -07:00
coffeegoddd☕️✨
c90a2daed8 /internal/storage/schema/schema.go: advisory lock for concurrent inits 2026-05-17 08:35:39 -07:00
Julian Knutsen
ed2b5aea52
fix(ready): apply filters to wisp ready work (#4008)
* fix(ready): apply filters to wisp ready work

* test(dep): expect current no-cycle message

* fix(ready): align wisp readiness filters
2026-05-17 08:08:58 -07:00