* test(cmd/bd): pin the command tree and representative --help output
Add two in-process goldens for the bd command surface, so any added,
removed, hidden or reworded command or flag fails until the goldens are
regenerated and shows up as a reviewed testdata diff:
- TestCommandTreeGolden walks the whole cobra tree (hidden commands
included) and records, per command, Use, Aliases, Short, Long, Example,
group, hidden/deprecated state, runnability and annotations, plus every
local and persistent flag it defines (name, shorthand, type, default,
usage, hidden, deprecation, annotations). Output is sorted and rendered
twice to prove it is deterministic.
- TestCommandHelpGolden runs `bd <cmd> --help` through rootCmd for root,
create, show, list, update, close, version, versions, config and serve.
--help returns before the root pre-run, so no store is opened; color
escapes are stripped. The snapshots are byte-identical to a built bd
binary's --help output.
Both run from a fresh ordinary (dependency-mode) workspace: a
.beads/metadata.json with no graph marker and no database behind it.
The tree is primed the way the binary is (main()'s help command and its
--all/--doc/--list/--docs-root flags, ExecuteC's completion command), and
cobra's history-dependent pieces (the lazily added per-command --help flag,
the __complete request commands) are excluded, so the result does not
depend on which in-process tests ran first. The help runs reset every flag
afterwards so a later in-process command does not inherit --help.
docs/cli-docs.pin holds check-doc-flags at the v1.2.2 release, so drift on
main is not caught there; these goldens are the live guard. They pin the
cgo build (the !cgo build swaps in a federation stub). Regenerate with
BD_UPDATE_GOLDEN=1 go test -tags gms_pure_go ./cmd/bd -run '^TestCommand(Tree|Help)Golden$'.
Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): keep the command goldens from merging flags into the shared tree
TestCommandTreeGolden read each command's flags through
LocalNonPersistentFlags, and TestCommandHelpGolden dispatches
`bd serve --help`. Both run cobra's mergePersistentFlags, which copies
every inherited persistent flag (--json, --db, ...) into the command's
own flag set for the rest of the process. TestServeFlags pins serveCmd's
exact flag set, so it failed whenever a golden test ran before it in the
same test binary: tree then serve flags, help then serve flags, and
-test.shuffle seeds 2 and 3, on the PR head and on its merge with main.
CI passes only because bd_test's 16 Bazel shards happen to run them in
different processes. Of 37 candidate tests, TestServeFlags is the only
one affected.
- goldenLocalFlags reads the set LocalNonPersistentFlags reports without
calling it: c.Flags() minus c's own persistent flags and minus
inherited copies. Like cobra, it treats a flag as inherited only if it
is the nearest ancestor's own *pflag.Flag, so copies left by an
earlier in-process execution are skipped and a flag that shadows an
inherited one still renders.
- TestCommandTreeGolden fails if rendering changes the number of flags
in any command's flag set.
- TestCommandHelpGolden calls restoreServeGlobals, which re-registers
serveCmd's flags after the `bd serve --help` dispatch.
Review minors:
- The regeneration command (doc comment, failure-message constant,
tree.golden header) sets CGO_ENABLED=1. Without cgo the file does not
build, so the command matches no test and exits 0.
- enterOrdinaryWorkspaceForGolden calls isolateBeadsDirForTest.
- renderCommandHelpGolden's comment says when the ANSI strip matters.
- cmd/bd/AGENTS.md lists the goldens under "Adding a command" and
"Guard tests".
Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>