Commit graph

7 commits

Author SHA1 Message Date
matt wilkie
234da63193
fix: resolve remaining 11 CI test failures (#2983)
* fix: resolve remaining 11 CI test failures (#2982)

Two categories of fixes:

1. Flock contention in test setup helpers: bdCreate, bdCreateSilent,
   bdUpdate, bdDelete, bdClose, and bdDepAdd now retry up to 5 times
   with exponential backoff when they encounter "one writer at a time"
   flock errors. This handles transient contention when parallel tests
   within the same CI shard compete for the embedded Dolt lock during
   their setup phase.

2. macOS path symlink mismatch: TestContext* tests in
   explicit_db_nodb_test.go now use filepath.EvalSymlinks() when
   comparing beads_dir paths, fixing failures where macOS resolves
   /var/folders to /private/var/folders.

Fixes #2982

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: increase flock retry budget and add retry to read helpers

The initial 5-retry/100ms-base backoff was insufficient for CI
contention. Refactored to a shared bdRunWithFlockRetry helper with
10 retries and 500ms base backoff (~30s total budget).

Also added flock retry to bdDiff, bdDiffJSON, bdShowRaw, and
bdShowDetails which were also failing on CI due to flock contention
during parallel test execution.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: close store before subprocess to release flock

The root cause of the persistent flock failures was openStore()
deferring Close() to t.Cleanup, keeping the exclusive flock held
while bd subprocess commands tried to acquire it. No amount of
retry can help when the same test holds the lock.

- getCommitHash: open/close store inline instead of via openStore
- show_json_includes_comments: close store after AddIssueComment
- show_as_of: close store after GetCurrentCommit

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 09:15:50 -07:00
matt wilkie
f443df1f2a
fix: resolve CI failures from flock, version bump, and lint (#2981)
* fix: resolve CI failures from flock, version bump, and lint

Three categories of CI failure on main after the v1.0.0 release:

1. rules.go lint/format: Fix gofmt alignment, errcheck on tw.Flush(),
   gosec G304 (add nosec comment), gosec G306 (use 0o600 perms).

2. doctor_test.go version tracking: The 'slightly outdated version'
   test used 0.55.0 which now has a major version diff from 1.0.0,
   correctly triggering a warning. Update expected status to match.

3. Embedded Dolt concurrent tests: The exclusive flock from #2571
   causes concurrent bd processes to fail with 'one writer at a time'.
   Update 58 concurrent test files to tolerate this expected error
   while still failing on unexpected errors and panics.

Amp-Thread-ID: https://ampcode.com/threads/T-019d5386-b41e-7138-bc81-6ea331b80760
Co-authored-by: Amp <amp@ampcode.com>

* fix: concurrent test post-conditions tolerate flock contention

With exclusive flock (commit 543e1943), only some workers can acquire
the lock in concurrent tests. Update post-conditions in 5 tests to:
- Only verify side effects from workers that succeeded (r.err == nil)
- Require at least 1 worker succeeds (fail if all hit flock)
- Log success/failure counts for visibility
- Still verify correct behavior for successful operations

Tests fixed:
- TestEmbeddedCloseConcurrent: remove Fatalf on failures, skip total count check
- TestEmbeddedDeferConcurrent: only check deferred status for successful workers
- TestEmbeddedUndeferConcurrent: only check open status for successful workers
- TestEmbeddedReopenConcurrent: only check open status for successful workers
- TestEmbeddedPromoteCLIConcurrent: only check permanent for successful workers

Amp-Thread-ID: https://ampcode.com/threads/T-019d5386-b41e-7138-bc81-6ea331b80760
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d5386-b41e-7138-bc81-6ea331b80760
Co-authored-by: Amp <amp@ampcode.com>

---------

Co-authored-by: Amp <amp@ampcode.com>
2026-04-03 07:27:00 -07:00
matt wilkie
59b49c45f0 fix: add missing //go:build cgo tags to embedded test files and cmd
Several test files and one main.go that depend on CGO-only types
(EmbeddedDoltStore methods like Close, CreateIssue, GetIssue) were
missing //go:build cgo build tags, causing compilation failures when
building with CGO_ENABLED=0.

Files fixed:
- 67 cmd/bd/*_embedded_test.go files
- cmd/bd/metadata_filter_test.go (uses newTestStore from cgo-tagged helper)
- cmd/bd/doctor/federation_test.go (uses doctorTestServerPort/testSharedDB)
- cmd/bd/doctor/fix/migrate_import_test.go (uses fixTestServerPort)
- 6 internal/storage/embeddeddolt/*_test.go files
- internal/storage/embeddeddolt/cmd/main.go

Amp-Thread-ID: https://ampcode.com/threads/T-019d4938-40d4-73ae-89d1-1891a19a9a15
Co-authored-by: Amp <amp@ampcode.com>
2026-04-01 07:08:41 -07:00
coffeegoddd☕️✨
a35edfd28e /{internal,cmd,.goreleaser,.github}: embedded mode by default 2026-03-28 13:47:20 -07:00
coffeegoddd☕️✨
cda9228ae1 /: bump driver to 1.84.0, paralleize embedded tests 2026-03-23 14:55:55 -07:00
coffeegoddd☕️✨
e7a77a2fa3 /{cmd,internal}: pr feedback 2026-03-20 13:58:17 -07:00
coffeegoddd☕️✨
778975c290 /cmd/bd/diff_embedded_test.go: diff tests 2026-03-20 12:28:13 -07:00