Commit graph

297 commits

Author SHA1 Message Date
Harry Miller
4a25937df2
fix: replace deprecated --force flag with --reinit-local in init error messages (#3695)
* fix: replace deprecated --force flag with --reinit-local in init error messages

Four error messages in init.go suggested 'bd init --force --prefix <x>'
when a workspace was already initialized. The --force flag was deprecated
in favor of --reinit-local, but the error messages were never updated.

Fixes #3684

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test: add regression tests for GH#3684 --reinit-local in error messages

Add TestCheckExistingBeadsData_SuggestsReinitLocal with two subtests
(embedded_dolt, sqlite_db_file) that verify the 'already initialized'
error messages recommend --reinit-local instead of the deprecated --force.

Also strengthen existing guard tests (server_mode_with_dolt_dir_blocks_init,
embedded_mode_with_existing_db_blocks_init, embedded_metadata_ignores_ambient)
with GH#3684 assertions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-05-04 11:42:47 -07:00
matt wilkie
acd2b7d97d
Merge pull request #3559 from kevglynn/feat/conditional-dolt-push-template
feat(setup): omit bd dolt push from template when no remote configured
2026-05-02 19:04:41 -07:00
maphew
261fdbb996 fix(setup): format conditional push template 2026-05-02 18:38:36 -07:00
coffeegoddd☕️✨
e97532ab5e :remove uneccessary locking 2026-05-01 17:46:37 -07:00
matt wilkie
16c0cd1626
Merge PR #3483: fix init permissions repair
Fix bd init so pre-existing permissive .beads directories are repaired to 0700, with regression coverage. Includes maintainer follow-up f34ab803b to align behavior with GH#3391 and the existing warning policy.
2026-04-28 07:05:03 -07:00
matt wilkie
f34ab803b9 fix(init): repair existing .beads permissions to 0700 2026-04-28 06:48:13 -07:00
matt wilkie
b9e16ac9d0
init: harden --remote error path and broaden test coverage (#3558)
- init.go: when cloneFromRemoteWithMode fails for a non-empty remote,
  echo the URL the user typed and add a Hint suggesting the user
  verify reachability/credentials or omit --remote. Distinguishes the
  unreachable-remote scenario from the empty-remote fallback so
  failures are no longer silent.
- init_embedded_test.go: add Windows skip to remote_bootstraps_existing_dolt_data
  (uses os.Symlink to mask dolt off PATH).
- init_embedded_test.go: add remote_clone_failure_emits_url_and_hint
  covering the explicit-URL non-empty-remote failure path with
  remotesapi:// (rejected as unknown scheme; fast and stable).
- init_embedded_test.go: add remote_http_url_preserved_verbatim asserting
  explicit --remote http:// URLs are not normalized to git+http://
  (GH#3339).

Both new failure-path subtests use exec.CommandContext with a 30s
deadline so a hung dial cannot stall CI, and assert against the
'failed to clone remote %q' wrap from init.go to keep the verbatim
check from accidentally matching a hypothetical git+http:// rewrite.

Closes mybd-cb4, mybd-n37, mybd-kr8.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 06:35:08 -07:00
kev
7d3dc1a5f7 fix(init): only strip world-accessible bits, preserve group perms
Users may intentionally set 0750 for shared group access. The
previous approach forced 0700 unconditionally. Now only the other
bits (0007) are cleared: 0755→0750, 0750→0750, 0700→0700.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-27 18:00:27 -04:00
kev
a0cf5e6838 fix(init): chmod existing .beads/ to 0700 instead of only warning (GH#3391)
When .beads/ already exists with permissive modes (e.g. created by
git clone with default umask), bd init now fixes the permissions to
0700 rather than leaving it for every subsequent bd command to warn
about.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-27 18:00:27 -04:00
kev
e90f980ada feat(setup): omit bd dolt push from template when no remote configured
RenderSection() and ReplaceSection() now accept RenderOpts with a
HasRemote flag. When false, "bd dolt push" is stripped from the
session-completion code block (and the Auto-Sync informational bullet
in the full profile). This prevents agents from dutifully running a
no-op every session on solo/local-only projects.

bd init detects the remote via shouldWireInitRemote(); bd setup detects
it by reading sync.remote / sync.git-remote from config.yaml. The
existing no-arg RenderSection() and ReplaceSection() default to
HasRemote=true for full backward compatibility.

Closes beads-ozg.
2026-04-27 17:37:42 -04:00
matt wilkie
112be87f80
Add bd init --remote bootstrap path (#3527)
* Add init remote bootstrap path (bd-cil)

* fix(init): adopt source _project_id when bootstrapping from remote

When `bd init --remote=<url>` cloned an existing Dolt remote, the
ProjectID adoption gate at init.go:867 only fired for `--database`
(GH#2922), so a fresh ProjectID was minted and then written back to
the cloned database, overwriting the source rig's identity and
breaking cross-project verification on subsequent pulls.

Extend the gate to also adopt when `bootstrappedFromRemote` is true,
matching the GH#2922 intent: if another rig already chose an
identity, inherit it rather than overwrite.

Fixes the failing TestEmbeddedInit/remote_bootstraps_existing_dolt_data
subtest added in this PR. The other --remote subtests (empty source,
plain git origin) and the GH#2922 --database path are unaffected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 13:45:26 -07:00
matt wilkie
87a932f927
Merge pull request #3195 from osamu2001/bd-where-is-slow
Improve bd where performance in worktree fallback
2026-04-27 07:34:44 -07:00
matt wilkie
3e56f0b214
Document Linear external_ref pre-linking (#3517)
* Document Linear external ref prelinking (bd-ly3)
* Fix Linear sync dependency graph handling
* Fix init remote clone routing
* Fix stale gate help text
* Fix init remote cherry-pick integration
* Fix init remote flag handling
* Fix Linear prelink hydration blockers
* Fix Linear relation dependency gating
* Fix ready list parent filtering
* Deduplicate dry-run dependency previews by stored identity
2026-04-27 06:05:30 -07:00
Osamu Okano
ef3c991cb0
Merge remote-tracking branch 'origin/main' into bd-where-is-slow
# Conflicts:
#	cmd/bd/where_test.go
2026-04-25 10:20:06 +09:00
Kevin Glynn
ac085df8c5
Skip Dolt remote registration for plain git source repos during init (#3357)
bd init unconditionally registered the parent git repo's origin URL as a
Dolt remote whenever origin existed, even when the remote had no Dolt data
(refs/dolt/data). For plain Git source repos (e.g. gastownhall/beads
itself), this caused every subsequent Dolt fetch to fail, generating
orphaned tmp_pack_* files that accumulated at ~15 GB/day (#3354).

Gate AddRemote and sync.remote persistence on either:
- syncFromRemote (remote confirmed to have refs/dolt/data), or
- syncURLFromConfig (URL came from explicit sync.remote config)

Auto-detected git origin URLs that lack Dolt data are no longer
registered as Dolt remotes or persisted to config.yaml.

This matches the stricter behavior already used by bd bootstrap's
detectBootstrapAction, which only sets SyncRemote when
refs/dolt/data exists.

Fixes #3356
2026-04-24 09:55:11 -07:00
Andreas Lingenhag
1e76efcfb6
fix: don't normalize user-provided sync.remote URLs (GH#3339) (#3432)
normalizeRemoteURL() converts http:// to git+http://, which breaks Dolt
remotesapi endpoints. Stop normalizing URLs from sync.remote (user
explicitly chose the format) while keeping normalization for auto-detected
git origin URLs. Also add git+http to allowedSchemes in remotecache so
ValidateRemoteURL accepts it.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-24 09:33:02 -07:00
Steven Syrek
c6d0cc2fd9
fix(init): refuse --force when remote has Dolt history (#3455)
* fix(init): refuse --force when remote has Dolt history

bd init --force in a repo whose origin has refs/dolt/data silently
skipped the bootstrap-from-remote path and then wired origin as a Dolt
remote anyway. The next write auto-pushed an orphan history, failing
with "no common ancestor". Recovery options were all destructive.

This change:

- Adds --reinit-local (named-intent replacement for --force) and
  --discard-remote (explicit cross-boundary authorization).
- Routes --force to --reinit-local with a DeprecationWarning. --force
  continues to work for ≥2 releases.
- Refuses bd init --force / --reinit-local when origin has
  refs/dolt/data, unless --discard-remote is also passed. Exit code 10
  (ExitRemoteDivergenceRefused).
- Adds stable numeric exit codes for init refusals (10/11/12).
- Adds bd init-safety documenting the full flag surface and the
  destroy-token format.
- Adds an internal race-safety re-check: if remote state changes
  during the TTY confirmation window, abort rather than overwrite.
- Retrofits the existing destroy-token echo at init.go:231 to not
  print a copy-pasteable destructive invocation, matching the new
  error-text-no-echo ADR invariant.

Adds:
- cmd/bd/init_safety.go — CheckRemoteSafety chokepoint (pure fn).
- cmd/bd/init_safety_test.go — guard matrix (13 cases) + subprocess
  regression test with a synthetic refs/dolt/data fixture.
- docs/adr/0002-init-safety-invariants.md — ADR encoding the five
  invariants (single-source identity, scope-bound --force, central
  chokepoint, error-text-no-echo, race-safety).
- docs/RECOVERY.md — named recovery playbooks per refusal exit code.
- .github/CODEOWNERS — review ownership for init*.go pointing at the
  ADR so future flags must extend the guard matrix.

Historical pattern (git log for cmd/bd/init.go): 8+ prior commits
patched individual surfaces of this class without encoding the
invariant. The guard matrix test is the structural hedge — adding a
new flag or data source is a signal to extend the table, not to add
another `&& !someFlag` at the call site.

(bd-q83)

* fix(init): satisfy lint for origin safety helpers (bd-main-nwo)

---------

Co-authored-by: matt wilkie <maphew@gmail.com>
2026-04-24 09:01:35 -07:00
matt wilkie
578524c0e9
[codex] Diagnose Dolt journal corruption and init lock hangs (#3457)
* fix: diagnose Dolt journal corruption on startup

* fix: prevent embedded init CI hang

* test(init): bound concurrent embedded init subprocesses

* test: align embedded dolt status concurrency expectation
2026-04-24 07:14:24 -07:00
Osamu Okano
69cd8af639
Merge remote-tracking branch 'upstream/main' into bd-where-is-slow 2026-04-23 09:51:21 +09:00
Shaun Taheri
a78e58388f
feat: support Unix domain sockets for Dolt server connections (#3300)
Add ServerSocket config field and BEADS_DOLT_SERVER_SOCKET env var to
connect to Dolt via unix sockets instead of TCP. This eliminates port
conflicts between concurrent projects and simplifies sandbox integration.

- Wire --server-socket CLI flag through bd init and bd dolt set (dolt.socket)
- Add GetDoltServerSocket() to configfile with env var precedence
- Socket mode disables auto-start with socket-specific error hints
- TLS settings honored regardless of transport
- Integration test: starts dolt sql-server --socket, verifies end-to-end SQL
- Document in README.md server mode table

Closes #2939
2026-04-21 22:12:15 -07:00
Harry Miller
80255b69ce
fix(bootstrap): clone via SQL server in external server mode (#3346)
When dolt_mode=server is configured in metadata.json (e.g. for an
externally managed dolt sql-server), bd bootstrap was cloning to the
local .beads/dolt/ directory instead of letting the server handle the
clone. The server never discovered the database, causing bd ready to
return empty results.

Root cause: cloneFromRemote() used isEmbeddedMode() which checks
runtime globals not yet initialized during bootstrap, defaulting to
embedded mode. finalizeSyncedBootstrap() had the same issue, resetting
dolt_mode back to embedded.

Fix:
- cloneFromRemote() now uses doltserver.ResolveServerMode() which reads
  metadata.json directly to determine the server lifecycle mode
- In ServerModeExternal, connects to the running server via MySQL and
  executes CALL DOLT_CLONE so the server places the database in its
  own data directory
- finalizeSyncedBootstrap() uses cfg.IsDoltServerMode() to preserve
  the server mode from the loaded config
- Added tests for both server-mode clone routing and mode preservation

Fixes #3343

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-20 17:56:20 -07:00
Miguel Miranda Dias
3c6c9db36b
fix(init): skip hooks during from-jsonl bootstrap commit (#3342) 2026-04-20 17:49:46 -07:00
Kevin Glynn
dbf793fdb6
fix: auto-sanitize hyphenated dolt_database on embedded-mode upgrade (#3231) (#3232)
Auto-sanitize hyphenated `dolt_database` names on embedded-mode upgrade. Projects initialized before #2142 retain hyphenated names in `metadata.json`; after the 1.0.0 embedded-mode default flip, those names are rejected by the embedded Dolt engine. This change detects legacy names on store open, renames the database directory, persists the fix to `metadata.json`, and adds a doctor check + init guard for future prevention.

Closes #3231. Related: #2142, #2160, #3128, #3129.

Thanks @kevglynn for the thorough fix, migration safety (collision detection, crash-safe ordering), and test coverage.
2026-04-20 13:17:26 -07:00
Osamu Okano
9a20251346
Merge branch 'main' into bd-where-is-slow
# Conflicts:
#	cmd/bd/main.go
2026-04-18 09:20:34 +09:00
Julian Knutsen
3c67e86400
fix: rebind selected workspace before db command startup (#3230)
* fix: rebind target workspace for db commands

* fix: isolate rebinding from caller workspace state

* fix: restore no-db target selection semantics

* fix: honor no-db target precedence consistently

* test: restore db flag state in context rebinding tests
2026-04-16 16:24:49 -07:00
coffeegoddd☕️✨
50f715b124 /{cmd,internal}: move local only state to dolt ignored tables 2026-04-14 14:47:30 -07:00
coffeegoddd☕️✨
fa87dd2bdd feat: add global beads_global database for shared-server mode
Adds a project-agnostic beads_global database to shared-server mode so
clients can track issues globally across all projects on the server.

- Add EnsureGlobalDatabase() to create the DB during shared server init
- Add --global persistent flag to switch CLI commands to the global DB
- Add global_dolt_database field to metadata.json for connection info
- Seed global DB with issue_prefix="global" and sentinel project ID
- Export/import default to global-issues.jsonl with --global flag
- --global errors when not in shared-server mode (additive, no breakage)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-14 09:18:43 -07:00
Osamu Okano
8684b8c68a
Merge branch 'main' into bd-where-is-slow 2026-04-14 21:47:31 +09:00
matt wilkie
64e504d541
fix: enable auto-export by default and add init prompt (GH#2973) (#3204)
* fix: enable auto-export by default with canonical issues.jsonl name (GH#2973)

Users expected JSONL export to refresh automatically but export.auto
defaulted to false, requiring explicit opt-in. Also the default filename
(export.jsonl) didn't match the canonical issues.jsonl used in docs and
git hooks. Change defaults: export.auto=true, export.path=issues.jsonl,
export.git-add=true so viewers (bv) and git workflows see fresh data
without extra configuration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat(init): add auto-export prompt and document export.* config (GH#2973)

Interactive bd init now asks whether to enable auto-export (default: yes).
Users can opt out during setup instead of discovering the setting later.

Also documents the export.* config namespace in bd config --help with
all four keys (export.auto, export.path, export.interval, export.git-add)
and adds export examples.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: document export.* auto-export config keys (GH#2973)

Document the export.auto/path/interval/git-add keys in docs/CONFIG.md
and note the default-on switch in CHANGELOG.md [Unreleased].

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(export): don't prime throttle on empty init and skip git-add without git (GH#2973)

Review feedback on #3204 surfaced two regressions in the default-on
auto-export path:

1. bd init's PersistentPostRun fired maybeAutoExport with zero issues,
   writing an empty .beads/issues.jsonl and saving export-state.json with
   the current dolt commit + timestamp. The next `bd create` was then
   throttled for up to export.interval (default 60s) because the
   timestamp check in maybeAutoExport returned before considering the new
   commit, leaving issues.jsonl stale on fresh repos.

   Skip saving state and remove the empty file when the export produced
   no issues and no memories. The next write runs a real export
   immediately.

2. export.git-add defaulting to true emitted
   `Warning: auto-export: git add failed: exit status 128` on every
   write in the supported standalone BEADS_DIR flow where init
   intentionally skips `git init`. Gate the git add call on isGitRepo()
   so standalone users get silent, working auto-export.

Adds a scripttest regression guard for the init -> immediate create
path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test(memory): disable auto-export in concurrent test (GH#2973)

TestEmbeddedMemoryConcurrent started failing on this branch after
auto-export became the default: every concurrent 'bd remember'/'bd
forget' call now fires maybeAutoExport, which reads store state after
the write. Under 8-worker contention this intermittently leaves a
forgotten key visible to 'bd memories'.

The test exercises memory concurrency, not export behavior; opt it
out of auto-export so the signal stays focused. Followup: investigate
the race between write commit and post-write auto-export read in
embedded Dolt concurrent paths.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-13 16:02:58 -07:00
Osamu Okano
f993aa6083
Merge remote-tracking branch 'origin/main' into bd-where-is-slow 2026-04-14 06:41:56 +09:00
matt wilkie
df2078b56f
fix(ci): collapse multiline expression in cross-version-smoke workflow (#3189)
* fix(ci): collapse multiline expression in cross-version-smoke workflow

Multi-line plain YAML scalars are invalid — the ${{ }} expression
spanning multiple lines caused GitHub to reject the workflow file
immediately (0s, "workflow file issue") on every push to main.

Collapse to a single-line expression; semantics are unchanged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): fix smoke test CWD, mode check, --silent compat, and prefix dots

Three independent bugs causing all 5 upgrade smoke scenarios to fail:

1. Smoke test CWD (root cause of most failures)
   - All `bd` invocations ran from the test script's CWD (the beads repo
     checkout), not from the isolated workspace $WS. This caused:
     * bd init to detect the beads repo's `origin` remote (has
       refs/dolt/data) and clone the entire beads Dolt database into $WS,
       corrupting the upgrade scenario and wasting minutes on chunk downloads.
     * `git config beads.role` to be written to the beads repo's git config
       instead of $WS's, so scenario 4's role check always failed.
   - Fix: add `prev()` and `cand()` helpers that cd into $WS before running.

2. `create --silent` not in binaries older than ~v1.1.0
   - --silent was added after the v1.0.0 release; calling it with older
     binaries silently failed (error to stderr, empty stdout), making every
     create attempt look like an init failure.
   - Fix: `prev_create()` helper tries --silent first, falls back to
     parsing any ID-like token from plain create output.

3. Mode preservation check used wrong path
   - Embedded Dolt stores data in `.beads/embeddeddolt/` (a directory).
     The test checked for `.beads/beads.db` (a file), which never exists
     in embedded mode, so the "DB exists before/after upgrade" assertions
     always failed.
   - Fix: `embedded_db_exists()` checks for either the directory
     (current embedded mode) or the legacy SQLite file.

Also fix issue_prefix dot sanitization in init.go (TestEmbeddedInit/
prefix_dot_sanitized): when a prefix like "GPUPolynomials.jl" is used,
`issue_prefix` stored in the DB must have dots replaced with underscores
(matching DoltDatabase sanitization), otherwise issue IDs contain dots.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): handle embedded-mode edge cases in upgrade smoke test

Three remaining failures after the CWD fix:

1. `storage.mode (not set)` treated as failure
   The `config get storage.mode` output includes the key name and "(not set)"
   when the config key doesn't exist. Embedded mode is the default and doesn't
   require an explicit setting, so any "not set" output should be accepted.
   Also accept the empty-string case that can arise with older config formats.

2. Embedded DB check too strict for v0.63.x
   v0.63.x was the first embedded-mode release; its init installed hooks and
   set beads.role correctly but may not have fully initialized the embeddeddolt/
   directory in CI due to early-release bugs. Changed the pre-upgrade check to
   verify `.beads/` directory exists (init ran) rather than the specific
   embeddeddolt/ subdirectory.

3. Create failures in old binaries treated as hard failures
   When an old binary cannot create issues (e.g. v0.63.x embedded init bug),
   the test now skips the data-migration and mutation checks with a `pass`
   (annotated as "skipped") rather than failing. The role-preservation and
   doctor checks still run.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(ci): handle pre-embedded (server-mode) releases in smoke test scenario 3

v0.60.0-v0.62.0 used server mode and required an external Dolt server
to initialize. Without a running server in CI, their init installs hooks
but cannot create .beads/. The mode-preservation scenario was treating
this as a failure.

Change the pre-upgrade check in scenario 3 to skip gracefully when
.beads/ doesn't exist (old binary requires external server). The scenario
still runs candidate init and verifies the candidate defaults to embedded
mode — which is the meaningful test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-11 10:34:02 -07:00
Osamu Okano
c9eb8ec384
fix(init): sanitize dotted prefixes consistently (beads-oko) 2026-04-11 19:22:18 +09:00
Jim Wordelman
652d321968
fix: set FS_NOCOW_FL on .beads/ at init to avoid btrfs kworker thrashing (#3162)
Co-authored-by: quad341 <quad341@users.noreply.github.com>
2026-04-10 21:52:18 -07:00
Okano, Osamu
ef6c6e3e48
Follow up remaining runtime .beads fallbacks after GH#3124 (#3183)
* fix(workspace): align resolved workspace messaging and config lookup

intent(workspace): pure worktrees and external BEADS_DIR setups should work without implying a local .beads directory is required
decision(config): derive config repo roots from FindBeadsDir-backed workspace resolution instead of a local-only .beads walk
constraint(workspace-detection): keep FindBeadsDir ordering and storage behavior unchanged while making bd where the primary diagnostic hint
learned(testing): shared-server env and global .beads ignore rules can distort CGO suites, so regression coverage now normalizes those test paths

* fix(bootstrap): align no-workspace JSON wording

intent(bootstrap): machine-readable no-workspace output should match the resolved-workspace guidance used elsewhere on this branch
decision(bootstrap-json): reuse the shared workspace error helpers through a dedicated payload builder so tests can lock the JSON contract
constraint(review-loop): keep the bootstrap CLI flow unchanged outside the no-workspace JSON branch while adding a focused regression test

* fix(where): allow no-workspace diagnostics without db (beads-9f74-5l1)

intent(where): no-workspace guidance should point to a command that actually runs when workspace resolution fails
decision(startup): treat top-level where as a no-db command so it reaches its own handler before database preflight
constraint(where-tests): subprocess mode can change the exact hint text, so the regression test locks the JSON contract and stable guidance fragments instead

* fix(bootstrap): restore bd where guidance for no-workspace output (beads-9f74-3c3)

intent(bootstrap): no-workspace bootstrap guidance should match the resolved-workspace diagnostics introduced on this branch
decision(no-workspace-hints): reuse the shared hint that mentions bd where instead of the bootstrap-specific fallback text
constraint(bootstrap-tests): cover both the payload helper and subprocess CLI path so wording regressions are caught before release

* fix(workspace): remove no-workspace .beads fallbacks (beads-9f74-gr1)

intent(workspace-resolution): finish the GH#3124 follow-up for runtime paths that still fabricated local .beads state
rejected(no-workspace-fallback): inventing ./ .beads paths outside an active workspace hid shared-worktree resolution and created stray files
decision(setup-recipes): keep built-in bd setup recipes usable without a workspace but require an active workspace for custom recipe state
constraint(worktree-support): completion and backup helpers still need to resolve shared main-repo workspaces from a git worktree

* fix(config): skip no-workspace store init for store-free commands

intent(config): review-fix-loop found no-workspace config commands should reach their own graceful paths instead of failing in PersistentPreRun
decision(config-preflight): detect store-free config subcommands before DB synthesis so config.yaml, git-backed, and diagnostic flows can run without an opened store
constraint(json-contract): keep bd config validate --json machine-readable on stdout once pre-run stops short-circuiting into low-level DB errors
learned(config-preflight): the parent config command not being in noDbCommands leaked store init into show, validate, drift, apply, and yaml-only config helpers

* fix(ci): restore init prefix normalization and formatting

intent(ci): clear the current PR failures instead of leaving the branch blocked behind known red checks

decision(init-prefix): normalize dotted prefixes before persisting issue_prefix so config, metadata.json, and Dolt database naming stay aligned for Julia-style repos
constraint(fmt-check): CI runs gofmt over the whole repo, so the existing spacing drift in internal/jira/tracker_test.go had to be cleaned up on this branch to get a green run
learned(ci): the latest main CI was already red on the same formatting file and the same embedded shard, so rebasing surfaced pre-existing blockers rather than introducing a new shard-only regression
2026-04-10 21:23:14 -07:00
coffeegoddd☕️✨
1684130a26 /{cmd,docs,internal}: get bootstrap and init working correctly and remote agnostic 2026-04-10 14:37:49 -07:00
coffeegoddd☕️✨
c96008f975 /cmd/bd: unify behavior of bd init and bootstrap 2026-04-10 14:36:19 -07:00
Graeme Foster
1a218aa56f
fix: explicitly disable TLS in Dolt connections when not configured (#3107)
go-sql-driver/mysql v1.8+ changed the default TLS mode from "false" to
"preferred", causing all connections to attempt TLS negotiation. Dolt
servers without TLS configured reject this with "TLS requested but server
does not support TLS" instead of gracefully declining.

- ServerDSN.String() now explicitly sets tls=false when TLS is not enabled
- All ServerDSN call sites plumb cfg.GetDoltServerTLS() so Hosted Dolt
  users with BEADS_DOLT_SERVER_TLS=1 get TLS on every code path
- Added dsn_test.go with explicit TLS on/off assertions

Authored-by: Graeme Foster <80714+GraemeF@users.noreply.github.com>
2026-04-10 13:55:06 -07:00
Jack J Garzella
f3d4293b35
fix(init): sanitize dots in metadata.json DoltDatabase and add early validation (#3129)
Two bugs in bd init when the directory name contains dots (e.g. GPUPolynomials.jl):

1. metadata.json mismatch: dbName sanitized hyphens AND dots to underscores,
   but cfg.DoltDatabase only sanitized hyphens. This caused init in dotted
   directories to create a database under one name but record a different name
   in metadata.json, breaking every subsequent command.

2. No early validation for characters that survive sanitization (spaces, @, etc.):
   errors came from deep in the storage layer with no actionable hint.

Fixes #3128

Co-Authored-By: JJ Garzella <jjgarzella@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-10 13:51:41 -07:00
matt wilkie
fe1b5a880e
Merge pull request #3115 from osamu2001/fix/init-force-worktree-count
fix: add worktree fallback to countExistingIssues
2026-04-10 11:48:12 -07:00
coffeegoddd☕️✨
0c2dfc14af /{cmd,internal}: shared server concurrency tests 2026-04-08 13:22:54 -07:00
Osamu Okano
614d925868
test: add worktree test for init force count fallback 2026-04-08 07:25:42 +09:00
Osamu Okano
cadf02e811
fix: add worktree fallback to countExistingIssues
countExistingIssues() used CWD-relative ".beads" which doesn't
exist in worktrees. Added GetWorktreeFallbackBeadsDir() fallback
matching the pattern in checkExistingBeadsData().
2026-04-07 22:19:15 +09:00
matt wilkie
4fe05a3bec
Use getting started docs as bugs to fix (#3034)
* fix: narrow cross-version smoke CI triggers and warn on high skip rate

Remove push-to-main and PR triggers from cross-version smoke test
workflow — 30-45 min runtime is too costly for every push. Keep tag
pushes (releases/RCs) and manual dispatch.

Add a visible warning when >80% of tested versions are skipped, printed
to stderr and GitHub step summary. Prevents silent "all passed" when
nearly nothing actually ran.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: add .buildflags for consistent ICU build configuration

Amp-Thread-ID: https://ampcode.com/threads/T-019d5c3f-42eb-7794-8d59-524bbf77bdf8
Co-authored-by: Amp <amp@ampcode.com>

* Add analysis of getting-started docs: necessity vs. fixable errors

Analyzes ~3,200 lines of getting-started documentation across 9 files.
Finds ~50% of the content compensates for tool-level UX gaps that should
be fixed rather than documented. Categorizes every section as genuinely
necessary, useful reference, workaround for fixable issue, or redundant.
Includes specific recommendations for both tool fixes and doc consolidation.

Requested by @csells.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* Streamline getting-started docs: reduce noise, fix user-facing paths

QUICKSTART.md:
- Change all ./bd to bd (reflects installed binary, not local build)
- Replace go-build install section with brew/npm + link to INSTALLING.md
- Remove Notion sync, database maintenance, and migration sections
  (these are advanced topics, not quickstart material)
- Add "Database maintenance" link to Next Steps

README.md:
- Consolidate installation from ~30 lines to ~8 lines
- Remove CGO/build-from-source details (belong in INSTALLING.md)
- Add links to INSTALLING.md sections for all install methods

INSTALLING.md:
- Demote go install/source to "Contributors / Go developers" in matrix
- Move Build Dependencies section after platform installs, retitle to
  "Build Dependencies (Contributors Only)" with skip-if-prebuilt note
- Add cross-reference to TROUBLESHOOTING.md in troubleshooting section

Net effect: -91 lines, clearer separation between user and contributor
paths, less noise in the first-time experience.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* fix: detect permission errors in bd init with platform-specific guidance

On Windows, Controlled Folder Access can block bd init from creating
.beads/ with no useful error. Now detects os.IsPermission and prints
specific guidance for Windows (CFA whitelist instructions) and Unix
(ls -la / chmod suggestions) instead of a generic failure message.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* fix: add circuit breaker cleanup to bd doctor --fix

Stale circuit breaker files in /tmp/beads-circuit/ can block all bd
operations. Previously users had to manually rm these files. Now
bd doctor detects stale breaker files as a fixable check, and
bd doctor --fix clears them automatically via CleanStaleCircuitBreakerFiles.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* feat: warn about multiple bd binaries in PATH

bd version now scans PATH for duplicate bd executables and warns when
more than one is found. This catches the common case where go install
and Homebrew binaries coexist, causing version confusion. Symlinks
are resolved to avoid false positives.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* fix: show holding process PID in database lock errors

When the Dolt database is locked, the error message now tries to
identify the holding process by scanning /proc for bd/dolt processes.
On Linux, users see e.g. "Process 12345 (bd/dolt) may be holding
the lock." Gracefully degrades to the previous message on platforms
without /proc (macOS, Windows, FreeBSD).

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* fix: only flag circuit breaker files as stale after TTL expires

CheckCircuitBreaker() was counting any open/half-open breaker as stale
regardless of age. This could reset a legitimately active breaker
during a real outage. Now uses the same 5-minute staleness threshold
as CleanStaleCircuitBreakerFiles() — only breakers older than 5 minutes
(from TrippedAt or LastFailure) are flagged for cleanup.

https://claude.ai/code/session_01Fak22deVmDX3KRBKVptJBL

* fix: correct broken doc anchors in README installation links

The "go install" and "from source" links pointed to nonexistent anchors
in INSTALLING.md. Found during review checklist testing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: suppress gosec G304 false positive in circuit breaker check

Path comes from filepath.Glob with a controlled pattern, matching
the same nolint pattern used in internal/storage/dolt/circuit.go.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Amp <amp@ampcode.com>
2026-04-05 16:09:58 -07:00
beads/crew/emma
543e1943b6 fix: prevent concurrent embedded Dolt panic with exclusive flock (#2571)
When two bd commands ran simultaneously against the same embedded Dolt
database, the second process could panic with a nil-pointer dereference
in DoltDB.SetCrashOnFatalError during engine initialization. The race
occurs because dolthub/driver.NewConnector is not safe for concurrent
initialization on the same data directory.

The fix acquires an exclusive flock in embeddeddolt.New() for the entire
store lifetime. The second process now receives a clear error message
instead of panicking. The lock is released in Close(). A WithLock option
allows bd init (which acquires the lock earlier) to pass its pre-held
lock and avoid double-locking on macOS where flock is per-fd.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Executed-By: beads/crew/emma
2026-04-02 21:27:37 -07:00
Fredrik Källström
63c7a2601d
fix: adopt existing project_id when init --database targets shared server (#2925)
When a second user runs bd init --database against an existing remote
Dolt database, adopt the server's _project_id instead of generating a
new one. Prevents PROJECT IDENTITY MISMATCH errors in team workflows.

Fixes #2922
2026-04-02 20:28:49 -07:00
matt wilkie
223895b89f
fix: make bd setup claude project-local by default and auto-setup in bd init (#2935) (#2972)
Changes:
- bd setup claude now defaults to project-local (.claude/settings.json)
  instead of global (~/.claude/settings.json)
- bd setup claude --global explicitly installs globally
- bd init automatically runs Claude hook setup (project-local)
- Legacy .claude/settings.local.json hooks are auto-migrated on install
  and cleaned on remove
- bd setup claude --check detects legacy installs with migration hint
- bd init stages .claude/settings.json and CLAUDE.md for git commit

Closes #2935

Amp-Thread-ID: https://ampcode.com/threads/T-019d4fc1-6587-75cb-bdcb-1912a98cb1c1

Co-authored-by: Amp <amp@ampcode.com>
2026-04-02 20:28:36 -07:00
matt wilkie
baa9d02457
fix: treat --shared-server as server mode for DoltMode (#2947)
* fix: prevent silent fallback to embedded mode when shared-server is active (GH#2949)

Root cause: ResolveServerMode() and IsDoltServerMode() checked
metadata.json dolt_mode=embedded BEFORE runtime env vars, so stale
persisted metadata silently overrode active shared-server config.

Fixes:
- ResolveServerMode: env vars (BEADS_DOLT_SERVER_MODE, BEADS_DOLT_SHARED_SERVER)
  now checked before metadata.json, preventing stale embedded override
- IsDoltServerMode: now checks BEADS_DOLT_SHARED_SERVER env var (shared-server
  implies server-backed storage)
- warnSharedServerEmbeddedMismatch -> repairSharedServerEmbeddedMismatch:
  auto-repairs stale dolt_mode=embedded in metadata.json instead of just warning
- Added 6 regression tests covering the upgrade path

Closes #2949

Amp-Thread-ID: https://ampcode.com/threads/T-019d4b84-cddd-725a-a3c6-ee7e3631f2aa
Co-authored-by: Amp <amp@ampcode.com>

* fix: treat --shared-server as server mode for metadata.json DoltMode (#2946)

--shared-server sets BEADS_DOLT_SHARED_SERVER for directory resolution but
never set initServerMode, so metadata.json recorded DoltMode as "embedded"
and all subsequent commands used embedded Dolt despite config.yaml having
dolt.shared-server: true.

Also override metadata.json at runtime when dolt.shared-server is set,
so existing installs with stale metadata.json are handled without re-init.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: ensure shared server runs during init and fix isEmbeddedMode check

Two additional fixes for GH#2946:

1. Init auto-starts the shared Dolt server if not already running,
   since ResolveServerMode classifies shared-server as External
   which suppresses the normal auto-start path.

2. isEmbeddedMode() now checks doltserver.IsSharedServerMode() as a
   fallback. Dolt subcommands (status, start, stop) skip DB init in
   PersistentPreRun, so serverMode is never set from metadata.json.
   Without this, "bd dolt status" would still report embedded mode
   even with dolt.shared-server: true in config.yaml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: apply shared-server override to loadServerModeFromConfig()

Closes the gap flagged in PR review: no-db commands (bd dolt start,
bd dolt status, bd doctor, etc.) go through loadServerModeFromConfig()
which didn't have the shared-server override for stale metadata.json.

This ensures isEmbeddedMode() returns false for all command paths when
dolt.shared-server is true in config.yaml, not just commands that pass
the no-db guard in PersistentPreRun.

GH#2946

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d4f6f-01f8-72d4-b474-f75d7909b8b9

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-02 11:52:20 -07:00
matt wilkie
ba46bd5f3b
fix: repair nightly test failures for TestInitCancel_E2E and dolt autostart (#2969)
TestInitCancel_E2E: The --contributor flag was rejected because
isNonInteractiveInit() detected non-interactive mode (CI=true + piped
stdin). Fix by supporting BD_NON_INTERACTIVE=0/false to explicitly
force interactive mode, and set it in the test env.

TestE2E_AutoStartedRepoLocalServerPersistsAcrossCommands: init
defaulted to embedded mode since a35edfd2, but the test needs server
mode for dolt status/start/stop. Fix by adding --server to init args.

Also adds unit tests for the new BD_NON_INTERACTIVE=0 override.

Amp-Thread-ID: https://ampcode.com/threads/T-019d4f2d-9137-742b-bf44-ed413fe59cd0

Co-authored-by: Amp <amp@ampcode.com>
2026-04-02 11:04:32 -07:00
matt wilkie
ca1ae15d02
Fix init leaving beads.role unset in edge cases (GH#2950) (#2964)
Root cause: multiple code paths in bd init could skip setting beads.role:
- BEADS_DIR set → git init skipped → isGitRepo() false → role block skipped
- promptContributorMode() fails → role never set
- Non-interactive without explicit --role → only sets if not already present

Fix: Add safety net at end of init that checks isGitRepo() && !hasRole
and defaults to 'maintainer' (or --role value). This guarantees every
init leaves beads.role configured.

Also:
- Improve routing.go warning to show one-command fix
- Update doctor check fix to use 'git config' directly (simpler)
- Add TestInitNonInteractiveAlwaysSetsRole regression test

Amp-Thread-ID: https://ampcode.com/threads/T-019d4a99-63c8-779f-bb8e-ee8522b61cdf

Co-authored-by: Amp <amp@ampcode.com>
2026-04-01 17:00:41 -07:00
matt wilkie
dbcc2db0a9
[codex] Fix installer ICU/CGO fallback handling (#2965)
* Fix shared-server init mode selection

* Warn on shared-server embedded metadata mismatch

* Fix installer ICU/CGO fallback handling
2026-04-01 16:52:53 -07:00