Commit graph

19 commits

Author SHA1 Message Date
Medhat Galal
57ddb0bbfe
fix: bd admin commands fail with 'embedded mode' error in server mode (#3438)
PersistentPreRunE on adminCmd fires before main.go's PersistentPreRun
sets serverMode/cmdCtx.ServerMode. Cobra runs child PersistentPreRunE
before parent PersistentPreRun, so isEmbeddedMode() sees cmdCtx.ServerMode
as false (zero value) even when metadata.json declares dolt_mode=server.

Fix: remove PersistentPreRunE from adminCmd. Add requireServerMode() helper
and call it at the top of each subcommand's Run func, after store init has
populated cmdCtx.ServerMode correctly.

Fixes: bd admin compact, bd admin cleanup, bd admin reset all returning
'not yet supported in embedded mode' for server-mode projects.
2026-04-28 06:33:03 -07:00
matt wilkie
70e159689b fix: remove redundant os.Stat check after FindBeadsDir
FindBeadsDir() already validates directory existence internally,
so the subsequent os.Stat guard is unreachable dead code.

Co-Authored-By: osamu2001 <osamu2001@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-10 11:49:56 -07:00
Osamu Okano
9a51646bce
test: add worktree test for reset beads dir resolution 2026-04-08 07:14:43 +09:00
Osamu Okano
c2c2306981
fix: use FindBeadsDir for worktree-aware reset
Hardcoded ".beads" path doesn't exist in worktrees, causing
bd reset to report "not initialized" incorrectly.
2026-04-07 22:19:15 +09:00
obsidian
1838b30924 refactor: remove 3-way merge engine remnants (bd-hhh)
Remove dead code from the defunct bd merge command:

- staleness.go/staleness_test.go: JSONL mtime freshness checks
  (checkDatabaseFreshness, refreshLastImportTime, --allow-stale flag)
- doctor/git.go: CheckMergeDriver, FixMergeDriver
- doctor/git_test.go: merge driver test cases
- doctor_fix.go: "Git Merge Driver" fix case
- reset.go: hasMergeDriverConfig, hasGitattributesEntry,
  removeGitattributesEntry, and merge driver/gitattributes reset items
- reset_test.go: removeGitattributesEntry tests
- context.go: AllowStale field and isAllowStale function
- cli_coverage_show_test.go: --allow-stale flag usage

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-04 23:44:35 -08:00
emma
c690613ced fix: resolve CI lint and formatting failures
- Fix gofmt formatting in 30 files under internal/storage/dolt/ and factory/
- Remove unused daemonFunc param from processBatchLabelOperation (label.go)
- Remove dead routedArgs loops from showIssueChildren and showIssueRefs
- Fix unused params: dbPathArg, orphanHandling, opts (import_engine.go),
  beadsDir (reset.go)
- Add nolint:unparam for burnWisps error return (kept for API consistency)
- Fix unchecked MarkFlagRequired in human.go
- Simplify truncateSnippet to hardcode max=50 (bootstrap.go)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Executed-By: beads/crew/emma
Rig: beads
Role: crew
2026-02-10 12:30:56 -08:00
quartz
326976614d feat: remove daemon subsystem from bd CLI (dolt-test-jjsjn)
Remove the daemon subcommand, --no-daemon flag, and all daemon-related
code from bd. With Dolt native backend, there is no daemon. This
eliminates the deepest heresy vector where agents see daemon flags
and conclude beads has a daemon architecture.

Deleted 65+ daemon-specific files (~24.7k lines) including:
- daemon.go, daemon_autostart.go, daemon_sync.go, daemon_server.go, etc.
- internal/daemon/ package (registry, discovery, kill_*)
- doctor/daemon.go, doctor/fix/daemon.go
- activity.go (daemon-only activity command)
- All corresponding test files

Edited core files to remove daemon references:
- main.go: removed --no-daemon flag, daemon connection block, imports
- context.go: removed DaemonClient, DaemonStatus, NoDaemon fields
- direct_mode.go: simplified to remove daemon fallback logic
- doctor.go: removed daemon health checks
- init.go: removed daemon stop before reinit
- reset.go: removed daemon stop logic
- worktree.go: removed daemon worktree safety checks

Created compatibility stubs:
- daemon_deprecated.go: stub variables/functions for 66 files that
  still reference daemonClient (always nil), enabling gradual cleanup
- sync_helpers.go: extracted non-daemon sync functions (export/import)
- sync_state.go: extracted sync state management

Follow-up: Remove dead `if daemonClient != nil` branches from 66
command files, then delete daemon_deprecated.go and internal/rpc.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Executed-By: beads/polecats/quartz
Rig: beads
Role: polecats
2026-02-09 21:47:31 -08:00
beads/crew/lizzy
2bb827facb style: run gofmt across entire codebase (bd-nmk12)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 19:35:20 -08:00
matt wilkie
1f8a6bf84e
fix(autoimport): auto-correct deleted status to tombstone for JSONL compatibility (#1231)
* fix(autoimport): auto-correct deleted status to tombstone for JSONL compatibility (GH#1223)

This fix addresses the 'Stuck in sync diversion loop' issue where v0.48.0
encountered validation errors during JSONL import. The issue occurs when
JSONL files from older versions have issues with status='deleted' but the
current code expects status='tombstone' for deleted issues.

Changes:
- Add migration logic in parseJSONL to auto-correct 'deleted' status to 'tombstone'
- Ensure tombstones always have deleted_at timestamp set
- Add debug logging for both migration operations
- Prevents users from being stuck in sync divergence when upgrading

Fixes GH#1223: Stuck in sync diversion loop

* fix(autoimport): comprehensively fix corrupted deleted_at on non-tombstone issues (GH#1223)

The initial fix for GH#1223 only caught issues with status='deleted', but the real
data in the wild had issues with status='closed' (or other statuses) but also
had deleted_at set, which violates the validation rule.

Changes:
- Add broader migration logic: any non-tombstone issue with deleted_at should become tombstone
- Apply fix in all three JSONL parsing locations:
  - internal/autoimport/autoimport.go (parseJSONL for auto-import)
  - cmd/bd/import.go (import command)
  - cmd/bd/daemon_sync.go (daemon sync helper)
- Add comprehensive test case for corrupted closed issues with deleted_at
- Fixes the 'non-tombstone issues cannot have deleted_at timestamp' validation error
  during fresh bd init or import

Fixes GH#1223: Stuck in sync diversion loop

* Add merge driver comment to .gitattributes

* fix: properly clean up .gitattributes during bd admin reset

Fixes GH#1223 - Stuck in sync diversion loop

The removeGitattributesEntry() function was not properly cleaning up
beads-related entries from .gitattributes. It only removed lines
containing "merge=beads" but left behind:
- The comment line "# Use bd merge for beads JSONL files"
- Empty lines following removed entries

This caused .gitattributes to remain in a modified state after
bd admin reset --force, triggering sync divergence warning loop.

The fix now:
- Skips lines containing "merge=beads" (existing behavior)
- Skips beads-related comment lines
- Skips empty lines that follow removed beads entries
- Properly cleans up file so it's either empty (and gets deleted)
  or contains only non-beads content

---------

Co-authored-by: Amp <amp@example.com>
2026-01-21 21:50:38 -08:00
Zain Rizvi
e723417168
Fix git hooks not working in worktrees (#1126)
Git hooks are shared across all worktrees and live in the common git
directory (e.g., /repo/.git/hooks), not the worktree-specific directory
(e.g., /repo/.git/worktrees/feature/hooks).

The core issue was in GetGitHooksDir() which used GetGitDir() instead
of GetGitCommonDir(). This caused hooks to be installed to/read from
the wrong location when running in a worktree.

Additionally, several places in the codebase manually constructed
hooks paths using gitDir + "hooks" instead of calling GetGitHooksDir().
These have been updated to use the proper worktree-aware path.

Affected areas:
- GetGitHooksDir() now uses GetGitCommonDir()
- CheckGitHooks() uses GetGitHooksDir()
- installHooks/uninstallHooks use GetGitHooksDir()
- runChainedHook() uses GetGitHooksDir()
- Doctor checks use git-common-dir for hooks paths
- Reset command uses GetGitCommonDir() for hooks and beads-worktrees

Symptoms that this fixes:
- Chained hooks (pre-commit.old) not running in worktrees
- bd hooks install not finding/installing hooks correctly in worktrees
- bd hooks list showing incorrect status in worktrees
- bd doctor reporting incorrect hooks status in worktrees

Co-authored-by: Zain Rizvi <4468967+ZainRizvi@users.noreply.github.com>
2026-01-16 12:01:43 -08:00
Steve Yegge
d77a697cee feat: add bd admin parent command for cleanup/compact/reset (bd-3u8m)
Move cleanup, compact, and reset commands under `bd admin` namespace.
Creates hidden aliases for backwards compatibility that show deprecation
notice when used.

- Create cmd/bd/admin.go with parent command
- Create cmd/bd/admin_aliases.go for hidden backwards-compat aliases
- Update cleanup.go, compact.go, reset.go to remove rootCmd.AddCommand
- Update all documentation to use `bd admin <cmd>` syntax

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-27 16:21:08 -08:00
Steve Yegge
25061ea9a7 chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)
- Remove TestFindJSONLPathDefault from .test-skip (now passes)
- Add explanatory comments to 24 ignored error locations in cmd/bd:
  - Cobra flag methods (MarkHidden, MarkRequired, MarkDeprecated)
  - Best-effort cleanup/close operations
  - Process signaling operations

Part of code health review epic bd-tggf.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 21:30:57 -08:00
Ryan Snodgrass
cafc0b9dfb refactor(doctor): consolidate maintenance commands + improve daemon startup
Consolidate clean, repair-deps, validate into bd doctor:
- Add validation checks to doctor (merge artifacts, orphaned deps, duplicates, test pollution, git conflicts)
- Add auto-fix for merge artifacts and orphaned dependencies
- Delete obsolete command files: clean.go, repair_deps.go, validate.go
- Delete orphaned test files: clean_security_test.go, validate_test.go

Improve daemon startup performance:
- Add fast-fail detection when daemon crashed (check lock before retrying)
- Reduce graceful shutdown timeout from 5s to 1s
- Skip daemon connection for root command (just shows help)
- Extract shutdown timeout as constants (daemonShutdownTimeout, daemonShutdownPollInterval)

Other changes:
- Move rename-prefix command to Maintenance group in help
- Fix Makefile to inject git commit hash via ldflags

New files:
- cmd/bd/doctor/validation.go (5 check functions)
- cmd/bd/doctor/fix/validation.go (2 fix functions)
2025-12-22 20:21:30 -08:00
Ryan Snodgrass
6ca141712c
refactor(ui): standardize on lipgloss semantic color system
Replace all fatih/color usages with internal/ui package that provides:
- Semantic color tokens (Pass, Warn, Fail, Accent, Muted)
- Adaptive light/dark mode support via Lipgloss AdaptiveColor
- Ayu theme colors for consistent, accessible output
- Tufte-inspired data-ink ratio principles

Files migrated: 35 command files in cmd/bd/

Add docs/ui-philosophy.md documenting:
- Semantic token usage guidelines
- Light/dark terminal optimization rationale
- Tufte and perceptual UI/UX theory application
- When to use (and not use) color in CLI output
2025-12-20 17:09:50 -08:00
Steve Yegge
52f3363b0f fix: resolve all golangci-lint errors
- errcheck: explicitly discard error returns for git config --unset
- gosec G304: add nolint for safe file read from hardcoded list
- gosec G306: add nolint for .gitattributes (must be world-readable)
- unparam: remove unused gitDir param, use _ for unused ctx
- unparam: change functions with always-nil error returns to void

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-16 17:50:25 -08:00
Steve Yegge
4b5ea05da2 feat: add bd reset command (GH#505)
Adds a new 'bd reset' command that completely removes beads from a repository:
- Stops running daemon
- Removes git hooks (pre-commit, post-merge, pre-push, post-checkout)
- Removes merge driver configuration
- Removes .gitattributes entry
- Removes sync branch worktrees
- Removes .beads directory

By default runs in dry-run mode showing what would be deleted.
Use --force to actually perform the reset.

Closes steveyegge/beads#505
2025-12-14 17:39:54 -08:00
matt wilkie
e01b7412d9 feat: add Git worktree compatibility (PR #478)
Adds comprehensive Git worktree support for beads issue tracking:

Core changes:
- New internal/git/gitdir.go package for worktree detection
- GetGitDir() returns proper .git location (main repo, not worktree)
- Updated all hooks to use git.GetGitDir() instead of local helper
- BeadsDir() now prioritizes main repository's .beads directory

Features:
- Hooks auto-install in main repo when run from worktree
- Shared .beads directory across all worktrees
- Config option no-install-hooks to disable auto-install
- New bd worktree subcommand for diagnostics

Documentation:
- New docs/WORKTREES.md with setup instructions
- Updated CHANGELOG.md and AGENT_INSTRUCTIONS.md

Testing:
- Updated tests to use exported git.GetGitDir()
- Added worktree detection tests

Co-authored-by: Claude <noreply@anthropic.com>
Closes: #478
2025-12-13 12:50:33 -08:00
Steve Yegge
2fd1d1fb87 fix: resolve golangci-lint warnings
- Handle ignored errors with explicit _ assignment (errcheck)
- Add #nosec comments for false positive G304/G204 warnings (gosec)
- Fix misspelling: cancelled -> canceled

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-13 10:07:36 +11:00
Steve Yegge
88153f224f feat(reset): implement bd reset CLI command with unit tests
Implements the bd reset command for GitHub issue #479:
- CLI command with flags: --hard, --force, --backup, --dry-run, --skip-init, --verbose
- Impact summary showing issues/tombstones to be deleted
- Confirmation prompt (skippable with --force)
- Colored output for better UX
- Unit tests for reset.go and git.go
- Fix: use --force flag in git rm to handle staged files

Part of epic bd-aydr.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-13 10:00:47 +11:00