Convert direct fmt.Fprintf(os.Stderr)+os.Exit(1) patterns to FatalError(),
FatalErrorWithHint() in delete.go, ship.go, mol_distill.go, find_duplicates.go,
show_thread.go. Scope note: ~400 remaining call sites across 50+ files.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Strip out the multi-backend storage layer: factory pattern, memory/in-memory
provider, connection string parsing, local provider, and associated tests.
Inline Dolt as the sole storage backend. Part of Dolt-Native Beads v2 epic.
WIP - SQLite removal in progress, more cleanup phases to follow.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
Phase 2 of Dolt transition (woho.2): Remove the entire daemon/RPC layer
now that all commands use direct storage access.
- Delete internal/rpc/ directory (40 files, ~11K lines)
- Delete daemon_deprecated.go stub layer
- Delete compact_rpc.go (daemon-only compact via RPC)
- Delete daemon-specific test files (delete_rpc_test.go, direct_mode_test.go,
dual_mode_test.go, list_watch_test.go)
- Clean up remaining daemon references in ~25 source files:
- Remove daemon RPC branches from update, create, template, markdown,
gate_discover, mol_stale, mol_current, import, query, version, prime
- Remove rpc.Client parameter from show_thread functions
- Simplify info.go to always show "direct" mode
- Simplify sync_import.go to always use inline import
- Remove daemon status checks from staleness, migrate_dolt, rename_prefix
- Remove unused fallbackToDirectMode function
- Remove stale daemon comments from sync.go
- Add daemon_compat.go with --no-daemon flag (backward compat for hooks)
and utility functions (boolToFlag, truncateString, formatUptime, progressBar)
- Fix test files: remove daemonClient cleanup blocks, update findRepliesTo/
findReplies call signatures, remove RPC test functions
- go vet ./... passes clean
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Since daemonClient is always nil (daemon_deprecated.go stub), every
`if daemonClient != nil` branch was dead code. This removes all 171
occurrences across 56 command files, keeping only the direct storage
(else) branches. Also cleans up unused rpc/json/types imports and
fixes variable shadowing issues left behind.
Part of Dolt transition Phase 2 (dolt-test-woho epic).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Executed-By: beads/crew/emma
Rig: beads
Role: crew
GetDependentsWithMetadata is on the Storage interface, so call it directly
instead of type-asserting to *sqlite.SQLiteStorage. Removes the slow
GetAllDependencyRecords fallback path that Dolt would have hit.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>