Commit graph

7 commits

Author SHA1 Message Date
coffeegoddd☕️✨
58915b13e7 /{cmd,internal}: update global store to be interface 2026-03-17 13:26:17 -07:00
beads/crew/wickham
41e47e1665 refactor: standardize error handling with FatalError wrappers (bd-qioh)
Convert direct fmt.Fprintf(os.Stderr)+os.Exit(1) patterns to FatalError(),
FatalErrorWithHint() in delete.go, ship.go, mol_distill.go, find_duplicates.go,
show_thread.go. Scope note: ~400 remaining call sites across 50+ files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-21 15:36:34 -08:00
beads/crew/emma
a5da57e39b refactor: remove storage factory, memory backend, and provider abstraction (Phase 7)
Strip out the multi-backend storage layer: factory pattern, memory/in-memory
provider, connection string parsing, local provider, and associated tests.
Inline Dolt as the sole storage backend. Part of Dolt-Native Beads v2 epic.

WIP - SQLite removal in progress, more cleanup phases to follow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Executed-By: beads/crew/emma
Rig: beads
Role: crew
2026-02-15 11:27:39 -08:00
elinor
b136996b90 refactor: delete daemon/RPC layer and internal/rpc/ package (-19,663 lines)
Phase 2 of Dolt transition (woho.2): Remove the entire daemon/RPC layer
now that all commands use direct storage access.

- Delete internal/rpc/ directory (40 files, ~11K lines)
- Delete daemon_deprecated.go stub layer
- Delete compact_rpc.go (daemon-only compact via RPC)
- Delete daemon-specific test files (delete_rpc_test.go, direct_mode_test.go,
  dual_mode_test.go, list_watch_test.go)
- Clean up remaining daemon references in ~25 source files:
  - Remove daemon RPC branches from update, create, template, markdown,
    gate_discover, mol_stale, mol_current, import, query, version, prime
  - Remove rpc.Client parameter from show_thread functions
  - Simplify info.go to always show "direct" mode
  - Simplify sync_import.go to always use inline import
  - Remove daemon status checks from staleness, migrate_dolt, rename_prefix
  - Remove unused fallbackToDirectMode function
  - Remove stale daemon comments from sync.go
- Add daemon_compat.go with --no-daemon flag (backward compat for hooks)
  and utility functions (boolToFlag, truncateString, formatUptime, progressBar)
- Fix test files: remove daemonClient cleanup blocks, update findRepliesTo/
  findReplies call signatures, remove RPC test functions
- go vet ./... passes clean

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-10 12:10:24 -08:00
Steve Yegge
6a51223b6f refactor: remove 171 dead if daemonClient != nil branches from 56 files (-3,384 lines)
Since daemonClient is always nil (daemon_deprecated.go stub), every
`if daemonClient != nil` branch was dead code. This removes all 171
occurrences across 56 command files, keeping only the direct storage
(else) branches. Also cleans up unused rpc/json/types imports and
fixes variable shadowing issues left behind.

Part of Dolt transition Phase 2 (dolt-test-woho epic).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Executed-By: beads/crew/emma
Rig: beads
Role: crew
2026-02-10 00:23:20 -08:00
beads/crew/lizzy
72ab11a82f fix: remove SQLite type assertion in findReplies, use Storage interface (dolt-test-ruqw)
GetDependentsWithMetadata is on the Storage interface, so call it directly
instead of type-asserting to *sqlite.SQLiteStorage. Removes the slow
GetAllDependencyRecords fallback path that Dolt would have hit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-08 15:56:18 -08:00
Steve Yegge
6c14fd2225 refactor: Split large cmd/bd files to meet 800-line limit (bd-xtf5)
Split 6 files exceeding 800 lines by extracting cohesive function groups:

- show.go (1592→578): extracted show_thread.go, close.go, edit.go, update.go
- doctor.go (1295→690): extracted doctor_fix.go, doctor_health.go, doctor_pollution.go
- sync.go (1201→749): extracted sync_git.go
- compact.go (1199→775): extracted compact_tombstone.go, compact_rpc.go
- linear.go (1190→641): extracted linear_sync.go, linear_conflict.go
- main.go (1148→800): extracted main_help.go, main_errors.go, main_daemon.go

All files now under 800-line acceptance criteria.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-28 18:43:09 -08:00