From da398036bd7097b4bce9368a86bfb49d7de3b216 Mon Sep 17 00:00:00 2001 From: Julian Knutsen Date: Tue, 6 Oct 2026 20:24:35 +0000 Subject: [PATCH] ci(bazel): cover fork and Dependabot PRs with the Bazel lanes (BAZEL_COVERS_FORKS=true) Fork and Dependabot PRs ran both stacks: the legacy embedded, proxied, server-storage and PR-lane tiers plus the Bazel lanes, which rbe-fork has executed remotely (fork-ro/fork-rw) since the canary ended. Flip the committed flag in pr.yml and pr-risk.yml so bazel-coverage retires those tiers for forks too. A covered run the mint does not serve (mode cache) already turns CI Gate / Required red with a re-run message; it never falls back silently. Refs ga-96smfk.15 Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/pr-risk.yml | 12 ++++++++---- .github/workflows/pr.yml | 12 ++++++++---- engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md | 3 ++- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pr-risk.yml b/.github/workflows/pr-risk.yml index 516e8508a..a8c56606e 100644 --- a/.github/workflows/pr-risk.yml +++ b/.github/workflows/pr-risk.yml @@ -42,10 +42,14 @@ env: # flags above then retire their legacy tiers too): rbe-west's mint # (rbe-fork) gives their Bazel lanes remote execution, instance oss-fork # or, for allowlisted authors, oss, and a run the mint does not serve - # (mode cache) is red. "false": they keep the legacy tiers, and the Bazel - # lanes run remotely beside them whenever rbe-fork is open (bazel.yml - # modes fork-ro/fork-rw), else locally with the read-only cache as before. - BAZEL_COVERS_FORKS: "false" + # (mode cache) is red, never a silent fall back to the legacy tiers. + # "false": they keep the legacy tiers, and the Bazel lanes run remotely + # beside them whenever rbe-fork is open (bazel.yml modes + # fork-ro/fork-rw), else locally with the read-only cache as before. + # "true" since ga-96smfk.15: after the canary every fork and Dependabot + # run took fork-ro/fork-rw (none fell to cache). Rollback if the mint + # becomes unreliable: commit "false" in both workflows. + BAZEL_COVERS_FORKS: "true" jobs: detect-ci-tier: diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 4adf3084c..1a1fda034 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -55,10 +55,14 @@ env: # flags above then retire their legacy tiers too): rbe-west's mint # (rbe-fork) gives their Bazel lanes remote execution, instance oss-fork # or, for allowlisted authors, oss, and a run the mint does not serve - # (mode cache) is red. "false": they keep the legacy tiers, and the Bazel - # lanes run remotely beside them whenever rbe-fork is open (bazel.yml - # modes fork-ro/fork-rw), else locally with the read-only cache as before. - BAZEL_COVERS_FORKS: "false" + # (mode cache) is red, never a silent fall back to the legacy tiers. + # "false": they keep the legacy tiers, and the Bazel lanes run remotely + # beside them whenever rbe-fork is open (bazel.yml modes + # fork-ro/fork-rw), else locally with the read-only cache as before. + # "true" since ga-96smfk.15: after the canary every fork and Dependabot + # run took fork-ro/fork-rw (none fell to cache). Rollback if the mint + # becomes unreliable: commit "false" in both workflows. + BAZEL_COVERS_FORKS: "true" # bazel.yml's bazel-cmd-dolt lane (the cmd/bd Dolt-server tier: the # Dolt-gated cmd/bd tests no other lane runs) is advisory while this is # "false": it runs and reports in the bazel call (continue-on-error, so a diff --git a/engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md b/engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md index 51bd82a8c..57102cc1f 100644 --- a/engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md +++ b/engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md @@ -998,7 +998,8 @@ manifests. On those PRs they are the tiers' only pre-merge run, and policy-tested) is `"true"`: their lanes then run remotely through rbe-fork (modes `fork-ro`/`fork-rw`), and a run rbe-fork does not serve (mode `cache`) turns `CI Gate / Required` red rather than falling back. - It ships `"false"`. + It is `"true"` (ga-96smfk.15): fork and Dependabot PRs run only the Bazel + lanes for the retired tiers. - Everyone else keeps the legacy tiers unchanged: - fork PRs, while `BAZEL_COVERS_FORKS` is `"false"` (their Bazel lanes run beside the legacy tiers: remotely while rbe-fork is open, else in