Compare commits

..

1 commit

Author SHA1 Message Date
Julian Knutsen
907595ffc6 fix(cmd/bd): measure wisp GC age at updated_at's storage precision
updated_at is a whole-second DATETIME and Dolt rounds a fractional write
to the nearest second (verified: '00:00:00.7' reads back as '00:00:01'), so
a just-written wisp reads back up to 500ms in the future.
findAbandonedWisps compared now.Sub(updated_at) > threshold at nanosecond
precision, so for up to half a second after a write the age was negative,
and `bd mol wisp gc --age 0s` missed the wisp it was asked to reclaim.
This made TestCLI_WispGCExcludeType flake (13/300 iterations on the cmd/bd
Dolt-server lane).

wispIdleAtLeast now rounds now to the same one-second precision and
compares with >=. round(write) <= round(now) for any write at or before
now, so age is never negative and --age 0s means every wisp. Thresholds
are as fine as the stored timestamp: a sub-second threshold behaves like
"idle for at least the current second".

Fixes ga-vnycm2.44.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-10 10:23:13 +00:00
946 changed files with 10376 additions and 116171 deletions

145
.bazelrc
View file

@ -104,17 +104,6 @@ test:embedded --remote_download_regex=.*/test\.xml$
# jobs, which never retried. Evicted inputs fail the step instead; a
# visible "Re-run failed jobs" retries it.
test:embedded --experimental_remote_cache_eviction_retries=0
# The race configuration's nogo validations run once, in bazel.yml's `test`
# lane (`bazel test //... --config=ci`), which is a strict superset of every
# race-group lane's RunNogo/ValidateNogo keys. --norun_validations is a
# build-request option, not a configuration flag: it changes no action key
# (compile, link and nogo actions are shared with `test` through the action
# cache; test results are not, since each lane's test actions carry its own
# test env and args) and discards no analysis; it only skips re-running nogo's
# validation actions that the owner lane already runs on this configuration.
# scripts/nogo_lint_policy_test.go's TestNogoConfigurationsHaveOneValidatingLane
# pins `test` as this configuration's sole validating lane.
test:embedded --norun_validations
# Dolt-server lane: what pr.yml's retired container-backed jobs ("Test
# (storage domain + uow)" and "Contract corpus") ran, but every dolt
@ -138,9 +127,6 @@ test:doltserver --test_arg=-test.parallel=4
# runner shape; remote workers are not limited by it.
test:doltserver --local_test_jobs=4
test:doltserver --remote_download_regex=.*/test\.(log|xml)$
# Race-group nogo is owned by the `test` lane; see test:embedded's comment
# above.
test:doltserver --norun_validations
# Proxied-server tier: PR Risk's "Test (Proxied Dolt Cmd N/15)" jobs, as
# //cmd/bd:bd_proxied_test and //cmd/bd:bd_managed_local_test (the
@ -174,40 +160,6 @@ test:doltserver-proxied --remote_download_regex=.*/test\.(log|xml)$
# jobs, which never retried. Evicted inputs fail the step instead; a
# visible "Re-run failed jobs" retries it.
test:doltserver-proxied --experimental_remote_cache_eviction_retries=0
# Race-group nogo is owned by the `test` lane; see test:embedded's comment
# above.
test:doltserver-proxied --norun_validations
# dolt-server + proxied union (item 5): bazel.yml's bazel-dolt-race job runs
# both tiers in one invocation in mode remote, in place of the bazel-doltserver
# and bazel-proxied lanes, which still run --config=doltserver and
# --config=doltserver-proxied in every other mode. Exactly the union of the two
# member configs' lines, with one tag filter naming both tiers
# (scripts/bazel_dolt_race_test.go). Every other flag is the same in both
# members or outside any action key for the other: the race build,
# -test.parallel=4 and GO_TEST_WRAP_TESTV=1 are common; the eternal timeout
# applies to no dolt-server target; the eviction retry count is what
# doltserver gets from --config=sole-run wherever it executes remotely;
# test_summary, local_test_jobs and remote_download_regex are not in any action
# key. So each member target's test action is unchanged (aquery: all 62
# TestRunner actions byte-identical), and whichever arm the mode picks shares
# cached results with the other. The member configs stay for those modes, make
# and developers.
test:dolt-race --@rules_go//go/config:race
test:dolt-race --test_tag_filters=dolt-server,dolt-server-proxied
test:dolt-race --build_tests_only
test:dolt-race --keep_going
test:dolt-race --test_summary=terse
test:dolt-race --test_timeout=-1,-1,-1,1200
test:dolt-race --test_env=GO_TEST_WRAP_TESTV=1
test:dolt-race --test_arg=-test.parallel=4
test:dolt-race --local_test_jobs=4
test:dolt-race --remote_download_regex=.*/test\.(log|xml)$
test:dolt-race --experimental_remote_cache_eviction_retries=0
# The union carries its members' --norun_validations line
# (TestBazelDoltRaceConfigIsMemberUnion needs no change: both members and the
# union carry the same line).
test:dolt-race --norun_validations
# Server-Dolt storage tier: PR Risk's "Test (Server Dolt Conformance)" and
# "Test (Server Dolt Full Suite N/16)" jobs, as
@ -235,21 +187,6 @@ test:doltserver-integration --test_env=GO_TEST_WRAP_TESTV=1
test:doltserver-integration --test_arg=-test.parallel=4
test:doltserver-integration --local_test_jobs=4
test:doltserver-integration --remote_download_regex=.*/test\.(log|xml)$
# F5 S2 Variant A: this configuration (integration, doltserver-integration,
# doltserver-cmd -- the same fingerprint, race=true plus
# tags=gms_pure_go,integration) has no full-lane owner. Its nogo runs once,
# narrowly, in bazel.yml's bazel-integration job: a `bazel build
# --output_groups=nogo_fix` step over //internal/testutil/integration only
# (the configuration's non-test library; the 56 integration-tagged _test.go
# files this loses vet/lint coverage on are listed in
# tools/nogo/unvalidated_integration_tests.txt, f5-spec.md §3/§5 S2).
# --norun_validations is a build-request option, not a configuration flag:
# it changes no action key and discards no analysis; it only skips
# re-running nogo's validation actions, which bazel-integration's nogo-only
# step already runs for this configuration's library files.
# scripts/nogo_lint_policy_test.go's TestNogoConfigurationsHaveOneValidatingLane
# pins the nogo-only step as this configuration's sole validating lane.
test:doltserver-integration --norun_validations
# Since D2 step 2 this lane is the tier's only pre-merge run on same-repo
# PRs. Results are cached like every lane's (nightly: --config=fresh).
# No whole-invocation retry on a remote cache eviction ("Lost inputs"):
@ -280,68 +217,13 @@ test:doltserver-cmd --keep_going
test:doltserver-cmd --test_summary=terse
test:doltserver-cmd --test_timeout=-1,-1,-1,1200
# As in --config=integration: Go's own timeout fires first and dumps every
# goroutine to test.log, which Bazel's kill at 1200s does not. Item 5 A2: the
# -test.timeout=19m arg and the BEADS_TEST_REQUIRE_EXCLUDE_PERMISSION env moved
# onto //cmd/bd:bd_dolt_server_test's and //tests/regression:regression_test's
# own args/env (the rules), so --config=dolt-int below does not need them:
# without the move, server-storage's 15m Go timeout would become 19m under
# the union, and the env would leak into server-storage's targets. The final
# argv and environment Bazel assembles (target args, then -test.timeout=19m,
# then this config's own -test.parallel=4 test_arg; same env map either way)
# are unchanged, so the remote action digest -- what RBE's cache keys on --
# is unaffected and cached results should carry over. This IS a local
# actionKey change for these two targets' 46 actions: --test_env is part of
# the build configuration's own fingerprint, picked up by every target
# analyzed under that configuration, unlike a target's own env attribute,
# which only the target carries. To be confirmed in practice by the first
# merge group's tests_cached == tests_total in ci-analytics, not claimed here
# as already observed.
# goroutine to test.log, which Bazel's kill at 1200s does not.
test:doltserver-cmd --test_arg=-test.timeout=19m
test:doltserver-cmd --test_arg=-test.parallel=4
test:doltserver-cmd --test_env=BEADS_TEST_REQUIRE_EXCLUDE_PERMISSION=1
test:doltserver-cmd --test_env=GO_TEST_WRAP_TESTV=1
test:doltserver-cmd --local_test_jobs=4
test:doltserver-cmd --remote_download_regex=.*/test\.(log|xml)$
# F5 S2 Variant A: same configuration as --config=integration /
# doltserver-integration above; see that block's comment for the owner
# (bazel-integration's nogo-only step over //internal/testutil/integration).
test:doltserver-cmd --norun_validations
# server-storage + cmd-dolt union (item 5 A2): bazel.yml's bazel-dolt-int job
# runs both tiers in one invocation in mode remote, in place of the
# bazel-server-storage and bazel-cmd-dolt jobs, which still run
# --config=doltserver-integration and --config=doltserver-cmd in every other
# mode (fork-ro, fork-rw, cache, local): there one client does both tiers'
# work with no in-flight deduplication, so a union would cost the sum of the
# tiers instead of the max. Exactly the union of the two member configs'
# lines above, with one tag filter naming both members' tags
# (scripts/bazel_dolt_int_test.go). Every other flag is the same in both
# members: the race build, tags=gms_pure_go,integration, keep_going,
# test_summary, the eternal 1200s timeout, GO_TEST_WRAP_TESTV=1,
# -test.parallel=4, local_test_jobs, remote_download_regex and
# norun_validations. So each member target's test action is unchanged in the
# sense that matters for caching (aquery: all 63 TestRunner actions' remote
# action digests are byte-identical, the key RBE's cache lookups use), though
# each action's local actionKey differs since these flags now reach the
# target via its own env/args rather than the member's build configuration.
# Cached results carry over both ways regardless.
# New for cmd-dolt here: --experimental_remote_cache_eviction_retries=0.
# server-storage already has it (above); cmd-dolt did not (it has no
# --config=sole-run of its own, unlike doltserver). Adding it to the union is
# stricter for cmd-dolt (no whole-invocation retry on a remote cache
# eviction) and policy-conformant with sole-run semantics; the eviction
# allowlist in pr_risk_bazel_coverage_test.go records the new line.
build:dolt-int --@rules_go//go/config:tags=gms_pure_go,integration
test:dolt-int --@rules_go//go/config:race
test:dolt-int --test_tag_filters=dolt-server-integration,dolt-server-cmd
test:dolt-int --build_tests_only
test:dolt-int --keep_going
test:dolt-int --test_summary=terse
test:dolt-int --test_timeout=-1,-1,-1,1200
test:dolt-int --test_env=GO_TEST_WRAP_TESTV=1
test:dolt-int --test_arg=-test.parallel=4
test:dolt-int --local_test_jobs=4
test:dolt-int --remote_download_regex=.*/test\.(log|xml)$
test:dolt-int --norun_validations
test:dolt-int --experimental_remote_cache_eviction_retries=0
# Integration lane: the `go test` main.yml's former "Main Linux integration"
# jobs ran on push (this lane replaced them, and nightly.yml's retired Full
@ -386,13 +268,6 @@ test:integration --test_env=GO_TEST_WRAP_TESTV=1
# equivalence.py / check_testcases.py right after each lane's own
# `bazel test`, before the other lane runs (or give the lanes separate jobs).
test:integration --remote_download_regex=.*/test\.xml$
# F5 S2 Variant A: same configuration as --config=doltserver-integration /
# doltserver-cmd above; see that block's comment for the owner
# (bazel-integration's nogo-only step over //internal/testutil/integration).
# The 56 integration-tagged _test.go files this configuration no longer
# validates in any full lane are the accepted loss, listed in
# tools/nogo/unvalidated_integration_tests.txt.
test:integration --norun_validations
# Pure-Go lane: pr.yml's "Check pure-Go and js/wasm boundaries
# (CGO_ENABLED=0)" job. CGO is off for every Go target (rules_go drops
@ -419,15 +294,11 @@ build:js-wasm --use_target_platform_for_tests
build:js-wasm --remote_download_outputs=toplevel
# nogo (//tools/nogo: go test's vet checks plus the golangci-lint linters
# .golangci.yml enables) runs beside every Go compile, so `bazel build`/
# `bazel test` fails on a finding -- in bazel.yml's one validating (owner)
# lane per configuration (since F5 S1: a race-group non-owner lane reuses
# its owner's nogo results instead of re-running them; see
# scripts/nogo_lint_policy_test.go's nogoConfigurations table).
# --config=nogo asks for the analysis alone (the nogo_fix output group;
# nothing is linked), in the race configuration bazel.yml's unit lane
# (test:ci) builds, so a local run reuses CI's remote cache. make lint,
# scripts/pr-lint and the pre-commit hook use it.
# .golangci.yml enables) runs beside every Go compile of every lane, so any
# `bazel build`/`bazel test` fails on a finding. --config=nogo asks for the
# analysis alone (the nogo_fix output group; nothing is linked), in the race
# configuration bazel.yml's unit lane (test:ci) builds, so a local run reuses
# CI's remote cache. make lint, scripts/pr-lint and the pre-commit hook use it.
build:nogo --@rules_go//go/config:race
build:nogo --keep_going
build:nogo --output_groups=nogo_fix

View file

@ -201,8 +201,7 @@ document what the pinned release does, never main-only features. See
## 9. Verify before you call it done
Run the gates in [references/verification.md](references/verification.md).
The short list: `bazel test //test/docsync:docsync_test --config=ci`
(nav↔file sync + link conventions),
The short list: `go test ./test/docsync` (nav↔file sync + link conventions),
`./scripts/generate-cli-docs.sh --check` (generated docs fresh),
`./scripts/check-doc-freshness.sh` (Last reviewed markers), and a live
preview with `make docs-dev` (or `./mint.sh dev`) at `localhost:3000`.

View file

@ -39,9 +39,8 @@ don't measure that work by the word delta.
*not* simplifying — it buries the real change in the diff.
4. **Loss-check** (below).
5. **Fact-check** (below).
6. **Gates:** `bazel test //test/docsync:docsync_test --config=ci`, every
fence parses, no body H1, no HTML comments (MDX), preview with
`make docs-dev`.
6. **Gates:** `go test ./test/docsync`, every fence parses, no body H1, no
HTML comments (MDX), preview with `make docs-dev`.
7. **Preview, then commit on approval** — one page or section per batch, so
the reviewer can steer before a cut compounds across the section.

View file

@ -8,7 +8,7 @@ Run these before considering docs work complete. Ordered cheapest-first.
# 1. Docs sync: docs.json nav <-> file consistency, link conventions
# (root-relative extensionless in docs/, exact paths in engdocs/ and
# curated root files), orphan detection (only CLI_REFERENCE.md is exempt).
bazel test //test/docsync:docsync_test --config=ci
go test ./test/docsync
# 2. Generated CLI docs freshness: regenerates from the live command tree
# and diffs docs/CLI_REFERENCE.md, docs/cli-reference/, and the CLI

View file

@ -8,9 +8,7 @@ description: >
BAZEL_REMOTE_EXECUTOR, RBE_TLS_CERT and RBE_TLS_KEY in the step env, that rc
enables --config=remote-exec for every bazel command; with none of them the
job runs locally; with BAZEL_FORK_CACHE=true (and no secrets) it enables
the read-only fork cache (--config=fork-cache), and with BAZEL_RRC_READ=true
too (the remote repo contents cache readers) Bazel's remote repo contents
cache through rbe-cache while it answers; with BAZEL_FORK_REMOTE=true
the read-only fork cache (--config=fork-cache); with BAZEL_FORK_REMOTE=true
(fork and Dependabot PRs, bazel.yml modes fork-ro/fork-rw; needs
RBE_FORK_PR and RBE_FORK_TIER) it gets a short-lived certificate from
rbe-fork-mint (fork-credential.sh, proving the run with a CSR artifact) and

View file

@ -1,151 +0,0 @@
#!/usr/bin/env bash
# May this fork-cache lane read Bazel's remote repo contents cache through
# rbe-west's anonymous read-only cache (rbe-cache :8443, .bazelrc's
# fork-cache) right now? Exits 0 only when the kill switch below is on,
# rbe-cache answers a REAPI GetCapabilities for instance oss with gRPC status
# 0 and a ServerCapabilities that has cache_capabilities, and then answers a
# GetActionResult for a key no action has, and a ByteStream Read for a blob
# the CAS does not hold, each with NOT_FOUND (gRPC 5): the whole read chain
# (Caddy, nativelink-anon, the action cache and the CAS) is up. Anything else
# exits nonzero: switched off, an HTTP or gRPC error, a refused connection,
# a timeout, an answer that does not parse, no curl or python3. The caller
# then writes no repo contents cache lines, and never fails on it. The
# verdict carries the GetCapabilities TCP connect time without the DNS
# lookup (about one round trip to rbe-cache), for the lane's step summary.
#
# Why a probe: with the startup flag set and the cache unreachable (closed
# by rbe-west's kill switch, or down), Bazel retries every repository
# against it before fetching it itself (engdocs/design/
# bazel-remote-repo-contents-cache.md, R6), which costs far more than the
# cache saves. Fork pull_request runs see no repository variables, so the
# opt-out is the committed line below and the server's own answer.
#
# Three gRPC calls over curl's HTTP/2, the first answer decoded by
# python3's standard library: no grpcurl, no new action. Nothing goes to
# stdout (callers write their rc from it); one verdict line goes to stderr. A copy lives in gascity
# (tools/rbe/) and beads (.github/actions/setup-bazel/); keep in sync, except
# the kill switch, which is each repository's own.
#
# Tests only: RBE_CACHE_PROBE_URL (a stand-in server) and
# RBE_CACHE_PROBE_MAX_TIME (seconds).
set -uo pipefail
# Kill switch: off stops this repository's fork-cache lanes reading the
# remote repo contents cache (they fetch external repositories themselves),
# with a one-line pull request; on lets rbe-cache's answer decide. To stop
# every reader of rbe-cache, set it off in both copies (gascity and beads).
# It reaches a lane when the lane's checkout carries it.
fork_rrc_read=on
url=${RBE_CACHE_PROBE_URL:-https://rbe-cache.ops.gascity.com:8443}
max_time=${RBE_CACHE_PROBE_MAX_TIME:-5}
rtt=
no() {
echo "rbe-cache rrc probe: $*${rtt:+ ($rtt)}; this lane fetches external repositories itself" >&2
exit 1
}
[ "$fork_rrc_read" = on ] || no "switched off (fork_rrc_read=$fork_rrc_read in $(basename "$0"))"
command -v curl >/dev/null 2>&1 || no "no curl"
command -v python3 >/dev/null 2>&1 || no "no python3"
tmp=$(mktemp -d) || no "no temp dir"
trap 'rm -rf "$tmp"' EXIT
# call WHAT METHOD REQ: one gRPC call (METHOD: service/method); the answer's
# messages go to $tmp/body, its grpc-status to $st, and the TCP connect time
# without the DNS lookup to $tc. Fails the probe (prefixed with WHAT) on a
# transport error or a non-200 answer.
call() {
local what=$1 out code dns
out=$(curl -sS --http2 --connect-timeout 3 --max-time "$max_time" \
-H 'content-type: application/grpc' -H 'te: trailers' \
--data-binary @"$3" -D "$tmp/head" -o "$tmp/body" -w '%{http_code} %{time_namelookup} %{time_connect}' \
"$url/$2" 2>"$tmp/err") ||
no "$what$(tr '\n' ' ' <"$tmp/err")"
read -r code dns tc <<<"$out"
tc=$(awk -v d="$dns" -v c="$tc" 'BEGIN { if (c > d) printf "%.6f", c - d }' 2>/dev/null) || tc=
[ "$code" = 200 ] || no "${what}HTTP $code"
# grpc-status is a trailer; curl writes trailers after the headers.
st=$(tr -d '\r' <"$tmp/head" | sed -n 's/^grpc-status: *//Ip' | tail -1)
}
# GetCapabilitiesRequest{instance_name: "oss"} (fork-cache's
# --remote_instance_name) as one uncompressed gRPC message.
printf '\000\000\000\000\005\012\003oss' >"$tmp/req" || no "cannot write the request"
call "" build.bazel.remote.execution.v2.Capabilities/GetCapabilities "$tmp/req"
rtt=$(awk -v s="$tc" 'BEGIN { if (s > 0) printf "tcp connect %.1f ms", s * 1000 }' 2>/dev/null) || rtt=
[ "$st" = 0 ] || no "gRPC status ${st:-missing}"
why=$(python3 -I - "$tmp/body" <<'PY'
import sys
def varint(b, i):
v = s = 0
while True:
if i >= len(b) or s > 63:
raise ValueError("truncated varint")
c = b[i]
i += 1
v |= (c & 0x7F) << s
s += 7
if c < 0x80:
return v, i
def fields(b):
i = 0
while i < len(b):
key, i = varint(b, i)
num, wire = key >> 3, key & 7
if wire == 0:
v, i = varint(b, i)
elif wire == 1:
v, i = b[i:i + 8], i + 8
elif wire == 2:
n, i = varint(b, i)
v, i = b[i:i + n], i + n
elif wire == 5:
v, i = b[i:i + 4], i + 4
else:
raise ValueError("wire type %d" % wire)
if i > len(b):
raise ValueError("truncated field %d" % num)
yield num, wire, v
try:
body = open(sys.argv[1], "rb").read()
if len(body) < 5 or body[0] != 0:
raise ValueError("not an uncompressed gRPC message")
n = int.from_bytes(body[1:5], "big")
if len(body) != 5 + n:
raise ValueError("gRPC length %d, %d bytes" % (n, len(body) - 5))
# ServerCapabilities.cache_capabilities
cache = [v for num, wire, v in fields(body[5:]) if num == 1 and wire == 2]
except (OSError, ValueError) as e:
print("unreadable answer (%s)" % e)
sys.exit(2)
if not cache:
print("no cache_capabilities in the answer")
sys.exit(1)
PY
) || no "${why:-python3 failed}"
# GetActionResultRequest{instance_name: "oss", action_digest: {hash:
# sha256("cache-rrc-probe: no action has this key"), size_bytes: 1}}: a key
# no action has, so the action cache behind rbe-cache must say NOT_FOUND.
key=ad12d7a2f1dec188fc1f2c4f5535a4a65eb630fa2f309eca423695e6ec7abee7
printf '\000\000\000\000\113\012\003oss\022\104\012\100%s\020\001' "$key" >"$tmp/req" ||
no "cannot write the request"
call "GetActionResult: " build.bazel.remote.execution.v2.ActionCache/GetActionResult "$tmp/req"
[ "$st" = 5 ] || no "GetActionResult: gRPC status ${st:-missing}, want 5 (NOT_FOUND)"
# ReadRequest{resource_name: "oss/blobs/<the same hash>/1"}: a blob the CAS
# does not hold (its content would have to hash to that key), so the CAS
# behind rbe-cache must say NOT_FOUND.
printf '\000\000\000\000\116\012\114oss/blobs/%s/1' "$key" >"$tmp/req" ||
no "cannot write the request"
call "ByteStream Read: " google.bytestream.ByteStream/Read "$tmp/req"
[ "$st" = 5 ] || no "ByteStream Read: gRPC status ${st:-missing}, want 5 (NOT_FOUND)"
echo "rbe-cache rrc probe: rbe-cache answers GetCapabilities, GetActionResult and ByteStream Read${rtt:+ ($rtt)}; this lane reads the remote repo contents cache" >&2

View file

@ -32,13 +32,7 @@
# means no) it also asks for zstd transfers (--remote_cache_compression). A
# probe, not a repository variable: fork pull_request runs see no vars. No
# other mode ever asks, because only the anonymous cache can advertise zstd,
# and Bazel refuses a remote that does not. With BAZEL_RRC_READ=true too
# (bazel.yml's remote repo contents cache readers alone: the jobs whose
# configs rrc-lane-commands.txt seeds), and while rbe-cache answers
# (cache-rrc-probe.sh, which also holds the committed kill switch), it reads
# Bazel's remote repo contents cache, as those jobs' trusted readers do: the
# trees rrc-seed wrote on main pushes, through rbe-cache's anonymous AC and
# CAS reads. The job's step summary says whether it reads, and why.
# and Bazel refuses a remote that does not.
#
# RBE_FORK_CERT_FILE + RBE_FORK_KEY_FILE + RBE_FORK_ENDPOINT + RBE_FORK_INSTANCE
# (bazel.yml modes fork-ro/fork-rw: fork-credential.sh's outputs, a
@ -100,7 +94,6 @@ key="${RBE_TLS_KEY:-}"
ca="${RBE_TLS_CA:-}"
instance="${RBE_INSTANCE:-}"
fork_cache="${BAZEL_FORK_CACHE:-}"
rrc_reader="${BAZEL_RRC_READ:-}"
fork_cert="${RBE_FORK_CERT_FILE:-}"
fork_key="${RBE_FORK_KEY_FILE:-}"
fork_endpoint="${RBE_FORK_ENDPOINT:-}"
@ -123,13 +116,6 @@ case "$fork_cache" in
exit 1
;;
esac
case "$rrc_reader" in
"" | true) ;;
*)
echo "setup-bazel: BAZEL_RRC_READ must be \"true\" or empty, got \"$rrc_reader\"" >&2
exit 1
;;
esac
rc="$secret_dir/ci.bazelrc"
umask 077
@ -241,38 +227,14 @@ elif [[ "$set_fields" -ne 0 ]]; then
echo "setup-bazel: remote execution is partially configured; BAZEL_REMOTE_EXECUTOR, RBE_TLS_CERT and RBE_TLS_KEY must be set together (or none, for local execution)" >&2
exit 1
elif [[ "$fork_cache" == true ]]; then
# The remote repo contents cache, read-only, for the jobs that opt in
# (BAZEL_RRC_READ: only their configs are seeded), while rbe-cache
# answers and the probe's kill switch (fork_rrc_read) is on. With the
# startup flag set and the cache unreachable, every repository first
# fails a lookup (gascity engdocs/design/bazel-remote-repo-contents-cache.md,
# R6), so a closed or down rbe-cache gets no lines, and a notice says
# why. That holds at probe time only: after loading, Bazel fetches the
# files lazily, and losing rbe-cache then fails the command (R4). Both
# lines are key neutral, as for the trusted readers; fork-cache uploads
# nothing, and rbe-cache refuses every write.
rrc_read=false
if [[ "$rrc_reader" != true ]]; then
why="not a remote repo contents cache reader (no BAZEL_RRC_READ)"
elif why=$(bash "$(dirname "${BASH_SOURCE[0]}")/cache-rrc-probe.sh" 2>&1); then
rrc_read=true
echo "$why"
else
echo "::notice title=No remote repo contents cache::$why"
fi
echo "Fork cache remote repo contents cache read: **$([[ "$rrc_read" == true ]] && echo on || echo off)** (${why#rbe-cache rrc probe: })" >>"${GITHUB_STEP_SUMMARY:-/dev/null}"
# zstd for the anonymous cache's transfers while it advertises zstd:
# transport only, so action keys are unchanged. The probes never fail
# this script; they only decide the lines.
# transport only, so action keys are unchanged. The probe never fails
# this script; it only decides the line.
{
echo "build --config=fork-cache"
if bash "$(dirname "${BASH_SOURCE[0]}")/cache-zstd-probe.sh"; then
echo "build:fork-cache --remote_cache_compression"
fi
if [[ "$rrc_read" == true ]]; then
echo "startup --experimental_remote_repo_contents_cache"
echo "common --loading_phase_threads=64"
fi
} >>"$rc"
cache=true
echo "setup-bazel: read-only remote cache (rbe-cache); executing locally"

View file

@ -1,3 +1,161 @@
# Embedded cmd test shard manifest.
#
# Format: <total_shards> <shard_number> <top_level_test_name>
#
# There is no committed recent duration artifact for these tests. This manifest
# pins a conservative even split for the 20-shard CI matrix while
# embedded-test-shard.sh continues to hash-distribute newly-added tests that are
# not listed here.
20 1 TestEmbeddedBackup
20 2 TestEmbeddedBackupConcurrent
20 3 TestEmbeddedBlocked
20 4 TestEmbeddedBlockedConcurrent
20 6 TestEmbeddedBootstrapConcurrent
20 7 TestEmbeddedBranch
20 8 TestEmbeddedBranchConcurrent
20 10 TestEmbeddedChildrenConcurrent
20 11 TestEmbeddedCloseGuardsAndEpics
20 12 TestEmbeddedCloseConcurrent
20 13 TestEmbeddedComments
20 14 TestEmbeddedCommentsCLI
20 15 TestEmbeddedCommentsCLIConcurrent
20 16 TestEmbeddedCompact
20 17 TestEmbeddedCompactConcurrent
20 18 TestEmbeddedConfig
20 19 TestEmbeddedConfigConcurrent
20 20 TestEmbeddedConfigNoWorkspaceStoreFreeCommands
20 1 TestEmbeddedConfigValidateJSONNoWorkspaceWritesStdout
20 2 TestEmbeddedContext
20 3 TestEmbeddedContextConcurrent
20 5 TestEmbeddedCount
20 6 TestEmbeddedCountConcurrent
20 7 TestEmbeddedCreateScalarAndRelationships
20 7 TestEmbeddedCreateGraphAndBulk
20 8 TestEmbeddedCreateCommitPending
20 9 TestEmbeddedCreateConcurrent
20 10 TestEmbeddedCreateCrossRepo
20 11 TestEmbeddedCreateCrossRepoUninit
20 12 TestEmbeddedCreateCrossRepoWithParent
20 13 TestEmbeddedCreateWithGitRemote
20 14 TestEmbeddedDefer
20 15 TestEmbeddedDeferConcurrent
20 18 TestEmbeddedDepConcurrent
20 19 TestEmbeddedDiff
20 20 TestEmbeddedDiffConcurrent
20 1 TestEmbeddedDoltBlockedAndCommit
20 1 TestEmbeddedDoltRemoteAndPush
20 2 TestEmbeddedDoltConcurrent
20 3 TestEmbeddedDuplicate
20 4 TestEmbeddedDuplicateConcurrent
20 6 TestEmbeddedDuplicatesConcurrent
20 7 TestEmbeddedEpicStatus
20 7 TestEmbeddedEpicCloseEligibleReasonFlag
20 7 TestEmbeddedEpicCloseEligibleReasonOutput
20 8 TestEmbeddedEpicConcurrent
20 9 TestEmbeddedExportFormats
20 9 TestEmbeddedExportFlags
20 10 TestEmbeddedExportConcurrent
20 11 TestEmbeddedFederationPeers
20 11 TestEmbeddedFederationStatus
20 12 TestEmbeddedFederationConcurrent
20 13 TestEmbeddedFindDuplicates
20 14 TestEmbeddedFindDuplicatesConcurrent
20 15 TestEmbeddedFlatten
20 16 TestEmbeddedFlattenConcurrent
20 18 TestEmbeddedGCConcurrent
20 20 TestEmbeddedGateConcurrent
20 2 TestEmbeddedGetDependencies
20 3 TestEmbeddedGraph
20 4 TestEmbeddedGraphConcurrent
20 5 TestEmbeddedHistory
20 6 TestEmbeddedHistoryConcurrent
20 7 TestEmbeddedHooks
20 8 TestEmbeddedHooksConcurrent
20 10 TestEmbeddedHumanConcurrent
20 11 TestEmbeddedImportFromSources
20 11 TestEmbeddedImportUpsertAndPrefixSync
20 12 TestEmbeddedImportConcurrent
20 13 TestEmbeddedInfo
20 14 TestEmbeddedInfoConcurrent
20 15 TestEmbeddedInitC
20 16 TestEmbeddedInitConcurrent
20 17 TestEmbeddedKV
20 18 TestEmbeddedKVConcurrent
20 19 TestEmbeddedLabelPropagateRename
20 20 TestEmbeddedLabelConcurrent
20 1 TestEmbeddedLint
20 2 TestEmbeddedLintConcurrent
20 4 TestEmbeddedListConcurrent
20 13 TestEmbeddedMaxRowsListBasic
20 13 TestEmbeddedMaxRowsListLimitInteraction
20 11 TestEmbeddedMaxRowsDepTreeAndDuplicates
20 12 TestEmbeddedMaxRowsDoctorAndConfig
20 14 TestEmbeddedMaxRowsGraph
20 15 TestEmbeddedMaxRowsReady
20 16 TestEmbeddedMaxRowsReadyMerge
20 5 TestEmbeddedMemory
20 6 TestEmbeddedMemoryConcurrent
20 7 TestEmbeddedMigrate
20 8 TestEmbeddedMigrateConcurrent
20 9 TestEmbeddedOnboard
20 10 TestEmbeddedOnboardConcurrent
20 11 TestEmbeddedOrphans
20 12 TestEmbeddedOrphansConcurrent
20 13 TestEmbeddedPrime
20 14 TestEmbeddedPrimeConcurrent
20 15 TestEmbeddedPromote
20 16 TestEmbeddedPromoteCLI
20 17 TestEmbeddedPromoteCLIConcurrent
20 18 TestEmbeddedPruneSafetyAndScope
20 18 TestEmbeddedPruneDryRunAndFilters
20 19 TestEmbeddedPurgeBasics
20 19 TestEmbeddedPurgeFiltered
20 20 TestEmbeddedPurgeConcurrent
20 1 TestEmbeddedQuery
20 2 TestEmbeddedQueryConcurrent
20 3 TestEmbeddedQuick
20 4 TestEmbeddedQuickConcurrent
20 5 TestEmbeddedQuickstart
20 6 TestEmbeddedQuickstartConcurrent
20 8 TestEmbeddedReadyConcurrent
20 9 TestEmbeddedRenamePrefixBasic
20 9 TestEmbeddedRenamePrefixEdgeCases
20 10 TestEmbeddedRenamePrefixConcurrent
20 11 TestEmbeddedReopen
20 12 TestEmbeddedReopenConcurrent
20 13 TestEmbeddedRestore
20 14 TestEmbeddedRestoreConcurrent
20 16 TestEmbeddedSearchConcurrent
20 17 TestEmbeddedSetup
20 18 TestEmbeddedSetupConcurrent
20 19 TestEmbeddedShip
20 20 TestEmbeddedShipConcurrent
20 1 TestEmbeddedShowBasicsAndJSON
20 2 TestEmbeddedShowConcurrent
20 3 TestEmbeddedStale
20 4 TestEmbeddedStaleConcurrent
20 5 TestEmbeddedState
20 6 TestEmbeddedStateConcurrent
20 7 TestEmbeddedStatus
20 8 TestEmbeddedStatusConcurrent
20 9 TestEmbeddedSupersede
20 10 TestEmbeddedSupersedeConcurrent
20 12 TestEmbeddedSwarmConcurrent
20 13 TestEmbeddedTodo
20 14 TestEmbeddedTodoConcurrent
20 15 TestEmbeddedTypes
20 16 TestEmbeddedTypesConcurrent
20 17 TestEmbeddedUndefer
20 18 TestEmbeddedUndeferConcurrent
20 20 TestEmbeddedUpdateConcurrent
20 1 TestEmbeddedVCStatusAndCommit
20 1 TestEmbeddedVCCommitVariantsAndMerge
20 2 TestEmbeddedVCConcurrent
20 3 TestEmbeddedVersion
20 4 TestEmbeddedVersionConcurrent
20 5 TestEmbeddedWhere
20 6 TestEmbeddedWhereConcurrent
# Embedded-Dolt cmd/bd test shard manifest.
#
# Format: <total_shards> <shard_number> <top_level_test_name>
@ -11,7 +169,7 @@
# t.Parallel) add up, parallel ones share -test.parallel=4.
# Regenerate with scripts/ci/gen_embedded_cmd_shard_manifest.py 100
# --weights=duration --write after adding, splitting or removing
# TestEmbedded* functions in cmd/bd/*_test.go. --write is
# TestEmbedded* functions in cmd/bd/*_embedded_test.go. --write is
# incremental: it keeps every already-assigned test on its current shard
# and only places newly-discovered names, onto whichever shard is
# currently lightest, so two unrelated PRs that each add one test do not
@ -59,206 +217,99 @@
100 17 TestEmbeddedReopen
100 18 TestEmbeddedLabelPropagateRename
100 18 TestEmbeddedPrune_protectsBeadCitedByCustomStatusBead
100 19 TestEmbeddedLabelConcurrent
100 19 TestEmbeddedNewDoltStore_StrictReadOnlyRefusesWritesOnFreshDatabase
100 20 TestEmbeddedInitRoleRoutingRetainedFork
100 20 TestEmbeddedMigrateSchema_IdentityMismatchRefusesBeforeApplying
100 21 TestEmbeddedMaxRowsReady
100 21 TestEmbeddedMigratePersonal_movesIssues
100 22 TestEmbeddedCount
100 22 TestEmbeddedIfRevisionCloseReplaysMoleculeAutoClose
100 23 TestEmbeddedCountConcurrent
100 23 TestEmbeddedExportExcludeOwner_flag
100 24 TestEmbeddedEventsTailFollowReportsTruncationOnTheStream
100 24 TestEmbeddedUndeferConcurrent
100 24 TestEmbeddedWispGCProtectsActiveWisps
100 25 TestEmbeddedDoltRemoteAdd_LocalOnly_FiresBeforeGuard
100 25 TestEmbeddedMaxRowsListBasic
100 25 TestEmbeddedRemovedBackendHealRejectionPerBackend
100 26 TestEmbeddedDoltRemoteAdd_JSON_AllowGitOrigin_WarningOnStderr
100 26 TestEmbeddedExternalMutationPolicy
100 26 TestEmbeddedPersistentPreRunLogsAndSkipsIdentityCheckForFreshEmbeddedWorkspace
100 27 TestEmbeddedDoltRemoteAdd_GitOriginCollision_RefusalMessageCopy
100 27 TestEmbeddedNewDoltStoreFromConfig_DottedDBName
100 27 TestEmbeddedShipConcurrent
100 28 TestEmbeddedDoltLocalOnly_RemoteAdd_RefusesExitOne
100 28 TestEmbeddedHistoryConcurrent
100 28 TestEmbeddedImportChunkedRealStoreResumeConverges
100 29 TestEmbeddedDoltLocalOnly_RemoteAdd_ErrorOnStderr
100 29 TestEmbeddedEpicCloseEligibleReasonFlag
100 29 TestEmbeddedImportChunkedNoReadyWindowWithReadinessEdgeIntoCycle
100 30 TestEmbeddedCloseGuardsAndEpics
100 30 TestEmbeddedDoltLocalOnly_Push_ExitsZeroWithMessage
100 30 TestEmbeddedImportChunkedCrossBucketBlocksEdgesResumeBackfills
100 31 TestEmbeddedDoltLocalOnly_ConfigRoundTrip
100 31 TestEmbeddedIfRevisionCloseWarnsOnForcedOpenChildren
100 31 TestEmbeddedInitSelectedExcludeRoutingForkInvalidQuiet
100 32 TestEmbeddedDoctorUnsupportedJSON
100 32 TestEmbeddedIfRevisionAdvertisedOnFourVerbs
100 32 TestEmbeddedListSearchAndOutputFormats
100 33 TestEmbeddedBootstrapJSONLAndGitOrigin
100 33 TestEmbeddedDeleteJournalsTheRequestingActor
100 33 TestEmbeddedExportExcludeOwner_verbose
100 34 TestEmbeddedCopyIssueRelations_preservesCommentWithTimestamp
100 34 TestEmbeddedEventsTailReportsTruncationToTheCLI
100 34 TestEmbeddedUnclaimBatchAndRefusals
100 34 TestEmbeddedWispGCPurgeClosedDoesNotCascadeIntoLiveSteps
100 35 TestEmbeddedAutoPruneRespectsBdConfigSet
100 35 TestEmbeddedEventsReadNoticesADisabledJournal
100 35 TestEmbeddedGateCreateBeadRename
100 35 TestEmbeddedVersionedHistoryEnvIsProcessWideAndOnlyTurnsRecordingOn
100 36 TestEmbeddedAutoPruneLeavesAnUnboundedJournalAlone
100 36 TestEmbeddedDoltRemoteResetData_UnknownRemote
100 36 TestEmbeddedGateConcurrent
100 36 TestEmbeddedUnclaimIfAssigneeCLIDifferentSpelling
100 37 TestEmbeddedAutoPruneBoundsTheJournalAfterAMutatingCommand
100 37 TestEmbeddedDoltRemoteResetData_CloudRemoteRefused
100 37 TestEmbeddedMaxRowsDepTreeAndDuplicates
100 37 TestEmbeddedSpawnMolecule_SubstitutesTemplatedStepFields
100 38 TestEmbeddedGraphConcurrent
100 38 TestEmbeddedRoutedCreateJournalsIntoTheTargetWorkspace
100 38 TestEmbeddedUnclaimIfAssigneeFlagValidation
100 39 TestEmbeddedIfRevisionRejectsLabelAndParentEdits
100 39 TestEmbeddedMaxRowsGraph
100 39 TestEmbeddedNewDoltStoreFromConfig_NoMetadata
100 40 TestEmbeddedIfRevisionOutranksReassignFenceCLI
100 40 TestEmbeddedNewDoltStoreFromConfig_HyphenatedDBName
100 40 TestEmbeddedUpdateLifecycleClaimParentCommit
100 41 TestEmbeddedDuplicateConcurrent
100 41 TestEmbeddedVersionedHistoryFollowsTheStoreItWritesInto
100 42 TestEmbeddedInitAForkAutoContributor
100 42 TestEmbeddedUpdateIfGuardsFlagValidation
100 43 TestEmbeddedIfRevisionMultiIDRejected
100 43 TestEmbeddedInitExplicitBeadsDirIsAuthoritative
100 44 TestEmbeddedIfRevisionComposesWithIfAssigneeIfStatus
100 44 TestEmbeddedStaleConcurrent
100 45 TestEmbeddedGraph
100 45 TestEmbeddedUpdateIfGuardsCLI
100 46 TestEmbeddedCloseAlreadyClosedClaimNextAndMolecule
100 46 TestEmbeddedIfRevisionMatchAndMismatch
100 47 TestEmbeddedListSearchAndOutputSearchAndSort
100 47 TestEmbeddedRevisionRemintMatrix
100 48 TestEmbeddedDeferConcurrent
100 48 TestEmbeddedReassignFenceCLI
100 49 TestEmbeddedBackupRestoreStrictReadonly
100 49 TestEmbeddedInitAPushConsentAndRemoteBootstrap
100 49 TestEmbeddedMigratePersonal_abortOnNoConfirm
100 50 TestEmbeddedDiffConcurrent
100 50 TestEmbeddedDoltRemoteAdd_AllowGitOrigin_WarningOnStderr
100 50 TestEmbeddedImportChunkedWaitsForChildImportedLaterStaysBlocked
100 50 TestEmbeddedVersionOutputShape
100 51 TestEmbeddedDoltRemoteAdd_AllowGitOrigin_Exits0
100 51 TestEmbeddedHistoryAndShowAsOfReadDoltCommits
100 51 TestEmbeddedImportChunkedStaleRejectedRowKeepsDeferredDepsOut
100 51 TestEmbeddedInitGitBootstrapRoutingFreshQuiet
100 52 TestEmbeddedConfigSetOtherKeysSkipTheVersionedHistoryScan
100 52 TestEmbeddedDoltLocalOnly_Push_LocalStoreCopy
100 52 TestEmbeddedImportChunkedNoReadyWindowAtAnyFreezePoint
100 52 TestEmbeddedSwarmConcurrent
100 53 TestEmbeddedDoltLocalOnly_Push_JSON_DisabledStatus
100 53 TestEmbeddedIfRevisionOrdinaryCAS
100 53 TestEmbeddedImportChunkedMixedRegularWispCrossBucketEdgesWired
100 53 TestEmbeddedInitSelectedExcludeRoutingStealthDecoyQuiet
100 54 TestEmbeddedDiscoveryPinsEnvFileReadonly
100 54 TestEmbeddedFormatJSONAliasMatchesJSON
100 54 TestEmbeddedGraphModeDependencyWorkspaceUnaffected
100 54 TestEmbeddedInitAgentArtifactsGolden
100 54 TestEmbeddedSearchConcurrent
100 54 TestEmbeddedShowAsOfFailureExitCodes
100 55 TestEmbeddedDoltLocalOnly_Pull_JSON_DisabledStatus
100 55 TestEmbeddedImportChunkedConcurrentUpdateKeepsDeferredDeps
100 55 TestEmbeddedUndefer
100 55 TestEmbeddedVersionedHistorySwitchScansEveryRowNotOnePage
100 56 TestEmbeddedDepNoCycleCheck
100 56 TestEmbeddedDoltLocalOnly_Pull_ExitsZeroWithMessage
100 56 TestEmbeddedImportChunkedConcurrentUpdateKeepsBlockingDeps
100 56 TestEmbeddedVersionedHistorySwitchRoundTrip
100 57 TestEmbeddedDoltLocalOnly_DoltStatus_ShowsDisabled
100 57 TestEmbeddedIfRevisionDeletePreflightGoneIsPreconditionFailed
100 57 TestEmbeddedQueryConcurrent
100 57 TestEmbeddedVersionedHistorySwitchRefusesUnversionableMetadata
100 58 TestEmbeddedDepAAddRejectionsAndBulk
100 58 TestEmbeddedDoctorUnsupportedProse
100 58 TestEmbeddedIfRevisionCascadeDelete
100 58 TestEmbeddedVersionedHistorySwitchRefusesAnUnrecordableGateTimeout
100 59 TestEmbeddedDeferAutoWake
100 59 TestEmbeddedDoctorSupportedChecks
100 59 TestEmbeddedIdentityGateRendersSchemaSkewFromForwardDriftedWorkspace
100 59 TestEmbeddedVersionedHistorySetManyRefusesUnversionableMetadata
100 60 TestEmbeddedCommentsCLI
100 60 TestEmbeddedCorruptMetadataFailsLoudUntilRestored
100 60 TestEmbeddedExportExcludeOwner_config
100 60 TestEmbeddedRoutedWriteMissDoesNotCreateTargetDatabase
100 60 TestEmbeddedWispGCPurgeClosedStillPurgesFullyClosedMolecules
100 61 TestEmbeddedBootstrapCloneFailureScrubsCredentials
100 61 TestEmbeddedContributorRoutedWritesCommitInPlanning
100 61 TestEmbeddedEventsPruneHonorsRetainRowsFloorFromConfig
100 61 TestEmbeddedUpdateRoutedStoreCommitsTargetHead
100 61 TestEmbeddedVersionedHistoryConfigSetWritesTheStoreRow
100 62 TestEmbeddedAutoPruneDoesNotRunForReadOnlyCommands
100 62 TestEmbeddedDoltRemoteResetData_GitBacked
100 62 TestEmbeddedGateCheckSkipsTemplateGates
100 62 TestEmbeddedReadyBlockersAndLabels
100 62 TestEmbeddedUnclaimIfAssigneeCLI
100 63 TestEmbeddedDepAndLinkBatchAutoCommitDoesNotAdvanceHead
100 63 TestEmbeddedGateCheckLimitCountsOnlyLiveGates
100 63 TestEmbeddedIfRevisionDeletePreflightGoneParentIsPreconditionFailed
100 63 TestEmbeddedListPageEdges
100 64 TestEmbeddedAutoExportExcludeOwner_config
100 64 TestEmbeddedDoltRemoteAdd_NoGitOrigin_ProceedsNormally
100 64 TestEmbeddedGateWaiterCheckLifecycle
100 64 TestEmbeddedPromoteMovesAWispParent
100 64 TestEmbeddedSpawnMolecule_PreservesStepLabels
100 65 TestEmbeddedIfRevisionPreflightGoneIsPreconditionFailedOnEveryVerb
100 65 TestEmbeddedRemovedBackendHealRoundTrip
100 65 TestEmbeddedSupersede
100 66 TestEmbeddedCloseBasicIsolatedStores
@ -320,11 +371,8 @@
100 70 TestEmbeddedPurgeConcurrent
100 70 TestEmbeddedRoutedMutatingSiblingAssignTagDepTag
100 71 TestEmbeddedCloseJSONReportsMoleculeAutoClose
100 71 TestEmbeddedInitRoleRoutingExplicitDefault
100 71 TestEmbeddedPrimeChangeDirRedirectNoticeFollowsTarget
100 71 TestEmbeddedRoutedCreateHonorsTheEnvOverrideOverTheTargetsConfig
100 71 TestEmbeddedSearchRoutesAgree
100 72 TestEmbeddedContributorCreateMultiple
100 72 TestEmbeddedCreateWithGitRemote
@ -434,10 +482,8 @@
100 83 TestEmbeddedPurgeFiltered
100 83 TestEmbeddedReadyConcurrent
100 84 TestEmbeddedDoltRemoteAdd_GitOriginCollision_Exits1
100 84 TestEmbeddedInitGitBootstrapRoutingDecoyInvalid
100 84 TestEmbeddedInitSelectedExcludeRoutingStealthInvalid
100 84 TestEmbeddedMigratePersonal_preservesComments
100 85 TestEmbeddedBootstrapExistingDryRunInit
100 85 TestEmbeddedChildrenBasicAndEmpty
@ -446,10 +492,8 @@
100 85 TestEmbeddedIfRevisionReopenGuardDirect
100 85 TestEmbeddedInitArtifactRouting
100 86 TestEmbeddedDoltRemoteAdd_DifferentURL_ProceedsNormally
100 86 TestEmbeddedExplicitHierarchicalParentEdges
100 86 TestEmbeddedInitHooksRouting
100 86 TestEmbeddedMigratePersonal_noopWhenEmpty
100 87 TestEmbeddedCreateRepoProxiedTargetError
100 87 TestEmbeddedGateInheritsDownParentChain

View file

@ -176,17 +176,14 @@
40 3 TestTransactionCleanupBeforeSQLCommitRemainsDefinite
40 3 TestUnknownProvenanceLeaseStaysReclaimable
40 4 TestBlockedListerContract
40 4 TestCreateBatchFastPathsMatchPerRowSmallDepAdd_Embedded
40 4 TestEmbeddedIssueOperationsUpdateLabelPatchOrdering
40 4 TestEmbeddedReaderGetMissIsNotFoundAndBackendFailureDoesNotDecay
40 4 TestEmbeddedReaderListFilterFamiliesNarrowToTheirRows
40 4 TestMergeAndSettleWithStrategy_EmptyStrategyMatchesMergeAndSettle
40 5 TestEmbeddedClaimerRefusesIncompleteRequestsAndAnAbsentIDWithoutTouchingState
40 5 TestEmbeddedIssueOperationsCloseAndReopenAWisp
40 5 TestEmbeddedReaderListKeysetPositionResumesTheCreatedDescIDAscOrder
40 5 TestRecordVersionKeepsSubSecondChangeAt
40 5 TestWithPeerAuth
40 6 TestCreateBatchFastPathsMatchPerRowApplyWaitsFor_Embedded
@ -196,7 +193,6 @@
40 6 TestEmbeddedRelationsAnswersAWispTargetInTheOutDirection
40 6 TestPromoteStillWorksWithCollisionGuard
40 6 TestSearchWithMissingWispPlaneTables
40 6 TestVersionedHistoryKeepsNumbersTheStoreDistinguishesApart
40 7 TestConcurrencyMultiProcess
40 7 TestEmbeddedBatchCloserRecordsOneHistoryEntryForWhatLanded
@ -205,20 +201,17 @@
40 7 TestEmbeddedIssueOperationsUpdateMetadataReplaceClearsAndValidates
40 7 TestEmbeddedLenientOpenWarning_DataBehind
40 7 TestEmbeddedRelationsLeavesTheCallersRequestAlone
40 7 TestLoseVersionLeavesTheEpochTablesCommitted
40 7 TestMergeAndSettleWithStrategy_ResolvesDeclinedConflict
40 8 TestDeleterContract
40 8 TestEmbeddedDependencyEditorRoutesWispSourcedRemovalToTheWispPlane
40 8 TestEmbeddedMergeAndSettleDirtyWorkingSetSurvivesRefusedMerge
40 8 TestEmbeddedMintLeavesUpdatedAtWhereHistoryOffDoes
40 8 TestEmbeddedReaderGetBriefDepsProjectsTheDependencyRows
40 8 TestEmbeddedRelationsOrdersNeighborsFromBothPlanesTogether
40 8 TestEmbeddedReopenIssueCategorySemantics
40 8 TestGetIssueCommentsPageEmbedded
40 8 TestListWisps
40 9 TestBumpEpochCarryingNeitherCarriesNorServesARowFromAFutureEpoch
40 9 TestEmbeddedDependencyEditorRefusesCrossPlaneCycle
40 9 TestEmbeddedDependencyEditorSameTypeReAddIsIdempotent
40 9 TestEmbeddedDependencyEditorSnapshotsTheRequest
@ -237,10 +230,8 @@
40 10 TestGraphCounterContract
40 10 TestIgnoredCursorHealRespectsOperatorOverride
40 10 TestRunInTransactionPostCommitStageFailureIsIndeterminate
40 10 TestVersionedHistoryOffMatchesPreStackGolden_Embedded
40 10 TestWithPeerAuth_WarnsWhenStoredPeerSuppressesAmbientPasswordAmbient
40 11 TestABumpUnderOneStoreIDMovesTheEpochSeenThroughEveryStoreID
40 11 TestEmbeddedBatchCreateFirstVersionCarriesCreationTimeEdges
40 11 TestEmbeddedClaimerRefusalMessagesCarryTheirFragments
40 11 TestEmbeddedGuardedUpdateMintsOnceAfterItsPatches
@ -260,7 +251,6 @@
40 12 TestEmbeddedReadyClaimerAnswersTheQuestionReaderReadyLists
40 12 TestHistoryPresenceContract
40 12 TestLifecycleUpdateContract
40 12 TestReaderListExcludeStatusAcceptsAWorkspaceCustomStatus
40 13 TestEmbeddedDepRekeyConvergesRenameChain
40 13 TestEmbeddedDependencyEditorAppliesParentChildBeforeBlockingEdges
@ -281,7 +271,6 @@
40 14 TestEmbeddedReaderReadyDefaultTypeExclusionsYieldToAnExplicitType
40 14 TestEmbeddedReadyClaimerClaimsTheFrontRowAndReturnsThePostClaimState
40 14 TestEmbeddedReadyClaimerDoesNotMutateTheCallerRequest
40 14 TestHeartbeatIssueCommitsARefusalOnlyWhenItReadTheIssueEmbedded
40 14 TestHistory_NullTextColumns
40 15 TestCreateIssuesRejectStaleUpserts
@ -293,7 +282,6 @@
40 15 TestEmbeddedRelationsFiltersByAnOpenTypeVocabulary
40 15 TestGetIssue
40 15 TestLegacyTrackedIgnoredCursorHealsOnOpen
40 15 TestMoleculeContract
40 15 TestReadyWorkPageTotalFilterMatrix
40 16 TestDescendantWalkReachesEveryTargetKindAndStopsOnCycles
@ -318,7 +306,6 @@
40 17 TestStatsReporterContract
40 17 TestVersionReconcilerContract
40 18 TestCreateBatchParticipationGeneration
40 18 TestEmbeddedBatchCloserIdempotentRecloseIsAPerItemSuccess
40 18 TestEmbeddedDependencyEditorMixedBatchWritesBothPlanes
40 18 TestEmbeddedIssueOperationsUpdateRawMetadataTakesTheFunnelsValueShapes
@ -338,11 +325,9 @@
40 19 TestIgnoredCursorHealConvergesFromEveryCrashState
40 19 TestOpenAfterCloseCreatesNewStore
40 19 TestOpenReturnsCachedStore
40 19 TestParticipationGenerationFixtureKitIsWired
40 19 TestRemoteVerbsPresentStoredPeerCredentials
40 19 TestRenameLabelMintsOneVersionPerTouchedBead
40 20 TestBumpEpochCarryingCarriesOnlyTheLineageHoldingTheNewestRow
40 20 TestCreateIssue
40 20 TestEmbeddedCheckedWrappersRouteTheirPreconditions
40 20 TestEmbeddedIssueOperationsCreateRoutesInfraTypesToWisps
@ -354,7 +339,6 @@
40 20 TestHeartbeatRejectsWispEmbedded
40 20 TestIgnoredCursorHealNeverResurrectsRolledBackVersions
40 21 TestBumpEpochCarryingCarriesTheLiveRowsOfEveryStoreInTheDatabase
40 21 TestCreateRejectsCrossTableIDCollision
40 21 TestEmbeddedBatchCloserItemsAnswerToTheCloseGuards
40 21 TestEmbeddedDependencyEditorAcceptsATypeOutsideTheConstants
@ -376,9 +360,7 @@
40 22 TestEventsJournalPruneNeverSplitsASkewedPair
40 22 TestLargeBatchApplyStatementCounts356_Embedded
40 22 TestLeaseLifecycleEmbedded
40 22 TestPolicyBlockingAnnotatorForeignOpensAreSublinear
40 23 TestAsOfReadContract
40 23 TestEmbeddedBatchCloserBackendFailureReturnsNoOutcomes
40 23 TestEmbeddedBatchCloserClaimNextHydratesWhenSomethingClosed
40 23 TestEmbeddedDependencyEditorAcceptsBlockingAcrossIssueTypes
@ -397,21 +379,18 @@
40 24 TestEmbeddedIgnoredSeriesConvergesWithFreshInitShape
40 24 TestEmbeddedIssueOperationsCreateWithDependenciesSettlesInTheCreatingTransaction
40 24 TestEmbeddedMigrateSelfHealsAfterMidPassFault_4566
40 24 TestEmbeddedReaderListQueryMatchesTheTitleOrTheID
40 24 TestEmbeddedReaderListWispTypeNarrowsTheAdmittedPlaneRatherThanAdmittingIt
40 24 TestIgnoredCursorHealResumeRespectsOperatorOverride
40 24 TestLargeBatchApplyStatementCountsClassic40_Embedded
40 24 TestReopenIssue
40 25 TestBatchGetterContract
40 25 TestDatabases
40 25 TestDualWriteFixtureKitIsWired
40 25 TestEmbeddedBatchCloserClaimNextIsNilWhenNothingClosed
40 25 TestEmbeddedIssueOperationsUpdateClaimHonorsConfiguredActiveStatuses
40 25 TestEmbeddedReadyClaimerLeavesEphemeralRowsOutOfTheDefaultReadySet
40 25 TestEmbeddedReadyClaimerRejectsLimitOffsetBriefAndEmptyActor
40 25 TestGetDependentRecordsForIssuesEmbedded
40 25 TestHeartbeaterContract
40 25 TestIgnoredCursorHealIsIdempotent
40 25 TestIsBlockedBatchEmbedded
40 25 TestReadyWorkPageTotal
@ -441,7 +420,6 @@
40 27 TestRemoteGitDataRefOnEngine
40 27 TestSweeperContract
40 28 TestBumpEpochCarryingDoesNotCarryALostLineage
40 28 TestEmbeddedBatchCloserForceBypassesOnlyClosePolicy
40 28 TestEmbeddedBatchCloserSettlesTheDependersOfWhatItClosed
40 28 TestEmbeddedClaimerClaimsAnUnassignedOpenIssueAndAnswersTheBareRow
@ -460,7 +438,6 @@
40 29 TestEmbeddedDependencyEditorRecordsOneHistoryEntryPerLandedRequest
40 29 TestEmbeddedMergeAndSettleMetadataConflict
40 29 TestEmbeddedReaderListDefaultExclusionsAndTheirOverrides
40 29 TestEmbeddedReaderListTimeBoundsAreStrictAndWholeSecond
40 29 TestEmbeddedReaderReadySetOwnsItsStatusPinnedAndTemplateDecisions
40 29 TestEmbeddedTransactionSameStatusDoesNotPublishUnrelatedDurableChanges
40 29 TestEventsJournalAccessor
@ -479,7 +456,6 @@
40 30 TestLegacyTrackedIgnoredCursorUnwedgesPull
40 30 TestUpdateMergeOps_DoltEngine_TwoIssues
40 31 TestBumpEpochCarryingWritesOneCarryRowPerLiveIDNamingTheLineageRoot
40 31 TestDualWriteContract
40 31 TestEmbeddedDependencyEditorAcceptsAForeignRepoTarget
40 31 TestEmbeddedDependencyEditorMaintainsBlockedStateAcrossPlanes
@ -492,7 +468,6 @@
40 31 TestReadyCounterContract
40 31 TestWithPeerAuth_KeyMismatchFailsClosed
40 32 TestCurrentAddressForNeverReseedsAnAbsentStoreEpochRow
40 32 TestEmbeddedClaimerGrantsALiveLeaseOnTheRowItWonAndLeavesARefusedOneAlone
40 32 TestEmbeddedDependencyEditorRefusesAMissingLocalTarget
40 32 TestEmbeddedDirtyTablesGate_BlocksReopenThenWorkingSetReconcileRecovers
@ -513,13 +488,11 @@
40 33 TestEmbeddedRelationsResolvesTheAnchorIDExactly
40 33 TestEmbeddedSyncCommitsConfigBeforeMerge
40 33 TestEventsAutoPruneThrottleSkipsTheSecondPass
40 33 TestFirstMintLeavesTheEpochTablesCommitted
40 33 TestGetDependentRecordsEmbedded
40 33 TestPruneEventsBatchDeletesTheLowestSeqsOnly
40 33 TestTreeWalkerContract
40 34 TestAddLabel
40 34 TestBumpEpochCarryingLeavesTheEpochTablesCommitted
40 34 TestDecryptPassword_KeyMismatchNamesTheLocalKey
40 34 TestEmbeddedBlockedRecheckRecordsUnblockingWrites
40 34 TestEmbeddedDependencyEditorAttributesItsEventsToTheActor
@ -543,7 +516,6 @@
40 35 TestReadyWorkWithMissingDeferredParentTables
40 35 TestReclaimExpiredLeaseSurvivesRestartEmbedded
40 36 TestBumpEpochCarryingFailsAndRollsBackWhenARowAlreadyExistsAtTheNewEpoch
40 36 TestCommenterContract
40 36 TestConcurrentOpenReturnsCached
40 36 TestEmbeddedBatchCloserAllRefusedBatchRecordsNoHistory
@ -566,7 +538,6 @@
40 37 TestEmbeddedMergeAndSettleReportsOperatorConflicts
40 37 TestEmbeddedReaderListBriefDropsTheFreeFormTextAndNothingElse
40 37 TestEmbeddedReaderListNaturalNumericIDSortTrimsAfterTheFetch
40 37 TestEpochWritesReportAnUnpublishedCommitAsIndeterminate
40 37 TestIgnoredCursorHealRespectsOverrideUnderBroaderPattern
40 38 TestCreateIssues
@ -579,7 +550,6 @@
40 38 TestEmbeddedReaderListKeysetWalkOverAnOversizedGroupLosesNothingAndRepeatsNothing
40 38 TestEmbeddedTempRebuildIntermediatesNeverReachHistory
40 38 TestEventsJournalPruneWhenEveryRowIsOlderThanTheCutoff
40 38 TestPolicyBlockingAnnotatorBatchEqualsPerItem
40 38 TestWithPeerAuth_ConcurrentPeersDoNotMixCredentials
40 39 TestDualWriteContractFlagOff
@ -590,7 +560,6 @@
40 39 TestEmbeddedMigrateRepairedDependenciesIDColumnCommitsAtomicallyWithVersion53_4690
40 39 TestEmbeddedReaderListSkipCountsDropsTheCardinalitiesAndNothingElse
40 39 TestEmbeddedRelationsResolvesAWispAnchor
40 39 TestParticipationGenerationFence
40 39 TestPreviewStoreRefusesLocalMetadataWrite
40 39 TestReclaimRefusesForeignReplicaLease
40 39 TestWorkspaceConfigContract

View file

@ -3,7 +3,7 @@
#
# Usage: embedded-test-shard.sh <shard_number> <total_shards>
#
# Discovers all TestEmbedded* top-level functions in cmd/bd/*_test.go.
# Discovers all TestEmbedded* top-level functions from cmd/bd/*_embedded_test.go.
# Tests listed in embedded-cmd-test-shards.txt for the requested shard count use
# that committed assignment; newly-added tests fall back to hash(name) % total.
# Runs the matching subset using the pre-built test binary at
@ -33,12 +33,8 @@ fi
SHARD_INDEX=$(( SHARD_NUMBER - 1 ))
MANIFEST="${BEADS_TEST_SHARD_MANIFEST:-.github/scripts/embedded-cmd-test-shards.txt}"
# Discover all top-level TestEmbedded* functions across every cmd/bd test
# file, by name rather than by file glob (as proxied-test-shard.sh does): a
# test gated on BEADS_TEST_EMBEDDED_DOLT runs in this lane or in none, wherever
# it lives. scripts/embedded_lane_coverage_test.go fails on a gated test this
# selection misses.
ALL_TESTS=$(grep -rh '^func TestEmbedded' cmd/bd/*_test.go \
# Discover all top-level TestEmbedded* functions.
ALL_TESTS=$(grep -rh '^func TestEmbedded' cmd/bd/*_embedded_test.go \
| sed 's/func \(TestEmbedded[A-Za-z0-9_]*\).*/\1/' \
| sort -u)

View file

@ -1,3 +1,235 @@
# Proxied-server cmd test shard manifest.
#
# Format: <total_shards> <shard_number> <top_level_test_name>
#
# 15-shard split, bin-packed longest-processing-time-first by
# estimated cost (bd-init count; per-init migration chains dominate), as of
# the test set that existed when this block was last generated.
# Regenerating it (scripts/ci/gen_proxied_shard_manifest.py 15 --write) is
# deliberately NOT part of normal maintenance: this block is frozen for
# pr-risk.yml's/main.yml's legacy fork/push jobs (see engdocs/TESTING.md),
# so every TestProxiedServer*/TestServerMode* function added since it was
# last generated hash-distributes via proxied-test-shard.sh (cksum(name) %
# total) instead of being explicitly listed here. Only reweight it on
# purpose, and expect the shard assignments below to change substantially
# if you do (a fresh run packs every currently-discovered test, not just
# the ones already listed here).
#
# Deliberate exception (Oct 2026): four tests that had been hash-placed
# onto the two shards closest to the 15m -test.timeout are pinned here
# by hand, onto shards whose measured CI job time was lowest; nothing
# that was already listed moved. TestProxiedServerStorageClass and
# TestProxiedServerServeRefusesAStaleCheckpointWithGone (discovered
# from #7129 on) had hashed onto shard 5, which then hit the timeout on
# most Main runs; pinning them returns shard 5 to its earlier test set.
# TestProxiedServerListComments and
# TestProxiedServerServeRefusesAStreamOnADisabledJournal had hashed
# onto shard 3, which runs within about a minute of the timeout. An
# incremental --write keeps pinned lines where they are; a pin is a
# reviewed choice, not a regeneration of this block.
#
# TestProxiedServerOutageReconnectAcceptanceMatrix is pinned to shard 1
# (the lightest in recent Main runs, ~6.5 min) instead of hashing onto
# shard 14, which already runs ~13.5 min of the 15m timeout. These jobs
# have no socat, so today it skips here; the pin keeps shard 14 safe if
# socat is ever installed.
#
# TestProxiedServerClose3 (shard 13) and TestProxiedServerClose4 (shard 2)
# are the two parents gastownhall/beads#7173 split off TestProxiedServerClose
# to pull shard 5 (15m+) back under the timeout, pinned onto the two
# lightest shards of that PR's own run other than shard 5 itself (6m51s
# and 7m57s; shard 5 ran 5m50s only because their 12 subtests had just
# left it, and putting Close3 back would recreate most of the set that
# timed out) rather than hashed; the lines are listed under their shards
# like every other pin.
#
# This file is generated: notes added here are erased by the next
# regeneration. Add them to the generator instead. Known blind spots
# of the cost proxy (it counts inits, not the work done per init):
#
# TestProxiedServerListSortRetiresTheWalk is the most expensive
# entry and one of the cheapest-looking: off a single init it seeds
# 1400 rows and walks the listing three ways. It is the measurement
# behind the claim that sort=priority retires the client-side walk,
# so it has to run on PRs.
#
# TestProxiedServerServeReadParity is the CLI/HTTP read parity
# oracle, the behavioural half of the anti-drift claim. It being in
# this lane, and this lane being required by the PR Risk CI gate,
# is what makes that claim enforced on PRs rather than asserted in
# a doc comment.
15 1 TestProxiedServerBlocked
15 1 TestProxiedServerCompactDolt
15 1 TestProxiedServerCreate
15 1 TestProxiedServerDep2
15 1 TestProxiedServerDepConcurrent
15 1 TestProxiedServerListSortRetiresTheWalk
15 1 TestProxiedServerMolLastActivity
15 1 TestProxiedServerOutageReconnectAcceptanceMatrix
15 1 TestProxiedServerReopenConcurrent
15 1 TestProxiedServerServeReadParity
15 1 TestProxiedServerServeRefusesAStreamOnADisabledJournal
15 1 TestProxiedServerUpdateConcurrentClaim
15 2 TestProxiedServerClose4
15 2 TestProxiedServerCompactHistory
15 2 TestProxiedServerCreate2
15 2 TestProxiedServerDepListSingleIDWarnsOnDroppedExternalEdge
15 2 TestProxiedServerFindDuplicates
15 2 TestProxiedServerListWatchCountsTheOffsetIntoMaxRows
15 2 TestProxiedServerReady2
15 2 TestProxiedServerSQL
15 2 TestProxiedServerServeReadRevision
15 2 TestProxiedServerUpdateConcurrentMetadata
15 2 TestProxiedServerUpdateIfGuards
15 3 TestProxiedServerCascadeParity
15 3 TestProxiedServerDoltLifecycle
15 3 TestProxiedServerMolBurn
15 3 TestProxiedServerMolStale
15 3 TestProxiedServerMoleculeFrontDoorDirectServerProxyParity
15 3 TestProxiedServerSQLDatabaseFlag
15 3 TestProxiedServerServeRelatedIssues
15 3 TestProxiedServerTag
15 3 TestProxiedServerUpdate
15 3 TestProxiedServerWispCreateRejectsEnumViolatingVar
15 4 TestProxiedServerCreateInfraTypeRoutesToWisps
15 4 TestProxiedServerEdit
15 4 TestProxiedServerListComments
15 4 TestProxiedServerMoleculeFrontDoorWriteParity
15 4 TestProxiedServerPour
15 4 TestProxiedServerReassignFence
15 4 TestProxiedServerServeAddComment
15 4 TestProxiedServerServeRelease
15 4 TestProxiedServerUpdate2
15 4 TestProxiedServerUpdateHooks
15 5 TestProxiedServerClose
15 5 TestProxiedServerConfigConcurrent
15 5 TestProxiedServerExport
15 5 TestProxiedServerGateLifecycle
15 5 TestProxiedServerMolReadyGated
15 5 TestProxiedServerMultiStatementSQL
15 5 TestProxiedServerServeAddDependencies
15 5 TestProxiedServerServeRemoveDependency
15 5 TestProxiedServerWispCreate
15 6 TestProxiedServerClose2
15 6 TestProxiedServerContext
15 6 TestProxiedServerExternalCreate
15 6 TestProxiedServerLink
15 6 TestProxiedServerNote
15 6 TestProxiedServerRelate
15 6 TestProxiedServerServeBatchClose
15 6 TestProxiedServerServeSettingsWrites
15 6 TestProxiedServerWispList
15 7 TestProxiedServerAssign
15 7 TestProxiedServerBackupRefusedOnExternalTopology
15 7 TestProxiedServerCount
15 7 TestProxiedServerGC
15 7 TestProxiedServerList
15 7 TestProxiedServerOrphans
15 7 TestProxiedServerReady
15 7 TestProxiedServerServeClaim
15 7 TestProxiedServerServeRefusesAStaleCheckpointWithGone
15 7 TestProxiedServerServeUpdate
15 7 TestProxiedServerState
15 8 TestProxiedServerBatchParity
15 8 TestProxiedServerCountIncludeInfra
15 8 TestProxiedServerDoltRemoteRemove
15 8 TestProxiedServerGateCreateInheritsRepoMetadata
15 8 TestProxiedServerLabel
15 8 TestProxiedServerMolBond
15 8 TestProxiedServerPathHelpers
15 8 TestProxiedServerRecomputeBlocked
15 8 TestProxiedServerServeClaimNext
15 8 TestProxiedServerSetState
15 9 TestProxiedServerChildren
15 9 TestProxiedServerComment
15 9 TestProxiedServerDeferAutoWake
15 9 TestProxiedServerGateFrontDoorDirectServerProxyParity
15 9 TestProxiedServerMemory
15 9 TestProxiedServerPing
15 9 TestProxiedServerPrune
15 9 TestProxiedServerReopen
15 9 TestProxiedServerServeClose
15 9 TestProxiedServerStale
15 10 TestProxiedServerCleanDatabases
15 10 TestProxiedServerDeferUndefer
15 10 TestProxiedServerDuplicates
15 10 TestProxiedServerGraph
15 10 TestProxiedServerPourRejectsEnumViolatingVar
15 10 TestProxiedServerSearch
15 10 TestProxiedServerServeCount
15 10 TestProxiedServerShow
15 10 TestProxiedServerStatuses
15 10 TestProxiedServerUpdateWisp
15 11 TestProxiedServerDelete
15 11 TestProxiedServerDep
15 11 TestProxiedServerGateCheck
15 11 TestProxiedServerGateList
15 11 TestProxiedServerHeartbeat
15 11 TestProxiedServerMolProgress
15 11 TestProxiedServerPriority
15 11 TestProxiedServerPromote
15 11 TestProxiedServerServeCreate
15 11 TestProxiedServerSwarm
15 12 TestProxiedServerDeleteBlockedJSONSingleDoc
15 12 TestProxiedServerHistory
15 12 TestProxiedServerKV
15 12 TestProxiedServerMolShow
15 12 TestProxiedServerQuery
15 12 TestProxiedServerQuick
15 12 TestProxiedServerServeDelete
15 12 TestProxiedServerShow2
15 12 TestProxiedServerTypes
15 12 TestProxiedServerUpdateClosePolicy
15 13 TestProxiedServerClose3
15 13 TestProxiedServerDeleteConcurrent
15 13 TestProxiedServerInfo
15 13 TestProxiedServerMolSquash
15 13 TestProxiedServerReadyClaimConcurrent
15 13 TestProxiedServerReadyWisp
15 13 TestProxiedServerServeEdgeCounts
15 13 TestProxiedServerShow3
15 13 TestProxiedServerStatus
15 13 TestProxiedServerUnclaim
15 13 TestProxiedServerWispGC
15 14 TestProxiedServerCleanDatabasesPurgeDropped
15 14 TestProxiedServerConfig
15 14 TestProxiedServerConfigSetMany
15 14 TestProxiedServerDeleteForceOrphans
15 14 TestProxiedServerImport
15 14 TestProxiedServerInitIfMissing
15 14 TestProxiedServerMolDistill
15 14 TestProxiedServerPrime
15 14 TestProxiedServerReadyConcurrent
15 14 TestProxiedServerServeLifecycle
15 14 TestProxiedServerStorageClass
15 14 TestProxiedServerUnclaimIfAssigneeParity
15 15 TestProxiedServerCloseConcurrent
15 15 TestProxiedServerDeleteWisp
15 15 TestProxiedServerEpic
15 15 TestProxiedServerHuman
15 15 TestProxiedServerLint
15 15 TestProxiedServerMolCurrent
15 15 TestProxiedServerReclaim
15 15 TestProxiedServerServeModeGate
15 15 TestProxiedServerTodo
15 15 TestProxiedServerUpdate3
15 15 TestProxiedServerUpdateConcurrentAppendNotes
# Proxied-server cmd test shard manifest.
#
# Format: <total_shards> <shard_number> <top_level_test_name>
@ -44,7 +276,6 @@
34 3 TestProxiedServerAutoPrune
34 3 TestProxiedServerClose2B
34 3 TestProxiedServerEventsJournalOffByDefault
34 3 TestProxiedServerIfRevisionCloseMismatchRefuses
34 3 TestProxiedServerMolLastActivity
34 3 TestProxiedServerPurgeWispsPlaneRetention
34 3 TestProxiedServerServeLifecycle
@ -69,17 +300,13 @@
34 6 TestProxiedServerServeReadsTheJournalItJustWrote
34 6 TestProxiedServerSwarm
34 6 TestProxiedServerUpdate2B
34 6 TestProxiedServerVersionedHistorySwitchRefusesAnUnrecordableGateTimeout
34 6 TestProxiedServerWispList
34 7 TestProxiedServerCloseConcurrent
34 7 TestProxiedServerCreateInfraTypeRoutesToWisps
34 7 TestProxiedServerDeleteIfRevisionSingleWinner
34 7 TestProxiedServerExternalCreate
34 7 TestProxiedServerIfRevisionGuardDelete
34 7 TestProxiedServerIfRevisionTargetGoneIsPreconditionFailed
34 7 TestProxiedServerLabelC
34 7 TestProxiedServerMoleculeLifecycleAgreesOnEveryRoute
34 7 TestProxiedServerTypesAgreeWithCreate
34 8 TestProxiedServerClose2
@ -93,7 +320,6 @@
34 9 TestProxiedServerGateLifecycle
34 9 TestProxiedServerHistoryRemoteSupportedFrontDoorParity
34 9 TestProxiedServerIfRevisionGuardReopen
34 9 TestProxiedServerIfRevisionOutranksReassignFence
34 9 TestProxiedServerServeRefusesTheJournalWhenItIsDisabled
34 9 TestProxiedServerUpdate
34 9 TestServerModeServe
@ -124,7 +350,6 @@
34 13 TestProxiedServerCompactDolt
34 13 TestProxiedServerCreate2
34 13 TestProxiedServerGraph
34 13 TestProxiedServerHistoryRemoteSupportedDirectParity
34 13 TestProxiedServerMolSquash
34 13 TestProxiedServerPromote
34 13 TestProxiedServerServeRefusesAStaleCheckpointWithGone
@ -133,7 +358,6 @@
34 14 TestProxiedServerCloseB
34 14 TestProxiedServerDuplicates
34 14 TestProxiedServerHeartbeat
34 14 TestProxiedServerIfRevisionCloseReplaysMoleculeAutoClose
34 14 TestProxiedServerInitIfMissing
34 14 TestProxiedServerMolReadyGated
@ -157,7 +381,6 @@
34 17 TestProxiedServerPrime
34 17 TestProxiedServerSQLDatabaseFlag
34 17 TestProxiedServerServeModeGate
34 17 TestServerModeServeIgnoresGraphModeDependency
34 18 TestProxiedServerClose3
34 18 TestProxiedServerCount
@ -199,7 +422,6 @@
34 23 TestProxiedServerIfRevisionGuardUpdate
34 23 TestProxiedServerListWatchCountsTheOffsetIntoMaxRows
34 23 TestProxiedServerMolBurn
34 23 TestProxiedServerSearchRoutesAgree
34 23 TestProxiedServerServeUpdate
34 23 TestProxiedServerUpdateConcurrentClaim
34 23 TestProxiedServerUpdateWisp
@ -207,7 +429,6 @@
34 24 TestProxiedServerDeleteBlockedJSONSingleDoc
34 24 TestProxiedServerDeleteForceOrphans
34 24 TestProxiedServerHuman
34 24 TestProxiedServerIfRevisionDeleteMatchAndMismatch
34 24 TestProxiedServerIfRevisionGuardAssign
34 24 TestProxiedServerListComments
34 24 TestProxiedServerListSortRetiresTheWalk
@ -237,7 +458,6 @@
34 28 TestProxiedServerDep2C
34 28 TestProxiedServerDoltLifecycle
34 28 TestProxiedServerIfRevisionCloseWarnsOnForcedOpenChildren
34 28 TestProxiedServerReady2
34 28 TestProxiedServerReassignFence
34 28 TestProxiedServerSQLStatementRouting
@ -256,13 +476,11 @@
34 30 TestProxiedServerStatus
34 30 TestProxiedServerTodo
34 30 TestProxiedServerUpdate2
34 30 TestProxiedServerVersionedHistoryServeActivatesTheProviderFromItsOwnRow
34 31 TestProxiedServerCloseBeadGate
34 31 TestProxiedServerComment
34 31 TestProxiedServerConfigB
34 31 TestProxiedServerEventsJournal
34 31 TestProxiedServerGateAddWaiterConvoy
34 31 TestProxiedServerIfRevisionGuardClose
34 31 TestProxiedServerMolBond

View file

@ -9,9 +9,7 @@ test //... --config=embedded
test //... --config=integration
test //... --config=doltserver
test //... --config=doltserver-proxied
test //... --config=dolt-race
test //... --config=doltserver-integration
test //... --config=doltserver-cmd
test //... --config=dolt-int
build --config=pure //cmd/bd:bd //cmd/bd:bd_test //internal/storage/embeddeddolt:embeddeddolt_test //internal/tracker:tracker_test
build --config=js-wasm //internal/hooks:hooks_test

View file

@ -46,14 +46,7 @@
# only what the PR changed is built and tested on the runner, and it is
# their only PR-time integration run (no legacy job runs it on PRs). Mode
# local (rbe=off) still skips it. Direct runs (push to main,
# workflow_dispatch, nightly.yml's call) gate nothing. In mode remote the
# dolt-server and proxied-server tiers run as one union job, bazel-dolt-race
# (`bazel test --config=dolt-race`), whose job.status is both the
# bazel-doltserver and the bazel-proxied output; in every other mode
# bazel-doltserver and bazel-proxied run as before and report their own.
# Exactly one of the two arms runs in any mode, so the gate ids
# (BAZEL_DOLTSERVER, BAZEL_PROXIED) and bazel-gate.sh's skips are unchanged
# (engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md, "dolt-race Union Lane").
# workflow_dispatch, nightly.yml's call) gate nothing.
#
# Execution mode, decided once by the rbe job (every other job needs it and
# reads its outputs; none re-derives the condition) and passed to
@ -223,9 +216,8 @@ on:
# test would silently stop the lane on main.
integration:
description: >
"off" skips bazel-integration, bazel-cmd-dolt and
bazel-server-storage; anything else (pr.yml and bazel-farm.yml
pass "on") runs them where remote execution is on.
"off" skips bazel-integration; anything else (pr.yml and
bazel-farm.yml pass "on") runs it where remote execution is on.
type: string
required: false
default: "on"
@ -349,27 +341,18 @@ on:
bazel-integration:
description: "bazel-integration's job.status"
value: ${{ jobs.bazel-integration.outputs.result }}
# Mode remote: bazel-dolt-race runs both tiers and the member jobs
# skip; every other mode: the reverse. One side is always empty.
bazel-doltserver:
description: "the dolt-server tier's job.status: bazel-dolt-race's in mode remote, bazel-doltserver's otherwise"
value: ${{ jobs.bazel-dolt-race.outputs.result || jobs.bazel-doltserver.outputs.result }}
description: "bazel-doltserver's job.status"
value: ${{ jobs.bazel-doltserver.outputs.result }}
bazel-proxied:
description: "the proxied-server tier's job.status: bazel-dolt-race's in mode remote, bazel-proxied's otherwise"
value: ${{ jobs.bazel-dolt-race.outputs.result || jobs.bazel-proxied.outputs.result }}
# Mode remote: bazel-dolt-int runs both tiers and the member jobs
# skip; every other mode: the reverse. One side is always empty
# (item 5 A2). bazel-dolt-int reports its own per-tier classification
# (classify_tier_results.py), not job.status: the job carries no
# continue-on-error, so job.status alone would read failure for both
# tiers on a cmd-dolt-only failure, unlike bazel-cmd-dolt's own
# advisory, continue-on-error nature outside mode remote.
description: "bazel-proxied's job.status"
value: ${{ jobs.bazel-proxied.outputs.result }}
bazel-server-storage:
description: "the server-Dolt storage tier's result: bazel-dolt-int's server_storage_result in mode remote, bazel-server-storage's job.status otherwise"
value: ${{ jobs.bazel-dolt-int.outputs.server_storage_result || jobs.bazel-server-storage.outputs.result }}
description: "bazel-server-storage's job.status"
value: ${{ jobs.bazel-server-storage.outputs.result }}
bazel-cmd-dolt:
description: "the cmd/bd Dolt-server tier's result (advisory unless pr.yml's BAZEL_CMD_DOLT_REQUIRED is \"true\"): bazel-dolt-int's cmd_dolt_result in mode remote, bazel-cmd-dolt's job.status otherwise"
value: ${{ jobs.bazel-dolt-int.outputs.cmd_dolt_result || jobs.bazel-cmd-dolt.outputs.result }}
description: "bazel-cmd-dolt's job.status (advisory unless pr.yml's BAZEL_CMD_DOLT_REQUIRED is \"true\")"
value: ${{ jobs.bazel-cmd-dolt.outputs.result }}
package-mcp:
description: "package-mcp's job.status (empty unless package-gates is 'on')"
value: ${{ jobs.package-mcp.outputs.result }}
@ -525,11 +508,10 @@ jobs:
# canary seed, and bazel-test reads;
# on seed, and every lane in .github/scripts/rrc-lane-commands.txt
# reads.
# Mode remote only: fork pull_request runs see no vars (mode cache
# reads through setup-bazel's rc instead, in the jobs that pass
# BAZEL_RRC_READ, behind its probe of rbe-cache: write-bazelrc.sh). Any other value is off, with a warning, so a typo
# never fails the required gate. Like decide, this step runs no
# repository code (it comes before the checkout).
# Mode remote only: fork pull_request runs see no vars, and only
# rbe-west's trusted edge serves the entries. Any other value is off,
# with a warning, so a typo never fails the required gate. Like decide,
# this step runs no repository code (it comes before the checkout).
- name: Remote repo contents cache
id: rrc
env:
@ -777,10 +759,7 @@ jobs:
# and cache runs (forks, rbe=off/cache, no secrets) build everything
# they miss on the runner, so they get the larger GitHub-hosted one.
# Fork modes (fork-ro/fork-rw) execute remotely but stay GitHub-hosted,
# like every fork job: the runner is only a client. ubuntu-24.04, not
# ubuntu-latest, in every lane that reads the remote repo contents cache
# in mode cache: the cached trees are Linux x86_64 ones from a 24.04 host
# (design R2), so the image must not move under them.
# like every fork job: the runner is only a client.
#
# 8 vCPU, not the other lanes' 4: with every action a remote cache hit,
# this lane's `bazel test //... --config=ci` spent ~63 of 81s in
@ -789,7 +768,7 @@ jobs:
# parallelizes across the client's cores. Analysis-only, seeded runner
# cache (ga-vnycm2.8): 38.3s on 2 vCPU, 25.6s on 4, 16.3s on 8.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-24.04' }}
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-latest' }}
# Remote execution goes to rbe-west (instance "oss", the Blacksmith-backed
# worker pool shared with gascity). Skipped only in mode skip (same-repo
# runs while RBE_WEST_WORKERS is unset).
@ -864,7 +843,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -1079,13 +1057,13 @@ jobs:
name: pure-Go and js/wasm
# Same runner and skip rule as bazel-test.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-24.04' }}
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.mode != 'skip' }}
timeout-minutes: 90
outputs:
result: ${{ steps.result.outputs.result }}
env:
PURE_CMD_BD_TESTS: '^Test(Help|CheckRemoteSafety|FormatDestroyToken|ShouldWireInitRemote|ExtractPrefix|IsNumericID|GetWorktreeGitDir|DriftItemStatuses|RunDriftChecks|IsServerProbablyRunning|CheckHooksDriftNotGitRepo|CheckServerDriftNoBeadsDir|CheckRemoteDriftNoBeadsDir|NocgoFactoriesHonorSharedServer|NocgoNewDoltStoreFromConfig_ErrorSuggestsCorrectFlag|NocgoNewReadOnlyStoreFromConfig_ErrorSuggestsCorrectFlag|NocgoStoreFactoriesRefuseGraphWorkspace)'
PURE_CMD_BD_TESTS: '^Test(Help|CheckRemoteSafety|FormatDestroyToken|ShouldWireInitRemote|ExtractPrefix|IsNumericID|GetWorktreeGitDir|DriftItemStatuses|RunDriftChecks|IsServerProbablyRunning|CheckHooksDriftNotGitRepo|CheckServerDriftNoBeadsDir|CheckRemoteDriftNoBeadsDir|NocgoFactoriesHonorSharedServer|NocgoNewDoltStoreFromConfig_ErrorSuggestsCorrectFlag|NocgoNewReadOnlyStoreFromConfig_ErrorSuggestsCorrectFlag)'
# The only pre-merge run of these boundaries: where it executes
# remotely --config=sole-run fails on a remote cache eviction instead
# of re-running the whole invocation (whose retry could turn a failed
@ -1134,7 +1112,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -1350,11 +1327,9 @@ jobs:
JOB_STATUS: ${{ job.status }}
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
# pr-risk.yml's retired embedded-Dolt tier ("Test (Embedded Dolt Cmd N/20)",
# pr-risk.yml's embedded-Dolt tier ("Test (Embedded Dolt Cmd N/20)",
# "Test (Embedded Dolt Storage N/5)", "Test (Embedded Dolt Conformance -
# core/audit)") as --config=embedded: those jobs, and the frozen 20-shard
# cmd block they read, no longer exist (see engdocs/TESTING.md) — this runs
# the embedded-tagged variants of
# core/audit)") as --config=embedded: the embedded-tagged variants of
# //cmd/bd:bd_test and //internal/storage/embeddeddolt:embeddeddolt_test.
# The shard variants run the jobs' own shard scripts and manifests, so Bazel
# shard k runs exactly the tests of job k. A job of its own rather than a
@ -1372,8 +1347,8 @@ jobs:
# scripts/ci/embedded_storage_test_durations.json -- up from an earlier,
# smaller test surface's ~7-10k estimate) on one runner, several hours
# per run on the pool whose job cap this track exists to relieve, and it
# proved nothing pr-risk.yml's embedded jobs (which ran for forks before
# #7353 retired them) did not.
# proves nothing pr-risk.yml's embedded jobs (which do run for forks) do
# not.
#
# Shard counts: storage (40): its tests are serial, so a shard's wall
# time is the sum of its tests, and CI shards run ~1.3-1.6x the rbe-west
@ -1434,7 +1409,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -1506,25 +1480,6 @@ jobs:
if-no-files-found: ignore
retention-days: 7
# The served targets' per-test durations, on every run: their pinned
# shard manifests (backend/http/served_pinned_shards.txt from
# tools/bazel/pin_shards.py, the corpus parts' split) are sized from a
# sharded run of this lane, and the logs above are kept only on failure.
# test.xml only, a few KB each. Telemetry like the CI analytics upload:
# nothing in CI reads it, so an artifact 5xx or stall must not fail or
# hold the lane (scripts TestBazelEmbeddedServedTimingsUploadIsTelemetry).
- name: Upload served test timings
if: ${{ !cancelled() && steps.test.outcome != 'skipped' }}
continue-on-error: true
timeout-minutes: 2
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
overwrite: true # a job re-run is the same run: replace, not 409
name: bazel-embedded-served-testxml
path: bazel-testlogs/backend/http/**/test.xml
if-no-files-found: ignore
retention-days: 7
# Same redacted summary as bazel-test's; see its comment.
- name: CI analytics summary
id: ci-analytics
@ -1601,12 +1556,9 @@ jobs:
# A caller may turn it off with integration: "off"; pr.yml and
# bazel-farm.yml pass "on".
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-24.04' }}
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ (needs.rbe.outputs.enabled == 'true' || needs.rbe.outputs.mode == 'cache') && inputs.integration != 'off' }}
# F5 S2 Variant A added the "Nogo: integration library files" step after
# `test`; +5 over the previous 85 keeps it headroom without exceeding
# TestBazelIntegrationJob's test-step-timeout+15 ceiling (75+15=90).
timeout-minutes: 90
timeout-minutes: 85
outputs:
result: ${{ steps.result.outputs.result }}
steps:
@ -1638,7 +1590,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -1687,34 +1638,6 @@ jobs:
if: ${{ always() && steps.test.outcome != 'skipped' }}
run: python3 tools/bazel/check_testcases.py --bep "$RUNNER_TEMP/bazel-bep.json" --not-go //tools/bazel:dolt_version_test --not-go //scripts/repochecks:all
# F5 S2 Variant A: the integration/doltserver-integration/doltserver-cmd
# configuration (--config=integration plus race) has no full-lane nogo
# owner (every lane above passes --norun_validations, .bazelrc). This
# narrow build keeps full nogo (vet + golangci-lint) on the
# configuration's non-test library package,
# //internal/testutil/integration, which every one of those lanes
# compiles; the 56 integration-tagged _test.go files this does not
# cover are the accepted loss (tools/nogo/unvalidated_integration_tests.txt,
# f5-spec.md §3). --keep_going so one finding does not hide another.
# scripts/nogo_lint_policy_test.go's
# TestNogoConfigurationsHaveOneValidatingLane pins this step as the
# configuration's sole validating lane.
- name: "Nogo: integration library files"
id: nogo-integration
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 10
run: |
set -o pipefail
start=$(date +%s)
rc=0
bazel build --config=integration --@rules_go//go/config:race --keep_going \
--output_groups=nogo_fix \
-- //internal/testutil/integration:integration \
2>&1 | tee "$RUNNER_TEMP/bazel-nogo-integration.log" || rc=$?
procs=$(grep -oE 'INFO: [0-9]+ process' "$RUNNER_TEMP/bazel-nogo-integration.log" | tail -1 || true)
echo "nogo-integration: exit $rc, $(( $(date +%s) - start ))s wall${procs:+, $procs}" | tee -a "$GITHUB_STEP_SUMMARY"
exit "$rc"
- name: Upload test logs
if: ${{ failure() && steps.test.outcome != 'skipped' }}
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
@ -1774,18 +1697,12 @@ jobs:
# doctor/fix, protocol in 8 shards, testutil), each of which starts its
# own dolt sql-server from the pinned dolt, so they execute on the remote
# workers like any other test (locally with rbe=off).
# Not in mode remote: there bazel-dolt-race runs this tier together with
# the proxied-server tier and reports for both (item 5). In the fork
# modes, cache and local there is no in-flight deduplication of one
# client's actions and the client does the work, so a union would cost the
# sum of the two tiers instead of the max: this job runs there as before.
bazel-doltserver:
name: dolt-server lane
# Same runner as bazel-test; bazel-test's skip rule, plus mode remote
# (bazel-dolt-race's).
# Same runner and skip rule as bazel-test.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-24.04' }}
if: ${{ needs.rbe.outputs.mode != 'skip' && needs.rbe.outputs.mode != 'remote' }}
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.mode != 'skip' }}
timeout-minutes: 90
outputs:
result: ${{ steps.result.outputs.result }}
@ -1827,7 +1744,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -1901,23 +1817,20 @@ jobs:
JOB_STATUS: ${{ job.status }}
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
# Like pr-risk.yml's retired proxied-server tier, "Test (Proxied Dolt Cmd
# N/15)" (that job, and the frozen 15-shard block it read, no longer exist;
# see engdocs/TESTING.md), as --config=doltserver-proxied:
# //cmd/bd:bd_proxied_test runs the shard script, so shard k runs exactly
# that manifest entry's tests. This lane runs 34 shards of its own
# (.github/scripts/proxied-cmd-test-shards.txt's duration-balanced 34-block;
# see scripts/ci/proxied_test_durations.json) — shard k here was never the
# same split as the retired job's shard k. Same build as --config=doltserver
# (race bd_test, non-race
# Like pr-risk.yml's proxied-server tier, "Test (Proxied Dolt Cmd N/15)",
# as --config=doltserver-proxied: //cmd/bd:bd_proxied_test runs the shard
# script, so shard k runs exactly that manifest entry's tests. This lane
# runs 34 shards of its own (.github/scripts/proxied-cmd-test-shards.txt's
# duration-balanced 34-block; see scripts/ci/proxied_test_durations.json),
# not the legacy jobs' 15 — shard k here is not the same split as their
# shard k. Same build as --config=doltserver (race bd_test, non-race
# bd_for_tests), shared with bazel-doltserver through the remote cache.
# The test binary is race, as PR Risk's retired jobs built it. It also runs
# //cmd/bd:bd_managed_local_test, the managed-local proxied lifecycle
# (formerly proxied-local-smoke.yml) in a loopback-only network
# namespace, which needs the workers' unprivileged user namespaces. A job
# of its own, not gated by any integration switch: it runs in pr.yml's
# call and its gate requires it (BAZEL_PROXIED). Fork modes only: in mode
# remote bazel-dolt-race runs this tier (see bazel-doltserver's comment).
# call and its gate requires it (BAZEL_PROXIED).
bazel-proxied:
name: proxied-server tier
# Remote execution only, like bazel-embedded: 30 concurrent shards, each
@ -1927,7 +1840,7 @@ jobs:
# retired) and pr.yml's gate requires it to have run here and passed.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.enabled == 'true' && needs.rbe.outputs.mode != 'remote' }}
if: ${{ needs.rbe.outputs.enabled == 'true' }}
timeout-minutes: 30
outputs:
result: ${{ steps.result.outputs.result }}
@ -1960,7 +1873,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -2071,208 +1983,25 @@ jobs:
JOB_STATUS: ${{ job.status }}
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
# Item 5 (scripts/bazel_dolt_race_test.go): the dolt-server and
# proxied-server tiers in one `bazel test --config=dolt-race` (.bazelrc:
# exactly the union of --config=doltserver's and
# --config=doltserver-proxied's lines, one tag filter for both), mode
# remote only, in place of bazel-doltserver and bazel-proxied, which run
# in every other mode. One client waits on rbe-west for both tiers'
# shards at once (27 + 35 test actions, under the remote-exec config's 64
# jobs), so the job ends with the slower tier and saves the other's
# runner. Each member target's test action key is unchanged (aquery-
# verified), so cached results carry over both ways, and a revert of the
# cutover re-executes nothing. Gated: its job.status is both the
# bazel-doltserver and the bazel-proxied workflow_call output (a failure
# in either tier fails both ids, which are both required). Every step has
# a timeout and the job's exceeds their sum by 5 minutes while staying
# under the merge queue's 60-minute check timeout
# (TestBazelDoltRaceJobTimeouts), so a hang fails a named step instead of
# dropping the merge group. The member jobs' configs and the union's must
# stay key-identical: the mode decides which runs (TestBazelDoltRaceConfigIsMemberUnion).
# Its ci-analytics LANE is dolt-race.
bazel-dolt-race:
name: dolt-race
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.mode == 'remote' }}
# At least every step's timeout-minutes plus 5, and below the merge
# queue's 60-minute check timeout so this job alone cannot exhaust it
# (TestBazelDoltRaceJobTimeouts). Not a whole-run bound: the rbe job runs
# first and sibling lanes have longer timeouts.
timeout-minutes: 56
outputs:
result: ${{ steps.result.outputs.result }}
steps:
# inputs.checkout-sha: see the header (empty: the event's default ref).
# checkout v7 refuses a fork head on pull_request_target unless opted
# in; only bazel-farm.yml's authorized call opts in (false elsewhere).
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
timeout-minutes: 5
with:
ref: ${{ inputs.checkout-sha }}
persist-credentials: false
allow-unsafe-pr-checkout: ${{ inputs.fork-farm == 'authorized' && github.event_name == 'pull_request_target' }}
# The remote repo contents cache, read-only, as in bazel-test.
- name: Remote repo contents cache (read)
if: ${{ needs.rbe.outputs.mode == 'remote' && needs.rbe.outputs.rrc == 'on' }}
timeout-minutes: 1
run: |
{
echo 'startup --experimental_remote_repo_contents_cache'
echo 'common --loading_phase_threads=64'
} >> .bazelrc.local
- name: Set up Bazel
id: bazel
timeout-minutes: 5
uses: ./.github/actions/setup-bazel
env:
BAZEL_REMOTE_EXECUTOR: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_WEST_EXECUTOR || '' }}
RBE_TLS_CERT: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CERT || '' }}
RBE_TLS_KEY: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_KEY || '' }}
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
# As in bazel-proxied.
- name: No test target is marked flaky
timeout-minutes: 3
run: |
flaky="$(bazel query 'attr(flaky, 1, tests(//...))')"
if [ -n "$flaky" ]; then
echo "::error::flaky = True on ${flaky//$'\n'/ }: the gated lanes run each test once"
exit 1
fi
# Both tiers' shards at once: 27 dolt-server + 35 proxied test actions,
# under the remote-exec config's 64 jobs. No --config=sole-run: its one
# line (no retry on a remote cache eviction) is already in the union.
# Shards are expected around 55-95s on rbe-west (see bazel-proxied's
# test step), the proxied tier's 1200s cap included. The step timeout is
# >= proxied test_timeout 1200 s + about 3 min so Bazel writes TIMEOUT
# logs before GitHub kills the step.
- name: bazel test //... --config=dolt-race
id: test
timeout-minutes: 23
run: |
set -o pipefail
start=$(date +%s)
rc=0
bazel test //... --config=dolt-race ${BAZEL_FRESH:+"$BAZEL_FRESH"} \
--build_event_json_file="$RUNNER_TEMP/bazel-bep.json" \
--execution_log_compact_file="$RUNNER_TEMP/bazel-exec.log.zst" \
--profile="$RUNNER_TEMP/bazel-profile.json" \
--experimental_build_event_upload_strategy=local \
2>&1 | tee "$RUNNER_TEMP/bazel-test.log" || rc=$?
echo "bazel test --config=dolt-race: exit $rc, $(( $(date +%s) - start ))s wall" | tee -a "$GITHUB_STEP_SUMMARY"
exit "$rc"
# The member lanes' checks, once over the union's BEP: bazel-proxied's
# (the dolt-server lane has none). check_shard_coverage ignores targets
# it does not list; check_testcases checks every target, so it covers
# the dolt-server tier too, which bazel-doltserver does not check: a
# dolt-server shard that runs no test turns this job red.
- name: Every target and shard ran tests
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 2
run: python3 tools/bazel/check_testcases.py --bep "$RUNNER_TEMP/bazel-bep.json"
- name: Every listed test ran in its shard
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 2
run: >-
python3 tools/bazel/check_shard_coverage.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--suite //cmd/bd:bd_proxied_test .github/scripts/proxied-test-shard.sh 34
- name: Upload test logs
if: ${{ failure() && steps.test.outcome != 'skipped' }}
timeout-minutes: 3
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
overwrite: true # a job re-run is the same run: replace, not 409
name: bazel-dolt-race-testlogs
path: |
bazel-testlogs/**/test.log
bazel-testlogs/**/test.xml
if-no-files-found: ignore
retention-days: 7
# Same redacted summary as bazel-test's; see its comment.
- name: CI analytics summary
id: ci-analytics
if: "!cancelled() && steps.test.outcome != 'skipped'"
continue-on-error: true
timeout-minutes: 2
env:
LANE: dolt-race
MODE: ${{ needs.rbe.outputs.mode }}
CHECK_RUN_ID: ${{ job.check_run_id }}
PR_HINT: ${{ github.event.pull_request.number || 0 }}
run: |
[ -f "$RUNNER_TEMP/bazel-bep.json" ] || exit 0
zstd --version || echo "::warning::zstd missing: no per-mnemonic data in this lane's summary"
python3 tools/bazel/ci_analytics_extract.py \
--lane "$LANE" --mode "$MODE" --check-run-id "$CHECK_RUN_ID" --pr-hint "$PR_HINT" \
--invocation test "$RUNNER_TEMP/bazel-bep.json" "$RUNNER_TEMP/bazel-exec.log.zst" "$RUNNER_TEMP/bazel-profile.json" \
--out "$RUNNER_TEMP/ci-analytics/ci-analytics.json"
- name: Upload CI analytics summary
if: "!cancelled() && steps.ci-analytics.outcome == 'success'"
continue-on-error: true
timeout-minutes: 2
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
overwrite: true # a job re-run is the same run: replace, not 409
name: ci-analytics-dolt-race-${{ github.run_attempt }}
path: ${{ runner.temp }}/ci-analytics/ci-analytics.json
retention-days: 7
if-no-files-found: ignore
# Last step: the job's result as the bazel-doltserver and
# bazel-proxied workflow_call outputs for pr.yml's ci-gate. always()
# runs it after a failure, a timeout or a cancellation too.
- name: Record job result
id: result
if: ${{ always() }}
timeout-minutes: 1
env:
JOB_STATUS: ${{ job.status }}
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
# pr-risk.yml's server-Dolt storage tier, "Test (Server Dolt Conformance)"
# and "Test (Server Dolt Full Suite N/16)", as --config=doltserver-integration:
# the conformance and 16-shard full-suite variants of
# //internal/storage/dolt over a non-race dolt_test build, each shard
# running the job's own shard script. --config=doltserver-integration has
# exactly --config=integration's build flags, so it compiles nothing
# bazel-integration does not (shared through the remote cache). This is a
# PR-time tier, unlike main.yml's integration jobs, and pr.yml's gate
# requires it (BAZEL_SERVER_STORAGE); it also honors the same
# `integration` input as bazel-integration/bazel-cmd-dolt so an explicit
# "off" skips it too, even though no caller passes that today (pr.yml and
# bazel-farm.yml both pass "on") -- see the `integration` input's own
# description.
# Not in mode remote: there bazel-dolt-int runs this tier together with
# the cmd/bd Dolt-server tier and reports for both (item 5 A2). In the
# fork modes and cache there is no in-flight deduplication of one client's
# actions, so a union would cost the sum of the two tiers instead of the
# max: this job runs there as before.
# bazel-integration does not (shared through the remote cache). A job of
# its own, not gated by any integration switch: this is a PR-time tier,
# unlike main.yml's integration jobs, and pr.yml's gate requires it
# (BAZEL_SERVER_STORAGE).
bazel-server-storage:
name: server-Dolt storage tier
# Remote execution only, like bazel-integration: locally the tagged race
# build of //... alone is most of the timeout. Plus mode remote
# (bazel-dolt-int's).
# build of //... alone is most of the timeout.
# This lane is the tier's only PR run (pr-risk.yml's legacy jobs are
# retired) and pr.yml's gate requires it to have run here and passed.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.enabled == 'true' && needs.rbe.outputs.mode != 'remote' && inputs.integration != 'off' }}
if: ${{ needs.rbe.outputs.enabled == 'true' }}
timeout-minutes: 30
outputs:
result: ${{ steps.result.outputs.result }}
@ -2305,7 +2034,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -2422,7 +2150,7 @@ jobs:
# integration-tagged cmd/bd suite (//cmd/bd:bd_dolt_server_test, 32
# shards, the slowest tests pinned to 16 of them) against a hermetic dolt sql-server, i.e. the Dolt-gated cmd/bd
# tests (TestCLI_*, TestInit*, the store-backed suites) that every other
# lane skips with BEADS_TEST_SKIP=dolt or leaves out of its
# lane and legacy job skips with BEADS_TEST_SKIP=dolt or leaves out of its
# manifest; plus the differential regression suite
# (//tests/regression:regression_test, 14 shards: the candidate
# bd_for_tests against the catalog-pinned v0.49.6 release, formerly
@ -2442,12 +2170,9 @@ jobs:
# (TestBazelIntegrationExcludesBdTestOnlyWhereCmdDoltCovers).
bazel-cmd-dolt:
name: cmd/bd Dolt-server tier
# Not in mode remote: there bazel-dolt-int runs this tier together with
# the server-Dolt storage tier (item 5 A2). See bazel-server-storage's
# comment above.
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-24.04' }}
if: ${{ (needs.rbe.outputs.enabled == 'true' || needs.rbe.outputs.mode == 'cache') && inputs.integration != 'off' && needs.rbe.outputs.mode != 'remote' }}
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ (needs.rbe.outputs.enabled == 'true' || needs.rbe.outputs.mode == 'cache') && inputs.integration != 'off' }}
timeout-minutes: 85
continue-on-error: true
outputs:
@ -2481,7 +2206,6 @@ jobs:
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
@ -2572,292 +2296,6 @@ jobs:
JOB_STATUS: ${{ job.status }}
run: echo "result=$JOB_STATUS" >> "$GITHUB_OUTPUT"
# Item 5 A2 (scripts/bazel_dolt_int_test.go): the server-Dolt storage and
# cmd/bd Dolt-server tiers in one `bazel test --config=dolt-int` (.bazelrc:
# exactly the union of --config=doltserver-integration's and
# --config=doltserver-cmd's lines, one tag filter for both), mode remote
# only, in place of bazel-server-storage and bazel-cmd-dolt, which run in
# every other mode (there a single client does both tiers' work without
# in-flight deduplication, so a union would cost the sum of the two tiers
# rather than the max). One client waits on rbe-west for both tiers' shards
# at once (17 + 46 = 63 test actions, under the remote-exec config's 64
# jobs), so the job ends with the slower tier and the other tier's runner
# is saved. cmd-dolt's Go-level -test.timeout=19m arg and its
# BEADS_TEST_REQUIRE_EXCLUDE_PERMISSION env moved from --config=doltserver-cmd
# onto //cmd/bd:bd_dolt_server_test's and //tests/regression:regression_test's
# own args/env (their comments), so the union's tag filter alone decides
# which targets see them: without the move, server-storage's per-shard 15m
# Go timeout would become 19m under the union. The final argv and
# environment either way are identical (aquery-verified for all 4 affected
# targets, item 5 A2 PR), so remote action digests -- what RBE's cache keys
# on -- are unchanged and cached results should carry over; this is a local
# actionKey change for cmd-dolt's 46 actions, not a remote one (--test_env
# is part of the build configuration's own fingerprint, which every target
# under that configuration picks up, unlike a target's own env attribute),
# confirmed in practice by the first merge group's tests_cached ==
# tests_total in ci-analytics, not claimed here as already observed.
#
# Unlike dolt-race, the members have different gating categories:
# bazel-server-storage is plain-gated (BAZEL_SERVER_STORAGE), bazel-cmd-dolt
# is flag-gated and advisory (BAZEL_CMD_DOLT, continue-on-error) until
# pr.yml's BAZEL_CMD_DOLT_REQUIRED is "true". This job therefore carries no
# job-level continue-on-error: on push, nightly and dispatch nothing reads
# BAZEL_SERVER_STORAGE off a workflow_call output, so job-level
# continue-on-error (job.status reads success regardless of the test step's
# own result) would let a server-storage failure end such a run green,
# where it must stay red exactly as it does on main today. Instead only the
# `bazel test` step carries continue-on-error, and an always() step
# (tools/bazel/classify_tier_results.py) reads the BEP by target label,
# computes each tier's own result, and fails the job itself iff
# server-storage's tier failed (a cmd-dolt-only test failure leaves the job
# green, as bazel-cmd-dolt's own continue-on-error already does outside
# mode remote) or bazel's exit code was neither 0 nor 3 (a build or infra
# failure is not attributable to one tier, so both are marked failed and
# the job fails regardless). Both members' workflow_call outputs read this
# job's matching per-tier output first, then their own member's; a job that
# dies before the classify step leaves both outputs empty, which mode
# remote's gate (bazel-gate.sh, ci-gate.sh) already treats as skipped and
# fails, same as an empty bazel-server-storage/bazel-cmd-dolt result would.
# Every step has a timeout and the job's exceeds their sum by 5 minutes
# while staying under the merge queue's 60-minute check timeout
# (TestBazelDoltIntJobTimeouts): 58 leaves only about 2 minutes for runner
# pickup and the rbe job inside that 60-minute budget, so a hang that runs
# to this job's own timeout can drop the merge group; accepted, because
# such a run is red anyway and the 58-minute job timeout bounds only this
# job, not the whole run (as #7514's dolt-race job comment). The member
# jobs' configs and the union's must stay key-identical: the mode decides
# which runs (TestBazelDoltIntConfigIsMemberUnion). Its ci-analytics LANE
# is dolt-int.
bazel-dolt-int:
name: dolt-int
needs: rbe
runs-on: ${{ needs.rbe.outputs.mode == 'remote' && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
if: ${{ needs.rbe.outputs.mode == 'remote' && inputs.integration != 'off' }}
# At least every step's timeout-minutes plus 5, and below the merge
# queue's 60-minute check timeout so this job alone cannot exhaust it
# (TestBazelDoltIntJobTimeouts). 58 leaves only about 2 minutes for
# runner pickup and the rbe job inside the merge queue's 60-minute check;
# a hang that runs to this timeout can therefore drop the group, which is
# accepted because such a run is red anyway and the 58-minute job timeout
# bounds this job, not the whole run (as #7514's dolt-race job comment).
timeout-minutes: 58
outputs:
server_storage_result: ${{ steps.classify.outputs.server_storage_result }}
cmd_dolt_result: ${{ steps.classify.outputs.cmd_dolt_result }}
steps:
# inputs.checkout-sha: see the header (empty: the event's default ref).
# checkout v7 refuses a fork head on pull_request_target unless opted
# in; only bazel-farm.yml's authorized call opts in (false elsewhere).
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
timeout-minutes: 5
with:
ref: ${{ inputs.checkout-sha }}
persist-credentials: false
allow-unsafe-pr-checkout: ${{ inputs.fork-farm == 'authorized' && github.event_name == 'pull_request_target' }}
# The remote repo contents cache, read-only, as in bazel-test.
- name: Remote repo contents cache (read)
if: ${{ needs.rbe.outputs.mode == 'remote' && needs.rbe.outputs.rrc == 'on' }}
timeout-minutes: 1
run: |
{
echo 'startup --experimental_remote_repo_contents_cache'
echo 'common --loading_phase_threads=64'
} >> .bazelrc.local
- name: Set up Bazel
id: bazel
timeout-minutes: 5
uses: ./.github/actions/setup-bazel
env:
BAZEL_REMOTE_EXECUTOR: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_WEST_EXECUTOR || '' }}
RBE_TLS_CERT: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CERT || '' }}
RBE_TLS_KEY: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_KEY || '' }}
RBE_TLS_CA: ${{ needs.rbe.outputs.mode == 'remote' && secrets.RBE_TLS_CA || '' }}
RBE_INSTANCE: ${{ needs.rbe.outputs.mode == 'remote' && 'oss' || '' }}
BAZEL_FORK_CACHE: ${{ needs.rbe.outputs.mode == 'cache' && 'true' || '' }}
BAZEL_RRC_READ: 'true' # mode cache reads the repo contents cache through rbe-cache
BAZEL_FORK_REMOTE: ${{ startsWith(needs.rbe.outputs.mode, 'fork-') && 'true' || '' }}
RBE_FORK_TIER: ${{ needs.rbe.outputs.tier }}
RBE_FORK_PR: ${{ github.event.pull_request.number }}
# As in bazel-server-storage and bazel-proxied.
- name: No test target is marked flaky
timeout-minutes: 3
run: |
flaky="$(bazel query 'attr(flaky, 1, tests(//...))')"
if [ -n "$flaky" ]; then
echo "::error::flaky = True on ${flaky//$'\n'/ }: the gated lanes run each test once"
exit 1
fi
# Both tiers' shards at once: 17 server-storage + 46 cmd-dolt test
# actions, under the remote-exec config's 64 jobs. No --config=sole-run:
# its one line (no retry on a remote cache eviction) is already in the
# union. The step timeout is >= the union's eternal-size test_timeout
# cap (1200s, shared by bd_dolt_server_test and regression_test) + about
# 3 min so Bazel writes TIMEOUT logs before GitHub kills the step, plus
# the margin server-storage's own step budgets for a cold compile (its
# own step was 25). continue-on-error: a cmd-dolt-only test failure
# must not fail this step (and so the job) outright; the classify step
# below decides that per-tier, from this step's own exit code (written
# to its "rc" output) and the BEP.
- name: bazel test //... --config=dolt-int
id: test
timeout-minutes: 25
continue-on-error: true
run: |
set -o pipefail
start=$(date +%s)
rc=0
bazel test //... --config=dolt-int ${BAZEL_FRESH:+"$BAZEL_FRESH"} \
--build_event_json_file="$RUNNER_TEMP/bazel-bep.json" \
--execution_log_compact_file="$RUNNER_TEMP/bazel-exec.log.zst" \
--profile="$RUNNER_TEMP/bazel-profile.json" \
--experimental_build_event_upload_strategy=local \
2>&1 | tee "$RUNNER_TEMP/bazel-test.log" || rc=$?
echo "bazel test --config=dolt-int: exit $rc, $(( $(date +%s) - start ))s wall" | tee -a "$GITHUB_STEP_SUMMARY"
echo "rc=$rc" >> "$GITHUB_OUTPUT"
exit "$rc"
# check_testcases split per tier (should-fix 2, PR #7535 review): a
# single shared step with no continue-on-error would fail this job
# outright on a cmd-dolt-only zero-testcase shard (e.g. TestMain dying
# on dolt server start under BEADS_TEST_REQUIRE_DOLT_CONTAINER=1),
# where main (bazel-cmd-dolt alone) stays green, and the divergence
# would only show up under the documented rollback to
# BAZEL_CMD_DOLT_REQUIRED=false. Each step is --label-scoped to its own
# tier (so a --label typo or a label the run did not test fails
# closed, not open: check_testcases.py's own --label section) and
# carries continue-on-error so neither can fail the job by itself; the
# classify step below folds each step's own outcome into that tier's
# result with --check, so a cmd-dolt failure here reaches
# cmd_dolt_result only, same as a cmd-dolt BEP test failure does.
- name: Every target and shard ran tests (server-storage)
id: check-ss
if: ${{ always() && steps.test.outcome != 'skipped' }}
continue-on-error: true
timeout-minutes: 1
run: >-
python3 tools/bazel/check_testcases.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--label //internal/storage/dolt:dolt_server_full_test
--label //internal/storage/dolt:dolt_server_conformance_test
- name: Every target and shard ran tests (cmd-dolt)
id: check-cd
if: ${{ always() && steps.test.outcome != 'skipped' }}
continue-on-error: true
timeout-minutes: 1
run: >-
python3 tools/bazel/check_testcases.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--label //cmd/bd:bd_dolt_server_test
--label //tests/regression:regression_test
# bazel-server-storage's own check (cmd-dolt has none): every
# full-suite shard ran exactly the tests its shard script lists, and
# neither it nor the conformance target only skips.
- name: Every listed test ran in its shard
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 2
run: >-
python3 tools/bazel/check_shard_coverage.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--suite //internal/storage/dolt:dolt_server_full_test .github/scripts/server-storage-test-shard.sh 16
--whole //internal/storage/dolt:dolt_server_conformance_test
# bazel-server-storage's own check, scoped with --label to the one
# target it has always budgeted: cmd-dolt's bd_dolt_server_test and
# regression_test shards are sharded too but no job budgeted them
# before the union, and this script has never judged them (see its
# docstring).
- name: Shard balance
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 2
run: >-
python3 tools/bazel/shard_budget.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--label //internal/storage/dolt:dolt_server_full_test
# failure() alone misses an ordinary test failure here: the `bazel
# test` step carries its own continue-on-error (must-fix 2), so a
# failing test does not make failure() true until the classify step
# (which runs after this one) exits non-zero. steps.test.outcome ==
# 'failure' catches that case directly (nit, PR #7535 review).
- name: Upload test logs
if: ${{ (failure() || steps.test.outcome == 'failure') && steps.test.outcome != 'skipped' }}
timeout-minutes: 3
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
overwrite: true # a job re-run is the same run: replace, not 409
name: bazel-dolt-int-testlogs
path: |
bazel-testlogs/**/test.log
bazel-testlogs/**/test.xml
if-no-files-found: ignore
retention-days: 7
# Same redacted summary as bazel-test's; see its comment.
- name: CI analytics summary
id: ci-analytics
if: "!cancelled() && steps.test.outcome != 'skipped'"
continue-on-error: true
timeout-minutes: 2
env:
LANE: dolt-int
MODE: ${{ needs.rbe.outputs.mode }}
CHECK_RUN_ID: ${{ job.check_run_id }}
PR_HINT: ${{ github.event.pull_request.number || 0 }}
run: |
[ -f "$RUNNER_TEMP/bazel-bep.json" ] || exit 0
zstd --version || echo "::warning::zstd missing: no per-mnemonic data in this lane's summary"
python3 tools/bazel/ci_analytics_extract.py \
--lane "$LANE" --mode "$MODE" --check-run-id "$CHECK_RUN_ID" --pr-hint "$PR_HINT" \
--invocation test "$RUNNER_TEMP/bazel-bep.json" "$RUNNER_TEMP/bazel-exec.log.zst" "$RUNNER_TEMP/bazel-profile.json" \
--out "$RUNNER_TEMP/ci-analytics/ci-analytics.json"
- name: Upload CI analytics summary
if: "!cancelled() && steps.ci-analytics.outcome == 'success'"
continue-on-error: true
timeout-minutes: 2
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
overwrite: true # a job re-run is the same run: replace, not 409
name: ci-analytics-dolt-int-${{ github.run_attempt }}
path: ${{ runner.temp }}/ci-analytics/ci-analytics.json
retention-days: 7
if-no-files-found: ignore
# Last step: each tier's own result (not job.status: this job carries
# no continue-on-error, see the job's own comment) as the
# bazel-server-storage and bazel-cmd-dolt workflow_call outputs for
# pr.yml's ci-gate. always() runs it after a failure, a timeout or a
# cancellation too (steps.test.outcome stays "skipped" then, so the
# script's --bep file does not exist; it is only read when the test
# step actually ran). This step's own exit code decides job.status: it
# fails the job iff server-storage's tier failed, or `bazel test`'s
# exit code was neither 0 nor 3 (a build or infra failure, not
# attributable to one tier, fails both and the job).
- name: Classify tier results
id: classify
if: ${{ always() && steps.test.outcome != 'skipped' }}
timeout-minutes: 1
env:
TEST_RC: ${{ steps.test.outputs.rc }}
CHECK_SS_OUTCOME: ${{ steps.check-ss.outcome }}
CHECK_CD_OUTCOME: ${{ steps.check-cd.outcome }}
run: >-
python3 tools/bazel/classify_tier_results.py
--bep "$RUNNER_TEMP/bazel-bep.json"
--rc "$TEST_RC"
--tier server-storage=//internal/storage/dolt:dolt_server_full_test,//internal/storage/dolt:dolt_server_conformance_test
--tier cmd-dolt=//cmd/bd:bd_dolt_server_test,//tests/regression:regression_test
--gate-tier server-storage
--check "server-storage=$CHECK_SS_OUTCOME"
--check "cmd-dolt=$CHECK_CD_OUTCOME"
--github-output "$GITHUB_OUTPUT"
# F3: moved here from pr.yml so the gate depends on nothing but the rbe
# job's decision (not the whole bazel call). Only pr.yml opts in (package-gates: "on");
# bazel-farm.yml and nightly.yml keep the default "off" and this job does
@ -2921,7 +2359,7 @@ jobs:
# bazel-out/k8-fastbuild-ST-.../bin/cmd/bd/bd_for_tests/bd path).
- name: bazel build //cmd/bd:bd_for_tests
if: ${{ steps.detect.outputs.mcp_package == 'true' && needs.rbe.outputs.mode == 'remote' }}
run: bazel build --@rules_go//go/config:race //cmd/bd:bd_for_tests --remote_download_regex='.*/bin/cmd/bd/bd_for_tests/bd$' --norun_validations
run: bazel build --@rules_go//go/config:race //cmd/bd:bd_for_tests --remote_download_regex='.*/bin/cmd/bd/bd_for_tests/bd$'
- name: Package the Bazel-built bd
if: ${{ steps.detect.outputs.mcp_package == 'true' && needs.rbe.outputs.mode == 'remote' }}
@ -3043,7 +2481,7 @@ jobs:
# bazel-out/k8-fastbuild-ST-.../bin/cmd/bd/bd_for_tests/bd path).
- name: bazel build //cmd/bd:bd_for_tests
if: ${{ steps.detect.outputs.npm_package == 'true' && needs.rbe.outputs.mode == 'remote' }}
run: bazel build --@rules_go//go/config:race //cmd/bd:bd_for_tests --remote_download_regex='.*/bin/cmd/bd/bd_for_tests/bd$' --norun_validations
run: bazel build --@rules_go//go/config:race //cmd/bd:bd_for_tests --remote_download_regex='.*/bin/cmd/bd/bd_for_tests/bd$'
- name: Package the Bazel-built bd
if: ${{ steps.detect.outputs.npm_package == 'true' && needs.rbe.outputs.mode == 'remote' }}
@ -3231,7 +2669,7 @@ jobs:
title="rrc-verify: remote repo contents cache differs from a cold fetch"
body="The nightly rrc-verify run found cached repository trees that differ from a cold fetch, or could not check them: $RUN_URL (summary and the rrc-verify report artifact).
A mismatch is a poisoned entry or a repository rule falsely marked reproducible (gascity engdocs/design/bazel-remote-repo-contents-cache.md, R1/R2). Contain the fork-cache readers first: they see no repository variables, so (1) commit fork_rrc_read=off in both probe scripts, beads .github/actions/setup-bazel/cache-rrc-probe.sh and gascity tools/rbe/cache-rrc-probe.sh (beads has no fresh-merge: an open fork PR keeps the old switch until it is pushed again); (2) for immediate server-side containment, an operator runs rbe-cache-gate close on core, which stops all fork-cache, and fails fork-cache lanes already reading; (3) on a mismatch, set RBE_REPO_CONTENTS_CACHE to seed: the trusted readers read the same entries (rbe-cache serves the oss action cache), and seed stops every one of them while rrc-seed and this check keep running; set it to off only to stop seeding too, which also stops rrc-verify; if this run only says it could not check, leave the variable as it is. Then follow gascity/infra nativelink-cas/west/README.md (remote repo contents cache writer, poisoned entries)."
A mismatch is a poisoned entry or a repository rule falsely marked reproducible (gascity engdocs/design/bazel-remote-repo-contents-cache.md, R1/R2). Stop readers first: set the repository variable RBE_REPO_CONTENTS_CACHE to off. Then follow gascity/infra nativelink-cas/west/README.md (remote repo contents cache writer, poisoned entries)."
gh label create rrc-verify -R "$GITHUB_REPOSITORY" --color B60205 \
--description "Remote repo contents cache verification failures" 2>/dev/null || true
n=$(gh issue list -R "$GITHUB_REPOSITORY" --label rrc-verify --state open --json number --jq '.[0].number // empty')

View file

@ -24,8 +24,8 @@ env:
# The legacy Go test tiers this workflow used to run (embedded Dolt storage,
# conformance and cmd shards; proxied-server cmd shards; server-Dolt storage
# and full suite) are pr.yml's Bazel lanes on rbe-west now: `embedded Dolt
# tier`, `proxied-server tier` (`dolt-race`, with the dolt-server lane, in
# mode remote) and `server-Dolt storage tier` (bazel.yml), which pr.yml's `CI Gate / Required` requires to have run remotely and
# tier`, `proxied-server tier` and `server-Dolt storage tier` (bazel.yml),
# which pr.yml's `CI Gate / Required` requires to have run remotely and
# passed on every pull_request and merge group, fork and Dependabot PRs
# included (ga-96smfk.22). What remains is the Nix packaging check, which no
# Bazel target can stand in for: it builds the package Nix users install.

View file

@ -82,14 +82,6 @@ jobs:
- name: Update vendorHash
run: ./scripts/update-nix-vendorhash.sh
- name: Verify the build independently of the script's exit status
# update-nix-vendorhash.sh's own verification build (its step 5) is
# internal to the script; this step re-derives the same signal from
# a source the workflow doesn't have to trust: a plain `nix build`
# that this job step fails on if it fails, regardless of what the
# script itself reported.
run: nix build .#default
- name: Detect whether hash changed
id: changed
run: |

View file

@ -467,28 +467,12 @@ linters:
# tests: false` means forbidigo never analyzes a test file at all, so that
# entry asserts nothing either way and scoping it would be the churn this
# comment just refused to write.
#
# `search` LEFT this list when all three of its routes moved onto
# issueops.Reader.List with issueops.SearchListRequest (cmd/bd/search.go);
# it builds no filter any more.
#
# `gate` LEFT it when `bd gate check` joined `bd gate list` on
# issueops.ListGates over the route's Querier: cmd/bd/gate.go and
# cmd/bd/gate_proxied_server.go name no filter type any more.
# `gate_discover` keeps its own hole below, since findPendingGates still
# asks SearchIssues for its gates.
- path: '^cmd/bd/(close|duplicates|find_duplicates|gc|graph|info|label|orphans|purge|todo|wisp|human)(_proxied_server)?\.go$'
- path: '^cmd/bd/(close|duplicates|find_duplicates|gate|gc|graph|info|label|orphans|purge|search|todo|wisp|human)(_proxied_server)?\.go$'
text: 'do not write a filter here'
linters:
- forbidigo
# Molecule reporting: each selects the members of one molecule.
#
# `mol current` and `mol progress` LEFT this list when their in_progress
# and hooked listings moved onto issueops.Reader.List (cmd/bd/mol_roles.go)
# so a remote backend answers them. The proxied route's in-transaction
# port still searches through the unit of work, and that filter lives in
# mol_port.go beside the port.
- path: '^cmd/bd/mol_(port|ready_gated|stale)\.go$'
- path: '^cmd/bd/mol_(current|port|progress|ready_gated|stale)\.go$'
text: 'do not write a filter here'
linters:
- forbidigo

View file

@ -126,29 +126,9 @@ make install # build and install bd to ~/.local/bin (canonical)
certificate `--config=remote-exec`, agent hosts whose `~/.bazelrc` names the
executor neither. Make yours the default with a `build --config=...` line in
the gitignored `.bazelrc.local`, or pass `BAZEL_FLAGS=...` to make.
- Agents run tests only with `bazel test`, also while iterating on one
behavior:
```bash
bazel test //cmd/bd:bd_test --config=ci --test_filter='^TestName$' --test_output=all
```
A target also passes when the test never ran (a filter that matches
nothing, a skip, a file the configuration does not compile), so count a run
only when its log shows `--- PASS: TestName` and no `--- SKIP` for the test
or a `TestName/...` subtest: Go prints `--- PASS` for a test whose every
subtest skipped. "Check That the Test Ran" in
[engdocs/TESTING.md](engdocs/TESTING.md) names the tests `--config=ci` does
not run (Dolt-backed, `-short`-gated, integration-tagged, `TestEmbedded*`
and embedded-Dolt, files `BUILD.bazel` does not list) and the way into
each. An unchanged target returns its cached result, which is the same
evidence. Finish with `make test`.
- Agents do not run `go test` (`./scripts/test.sh`, `make test-go`): CI does
not enforce it, it skips nogo, gofmt and the guards, and agent hosts may
refuse it. It stays a convenience for humans working offline. The exception
is regenerating golden files (`make corpus-regen`, `make githooks-regen`,
`BD_UPDATE_GOLDEN=1`), which Bazel cannot do: see "Regenerating Golden
Files" in [engdocs/TESTING.md](engdocs/TESTING.md).
- `go test` (`./scripts/test.sh`, `make test-go`) is an inner-loop
convenience only. CI does not enforce it, and it skips nogo, gofmt and the
guards; finish with `make test`.
- **Do NOT** use `go build -o bd ./cmd/bd`, `go install ./cmd/bd`, or raw
`go run ./cmd/bd ...`: they bypass the canonical build path, leave stale
binaries, and raw `go run` misses the `gms_pure_go` tag. Use `make install`,

View file

@ -74,13 +74,6 @@ exports_files(
visibility = ["//scripts:__pkg__"],
)
# //scripts:shell_scripts_test: Oracle A's runner, whose EXIT-trap removal of
# its reference worktree oracle_a_script_test.go checks in a fixture repository.
exports_files(
["tests/oracle-a/run-oracle-a.sh"],
visibility = ["//scripts:__pkg__"],
)
# The nested Go modules' go.mod files, which mark where the root module ends:
# //scripts:go_test_sources_test's scan of every _test.go file skips their
# trees, as `go test ./...` does. (go.mod is in no Go partition below: it is
@ -253,20 +246,6 @@ exports_files(
visibility = ["//internal/httpclient/encode:__pkg__"],
)
# --- begin go_srcs (managed by tools/bazel/go_srcs.py; run `make bazel-sync`) ---
filegroup(
name = "go_srcs",
srcs = glob(
["**/*.go"],
allow_empty = True,
exclude = ["bazel-*/**"],
),
visibility = ["//:__subpackages__"],
)
# --- end go_srcs ---
# --- begin repo_files (managed by tools/bazel/go_srcs.py; run `make bazel-sync`) ---
filegroup(
@ -321,7 +300,6 @@ filegroup(
"//backend:repo_doc_files",
"//backend/conformance:repo_doc_files",
"//backend/http:repo_doc_files",
"//backend/http/corpus:repo_doc_files",
"//beadserrors:repo_doc_files",
"//cmd/bd:repo_doc_files",
"//cmd/bd/doctor:repo_doc_files",
@ -365,7 +343,6 @@ filegroup(
"//internal/httpclient/encode:repo_doc_files",
"//internal/httpclient/wire:repo_doc_files",
"//internal/idgen:repo_doc_files",
"//internal/initprocs:repo_doc_files",
"//internal/jira:repo_doc_files",
"//internal/linear:repo_doc_files",
"//internal/lockfile:repo_doc_files",
@ -405,7 +382,6 @@ filegroup(
"//internal/storage/externaldeps:repo_doc_files",
"//internal/storage/fs:repo_doc_files",
"//internal/storage/git:repo_doc_files",
"//internal/storage/historyoffequiv:repo_doc_files",
"//internal/storage/issueops:repo_doc_files",
"//internal/storage/journalscan:repo_doc_files",
"//internal/storage/kvkeys:repo_doc_files",
@ -436,7 +412,6 @@ filegroup(
"//internal/utils:repo_doc_files",
"//internal/validation:repo_doc_files",
"//internal/versioncheck:repo_doc_files",
"//internal/versionedhistory:repo_doc_files",
"//internal/workapi:repo_doc_files",
"//internal/workapi/storecounter:repo_doc_files",
"//internal/workapi/storequerier:repo_doc_files",
@ -558,7 +533,6 @@ filegroup(
"//backend:repo_go_srcs",
"//backend/conformance:repo_go_srcs",
"//backend/http:repo_go_srcs",
"//backend/http/corpus:repo_go_srcs",
"//beadserrors:repo_go_srcs",
"//cmd/bd:repo_go_srcs",
"//cmd/bd/doctor:repo_go_srcs",
@ -602,7 +576,6 @@ filegroup(
"//internal/httpclient/encode:repo_go_srcs",
"//internal/httpclient/wire:repo_go_srcs",
"//internal/idgen:repo_go_srcs",
"//internal/initprocs:repo_go_srcs",
"//internal/jira:repo_go_srcs",
"//internal/linear:repo_go_srcs",
"//internal/lockfile:repo_go_srcs",
@ -642,7 +615,6 @@ filegroup(
"//internal/storage/externaldeps:repo_go_srcs",
"//internal/storage/fs:repo_go_srcs",
"//internal/storage/git:repo_go_srcs",
"//internal/storage/historyoffequiv:repo_go_srcs",
"//internal/storage/issueops:repo_go_srcs",
"//internal/storage/journalscan:repo_go_srcs",
"//internal/storage/kvkeys:repo_go_srcs",
@ -673,7 +645,6 @@ filegroup(
"//internal/utils:repo_go_srcs",
"//internal/validation:repo_go_srcs",
"//internal/versioncheck:repo_go_srcs",
"//internal/versionedhistory:repo_go_srcs",
"//internal/workapi:repo_go_srcs",
"//internal/workapi/storecounter:repo_go_srcs",
"//internal/workapi/storequerier:repo_go_srcs",
@ -780,7 +751,6 @@ filegroup(
"//backend:repo_go_test_srcs",
"//backend/conformance:repo_go_test_srcs",
"//backend/http:repo_go_test_srcs",
"//backend/http/corpus:repo_go_test_srcs",
"//beadserrors:repo_go_test_srcs",
"//cmd/bd:repo_go_test_srcs",
"//cmd/bd/doctor:repo_go_test_srcs",
@ -824,7 +794,6 @@ filegroup(
"//internal/httpclient/encode:repo_go_test_srcs",
"//internal/httpclient/wire:repo_go_test_srcs",
"//internal/idgen:repo_go_test_srcs",
"//internal/initprocs:repo_go_test_srcs",
"//internal/jira:repo_go_test_srcs",
"//internal/linear:repo_go_test_srcs",
"//internal/lockfile:repo_go_test_srcs",
@ -864,7 +833,6 @@ filegroup(
"//internal/storage/externaldeps:repo_go_test_srcs",
"//internal/storage/fs:repo_go_test_srcs",
"//internal/storage/git:repo_go_test_srcs",
"//internal/storage/historyoffequiv:repo_go_test_srcs",
"//internal/storage/issueops:repo_go_test_srcs",
"//internal/storage/journalscan:repo_go_test_srcs",
"//internal/storage/kvkeys:repo_go_test_srcs",
@ -895,7 +863,6 @@ filegroup(
"//internal/utils:repo_go_test_srcs",
"//internal/validation:repo_go_test_srcs",
"//internal/versioncheck:repo_go_test_srcs",
"//internal/versionedhistory:repo_go_test_srcs",
"//internal/workapi:repo_go_test_srcs",
"//internal/workapi/storecounter:repo_go_test_srcs",
"//internal/workapi/storequerier:repo_go_test_srcs",
@ -1011,7 +978,6 @@ filegroup(
"//backend:repo_other_files",
"//backend/conformance:repo_other_files",
"//backend/http:repo_other_files",
"//backend/http/corpus:repo_other_files",
"//beadserrors:repo_other_files",
"//cmd/bd:repo_other_files",
"//cmd/bd/doctor:repo_other_files",
@ -1055,7 +1021,6 @@ filegroup(
"//internal/httpclient/encode:repo_other_files",
"//internal/httpclient/wire:repo_other_files",
"//internal/idgen:repo_other_files",
"//internal/initprocs:repo_other_files",
"//internal/jira:repo_other_files",
"//internal/linear:repo_other_files",
"//internal/lockfile:repo_other_files",
@ -1095,7 +1060,6 @@ filegroup(
"//internal/storage/externaldeps:repo_other_files",
"//internal/storage/fs:repo_other_files",
"//internal/storage/git:repo_other_files",
"//internal/storage/historyoffequiv:repo_other_files",
"//internal/storage/issueops:repo_other_files",
"//internal/storage/journalscan:repo_other_files",
"//internal/storage/kvkeys:repo_other_files",
@ -1126,7 +1090,6 @@ filegroup(
"//internal/utils:repo_other_files",
"//internal/validation:repo_other_files",
"//internal/versioncheck:repo_other_files",
"//internal/versionedhistory:repo_other_files",
"//internal/workapi:repo_other_files",
"//internal/workapi/storecounter:repo_other_files",
"//internal/workapi/storequerier:repo_other_files",

File diff suppressed because it is too large Load diff

View file

@ -165,13 +165,6 @@ llvm_host_dist(
llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm")
llvm.toolchain(
name = "llvm_toolchain",
# Pair Darwin's host SDK with its native linker. LLVM 22.1.8's ld64.lld
# cannot parse the arm64e.x1 TAPI targets in the macOS 27 SDK. Keep the
# pinned Clang compiler; Linux keeps the bundled LLD and pinned sysroot.
linker = {
"darwin-aarch64": "auto",
"darwin-x86_64": "auto",
},
llvm_version = LLVM_VERSION,
# The sysroot's libstdc++, linked dynamically as host-gcc builds did.
stdlib = {"linux-x86_64": "dynamic-stdc++"},

View file

@ -46,7 +46,7 @@ endif
.PHONY: all build doctor-build test test-icu-path test-full-cgo test-regression test-upgrade test-cross-version test-migration corpus-regen githooks-regen bench bench-quick clean clean-test-tmp install install-force help check-up-to-date fmt fmt-check check-testing-short
.PHONY: lint lint-changed vet
.PHONY: check check-go test-go check-docs-go
.PHONY: ci-pr-core ci-pr-lint ci-complexity ci-complexity-diff ci-complexity-check ci-package-mcp ci-package-npm nogo-ownership
.PHONY: ci-pr-core ci-pr-lint ci-complexity ci-complexity-diff ci-complexity-check ci-package-mcp ci-package-npm
.PHONY: api-gen api-check
.PHONY: bazel-sync bazel-sync-check
@ -237,16 +237,6 @@ ci-pr-core:
ci-pr-lint:
@./scripts/ci/pr-lint.sh
# nogo-ownership is a dynamic, advisory cross-check (not part of the required
# //scripts static suite, which cannot shell out to Bazel): it asks real
# `bazel aquery` whether the nogo owner lane for each configuration group
# (today: race, bazel-test/--config=ci) really does validate every file a
# non-owner lane (embedded, doltserver, doltserver-proxied, dolt-race, which
# pass --norun_validations) compiles. See tools/bazel/nogo_ownership.py and
# scripts/nogo_lint_policy_test.go's nogoConfigurations table.
nogo-ownership:
@python3 tools/bazel/nogo_ownership.py
# The CI lint gate: native, plus //tools/bazel:release_cross for windows/amd64
# and darwin/arm64 (BD_LINT_TARGETS selects; scripts/pr-lint).
lint: ci-pr-lint

View file

@ -223,19 +223,6 @@ reference as a leaf, and while it is unsatisfied the issue stays out of
`--force`. A server that advertises enforcing that policy itself is trusted
to do so instead.
Three CLI-level differences are worth knowing up front:
- IDs resolve exactly: an abbreviated id is not expanded (the wire has no
substring search), and a missing id is reported as not found after one
lookup.
- `bd update -s closed` does not record `closed_by_session` (from `--session`
or `CLAUDE_SESSION_ID`), because the wire's update cannot carry it; the
close itself happens as usual. `bd close` does record the session. `bd
reopen`'s history entry carries the server's own label.
- Contributor auto-routing (`routing.*` settings) is read from local
`config.yaml` / environment only, never from the server's settings: its
targets are local paths.
`bd connect` writes two things on success: `.beads/metadata.json` gets
`"backend": "http"`, and a per-user, never-git-tracked sidecar
(`.beads/http_target.json`) records the server URL and pinned project id. It
@ -251,70 +238,6 @@ credential would cross the network unencrypted) — pass `--allow-plaintext` to
override, or use `https://`. Switching a workspace that already selects a
different backend needs `--force`.
Each read (a GET, or the POST batch get) gives its first attempt 15s, from
when the request is sent, to get the server's response headers
(`BEADS_HTTP_RESPONSE_HEADER_TIMEOUT`: a duration such as `30s`, a number of
seconds, or `off`). A read whose headers do not arrive in time, or whose
connection is reset, is retried once on another connection, and each retry
is logged to stderr with its count. The retry has no header timer, but it
runs on what is left of the 60s bound on the whole request, counted from
when the first attempt was sent: a slow but healthy read still finishes if
the retry's headers and body together fit in that remainder (about 45s after
a header timeout), and one that needs longer now fails at 60s. The header
timer never cuts off a body that is still streaming; the 60s bound still
does. The events:watch stream's connect gets neither the header timer nor
the retry. On Windows a reset connection is retried only when it surfaces as
an early EOF, because the check matches the Unix reset error (`ECONNRESET`),
which a Windows reset (`WSAECONNRESET`) is not. A write gets no
header timer (the server answers a write only after it commits, so a large
one can be slow and healthy) and is never retried; if the 60s bound expires
after it was sent but before its headers, it fails with an error naming the
server's host, because it may or may not have been applied. A batch apply of
more than 100 items (a large `bd create --graph` plan, say) gets 6 minutes
instead of 60s, because `bd serve` gives such a request its
`--large-apply-ceiling` (5 minutes by default) and finishes it even after the
client has given up. A server whose ceiling is raised past about 5m15s can
still outlast the client. A dial or TLS timeout stays a plain connection
error, since the server never saw the request, and a connect that fails says
so: it names the address that refused the connection (nothing listening) or
never answered (a filtered port or a down host, after the dialer's 30s), or
the host name that did not resolve. `off` turns off only the
header timer: a reset read is still retried, and a write's timeout is still
reported as above.
Whether the server applies bd's external-dependency policy itself (the
`policy.external_dependencies` capability) is remembered for 5 minutes per
server URL and pinned project, in `beads/http-policy/` under the user cache
directory, so `bd ready` does not fetch the server's context before every
listing just to learn it. `BEADS_HTTP_POLICY_CACHE_TTL` sets that window (a
duration such as `1m`, a number of seconds, or `off`); a server restarted
with a different composition is seen once it passes. Claims and closes never
use the cached answer: they ask the server, since a stale one could skip the
client-side refusal of externally blocked work. A workspace connected without
a project pin is not cached.
`bd search`, `bd show --current` and `bd recompute-blocked` work over HTTP
too, each in its own way. `bd search` asks the server's listing with its text (`q`, behind the `issues.list.search` capability) and
refuses before dialing against a server that does not advertise it. `bd list
--no-assignee`, `--title` and `--id` likewise ride the listing's
`no_assignee`, `title` and repeatable `id`, each behind its own capability
(`issues.list.noAssignee`, `issues.list.title`, `issues.list.ids`), and the
rest of `bd list`'s filters (`--updated-*`, `--closed-*`, `--defer-*`,
`--due-*`, `--priority*`, the text and external-ref matches, `--spec`,
`--label-pattern`/`--label-regex`, `--exclude-type`, `--no-parent`,
`--no-labels`, `--empty-description`, `--pinned`/`--no-pinned`,
`--deferred`, `--overdue`, `--mol-type`, `--wisp-type`) ride it behind one
capability, `issues.list.filters`. Time bounds are resolved on the client as
they are locally; `--overdue` compares against the server's clock. The
default `--parent` tree view does not carry those filters yet and refuses one
rather than drop it; `--flat` or `--json` applies them to the parent's direct
children (not its whole subtree).
`bd show --current` finds the actor's in-progress or hooked issue through the
server's boolean query. `bd recompute-blocked` is a no-op that exits 0: the
server maintains `is_blocked` on every write, and repairing a stale flag is
done in the server's own workspace (`--json` reports
`{"rows_corrected": 0, "maintained_by": "server"}`).
An embedding program that links beads as a library rather than running
`cmd/bd` registers this backend itself through the public
[`backend/http`](backend/http) package (`bdhttp.Register`), and can open a

View file

@ -145,8 +145,7 @@ Before starting a release:
- [ ] All tests passing (`make test`, the Bazel test lane)
- [ ] npm package tests passing (`cd npm-package && npm run test:all`)
- [ ] **Upgrade smoke tests pass** (`make test-upgrade`) — see [Release Stability Gate](engdocs/RELEASE-STABILITY-GATE.md)
- [ ] **Regression tests pass**
(`bazel test //tests/regression:regression_test --config=doltserver-cmd`)
- [ ] **Regression tests pass** (`make test-regression`)
- [ ] **Every release target cross-compiles** — see
[Cross-compile before tagging](#cross-compile-before-tagging). PR CI
builds them only with cgo off, and a target that fails at tag time

View file

@ -19,7 +19,7 @@ Row numbers are the historical table's. Line numbers in this table are against t
| # | Path | Version seam at this head | Disposition | Mechanism |
|---|---|---|---|---|
| 13 | any of rows 1-8 whose target row is a wisp **or a promoted no-history bead** | no | NO-OP (a flagged issues-table create is stamped, not versioned) | The table that holds the row decides its plane, not its flags. A row in the wisps table mints and stamps nothing, whatever its flags say (FR-8). An update-shaped call on a flagged wisp returns on `IsWisp`, which is `Ephemeral \|\| NoHistory` (helpers.go:36-41). Every other wisps-table row is excluded by the seam's read of `participation_generation` from the issues table, which finds no row and returns: a flagged wisp's create-shaped call, and an unflagged row (bd mol squash's in-place flag clear, import's `wisp_plane` marker), which passes `IsWisp`. An issues-table row carrying `NoHistory` (a promoted no-history bead, bd-r9uce) is never versioned while it says so, because no-history means no history: an update-shaped call returns on `IsWisp`. A create-shaped call on such a row, with the flag on, still stamps `participation_generation` and mints nothing, so the row is not legacy once `bd update --persistent` repairs the flag in place. |
| 13 | any of rows 1-8 whose target row is a wisp **or a promoted no-history bead** | no | NO-OP | `RecordVersionInTx` returns on `IsWisp`, which is `Ephemeral \|\| NoHistory` (helpers.go:36-41): wisps per FR-8, and a promoted no-history bead — a durable issues-plane row with `NoHistory=true` — because no-history means no history. Wording only; the code did not change. |
| 14 | dependencies.go:`addDependencyInTx` via `AddDependencyInTx` from the store verbs, `ApplyParentPatch`, `applyBatchRun.applyDepAdd` | yes | VERSIONED | mint moved into `addDependencyInTx` (`mintDependencyVersion`, dependencies.go:393), gated on the row insert rather than on `eventWritten`; the publicops editor's own mint call was removed so no leg double-mints |
| 15 | domain/db/dependency.go:`dependencySQLRepositoryImpl.Insert` (uow `AddDependencies`, create-time edges) | yes | VERSIONED | seam at dependency.go:228 and :240 after the insert |
| 16 | dependencies.go:`removeDependencyInTx` via `RemoveDependencyInTx` and domain/db/dependency.go:`Delete` | yes | VERSIONED | gated on the row delete; dependency.go:409 on the uow leg |

View file

@ -11,11 +11,9 @@ go_library(
"audit_molecule_wisp_batch_iter.go",
"audit_search-counts-stats.go",
"batch_apply_contract.go",
"batch_apply_gate_contract.go",
"batch_closer_contract.go",
"batch_creator_contract.go",
"batch_getter_contract.go",
"blocked_lister_contract.go",
"blocked_state.go",
"blocking_annotator_contract.go",
"bootstrapper_contract.go",
@ -29,11 +27,9 @@ go_library(
"deleter_contract.go",
"dependency_editor_contract.go",
"dualwrite_history_contract.go",
"dualwrite_participation_generation_contract.go",
"edge_reader_contract.go",
"expected_revision_contract.go",
"graph_counter_contract.go",
"heartbeater_contract.go",
"history_matching.go",
"importer_contract.go",
"issue_operations_contract.go",
@ -42,12 +38,9 @@ go_library(
"lease_reclaimer_contract.go",
"lifecycle_close_reopen_contract.go",
"lifecycle_create_contract.go",
"lifecycle_create_gate_contract.go",
"lifecycle_update_contract.go",
"lifecycle_update_gate_contract.go",
"memories_contract.go",
"metadata_cas_contract.go",
"molecule_contract.go",
"portable.go",
"querier_contract.go",
"reader_contract.go",
@ -65,7 +58,6 @@ go_library(
"transaction_parity.go",
"tree_walker_contract.go",
"version_reconciler_contract.go",
"versioned_read_contract.go",
"workspaceconfig_contract.go",
],
importpath = "github.com/steveyegge/beads/backend/conformance",

View file

@ -171,12 +171,6 @@ func RunBatchApplyAppliesEveryItemInDeclarationOrder(t *testing.T, ctx context.C
if got := batchApplyColumn(t, ctx, fixture, "status", blocked); got == string(types.StatusClosed) {
t.Errorf("%s was closed by a request that only asked to close %s", blocked, blocker)
}
// Neither create item names a creator, so each defaults to the request's actor.
for _, id := range []string{blocked, blocker} {
if got := batchApplyColumn(t, ctx, fixture, "created_by", id); got != "apply-writer" {
t.Errorf("%s created_by = %q, want the request's actor %q", id, got, "apply-writer")
}
}
}
// RunBatchApplyBindsEachNamedKeyToItsMintedID pins ApplyBatchResult.Keys: it is

View file

@ -1,145 +0,0 @@
package conformance
import (
"context"
"encoding/json"
"errors"
"slices"
"testing"
"time"
"github.com/steveyegge/beads/internal/types"
publicops "github.com/steveyegge/beads/issueops"
)
// The BatchApplier half of the gate-member clauses; see
// lifecycle_create_gate_contract.go.
// RunBatchApplyCarriesTheGateMembers pins the gate members through
// BatchApplier: a create item stores all four, an update item replaces the
// waiter list of an existing row whole, a clear through an update item stores
// the empty list `[]`, and a create or update item past a bound refuses the
// WHOLE request as ErrValidation naming its member (on its *ItemError for the
// update item), so the earlier item rolls back with it.
func RunBatchApplyCarriesTheGateMembers(t *testing.T, ctx context.Context, fixture BatchApplyFixture) {
t.Helper()
gate := fixture.IssuePrefix + "-bag-gate"
existing := fixture.IssuePrefix + "-bag-existing"
batchApplySeedIssue(t, ctx, fixture, existing, types.StatusOpen)
issue := batchApplyIssue(gate, "a gate made by a plan")
issue.IssueType = types.TypeGate
issue.AwaitType = "timer"
issue.AwaitID = "await-plan"
issue.Timeout = 2 * time.Hour
issue.Waiters = []string{"a", "a", "b"}
batchApplyMust(t, ctx, fixture, publicops.ApplyBatchRequest{
Actor: "apply-writer",
ForceIDPrefix: true,
Items: []publicops.ApplyItem{
batchApplyCreate("gate", issue),
batchApplyUpdate(publicops.Ref{ID: existing}, publicops.IssuePatch{
AwaitID: publicops.Field[string]{Set: true, Value: "bead:" + gate},
Waiters: publicops.Field[[]string]{Set: true, Value: []string{"x", "y"}},
}),
},
})
assertBatchApplyGateColumns(t, ctx, fixture, gate, "timer", "await-plan", 2*time.Hour, []string{"a", "a", "b"})
assertBatchApplyGateColumns(t, ctx, fixture, existing, "", "bead:"+gate, 0, []string{"x", "y"})
// A clear through an update item stores the empty JSON list, not NULL and
// not the JSON null: the column is read raw here because every reader
// above treats the three alike.
batchApplyMust(t, ctx, fixture, publicops.ApplyBatchRequest{
Actor: "apply-writer",
Items: []publicops.ApplyItem{
batchApplyUpdate(publicops.Ref{ID: existing}, publicops.IssuePatch{
AwaitID: publicops.Field[string]{Set: true},
Waiters: publicops.Field[[]string]{Set: true},
}),
},
})
assertBatchApplyGateColumns(t, ctx, fixture, existing, "", "", 0, nil)
var clearedWaiters string
if err := fixture.QueryScalar(ctx, "SELECT COALESCE(waiters, '<NULL>') FROM issues WHERE id = ?", []any{existing}, &clearedWaiters); err != nil {
t.Fatalf("read the waiters column of %s: %v", existing, err)
}
if clearedWaiters != "[]" {
t.Errorf("%s waiters column after a clear = %q, want the stored empty list %q", existing, clearedWaiters, "[]")
}
first := fixture.IssuePrefix + "-bag-rolledback"
refused := batchApplyIssue(fixture.IssuePrefix+"-bag-refused", "past the bound")
refused.AwaitType = gateFieldAtBoundAwaitType + "x"
_, err := fixture.BatchApplier.ApplyBatch(ctx, publicops.ApplyBatchRequest{
Actor: "apply-writer",
ForceIDPrefix: true,
Items: []publicops.ApplyItem{
batchApplyCreate("first", batchApplyIssue(first, "rolls back with the refusal")),
batchApplyCreate("refused", refused),
},
})
assertGateFieldError(t, err, "a create item with await_type past its bound", publicops.GateFieldAwaitType)
assertBatchApplyRowCount(t, ctx, fixture, "issues", first, 0)
// An update item past a bound refuses the same way, named on its own
// item: the earlier create rolls back, and the target keeps its columns.
firstOfUpdate := fixture.IssuePrefix + "-bag-rolledback-upd"
_, err = fixture.BatchApplier.ApplyBatch(ctx, publicops.ApplyBatchRequest{
Actor: "apply-writer",
ForceIDPrefix: true,
Items: []publicops.ApplyItem{
batchApplyCreate("first", batchApplyIssue(firstOfUpdate, "rolls back with the refusal")),
batchApplyUpdate(publicops.Ref{ID: gate}, publicops.IssuePatch{
Title: publicops.Field[string]{Set: true, Value: "must not land"},
AwaitID: publicops.Field[string]{Set: true, Value: gateFieldAtBoundAwaitID + "x"},
}),
},
})
assertGateFieldError(t, err, "an update item with await_id past its bound", publicops.GateFieldAwaitID)
var itemErr *publicops.ItemError
if !errors.As(err, &itemErr) {
t.Fatalf("an update item with await_id past its bound: error = %v, want an *ItemError naming the item", err)
}
if itemErr.Index != 1 || itemErr.Kind != publicops.ItemUpdate {
t.Errorf("ItemError = %#v, want Index 1 and Kind %q", itemErr, publicops.ItemUpdate)
}
assertBatchApplyRowCount(t, ctx, fixture, "issues", firstOfUpdate, 0)
assertBatchApplyGateColumns(t, ctx, fixture, gate, "timer", "await-plan", 2*time.Hour, []string{"a", "a", "b"})
if got := batchApplyColumn(t, ctx, fixture, "title", gate); got != "a gate made by a plan" {
t.Errorf("%s title = %q, want the created title: a refused item writes nothing", gate, got)
}
}
// assertBatchApplyGateColumns reads the four gate columns of one durable row
// raw, so neither side of the comparison comes from the role.
func assertBatchApplyGateColumns(t *testing.T, ctx context.Context, fixture BatchApplyFixture, id, awaitType, awaitID string, timeout time.Duration, waiters []string) {
t.Helper()
var gotType, gotID, gotWaiters string
var gotTimeout int64
if err := fixture.QueryScalar(ctx,
"SELECT COALESCE(await_type, ''), COALESCE(await_id, ''), COALESCE(timeout_ns, 0), COALESCE(waiters, '') FROM issues WHERE id = ?",
[]any{id}, &gotType, &gotID, &gotTimeout, &gotWaiters); err != nil {
t.Fatalf("read the gate columns of %s: %v", id, err)
}
if gotType != awaitType || gotID != awaitID || time.Duration(gotTimeout) != timeout {
t.Errorf("%s gate columns = (%q, %q, %s), want (%q, %q, %s)", id, gotType, gotID, time.Duration(gotTimeout), awaitType, awaitID, timeout)
}
if stored := parseGateWaiters(gotWaiters); !slices.Equal(stored, waiters) {
t.Errorf("%s waiters column = %q (%q), want %q", id, gotWaiters, stored, waiters)
}
}
// parseGateWaiters reads the waiters TEXT column's JSON array, treating the
// empty string, `null` and `[]` as the one empty list they all mean.
func parseGateWaiters(raw string) []string {
if raw == "" || raw == "null" || raw == "[]" {
return nil
}
var out []string
if err := json.Unmarshal([]byte(raw), &out); err != nil {
return []string{"<unparseable: " + err.Error() + ">"}
}
return out
}

View file

@ -97,14 +97,6 @@ func RunBatchCreatorCreatesEveryItemAsOneAct(t *testing.T, ctx context.Context,
}
seen[issue.ID] = true
assertBatchCreatorRowCount(t, ctx, fixture, "issues", issue.ID, 1)
// No item names a creator, so each defaults to the batch's actor.
var createdBy string
if err := fixture.QueryScalar(ctx, "SELECT COALESCE(created_by, '') FROM issues WHERE id = ?", []any{issue.ID}, &createdBy); err != nil {
t.Fatalf("read created_by for %s: %v", issue.ID, err)
}
if createdBy != request.Actor || issue.CreatedBy != request.Actor {
t.Errorf("item %d created_by = %q (result %q), want the request's actor %q", i, createdBy, issue.CreatedBy, request.Actor)
}
}
if labels := result.Issues[0].Labels; len(labels) != 1 || labels[0] != "alpha" {
t.Errorf("result issue 0 labels = %v, want [alpha]: the snapshot is promised hydrated with labels", labels)

View file

@ -1,426 +0,0 @@
package conformance
import (
"context"
"fmt"
"reflect"
"slices"
"testing"
"time"
"github.com/steveyegge/beads/internal/types"
publicops "github.com/steveyegge/beads/issueops"
)
// This file holds the semantic contract every implementation of
// publicops.BlockedLister must satisfy: what issueops/blockedlister.go
// promises, asserted on every leg (dolt, embedded dolt, unit of work, and the
// served HTTP client) so `bd blocked` answers one listing whichever route it
// takes.
//
// EVERY CASE IS SCOPED BY A LABEL: the blocked set is a property of the whole
// database, not of an id prefix, so a row seeded by one case is inside the
// next one's answer unless each asks through Labels.
// BlockedListerFixture supplies adapter-specific storage access for the
// blocked-listing assertions.
type BlockedListerFixture struct {
// IssuePrefix namespaces the ids each case seeds, so several cases can
// share one database.
IssuePrefix string
// BlockedLister is the surface under test.
BlockedLister publicops.BlockedLister
// CreateIssue seeds a durable issue in the issues plane.
CreateIssue func(context.Context, *types.Issue, string) error
// CreateWisp seeds an ephemeral issue in the wisps plane.
CreateWisp func(context.Context, *types.Issue, string) error
// AddDependency seeds ONE edge, recomputing the stored blocked flag the
// way every dependency write does.
AddDependency func(context.Context, *types.Dependency, string) error
// MarkBlocked sets the stored is_blocked flag on one durable issue
// directly, without the edge that would justify it: the stale flag `bd
// recompute-blocked` exists to repair. It must fail unless exactly one row
// changed. A nil hook means this leg cannot write the column, and the case
// that needs it skips with that reason.
MarkBlocked func(context.Context, string) error
}
// RunBlockedLister runs every blocked-listing case as a subtest of t.
func RunBlockedLister(t *testing.T, ctx context.Context, fixture BlockedListerFixture) {
t.Helper()
t.Run("NamesADirectBlocker", func(t *testing.T) { runBlockedNamesADirectBlocker(t, ctx, fixture) })
t.Run("AttributesAChildToItsBlockedParent", func(t *testing.T) { runBlockedAttributesAChildToItsParent(t, ctx, fixture) })
t.Run("ClosedBlockerDoesNotBlock", func(t *testing.T) { runBlockedClosedBlockerDoesNotBlock(t, ctx, fixture) })
t.Run("IncludesTheWispPlane", func(t *testing.T) { runBlockedIncludesTheWispPlane(t, ctx, fixture) })
t.Run("ExcludesThePinnedStatus", func(t *testing.T) { runBlockedExcludesThePinnedStatus(t, ctx, fixture) })
t.Run("ParentFilter", func(t *testing.T) { runBlockedParentFilter(t, ctx, fixture) })
t.Run("LabelFilters", func(t *testing.T) { runBlockedLabelFilters(t, ctx, fixture) })
t.Run("Order", func(t *testing.T) { runBlockedOrder(t, ctx, fixture) })
t.Run("NamesWaitsForAndConditionalBlockers", func(t *testing.T) { runBlockedNamesWaitsForAndConditionalBlockers(t, ctx, fixture) })
t.Run("OmitsAStaleFlagWithNoNameableBlocker", func(t *testing.T) { runBlockedOmitsAStaleFlag(t, ctx, fixture) })
t.Run("HasNoTypeExclusions", func(t *testing.T) { runBlockedHasNoTypeExclusions(t, ctx, fixture) })
t.Run("EmptyIsAnEmptySlice", func(t *testing.T) { runBlockedEmptyIsAnEmptySlice(t, ctx, fixture) })
t.Run("DoesNotMutateTheCallerRequest", func(t *testing.T) { runBlockedDoesNotMutateTheRequest(t, ctx, fixture) })
}
// runBlockedNamesADirectBlocker: an issue with an open `blocks` target is
// listed with that target as its one blocker; the target itself is not.
func runBlockedNamesADirectBlocker(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-direct"
blocked, blocker := blListerID(f, "direct-src"), blListerID(f, "direct-dst")
blListerSeedIssue(t, ctx, f, blListerIssue(blocked, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label))
blListerSeedEdge(t, ctx, f, blocked, blocker, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{blocked: {blocker}})
}
// runBlockedAttributesAChildToItsParent: a child of a blocked parent, with no
// blocker of its own, is listed with its parent named as the blocker.
func runBlockedAttributesAChildToItsParent(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-child"
parent, child, blocker := blListerID(f, "child-parent"), blListerID(f, "child-child"), blListerID(f, "child-blocker")
blListerSeedIssue(t, ctx, f, blListerIssue(parent, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(child, 1, label))
blListerSeedEdge(t, ctx, f, child, parent, types.DepParentChild)
blListerSeedEdge(t, ctx, f, parent, blocker, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{parent: {blocker}, child: {parent}})
}
// runBlockedClosedBlockerDoesNotBlock: a `blocks` edge onto a closed target
// names no blocker, so the source is not listed.
func runBlockedClosedBlockerDoesNotBlock(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-closed"
src, dst := blListerID(f, "closed-src"), blListerID(f, "closed-dst")
blListerSeedIssue(t, ctx, f, blListerIssue(src, 1, label))
closed := blListerIssue(dst, 1, label)
closed.Status = types.StatusClosed
blListerSeedIssue(t, ctx, f, closed)
blListerSeedEdge(t, ctx, f, src, dst, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{})
}
// runBlockedIncludesTheWispPlane: a blocked wisp is listed beside the issues.
func runBlockedIncludesTheWispPlane(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-wisp"
wisp, blocker := blListerID(f, "wisp-src"), blListerID(f, "wisp-dst")
w := blListerIssue(wisp, 1, label)
w.Ephemeral = true
if err := f.CreateWisp(ctx, w, "seed"); err != nil {
t.Fatalf("seed wisp %s: %v", wisp, err)
}
b := blListerIssue(blocker, 1, label)
b.Ephemeral = true
if err := f.CreateWisp(ctx, b, "seed"); err != nil {
t.Fatalf("seed wisp %s: %v", blocker, err)
}
blListerSeedEdge(t, ctx, f, wisp, blocker, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{wisp: {blocker}})
}
// runBlockedExcludesThePinnedStatus: a row whose status is pinned is never
// listed, whatever blocks it.
func runBlockedExcludesThePinnedStatus(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-pinned"
pinned, open, blocker := blListerID(f, "pinned-src"), blListerID(f, "pinned-open"), blListerID(f, "pinned-dst")
p := blListerIssue(pinned, 1, label)
p.Status = types.StatusPinned
blListerSeedIssue(t, ctx, f, p)
blListerSeedIssue(t, ctx, f, blListerIssue(open, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
blListerSeedEdge(t, ctx, f, pinned, blocker, types.DepBlocks)
blListerSeedEdge(t, ctx, f, open, blocker, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{open: {blocker}})
}
// runBlockedParentFilter: ParentID narrows to the parent's direct children.
func runBlockedParentFilter(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-parent"
parent, kid, stranger, blocker := blListerID(f, "pf-parent"), blListerID(f, "pf-kid"), blListerID(f, "pf-stranger"), blListerID(f, "pf-blocker")
blListerSeedIssue(t, ctx, f, blListerIssue(parent, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(kid, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(stranger, 1, label))
blListerSeedEdge(t, ctx, f, kid, parent, types.DepParentChild)
blListerSeedEdge(t, ctx, f, kid, blocker, types.DepBlocks)
blListerSeedEdge(t, ctx, f, stranger, blocker, types.DepBlocks)
all := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, all, map[string][]string{kid: {blocker}, stranger: {blocker}})
narrowed := blListerList(t, ctx, f, publicops.BlockedRequest{ParentID: parent, Labels: []string{label}})
blListerAssertRows(t, narrowed, map[string][]string{kid: {blocker}})
}
// runBlockedLabelFilters: Labels is AND, LabelsAny is OR, ExcludeLabels
// removes, and every value is trimmed with blanks dropped.
func runBlockedLabelFilters(t *testing.T, ctx context.Context, f BlockedListerFixture) {
base := f.IssuePrefix + "-bl-lab"
red, blue := base+"-red", base+"-blue"
both, onlyRed, onlyBlue, blocker := blListerID(f, "lab-both"), blListerID(f, "lab-red"), blListerID(f, "lab-blue"), blListerID(f, "lab-blocker")
blListerSeedIssue(t, ctx, f, blListerIssue(both, 1, base, red, blue))
blListerSeedIssue(t, ctx, f, blListerIssue(onlyRed, 1, base, red))
blListerSeedIssue(t, ctx, f, blListerIssue(onlyBlue, 1, base, blue))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, base+"-other"))
for _, id := range []string{both, onlyRed, onlyBlue} {
blListerSeedEdge(t, ctx, f, id, blocker, types.DepBlocks)
}
want := func(ids ...string) map[string][]string {
m := map[string][]string{}
for _, id := range ids {
m[id] = []string{blocker}
}
return m
}
blListerAssertRows(t, blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{" " + red + " ", "", blue}}), want(both))
blListerAssertRows(t, blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{base}, LabelsAny: []string{red, blue}}), want(both, onlyRed, onlyBlue))
blListerAssertRows(t, blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{base}, ExcludeLabels: []string{" " + blue}}), want(onlyRed))
}
// runBlockedOrder: priority ascending, then created_at descending, then id.
//
// The created_at values are seeded explicitly, so every key decides at least
// one pair: two rows share a priority and differ in created_at (newest first),
// and five share both priority and created_at (the id breaks the tie). The
// expected order is written out rather than recomputed from the answer.
func runBlockedOrder(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-order"
blocker := blListerID(f, "order-blocker")
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
older := time.Date(2026, 1, 1, 10, 0, 0, 0, time.UTC)
newer := older.Add(time.Hour)
// Two of the five tied rows are wisps. The store body assembles rows
// issues-plane first, each plane in id order, so the ids alone would put
// the tied run in the wrong order (b, d, e, then a, c); only the id
// tiebreak puts it right.
rows := []struct {
name string
priority int
created time.Time
wisp bool
}{
{"order-p3", 3, newer, false},
{"order-p0-older", 0, older, false},
{"order-p0-newer-e", 0, newer, false},
{"order-p0-newer-c", 0, newer, true},
{"order-p0-newer-a", 0, newer, true},
{"order-p0-newer-d", 0, newer, false},
{"order-p0-newer-b", 0, newer, false},
{"order-p1", 1, older, false},
}
for _, row := range rows {
issue := blListerIssue(blListerID(f, row.name), row.priority, label)
issue.CreatedAt = row.created
issue.UpdatedAt = row.created
if row.wisp {
issue.Ephemeral = true
if err := f.CreateWisp(ctx, issue, "seed"); err != nil {
t.Fatalf("seed wisp %s: %v", issue.ID, err)
}
} else {
blListerSeedIssue(t, ctx, f, issue)
}
blListerSeedEdge(t, ctx, f, issue.ID, blocker, types.DepBlocks)
}
want := []string{
blListerID(f, "order-p0-newer-a"),
blListerID(f, "order-p0-newer-b"),
blListerID(f, "order-p0-newer-c"),
blListerID(f, "order-p0-newer-d"),
blListerID(f, "order-p0-newer-e"),
blListerID(f, "order-p0-older"),
blListerID(f, "order-p1"),
blListerID(f, "order-p3"),
}
got := blListerIDs(blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}}))
if !slices.Equal(got, want) {
t.Errorf("listing order = %v, want %v (priority ascending, created_at descending, id)", got, want)
}
}
// runBlockedNamesWaitsForAndConditionalBlockers: a waits-for onto a spawner
// whose child is still open, and a conditional-blocks onto an open target,
// each name their target, as a blocks edge does.
func runBlockedNamesWaitsForAndConditionalBlockers(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-wf"
spawner, spawned := blListerID(f, "wf-spawner"), blListerID(f, "wf-spawned")
waiter := blListerID(f, "wf-waiter")
target, conditional := blListerID(f, "cb-target"), blListerID(f, "cb-src")
blListerSeedIssue(t, ctx, f, blListerIssue(spawner, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(spawned, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(target, 1, label+"-other"))
blListerSeedIssue(t, ctx, f, blListerIssue(waiter, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(conditional, 1, label))
blListerSeedEdge(t, ctx, f, spawned, spawner, types.DepParentChild)
blListerSeedEdge(t, ctx, f, waiter, spawner, types.DepWaitsFor)
blListerSeedEdge(t, ctx, f, conditional, target, types.DepConditionalBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{waiter: {spawner}, conditional: {target}})
}
// runBlockedOmitsAStaleFlag: a row whose stored flag says blocked but which
// has no active blocker and no parent names no blocker, so it is not listed.
// This is the narrowing gc's readiness projection documents relying on.
func runBlockedOmitsAStaleFlag(t *testing.T, ctx context.Context, f BlockedListerFixture) {
if f.MarkBlocked == nil {
t.Skip("this leg cannot write the stored is_blocked flag directly")
}
label := f.IssuePrefix + "-bl-stale"
stale, real, blocker := blListerID(f, "stale-src"), blListerID(f, "stale-real"), blListerID(f, "stale-blocker")
blListerSeedIssue(t, ctx, f, blListerIssue(stale, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(real, 1, label))
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
blListerSeedEdge(t, ctx, f, real, blocker, types.DepBlocks)
if err := f.MarkBlocked(ctx, stale); err != nil {
t.Fatalf("mark %s blocked: %v", stale, err)
}
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{real: {blocker}})
}
// runBlockedHasNoTypeExclusions: a gate is listed like any other row; the
// blocked door excludes no issue type (unlike the ready front).
func runBlockedHasNoTypeExclusions(t *testing.T, ctx context.Context, f BlockedListerFixture) {
label := f.IssuePrefix + "-bl-type"
gate, epic, blocker := blListerID(f, "type-gate"), blListerID(f, "type-epic"), blListerID(f, "type-blocker")
g := blListerIssue(gate, 1, label)
g.IssueType = types.TypeGate
g.AwaitType = "human"
blListerSeedIssue(t, ctx, f, g)
e := blListerIssue(epic, 1, label)
e.IssueType = types.TypeEpic
blListerSeedIssue(t, ctx, f, e)
blListerSeedIssue(t, ctx, f, blListerIssue(blocker, 1, label+"-other"))
blListerSeedEdge(t, ctx, f, gate, blocker, types.DepBlocks)
blListerSeedEdge(t, ctx, f, epic, blocker, types.DepBlocks)
items := blListerList(t, ctx, f, publicops.BlockedRequest{Labels: []string{label}})
blListerAssertRows(t, items, map[string][]string{gate: {blocker}, epic: {blocker}})
}
// runBlockedEmptyIsAnEmptySlice: nothing blocked is an empty, non-nil slice
// and a nil error.
func runBlockedEmptyIsAnEmptySlice(t *testing.T, ctx context.Context, f BlockedListerFixture) {
result, err := f.BlockedLister.ListBlocked(ctx, publicops.BlockedRequest{Labels: []string{f.IssuePrefix + "-bl-nothing"}})
if err != nil {
t.Fatalf("ListBlocked: %v", err)
}
if result.Items == nil || len(result.Items) != 0 {
t.Fatalf("Items = %#v, want an empty non-nil slice", result.Items)
}
}
// runBlockedDoesNotMutateTheRequest: the caller's label slices come back as
// they were sent, normalization notwithstanding.
func runBlockedDoesNotMutateTheRequest(t *testing.T, ctx context.Context, f BlockedListerFixture) {
req := publicops.BlockedRequest{
ParentID: " ",
Labels: []string{" a ", "", "a"},
LabelsAny: []string{" b"},
ExcludeLabels: []string{"c "},
}
before := publicops.BlockedRequest{
ParentID: req.ParentID,
Labels: slices.Clone(req.Labels),
LabelsAny: slices.Clone(req.LabelsAny),
ExcludeLabels: slices.Clone(req.ExcludeLabels),
}
if _, err := f.BlockedLister.ListBlocked(ctx, req); err != nil {
t.Fatalf("ListBlocked: %v", err)
}
if !reflect.DeepEqual(req, before) {
t.Errorf("request after = %#v, before = %#v", req, before)
}
}
func blListerID(f BlockedListerFixture, name string) string {
return fmt.Sprintf("%s-%s", f.IssuePrefix, name)
}
func blListerIssue(id string, priority int, labels ...string) *types.Issue {
return &types.Issue{
ID: id,
Title: id,
Status: types.StatusOpen,
Priority: priority,
IssueType: types.TypeTask,
Labels: labels,
}
}
func blListerSeedIssue(t *testing.T, ctx context.Context, f BlockedListerFixture, issue *types.Issue) {
t.Helper()
if err := f.CreateIssue(ctx, issue, "seed"); err != nil {
t.Fatalf("seed issue %s: %v", issue.ID, err)
}
}
func blListerSeedEdge(t *testing.T, ctx context.Context, f BlockedListerFixture, from, to string, kind types.DependencyType) {
t.Helper()
if err := f.AddDependency(ctx, &types.Dependency{IssueID: from, DependsOnID: to, Type: kind}, "seed"); err != nil {
t.Fatalf("seed %s edge %s -> %s: %v", kind, from, to, err)
}
}
func blListerList(t *testing.T, ctx context.Context, f BlockedListerFixture, req publicops.BlockedRequest) []*types.BlockedIssue {
t.Helper()
result, err := f.BlockedLister.ListBlocked(ctx, req)
if err != nil {
t.Fatalf("ListBlocked(%+v): %v", req, err)
}
if result.Items == nil {
t.Fatalf("ListBlocked(%+v) Items is nil; the role promises a non-nil slice", req)
}
return result.Items
}
func blListerIDs(items []*types.BlockedIssue) []string {
ids := make([]string, 0, len(items))
for _, item := range items {
ids = append(ids, item.ID)
}
return ids
}
// assertBlockedRows requires the listing to be exactly want: the same ids,
// each naming exactly the blockers want gives it (in any order), with
// BlockedByCount equal to their number.
func blListerAssertRows(t *testing.T, items []*types.BlockedIssue, want map[string][]string) {
t.Helper()
got := map[string][]string{}
for _, item := range items {
if item == nil {
t.Fatalf("listing carries a nil row")
}
if _, dup := got[item.ID]; dup {
t.Errorf("row %s listed twice", item.ID)
}
blockers := slices.Clone(item.BlockedBy)
slices.Sort(blockers)
got[item.ID] = blockers
if item.BlockedByCount != len(item.BlockedBy) {
t.Errorf("row %s: BlockedByCount = %d, len(BlockedBy) = %d", item.ID, item.BlockedByCount, len(item.BlockedBy))
}
}
normalized := map[string][]string{}
for id, blockers := range want {
b := slices.Clone(blockers)
slices.Sort(b)
normalized[id] = b
}
if !reflect.DeepEqual(got, normalized) {
t.Errorf("listing = %v, want %v", got, normalized)
}
}

View file

@ -546,65 +546,3 @@ func assertParent(t *testing.T, result publicops.BlockingResult, id, want string
t.Errorf("entry %s parent = %q, want %q", id, got, want)
}
}
// RunBlockingAnnotatorReportsTheTransitiveBlockedFlag pins
// BlockingRequest.IncludeIsBlocked and IssueBlocking.IsBlocked: asked, each id
// with a row carries its STORED TRANSITIVE is_blocked flag — a child of a
// blocked parent is blocked with no blocking edge of its own, which BlockedBy
// alone would read as free — and an id naming no row carries none. Unasked,
// no item carries a flag. This is the read issueops.BlockedFlags (storage's
// IsBlockedBatch on a role-served backend) is built on.
func RunBlockingAnnotatorReportsTheTransitiveBlockedFlag(t *testing.T, ctx context.Context, fixture BlockingAnnotatorFixture) {
t.Helper()
blocker := fixture.IssuePrefix + "-flag-blocker"
blocked := fixture.IssuePrefix + "-flag-blocked"
child := fixture.IssuePrefix + "-flag-child"
free := fixture.IssuePrefix + "-flag-free"
ghost := fixture.IssuePrefix + "-flag-ghost"
seedBlockingIssues(t, ctx, fixture, blocker, blocked, child, free)
seedBlockingEdge(t, ctx, fixture, child, blocked, types.DepParentChild)
seedBlockingEdge(t, ctx, fixture, blocked, blocker, types.DepBlocks)
ids := []string{blocked, child, free, ghost}
unasked := annotateBlocking(t, ctx, fixture, publicops.BlockingRequest{IDs: ids})
for _, item := range unasked.Items {
if item.IsBlocked != nil {
t.Errorf("unasked: %s carries IsBlocked=%v, want no flag", item.ID, *item.IsBlocked)
}
}
asked := annotateBlocking(t, ctx, fixture, publicops.BlockingRequest{IDs: ids, IncludeIsBlocked: true})
want := map[string]*bool{blocked: new(true), child: new(true), free: new(false), ghost: nil}
if len(asked.Items) != len(ids) {
t.Fatalf("asked: %d items, want %d", len(asked.Items), len(ids))
}
for _, item := range asked.Items {
w, ok := want[item.ID]
if !ok {
t.Errorf("asked: unexpected item %s", item.ID)
continue
}
switch {
case w == nil && item.IsBlocked != nil:
t.Errorf("asked: %s (no row) IsBlocked=%v, want no flag", item.ID, *item.IsBlocked)
case w != nil && item.IsBlocked == nil:
t.Errorf("asked: %s IsBlocked absent, want %v", item.ID, *w)
case w != nil && *item.IsBlocked != *w:
t.Errorf("asked: %s IsBlocked=%v, want %v", item.ID, *item.IsBlocked, *w)
}
}
flags, err := publicops.BlockedFlags(ctx, fixture.Annotator, append(ids, blocked, ""))
if err != nil {
t.Fatalf("BlockedFlags: %v", err)
}
wantFlags := map[string]bool{blocked: true, child: true, free: false}
if len(flags) != len(wantFlags) {
t.Errorf("BlockedFlags = %v, want %v (no entry for the ghost or the blank id)", flags, wantFlags)
}
for id, w := range wantFlags {
if got, ok := flags[id]; !ok || got != w {
t.Errorf("BlockedFlags[%s] = %v (present %v), want %v", id, got, ok, w)
}
}
}

View file

@ -71,13 +71,11 @@ import (
// - PARTICIPATION-GENERATION GATING (design §16.2b). Whether an
// update-shaped mutation on a legacy (participation_generation IS NULL)
// row is correctly skipped is Phase 2 behavior this bead also owns, but
// it depends on migration 0070's participation_generation column, which
// does not exist when this contract is first written (0070 lands last in
// this bead's build order, by the mayor's explicit sequencing — steps 4-5
// of design §16.3 moved to their own migration slot when 0068 shipped as
// attribution_status-only, see that migration's header). It gets its own
// dedicated cases once 0070 lands, beside this file rather than inside
// it.
// it depends on migration 0068's participation_generation column, which
// does not exist when this contract is first written (0068 lands last in
// this bead's build order, by the mayor's explicit sequencing). It gets
// its own dedicated cases once 0068 lands, beside this file rather than
// inside it.
// - CONCURRENT WRITERS. Every case here is one writer, one issue, one
// mutation at a time — the same restriction journal_contract.go states
// for the same reason: a single-threaded case cannot exercise what only

View file

@ -1,644 +0,0 @@
package conformance
import (
"context"
"testing"
)
// This file holds the write-fence cases dualwrite_history_contract.go's own
// "WHAT THIS CONTRACT DELIBERATELY DOES NOT PIN" section explicitly deferred:
// "PARTICIPATION-GENERATION GATING (design §16.2b)... It gets its own
// dedicated cases once 0070 lands, beside this file rather than inside it."
// Migration 0070 now carries participation_generation on both issues and
// wisps (design §16.3 steps 4-5, be-dt74u amendment, be-h89oq), so this is
// that file.
//
// Design §16.2b, verbatim substance: the flag-on writer does not increment
// current_revision or mint an issue_versions row for an UPDATE-shaped
// mutation against a record whose participation_generation is NULL — a skip,
// not a refusal (FR-2's zero-rows no-op shape). A CREATE-shaped mutation is
// different: a brand-new row has no prior legacy state to preserve, so if the
// flag is already on at creation time, the writer stamps
// participation_generation as part of the same insert that begins its
// history. A create with the flag off leaves the column NULL, indistinguishable
// from a true legacy row (FR-7's byte-identical requirement).
//
// WHY A SEPARATE FIXTURE RATHER THAN THREE MORE DualWriteFixture CLOSURES.
// DualWriteFixture's Mutate/MutateAsNoOp pair is deliberately flag-fixed-at-
// construction (see that file's SEEDING DISCIPLINE note and each leg's
// newXxxDualWriteFixture, which calls SetVersionedHistoryEnabled exactly
// once). The legacy-record case here is inherently "created while the flag
// was OFF, then mutated after the flag turns ON" — a fixture built once with
// one flag state cannot express that sequence, so SetFlag here is a toggle
// callable more than once per fixture, not a one-time constructor argument.
//
// THE FIXTURE'S CLOSURES ARE THE OBSERVABLE SURFACE, NOT THE SCHEMA — same
// discipline as DualWriteFixture: Mutate/MutateExisting drive CreateIssue and
// UpdateIssue (or their unit-of-work equivalents), never issue_versions or
// store_epoch directly.
//
// WHAT THIS CONTRACT DELIBERATELY DOES NOT PIN:
// - THE EXACT STAMPED VALUE. That a create-shaped mutation with the flag on
// stamps SOME non-NULL participation_generation is pinned here; that the
// value equals the current store_epoch.epoch is not — reaching
// store_epoch is the same one-column, two-of-three-legs-need-white-box-
// access problem dualwrite_history_contract.go's FR-6 note describes, and
// the same resolution applies: pinned per leg, dolt-only, alongside
// TestDualWriteStampsTheCurrentStoreEpochOnEachVersionRow.
// - wisps.participation_generation. FR-8 (carried by dualwrite_history_contract.go's
// exclusion list) applies here too: this fixture's Mutate front door is
// CreateIssue against the issues table, the wisp-arrival cases read only
// the issues row a wisp becomes, and no phase reads or writes the wisps
// column regardless.
type ParticipationGenerationFixture struct {
// IssuePrefix namespaces the id each case mints, the same discipline
// DualWriteFixture uses and for the same reason.
IssuePrefix string
// SetFlag toggles versioned history for every subsequent call through
// this fixture, and may be called more than once per case — unlike
// DualWriteFixture, whose flag is fixed at construction.
SetFlag func(ctx context.Context, enabled bool) error
// Mutate creates a new issue with the given id: a CREATE-shaped mutation
// in design §16.2b's sense.
Mutate func(ctx context.Context, id string) error
// MutateExisting applies a real (non-no-op) UPDATE-shaped mutation to an
// already-existing issue — a different value than Mutate gave it, so a
// vacuous no-op skip can never be mistaken for the fence.
MutateExisting func(ctx context.Context, id string) error
// CreateWisp creates a new wisp-plane (ephemeral) issue with the given
// id: the starting point for the two ways a record reaches the issues
// plane without being created there. A wisp is never versioned (FR-8)
// and never carries a participation declaration, in either flag state.
CreateWisp func(ctx context.Context, id string) error
// PromoteWisp promotes the wisp id onto the issues plane
// (PromoteFromEphemeral, or the unit-of-work leg's PromoteWisp).
PromoteWisp func(ctx context.Context, id string) error
// MovePersistent moves the wisp id onto the issues plane through a
// persistence-mode update (bd update --persistent). It is its own
// closure rather than a second spelling of PromoteWisp because it mints at
// a different site on every leg: the guarded update's one end-of-update
// mint on dolt and embeddeddolt, MoveIssuePersistenceInTx's own on uow.
// On an issues-plane row whose flags disagree with it (see
// CreateNoHistoryIssue) the same update repairs the flags in place, a
// same-plane normalize, rather than moving the row.
MovePersistent func(ctx context.Context, id string) error
// ClearWispFlag clears the wisp id's ephemeral flag IN PLACE: the untyped
// UpdateIssue of {"wisp": false} bd mol squash makes on a squashed root
// (UpdateWisp on the unit-of-work leg, the way its molecule writer routes
// it). The row stays in the wisps table, now carrying neither Ephemeral
// nor NoHistory.
ClearWispFlag func(ctx context.Context, id string) error
// SquashWispRoot closes the wisp id and then clears its flag as
// ClearWispFlag does, both in ONE transaction: the shape bd mol squash's
// root auto-close takes, where an error from either write aborts both.
SquashWispRoot func(ctx context.Context, id string) error
// CreateUnflaggedWisp creates id in the wisps table with neither
// Ephemeral nor NoHistory set: import's "wisp_plane" marker, which pins
// the plane whatever the flags say (WispPlaneOverride = &true, through
// the batch create import runs), or on the unit-of-work leg CreateWisp,
// which routes by the call rather than by the flags.
CreateUnflaggedWisp func(ctx context.Context, id string) error
// CreateNoHistoryIssue creates id in the ISSUES table carrying
// NoHistory=true: import's promoted-no-history shape (bd-r9uce), a
// durable row whose stray flag is preserved while WispPlaneOverride =
// &false pins its plane, through the batch create import runs; or on the
// unit-of-work leg CreateIssue, which routes by the call.
CreateNoHistoryIssue func(ctx context.Context, id string) error
// CurrentRevision reads issues.current_revision for id.
CurrentRevision func(ctx context.Context, id string) (int64, error)
// VersionRowCount reads how many issue_versions rows exist for id.
VersionRowCount func(ctx context.Context, id string) (int, error)
// ParticipationGeneration reads issues.participation_generation for id,
// returning nil for SQL NULL.
ParticipationGeneration func(ctx context.Context, id string) (*int64, error)
// InWispsTable reports whether the wisps table holds a row for id: the
// precondition the wisps-table cases check, so they cannot pass on a row
// that a step moved to the issues table.
InWispsTable func(ctx context.Context, id string) (bool, error)
}
// RunParticipationGenerationCreateWithFlagOnStampsAValue pins design
// §16.2(a)/(b): a create-shaped mutation with the flag already on stamps a
// non-NULL participation_generation on the new row, as part of the same
// insert that begins its history — a brand-new row has no legacy state to
// preserve, so there is nothing to skip.
func RunParticipationGenerationCreateWithFlagOnStampsAValue(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-create-stamps"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
gen, err := fixture.ParticipationGeneration(ctx, id)
if err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
}
if gen == nil {
t.Errorf("participation_generation for %s is NULL immediately after a create-shaped mutation with "+
"the flag on, want a stamped non-NULL value: design §16.2b requires the writer to declare "+
"participation at insert time, since a brand-new row has no prior legacy state to preserve", id)
}
}
// RunParticipationGenerationCreateWithFlagOffLeavesLegacyNull pins the other
// half of design §16.2(b): a create-shaped mutation with the flag off leaves
// participation_generation NULL, indistinguishable from a true legacy row —
// flag-off must stay byte-identical to pre-Phase-2 behavior (FR-7).
func RunParticipationGenerationCreateWithFlagOffLeavesLegacyNull(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, false); err != nil {
t.Fatalf("disabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-create-flag-off"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
gen, err := fixture.ParticipationGeneration(ctx, id)
if err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
}
if gen != nil {
t.Errorf("participation_generation for %s = %d with the flag off at creation, want NULL: a "+
"flag-off create must remain indistinguishable from a true legacy row (design §16.2b)", id, *gen)
}
}
// RunParticipationGenerationSkipsUpdateOnLegacyRecord pins the write fence's
// central claim, design §16.2(b): the flag-on writer does not increment
// current_revision or mint an issue_versions row for an update-shaped
// mutation against a record whose participation_generation is NULL. The
// record must be a REAL legacy record — created while the flag was off, not
// merely one the fixture asserts is NULL — so this also re-confirms that
// precondition before trusting the rest of the case.
func RunParticipationGenerationSkipsUpdateOnLegacyRecord(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, false); err != nil {
t.Fatalf("disabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-legacy-skip"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
if gen, err := fixture.ParticipationGeneration(ctx, id); err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
} else if gen != nil {
t.Fatalf("participation_generation for %s = %d before the flag was ever turned on, want NULL — "+
"this case cannot test the legacy-record fence against a record that was never actually legacy",
id, *gen)
}
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
beforeRevision, err := fixture.CurrentRevision(ctx, id)
if err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
}
beforeCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterRevision, err := fixture.CurrentRevision(ctx, id)
if err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != beforeCount {
t.Errorf("version row count for %s went from %d to %d across an update-shaped mutation on a "+
"legacy (participation_generation IS NULL) record with the flag now on, want unchanged: "+
"design §16.2b requires the writer to skip minting for a record it has not positively "+
"promoted", id, beforeCount, afterCount)
}
if afterRevision != beforeRevision {
t.Errorf("current_revision for %s went from %d to %d across the same skipped mutation, want "+
"unchanged: a skip means neither half of RecordVersionInTx's write runs, not just the "+
"version-row half", id, beforeRevision, afterRevision)
}
}
// RunParticipationGenerationProceedsForPromotedRecord is the fence's
// not-vacuous check: an update-shaped mutation against a record whose
// participation_generation is ALREADY stamped (created with the flag on,
// i.e. positively declared, not legacy) must mint normally. Without this
// case, an implementation that skips every update unconditionally would
// still pass RunParticipationGenerationSkipsUpdateOnLegacyRecord.
func RunParticipationGenerationProceedsForPromotedRecord(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-promoted-proceeds"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
if gen, err := fixture.ParticipationGeneration(ctx, id); err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
} else if gen == nil {
t.Fatalf("participation_generation for %s is NULL immediately after a create with the flag on — "+
"this case cannot test the promoted-record path against a record that was never actually "+
"promoted", id)
}
beforeCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != beforeCount+1 {
t.Errorf("version row count for %s went from %d to %d across an update-shaped mutation on an "+
"already-promoted record, want exactly +1: the fence must skip only a legacy (NULL) record, "+
"not every update (design §16.2b)", id, beforeCount, afterCount)
}
}
// RunParticipationGenerationFlagOffSkipsUpdateOnParticipatingRecord pins the
// switch's off half for a record the fence would let through: created with
// the flag on (so participation_generation is stamped), then updated after
// the flag is turned back off, it must mint nothing. ProceedsForPromotedRecord
// shows the fence passes such a record, so only the flag stands between this
// update and a mint. No other case can see a writer that ignores the flag on
// updates: every other flag-off record is legacy, and the fence stops those
// first.
func RunParticipationGenerationFlagOffSkipsUpdateOnParticipatingRecord(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-flag-off-skip"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
if gen, err := fixture.ParticipationGeneration(ctx, id); err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
} else if gen == nil {
t.Fatalf("participation_generation for %s is NULL immediately after a create with the flag on — "+
"this case cannot test the flag against a record the fence would have stopped anyway", id)
}
if err := fixture.SetFlag(ctx, false); err != nil {
t.Fatalf("disabling versioned history: %v", err)
}
beforeRevision, err := fixture.CurrentRevision(ctx, id)
if err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
}
beforeCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterRevision, err := fixture.CurrentRevision(ctx, id)
if err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != beforeCount {
t.Errorf("version row count for %s went from %d to %d across an update-shaped mutation with the "+
"flag off, want unchanged: turning versioned history off stops minting for every record, "+
"including one that already participates", id, beforeCount, afterCount)
}
if afterRevision != beforeRevision {
t.Errorf("current_revision for %s went from %d to %d across the same update with the flag off, "+
"want unchanged", id, beforeRevision, afterRevision)
}
}
// RunParticipationGenerationWispPromotionBeginsHistory pins that promoting a
// wisp onto the issues plane is CREATE-shaped in design §16.2b's sense. (This
// is wisp promotion, PromoteFromEphemeral: not R2.3's promotion of a legacy
// record, which is what ProceedsForPromotedRecord's name refers to.) The
// issues row a promotion inserts is brand new on that plane, and the wisp
// behind it was never versioned and never declared participation (FR-8), so
// there is no legacy state to preserve: with the flag on, the promotion stamps
// participation_generation and mints the record's first version, as a create
// there would. Treated as UPDATE-shaped, the fence finds the new row NULL and
// skips, and because nothing stamps the column afterwards every later update
// skips too, so a record created with the flag on is never versioned at all.
func RunParticipationGenerationWispPromotionBeginsHistory(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
runWispArrivalBeginsHistory(t, ctx, fixture, "promote", fixture.PromoteWisp)
}
// RunParticipationGenerationWispPersistenceMoveBeginsHistory is
// RunParticipationGenerationWispPromotionBeginsHistory for the other way a
// wisp reaches the issues plane, a persistence-mode update (bd update
// --persistent). It needs its own case because it reaches a different mint
// site than promotion on every leg (see MovePersistent).
func RunParticipationGenerationWispPersistenceMoveBeginsHistory(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
runWispArrivalBeginsHistory(t, ctx, fixture, "move-persistent", fixture.MovePersistent)
}
// runWispArrivalBeginsHistory is the body the two wisp-arrival cases share:
// with the flag on, a wisp that arrives on the issues plane through arrive
// carries a stamped participation_generation and exactly one version row,
// and the next update-shaped mutation mints normally.
func runWispArrivalBeginsHistory(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture, how string, arrive func(context.Context, string) error) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-" + how
if err := fixture.CreateWisp(ctx, id); err != nil {
t.Fatalf("creating wisp %s: %v", id, err)
}
if err := arrive(ctx, id); err != nil {
t.Fatalf("moving wisp %s onto the issues plane (%s): %v", id, how, err)
}
gen, err := fixture.ParticipationGeneration(ctx, id)
if err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
}
if gen == nil {
t.Errorf("participation_generation for %s is NULL after the wisp reached the issues plane (%s) with "+
"the flag on, want a stamped value: the issues row is new, so the arrival is create-shaped "+
"(design §16.2b), and a NULL here leaves the record fenced as legacy for good", id, how)
}
arrivedCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if arrivedCount != 1 {
t.Errorf("version row count for %s = %d after the wisp reached the issues plane (%s) with the flag "+
"on, want 1: a wisp is never versioned (FR-8), so the arrival mints the record's first version",
id, arrivedCount, how)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != arrivedCount+1 {
t.Errorf("version row count for %s went from %d to %d across an update-shaped mutation after the "+
"wisp reached the issues plane (%s), want exactly +1: a record that arrived with the flag on is "+
"not legacy, so the fence must let its updates mint", id, arrivedCount, afterCount, how)
}
}
// RunParticipationGenerationWispFlagClearMintsNothing pins that the fence
// decides a row's plane by the TABLE that holds it, not by the row's flags.
// bd mol squash clears a wisp root's ephemeral flag in place, so the row
// stays in the wisps table carrying neither Ephemeral nor NoHistory, and a
// plane test read off those flags takes it for an issues-plane row. It is
// not one: a wisps-table row is never versioned (FR-8) and has no issues row
// whose participation_generation the fence could read. So the update must
// succeed and mint nothing. Read off the flags, the fence either aborts the
// whole update looking for an issues row that is not there, or, without the
// fence, mints a stray version for a wisp.
func RunParticipationGenerationWispFlagClearMintsNothing(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
runWispTableRowMintsNothing(t, ctx, fixture, "flag-clear", fixture.CreateWisp, fixture.ClearWispFlag)
}
// RunParticipationGenerationWispRootSquashMintsNothing is
// RunParticipationGenerationWispFlagClearMintsNothing in the shape bd mol
// squash actually runs it: the root's close and its flag clear in one
// transaction, so a mint that fails on the cleared row takes the close down
// with it and the squash cannot complete.
func RunParticipationGenerationWispRootSquashMintsNothing(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
runWispTableRowMintsNothing(t, ctx, fixture, "squash", fixture.CreateWisp, fixture.SquashWispRoot)
}
// RunParticipationGenerationUnflaggedWispCreateMintsNothing pins the
// create-shaped half of the same rule: a row CREATED in the wisps table
// without either flag (import's "wisp_plane" marker) reaches the
// create-shaped mint, and must come out of it with no error and no version,
// exactly as a flagged wisp does.
func RunParticipationGenerationUnflaggedWispCreateMintsNothing(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
runWispTableRowMintsNothing(t, ctx, fixture, "unflagged-create", fixture.CreateUnflaggedWisp)
}
// runWispTableRowMintsNothing is the body the three wisps-table cases share:
// with the flag on, every step succeeds on id, the wisps table still holds id
// afterwards, and id ends with no issue_versions row.
func runWispTableRowMintsNothing(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture, how string, steps ...func(context.Context, string) error) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-" + how
for i, step := range steps {
if err := step(ctx, id); err != nil {
t.Fatalf("step %d of %s on wisps-table row %s with the flag on: %v — a row the wisps table "+
"holds is never versioned (FR-8), so its mint must be a no-op, not an error that aborts "+
"the mutation", i+1, how, id, err)
}
}
// The precondition, checked after the steps rather than assumed: a step
// that moved the row to the issues table would leave a NULL
// participation_generation there, the update-shaped mint would be fenced
// as legacy, and the zero count below would hold without saying anything
// about a wisps-table row.
if inWisps, err := fixture.InWispsTable(ctx, id); err != nil {
t.Fatalf("checking whether the wisps table holds %s: %v", id, err)
} else if !inWisps {
t.Fatalf("%s is not in the wisps table after %s — this case pins that a wisps-table row mints "+
"nothing, and cannot say so about a row a step moved out of that table", id, how)
}
count, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if count != 0 {
t.Errorf("version row count for wisps-table row %s = %d after %s with the flag on, want 0: a "+
"wisp is never versioned (FR-8), whatever its flags say", id, count, how)
}
}
// RunParticipationGenerationNoHistoryIssueCreateDeclaresParticipation pins
// that a create declares participation for every ISSUES-table row it makes
// with the flag on, a row carrying NoHistory included. Import keeps a
// promoted no-history wisp's durable row on the issues plane with its stray
// no_history=true (bd-r9uce). While the row says no-history it is not
// versioned, so the create mints nothing. But it was created with history
// on, so it is not legacy: once bd update --persistent repairs the flag in
// place (a same-plane normalize, update-shaped by design), the repair and
// every update after it must mint. Left NULL by the create, the column reads
// as legacy to the fence, and the row is never versioned at all.
func RunParticipationGenerationNoHistoryIssueCreateDeclaresParticipation(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-no-history-create"
if err := fixture.CreateNoHistoryIssue(ctx, id); err != nil {
t.Fatalf("creating no-history issues-plane row %s: %v", id, err)
}
gen, err := fixture.ParticipationGeneration(ctx, id)
if err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
}
if gen == nil {
t.Errorf("participation_generation for %s is NULL after a create with the flag on, want a stamped "+
"value: the row is new on the issues plane, so the create declares participation (design "+
"§16.2b) even though its NoHistory flag keeps it unversioned for now", id)
}
if count, err := fixture.VersionRowCount(ctx, id); err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
} else if count != 0 {
t.Errorf("version row count for %s = %d after a create carrying NoHistory, want 0: a no-history "+
"row is not versioned while it says so", id, count)
}
if err := fixture.MovePersistent(ctx, id); err != nil {
t.Fatalf("repairing %s to persistent: %v", id, err)
}
repairedCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if repairedCount != 1 {
t.Errorf("version row count for %s = %d after the persistent repair, want 1: the row was created "+
"with the flag on, so the fence must let the repair's update-shaped mint through", id, repairedCount)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != repairedCount+1 {
t.Errorf("version row count for %s went from %d to %d across an update-shaped mutation after the "+
"repair, want exactly +1", id, repairedCount, afterCount)
}
}
// RunParticipationGenerationLegacyNoHistoryIssueStaysLegacy is
// RunParticipationGenerationNoHistoryIssueCreateDeclaresParticipation's
// negative twin, and pins R2.3: an ordinary write never promotes a legacy
// record. The same no-history issues-table row, created while the flag was
// OFF, is legacy. Only a create-shaped call stamps a flagged row, so once the
// flag is on, an update-shaped mutation must leave participation_generation
// NULL and mint nothing. So must the bd update --persistent repair that then
// clears the flag in place: that repair is update-shaped too (a same-plane
// normalize), so the row it leaves is an ordinary legacy row, still fenced.
func RunParticipationGenerationLegacyNoHistoryIssueStaysLegacy(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
if err := fixture.SetFlag(ctx, false); err != nil {
t.Fatalf("disabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-no-history-legacy"
if err := fixture.CreateNoHistoryIssue(ctx, id); err != nil {
t.Fatalf("creating no-history issues-plane row %s with the flag off: %v", id, err)
}
if gen, err := fixture.ParticipationGeneration(ctx, id); err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
} else if gen != nil {
t.Fatalf("participation_generation for %s = %d before the flag was ever turned on, want NULL — "+
"this case cannot test that a legacy no-history row stays legacy against a row that was never "+
"legacy", id, *gen)
}
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
beforeRevision, err := fixture.CurrentRevision(ctx, id)
if err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
}
assertStillLegacy := func(after string) {
t.Helper()
if gen, err := fixture.ParticipationGeneration(ctx, id); err != nil {
t.Fatalf("reading participation_generation for %s: %v", id, err)
} else if gen != nil {
t.Errorf("participation_generation for %s = %d after %s with the flag on, want NULL: the row "+
"was created with the flag off, and an update-shaped write must not promote a legacy "+
"record (R2.3), whatever its no-history flag says", id, *gen, after)
}
if count, err := fixture.VersionRowCount(ctx, id); err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
} else if count != 0 {
t.Errorf("version row count for %s = %d after %s with the flag on, want 0: a legacy row's "+
"update-shaped mint is fenced (design §16.2b)", id, count, after)
}
if revision, err := fixture.CurrentRevision(ctx, id); err != nil {
t.Fatalf("reading current_revision for %s: %v", id, err)
} else if revision != beforeRevision {
t.Errorf("current_revision for %s went from %d to %d after %s, want unchanged: a fenced "+
"mint runs neither half of the seam's write", id, beforeRevision, revision, after)
}
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
assertStillLegacy("an update-shaped mutation")
if err := fixture.MovePersistent(ctx, id); err != nil {
t.Fatalf("repairing %s to persistent: %v", id, err)
}
assertStillLegacy("the persistent repair")
}
// RunParticipationGenerationFenceIgnoresSchemaSkewHatch pins design §16.2(c):
// BD_IGNORE_SCHEMA_SKEW=1 downgrades CheckForwardDrift's refusal to a warning
// (internal/storage/schema/schema.go), but it must have no effect on this
// fence — the fence keys on the participation_generation column's real data,
// not on the migration cursor the hatch is about, so a write admitted through
// that hatch is still, correctly, skipped when the record is legacy.
func RunParticipationGenerationFenceIgnoresSchemaSkewHatch(t *testing.T, ctx context.Context, fixture ParticipationGenerationFixture) {
t.Helper()
t.Setenv("BD_IGNORE_SCHEMA_SKEW", "1")
if err := fixture.SetFlag(ctx, false); err != nil {
t.Fatalf("disabling versioned history: %v", err)
}
id := fixture.IssuePrefix + "-schema-skew-hatch"
if err := fixture.Mutate(ctx, id); err != nil {
t.Fatalf("mutating %s: %v", id, err)
}
if err := fixture.SetFlag(ctx, true); err != nil {
t.Fatalf("enabling versioned history: %v", err)
}
beforeCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if err := fixture.MutateExisting(ctx, id); err != nil {
t.Fatalf("mutating existing %s: %v", id, err)
}
afterCount, err := fixture.VersionRowCount(ctx, id)
if err != nil {
t.Fatalf("counting version rows for %s: %v", id, err)
}
if afterCount != beforeCount {
t.Errorf("version row count for %s went from %d to %d with BD_IGNORE_SCHEMA_SKEW=1 set, want "+
"unchanged: the schema-skew hatch must not bypass the participation_generation fence — they "+
"key on different planes (migration cursor vs. real column data) — so a write admitted "+
"through the hatch against a legacy record must still be skipped", id, beforeCount, afterCount)
}
}

View file

@ -1,837 +0,0 @@
package conformance
import (
"context"
"errors"
"strings"
"testing"
"time"
storeops "github.com/steveyegge/beads/internal/storage/issueops"
"github.com/steveyegge/beads/internal/types"
publicops "github.com/steveyegge/beads/issueops"
)
// This file holds the contract every implementation of publicops.Heartbeater
// must satisfy. Each case asserts what issueops/heartbeater.go PROMISES, cited
// by symbol.
//
// THREE LEGS, ONE BODY. dolt, embedded dolt and the unit-of-work provider all
// reach internal/storage/issueops.ExecuteHeartbeatInTx, so a per-leg failure
// here is a wrapper's failure: a commit the leg added, a hook it fired, a
// refusal that stopped matching errors.Is.
//
// THE QUIET CASE IS THE POINT. A heartbeat is the hottest write in a fleet and
// it is cheap because it writes the lease row and nothing else. Most of what
// RunHeartbeaterChangesNothingOnTheRow asserts is an ABSENCE — no revision, no
// version, no updated_at, no event, no journal entry, no history entry, no
// hook — and each absence is something a plausible wrapper would add.
//
// THE LIVE-CLAIM FENCE IS AN INVARIANT AND A PREDICATE. The RefusesAfter*
// cases hold the invariant: each ends a claim one way and asserts both that
// the lease row is gone and that the holder's next heartbeat is refused. The
// RefusesAnOrphanedLease* cases hold the predicate: a lease row that survives
// on an issue that is no longer claimed by its holder (what a re-arm racing a
// release or close can leave on Dolt) is refused AND deleted, never refreshed.
type HeartbeaterFixture struct {
// IssuePrefix namespaces the ids each assertion seeds, so several of them
// can share one database.
IssuePrefix string
// Heartbeater is the surface under test.
Heartbeater publicops.Heartbeater
// CreateIssue seeds a durable issue in the issues plane.
CreateIssue func(context.Context, *types.Issue, string) error
// CreateWisp seeds an ephemeral issue in the wisps plane. A nil CreateWisp
// SKIPS the wisp case loudly.
CreateWisp func(context.Context, *types.Issue, string) error
// Claimer takes the claim, and with it the lease row, a heartbeat
// refreshes.
Claimer publicops.Claimer
// Lifecycle ends or moves a claim (close, a status move, a hand-doled
// claim) and performs the guarded write the revision case lands.
Lifecycle publicops.Lifecycle
// Releaser gives a claim up for the release case. Nil SKIPS that case.
Releaser publicops.Releaser
// LeaseReclaimer reverts an aged claim for the reclaim case. Nil, or a nil
// Exec, SKIPS that case.
LeaseReclaimer publicops.LeaseReclaimer
// Exec runs raw statements against the backing database: the cases use it
// to age a lease.
Exec func(ctx context.Context, statements []SQLStatement) error
// ExecUncommitted runs raw statements as ANOTHER writer that leaves its
// change uncommitted in the version-controlled working set (a batch-mode
// edit): SQL-committed, no version-control commit. Nil means Exec already
// behaves so.
ExecUncommitted func(ctx context.Context, statements []SQLStatement) error
// QueryScalar runs a single-row query and scans it, so the post-state is
// read RAW rather than through the role being tested.
QueryScalar func(context.Context, string, []any, ...any) error
// CountHistory reports how many version-control entries the fixture's
// branch has. Nil SKIPS that one assertion, loudly, in the quiet case.
CountHistory func(context.Context) (int, error)
// SetJournalEnabled turns on durable journaling, so the quiet case can
// observe that a heartbeat records nothing in bd_events_journal. Nil SKIPS
// that one assertion, loudly.
SetJournalEnabled func(enabled bool)
// SetVersionedHistoryEnabled turns on dual-write issue-version history, so
// the quiet case can observe that a heartbeat records no issue_versions
// row. Nil SKIPS that one assertion, loudly.
SetVersionedHistoryEnabled func(enabled bool)
// HookedHeartbeater is the same role taken off the leg's HOOK-FIRING chain
// (storage.HookFiringStore on the store legs, uow.NewNotifyingProvider on
// the unit-of-work leg), built over the runner FiredUpdates reads. Nil,
// with FiredUpdates, SKIPS the no-hook assertion loudly.
HookedHeartbeater publicops.Heartbeater
// FiredUpdates reports, in firing order, the issue id of every on_update
// the hooked chain ran so far.
FiredUpdates func(context.Context) ([]string, error)
}
const (
heartbeaterHolder = "hb-holder"
heartbeaterIntruder = "hb-intruder"
heartbeaterReaper = "hb-reaper"
)
// RunHeartbeaterRefreshesTheHoldersLease pins the refresh itself
// (Heartbeater: "pushes the lease the caller holds forward by the store's
// TTL") and every member of the HeartbeatResult, against the row READ RAW.
func RunHeartbeaterRefreshesTheHoldersLease(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
id := fixture.IssuePrefix + "-refresh"
heartbeaterSeedClaimed(t, ctx, fixture, id)
aged := time.Now().UTC().Add(-time.Minute).Truncate(time.Second)
if err := fixture.Exec(ctx, []SQLStatement{{
Query: "UPDATE leases SET lease_expires_at = ?, heartbeat_at = ? WHERE issue_id = ?",
Args: []any{aged, aged, id},
}}); err != nil {
t.Fatalf("age the lease on %s: %v", id, err)
}
before := time.Now().UTC().Add(-time.Second)
result := heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
after := time.Now().UTC().Add(time.Second)
if result.IssueID != id || result.Holder != heartbeaterHolder || result.Rearmed {
t.Fatalf("result = %+v, want {IssueID:%s Holder:%s Rearmed:false}", result, id, heartbeaterHolder)
}
if result.HeartbeatAt.Before(before) || result.HeartbeatAt.After(after) {
t.Fatalf("HeartbeatAt = %v, want the server clock at the call (between %v and %v)", result.HeartbeatAt, before, after)
}
if ttl := result.LeaseExpiresAt.Sub(result.HeartbeatAt); heartbeaterAbs(ttl-storeops.DefaultLeaseTTL) > time.Second {
t.Fatalf("LeaseExpiresAt - HeartbeatAt = %v, want the store's lease TTL %v", ttl, storeops.DefaultLeaseTTL)
}
if moved := heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM leases WHERE issue_id = ? AND holder = ? AND lease_expires_at > ? AND heartbeat_at > ?",
id, heartbeaterHolder, aged, aged); moved != 1 {
t.Fatal("the lease row's lease_expires_at and heartbeat_at did not move forward")
}
heartbeaterRequireStoredMatches(t, ctx, fixture, id, result, before, after)
}
// RunHeartbeaterASameSecondHeartbeatIsNotARearm pins HeartbeatResult.Rearmed
// against the refresh that changes no value: a heartbeat landing in the same
// second as the claim or the previous heartbeat writes values identical to the
// row's (the lease columns hold whole seconds), which some engines report as
// zero rows affected. It is still a refresh of the caller's own row: Rearmed
// is false, and the lease's granted_at and granted_node do not move.
func RunHeartbeaterASameSecondHeartbeatIsNotARearm(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
for i := 0; i < 3; i++ {
id := fixture.IssuePrefix + "-samesec-" + string(rune('a'+i))
heartbeaterSeedClaimed(t, ctx, fixture, id)
granted := heartbeaterScalar[string](t, ctx, fixture,
"SELECT CONCAT(CAST(granted_at AS CHAR), '|', COALESCE(granted_node, '')) FROM leases WHERE issue_id = ?", id)
for beat := 0; beat < 2; beat++ {
result := heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
if result.Rearmed {
t.Fatalf("heartbeat %d on %s right after the claim = %+v, want Rearmed:false: the holder's lease row existed", beat+1, id, result)
}
}
if got := heartbeaterScalar[string](t, ctx, fixture,
"SELECT CONCAT(CAST(granted_at AS CHAR), '|', COALESCE(granted_node, '')) FROM leases WHERE issue_id = ?", id); got != granted {
t.Fatalf("granted_at|granted_node on %s moved from %s to %s across refreshes; a refresh never re-grants", id, granted, got)
}
}
}
// RunHeartbeaterChangesNothingOnTheRow pins the role's quiet promise
// (Heartbeater: "A REFRESH WRITES ONLY THE LEASE ROW"): the issue row's revision
// (row_lock), its current_revision, its updated_at, its events, the events
// journal, issue_versions, the version-control history and the hooks are all
// exactly where the claim left them.
func RunHeartbeaterChangesNothingOnTheRow(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
if fixture.SetJournalEnabled != nil {
fixture.SetJournalEnabled(true)
defer fixture.SetJournalEnabled(false)
} else {
t.Log("HeartbeaterFixture.SetJournalEnabled is nil: the journal assertion is skipped on this backend")
}
if fixture.SetVersionedHistoryEnabled != nil {
fixture.SetVersionedHistoryEnabled(true)
defer fixture.SetVersionedHistoryEnabled(false)
} else {
t.Log("HeartbeaterFixture.SetVersionedHistoryEnabled is nil: the issue_versions assertion is skipped on this backend")
}
id := fixture.IssuePrefix + "-quiet"
heartbeaterSeedClaimed(t, ctx, fixture, id)
// updated_at is stored at second precision on some backends; step past
// the claim's second so a stamp the heartbeat added cannot hide in it.
time.Sleep(1100 * time.Millisecond)
snapshot := func() heartbeaterRowSnapshot {
return heartbeaterSnapshot(t, ctx, fixture, id)
}
before := snapshot()
fired := heartbeaterFired(t, ctx, fixture, id)
surface := fixture.Heartbeater
if fixture.HookedHeartbeater != nil && fixture.FiredUpdates != nil {
surface = fixture.HookedHeartbeater
} else {
t.Log("HeartbeaterFixture.HookedHeartbeater/FiredUpdates is nil: the no-hook assertion is skipped on this backend")
}
heartbeat(t, ctx, surface, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
after := snapshot()
if before != after {
t.Fatalf("a heartbeat changed the issue's durable state:\nbefore %+v\nafter %+v", before, after)
}
if got := heartbeaterFired(t, ctx, fixture, id); got != fired {
t.Fatalf("on_update fired %d time(s) for %s across a refresh, want 0: a refresh fires no hook", got-fired, id)
}
}
// RunHeartbeaterAGuardedWriteWithThePreHeartbeatRevisionStillWins is the
// reason the quiet case matters to a caller: the holder's revision token
// survives its own heartbeats, so a guarded write it composed from the claim
// still lands.
func RunHeartbeaterAGuardedWriteWithThePreHeartbeatRevisionStillWins(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.Lifecycle is nil: this backend cannot land a guarded write")
}
id := fixture.IssuePrefix + "-guarded"
revision := heartbeaterSeedClaimed(t, ctx, fixture, id)
heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{
Actor: heartbeaterHolder, IssueID: id, ExpectedVersion: &revision,
Patch: publicops.IssuePatch{Notes: publicops.Field[string]{Set: true, Value: "after two heartbeats"}},
}); err != nil {
t.Fatalf("guarded write with the claim's revision after heartbeats = %v, want it to land", err)
}
}
// RunHeartbeaterRefusesAForeignHolder pins the fence (Heartbeater REFUSALS:
// "an issue another actor holds: a *LeaseConflictError naming the Holder,
// wrapping ErrAlreadyClaimed"), and that the refusal writes nothing.
func RunHeartbeaterRefusesAForeignHolder(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
id := fixture.IssuePrefix + "-foreign"
heartbeaterSeedClaimed(t, ctx, fixture, id)
// Age the holder's lease first, so a heartbeat that ignored the holder
// fence would really CHANGE the row (some engines count only changed rows,
// and the columns hold whole seconds: an unaged row refreshed in the
// claim's second changes nothing and would hide the missing fence).
aged := time.Now().UTC().Add(-time.Minute).Truncate(time.Second)
if err := fixture.Exec(ctx, []SQLStatement{{
Query: "UPDATE leases SET lease_expires_at = ?, heartbeat_at = ? WHERE issue_id = ?",
Args: []any{aged, aged, id},
}}); err != nil {
t.Fatalf("age the lease on %s: %v", id, err)
}
lease := heartbeaterScalar[string](t, ctx, fixture, "SELECT CONCAT(CAST(lease_expires_at AS CHAR), '|', CAST(heartbeat_at AS CHAR), '|', holder) FROM leases WHERE issue_id = ?", id)
_, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterIntruder, IssueID: id})
if !errors.Is(err, publicops.ErrAlreadyClaimed) {
t.Fatalf("heartbeat by a non-holder = %v, want ErrAlreadyClaimed", err)
}
if errors.Is(err, publicops.ErrLeaseNotHeld) {
t.Fatalf("heartbeat by a non-holder = %v also matches ErrLeaseNotHeld; the two refusals must stay distinct", err)
}
conflict := heartbeaterConflict(t, err)
if conflict.IssueID != id || conflict.Holder != heartbeaterHolder || conflict.Status != types.StatusInProgress {
t.Fatalf("LeaseConflictError = %+v, want {IssueID:%s Holder:%s Status:%s}", conflict, id, heartbeaterHolder, types.StatusInProgress)
}
if got := heartbeaterScalar[string](t, ctx, fixture, "SELECT CONCAT(CAST(lease_expires_at AS CHAR), '|', CAST(heartbeat_at AS CHAR), '|', holder) FROM leases WHERE issue_id = ?", id); got != lease {
t.Fatalf("a refused heartbeat moved the holder's lease from %s to %s", lease, got)
}
}
// RunHeartbeaterCommitsOnlyItsOwnTables pins the commit discipline against a
// DIRTY working set (Heartbeater: "A REFRESH WRITES ONLY THE LEASE ROW"; "A
// RE-ARM IS RECORDED AS A MUTATION"): another writer has left an uncommitted
// versioned change (a batch-mode edit, here a config row). A refresh and a
// refusal make no version-control commit and leave that change uncommitted;
// a re-arm makes exactly one commit, of its own tables, and still leaves the
// other writer's change uncommitted rather than sweeping it in under the
// heartbeat's message.
func RunHeartbeaterCommitsOnlyItsOwnTables(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
if fixture.CountHistory == nil || fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.CountHistory/Lifecycle is nil: this backend has no version-control history to observe")
}
refreshed := fixture.IssuePrefix + "-dirty-refresh"
heartbeaterSeedClaimed(t, ctx, fixture, refreshed)
refused := fixture.IssuePrefix + "-dirty-refused"
heartbeaterSeed(t, ctx, fixture, refused)
rearmed := fixture.IssuePrefix + "-dirty-rearm"
heartbeaterSeed(t, ctx, fixture, rearmed)
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{
Actor: heartbeaterHolder, IssueID: rearmed,
Patch: publicops.IssuePatch{
Status: publicops.Field[publicops.Status]{Set: true, Value: types.StatusInProgress},
Assignee: publicops.Field[string]{Set: true, Value: heartbeaterHolder},
},
}); err != nil {
t.Fatalf("hand-dole %s: %v", rearmed, err)
}
probe := "heartbeat.dirty-probe." + fixture.IssuePrefix
dirty := fixture.Exec
if fixture.ExecUncommitted != nil {
dirty = fixture.ExecUncommitted
}
if err := dirty(ctx, []SQLStatement{{
Query: "REPLACE INTO config (`key`, value) VALUES (?, ?)", Args: []any{probe, "uncommitted"},
}}); err != nil {
t.Fatalf("dirty the working set: %v", err)
}
defer func() {
_ = dirty(ctx, []SQLStatement{{Query: "DELETE FROM config WHERE `key` = ?", Args: []any{probe}}})
}()
foreignDirty := func(when string) {
t.Helper()
if n := heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM dolt_status WHERE table_name = 'config'"); n == 0 {
t.Fatalf("%s: the other writer's uncommitted config change was committed; a heartbeat commits only its own tables", when)
}
}
history := func() int {
t.Helper()
n, err := fixture.CountHistory(ctx)
if err != nil {
t.Fatalf("CountHistory: %v", err)
}
return n
}
foreignDirty("before any heartbeat")
before := history()
heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: refreshed})
if got := history(); got != before {
t.Fatalf("a refresh moved the version-control history %d -> %d; a refresh makes no commit", before, got)
}
foreignDirty("after a refresh")
if _, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: refused}); err == nil {
t.Fatalf("heartbeat on unclaimed %s succeeded, want a refusal", refused)
}
if got := history(); got != before {
t.Fatalf("a refusal moved the version-control history %d -> %d; a refusal makes no commit", before, got)
}
foreignDirty("after a refusal")
if result := heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: rearmed}); !result.Rearmed {
t.Fatalf("heartbeat on hand-doled %s = %+v, want Rearmed", rearmed, result)
}
if got := history(); got != before+1 {
t.Fatalf("a re-arm moved the version-control history %d -> %d, want exactly one commit", before, got)
}
foreignDirty("after a re-arm")
}
// RunHeartbeaterRefusesAnOrphanedLeaseOnAReleasedIssue and
// ...OnAClosedIssue and ...OnAnIssueSomeoneElseHolds pin the live-claim
// predicate (Heartbeater: "THE LIVE-CLAIM FENCE IS A PREDICATE"): a lease row
// that names the caller but survives on an issue that is open, closed, or
// in_progress under another assignee is refused, never refreshed, and the
// refusal deletes it (Heartbeater: the one write a refusal makes). The row
// is planted raw: it is the state a re-arm racing a release or close leaves.
func RunHeartbeaterRefusesAnOrphanedLeaseOnAReleasedIssue(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
id := fixture.IssuePrefix + "-orphan-open"
heartbeaterSeed(t, ctx, fixture, id)
heartbeaterRefusesAnOrphan(t, ctx, fixture, id, types.StatusOpen, "")
}
func RunHeartbeaterRefusesAnOrphanedLeaseOnAClosedIssue(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
if fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.Lifecycle is nil: this backend cannot close the claim")
}
id := fixture.IssuePrefix + "-orphan-closed"
heartbeaterSeedClaimed(t, ctx, fixture, id)
if _, err := fixture.Lifecycle.Close(ctx, publicops.CloseRequest{Actor: heartbeaterHolder, IssueID: id, Reason: "done"}); err != nil {
t.Fatalf("close %s: %v", id, err)
}
heartbeaterRefusesAnOrphan(t, ctx, fixture, id, types.StatusClosed, "")
}
func RunHeartbeaterRefusesAnOrphanedLeaseOnAnIssueSomeoneElseHolds(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
requireHeartbeaterExec(t, fixture)
if fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.Lifecycle is nil: this backend cannot hand-dole a claim")
}
id := fixture.IssuePrefix + "-orphan-moved"
heartbeaterSeed(t, ctx, fixture, id)
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{
Actor: heartbeaterIntruder, IssueID: id,
Patch: publicops.IssuePatch{
Status: publicops.Field[publicops.Status]{Set: true, Value: types.StatusInProgress},
Assignee: publicops.Field[string]{Set: true, Value: heartbeaterIntruder},
},
}); err != nil {
t.Fatalf("hand-dole %s to %s: %v", id, heartbeaterIntruder, err)
}
heartbeaterRefusesAnOrphan(t, ctx, fixture, id, types.StatusInProgress, heartbeaterIntruder)
}
// heartbeaterRefusesAnOrphan plants a lease row for heartbeaterHolder on id
// (which the holder does not hold), heartbeats as the holder, and asserts the
// refusal and that the row is gone.
func heartbeaterRefusesAnOrphan(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string, status types.Status, foreign string) {
t.Helper()
now := time.Now().UTC().Truncate(time.Second)
if err := fixture.Exec(ctx, []SQLStatement{
{Query: "DELETE FROM leases WHERE issue_id = ?", Args: []any{id}},
{
Query: "INSERT INTO leases (issue_id, holder, granted_at, lease_expires_at, heartbeat_at, granted_node) VALUES (?, ?, ?, ?, ?, '')",
Args: []any{id, heartbeaterHolder, now.Add(-time.Minute), now.Add(time.Hour), now.Add(-time.Minute)},
},
}); err != nil {
t.Fatalf("plant an orphaned lease on %s: %v", id, err)
}
_, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
conflict := heartbeaterConflict(t, err)
if foreign != "" {
if !errors.Is(err, publicops.ErrAlreadyClaimed) || conflict.Holder != foreign {
t.Fatalf("heartbeat over an orphaned lease on an issue %s holds = %v (%+v), want ErrAlreadyClaimed naming %s", foreign, err, conflict, foreign)
}
} else if !errors.Is(err, publicops.ErrLeaseNotHeld) || conflict.Holder != "" {
t.Fatalf("heartbeat over an orphaned lease on a %s issue = %v (%+v), want ErrLeaseNotHeld", status, err, conflict)
}
if conflict.IssueID != id || conflict.Status != status || conflict.Ephemeral {
t.Fatalf("LeaseConflictError = %+v, want {IssueID:%s Status:%s Ephemeral:false}", conflict, id, status)
}
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 0 {
t.Fatalf("lease rows on %s after the refusal = %d, want 0: a refusal deletes the caller's orphaned lease", id, n)
}
// And it stays refused: the next heartbeat finds no row to refresh.
if _, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id}); err == nil {
t.Fatalf("a second heartbeat on %s succeeded after the orphan was refused", id)
}
}
// heartbeaterRequireStoredMatches pins the reported times to the stored row
// (LeaseRenewal: "exactly what the lease row now holds"): lease_expires_at and
// heartbeat_at as stored are the result's, within the columns' one-second
// precision, and the stored expiry is the call's clock plus the store's TTL.
func heartbeaterRequireStoredMatches(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string, result publicops.HeartbeatResult, before, after time.Time) {
t.Helper()
window := func(at time.Time) (time.Time, time.Time) { return at.Add(-time.Second), at.Add(time.Second) }
hbLo, hbHi := window(result.HeartbeatAt)
exLo, exHi := window(result.LeaseExpiresAt)
if n := heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM leases WHERE issue_id = ? AND holder = ? AND heartbeat_at BETWEEN ? AND ? AND lease_expires_at BETWEEN ? AND ?",
id, result.Holder, hbLo, hbHi, exLo, exHi); n != 1 {
t.Fatalf("the stored lease row on %s does not hold the reported heartbeat_at %v and lease_expires_at %v (within 1s)",
id, result.HeartbeatAt, result.LeaseExpiresAt)
}
ttlLo, ttlHi := before.Add(storeops.DefaultLeaseTTL), after.Add(storeops.DefaultLeaseTTL)
if n := heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM leases WHERE issue_id = ? AND lease_expires_at BETWEEN ? AND ?",
id, ttlLo, ttlHi); n != 1 {
t.Fatalf("the stored lease_expires_at on %s is not the call's clock plus the lease TTL %v", id, storeops.DefaultLeaseTTL)
}
if !result.HeartbeatAt.Equal(result.HeartbeatAt.Truncate(time.Second)) || !result.LeaseExpiresAt.Equal(result.LeaseExpiresAt.Truncate(time.Second)) {
t.Fatalf("result times %v / %v carry sub-second digits the lease columns cannot hold", result.HeartbeatAt, result.LeaseExpiresAt)
}
}
// RunHeartbeaterRefusesAfterClose, ...AfterRelease, ...AfterReclaim and
// ...AfterStatusMovedOffInProgress pin the in_progress fence through the
// lease-row invariant (Heartbeater: "a lease row exists only while its issue
// is in_progress with that holder as assignee"): each ends the claim one way,
// asserts the lease row went with it, and that the former holder's heartbeat
// is refused with ErrLeaseNotHeld, which also matches ErrNotClaimable.
func RunHeartbeaterRefusesAfterClose(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.Lifecycle is nil: this backend cannot close the claim")
}
heartbeaterRefusesAfter(t, ctx, fixture, "closed", types.StatusClosed, func(id string) error {
_, err := fixture.Lifecycle.Close(ctx, publicops.CloseRequest{Actor: heartbeaterHolder, IssueID: id, Reason: "done"})
return err
})
}
func RunHeartbeaterRefusesAfterRelease(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Releaser == nil {
t.Skip("HeartbeaterFixture.Releaser is nil: this backend cannot release the claim")
}
heartbeaterRefusesAfter(t, ctx, fixture, "released", types.StatusOpen, func(id string) error {
_, err := fixture.Releaser.Release(ctx, publicops.ReleaseRequest{Actor: heartbeaterHolder, IssueID: id})
return err
})
}
func RunHeartbeaterRefusesAfterReclaim(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.LeaseReclaimer == nil || fixture.Exec == nil {
t.Skip("HeartbeaterFixture.LeaseReclaimer/Exec is nil: this backend cannot reclaim the claim")
}
heartbeaterRefusesAfter(t, ctx, fixture, "reclaimed", types.StatusOpen, func(id string) error {
if err := fixture.Exec(ctx, []SQLStatement{{
Query: "UPDATE leases SET lease_expires_at = ? WHERE issue_id = ?",
Args: []any{time.Now().UTC().Add(-time.Hour), id},
}}); err != nil {
return err
}
result, err := fixture.LeaseReclaimer.Reclaim(ctx, publicops.ReclaimRequest{
Actor: heartbeaterReaper, Filter: publicops.ReclaimFilter{IDs: []string{id}},
})
if err == nil && len(result.Reclaimed) != 1 {
t.Fatalf("Reclaimed = %+v, want exactly %s", result.Reclaimed, id)
}
return err
})
}
func RunHeartbeaterRefusesAfterStatusMovedOffInProgress(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Lifecycle == nil {
t.Skip("HeartbeaterFixture.Lifecycle is nil: this backend cannot move the status")
}
heartbeaterRefusesAfter(t, ctx, fixture, "blocked", types.StatusBlocked, func(id string) error {
_, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{
Actor: heartbeaterHolder, IssueID: id,
Patch: publicops.IssuePatch{Status: publicops.Field[publicops.Status]{Set: true, Value: types.StatusBlocked}},
})
return err
})
}
// RunHeartbeaterRefusesAWisp pins the plane rule (Heartbeater REFUSALS: "a
// wisp ... ErrLeaseNotHeld"): wisps are never leased, so even a wisp the
// caller holds in_progress is refused, and no lease row appears for it.
func RunHeartbeaterRefusesAWisp(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.CreateWisp == nil || fixture.QueryScalar == nil {
t.Skip("HeartbeaterFixture.CreateWisp/QueryScalar is nil: this backend cannot seed a wisp")
}
id := fixture.IssuePrefix + "-wisp"
if err := fixture.CreateWisp(ctx, &types.Issue{
ID: id, Title: id, Status: types.StatusInProgress, Assignee: heartbeaterHolder,
Priority: 2, IssueType: types.TypeTask, Ephemeral: true,
}, "seed"); err != nil {
t.Fatalf("seed wisp %s: %v", id, err)
}
_, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
if !errors.Is(err, publicops.ErrLeaseNotHeld) || !errors.Is(err, publicops.ErrNotClaimable) {
t.Fatalf("heartbeat on a wisp = %v, want ErrLeaseNotHeld matching ErrNotClaimable", err)
}
if !strings.Contains(err.Error(), "ephemeral") {
t.Fatalf("heartbeat on a wisp = %q, want the refusal to say the issue is ephemeral", err)
}
if conflict := heartbeaterConflict(t, err); conflict.IssueID != id || conflict.Holder != "" {
t.Fatalf("LeaseConflictError = %+v, want {IssueID:%s Holder:\"\"}", conflict, id)
}
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 0 {
t.Fatalf("lease rows for wisp %s = %d, want 0: wisps are never leased", id, n)
}
}
// RunHeartbeaterRearmsAHandDoledClaim pins the self-heal (HeartbeatResult.
// Rearmed): an issue put in_progress with the caller as assignee by a generic
// update holds no lease row, and the holder's heartbeat grants one rather than
// refusing. The re-arm is recorded as a mutation (Heartbeater: "A RE-ARM IS
// RECORDED AS A MUTATION"): it remints the revision, which is what makes it
// collide with a racing release or close, and records a lease_rearmed event;
// the refresh after it does neither.
func RunHeartbeaterRearmsAHandDoledClaim(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Lifecycle == nil || fixture.QueryScalar == nil {
t.Skip("HeartbeaterFixture.Lifecycle/QueryScalar is nil: this backend cannot hand-dole a claim")
}
id := fixture.IssuePrefix + "-doled"
heartbeaterSeed(t, ctx, fixture, id)
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{
Actor: heartbeaterHolder, IssueID: id,
Patch: publicops.IssuePatch{
Status: publicops.Field[publicops.Status]{Set: true, Value: types.StatusInProgress},
Assignee: publicops.Field[string]{Set: true, Value: heartbeaterHolder},
},
}); err != nil {
t.Fatalf("hand-dole %s: %v", id, err)
}
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 0 {
t.Fatalf("lease rows after a generic update = %d, want 0: the case needs a claim with no lease", n)
}
revision := heartbeaterScalar[int64](t, ctx, fixture, "SELECT row_lock FROM issues WHERE id = ?", id)
before := time.Now().UTC().Add(-time.Second)
result := heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
after := time.Now().UTC().Add(time.Second)
if !result.Rearmed || result.Holder != heartbeaterHolder {
t.Fatalf("result = %+v, want Rearmed:true Holder:%s", result, heartbeaterHolder)
}
heartbeaterRequireStoredMatches(t, ctx, fixture, id, result, before, after)
if n := heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM leases WHERE issue_id = ? AND holder = ? AND lease_expires_at > ?",
id, heartbeaterHolder, time.Now().UTC()); n != 1 {
t.Fatal("the re-armed heartbeat left no live lease row for the holder")
}
rearmed := heartbeaterScalar[int64](t, ctx, fixture, "SELECT row_lock FROM issues WHERE id = ?", id)
if rearmed == revision {
t.Fatalf("row_lock stayed %d across a re-arming heartbeat; a re-arm remints it so a racing release or close collides with it", revision)
}
rearmEvents := func() int {
return heartbeaterScalar[int](t, ctx, fixture,
"SELECT COUNT(*) FROM events WHERE issue_id = ? AND event_type = ?", id, string(types.EventLeaseRearmed))
}
if n := rearmEvents(); n != 1 {
t.Fatalf("lease_rearmed events on %s after a re-arm = %d, want 1: a re-arm is recorded as a mutation", id, n)
}
// The next heartbeat refreshes the lease it just granted: no re-arm, and
// no revision change.
if again := heartbeat(t, ctx, fixture.Heartbeater, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id}); again.Rearmed {
t.Fatalf("second heartbeat after the re-arm = %+v, want Rearmed:false", again)
}
if got := heartbeaterScalar[int64](t, ctx, fixture, "SELECT row_lock FROM issues WHERE id = ?", id); got != rearmed {
t.Fatalf("row_lock moved from %d to %d across a refresh after the re-arm", rearmed, got)
}
if n := rearmEvents(); n != 1 {
t.Fatalf("lease_rearmed events on %s after a refresh = %d, want still 1: a refresh records nothing", id, n)
}
}
// RunHeartbeaterAnswersNotFoundForAnAbsentID pins Heartbeater REFUSALS: "an
// IssueID that names no row on either plane: ErrNotFound".
func RunHeartbeaterAnswersNotFoundForAnAbsentID(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
_, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{
Actor: heartbeaterHolder, IssueID: fixture.IssuePrefix + "-absent",
})
if !errors.Is(err, publicops.ErrNotFound) {
t.Fatalf("heartbeat on an absent id = %v, want ErrNotFound", err)
}
}
// RunHeartbeaterRefusesABlankOrOverLongActor pins the request rules
// (HeartbeatRequest.Actor, Heartbeater REFUSALS): each is a
// *HeartbeatFieldError naming its field, matching ErrValidation.
func RunHeartbeaterRefusesABlankOrOverLongActor(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
id := fixture.IssuePrefix + "-refusals"
for _, test := range []struct {
name string
request publicops.HeartbeatRequest
field string
}{
{"an empty actor", publicops.HeartbeatRequest{IssueID: id}, publicops.HeartbeatFieldActor},
{"a blank actor", publicops.HeartbeatRequest{Actor: " \t", IssueID: id}, publicops.HeartbeatFieldActor},
{"an over-long actor", publicops.HeartbeatRequest{Actor: strings.Repeat("a", types.MaxFieldLen+1), IssueID: id}, publicops.HeartbeatFieldActor},
{"an empty id", publicops.HeartbeatRequest{Actor: heartbeaterHolder}, publicops.HeartbeatFieldIssueID},
} {
t.Run(test.name, func(t *testing.T) {
_, err := fixture.Heartbeater.Heartbeat(ctx, test.request)
if !errors.Is(err, publicops.ErrValidation) {
t.Fatalf("Heartbeat(%s) = %v, want ErrValidation", test.name, err)
}
var field *publicops.HeartbeatFieldError
if !errors.As(err, &field) || field.Field != test.field {
t.Fatalf("Heartbeat(%s) = %v, want a *HeartbeatFieldError naming %q", test.name, err, test.field)
}
})
}
}
// RunHeartbeaterDoesNotMutateTheRequest pins the role's "never mutate
// caller-owned request values".
func RunHeartbeaterDoesNotMutateTheRequest(t *testing.T, ctx context.Context, fixture HeartbeaterFixture) {
t.Helper()
id := fixture.IssuePrefix + "-nomutate"
heartbeaterSeedClaimed(t, ctx, fixture, id)
request := publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id}
want := request
heartbeat(t, ctx, fixture.Heartbeater, request)
if request != want {
t.Fatalf("request after Heartbeat = %+v, want %+v", request, want)
}
}
// heartbeaterRefusesAfter seeds and claims one issue, ends the claim with end,
// and asserts the invariant and the refusal.
func heartbeaterRefusesAfter(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, suffix string, status types.Status, end func(id string) error) {
t.Helper()
if fixture.QueryScalar == nil {
t.Skip("HeartbeaterFixture.QueryScalar is nil: this backend cannot read the lease row")
}
id := fixture.IssuePrefix + "-after-" + suffix
heartbeaterSeedClaimed(t, ctx, fixture, id)
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 1 {
t.Fatalf("lease rows for claimed %s = %d, want 1", id, n)
}
if err := end(id); err != nil {
t.Fatalf("end the claim on %s (%s): %v", id, suffix, err)
}
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 0 {
t.Fatalf("lease rows for %s %s = %d, want 0: the path that ended the claim left its lease row", suffix, id, n)
}
_, err := fixture.Heartbeater.Heartbeat(ctx, publicops.HeartbeatRequest{Actor: heartbeaterHolder, IssueID: id})
if !errors.Is(err, publicops.ErrLeaseNotHeld) || !errors.Is(err, publicops.ErrNotClaimable) {
t.Fatalf("heartbeat after the claim was %s = %v, want ErrLeaseNotHeld matching ErrNotClaimable", suffix, err)
}
if errors.Is(err, publicops.ErrAlreadyClaimed) {
t.Fatalf("heartbeat after the claim was %s = %v also matches ErrAlreadyClaimed", suffix, err)
}
conflict := heartbeaterConflict(t, err)
if conflict.IssueID != id || conflict.Holder != "" || conflict.Status != status {
t.Fatalf("LeaseConflictError = %+v, want {IssueID:%s Holder:\"\" Status:%s}", conflict, id, status)
}
if n := heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM leases WHERE issue_id = ?", id); n != 0 {
t.Fatalf("a refused heartbeat left %d lease row(s) for %s", n, id)
}
}
// heartbeaterRowSnapshot is every durable trace a heartbeat must not leave.
// A field the backend cannot observe holds -1.
type heartbeaterRowSnapshot struct {
RowLock int64
CurrentRevision int64
UpdatedAt string
Events int
JournalMaxSeq int64
IssueVersions int
History int
}
func heartbeaterSnapshot(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string) heartbeaterRowSnapshot {
t.Helper()
snap := heartbeaterRowSnapshot{
RowLock: heartbeaterScalar[int64](t, ctx, fixture, "SELECT row_lock FROM issues WHERE id = ?", id),
CurrentRevision: heartbeaterScalar[int64](t, ctx, fixture, "SELECT current_revision FROM issues WHERE id = ?", id),
UpdatedAt: heartbeaterScalar[string](t, ctx, fixture, "SELECT CAST(updated_at AS CHAR) FROM issues WHERE id = ?", id),
Events: heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM events WHERE issue_id = ?", id),
JournalMaxSeq: -1,
IssueVersions: -1,
History: -1,
}
if fixture.SetJournalEnabled != nil {
snap.JournalMaxSeq = heartbeaterScalar[int64](t, ctx, fixture, "SELECT COALESCE(MAX(seq), 0) FROM bd_events_journal")
}
if fixture.SetVersionedHistoryEnabled != nil {
snap.IssueVersions = heartbeaterScalar[int](t, ctx, fixture, "SELECT COUNT(*) FROM issue_versions WHERE issue_id = ?", id)
}
if fixture.CountHistory != nil {
n, err := fixture.CountHistory(ctx)
if err != nil {
t.Fatalf("CountHistory: %v", err)
}
snap.History = n
}
return snap
}
func heartbeaterFired(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string) int {
t.Helper()
if fixture.HookedHeartbeater == nil || fixture.FiredUpdates == nil {
return 0
}
ids, err := fixture.FiredUpdates(ctx)
if err != nil {
t.Fatalf("FiredUpdates: %v", err)
}
n := 0
for _, fired := range ids {
if fired == id {
n++
}
}
return n
}
func requireHeartbeaterExec(t *testing.T, fixture HeartbeaterFixture) {
t.Helper()
if fixture.Exec == nil || fixture.QueryScalar == nil {
t.Skip("HeartbeaterFixture.Exec/QueryScalar is nil: this backend cannot read or age a lease row")
}
}
func heartbeaterSeed(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string) {
t.Helper()
if err := fixture.CreateIssue(ctx, &types.Issue{
ID: id, Title: id, Status: types.StatusOpen, Priority: 2, IssueType: types.TypeTask,
}, "seed"); err != nil {
t.Fatalf("seed %s: %v", id, err)
}
}
// heartbeaterSeedClaimed creates id and claims it as heartbeaterHolder through
// the leg's Claimer, answering the claim's row version.
func heartbeaterSeedClaimed(t *testing.T, ctx context.Context, fixture HeartbeaterFixture, id string) int64 {
t.Helper()
if fixture.Claimer == nil {
t.Skip("HeartbeaterFixture.Claimer is nil: this backend cannot take the claim a heartbeat refreshes")
}
heartbeaterSeed(t, ctx, fixture, id)
claimed, err := fixture.Claimer.Claim(ctx, publicops.ClaimRequest{Actor: heartbeaterHolder, IssueID: id})
if err != nil {
t.Fatalf("claim %s as %s: %v", id, heartbeaterHolder, err)
}
if claimed.Issue == nil {
t.Fatalf("claim %s answered no issue", id)
}
return claimed.Issue.RowVersion
}
func heartbeat(t *testing.T, ctx context.Context, surface publicops.Heartbeater, request publicops.HeartbeatRequest) publicops.HeartbeatResult {
t.Helper()
result, err := surface.Heartbeat(ctx, request)
if err != nil {
t.Fatalf("Heartbeat(%+v): %v", request, err)
}
return result
}
func heartbeaterConflict(t *testing.T, err error) *publicops.LeaseConflictError {
t.Helper()
var conflict *publicops.LeaseConflictError
if !errors.As(err, &conflict) {
t.Fatalf("refusal %v (%T) is not a *LeaseConflictError", err, err)
}
return conflict
}
func heartbeaterScalar[T any](t *testing.T, ctx context.Context, fixture HeartbeaterFixture, query string, args ...any) T {
t.Helper()
var value T
if err := fixture.QueryScalar(ctx, query, args, &value); err != nil {
t.Fatalf("%s %v: %v", query, args, err)
}
return value
}
func heartbeaterAbs(d time.Duration) time.Duration {
if d < 0 {
return -d
}
return d
}

View file

@ -490,12 +490,6 @@ func RunLifecycleCreateWritesEveryScalarField(t *testing.T, ctx context.Context,
t.Errorf("%s created_at = %v after a create that named none, want a stamp between %v and %v — a bare non-empty check would accept the zero time",
stamped, autoStamp, lower, upper)
}
// And no created_by: the request's actor is the creator (CreateRequest.Issue),
// stamped by the role itself, so a library caller and every front door store
// the same value for the same request.
if got := lifecycleCreateRow(t, ctx, fixture, stamped).CreatedBy; got != "writer" {
t.Errorf("%s created_by = %q after a create that named none, want the request's actor %q", stamped, got, "writer")
}
want := []lifecycleCreateMember{
{"title", "created title"},

View file

@ -1,170 +0,0 @@
package conformance
import (
"context"
"errors"
"fmt"
"strings"
"testing"
"time"
"github.com/steveyegge/beads/internal/types"
publicops "github.com/steveyegge/beads/issueops"
)
// This file and its two siblings (lifecycle_update_gate_contract.go,
// batch_apply_gate_contract.go) hold the gate-member clauses of Lifecycle.Create,
// Lifecycle.Update and BatchApplier: await_type, await_id, timeout and waiters
// on a create, await_id and waiters on a patch, and the one set of bounds every
// route refuses with a *publicops.GateFieldError.
//
// THE BOUNDS ARE THE COLUMNS', and the boundary is asserted from both sides: a
// value AT the bound lands whole, a value one past it is refused naming its
// member and writes nothing. await_type is VARCHAR(32) and await_id
// VARCHAR(255), both counted in characters, so each at-bound value is
// multi-byte — a byte count would refuse it. waiters is a TEXT column holding
// a JSON array, bounded in BYTES. A negative timeout is the one refusal that is
// not a width.
//
// NOTHING ELSE IS A RULE, and two cases say so: a gate member lands on an
// issue of any type (local `bd update --await-id` has always worked on any
// row), and waiters are stored as given, duplicates included (deduplication is
// the CLI's). A backend that grew a stricter rule fails here.
// gateFieldAtBoundAwaitType is a 32-character, 64-byte await_type.
var gateFieldAtBoundAwaitType = strings.Repeat("é", 32)
// gateFieldAtBoundAwaitID is a 255-character, 510-byte await_id.
var gateFieldAtBoundAwaitID = strings.Repeat("é", types.MaxFieldLen)
// gateFieldAtBoundWaiters is one waiter whose JSON array encoding is exactly
// types.MaxTextBytes bytes: the entry plus `["` and `"]`.
func gateFieldAtBoundWaiters() []string {
return []string{strings.Repeat("w", types.MaxTextBytes-4)}
}
// gateFieldOverBoundWaiters encodes to one byte past the TEXT column.
func gateFieldOverBoundWaiters() []string {
return []string{strings.Repeat("w", types.MaxTextBytes-3)}
}
// assertGateFieldError checks err is ErrValidation carried by a
// *publicops.GateFieldError naming field.
func assertGateFieldError(t *testing.T, err error, label, field string) {
t.Helper()
if !errors.Is(err, publicops.ErrValidation) {
t.Fatalf("%s: error = %v, want ErrValidation", label, err)
}
var fieldErr *publicops.GateFieldError
if !errors.As(err, &fieldErr) {
t.Fatalf("%s: error = %v, want a *GateFieldError naming %s", label, err, field)
}
if fieldErr.Field != field {
t.Errorf("%s: GateFieldError.Field = %q, want %q", label, fieldErr.Field, field)
}
}
// gateMembers renders the four gate members off an issue for comparison.
func gateMembers(issue *types.Issue) string {
waiters := issue.Waiters
if len(waiters) == 0 {
waiters = nil
}
return fmt.Sprintf("await_type=%q await_id=%q timeout=%s waiters=%q", issue.AwaitType, issue.AwaitID, issue.Timeout, waiters)
}
func assertGateMembers(t *testing.T, id, label string, issue *types.Issue, awaitType, awaitID string, timeout time.Duration, waiters []string) {
t.Helper()
if issue == nil {
t.Fatalf("%s %s: no issue to read the gate members off", id, label)
}
if len(waiters) == 0 {
waiters = nil
}
want := fmt.Sprintf("await_type=%q await_id=%q timeout=%s waiters=%q", awaitType, awaitID, timeout, waiters)
if got := gateMembers(issue); got != want {
// The at-bound values are long; report sizes rather than the values.
if len(got)+len(want) > 2000 {
t.Errorf("%s %s gate members differ (got %d bytes, want %d bytes; await_type %d/%d runes, await_id %d/%d runes, waiters %d/%d entries)",
id, label, len(got), len(want),
len([]rune(issue.AwaitType)), len([]rune(awaitType)), len([]rune(issue.AwaitID)), len([]rune(awaitID)),
len(issue.Waiters), len(waiters))
return
}
t.Errorf("%s %s gate members = %s, want %s", id, label, got, want)
}
}
// RunLifecycleCreateWritesTheGateMembers pins that Lifecycle.Create stores all
// four gate members (CreateRequest.Issue's "gate" fields) on the row and
// answers them on the result, with the waiter list stored as given, duplicate
// included, and on an issue that is not of the gate type.
func RunLifecycleCreateWritesTheGateMembers(t *testing.T, ctx context.Context, fixture LifecycleCreateFixture) {
t.Helper()
gate := fixture.IssuePrefix + "-lcg-gate"
issue := lifecycleCreateIssue(gate)
issue.IssueType = types.TypeGate
issue.AwaitType = "gh:run"
issue.AwaitID = "12345"
issue.Timeout = 90 * time.Minute
issue.Waiters = []string{"rig/workers/a", "rig/workers/b", "rig/workers/a"}
created, err := fixture.Lifecycle.Create(ctx, publicops.CreateRequest{Actor: "writer", ForceIDPrefix: true, Issue: issue})
if err != nil {
t.Fatalf("create gate %s: %v", gate, err)
}
want := []string{"rig/workers/a", "rig/workers/b", "rig/workers/a"}
assertGateMembers(t, gate, "in the create result", created.Issue, "gh:run", "12345", 90*time.Minute, want)
assertGateMembers(t, gate, "in the stored row", lifecycleCreateRow(t, ctx, fixture, gate), "gh:run", "12345", 90*time.Minute, want)
// Any type carries them: no gate-type-only rule.
task := fixture.IssuePrefix + "-lcg-task"
carrier := lifecycleCreateIssue(task)
carrier.AwaitType = "formula-defined"
carrier.AwaitID = "bead:" + gate
carrier.Waiters = []string{"mail:someone"}
if _, err := fixture.Lifecycle.Create(ctx, publicops.CreateRequest{Actor: "writer", ForceIDPrefix: true, Issue: carrier}); err != nil {
t.Fatalf("create task %s carrying gate members: %v", task, err)
}
assertGateMembers(t, task, "in the stored row", lifecycleCreateRow(t, ctx, fixture, task), "formula-defined", "bead:"+gate, 0, []string{"mail:someone"})
}
// RunLifecycleCreateBoundsTheGateMembers pins the four GateFieldError bounds
// on create from both sides: each at-bound value lands whole, each value one
// past it is refused as ErrValidation naming its member, and the refused
// create leaves no row.
func RunLifecycleCreateBoundsTheGateMembers(t *testing.T, ctx context.Context, fixture LifecycleCreateFixture) {
t.Helper()
atBound := fixture.IssuePrefix + "-lcg-atbound"
issue := lifecycleCreateIssue(atBound)
issue.IssueType = types.TypeGate
issue.AwaitType = gateFieldAtBoundAwaitType
issue.AwaitID = gateFieldAtBoundAwaitID
issue.Timeout = 0
issue.Waiters = gateFieldAtBoundWaiters()
if _, err := fixture.Lifecycle.Create(ctx, publicops.CreateRequest{Actor: "writer", ForceIDPrefix: true, Issue: issue}); err != nil {
t.Fatalf("create %s with every gate member at its bound: %v", atBound, err)
}
assertGateMembers(t, atBound, "in the stored row", lifecycleCreateRow(t, ctx, fixture, atBound),
gateFieldAtBoundAwaitType, gateFieldAtBoundAwaitID, 0, gateFieldAtBoundWaiters())
for _, test := range []struct {
name string
field string
mutate func(*types.Issue)
}{
{"await_type", publicops.GateFieldAwaitType, func(i *types.Issue) { i.AwaitType = gateFieldAtBoundAwaitType + "x" }},
{"await_id", publicops.GateFieldAwaitID, func(i *types.Issue) { i.AwaitID = gateFieldAtBoundAwaitID + "x" }},
{"timeout", publicops.GateFieldTimeout, func(i *types.Issue) { i.Timeout = -time.Nanosecond }},
{"waiters", publicops.GateFieldWaiters, func(i *types.Issue) { i.Waiters = gateFieldOverBoundWaiters() }},
} {
id := fixture.IssuePrefix + "-lcg-over-" + strings.ReplaceAll(test.name, "_", "")
refused := lifecycleCreateIssue(id)
refused.IssueType = types.TypeGate
test.mutate(refused)
_, err := fixture.Lifecycle.Create(ctx, publicops.CreateRequest{Actor: "writer", ForceIDPrefix: true, Issue: refused})
assertGateFieldError(t, err, "create with "+test.name+" past its bound", test.field)
assertLifecycleCreateAbsent(t, ctx, fixture, id, "after the refused "+test.name)
}
}

View file

@ -6,7 +6,6 @@ import (
"errors"
"fmt"
"reflect"
"slices"
"sort"
"sync"
"testing"
@ -1920,10 +1919,10 @@ func RunLifecycleUpdateParentIDReplacesEveryParent(t *testing.T, ctx context.Con
// RunLifecycleUpdatePersistentPreservesUnversionedClass pins the half of the
// Persistence clause nobody else asserts: "Persistent preserves an existing
// durable unversioned class" (issueops/issueops.go:149). The refusal beside
// it — an unversioned row cannot be demoted to a wisp mode — is
// RunLifecycleUpdateWispModesRefuseAnUnversionedRow; this clause says the legal
// direction is a no-op that does NOT normalize the row into versioned storage.
// durable unversioned class" (issueops/issueops.go:135-136). The refusal beside
// it — an unversioned row cannot be demoted to a wisp mode — is pinned
// elsewhere; this clause says the legal direction is a no-op that does NOT
// normalize the row into versioned storage.
//
// WHAT A PERSISTENCE RESTATEMENT MUST NOT DO is where the two observations come
// in. A persistence MOVE deletes the row from one plane and re-inserts it into
@ -1964,90 +1963,6 @@ func RunLifecycleUpdatePersistentPreservesUnversionedClass(t *testing.T, ctx con
assertLifecycleUpdateWispAbsent(t, ctx, fixture, id, "after the persistent restatement")
}
// RunLifecycleUpdateWispModesRefuseAnUnversionedRow pins the refusal beside
// that clause: Ephemeral and NoHistory "select wisp retention modes, never
// durable unversioned storage" (issueops/issueops.go:150-151), so an
// unversioned row asked for either is refused. The refusal is the request's,
// a deterministic validation failure, so it matches ErrValidation on every
// leg — over http that is the 400 naming the patch rather than a 500 that
// drops the reason and alerts the operator — and it leaves the row where it
// was: durable, still unversioned, and absent from the wisp plane.
func RunLifecycleUpdateWispModesRefuseAnUnversionedRow(t *testing.T, ctx context.Context, fixture LifecycleUpdateFixture) {
t.Helper()
id := fixture.IssuePrefix + "-lup-unversioned-wisp"
seeded := lifecycleUpdateIssue(id)
seeded.StorageClass = types.StorageClassUnversioned
seedLifecycleUpdateIssue(t, ctx, fixture, seeded)
for _, mode := range []publicops.PersistenceMode{publicops.PersistenceModeEphemeral, publicops.PersistenceModeNoHistory} {
label := "after the refused " + string(mode) + " move"
before := lifecycleUpdateRow(t, ctx, fixture, id)
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
Persistence: publicops.Field[publicops.PersistenceMode]{Set: true, Value: mode},
}}); !errors.Is(err, storage.ErrValidation) {
t.Fatalf("move unversioned %s to %s: error = %v, want ErrValidation", id, mode, err)
}
assertLifecycleUpdateRowUnchanged(t, ctx, fixture, id, label, before)
after := lifecycleUpdateRow(t, ctx, fixture, id)
if after.Ephemeral || after.NoHistory || after.StorageClass != types.StorageClassUnversioned {
t.Errorf("%s %s = {ephemeral %v, no-history %v, class %q}, want the durable unversioned row it was",
id, label, after.Ephemeral, after.NoHistory, after.StorageClass)
}
assertLifecycleUpdateWispAbsent(t, ctx, fixture, id, label)
}
}
// RunLifecycleUpdatePersistentPromotesAWisp pins the move `bd promote` makes
// (issueops.Promote): Persistence = persistent on an ephemeral wisp is a
// MUTATION that leaves the row on the durable plane under the same id, with
// its labels carried across and nothing left behind on the wisp plane. A
// second identical request is the no-op the "same current mode" clause
// promises, which is how Promote tells a lost race from a promotion.
func RunLifecycleUpdatePersistentPromotesAWisp(t *testing.T, ctx context.Context, fixture LifecycleUpdateFixture) {
t.Helper()
if fixture.CreateWisp == nil {
t.Skip("fixture has no CreateWisp: this backend has no wisp plane to promote from")
}
id := fixture.IssuePrefix + "-lup-promote"
seedLifecycleUpdateWisp(t, ctx, fixture, lifecycleUpdateIssue(id, "keep-me"))
if got := lifecycleUpdateRow(t, ctx, fixture, id); !got.Ephemeral {
t.Fatalf("seeded %s is not ephemeral; the case has nothing to promote", id)
}
promote := publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
Persistence: publicops.Field[publicops.PersistenceMode]{Set: true, Value: publicops.PersistenceModePersistent},
}}
promoted, err := fixture.Lifecycle.Update(ctx, promote)
if err != nil {
t.Fatalf("promote %s: %v", id, err)
}
if !promoted.Changed {
t.Errorf("promoting wisp %s reported Changed = false, want a mutation", id)
}
if promoted.Issue == nil || promoted.Issue.ID != id || promoted.Issue.Ephemeral {
t.Errorf("promote result issue = %+v, want %s on the durable plane", promoted.Issue, id)
}
after := lifecycleUpdateRow(t, ctx, fixture, id)
if after.Ephemeral || after.NoHistory {
t.Errorf("%s came back {ephemeral %v, no-history %v} after the promotion, want a durable-plane row", id, after.Ephemeral, after.NoHistory)
}
if !slices.Contains(after.Labels, "keep-me") {
t.Errorf("%s labels after the promotion = %v, want the wisp's label carried across", id, after.Labels)
}
assertLifecycleUpdateWispAbsent(t, ctx, fixture, id, "after the promotion")
again, err := fixture.Lifecycle.Update(ctx, promote)
if err != nil {
t.Fatalf("re-promote %s: %v", id, err)
}
if again.Changed {
t.Errorf("re-promoting durable %s reported Changed = true, want the same-mode no-op", id)
}
}
// RunLifecycleUpdateProvenanceLabelsHistory pins UpdateRequest.Provenance
// against the history the backend actually writes
// (issueops/issueops.go:261-270): the entry reads as the caller's own string,

View file

@ -1,133 +0,0 @@
package conformance
import (
"context"
"testing"
"time"
publicops "github.com/steveyegge/beads/issueops"
)
// The patch half of the gate-member clauses; see lifecycle_create_gate_contract.go.
// RunLifecycleUpdatePatchesTheGateMembers pins IssuePatch.AwaitID and
// IssuePatch.Waiters: a set value lands and is answered on the result, waiters
// is a WHOLE-VALUE replacement stored as given (duplicates kept), a same-value
// patch is a no-op, a clear (empty await_id, nil waiters) empties both, and a
// second clear is a no-op. await_type and timeout are not patch members, so
// they ride through every edit untouched. The row is a task: no gate-type-only
// rule.
func RunLifecycleUpdatePatchesTheGateMembers(t *testing.T, ctx context.Context, fixture LifecycleUpdateFixture) {
t.Helper()
id := fixture.IssuePrefix + "-lug-gate"
seeded := lifecycleUpdateIssue(id)
seeded.AwaitType = "timer"
seeded.AwaitID = "seeded-await"
seeded.Timeout = time.Minute
seeded.Waiters = []string{"seeded"}
seedLifecycleUpdateIssue(t, ctx, fixture, seeded)
patch := publicops.IssuePatch{
AwaitID: publicops.Field[string]{Set: true, Value: "run-42"},
Waiters: publicops.Field[[]string]{Set: true, Value: []string{"w1", "w2", "w1"}},
}
wantWaiters := []string{"w1", "w2", "w1"}
updated, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: patch})
if err != nil {
t.Fatalf("patch the gate members of %s: %v", id, err)
}
if !updated.Changed {
t.Errorf("patching the gate members of %s reported Changed = false, want a committed edit", id)
}
assertGateMembers(t, id, "in the update result", updated.Issue, "timer", "run-42", time.Minute, wantWaiters)
assertGateMembers(t, id, "in the stored row", lifecycleUpdateRow(t, ctx, fixture, id), "timer", "run-42", time.Minute, wantWaiters)
after := lifecycleUpdateRow(t, ctx, fixture, id)
again, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: patch})
if err != nil {
t.Fatalf("re-apply the same gate patch to %s: %v", id, err)
}
if again.Changed {
t.Errorf("re-applying the same gate patch to %s reported Changed = true, want false", id)
}
assertLifecycleUpdateRowUnchanged(t, ctx, fixture, id, "after the same-value gate patch", after)
clear := publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
AwaitID: publicops.Field[string]{Set: true},
Waiters: publicops.Field[[]string]{Set: true},
}}
cleared, err := fixture.Lifecycle.Update(ctx, clear)
if err != nil {
t.Fatalf("clear the gate members of %s: %v", id, err)
}
if !cleared.Changed {
t.Errorf("clearing the gate members of %s reported Changed = false, want a committed edit", id)
}
assertGateMembers(t, id, "in the clear's result", cleared.Issue, "timer", "", time.Minute, nil)
assertGateMembers(t, id, "in the cleared row", lifecycleUpdateRow(t, ctx, fixture, id), "timer", "", time.Minute, nil)
afterClear := lifecycleUpdateRow(t, ctx, fixture, id)
reclear, err := fixture.Lifecycle.Update(ctx, clear)
if err != nil {
t.Fatalf("re-clear the gate members of %s: %v", id, err)
}
if reclear.Changed {
t.Errorf("re-clearing the already-empty gate members of %s reported Changed = true, want false", id)
}
assertLifecycleUpdateRowUnchanged(t, ctx, fixture, id, "after the re-clear", afterClear)
// An explicitly empty list clears exactly as a nil one does.
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
Waiters: publicops.Field[[]string]{Set: true, Value: []string{"back"}},
}}); err != nil {
t.Fatalf("re-set the waiters of %s: %v", id, err)
}
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
Waiters: publicops.Field[[]string]{Set: true, Value: []string{}},
}}); err != nil {
t.Fatalf("clear the waiters of %s with an empty list: %v", id, err)
}
assertGateMembers(t, id, "after the empty-list clear", lifecycleUpdateRow(t, ctx, fixture, id), "timer", "", time.Minute, nil)
}
// RunLifecycleUpdateBoundsTheGateMembers pins the patch half of the
// GateFieldError bounds from both sides: at-bound await_id and waiters land
// whole, one past either is refused as ErrValidation naming its member, and
// the refusal writes nothing — not the gate member, and not an ordinary member
// riding in the same patch.
func RunLifecycleUpdateBoundsTheGateMembers(t *testing.T, ctx context.Context, fixture LifecycleUpdateFixture) {
t.Helper()
id := fixture.IssuePrefix + "-lug-bounds"
seedLifecycleUpdateIssue(t, ctx, fixture, lifecycleUpdateIssue(id))
if _, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: publicops.IssuePatch{
AwaitID: publicops.Field[string]{Set: true, Value: gateFieldAtBoundAwaitID},
Waiters: publicops.Field[[]string]{Set: true, Value: gateFieldAtBoundWaiters()},
}}); err != nil {
t.Fatalf("patch %s with await_id and waiters at their bounds: %v", id, err)
}
assertGateMembers(t, id, "in the stored row", lifecycleUpdateRow(t, ctx, fixture, id), "", gateFieldAtBoundAwaitID, 0, gateFieldAtBoundWaiters())
before := lifecycleUpdateRow(t, ctx, fixture, id)
for _, test := range []struct {
name string
field string
patch publicops.IssuePatch
}{
{"await_id", publicops.GateFieldAwaitID, publicops.IssuePatch{
Title: publicops.Field[string]{Set: true, Value: "must not land"},
AwaitID: publicops.Field[string]{Set: true, Value: gateFieldAtBoundAwaitID + "x"},
}},
{"waiters", publicops.GateFieldWaiters, publicops.IssuePatch{
Title: publicops.Field[string]{Set: true, Value: "must not land"},
Waiters: publicops.Field[[]string]{Set: true, Value: gateFieldOverBoundWaiters()},
}},
} {
_, err := fixture.Lifecycle.Update(ctx, publicops.UpdateRequest{Actor: "writer", IssueID: id, Patch: test.patch})
assertGateFieldError(t, err, "patch with "+test.name+" past its bound", test.field)
assertLifecycleUpdateRowUnchanged(t, ctx, fixture, id, "after the refused "+test.name, before)
assertGateMembers(t, id, "after the refused "+test.name, lifecycleUpdateRow(t, ctx, fixture, id), "", gateFieldAtBoundAwaitID, 0, gateFieldAtBoundWaiters())
}
}

View file

@ -233,11 +233,14 @@ func RunMemoriesRememberWithExplicitKeyStoresVerbatim(t *testing.T, ctx context.
}
// RunMemoriesRememberReplacesAndReportsIt pins
// memoryops.RememberResult.Replaced against row presence.
// memoryops.RememberResult.Replaced, including the leg that makes it different
// from RecallResult.Found.
//
// Three legs: a first write reports false, a second reports true and REPLACES
// rather than appends, and a write over an out-of-band EMPTY row reports true.
// The third is the one a body computing `previous != ""` gets wrong.
// rather than appends, and a write over an out-of-band EMPTY row reports true
// even though a Recall of that key would have reported Found false. The third
// is the divergence the leaf doc states — Replaced is about the ROW — and it is
// the one a body computing `previous != ""` gets wrong.
func RunMemoriesRememberReplacesAndReportsIt(t *testing.T, ctx context.Context, fixture MemoriesFixture) {
t.Helper()
neighbors := seedMemoriesAllFourClasses(t, ctx, fixture)
@ -259,7 +262,7 @@ func RunMemoriesRememberReplacesAndReportsIt(t *testing.T, ctx context.Context,
if err := fixture.SetConfig(ctx, "kv.memory."+emptied, ""); err != nil {
t.Fatalf("seed an empty memory row out of band: %v", err)
}
assertMemoriesRecall(t, ctx, fixture, emptied, "", true)
assertMemoriesRecall(t, ctx, fixture, emptied, "", false)
overEmpty := rememberMemory(t, ctx, fixture, memoryops.RememberRequest{Key: emptied, Content: "now it has content"})
if !overEmpty.Replaced {
t.Fatalf("Remember over a row stored EMPTY reported Replaced false: Replaced is about the row, " +
@ -371,8 +374,8 @@ func RunMemoriesRecallAnswersTheStoredValue(t *testing.T, ctx context.Context, f
}
// RunMemoriesRecallReportsAMissAsNotFoundNotAnError pins the decision recorded
// in memoryops/errors.go: absence is a result callers inspect, not an
// operational error they must classify.
// in memoryops/errors.go: there is no ErrNotFound on this role, because the
// seam beneath it cannot see the difference the error would claim.
func RunMemoriesRecallReportsAMissAsNotFoundNotAnError(t *testing.T, ctx context.Context, fixture MemoriesFixture) {
t.Helper()
seedMemoriesAllFourClasses(t, ctx, fixture)
@ -398,70 +401,33 @@ func RunMemoriesRecallReportsAMissAsNotFoundNotAnError(t *testing.T, ctx context
}
}
// RunMemoriesEmptyRowIsPresentUntilForgotten pins presence to the ROW rather
// than to whether its value is non-empty. No front door creates an empty
// memory, but out-of-band config writes and older workspaces can contain one,
// and it must remain addressable through Recall and Forget.
// RunMemoriesRecallConflatesStoredEmptyWithAbsent pins
// memoryops.RecallResult.Found's central claim, and the one asymmetry that lets
// a caller see past it: List enumerates the key, because the ROW exists.
//
// The second Forget is the retry leg: after the first call deletes the row, it
// reports a genuine miss and records no further history.
func RunMemoriesEmptyRowIsPresentUntilForgotten(t *testing.T, ctx context.Context, fixture MemoriesFixture) {
// That is the same same-answer-different-row shape the settings contract pins
// for `bd config get`, and stating it is what keeps a backend from "fixing" it
// on one leg and making the answer depend on the route.
func RunMemoriesRecallConflatesStoredEmptyWithAbsent(t *testing.T, ctx context.Context, fixture MemoriesFixture) {
t.Helper()
neighbors := seedMemoriesAllFourClasses(t, ctx, fixture)
seedMemoriesAllFourClasses(t, ctx, fixture)
emptied := fixture.IssuePrefix + "-stored-empty"
never := fixture.IssuePrefix + "-never-stored"
if err := fixture.SetConfig(ctx, "kv.memory."+emptied, ""); err != nil {
t.Fatalf("seed an empty memory row out of band: %v", err)
}
assertMemoriesRecall(t, ctx, fixture, emptied, "", true)
assertMemoriesRecall(t, ctx, fixture, emptied, "", false)
assertMemoriesRecall(t, ctx, fixture, never, "", false)
plane := listMemories(t, ctx, fixture, "")
if value, ok := plane[emptied]; !ok || value != "" {
t.Fatalf("List[%q] = %q (present=%v), want an enumerated empty value", emptied, value, ok)
t.Fatalf("List[%q] = %q (present=%v), want an empty value that IS enumerated: "+
"the row exists even though Recall denies it", emptied, value, ok)
}
if _, ok := plane[never]; ok {
t.Fatalf("List carries %q, which nothing stored", never)
}
first := forgetMemory(t, ctx, fixture, emptied)
if !first.Found || first.Value != "" {
t.Fatalf("first Forget(%q) = %+v, want Found true with the empty stored value", emptied, first)
}
assertMemoriesRawAbsent(t, ctx, fixture, "kv.memory."+emptied)
assertMemoriesNeighborsSurvived(t, ctx, fixture, neighbors)
var afterFirst int
if fixture.CountHistory != nil {
var err error
afterFirst, err = fixture.CountHistory(ctx)
if err != nil {
t.Fatalf("CountHistory after first Forget: %v", err)
}
}
second := forgetMemory(t, ctx, fixture, emptied)
if second.Found || second.Value != "" {
t.Fatalf("second Forget(%q) = %+v, want Found false with no value", emptied, second)
}
assertMemoriesRawAbsent(t, ctx, fixture, "kv.memory."+emptied)
assertMemoriesNeighborsSurvived(t, ctx, fixture, neighbors)
// The no-write half of the retry is the only leg that needs history, which
// is why it comes last: a backend that cannot observe history has run every
// other leg by here, and SKIPS this one with that reason, as the
// MemoriesFixture.CountHistory doc promises, rather than passing quietly.
if fixture.CountHistory == nil {
t.Skip("this backend cannot observe history, so the no-write half of the retry is unobservable here")
}
afterSecond, err := fixture.CountHistory(ctx)
if err != nil {
t.Fatalf("CountHistory after second Forget: %v", err)
}
if afterSecond != afterFirst {
t.Fatalf("history entries went %d -> %d across the second Forget, want no write", afterFirst, afterSecond)
}
}
// RunMemoriesForgetRemovesExactlyTheNamedRow IS THE QUADRANT CASE, and the
@ -562,7 +528,13 @@ func RunMemoriesForgetReportsTheForgottenValue(t *testing.T, ctx context.Context
// RunMemoriesForgetOfAnAbsentKeyIsNotFoundAndDeletesNothing pins that a miss is
// a RESULT and not an error, that it changes no row anywhere in the table, that
// the second call — the one a retrying caller actually makes — answers the same
// way.
// way, and that the SECOND kind of miss behaves like the first: a memory stored
// as the empty string is Found false, and its row is left standing.
//
// That last leg is memoryops.ForgetResult.Found's parenthesis, and it keeps
// Forget's answer and Recall's answer the same statement. A body that deleted
// on "the row is there" rather than on "Recall would find it" would report
// nothing removed while removing something.
//
// The whole-table row count is the assertion that matters: "the key is still
// absent" would pass on a delete that swept a neighboring plane.
@ -570,6 +542,10 @@ func RunMemoriesForgetOfAnAbsentKeyIsNotFoundAndDeletesNothing(t *testing.T, ctx
t.Helper()
neighbors := seedMemoriesAllFourClasses(t, ctx, fixture)
key := fixture.IssuePrefix + "-never-stored-forget"
emptied := fixture.IssuePrefix + "-empty-forget"
if err := fixture.SetConfig(ctx, "kv.memory."+emptied, ""); err != nil {
t.Fatalf("seed an empty memory row out of band: %v", err)
}
var before int
if err := fixture.QueryScalar(ctx, "SELECT COUNT(*) FROM config", nil, &before); err != nil {
@ -577,12 +553,14 @@ func RunMemoriesForgetOfAnAbsentKeyIsNotFoundAndDeletesNothing(t *testing.T, ctx
}
for attempt := 1; attempt <= 2; attempt++ {
result, err := fixture.Memories.Forget(ctx, memoryops.ForgetRequest{Key: key})
if err != nil {
t.Fatalf("Forget(%q) attempt %d = %v, want success with Found false", key, attempt, err)
}
if result.Found || result.Value != "" {
t.Fatalf("Forget(%q) attempt %d = %+v, want Found false and no value", key, attempt, result)
for _, miss := range []string{key, emptied} {
result, err := fixture.Memories.Forget(ctx, memoryops.ForgetRequest{Key: miss})
if err != nil {
t.Fatalf("Forget(%q) attempt %d = %v, want success with Found false", miss, attempt, err)
}
if result.Found || result.Value != "" {
t.Fatalf("Forget(%q) attempt %d = %+v, want Found false and no value", miss, attempt, result)
}
}
}
@ -591,8 +569,11 @@ func RunMemoriesForgetOfAnAbsentKeyIsNotFoundAndDeletesNothing(t *testing.T, ctx
t.Fatalf("count config rows after: %v", err)
}
if after != before {
t.Fatalf("config rows went %d -> %d across two forgets that found nothing, want no change", before, after)
t.Fatalf("config rows went %d -> %d across four forgets that found nothing, want no change", before, after)
}
// The stored-empty row is specifically still there: Found false said nothing
// was removed, and that has to be true of the row as well as of the answer.
assertMemoriesRawValue(t, ctx, fixture, "kv.memory."+emptied, "")
assertMemoriesNeighborsSurvived(t, ctx, fixture, neighbors)
// The empty key is a refusal, not a miss.

View file

@ -1,480 +0,0 @@
package conformance
import (
"context"
"errors"
"testing"
"github.com/steveyegge/beads/internal/types"
publicops "github.com/steveyegge/beads/issueops"
)
// This file holds the contract for the molecule operations every backend
// serves through one library entry each:
//
// - CloseRequest.AutoCloseMolecule / CloseBatchRequest.AutoCloseMolecule —
// the close closes the molecule root it completed IN ITS OWN TRANSACTION
// (internal/storage/issueops.CloseCompletedMoleculeInTx on the store
// backends, uow.CloseCompletedMoleculeInUOW on the unit of work, the
// server's own on http). Opt-in; unforced; guarded on the root revision.
// - issueops.MoleculeStepper — the advance behind `bd close --continue`,
// whose claim is a real claim (assignee = Actor) that never takes a step
// another actor holds.
//
// THE LEAF DOC COMMENTS ARE THE SPEC (issueops/issueops.go CloseRequest,
// issueops/batchcloser.go, issueops/moleculestepper.go, issueops/molecule.go).
// MoleculeFixture supplies adapter-specific storage access for the molecule
// assertions.
type MoleculeFixture struct {
// IssuePrefix namespaces the ids each assertion seeds.
IssuePrefix string
Lifecycle publicops.Lifecycle
BatchCloser publicops.BatchCloser
Stepper publicops.MoleculeStepper
// CreateIssue and CreateWisp seed one row in the issues and wisps plane.
CreateIssue func(context.Context, *types.Issue, string) error
CreateWisp func(context.Context, *types.Issue, string) error
// AddDependency seeds one edge.
AddDependency func(context.Context, *types.Dependency, string) error
// QueryScalar runs a single-row query and scans it.
QueryScalar func(context.Context, string, []any, ...any) error
}
const moleculeActor = "molecule-contract"
type moleculeSeed struct {
t *testing.T
ctx context.Context
fixture MoleculeFixture
}
func (s moleculeSeed) issue(id string, typ types.IssueType, status types.Status, ephemeral bool, labels ...string) {
s.t.Helper()
issue := &types.Issue{ID: id, Title: "molecule " + id, IssueType: typ, Status: status, Priority: 2, Labels: labels, Ephemeral: ephemeral}
if status == types.StatusClosed {
issue.CloseReason = "seeded closed"
}
create := s.fixture.CreateIssue
if ephemeral {
create = s.fixture.CreateWisp
}
if err := create(s.ctx, issue, moleculeActor); err != nil {
s.t.Fatalf("seed %s: %v", id, err)
}
}
func (s moleculeSeed) edge(from, to string, typ types.DependencyType) {
s.t.Helper()
if err := s.fixture.AddDependency(s.ctx, &types.Dependency{IssueID: from, DependsOnID: to, Type: typ}, moleculeActor); err != nil {
s.t.Fatalf("seed edge %s -> %s: %v", from, to, err)
}
}
// row reads id's status and assignee from whichever plane holds it.
func (s moleculeSeed) row(id string) (status, assignee string) {
s.t.Helper()
err := s.fixture.QueryScalar(s.ctx,
`SELECT status, COALESCE(assignee, '') FROM issues WHERE id = ?
UNION ALL SELECT status, COALESCE(assignee, '') FROM wisps WHERE id = ?`,
[]any{id, id}, &status, &assignee)
if err != nil {
s.t.Fatalf("read %s: %v", id, err)
}
return status, assignee
}
// molecule seeds root <- step1 (closed), step2 (open) and answers the ids.
func (s moleculeSeed) molecule(name string, rootType types.IssueType, ephemeral bool, labels ...string) (root, done, last string) {
s.t.Helper()
root = s.fixture.IssuePrefix + "-" + name
done, last = root+".1", root+".2"
s.issue(root, rootType, types.StatusOpen, ephemeral, labels...)
s.issue(done, types.TypeTask, types.StatusClosed, ephemeral)
s.issue(last, types.TypeTask, types.StatusOpen, ephemeral)
s.edge(done, root, types.DepParentChild)
s.edge(last, root, types.DepParentChild)
return root, done, last
}
func (s moleculeSeed) closeStep(id string, autoClose bool) publicops.CloseResult {
s.t.Helper()
res, err := s.fixture.Lifecycle.Close(s.ctx, publicops.CloseRequest{
Actor: moleculeActor, IssueID: id, Reason: "step done", Session: "molecule-session", AutoCloseMolecule: autoClose,
})
if err != nil {
s.t.Fatalf("close %s: %v", id, err)
}
return res
}
// RunMoleculeCloseAutoClosesTheCompletedRoot pins CloseRequest.AutoCloseMolecule:
// closing the last open step closes an auto-closing root in the same call,
// reports it, and records the auto-close reason.
func RunMoleculeCloseAutoClosesTheCompletedRoot(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
for _, shape := range []struct {
name string
rootType types.IssueType
labels []string
}{
{"poured", types.TypeMolecule, nil},
{"template", types.TypeEpic, []string{publicops.MoleculeTemplateLabel}},
} {
root, _, last := s.molecule("auto-"+shape.name, shape.rootType, false, shape.labels...)
res := s.closeStep(last, true)
if !res.Changed || res.Issue == nil || res.Issue.Status != types.StatusClosed {
t.Fatalf("%s: close %s = %+v, want the step closed", shape.name, last, res)
}
if res.AutoClosedMolecule == nil || res.AutoClosedMolecule.ID != root {
t.Fatalf("%s: AutoClosedMolecule = %+v, want %s", shape.name, res.AutoClosedMolecule, root)
}
if res.MoleculeAutoCloseRefusal != "" {
t.Errorf("%s: MoleculeAutoCloseRefusal = %q, want none", shape.name, res.MoleculeAutoCloseRefusal)
}
if status, _ := s.row(root); status != string(types.StatusClosed) {
t.Errorf("%s: root %s status = %s, want closed", shape.name, root, status)
}
var reason string
if err := fixture.QueryScalar(ctx, `SELECT close_reason FROM issues WHERE id = ?`, []any{root}, &reason); err != nil {
t.Fatalf("read %s close_reason: %v", root, err)
}
if reason != publicops.MoleculeAutoCloseReason {
t.Errorf("%s: root close_reason = %q, want %q", shape.name, reason, publicops.MoleculeAutoCloseReason)
}
}
}
// RunMoleculeAutoCloseIsOptInAndRuleBound pins the opt-in default and the
// three roots the auto-close must leave open: one a request did not ask for,
// an incomplete one, and an ordinary epic (explicit close-eligible work).
func RunMoleculeAutoCloseIsOptInAndRuleBound(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root, _, last := s.molecule("optin", types.TypeMolecule, false)
if res := s.closeStep(last, false); res.AutoClosedMolecule != nil {
t.Errorf("close without AutoCloseMolecule reported %s auto-closed", res.AutoClosedMolecule.ID)
}
if status, _ := s.row(root); status != string(types.StatusOpen) {
t.Errorf("root %s status after an un-flagged close = %s, want open", root, status)
}
root, _, last = s.molecule("plain", types.TypeEpic, false)
if res := s.closeStep(last, true); res.AutoClosedMolecule != nil {
t.Errorf("an ordinary epic auto-closed: %s", res.AutoClosedMolecule.ID)
}
if status, _ := s.row(root); status != string(types.StatusOpen) {
t.Errorf("ordinary epic %s status = %s, want open", root, status)
}
root, done, last := s.molecule("incomplete", types.TypeMolecule, false)
if res := s.closeStep(done, true); res.AutoClosedMolecule != nil {
t.Errorf("an incomplete molecule auto-closed: %s", res.AutoClosedMolecule.ID)
}
if status, _ := s.row(root); status != string(types.StatusOpen) {
t.Errorf("incomplete molecule %s status = %s, want open (%s still open)", root, status, last)
}
}
// RunMoleculeRecloseHealsAStrandedRoot pins the replay clause: an idempotent
// re-close of the last step still closes a root left open.
func RunMoleculeRecloseHealsAStrandedRoot(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root := fixture.IssuePrefix + "-stranded"
step := root + ".1"
s.issue(root, types.TypeMolecule, types.StatusOpen, false)
s.issue(step, types.TypeTask, types.StatusClosed, false)
s.edge(step, root, types.DepParentChild)
res := s.closeStep(step, true)
if res.Changed {
t.Errorf("re-close of %s reported Changed", step)
}
if res.AutoClosedMolecule == nil || res.AutoClosedMolecule.ID != root {
t.Fatalf("re-close AutoClosedMolecule = %+v, want %s healed", res.AutoClosedMolecule, root)
}
if status, _ := s.row(root); status != string(types.StatusClosed) {
t.Errorf("stranded root %s status = %s, want closed", root, status)
}
}
// RunMoleculeBatchCloseAutoClosesTheRootOnce pins the batch clause: a batch
// that closes the remaining steps closes the root once, on one outcome.
func RunMoleculeBatchCloseAutoClosesTheRootOnce(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root, _, last := s.molecule("batch", types.TypeMolecule, false)
other := root + ".3"
s.issue(other, types.TypeTask, types.StatusOpen, false)
s.edge(other, root, types.DepParentChild)
res, err := fixture.BatchCloser.CloseBatch(ctx, publicops.CloseBatchRequest{
Actor: moleculeActor,
Items: []publicops.BatchCloseItem{{IssueID: last, Reason: "done"}, {IssueID: other, Reason: "done"}},
AutoCloseMolecule: true,
})
if err != nil {
t.Fatalf("CloseBatch: %v", err)
}
reported := 0
for _, outcome := range res.Outcomes {
if outcome.Err != nil {
t.Fatalf("outcome %s: %v", outcome.IssueID, outcome.Err)
}
if outcome.AutoClosedMolecule != nil {
reported++
if outcome.AutoClosedMolecule.ID != root {
t.Errorf("outcome %s auto-closed %s, want %s", outcome.IssueID, outcome.AutoClosedMolecule.ID, root)
}
}
}
if reported != 1 {
t.Errorf("the root was reported on %d outcomes, want exactly one", reported)
}
if status, _ := s.row(root); status != string(types.StatusClosed) {
t.Errorf("root %s status = %s, want closed", root, status)
}
}
// RunMoleculeRefusedRootKeepsTheStepClose pins the refusal clause: a root its
// own close policy refuses (a live blocker) stays open and is reported in the
// policy's own sentence, and the step close it followed stands.
func RunMoleculeRefusedRootKeepsTheStepClose(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root, _, last := s.molecule("blocked", types.TypeMolecule, false)
blocker := root + "-blocker"
s.issue(blocker, types.TypeTask, types.StatusOpen, false)
s.edge(root, blocker, types.DepBlocks)
res := s.closeStep(last, true)
if res.AutoClosedMolecule != nil {
t.Errorf("a blocked root auto-closed: %s", res.AutoClosedMolecule.ID)
}
if want := publicops.NewCloseBlockedError(root, []string{blocker}).Error(); res.MoleculeAutoCloseRefusal != want {
t.Errorf("MoleculeAutoCloseRefusal = %q, want the policy's own sentence %q", res.MoleculeAutoCloseRefusal, want)
}
if status, _ := s.row(last); status != string(types.StatusClosed) {
t.Errorf("step %s status = %s, want closed (the refusal must not undo it)", last, status)
}
if status, _ := s.row(root); status != string(types.StatusOpen) {
t.Errorf("blocked root %s status = %s, want open", root, status)
}
}
// RunMoleculeGuardedRootKeepsTheStepClose pins the guard clause: the root close
// is unforced, so a root a direct close would refuse — assigned to someone
// other than Actor, pinned, or a template — stays open and is reported in the
// guard's own sentence, on a single close and on a batch, and the step's close
// (and a batch's other items) stand.
func RunMoleculeGuardedRootKeepsTheStepClose(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
for _, guard := range []struct {
name string
apply func(*types.Issue)
// refusal is the guard's own error for root, whose sentence
// MoleculeAutoCloseRefusal reports.
refusal func(root string) error
}{
{"assigned", func(root *types.Issue) { root.Assignee = "someone-else" }, func(root string) error {
return &publicops.CloseNotAssigneeError{IssueID: root, Assignee: "someone-else", Actor: moleculeActor}
}},
{"pinned", func(root *types.Issue) { root.Pinned = true }, func(root string) error {
return &publicops.PinnedError{IssueID: root}
}},
{"template", func(root *types.Issue) { root.IsTemplate = true }, func(root string) error {
return &publicops.TemplateReadOnlyError{IssueID: root}
}},
} {
for _, batch := range []bool{false, true} {
name := guard.name
if batch {
name += "-batch"
}
root := fixture.IssuePrefix + "-guarded-" + name
last := root + ".2"
rootIssue := &types.Issue{ID: root, Title: "molecule " + root, IssueType: types.TypeMolecule, Status: types.StatusOpen, Priority: 2}
guard.apply(rootIssue)
if err := fixture.CreateIssue(ctx, rootIssue, moleculeActor); err != nil {
t.Fatalf("%s: seed %s: %v", name, root, err)
}
s.issue(root+".1", types.TypeTask, types.StatusClosed, false)
s.issue(last, types.TypeTask, types.StatusOpen, false)
s.edge(root+".1", root, types.DepParentChild)
s.edge(last, root, types.DepParentChild)
var (
autoClosed *publicops.Issue
refusal string
closed = []string{last}
)
if batch {
other := root + "-other"
s.issue(other, types.TypeTask, types.StatusOpen, false)
closed = append(closed, other)
res, err := fixture.BatchCloser.CloseBatch(ctx, publicops.CloseBatchRequest{
Actor: moleculeActor,
Items: []publicops.BatchCloseItem{{IssueID: last, Reason: "done"}, {IssueID: other, Reason: "done"}},
AutoCloseMolecule: true,
})
if err != nil {
t.Fatalf("%s: CloseBatch: %v", name, err)
}
for _, outcome := range res.Outcomes {
if outcome.Err != nil {
t.Fatalf("%s: outcome %s: %v", name, outcome.IssueID, outcome.Err)
}
if outcome.IssueID == last {
autoClosed, refusal = outcome.AutoClosedMolecule, outcome.MoleculeAutoCloseRefusal
}
}
} else {
res := s.closeStep(last, true)
autoClosed, refusal = res.AutoClosedMolecule, res.MoleculeAutoCloseRefusal
}
if autoClosed != nil {
t.Errorf("%s: a guarded root auto-closed: %s", name, autoClosed.ID)
}
if want := guard.refusal(root).Error(); refusal != want {
t.Errorf("%s: MoleculeAutoCloseRefusal = %q, want the guard's own sentence %q", name, refusal, want)
}
for _, id := range closed {
if status, _ := s.row(id); status != string(types.StatusClosed) {
t.Errorf("%s: %s status = %s, want closed (the refusal must not undo it)", name, id, status)
}
}
if status, _ := s.row(root); status != string(types.StatusOpen) {
t.Errorf("%s: guarded root %s status = %s, want open", name, root, status)
}
}
}
}
// RunMoleculeStepperClaimsTheNextReadyStepForTheActor pins the advance and its
// claim: the next ready step becomes in progress AND assigned to Actor; without
// AutoClaim nothing is written.
func RunMoleculeStepperClaimsTheNextReadyStepForTheActor(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root := fixture.IssuePrefix + "-advance"
a, b, c := root+".1", root+".2", root+".3"
s.issue(root, types.TypeMolecule, types.StatusOpen, false)
s.issue(a, types.TypeTask, types.StatusClosed, false)
s.issue(b, types.TypeTask, types.StatusOpen, false)
s.issue(c, types.TypeTask, types.StatusOpen, false)
for _, id := range []string{a, b, c} {
s.edge(id, root, types.DepParentChild)
}
s.edge(c, b, types.DepBlocks)
res, err := fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: a})
if err != nil {
t.Fatalf("Advance: %v", err)
}
if res.MoleculeID != root || res.Claimed || res.NextStep == nil || res.NextStep.ID != b {
t.Fatalf("Advance without a claim = %+v, want next %s in %s, unclaimed", res, b, root)
}
if status, assignee := s.row(b); status != string(types.StatusOpen) || assignee != "" {
t.Errorf("%s after an unclaimed advance = %s/%q, want open and unassigned", b, status, assignee)
}
res, err = fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: a, AutoClaim: true})
if err != nil {
t.Fatalf("Advance with a claim: %v", err)
}
if !res.Claimed || res.NextStep == nil || res.NextStep.ID != b || res.NextStep.Assignee != moleculeActor {
t.Fatalf("Advance with a claim = %+v, want %s claimed for %s", res, b, moleculeActor)
}
if status, assignee := s.row(b); status != string(types.StatusInProgress) || assignee != moleculeActor {
t.Errorf("%s after the claim = %s/%q, want in_progress assigned to %s", b, status, assignee, moleculeActor)
}
if status, _ := s.row(c); status != string(types.StatusOpen) {
t.Errorf("%s (blocked) status = %s, want open", c, status)
}
}
// RunMoleculeStepperNeverTakesAStepAnotherActorHolds pins the refusal the claim
// carries: a ready step assigned to someone else is skipped for the next one,
// and left exactly as it was.
func RunMoleculeStepperNeverTakesAStepAnotherActorHolds(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root := fixture.IssuePrefix + "-held"
a, held, free := root+".1", root+".2", root+".3"
s.issue(root, types.TypeMolecule, types.StatusOpen, false)
s.issue(a, types.TypeTask, types.StatusClosed, false)
heldIssue := &types.Issue{ID: held, Title: "held", IssueType: types.TypeTask, Status: types.StatusOpen, Priority: 2, Assignee: "someone-else"}
if err := fixture.CreateIssue(ctx, heldIssue, moleculeActor); err != nil {
t.Fatalf("seed %s: %v", held, err)
}
s.issue(free, types.TypeTask, types.StatusOpen, false)
for _, id := range []string{a, held, free} {
s.edge(id, root, types.DepParentChild)
}
res, err := fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: a, AutoClaim: true})
if err != nil {
t.Fatalf("Advance: %v", err)
}
if !res.Claimed || res.NextStep == nil || res.NextStep.ID != free {
t.Fatalf("Advance = %+v, want %s skipped (held) and %s claimed", res, held, free)
}
if status, assignee := s.row(held); status != string(types.StatusOpen) || assignee != "someone-else" {
t.Errorf("held step %s = %s/%q, want untouched (open, someone-else)", held, status, assignee)
}
}
// RunMoleculeStepperAnswersCompleteAndOutsideAMolecule pins the two answers
// that claim nothing.
func RunMoleculeStepperAnswersCompleteAndOutsideAMolecule(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
orphan := fixture.IssuePrefix + "-orphan"
s.issue(orphan, types.TypeTask, types.StatusClosed, false)
res, err := fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: orphan, AutoClaim: true})
if err != nil {
t.Fatalf("Advance(orphan): %v", err)
}
if res.MoleculeID != "" || res.NextStep != nil || res.Claimed || res.ClosedStep == nil || res.ClosedStep.ID != orphan {
t.Errorf("Advance(orphan) = %+v, want the step and no molecule", res)
}
root := fixture.IssuePrefix + "-complete"
s.issue(root, types.TypeEpic, types.StatusOpen, false)
s.issue(root+".1", types.TypeTask, types.StatusClosed, false)
s.edge(root+".1", root, types.DepParentChild)
res, err = fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: root + ".1", AutoClaim: true})
if err != nil {
t.Fatalf("Advance(complete): %v", err)
}
if res.MoleculeID != root || !res.Complete || res.NextStep != nil || res.Claimed {
t.Errorf("Advance(complete) = %+v, want %s complete", res, root)
}
if _, err := fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: fixture.IssuePrefix + "-absent"}); !errors.Is(err, publicops.ErrNotFound) {
t.Errorf("Advance(absent) = %v, want ErrNotFound", err)
}
}
// RunMoleculeStepperClaimsAWispStep pins the wisp plane: a wisp molecule's next
// step is claimed for the actor too.
func RunMoleculeStepperClaimsAWispStep(t *testing.T, ctx context.Context, fixture MoleculeFixture) {
t.Helper()
s := moleculeSeed{t, ctx, fixture}
root, done, last := s.molecule("wisp", types.TypeMolecule, true)
res, err := fixture.Stepper.Advance(ctx, publicops.AdvanceRequest{Actor: moleculeActor, ClosedStepID: done, AutoClaim: true})
if err != nil {
t.Fatalf("Advance: %v", err)
}
if res.MoleculeID != root || !res.Claimed || res.NextStep == nil || res.NextStep.ID != last {
t.Fatalf("Advance over a wisp molecule = %+v, want %s claimed", res, last)
}
if status, assignee := s.row(last); status != string(types.StatusInProgress) || assignee != moleculeActor {
t.Errorf("wisp step %s = %s/%q, want in_progress assigned to %s", last, status, assignee, moleculeActor)
}
}

View file

@ -42,7 +42,6 @@ func RunPortableMethods(t *testing.T, factory Factory) {
t.Run("ImportIssueComment", func(t *testing.T) { testImportIssueComment(t, factory) })
t.Run("AddIssueCommentBurstOrder", func(t *testing.T) { testAddIssueCommentBurstOrder(t, factory) })
t.Run("PromoteFromEphemeral", func(t *testing.T) { testPromoteFromEphemeral(t, factory) })
t.Run("PromoteClosedWispPreservesSession", func(t *testing.T) { testPromoteClosedWispPreservesSession(t, factory) })
t.Run("UpdateIssueID", func(t *testing.T) { testUpdateIssueID(t, factory) })
t.Run("DeleteIssuesBySourceRepo", func(t *testing.T) { testDeleteIssuesBySourceRepo(t, factory) })
t.Run("CreateIssuesWithFullOptions", func(t *testing.T) { testCreateIssuesWithFullOptions(t, factory) })
@ -578,36 +577,6 @@ func testPromoteFromEphemeral(t *testing.T, f Factory) {
}
}
// testPromoteClosedWispPreservesSession verifies that promoting a *closed*
// ephemeral wisp preserves its closed_by_session provenance. Before the fix
// (GH#4662), closed_by_session was absent from the shared issue select/scan
// and insert column set, so promotion (read wisp -> insert issue) hydrated a
// zero value and dropped the original closing session. Promotion re-inserts
// through that shared (classic) writer, so this case guards GH#4662's path
// only; the domain writer's copy of the column (db.insertIssueRow) is pinned
// by the domain/db Insert tests.
func testPromoteClosedWispPreservesSession(t *testing.T, f Factory) {
s := f(t)
c := ctx()
must(t, s.CreateIssue(c, withDefaults(&types.Issue{ID: "test-cw", Title: "Closed wisp", Ephemeral: true}), "a"))
must(t, s.CloseIssue(c, "test-cw", "done", "a", "sess-xyz"))
must(t, s.PromoteFromEphemeral(c, "test-cw", "a"))
got, err := s.GetIssue(c, "test-cw")
must(t, err)
if got.Ephemeral {
t.Error("promoted issue still Ephemeral")
}
if got.Status != types.StatusClosed {
t.Errorf("promoted issue status = %q, want %q", got.Status, types.StatusClosed)
}
if got.ClosedBySession != "sess-xyz" {
t.Errorf("closed_by_session after promote = %q, want %q (GH#4662)", got.ClosedBySession, "sess-xyz")
}
}
// --- Id rekey / source-repo purge / batch create ---
func testUpdateIssueID(t *testing.T, f Factory) {

View file

@ -113,10 +113,6 @@ type ReaderFixture struct {
AddDependency func(context.Context, *types.Dependency, string) error
// AddComment puts one comment on a durable issue.
AddComment func(ctx context.Context, issueID, author, text string) error
// PromoteWisp moves a seeded wisp into the durable plane. It is the only
// way to seed a DURABLE row of an infra type: creating one routes it to the
// wisps plane on every backend.
PromoteWisp func(ctx context.Context, id, actor string) error
}
// RunReaderReadyDefaultTypeExclusionsYieldToAnExplicitType pins
@ -790,112 +786,6 @@ func RunReaderListReadyFlagRefusesAFilterItCannotCarry(t *testing.T, ctx context
assertReaderPageIDs(t, "List --id without --ready", page, []string{one})
}
// RunReaderListQueryMatchesTheTitleOrTheID pins ListRequest.Query: `bd
// search`'s text, which matches a row whose title OR id contains it, case
// insensitively, and which narrows without lifting a default exclusion — and
// issueops.SearchListRequest, the request every `bd search` route sends, which
// does lift them.
//
// EVERY KIND OF ROW the search scope promises is seeded with the text, because
// a scope that silently loses one kind answers every other row correctly: a
// template, a gate, a wisp of an infra type, and a DURABLE row of that type —
// a promoted wisp, which a type filter that narrows an infra type to its
// ephemeral rows drops with no error. Each must come back under the bare scope
// and under its own type.
//
// It scopes itself with a label rather than an id set, so the served leg runs
// it as written: listIssues publishes no id parameter.
func RunReaderListQueryMatchesTheTitleOrTheID(t *testing.T, ctx context.Context, fixture ReaderFixture) {
t.Helper()
if fixture.PromoteWisp == nil {
t.Fatal("fixture has no PromoteWisp: a durable row of an infra type cannot be seeded, and it is the row a narrowed type filter drops")
}
scope := readerLabel(fixture, "lsquery")
needle := strings.ToLower(fixture.IssuePrefix) + "qneedle"
titleHit := readerID(fixture, "lsquery", "title")
idHit := readerID(fixture, "lsquery", "idhit")
closedHit := readerID(fixture, "lsquery", "closed")
miss := readerID(fixture, "lsquery", "miss")
template := readerID(fixture, "lsquery", "template")
gate := readerID(fixture, "lsquery", "gate")
wispMessage := readerID(fixture, "lsquery", "wispmsg")
promotedMessage := readerID(fixture, "lsquery", "promotedmsg")
// The title carries the needle in UPPER case and the request asks in lower,
// so a case-sensitive match finds nothing.
titleIssue := readerIssue(titleHit, types.TypeTask, scope)
titleIssue.Title = "fix the " + strings.ToUpper(needle) + " path"
// The id-hit's title says nothing about it: only its id can match.
idIssue := readerIssue(idHit, types.TypeTask, scope)
idIssue.Title = "unrelated words"
closedIssue := readerIssue(closedHit, types.TypeTask, scope)
closedIssue.Title = "old " + needle
closedIssue.Status = types.StatusClosed
missIssue := readerIssue(miss, types.TypeTask, scope)
missIssue.Title = "nothing to see"
templateIssue := readerIssue(template, types.TypeTask, scope)
templateIssue.Title = needle + " template"
templateIssue.IsTemplate = true
gateIssue := readerIssue(gate, types.TypeGate, scope)
gateIssue.Title = needle + " gate"
for _, issue := range []*types.Issue{titleIssue, idIssue, closedIssue, missIssue, templateIssue, gateIssue} {
seedReaderIssue(t, ctx, fixture, issue)
}
// Two rows of the same infra type, one per plane. `message` is built in,
// so the type is valid on every backend without configuration.
for _, id := range []string{wispMessage, promotedMessage} {
message := readerIssue(id, types.TypeMessage, scope)
message.Title = needle + " message"
message.Ephemeral = true
seedReaderWisp(t, ctx, fixture, message)
}
if err := fixture.PromoteWisp(ctx, promotedMessage, "seed"); err != nil {
t.Fatalf("promote wisp %s: %v", promotedMessage, err)
}
searchType := func(issueType types.IssueType) publicops.ListRequest {
req := searchScoped(needle, scope)
req.IssueType = string(issueType)
return req
}
for _, tc := range []struct {
name string
req publicops.ListRequest
want []string
}{
{"a title match, case-insensitively, under the default exclusions", publicops.ListRequest{Labels: []string{scope}, Query: needle}, []string{titleHit}},
{"AllFlag takes the closed match back", publicops.ListRequest{Labels: []string{scope}, Query: needle, AllFlag: true}, []string{titleHit, closedHit}},
{"an id match whose title does not contain the text", publicops.ListRequest{Labels: []string{scope}, Query: idHit, AllFlag: true}, []string{idHit}},
{"text nothing contains", publicops.ListRequest{Labels: []string{scope}, Query: needle + "-absent", AllFlag: true}, nil},
{"no text narrows nothing", publicops.ListRequest{Labels: []string{scope}}, []string{titleHit, idHit, miss}},
{"SearchListRequest, `bd search`'s scope, takes every status and every kind of row back", searchScoped(needle, scope), []string{titleHit, closedHit, template, gate, wispMessage, promotedMessage}},
{"SearchListRequest under an infra type keeps both planes' rows of it", searchType(types.TypeMessage), []string{wispMessage, promotedMessage}},
{"SearchListRequest under the gate type", searchType(types.TypeGate), []string{gate}},
{"SearchListRequest under a plain type keeps its templates", searchType(types.TypeTask), []string{titleHit, closedHit, template}},
// Outside the search scope an infra type alone reads only its
// ephemeral rows, which is where creating one puts it; IncludeEphemeral
// is what lifts that narrowing to the durable rows as well.
{"an infra type alone reads only its ephemeral rows", publicops.ListRequest{Labels: []string{scope}, Query: needle, IssueType: string(types.TypeMessage)}, []string{wispMessage}},
{"IncludeEphemeral lifts that narrowing", publicops.ListRequest{Labels: []string{scope}, Query: needle, IssueType: string(types.TypeMessage), IncludeEphemeral: true}, []string{wispMessage, promotedMessage}},
} {
page, err := fixture.Reader.List(ctx, tc.req)
if err != nil {
t.Errorf("List %s: %v", tc.name, err)
continue
}
assertReaderPageIDSet(t, "List "+tc.name, page, tc.want)
}
}
// searchScoped is the library's search request narrowed to one case's label,
// the request every `bd search` route sends.
func searchScoped(query, label string) publicops.ListRequest {
req := publicops.SearchListRequest(query)
req.Labels = []string{label}
return req
}
// RunReaderListEmptyPageIsWellFormed pins the page shape when nothing matches
// (reader.go:376-381). Items is never nil for a successful call, so no caller
// has to tell null from empty to learn that nothing matched, and an empty page
@ -3175,335 +3065,6 @@ func assertReaderBriefRow(t *testing.T, what string, brief, full *types.Issue) {
}
}
// RunReaderListTimeBoundsAreStrictAndWholeSecond pins the eight time bounds
// ListRequest carries beside the created pair — UpdatedAfter/Before,
// ClosedAfter/Before, DeferAfter/Before and DueAfter/Before — at their exact
// boundaries (reader.go: each is a strict bound on its column).
//
// THE BOUNDARY IS THE ASSERTION. Three rows sit one second apart around an
// instant T, so a body that compared inclusively, swapped the two ends, or
// bound the wrong column fails on a row rather than on nothing:
//
// - after=T selects exactly the T+1s row and before=T exactly the T-1s row,
// so the row AT T is excluded by both;
// - a bound carrying a sub-second remainder (T+900ms) behaves as T on both
// ends, because the bound is compared at whole-second precision (the
// storage builder formats it as RFC 3339 without a fraction);
// - a row whose column is NULL — an open row's closed_at, an unset
// defer_until or due_at — never matches either bound;
// - a bound spelled in a non-UTC zone selects exactly what the same instant
// spelled in UTC does. An offset is part of the instant, not decoration,
// and a body that dropped it would move the bound by the offset.
//
// Every family scopes itself by id and seeds no labels, so no write after the
// insert can move updated_at off the instant it was seeded at; AllFlag keeps
// the closed rows in view.
func RunReaderListTimeBoundsAreStrictAndWholeSecond(t *testing.T, ctx context.Context, fixture ReaderFixture) {
t.Helper()
at := time.Now().UTC().Truncate(time.Second).Add(-3 * time.Hour)
created := at.Add(-time.Hour)
instants := []struct {
tag string
at time.Time
}{
{"early", at.Add(-time.Second)},
{"exact", at},
{"late", at.Add(time.Second)},
}
for _, family := range []struct {
name string
// set stamps the family's column onto a seed.
set func(issue *types.Issue, v time.Time)
// nullable seeds a fourth row with the column NULL.
nullable bool
after func(*publicops.ListRequest, *time.Time)
before func(*publicops.ListRequest, *time.Time)
}{
{
name: "updated",
set: func(issue *types.Issue, v time.Time) { issue.UpdatedAt = v },
after: func(r *publicops.ListRequest, v *time.Time) { r.UpdatedAfter = v },
before: func(r *publicops.ListRequest, v *time.Time) { r.UpdatedBefore = v },
},
{
name: "closed",
set: func(issue *types.Issue, v time.Time) {
issue.Status = types.StatusClosed
issue.UpdatedAt = v
issue.ClosedAt = &v
},
nullable: true,
after: func(r *publicops.ListRequest, v *time.Time) { r.ClosedAfter = v },
before: func(r *publicops.ListRequest, v *time.Time) { r.ClosedBefore = v },
},
{
name: "defer",
set: func(issue *types.Issue, v time.Time) { issue.DeferUntil = &v },
nullable: true,
after: func(r *publicops.ListRequest, v *time.Time) { r.DeferAfter = v },
before: func(r *publicops.ListRequest, v *time.Time) { r.DeferBefore = v },
},
{
name: "due",
set: func(issue *types.Issue, v time.Time) { issue.DueAt = &v },
nullable: true,
after: func(r *publicops.ListRequest, v *time.Time) { r.DueAfter = v },
before: func(r *publicops.ListRequest, v *time.Time) { r.DueBefore = v },
},
} {
caseTag := "ltb" + family.name
ids := map[string]string{}
var scope []string
for _, inst := range instants {
id := readerID(fixture, caseTag, inst.tag)
ids[inst.tag] = id
scope = append(scope, id)
issue := readerIssue(id, types.TypeTask, "")
issue.CreatedAt, issue.UpdatedAt = created, created
family.set(issue, inst.at)
seedReaderIssue(t, ctx, fixture, issue)
}
if family.nullable {
id := readerID(fixture, caseTag, "null")
scope = append(scope, id)
issue := readerIssue(id, types.TypeTask, "")
issue.CreatedAt, issue.UpdatedAt = created, created
seedReaderIssue(t, ctx, fixture, issue)
}
idScope := readerIDFilter(scope...)
list := func(what string, apply func(*publicops.ListRequest, *time.Time), bound time.Time) []string {
t.Helper()
req := publicops.ListRequest{IDFilter: idScope, AllFlag: true}
apply(&req, &bound)
page, err := fixture.Reader.List(ctx, req)
if err != nil {
t.Fatalf("List (%s %s): %v", family.name, what, err)
}
assertReaderPageNotNil(t, "List ("+family.name+" "+what+")", page)
got := readerPageIDs(page)
slices.Sort(got)
return got
}
expect := func(what string, apply func(*publicops.ListRequest, *time.Time), bound time.Time, want string) {
t.Helper()
if got := list(what, apply, bound); !slices.Equal(got, []string{want}) {
t.Errorf("List (%s %s %s) = %v, want exactly [%s]", family.name, what, bound.Format(time.RFC3339Nano), got, want)
}
}
plus2 := time.FixedZone("UTC+2", 2*60*60)
for _, bound := range []struct {
what string
v time.Time
}{
{"at T", at},
{"at T with a sub-second remainder", at.Add(900 * time.Millisecond)},
{"at T spelled in a +02:00 zone", at.In(plus2)},
} {
expect("after "+bound.what, family.after, bound.v, ids["late"])
expect("before "+bound.what, family.before, bound.v, ids["early"])
}
// The NULL row is outside even the widest bounds on both ends.
if family.nullable {
wide := at.Add(-24 * time.Hour)
if got, want := list("after a day earlier", family.after, wide), sortedCopy(ids["early"], ids["exact"], ids["late"]); !slices.Equal(got, want) {
t.Errorf("List (%s after a day earlier) = %v, want %v — a NULL column never matches", family.name, got, want)
}
if got, want := list("before a day later", family.before, at.Add(24*time.Hour)), sortedCopy(ids["early"], ids["exact"], ids["late"]); !slices.Equal(got, want) {
t.Errorf("List (%s before a day later) = %v, want %v — a NULL column never matches", family.name, got, want)
}
}
}
}
// RunReaderListFilterFamiliesNarrowToTheirRows pins one included and one
// excluded row for each remaining ListRequest filter family that `bd list`
// publishes beyond the scope filters: the priority trio, the three text
// substrings, the empty-description and no-labels predicates, the top-level
// predicate, the type exclusion, the spec prefix, the label pattern and
// regex, the external-ref pair, the pinned-flag pair, the deferred and
// overdue predicates, the status exclusion and the molecule type.
//
// Each row is scoped by id and every arm asks AllFlag (the pinned arms
// excepted, which are about that interplay), so an arm whose filter the body
// dropped answers its whole scope and fails, and one whose filter the body
// inverted answers the other row.
//
// PinnedFlag with NoPinnedFlag is a contradiction, and the role refuses it as
// a validation error rather than letting one of the two silently win.
// ParentID with NoParent is refused the same way, as CountRequest refuses it.
func RunReaderListFilterFamiliesNarrowToTheirRows(t *testing.T, ctx context.Context, fixture ReaderFixture) {
t.Helper()
id := func(name string) string { return readerID(fixture, "lff", name) }
seed := func(name string, mutate func(*types.Issue)) string {
t.Helper()
issue := readerIssue(id(name), types.TypeTask, "")
if mutate != nil {
mutate(issue)
}
seedReaderIssue(t, ctx, fixture, issue)
return issue.ID
}
intp := func(v int) *int { return &v }
past := time.Now().UTC().Truncate(time.Second).Add(-48 * time.Hour)
future := time.Now().UTC().Truncate(time.Second).Add(48 * time.Hour)
label := readerLabel(fixture, "lffpat")
external := fixture.IssuePrefix + "-LFF-ext-17"
spec := "docs/" + fixture.IssuePrefix + "-lff/"
p0 := seed("p0", func(i *types.Issue) { i.Priority = 0 })
p2 := seed("p2", func(i *types.Issue) { i.Priority = 2 })
p4 := seed("p4", func(i *types.Issue) { i.Priority = 4 })
textT := seed("text-t", func(i *types.Issue) { i.Title = "a title carrying ttok-lff" })
textD := seed("text-d", func(i *types.Issue) { i.Description = "a description carrying dtok-lff" })
textN := seed("text-n", func(i *types.Issue) { i.Notes = "notes carrying ntok-lff" })
labeled := seed("labeled", func(i *types.Issue) { i.Labels = []string{label} })
unlabeled := seed("unlabeled", nil)
parent := seed("parent", func(i *types.Issue) { i.IssueType = types.TypeEpic })
child := seed("child", nil)
if err := fixture.AddDependency(ctx, &types.Dependency{IssueID: child, DependsOnID: parent, Type: types.DepParentChild}, "seed"); err != nil {
t.Fatalf("seed edge %s -> %s: %v", child, parent, err)
}
loose := seed("loose", nil)
typeTask := seed("type-task", nil)
typeBug := seed("type-bug", func(i *types.Issue) { i.IssueType = types.TypeBug })
typeChore := seed("type-chore", func(i *types.Issue) { i.IssueType = types.TypeChore })
specced := seed("specced", func(i *types.Issue) { i.SpecID = spec + "design.md" })
unspecced := seed("unspecced", nil)
extRow := seed("ext", func(i *types.Issue) { i.ExternalRef = &external })
extOther := seed("ext-other", func(i *types.Issue) {
other := fixture.IssuePrefix + "-other-99"
i.ExternalRef = &other
})
pinned := seed("pinned", func(i *types.Issue) { i.Pinned = true })
unpinned := seed("unpinned", nil)
deferred := seed("deferred", func(i *types.Issue) { i.DeferUntil = &future })
undeferred := seed("undeferred", nil)
overdue := seed("overdue", func(i *types.Issue) { i.DueAt = &past })
dueLater := seed("due-later", func(i *types.Issue) { i.DueAt = &future })
closedOverdue := seed("closed-overdue", func(i *types.Issue) {
i.Status = types.StatusClosed
closedAt := time.Now().UTC().Truncate(time.Second).Add(-time.Hour)
i.ClosedAt = &closedAt
i.DueAt = &past
})
noDue := seed("no-due", nil)
swarm := seed("mol-swarm", func(i *types.Issue) { i.MolType = types.MolTypeSwarm })
patrol := seed("mol-patrol", func(i *types.Issue) { i.MolType = types.MolTypePatrol })
stOpen := seed("st-open", nil)
stProgress := seed("st-progress", func(i *types.Issue) { i.Status = types.StatusInProgress })
stBlocked := seed("st-blocked", func(i *types.Issue) { i.Status = types.StatusBlocked })
stClosed := seed("st-closed", func(i *types.Issue) {
i.Status = types.StatusClosed
closedAt := time.Now().UTC().Truncate(time.Second).Add(-time.Hour)
i.ClosedAt = &closedAt
})
statusScope := readerIDFilter(stOpen, stProgress, stBlocked, stClosed)
molType := func(m types.MolType) *publicops.MolType { return &m }
scoped := func(ids ...string) publicops.ListRequest {
return publicops.ListRequest{IDFilter: readerIDFilter(ids...), AllFlag: true}
}
with := func(req publicops.ListRequest, mutate func(*publicops.ListRequest)) publicops.ListRequest {
mutate(&req)
return req
}
for _, test := range []struct {
name string
req publicops.ListRequest
want []string
}{
{"Priority is exact", with(scoped(p0, p2, p4), func(r *publicops.ListRequest) { r.Priority = intp(2) }), []string{p2}},
{"Priority 0 is a value, not unset", with(scoped(p0, p2, p4), func(r *publicops.ListRequest) { r.Priority = intp(0) }), []string{p0}},
{"PriorityMin is inclusive", with(scoped(p0, p2, p4), func(r *publicops.ListRequest) { r.PriorityMin = intp(2) }), []string{p2, p4}},
{"PriorityMax is inclusive", with(scoped(p0, p2, p4), func(r *publicops.ListRequest) { r.PriorityMax = intp(2) }), []string{p0, p2}},
{"PriorityMin and PriorityMax compose", with(scoped(p0, p2, p4), func(r *publicops.ListRequest) { r.PriorityMin, r.PriorityMax = intp(1), intp(3) }), []string{p2}},
{"TitleContains is a case-insensitive substring", with(scoped(textT, textD, textN), func(r *publicops.ListRequest) { r.TitleContains = "TTOK-LFF" }), []string{textT}},
{"DescContains reads the description only", with(scoped(textT, textD, textN), func(r *publicops.ListRequest) { r.DescContains = "dtok-lff" }), []string{textD}},
{"NotesContains reads the notes only", with(scoped(textT, textD, textN), func(r *publicops.ListRequest) { r.NotesContains = "ntok-lff" }), []string{textN}},
{"EmptyDesc keeps the rows with no description", with(scoped(textT, textD, textN), func(r *publicops.ListRequest) { r.EmptyDesc = true }), []string{textT, textN}},
{"NoLabels keeps the unlabeled row", with(scoped(labeled, unlabeled), func(r *publicops.ListRequest) { r.NoLabels = true }), []string{unlabeled}},
{"LabelPattern is a glob", with(scoped(labeled, unlabeled), func(r *publicops.ListRequest) { r.LabelPattern = fixture.IssuePrefix + "-scope-lff*" }), []string{labeled}},
{"LabelRegex is a regular expression", with(scoped(labeled, unlabeled), func(r *publicops.ListRequest) { r.LabelRegex = "-scope-lffp.t$" }), []string{labeled}},
{"NoParent keeps the top-level rows", with(scoped(parent, child, loose), func(r *publicops.ListRequest) { r.NoParent = true }), []string{parent, loose}},
{"ExcludeTypes drops the named type", with(scoped(typeTask, typeBug, typeChore), func(r *publicops.ListRequest) { r.ExcludeTypes = []string{"bug"} }), []string{typeTask, typeChore}},
{"ExcludeTypes takes a comma-separated value", with(scoped(typeTask, typeBug, typeChore), func(r *publicops.ListRequest) { r.ExcludeTypes = []string{"bug,chore"} }), []string{typeTask}},
{"SpecPrefix is a prefix", with(scoped(specced, unspecced), func(r *publicops.ListRequest) { r.SpecPrefix = spec }), []string{specced}},
{"ExternalContains is a case-insensitive substring", with(scoped(extRow, extOther), func(r *publicops.ListRequest) { r.ExternalContains = "lff-EXT" }), []string{extRow}},
{"ExternalRef is exact", with(scoped(extRow, extOther), func(r *publicops.ListRequest) { r.ExternalRef = external }), []string{extRow}},
{"AllFlag alone admits both pinned-flag states", scoped(pinned, unpinned), []string{pinned, unpinned}},
{"PinnedFlag selects the flagged row", publicops.ListRequest{IDFilter: readerIDFilter(pinned, unpinned), PinnedFlag: true}, []string{pinned}},
{"NoPinnedFlag holds the unflagged predicate under AllFlag", with(scoped(pinned, unpinned), func(r *publicops.ListRequest) { r.NoPinnedFlag = true }), []string{unpinned}},
{"DeferredFlag keeps the deferred row", with(scoped(deferred, undeferred), func(r *publicops.ListRequest) { r.DeferredFlag = true }), []string{deferred}},
{"OverdueFlag keeps the open row past its due date", with(scoped(overdue, dueLater, closedOverdue, noDue), func(r *publicops.ListRequest) { r.OverdueFlag = true }), []string{overdue}},
{"ExcludeStatus under AllFlag keeps every status not named", with(scoped(stOpen, stProgress, stBlocked, stClosed), func(r *publicops.ListRequest) { r.ExcludeStatus = []string{"closed"} }), []string{stOpen, stProgress, stBlocked}},
{"ExcludeStatus takes repeated and comma-separated values", with(scoped(stOpen, stProgress, stBlocked, stClosed), func(r *publicops.ListRequest) { r.ExcludeStatus = []string{"blocked,in_progress", " closed "} }), []string{stOpen}},
{"ExcludeStatus adds to the default exclusions rather than replacing them", publicops.ListRequest{IDFilter: statusScope, ExcludeStatus: []string{"blocked"}}, []string{stOpen, stProgress}},
{"ExcludeStatus narrows an explicit Status", publicops.ListRequest{IDFilter: statusScope, Status: "open,blocked,closed", ExcludeStatus: []string{"blocked"}}, []string{stOpen, stClosed}},
{"MolType is exact", with(scoped(swarm, patrol), func(r *publicops.ListRequest) { r.MolType = molType(types.MolTypeSwarm) }), []string{swarm}},
} {
page, err := fixture.Reader.List(ctx, test.req)
if err != nil {
t.Errorf("List (%s): %v", test.name, err)
continue
}
assertReaderPageIDSet(t, "List ("+test.name+")", page, test.want)
}
// An exclusion naming no status in the workspace vocabulary is refused,
// never an exclusion that silently excludes nothing.
if _, err := fixture.Reader.List(ctx, publicops.ListRequest{IDFilter: statusScope, ExcludeStatus: []string{"clsoed"}}); !errors.Is(err, publicops.ErrValidation) {
t.Errorf("List with ExcludeStatus naming an unknown status = %v, want an error wrapping ErrValidation", err)
}
_, err := fixture.Reader.List(ctx, publicops.ListRequest{
IDFilter: readerIDFilter(pinned, unpinned), PinnedFlag: true, NoPinnedFlag: true,
})
if !errors.Is(err, publicops.ErrValidation) {
t.Errorf("List with PinnedFlag and NoPinnedFlag = %v, want an error wrapping ErrValidation", err)
}
_, err = fixture.Reader.List(ctx, publicops.ListRequest{
IDFilter: readerIDFilter(parent, child, loose), ParentID: parent, NoParent: true,
})
if !errors.Is(err, publicops.ErrValidation) {
t.Errorf("List with ParentID and NoParent = %v, want an error wrapping ErrValidation", err)
}
}
// sortedCopy returns its arguments as a sorted slice.
func sortedCopy(ids ...string) []string {
out := slices.Clone(ids)
slices.Sort(out)
return out
}
// readerIssue builds the seed every case starts from: an open, unassigned,
// unblocked task that qualifies for ready work. A case that needs it to fail one
// of those tests changes the field it means to test and nothing else.

View file

@ -769,21 +769,7 @@ type EpochFixture struct {
// Version now resolves to under the new epoch. A nil hook means this
// backend cannot report that, and the case that needs it skips with
// that reason.
//
// It only reads: it mints nothing and changes no state. It returns the
// address it was given when nothing carried the Version to a new one,
// and an error for an address the store does not serve.
CurrentAddressFor func(ctx context.Context, storeID string, oldAddress Address) (Address, error)
// LoseVersion records that storeID no longer serves the Version named by
// address. That address, and every address the same Version was carried
// to or from by a token-scheme change, resolves GoneReorganization from
// then on, in every later epoch: an epoch voids what the store lost,
// never what it still serves (R20-n). It is idempotent, never revives
// anything, and returns an error for an address storeID never minted. A
// nil LoseVersion means this backend cannot record a loss, and the cases
// that need one skip with that reason.
LoseVersion func(ctx context.Context, storeID string, address Address) error
}
// RunAnEpochBumpIsTriggeredOnlyByRestoreReinitOrSchemeChange pins R20-m: a
@ -833,258 +819,94 @@ func RunAnEpochBumpIsTriggeredOnlyByRestoreReinitOrSchemeChange(t *testing.T, ct
// RunEpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed pins R20-n — "Rev7
// tightening... the clause most likely to be gotten wrong" in the
// architecture doc's own words: an epoch voids what the store lost, never
// what it still serves.
// architecture doc's own words. A prior-epoch Address goes
// GoneReorganization UNLESS the backend still serves that Version, in which
// case it must stay Live AND additionally report the Address it now
// resolves to under the new epoch.
//
// Survival is RECORDED, never inferred (gastownhall/beads#6664, bee-ghosttrack
// review 5360880888, Major 1). An earlier form of this case made a Version
// survive by minting it again in every later epoch, and treated a Version
// nobody minted again as lost. That reads loss off the absence of a mint, so
// it could not express a Version the store lost after minting it, and it
// voided every survivor that nobody happened to mint again. Here a restore or
// a destructive reinit leaves every address row alone: an address the store
// still serves stays Live at its own address with no upkeep, and the only way
// an address goes Gone is LoseVersion saying so.
//
// Each phase is a named subtest, so a backend that cannot record a loss skips
// only the phases that need LoseVersion, and a failure names its phase.
// StillServes is an ORACLE here, not a control: this case cannot make a real
// backend keep serving one address and drop another, since Phase 0 wires no
// real backend. It asks StillServes what the fixture (once real) decided,
// and checks the rest of the contract's promise against that decision for
// both outcomes.
func RunEpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed(t *testing.T, ctx context.Context, fixture EpochFixture) {
t.Helper()
epochSkipUnlessReady(t, fixture, false)
// survivor-and-lost: of two Versions minted before a transition, the one
// the store loses goes Gone and the other stays Live at the address it
// already had, with no re-mint, for both triggers that leave addresses
// alone.
t.Run("survivor-and-lost", func(t *testing.T) {
if fixture.LoseVersion == nil {
t.Skip(epochLoseVersionSkip)
}
for _, trigger := range []EpochBumpTrigger{EpochBumpTriggerRestore, EpochBumpTriggerDestructiveReinit} {
t.Run(trigger.String(), func(t *testing.T) {
store := epochStore(fixture, "survivor-"+trigger.String())
addrA := epochMintAddress(t, ctx, fixture, store, "record-a")
addrB := epochMintAddress(t, ctx, fixture, store, "record-b")
newEpoch := epochBumpTo(t, ctx, fixture, store, trigger)
epochLoseAddress(t, ctx, fixture, store, addrB)
epochRequireLive(t, ctx, fixture, store, addrA, newEpoch,
"record-a was never lost, so the transition leaves it served at its own address with no re-mint (R20-n's exception)")
epochRequireGone(t, ctx, fixture, store, addrB, newEpoch,
"record-b was lost, so the transition voids it (R20-n)")
current := epochCurrentAddress(t, ctx, fixture, store, addrA)
epochRequireLive(t, ctx, fixture, store, current, newEpoch,
"the address CurrentAddressFor reports for a survivor must be served")
epochRequireLive(t, ctx, fixture, store, addrA, newEpoch,
"asking CurrentAddressFor must not retire or move the survivor's address")
if lostCurrent, err := fixture.CurrentAddressFor(ctx, store, addrB); err == nil {
t.Errorf("CurrentAddressFor(a lost address) = %s with no error, want an error: a lost Version has no current address", lostCurrent)
}
epochRequireGone(t, ctx, fixture, store, addrB, newEpoch,
"CurrentAddressFor on a lost address must not bring it back")
})
}
})
// gone-is-terminal: once an address is lost it stays lost. A later mint of
// the same id starts a new lineage under a new address, and neither that
// mint nor CurrentAddressFor revives the lost one (bee-ghosttrack's
// assertion for Major 1: a read-only lookup must not mint a replacement
// that makes a lost address look served).
t.Run("gone-is-terminal", func(t *testing.T) {
if fixture.LoseVersion == nil {
t.Skip(epochLoseVersionSkip)
}
store := epochStore(fixture, "terminal")
lost := epochMintAddress(t, ctx, fixture, store, "record-g")
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
epochLoseAddress(t, ctx, fixture, store, lost)
laterEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
fresh := epochMintAddress(t, ctx, fixture, store, "record-g")
if fresh == lost {
t.Fatalf("MintUnderEpoch(record-g) returned %s, the address already lost: a lost address is never handed out again", lost)
}
epochRequireLive(t, ctx, fixture, store, fresh, laterEpoch,
"a fresh mint of the id is a new lineage and is served")
epochRequireGone(t, ctx, fixture, store, lost, laterEpoch,
"a later mint of the same id must not revive a lost address")
if replacement, err := fixture.CurrentAddressFor(ctx, store, lost); err == nil {
t.Errorf("CurrentAddressFor(a lost address) = %s with no error, want an error: asking where a lost address resolves must not mint a replacement", replacement)
}
epochRequireGone(t, ctx, fixture, store, lost, laterEpoch,
"CurrentAddressFor on a lost address must not revive it")
// Losing it a second time is a no-op that leaves the fresh lineage
// alone.
epochLoseAddress(t, ctx, fixture, store, lost)
epochRequireLive(t, ctx, fixture, store, fresh, laterEpoch,
"losing the old address again must leave the fresh lineage served")
})
// survival-needs-no-upkeep: with nothing lost, an address stays Live across
// any number of counter-only transitions without being minted again, and a
// later mint of the same id neither retires it nor revives anything. This
// is the phase the earlier, mint-driven form failed: it answered Gone for
// every survivor nobody minted again.
t.Run("survival-needs-no-upkeep", func(t *testing.T) {
store := epochStore(fixture, "upkeep")
kept := epochMintAddress(t, ctx, fixture, store, "record-c")
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerDestructiveReinit)
finalEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
epochRequireLive(t, ctx, fixture, store, kept, finalEpoch,
"nothing was lost, so three counter-only transitions leave the address served without a re-mint")
fresh := epochMintAddress(t, ctx, fixture, store, "record-c")
if fresh == kept {
t.Fatalf("MintUnderEpoch(record-c) returned %s again after three bumps, want a new address for the new epoch", kept)
}
epochRequireLive(t, ctx, fixture, store, kept, finalEpoch,
"a later mint of the same id must not retire a served address")
epochRequireLive(t, ctx, fixture, store, fresh, finalEpoch,
"the fresh mint is served")
current := epochCurrentAddress(t, ctx, fixture, store, kept)
epochRequireLive(t, ctx, fixture, store, current, finalEpoch,
"the current address of a survivor must be served")
epochRequireLive(t, ctx, fixture, store, kept, finalEpoch,
"asking for the current address must not change the survivor")
})
}
// RunTokenSchemeChangeCarriesLiveAddressesAndOnlyThose pins R20-n's retained
// mapping for the one trigger that changes how addresses are encoded. A
// token-scheme-change bump gives every Version the store still serves a new
// address under the new epoch and keeps the old address resolving, so a holder
// of the old address is neither stranded nor pointed at something else. A
// Version the store already lost gets no new address and stays Gone.
func RunTokenSchemeChangeCarriesLiveAddressesAndOnlyThose(t *testing.T, ctx context.Context, fixture EpochFixture) {
t.Helper()
epochSkipUnlessReady(t, fixture, true)
store := epochStore(fixture, "scheme-change")
addrA := epochMintAddress(t, ctx, fixture, store, "record-a")
addrB := epochMintAddress(t, ctx, fixture, store, "record-b")
// record-b is lost in the epoch it was minted in, which a store may do.
epochLoseAddress(t, ctx, fixture, store, addrB)
newEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerTokenSchemeChange)
epochRequireLive(t, ctx, fixture, store, addrA, newEpoch,
"record-a is still served after the scheme change, through the retained mapping")
epochRequireGone(t, ctx, fixture, store, addrB, newEpoch,
"record-b was lost before the scheme change, which must not carry it")
carried := epochCurrentAddress(t, ctx, fixture, store, addrA)
if carried == addrA {
t.Errorf("CurrentAddressFor(%s) = the same address after a token-scheme change, want a new one: a scheme change re-encodes every served address, which is what tells a carry from a no-op", addrA)
if fixture.MintUnderEpoch == nil {
t.Skip("this backend has no way to mint a Version under a known epoch (MintUnderEpoch is nil)")
}
epochRequireLive(t, ctx, fixture, store, carried, newEpoch,
"the carried address must be served under the new epoch")
epochRequireLive(t, ctx, fixture, store, addrA, newEpoch,
"the old address must keep resolving after its carried address is looked up")
if again := epochCurrentAddress(t, ctx, fixture, store, carried); again != carried {
t.Errorf("CurrentAddressFor(%s) = %s, want the carried address itself: from the newest address the mapping is already current", carried, again)
if fixture.BumpEpoch == nil {
t.Skip("this backend has no epoch concept yet (BumpEpoch is nil)")
}
if lostCurrent, err := fixture.CurrentAddressFor(ctx, store, addrB); err == nil {
t.Errorf("CurrentAddressFor(a lost address) = %s with no error, want an error: a lost Version is not carried", lostCurrent)
if fixture.StillServes == nil {
t.Skip("this backend cannot report whether it still serves a prior-epoch Version (StillServes is nil)")
}
}
if fixture.Resolve == nil {
t.Skip("this backend does not yet report retention state (Resolve is nil)")
}
if fixture.CurrentAddressFor == nil {
t.Skip("this backend cannot report a still-served Version's new Address (CurrentAddressFor is nil)")
}
store := epochStore(fixture, "voids")
// RunACarriedAddressKeepsResolvingAcrossLaterBumps pins that a carried mapping
// is recorded once and then simply persists: later counter-only transitions do
// not change it, and a second token-scheme change extends it to the newest
// address without breaking any older one. Every address of the Version points
// directly at the newest address (one hop from any member), never along a
// chain.
func RunACarriedAddressKeepsResolvingAcrossLaterBumps(t *testing.T, ctx context.Context, fixture EpochFixture) {
t.Helper()
epochSkipUnlessReady(t, fixture, false)
store := epochStore(fixture, "carried-later")
addrA := epochMintAddress(t, ctx, fixture, store, "record-a")
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerTokenSchemeChange)
addrA1 := epochCurrentAddress(t, ctx, fixture, store, addrA)
if addrA1 == addrA {
t.Fatalf("CurrentAddressFor(%s) = the same address after a token-scheme change, want a new one", addrA)
addrA, err := fixture.MintUnderEpoch(ctx, store, "record-a")
if err != nil {
t.Fatalf("MintUnderEpoch(record-a): %v", err)
}
addrB, err := fixture.MintUnderEpoch(ctx, store, "record-b")
if err != nil {
t.Fatalf("MintUnderEpoch(record-b): %v", err)
}
// Two counter-only transitions, with nothing minted in between.
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
counterEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerDestructiveReinit)
epochRequireLive(t, ctx, fixture, store, addrA, counterEpoch,
"the original address must still resolve after counter-only transitions")
epochRequireLive(t, ctx, fixture, store, addrA1, counterEpoch,
"the carried address must still resolve after counter-only transitions")
if got := epochCurrentAddress(t, ctx, fixture, store, addrA); got != addrA1 {
t.Errorf("CurrentAddressFor(%s) = %s, want %s: a counter-only transition does not change the mapping", addrA, got, addrA1)
newEpoch, err := fixture.BumpEpoch(ctx, store, EpochBumpTriggerRestore)
if err != nil {
t.Fatalf("BumpEpoch: %v", err)
}
// A second scheme change carries the Version again.
secondEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerTokenSchemeChange)
addrA2 := epochCurrentAddress(t, ctx, fixture, store, addrA)
if addrA2 == addrA || addrA2 == addrA1 {
t.Fatalf("CurrentAddressFor(%s) = %s after a second scheme change, want an address different from %s and %s", addrA, addrA2, addrA, addrA1)
servesA, err := fixture.StillServes(ctx, store, addrA)
if err != nil {
t.Fatalf("StillServes(%s): %v", addrA, err)
}
for _, member := range []Address{addrA, addrA1, addrA2} {
epochRequireLive(t, ctx, fixture, store, member, secondEpoch,
"every address of a carried Version must resolve after a second scheme change")
servesB, err := fixture.StillServes(ctx, store, addrB)
if err != nil {
t.Fatalf("StillServes(%s): %v", addrB, err)
}
if got := epochCurrentAddress(t, ctx, fixture, store, addrA1); got != addrA2 {
t.Errorf("CurrentAddressFor(%s) = %s, want %s: every address of the Version points straight at the newest one", addrA1, got, addrA2)
if servesA == servesB {
t.Skip("this scenario needs one still-served and one no-longer-served address to exercise both halves of R20-n; StillServes reported the same answer for both, so this fixture gives this case nothing to contrast")
}
finalEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
epochRequireLive(t, ctx, fixture, store, addrA2, finalEpoch,
"the newest carried address must still resolve after a later restore")
}
// RunALostAddressStaysGoneAcrossASchemeChange pins that loss is terminal even
// across a token-scheme change. Losing a Version loses every address of its
// lineage at once, and a later scheme change must not carry a lost lineage
// back into service.
func RunALostAddressStaysGoneAcrossASchemeChange(t *testing.T, ctx context.Context, fixture EpochFixture) {
t.Helper()
epochSkipUnlessReady(t, fixture, true)
store := epochStore(fixture, "lost-scheme-change")
addrA := epochMintAddress(t, ctx, fixture, store, "record-a")
epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerTokenSchemeChange)
addrA1 := epochCurrentAddress(t, ctx, fixture, store, addrA)
lostEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerRestore)
// One lineage, two addresses: losing either loses both.
epochLoseAddress(t, ctx, fixture, store, addrA)
epochRequireGone(t, ctx, fixture, store, addrA, lostEpoch,
"the original address of a lost Version must be Gone")
epochRequireGone(t, ctx, fixture, store, addrA1, lostEpoch,
"the carried address of a lost Version must be Gone too")
schemeEpoch := epochBumpTo(t, ctx, fixture, store, EpochBumpTriggerTokenSchemeChange)
epochRequireGone(t, ctx, fixture, store, addrA, schemeEpoch,
"a later scheme change must not carry a lost lineage back into service")
epochRequireGone(t, ctx, fixture, store, addrA1, schemeEpoch,
"a later scheme change must not carry a lost lineage back into service")
for _, lostAddress := range []Address{addrA, addrA1} {
if current, err := fixture.CurrentAddressFor(ctx, store, lostAddress); err == nil {
t.Errorf("CurrentAddressFor(%s) = %s with no error, want an error: a lost lineage has no current address", lostAddress, current)
}
stillServed, noLongerServed := addrA, addrB
if servesB && !servesA {
stillServed, noLongerServed = addrB, addrA
}
fresh := epochMintAddress(t, ctx, fixture, store, "record-a")
if fresh == addrA || fresh == addrA1 {
t.Fatalf("MintUnderEpoch(record-a) returned %s, an address of the lost lineage: a lost address is never handed out again", fresh)
voidedAnswer, err := fixture.Resolve(ctx, store, noLongerServed)
if err != nil {
t.Fatalf("Resolve(no-longer-served): %v", err)
}
if voidedAnswer.Restriction != RestrictionGoneReorganization {
t.Errorf("Resolve(a prior-epoch Address no longer served) = %s, want RestrictionGoneReorganization (R20-n)", voidedAnswer.Restriction)
}
if voidedAnswer.Epoch == nil {
t.Fatal("Resolve(a prior-epoch Address no longer served).Epoch = nil, want the current epoch populated (R20-n: the answer must name the current epoch, not just Restriction alone)")
} else if *voidedAnswer.Epoch != newEpoch {
t.Errorf("Resolve(a prior-epoch Address no longer served).Epoch = %d, want the current epoch %d", *voidedAnswer.Epoch, newEpoch)
}
keptAnswer, err := fixture.Resolve(ctx, store, stillServed)
if err != nil {
t.Fatalf("Resolve(still-served): %v", err)
}
if keptAnswer.Restriction != RestrictionLive {
t.Errorf("Resolve(a prior-epoch Address the backend still serves) = %s, want RestrictionLive (R20-n's exception)", keptAnswer.Restriction)
}
newAddr, err := fixture.CurrentAddressFor(ctx, store, stillServed)
if err != nil {
t.Fatalf("CurrentAddressFor(%s): %v", stillServed, err)
}
if newAddr == "" {
t.Error("CurrentAddressFor(a still-served prior-epoch Address) returned an empty Address, want a real one under the new epoch")
}
epochRequireLive(t, ctx, fixture, store, fresh, schemeEpoch,
"a fresh mint of the id after the loss is a new lineage and is served")
}
// --- fixture helpers -------------------------------------------------------
@ -1131,137 +953,6 @@ func epochStore(fixture EpochFixture, tag string) string {
return fixture.IssuePrefix + "-epoch-store-" + tag
}
// epochLoseVersionSkip is the skip reason of every phase that needs
// EpochFixture.LoseVersion.
const epochLoseVersionSkip = "this backend cannot record that the store lost a Version (LoseVersion is nil)"
// epochSkipUnlessReady skips the case when the fixture lacks a capability the
// epoch cases need. The cases that record a loss also need LoseVersion. The
// all-nil wiring test runs every case against an empty fixture, so each case
// must call this before it touches any of them.
func epochSkipUnlessReady(t *testing.T, fixture EpochFixture, needsLoseVersion bool) {
t.Helper()
if fixture.MintUnderEpoch == nil {
t.Skip("this backend has no way to mint a Version under a known epoch (MintUnderEpoch is nil)")
}
if fixture.BumpEpoch == nil {
t.Skip("this backend has no epoch concept yet (BumpEpoch is nil)")
}
if fixture.StillServes == nil {
t.Skip("this backend cannot report whether it still serves a prior-epoch Version (StillServes is nil)")
}
if fixture.Resolve == nil {
t.Skip("this backend does not yet report retention state (Resolve is nil)")
}
if fixture.CurrentAddressFor == nil {
t.Skip("this backend cannot report a still-served Version's new Address (CurrentAddressFor is nil)")
}
if needsLoseVersion && fixture.LoseVersion == nil {
t.Skip(epochLoseVersionSkip)
}
}
// epochMintAddress mints id on store, failing the case if minting fails.
func epochMintAddress(t *testing.T, ctx context.Context, fixture EpochFixture, store, id string) Address {
t.Helper()
address, err := fixture.MintUnderEpoch(ctx, store, id)
if err != nil {
t.Fatalf("MintUnderEpoch(%s, %s): %v", store, id, err)
}
return address
}
// epochBumpTo bumps store's epoch for trigger and returns the epoch it
// reports. Epochs are captured from the return value, never assumed: the
// counter is one per database, shared by every store the suite uses.
func epochBumpTo(t *testing.T, ctx context.Context, fixture EpochFixture, store string, trigger EpochBumpTrigger) int {
t.Helper()
epoch, err := fixture.BumpEpoch(ctx, store, trigger)
if err != nil {
t.Fatalf("BumpEpoch(%s, %s): %v", store, trigger, err)
}
return epoch
}
// epochLoseAddress records that store lost the Version behind address.
func epochLoseAddress(t *testing.T, ctx context.Context, fixture EpochFixture, store string, address Address) {
t.Helper()
if err := fixture.LoseVersion(ctx, store, address); err != nil {
t.Fatalf("LoseVersion(%s, %s): %v", store, address, err)
}
}
// epochCurrentAddress asks where address now resolves, failing the case on an
// error or an empty answer.
func epochCurrentAddress(t *testing.T, ctx context.Context, fixture EpochFixture, store string, address Address) Address {
t.Helper()
current, err := fixture.CurrentAddressFor(ctx, store, address)
if err != nil {
t.Fatalf("CurrentAddressFor(%s, %s): %v", store, address, err)
}
if current == "" {
t.Fatalf("CurrentAddressFor(%s, %s) returned an empty Address, want a real one", store, address)
}
return current
}
// epochRequireLive asserts that address is served at epoch: StillServes is true
// and Resolve answers RestrictionLive naming that epoch. why says what the
// assertion is checking, for the failure message.
func epochRequireLive(t *testing.T, ctx context.Context, fixture EpochFixture, store string, address Address, epoch int, why string) {
t.Helper()
serves, err := fixture.StillServes(ctx, store, address)
if err != nil {
t.Fatalf("StillServes(%s): %v", address, err)
}
if !serves {
t.Errorf("StillServes(%s) = false, want true: %s", address, why)
}
answer, err := fixture.Resolve(ctx, store, address)
if err != nil {
t.Fatalf("Resolve(%s): %v", address, err)
}
if answer.Restriction != RestrictionLive {
t.Errorf("Resolve(%s) = %s, want RestrictionLive: %s", address, answer.Restriction, why)
}
epochRequireAnswerEpoch(t, answer, address, epoch, why)
}
// epochRequireGone asserts that address is no longer served at epoch:
// StillServes is false and Resolve answers RestrictionGoneReorganization
// naming that epoch.
func epochRequireGone(t *testing.T, ctx context.Context, fixture EpochFixture, store string, address Address, epoch int, why string) {
t.Helper()
serves, err := fixture.StillServes(ctx, store, address)
if err != nil {
t.Fatalf("StillServes(%s): %v", address, err)
}
if serves {
t.Errorf("StillServes(%s) = true, want false: %s", address, why)
}
answer, err := fixture.Resolve(ctx, store, address)
if err != nil {
t.Fatalf("Resolve(%s): %v", address, err)
}
if answer.Restriction != RestrictionGoneReorganization {
t.Errorf("Resolve(%s) = %s, want RestrictionGoneReorganization: %s", address, answer.Restriction, why)
}
epochRequireAnswerEpoch(t, answer, address, epoch, why)
}
// epochRequireAnswerEpoch asserts that a Live or Gone answer names the current
// epoch (R20-n: the answer carries the epoch, not just the Restriction).
func epochRequireAnswerEpoch(t *testing.T, answer RetentionAnswer, address Address, epoch int, why string) {
t.Helper()
if answer.Epoch == nil {
t.Errorf("Resolve(%s).Epoch = nil, want the current epoch %d: %s", address, epoch, why)
return
}
if *answer.Epoch != epoch {
t.Errorf("Resolve(%s).Epoch = %d, want the current epoch %d: %s", address, *answer.Epoch, epoch, why)
}
}
// sameRetentionAnswer compares two RetentionAnswer values by content rather
// than identity, so a case can assert "this did not change" without
// depending on the concrete Restriction the backend happened to pick.

View file

@ -63,7 +63,6 @@ var roleContractCases = []roleContract{
RunBatchApplyCloseItemsAnswerToTheCloseGuards,
RunBatchApplyRefusesADottedChildGatedOnItsOwnParent,
RunBatchApplyAppliesTheDefaultPriority,
RunBatchApplyCarriesTheGateMembers,
),
roleCases("BatchCloser", "BatchCloser()", oncePerRole,
@ -128,7 +127,6 @@ var roleContractCases = []roleContract{
RunBlockingAnnotatorRefusesAnEmptyID,
RunBlockingAnnotatorLeavesTheRequestAlone,
RunBlockingAnnotatorWritesNothing,
RunBlockingAnnotatorReportsTheTransitiveBlockedFlag,
),
// One contract file covers both halves of workspace identity: the eight
@ -464,8 +462,6 @@ var roleContractCases = []roleContract{
RunLifecycleCreateWritesEveryScalarField,
RunLifecycleCreateEchoesSubSecondTimestamps,
RunLifecycleCreateAppliesTheDefaultPriority,
RunLifecycleCreateWritesTheGateMembers,
RunLifecycleCreateBoundsTheGateMembers,
),
roleCases("LifecycleUpdate", "IssueLifecycle()", oncePerRole,
@ -492,13 +488,9 @@ var roleContractCases = []roleContract{
RunLifecycleUpdateParentIDReplacesTheParentEdge,
RunLifecycleUpdateParentIDReplacesEveryParent,
RunLifecycleUpdatePersistentPreservesUnversionedClass,
RunLifecycleUpdateWispModesRefuseAnUnversionedRow,
RunLifecycleUpdatePersistentPromotesAWisp,
RunLifecycleUpdateProvenanceLabelsHistory,
RunLifecycleUpdateRefusesATemplate,
RunLifecycleUpdateAllowTemplateEditsATemplate,
RunLifecycleUpdatePatchesTheGateMembers,
RunLifecycleUpdateBoundsTheGateMembers,
),
roleCases("Memories", "Memories()", oncePerRole,
@ -513,7 +505,7 @@ var roleContractCases = []roleContract{
RunMemoriesRememberRefusesAnUnderivableKey,
RunMemoriesRecallAnswersTheStoredValue,
RunMemoriesRecallReportsAMissAsNotFoundNotAnError,
RunMemoriesEmptyRowIsPresentUntilForgotten,
RunMemoriesRecallConflatesStoredEmptyWithAbsent,
RunMemoriesForgetRemovesExactlyTheNamedRow,
RunMemoriesForgetNeverTouchesTheSettingsPlane,
RunMemoriesForgetReportsTheForgottenValue,
@ -576,7 +568,6 @@ var roleContractCases = []roleContract{
RunReaderListKeysetPositionResumesTheCreatedDescIDAscOrder,
RunReaderListReadyFlagAnswersTheBlockerAwareSet,
RunReaderListReadyFlagRefusesAFilterItCannotCarry,
RunReaderListQueryMatchesTheTitleOrTheID,
RunReaderListEmptyPageIsWellFormed,
RunReaderListMaxRowsIsHonored,
RunReaderListMaxRowsBoundaryIsLimitPlusOffset,
@ -604,8 +595,6 @@ var roleContractCases = []roleContract{
RunReaderListWispTypeNarrowsTheAdmittedPlaneRatherThanAdmittingIt,
RunReaderListBriefDropsTheFreeFormTextAndNothingElse,
RunReaderReadyBriefDropsTheFreeFormTextAndNothingElse,
RunReaderListTimeBoundsAreStrictAndWholeSecond,
RunReaderListFilterFamiliesNarrowToTheirRows,
),
roleCases("ReadyClaimer", "ReadyClaimer() and IssueReader()", oncePerRole,

View file

@ -129,14 +129,5 @@ func TestVersionedHistoryPhase0RunsInFullSkipMode(t *testing.T) {
t.Run("EpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed", func(t *testing.T) {
RunEpochBumpVoidsOnlyAddressesOfVersionsNoLongerServed(t, ctx, fixture)
})
t.Run("TokenSchemeChangeCarriesLiveAddressesAndOnlyThose", func(t *testing.T) {
RunTokenSchemeChangeCarriesLiveAddressesAndOnlyThose(t, ctx, fixture)
})
t.Run("ACarriedAddressKeepsResolvingAcrossLaterBumps", func(t *testing.T) {
RunACarriedAddressKeepsResolvingAcrossLaterBumps(t, ctx, fixture)
})
t.Run("ALostAddressStaysGoneAcrossASchemeChange", func(t *testing.T) {
RunALostAddressStaysGoneAcrossASchemeChange(t, ctx, fixture)
})
})
}

View file

@ -1,356 +0,0 @@
package conformance
import (
"context"
"testing"
"time"
)
// This file holds the contract for R7.1 (gastownhall/beads#6136, design doc
// gastownhall/beads#5898 revision 9): the as-of read — the "versioned
// reads" half of Phase 3's title, authored here from scratch, since no
// fixture for it exists anywhere in this package to un-skip.
//
// R7.1, VERBATIM (design doc #5898 rev 9): "An as-of read is a named read
// whose selector is an instant. Given an instant T or a version address, a
// store returns one Bead's durable state as of that point — the latest
// version it holds that was accepted at or before T, with everything later
// excluded — under R7's record shape, marking the address it served, or
// refuses as gone or unknown with the reason (R8, R20). Like every history
// answer it is complete for the answering store's holdings and may change
// after a sync (TC3)."
//
// ADDRESS, RESTRICTION, AND CHANGEATTRIBUTION ARE DECLARED IN
// expected_revision_contract.go — see that file's package-level note on
// where this suite's shared vocabulary lives and why. This file reuses
// Restriction's five values as-is for the gone-or-unknown refusal outcome
// (R8): an as-of read never invents a sixth state, and never distinguishes
// "gone" from "unknown" any differently than R20 already does.
//
// EVERY HOOK ON THE FIXTURE BELOW IS INDEPENDENTLY NILABLE — see the
// package-level note in expected_revision_contract.go. Every case
// nil-checks every hook it uses and SKIPS BY NAME when one is missing. No
// backend implements as-of reads yet — the implementation is
// the child this suite is written ahead of.
//
// EXPLICIT NON-GOAL: MEMORY-PLANE CONSUMER POLICY IS NOT PART OF THIS
// PRIMITIVE. R7.1's own text is explicit that a closed-before-T boundary,
// sibling exclusion, and supersession exclusion "are Memory-plane policies
// a consumer layers on this primitive (#5877), not part of it." This suite
// does not implement or assert any of the three — a future reader who finds
// them absent should read that as this file honoring R7.1's own scope, not
// as an oversight. This is the read-side analog of the R16/R16.1 boundary
// risk already recorded in expected_revision_contract.go: do not conflate
// the primitive with policy layered on top of it.
//
// THIS SUITE ASSERTS LOCAL COMPLETENESS ONLY (TC3). Nothing below requires,
// or even checks, that two stores asked about the same lineage agree — R7.1
// itself says an as-of answer "may change after a sync," so two stores at
// different sync points are expected to answer differently, and neither is
// wrong. RunAsOfReadIsCompleteOnlyForTheAnsweringStoresHoldings is the one
// case that touches more than one store, and what it asserts is exactly
// this: each store answers strictly from its own holdings, never a
// sibling's — not that the two agree.
// AsOfSelector names the point R7.1 resolves against: either a wall-clock
// instant, or a specific version Address treated as the selector itself —
// "the read that names its own answer" (R7.1: "an instant T or a version
// address"). Exactly one of At/Version is populated in every case this file
// exercises; R7.1 does not speak to the shape where both or neither are
// set, so this suite does not either.
type AsOfSelector struct {
At *time.Time
Version *Address
}
// AsOfReadRefusal is R8's typed outcome for an as-of read that cannot be
// answered. Restriction is always one of the four Gone*/Unknown values,
// never RestrictionLive — a live answer is a served AsOfReadResult, not a
// refusal. Reason explains why (R8).
type AsOfReadRefusal struct {
Restriction Restriction
Reason string
}
// AsOfReadResult is the outcome of an as-of read (R7.1). Address/State and
// Refusal are mutually exclusive: read Address/State only when Refusal is
// nil.
type AsOfReadResult struct {
// Address is the version this read served, marking "the address it
// served" (R7.1). Populated only when Refusal is nil.
Address Address
// State is the served version's durable state under R7's record shape.
// Opaque to this suite: the fixture adapter translates a backend's real
// record shape into this map, and no case here asserts its field-level
// content — only that a served result carries an Address.
State map[string]any
// Refusal is populated instead of Address/State when the read cannot be
// answered (R8). Nil means the read was served.
Refusal *AsOfReadRefusal
}
// AsOfRead resolves storeID's answer to an as-of read against id's lineage,
// at selector (R7.1).
type AsOfRead func(ctx context.Context, storeID, id string, selector AsOfSelector) (AsOfReadResult, error)
// AsOfReadFixture supplies the capability under test for R7.1: a read whose
// selector is an instant or a version address, resolving to the latest
// version accepted at or before that point, or a typed refusal.
type AsOfReadFixture struct {
IssuePrefix string
// Resolve performs the as-of read under test (R7.1). A nil hook means
// this backend does not implement as-of reads yet, and every case in
// this file skips with that reason.
Resolve AsOfRead
// MintAt mints a fresh version for id under storeID, recorded as
// accepted at the given instant, and returns its Address. Cases use
// this to build a lineage with known accept-times to resolve an as-of
// read against. A nil hook means this backend has no way to mint a
// version at a controlled accept-time, and cases that need one skip
// with that reason.
MintAt func(ctx context.Context, storeID, id string, acceptedAt time.Time) (Address, error)
// MakeUnanswerable arranges for id to be unanswerable at storeID for
// the given Restriction (one of RestrictionGoneRetention/GoneErasure/
// GoneReorganization/Unknown) — independently of
// RetentionFixture/EpochFixture's own removal machinery, since R7.1's
// refusal is a sibling contract to R17/R20, not a dependent of them. A
// nil hook means this backend has no way to arrange this, and the case
// that needs it skips with that reason.
MakeUnanswerable func(ctx context.Context, storeID, id string, restriction Restriction) error
}
// RunAsOfReadSelectorAcceptsEitherAnInstantOrAVersionAddress pins R7.1's
// selector shape: an instant T and the version address that instant
// resolves to are two names for the same answer, and a store must accept
// either.
func RunAsOfReadSelectorAcceptsEitherAnInstantOrAVersionAddress(t *testing.T, ctx context.Context, fixture AsOfReadFixture) {
t.Helper()
if fixture.Resolve == nil {
t.Skip("this backend does not implement as-of reads (Resolve is nil)")
}
if fixture.MintAt == nil {
t.Skip("this backend has no way to mint a version at a controlled accept-time (MintAt is nil)")
}
store := asOfReadStore(fixture, "selector-kinds")
id := fixture.IssuePrefix + "-asof-selector"
t0 := time.Now().UTC().Add(-time.Hour)
asOfReadMint(t, ctx, fixture, store, id, t0)
t1 := t0.Add(time.Minute)
second := asOfReadMint(t, ctx, fixture, store, id, t1)
byInstant, err := fixture.Resolve(ctx, store, id, AsOfSelector{At: &t1})
if err != nil {
t.Fatalf("Resolve(selector=instant): %v", err)
}
if byInstant.Refusal != nil {
t.Fatalf("Resolve(selector=instant) = %+v, want a served result", byInstant)
}
byVersion, err := fixture.Resolve(ctx, store, id, AsOfSelector{Version: &second})
if err != nil {
t.Fatalf("Resolve(selector=version address): %v", err)
}
if byVersion.Refusal != nil {
t.Fatalf("Resolve(selector=version address) = %+v, want a served result", byVersion)
}
if byInstant.Address != second {
t.Errorf("Resolve(selector=instant matching a version's own accept-time).Address = %s, want %s", byInstant.Address, second)
}
if byVersion.Address != second {
t.Errorf("Resolve(selector=version address).Address = %s, want the same address named %s", byVersion.Address, second)
}
if byInstant.Address != byVersion.Address {
t.Errorf("an instant selector (served %s) and a version-address selector naming the same version (served %s) resolved to different addresses; R7.1 accepts either as a name for the same answer", byInstant.Address, byVersion.Address)
}
}
// RunAsOfReadReturnsTheLatestVersionAtOrBeforeTStrictlyExcludingLater pins
// R7.1's ordering promise: resolving at T returns the latest version
// accepted at or before T, and a version accepted after T is excluded even
// when its own instant is close by.
func RunAsOfReadReturnsTheLatestVersionAtOrBeforeTStrictlyExcludingLater(t *testing.T, ctx context.Context, fixture AsOfReadFixture) {
t.Helper()
if fixture.Resolve == nil {
t.Skip("this backend does not implement as-of reads (Resolve is nil)")
}
if fixture.MintAt == nil {
t.Skip("this backend has no way to mint a version at a controlled accept-time (MintAt is nil)")
}
store := asOfReadStore(fixture, "ordering")
id := fixture.IssuePrefix + "-asof-ordering"
t0 := time.Now().UTC().Add(-time.Hour)
asOfReadMint(t, ctx, fixture, store, id, t0)
t1 := t0.Add(time.Minute)
middle := asOfReadMint(t, ctx, fixture, store, id, t1)
t2 := t0.Add(2 * time.Minute)
asOfReadMint(t, ctx, fixture, store, id, t2)
atExactly, err := fixture.Resolve(ctx, store, id, AsOfSelector{At: &t1})
if err != nil {
t.Fatalf("Resolve(T=middle's own instant): %v", err)
}
if atExactly.Refusal != nil || atExactly.Address != middle {
t.Errorf("Resolve(T=middle's own instant) = %+v, want the version accepted exactly at T (%s), not a later one", atExactly, middle)
}
between := t1.Add(30 * time.Second)
betweenResult, err := fixture.Resolve(ctx, store, id, AsOfSelector{At: &between})
if err != nil {
t.Fatalf("Resolve(T strictly between two versions): %v", err)
}
if betweenResult.Refusal != nil || betweenResult.Address != middle {
t.Errorf("Resolve(T strictly between two versions) = %+v, want the latest version at-or-before T (%s); the version accepted after T must be strictly excluded", betweenResult, middle)
}
}
// RunAsOfReadReportsTheAddressItServed pins R7.1's "marking the address it
// served": a served result names the exact Address of the version it
// returned, not merely a truthy success.
func RunAsOfReadReportsTheAddressItServed(t *testing.T, ctx context.Context, fixture AsOfReadFixture) {
t.Helper()
if fixture.Resolve == nil {
t.Skip("this backend does not implement as-of reads (Resolve is nil)")
}
if fixture.MintAt == nil {
t.Skip("this backend has no way to mint a version at a controlled accept-time (MintAt is nil)")
}
store := asOfReadStore(fixture, "reports-address")
id := fixture.IssuePrefix + "-asof-reports-address"
at := time.Now().UTC()
address := asOfReadMint(t, ctx, fixture, store, id, at)
result, err := fixture.Resolve(ctx, store, id, AsOfSelector{At: &at})
if err != nil {
t.Fatalf("Resolve: %v", err)
}
if result.Refusal != nil {
t.Fatalf("Resolve = %+v, want a served result", result)
}
if result.Address == "" {
t.Fatal("Resolve returned an empty Address on a served result, want the address of the version it served (R7.1)")
}
if result.Address != address {
t.Errorf("Resolve(...).Address = %s, want the served version's own address %s", result.Address, address)
}
}
// RunAsOfReadRefusesAsGoneOrUnknownNeverSubstitutingAnotherVersion pins R8:
// a read that cannot be answered refuses as a typed Gone or Unknown outcome
// with a reason, and never silently returns a neighboring version, the
// nearest surviving version, or current state as a substitute — R8's own
// text names all three as non-answers.
func RunAsOfReadRefusesAsGoneOrUnknownNeverSubstitutingAnotherVersion(t *testing.T, ctx context.Context, fixture AsOfReadFixture) {
t.Helper()
if fixture.Resolve == nil {
t.Skip("this backend does not implement as-of reads (Resolve is nil)")
}
if fixture.MintAt == nil {
t.Skip("this backend has no way to mint a version at a controlled accept-time (MintAt is nil)")
}
if fixture.MakeUnanswerable == nil {
t.Skip("this backend has no way to make a lineage unanswerable (MakeUnanswerable is nil)")
}
for _, restriction := range []Restriction{
RestrictionGoneRetention,
RestrictionGoneErasure,
RestrictionGoneReorganization,
RestrictionUnknown,
} {
t.Run(restriction.String(), func(t *testing.T) {
store := asOfReadStore(fixture, "unanswerable-"+restriction.String())
id := fixture.IssuePrefix + "-asof-unanswerable-" + restriction.String()
at := time.Now().UTC()
address := asOfReadMint(t, ctx, fixture, store, id, at)
if err := fixture.MakeUnanswerable(ctx, store, id, restriction); err != nil {
t.Fatalf("MakeUnanswerable(%s, %s): %v", id, restriction, err)
}
result, err := fixture.Resolve(ctx, store, id, AsOfSelector{At: &at})
if err != nil {
t.Fatalf("Resolve after MakeUnanswerable(%s): %v", restriction, err)
}
if result.Refusal == nil {
t.Fatalf("Resolve after MakeUnanswerable(%s) = %+v, want a Refusal, not a served result (R8)", restriction, result)
}
if result.Refusal.Restriction != restriction {
t.Errorf("Refusal.Restriction = %s, want %s", result.Refusal.Restriction, restriction)
}
if result.Refusal.Reason == "" {
t.Error("Refusal.Reason is empty, want a reason (R8)")
}
if result.Address != "" {
t.Errorf("Resolve on a refusal returned Address = %s, want empty: R8 forbids silently substituting a neighboring version, the nearest surviving version, or current state (the pre-refusal address was %s)", result.Address, address)
}
})
}
}
// RunAsOfReadIsCompleteOnlyForTheAnsweringStoresHoldings pins R7.1's closing
// clause and TC3: an as-of answer "is complete for the answering store's
// holdings and may change after a sync." This case asserts NOTHING about
// agreement between two stores asked about the same lineage — proving that
// absence is the point, not a gap. It mints a lineage into exactly one of
// two stores and confirms each store answers strictly from its own
// holdings: the store that holds the lineage serves it, and the store that
// never received it answers Unknown (FR-06, reused from R20) rather than
// reaching across to a sibling store's knowledge, erroring, or answering
// Gone — which would claim knowledge of a lineage it never held.
func RunAsOfReadIsCompleteOnlyForTheAnsweringStoresHoldings(t *testing.T, ctx context.Context, fixture AsOfReadFixture) {
t.Helper()
if fixture.Resolve == nil {
t.Skip("this backend does not implement as-of reads (Resolve is nil)")
}
if fixture.MintAt == nil {
t.Skip("this backend has no way to mint a version at a controlled accept-time (MintAt is nil)")
}
holds := asOfReadStore(fixture, "tc3-holds-the-lineage")
neverSynced := asOfReadStore(fixture, "tc3-never-synced")
id := fixture.IssuePrefix + "-asof-tc3"
at := time.Now().UTC()
address := asOfReadMint(t, ctx, fixture, holds, id, at)
local, err := fixture.Resolve(ctx, holds, id, AsOfSelector{At: &at})
if err != nil {
t.Fatalf("Resolve on the store that holds the lineage: %v", err)
}
if local.Refusal != nil || local.Address != address {
t.Fatalf("Resolve on the store that holds the lineage = %+v, want it served from that store's own holdings (%s)", local, address)
}
remote, err := fixture.Resolve(ctx, neverSynced, id, AsOfSelector{At: &at})
if err != nil {
t.Fatalf("Resolve on a store that never received this lineage: %v", err)
}
if remote.Refusal == nil {
t.Fatalf("Resolve on a store that never received this lineage = %+v, want a Refusal: an as-of answer is complete for the answering store's own holdings, not a sibling's (TC3)", remote)
}
if remote.Refusal.Restriction != RestrictionUnknown {
t.Errorf("Refusal.Restriction on the never-synced store = %s, want RestrictionUnknown: no lineage knowledge is Unknown, not Gone (FR-06)", remote.Refusal.Restriction)
}
}
// --- fixture helpers -------------------------------------------------------
// asOfReadStore names a storeID namespaced by the fixture's IssuePrefix and
// tag, so cases that need more than one store (e.g. the TC3 local-
// completeness case) get independent ones.
func asOfReadStore(fixture AsOfReadFixture, tag string) string {
return fixture.IssuePrefix + "-asof-store-" + tag
}
// asOfReadMint mints a version for id on store at the given instant via
// fixture.MintAt, fataling the case if minting fails.
func asOfReadMint(t *testing.T, ctx context.Context, fixture AsOfReadFixture, store, id string, at time.Time) Address {
t.Helper()
address, err := fixture.MintAt(ctx, store, id, at)
if err != nil {
t.Fatalf("MintAt(%s, %s, %s): %v", store, id, at, err)
}
return address
}

View file

@ -31,26 +31,8 @@ go_test(
timeout = "long",
srcs = [
"attach_test.go",
"e2e_blocked_flags_test.go",
"e2e_blocked_test.go",
"e2e_cli_test.go",
"e2e_export_test.go",
"e2e_gates_test.go",
"e2e_heartbeat_test.go",
"e2e_link_test.go",
"e2e_list_filters_test.go",
"e2e_list_page_edges_test.go",
"e2e_mol_test.go",
"e2e_promote_test.go",
"e2e_read_your_own_write_test.go",
"e2e_recompute_blocked_test.go",
"e2e_remote_roles_test.go",
"e2e_request_budget_test.go",
"e2e_search_test.go",
"e2e_show_current_test.go",
"e2e_show_single_fetch_test.go",
"open_test.go",
"per_open_credential_test.go",
"register_test.go",
],
# The e2e files exec the real bd (bazeltest.PrebuiltBD); they run under
@ -67,7 +49,6 @@ go_test(
"//internal/storage/backends",
"//internal/storage/domain",
"//internal/storage/embeddeddolt",
"//internal/storage/issueops",
"//internal/testutil/bazeltest",
],
)
@ -76,28 +57,7 @@ go_test(
# in-process server over embedded Dolt and BEADS_HTTP_TEST_REQUIRED=1 turns a
# skip of that tier into a failure. http_test alone skips the TestE2E_* cases
# in every lane, because no lane sets those variables for it. It repeats
# http_test's `env` (go_test_pinned_shard.sh, like go_test_variant.sh, does
# not inherit it).
#
# Shard count: the package's tests are serial, and as one shard the target
# ran 235-394s on the lane's executors (2026-10-10..13), the embedded lane's
# longest action in most runs where it executed; the lane's other shards end
# by ~90-125s. The 19 TestE2E_* cases that take >= 3s are pinned
# (tools/bazel/go_test_pinned_shard.sh, served_pinned_shards.txt from
# tools/bazel/pin_shards.py --shards 6 --min-seconds 3) onto 6 shards, and
# the binary's round-robin runs the other ~28 (well under a second
# together) in the 7th. The durations are the maximum over two sharded runs
# of the lane (bazel.yml's bazel-embedded-served-testxml artifact): 11-90s
# each, ~770s together. The same test's time varied 2-5x between those runs
# with the executors' load, and sharded runs took up to 2x what the
# single-shard runs did, so size the pins from sharded runs of the lane,
# never from a single-shard or local one.
# Regenerate the manifest from PR runs' bazel-embedded-served-testxml
# artifacts (each http_served_test directory holds shard_*_of_7/test.xml;
# pass several runs, pin_shards.py takes each test's maximum):
# python3 tools/bazel/pin_shards.py --shards 6 --min-seconds 3 \
# --write backend/http/served_pinned_shards.txt \
# <run1>/http_served_test <run2>/http_served_test
# http_test's `env` (go_test_variant.sh).
#
# Tags:
# embedded: the embedded-Dolt tier; excluded from --config=prcore/ci,
@ -108,16 +68,14 @@ sh_test(
# -test.timeout=19m fires (with a goroutine dump) before Bazel's 1200s
# action limit (eternal under --config=embedded).
timeout = "eternal",
srcs = ["//tools/bazel:go_test_pinned_shard.sh"],
srcs = ["//tools/bazel:go_test_variant.sh"],
args = [
"$(rootpath :served_pinned_shards.txt)",
"$(rootpath :http_test)",
"-test.v",
"-test.count=1",
"-test.timeout=19m",
],
data = [
"served_pinned_shards.txt",
":http_test",
"//cmd/bd:bd_for_tests",
],
@ -126,7 +84,6 @@ sh_test(
"BEADS_TEST_BD_BINARY": "$(rlocationpath //cmd/bd:bd_for_tests)",
"BEADS_TEST_EMBEDDED_DOLT": "1",
},
shard_count = 7,
tags = ["embedded"],
)

View file

@ -1,146 +0,0 @@
load("@rules_go//go:def.bzl", "go_test")
load("@rules_shell//shell:sh_test.bzl", "sh_test")
go_test(
name = "corpus_test",
# The corpus runs every shape through the real bd (bazeltest.PrebuiltBD),
# served and embedded, under BEADS_TEST_EMBEDDED_DOLT=1 (corpus_served_test
# below); it skips otherwise.
size = "large",
timeout = "long",
srcs = [
"corpus_parts_test.go",
"corpus_test.go",
"gate_check_served_test.go",
"harness_test.go",
"reference_proxy_test.go",
"required_corpus_tier_test.go",
],
data = glob(["testdata/**"]) + ["//cmd/bd:bd_for_tests"],
env = {"BEADS_TEST_BD_BINARY": "$(rlocationpath //cmd/bd:bd_for_tests)"},
deps = [
"//internal/httpapi",
"//internal/httpapi/apigen",
"//internal/storage",
"//internal/storage/domain",
"//internal/storage/embeddeddolt",
"//internal/testutil/bazeltest",
"//internal/types",
"@in_gopkg_yaml_v3//:yaml_v3",
],
)
# corpus_test again, with the corpus tier on: BEADS_TEST_EMBEDDED_DOLT=1 runs
# TestServedCorpusPart1..N and BEADS_HTTP_TEST_REQUIRED=1 turns a skip of
# them into a failure. corpus_test alone skips them in every lane, because no
# lane sets those variables for it. It repeats corpus_test's `env`
# (go_test_pinned_shard.sh, like go_test_variant.sh, does not inherit it).
#
# Shard count: as one shard (one TestServedCorpus over every shape) the
# target ran 292-597s on the lane's executors (2026-10-11..13), the embedded
# lane's longest action in most runs where it executed. About 100s of that
# is the per-process server and seed, the rest the ~130 shapes (~1.9s each,
# serial, ~242s together). The shapes are now dealt round robin across
# corpusParts = 4 parts (corpus_test.go), each a top-level test with its own
# server and seed, and served_pinned_shards.txt pins part k to shard k; the
# 5th shard runs the package's other tests through the binary's
# round-robin (the engine-free ones, plus
# TestServedGateCheckOverAwaitTypedGates, which seeds its own small served
# store). Each part pays the setup again, though it seeds the served
# and embedded sides concurrently (~62-76s on the lane's executors), so a
# part's shard is that plus ~60s of shapes: 114-146s measured. Three parts
# ran 170-180s each; they save one setup (~75 test-seconds a run) but
# lengthen the lane's served long pole, which is on the gate's critical
# path, by ~34s.
#
# Tags:
# embedded: the embedded-Dolt tier; excluded from --config=prcore/ci,
# selected by --config=embedded.
sh_test(
name = "corpus_served_test",
size = "large",
# -test.timeout=19m fires (with a goroutine dump) before Bazel's 1200s
# action limit (eternal under --config=embedded).
timeout = "eternal",
srcs = ["//tools/bazel:go_test_pinned_shard.sh"],
args = [
"$(rootpath :served_pinned_shards.txt)",
"$(rootpath :corpus_test)",
"-test.v",
"-test.count=1",
"-test.timeout=19m",
],
data = [
"served_pinned_shards.txt",
":corpus_test",
"//cmd/bd:bd_for_tests",
],
env = {
"BEADS_HTTP_TEST_REQUIRED": "1",
"BEADS_TEST_BD_BINARY": "$(rlocationpath //cmd/bd:bd_for_tests)",
"BEADS_TEST_EMBEDDED_DOLT": "1",
},
shard_count = 5,
tags = ["embedded"],
)
# --- begin repo_files (managed by tools/bazel/go_srcs.py; run `make bazel-sync`) ---
filegroup(
name = "repo_doc_files",
srcs = glob(
[
"**/*.md",
"**/*.mdx",
],
allow_empty = True,
exclude = ["**/node_modules/**"],
),
visibility = ["//:__subpackages__"],
)
filegroup(
name = "repo_go_srcs",
srcs = glob(
["**/*.go"],
allow_empty = True,
exclude = [
"**/*_test.go",
"**/node_modules/**",
],
),
visibility = ["//:__subpackages__"],
)
filegroup(
name = "repo_go_test_srcs",
srcs = glob(
["**/*_test.go"],
allow_empty = True,
exclude = ["**/node_modules/**"],
),
visibility = ["//:__subpackages__"],
)
filegroup(
name = "repo_other_files",
srcs = glob(
["**"],
exclude = [
"**/*.db",
"**/*.exe",
"**/*.go",
"**/*.md",
"**/*.mdx",
"**/*.out",
"**/*.prof",
"**/*.pyc",
"**/*.test",
"**/__pycache__/**",
"**/node_modules/**",
],
),
visibility = ["//:__subpackages__"],
)
# --- end repo_files ---

View file

@ -1,154 +0,0 @@
# Served command corpus
This suite is the working definition of "bd fully supports a remote HTTP
backend". It runs every distinct `bd` command shape that an orchestrator (gc)
and its packs and formulas issue against a work store. Each shape runs
against a served workspace and is compared with the same command on an
embedded workspace.
## What runs
The shapes are dealt round robin, in corpus order, across `corpusParts`
parts (`corpus_test.go`). Each part is a top-level test,
`TestServedCorpusPart1` .. `TestServedCorpusPartN`, and each does the
following for its share of the shapes:
1. Builds `bd` from this tree. `BEADS_TEST_BD_BINARY=<path>` reuses a prebuilt
binary instead.
2. Starts an in-process `bd serve` (`httpapi.Listen` over embedded Dolt) the
way a deployed server is bound: `AllowNonLoopback` plus a bearer token
file. The socket is still `127.0.0.1`, but the bind mode decides every
behaviour the server keys on, including its refusal of unlimited reads.
3. Puts a reference proxy in front of the server. The proxy makes it answer
like the deployed reference server described in
`testdata/reference_server.json`:
- the context handshake publishes exactly that server's capability set and
its `ContextResponse` members (so no `wire_revision`);
- an operation the reference server does not publish gets the server's own
404;
- a query parameter or top-level request member it does not declare gets
the server's own 400 `unknown_parameter`.
4. Runs `bd connect` on one workspace and `bd init` on another. Both get the
`seed` from `testdata/corpus.yaml`: one graph of named rows, plus bulk
graphs that put more than one server page of ready rows and wisps in the
store. Both sides use `BEADS_ACTOR=worker` and set `CLAUDE_SESSION_ID`.
The embedded side is initialized and seeded on its own goroutine while
steps 2 and 3 run and the served side is seeded (`prepareSide`): the two
sides share no directory, env or process, and each runs the seed in
order, so the seeded data does not depend on the overlap.
5. Runs each of its shapes as a subtest, on both sides. The embedded run must
exit with the shape's `expect_exit` and match its `expect_stderr`. If it does
not, the shape is wrong or bd changed, and the subtest fails as a corpus
bug that no pending mark or allowlist entry hides. The served run must:
- exit like the embedded run;
- carry no refusal (`ErrUnsupported`, a v0-wire refusal, the
loopback-only 400, or a reference-profile 404/400);
- match the embedded output under the shape's `compare` mode, after
timestamps and revision tokens are dropped (but not `defer_until` or
`due_at`: a shape sets those itself, as absolute dates, and they must
match exactly);
- for writes, give the same JSON from every `verify` read on both sides
afterwards.
A part takes its own server, workspaces and seed, so no shape can see
another part's writes. That is safe because no shape depends on another
shape's effects:
- every check compares the served run with the embedded run after the same
commands, so it holds whatever ran before it on both sides;
- each part keeps corpus order, so its reads still run on the bare seed,
before any of its writes;
- each write owns its target ids (`e2e-t-*`, or ids it creates).
`TestCorpusPartsDealEveryShapeOnce` checks that every shape is in exactly one
part, in corpus order. A new shape must keep that independence: it may rely on
the seed and its own `setup`, never on another shape having run.
Every part seeds again, so running all the parts in one process takes
longer than one run over every shape did; each part logs its setup time
(`part N setup ...`). Run one part with
`-run 'TestServedCorpusPart2$'`.
There are four parts. In the embedded lane each part's setup (server start
plus both seeds, run concurrently) takes ~62-76s and the shapes ~242s in
total. Four parts ran 114-146s each and three ran 170-180s. Three would save
one setup (~75 test-seconds a run), but the longest part is the lane's
served long pole and sits on the CI gate's critical path, so four parts win.
To change the count, update `corpusParts`, `servedCorpusParts`,
`served_pinned_shards.txt` and the target's `shard_count` together.
```
CGO_ENABLED=1 BEADS_TEST_EMBEDDED_DOLT=1 BEADS_HTTP_TEST_REQUIRED=1 \
go test -tags gms_pure_go -run 'TestServedCorpus|TestCorpus' ./backend/http/corpus/
```
In CI, `//backend/http/corpus:corpus_served_test` runs the suite with both
variables set, in the Embedded Dolt lane (`--config=embedded`; see
[engdocs/TESTING.md](../../../engdocs/TESTING.md)). Its
`served_pinned_shards.txt` pins part k to Bazel shard k, so the parts run
concurrently. `corpus_test` on its own sets neither variable, so it skips
the parts.
Two environment variables change the run:
- `BEADS_CORPUS_REPORT=<file>` writes a JSON summary with per-shape status
and request counts.
- `BEADS_CORPUS_SKIP_PENDING=1` skips pending shapes without running them.
## The data
| File | Holds |
|---|---|
| `testdata/corpus.yaml` | assets, the seed, and the shapes |
| `testdata/allowlist.yaml` | permanent refusals, each with its reason and the refusal text the served run must match |
| `testdata/reference_server.json` | the reference server's wire surface |
Each shape in `corpus.yaml` has these fields:
| Field | Meaning |
|---|---|
| `id` | `gc-*` for orchestrator subprocess shapes, `mc-*` for pack/formula/prompt shapes |
| `source` | where the shape comes from |
| `args` | the argv; `{file:NAME}` expands to an asset path and `{rev:ID}` to that side's current revision of `ID` |
| `stdin` | text piped to `bd` on both sides |
| `setup` | commands run on both sides before the shape; one that fails fails the shape |
| `compare` | `json` (default), `ids`, `count`, `text` or `exit` |
| `ordered` | under `json` and `ids`, array order is significant; by default arrays are sorted before comparing |
| `prefix_of` | for a limited `ids` listing: its unlimited form. Each side's limited rows must be a prefix, in order, of that side's own unlimited listing, both sides return as many rows, and the two unlimited listings hold the same ids. A limit that cuts through a tie set (same priority, `created_at` in the same second) lands on different rows on two workspaces seeded seconds apart, so the limited rows are not compared across sides directly |
| `verify` | reads run after the shape |
| `ignore_fields` | JSON keys dropped, at any depth, before a `json` comparison and before `verify` output is compared; for example comment ids, which each workspace mints itself |
| `expect_exit`, `expect_stderr` | expected outcome on both sides (exit 0 by default). An allowlisted shape must state `expect_exit`; only its embedded run is held to these |
| `pending` | a known failure |
| `requests` | exactly how many requests the served run of `args` makes through the reference proxy, not counting `setup`, `verify` or `{rev:ID}` reads. Each request is a sequential round trip, so the count is the shape's latency floor over a gateway. A change that makes the shape cheaper updates the pin |
`pending: {slice, reason}` marks a known failure and names the slice or
slices that fix it, for example `S6c+S15`. A pending shape **still runs**:
- while it fails, the subtest is skipped and the skip records what was
observed;
- once it passes, the subtest fails with "now passes; remove the pending
mark".
So removing a mark is how a slice proves itself, and any other failure is
unexpected and fails the suite.
## Updating the reference profile
`reference_server.json` was derived from two things:
- the deployed server's live `GET /v0/beads/context` capabilities;
- its published OpenAPI document (bd 1.3.0, no `wire_revision`). For each
operation the profile keeps the method, the path template, the query
parameter names, and the top-level request members.
When the deployed server is upgraded (SRV-1), regenerate the file the same
way. Then remove the `SRV-1` pending marks that now pass.
## Known fidelity limits
- Responses pass through unfiltered. A response member the reference server
would not send still reaches the client.
- Only top-level request members are checked; nested members (for example
`batchApply` items) are not.
- The served backend underneath is embedded Dolt, not the reference
deployment's storage backend.
- Out of scope, because they are local by design or never touch a remote
store: `init`, `bootstrap`, `migrate`, `doctor`, `flatten`, `gc`, and the
`dolt` subcommands. `context`, `version`, `backup status` and `prime`
are in the corpus, but only checked for exit codes.

View file

@ -1,211 +0,0 @@
//go:build cgo
package corpus_test
import (
"context"
"errors"
"fmt"
"os"
"path/filepath"
"reflect"
"runtime"
"strings"
"sync"
"testing"
)
// TestCorpusPartsDealEveryShapeOnce runs without the embedded engine. It
// holds the deal TestServedCorpusPart1..N run to what makes splitting the
// corpus safe: every shape lands in exactly one part, each part keeps corpus
// order (so a part's reads still run before its writes, on its own fresh
// seed), no part is empty, and there is one TestServedCorpusPartN per part.
func TestCorpusPartsDealEveryShapeOnce(t *testing.T) {
if len(servedCorpusParts) != corpusParts {
t.Fatalf("servedCorpusParts has %d tests, want corpusParts = %d", len(servedCorpusParts), corpusParts)
}
c, _ := loadCorpus(t)
index := map[string]int{}
for i, s := range c.Shapes {
index[s.ID] = i
}
seen := map[string]int{}
for part := 1; part <= corpusParts; part++ {
shapes := corpusPart(c.Shapes, part)
if len(shapes) == 0 {
t.Errorf("part %d runs no shapes", part)
}
last := -1
for _, s := range shapes {
if prev, dup := seen[s.ID]; dup {
t.Errorf("shape %s is in part %d and part %d", s.ID, prev, part)
}
seen[s.ID] = part
i, ok := index[s.ID]
if !ok {
t.Errorf("part %d runs %s, which is not a corpus shape", part, s.ID)
continue
}
if i <= last {
t.Errorf("part %d runs %s out of corpus order", part, s.ID)
}
last = i
}
}
for _, s := range c.Shapes {
if _, ok := seen[s.ID]; !ok {
t.Errorf("shape %s is in no part", s.ID)
}
}
}
// The deal itself, on a corpus of 10 against 4 parts: round robin in corpus
// order.
func TestCorpusPartIsRoundRobinInOrder(t *testing.T) {
var shapes []shape
for i := 0; i < 10; i++ {
shapes = append(shapes, shape{ID: fmt.Sprint(i)})
}
want := map[int]string{1: "[0 4 8]", 2: "[1 5 9]", 3: "[2 6]", 4: "[3 7]"}
for part, w := range want {
var ids []string
for _, s := range corpusPartOf(shapes, part, 4) {
ids = append(ids, s.ID)
}
if got := fmt.Sprint(ids); got != w {
t.Errorf("part %d of 4 = %s, want %s", part, got, w)
}
}
}
// fakeBD writes a stand-in for bd that appends its arguments, one call per
// line, to calls.log in its working directory, and exits 3 when an argument
// is "boom".
func fakeBD(t *testing.T) string {
t.Helper()
bin := filepath.Join(t.TempDir(), "bd")
script := "#!/bin/sh\necho \"$*\" >> calls.log\nfor a in \"$@\"; do [ \"$a\" = boom ] && { echo boom >&2; exit 3; }; done\nexit 0\n"
if err := os.WriteFile(bin, []byte(script), 0o700); err != nil {
t.Fatal(err)
}
return bin
}
func calls(t *testing.T, sd *side) []string {
t.Helper()
raw, err := os.ReadFile(filepath.Join(sd.dir, "calls.log"))
if err != nil {
t.Fatal(err)
}
return strings.Split(strings.TrimSpace(string(raw)), "\n")
}
// prepareSide is what lets testServedCorpus seed the served and embedded
// sides at once: each side attaches, writes its assets and runs the seed in
// its own directories, in seed order, and a failure comes back as an error
// rather than a t.Fatal from a goroutine that is not the test's.
func TestPrepareSideSeedsBothSidesConcurrently(t *testing.T) {
bin := fakeBD(t)
c := &corpusFile{
Files: []corpusAsset{{Name: "plan.json", Content: "{}"}},
Seed: [][]string{{"create", "--graph", "{file:plan.json}"}, {"close", "e2e-x"}},
}
a := &side{name: "served", dir: t.TempDir(), files: t.TempDir()}
b := &side{name: "embedded", dir: t.TempDir(), files: t.TempDir()}
var wg sync.WaitGroup
errs := make([]error, 2)
for i, sd := range []*side{a, b} {
wg.Add(1)
go func() {
defer wg.Done()
errs[i] = prepareSide(context.Background(), t, bin, c, sd, []string{"init", sd.name})
}()
}
wg.Wait()
for i, sd := range []*side{a, b} {
if errs[i] != nil {
t.Fatalf("%s: %v", sd.name, errs[i])
}
want := []string{"init " + sd.name, "create --graph " + filepath.Join(sd.files, "plan.json"), "close e2e-x"}
if got := calls(t, sd); !reflect.DeepEqual(got, want) {
t.Errorf("%s ran %q, want %q", sd.name, got, want)
}
if _, err := os.Stat(filepath.Join(sd.files, "plan.json")); err != nil {
t.Errorf("%s: asset not written: %v", sd.name, err)
}
}
}
func TestPrepareSideReportsAFailedStepAsAnError(t *testing.T) {
bin := fakeBD(t)
c := &corpusFile{Seed: [][]string{{"create", "boom"}, {"close", "e2e-x"}}}
sd := &side{name: "embedded", dir: t.TempDir(), files: t.TempDir()}
err := prepareSide(context.Background(), t, bin, c, sd, []string{"init"})
if err == nil || !strings.Contains(err.Error(), "seed [create boom] on embedded failed") || !strings.Contains(err.Error(), "exit=3") {
t.Fatalf("err = %v, want the failed seed step with its exit", err)
}
if got := calls(t, sd); !reflect.DeepEqual(got, []string{"init", "create boom"}) {
t.Errorf("ran %q; the seed must stop at the failed step", got)
}
sd = &side{name: "served", dir: t.TempDir(), files: t.TempDir()}
if err := prepareSide(context.Background(), t, bin, c, sd, []string{"connect", "boom"}); err == nil || !strings.Contains(err.Error(), "bd connect boom on served") {
t.Fatalf("err = %v, want the failed attach", err)
}
}
// Once the other side has failed, the test cancels: a side stops before its
// next step instead of seeding on for nothing.
func TestPrepareSideStopsWhenCancelled(t *testing.T) {
bin := fakeBD(t)
c := &corpusFile{Seed: [][]string{{"create", "e2e-x"}}}
sd := &side{name: "embedded", dir: t.TempDir(), files: t.TempDir()}
ctx, cancel := context.WithCancel(context.Background())
cancel()
if err := prepareSide(ctx, t, bin, c, sd, []string{"init"}); !errors.Is(err, context.Canceled) {
t.Fatalf("err = %v, want context.Canceled", err)
}
if _, err := os.Stat(filepath.Join(sd.dir, "calls.log")); !os.IsNotExist(err) {
t.Errorf("bd ran after the cancel (calls.log: %v)", err)
}
}
// A part test wired to another part's number would run that part's shapes
// twice and drop its own without a word; testServedCorpus refuses to run
// unless the test's name is its part's (corpusPartNameErr).
func TestCorpusPartNameMustMatchItsPart(t *testing.T) {
if err := corpusPartNameErr("TestServedCorpusPart3", 3); err != nil {
t.Errorf("matching name: %v", err)
}
for _, c := range []struct {
name string
part int
}{
{"TestServedCorpusPart3", 2},
{"TestServedCorpusPart1", 10},
{"TestServedCorpusPart10", 1},
{"TestServedCorpusPart3/sub", 3},
{"TestServedCorpus", 1},
// A stray part past corpusParts would run no shapes at all.
{fmt.Sprintf("TestServedCorpusPart%d", corpusParts+1), corpusParts + 1},
{"TestServedCorpusPart0", 0},
} {
if err := corpusPartNameErr(c.name, c.part); err == nil {
t.Errorf("corpusPartNameErr(%q, %d) = nil, want a mismatch", c.name, c.part)
}
}
// Every wired part test passes the guard: run each with the engine
// off, so the guard (which comes first) is all that can fail it.
for k, fn := range servedCorpusParts {
want := fmt.Sprintf("TestServedCorpusPart%d", k+1)
if got := testFuncName(fn); got != want {
t.Errorf("servedCorpusParts[%d] is %s, want %s", k, got, want)
}
}
}
// testFuncName is fn's unqualified function name.
func testFuncName(fn func(*testing.T)) string {
full := runtime.FuncForPC(reflect.ValueOf(fn).Pointer()).Name()
return full[strings.LastIndex(full, ".")+1:]
}

View file

@ -1,968 +0,0 @@
//go:build cgo
// Package corpus_test is the served command-corpus suite: every distinct bd
// command shape an orchestrator (gc) and its packs/formulas issue, run by the
// real bd binary against an in-process bd serve masked to a reference
// deployment's wire surface, and compared with the same command on an embedded
// workspace. See README.md.
package corpus_test
import (
"context"
"encoding/json"
"errors"
"fmt"
"os"
"path/filepath"
"reflect"
"regexp"
"sort"
"strconv"
"strings"
"sync"
"testing"
"time"
"gopkg.in/yaml.v3"
)
// corpusFile is testdata/corpus.yaml.
type corpusFile struct {
Files []corpusAsset `yaml:"files"`
Seed [][]string `yaml:"seed"`
Shapes []shape `yaml:"shapes"`
}
// corpusAsset is a file the shapes reference as {file:NAME}. Exactly one of
// Content and Bulk is set.
type corpusAsset struct {
Name string `yaml:"name"`
Content string `yaml:"content"`
Bulk *bulkGraph `yaml:"bulk"`
}
// bulkGraph generates a `bd create --graph` plan of Count independent tasks
// with ids IDPrefix-001.. so the suite can hold more rows than one server page
// without a 100-line literal in the corpus.
type bulkGraph struct {
IDPrefix string `yaml:"id_prefix"`
Count int `yaml:"count"`
Priority int `yaml:"priority"`
Ephemeral bool `yaml:"ephemeral"`
Metadata map[string]string `yaml:"metadata"`
}
type shape struct {
ID string `yaml:"id"`
Source string `yaml:"source"`
// Args is the bd argv. Tokens may carry {file:NAME} (the side's copy of a
// corpus asset) and {rev:ID} (that side's current revision of ID).
Args []string `yaml:"args"`
Stdin string `yaml:"stdin"`
Setup [][]string `yaml:"setup"`
// Compare is how the served stdout is held to the embedded stdout:
// json (default), ids, count, text, or exit (exit code only).
Compare string `yaml:"compare"`
// Ordered keeps array order significant under json/ids.
Ordered bool `yaml:"ordered"`
// PrefixOf is the unlimited form of a limited listing (compare: ids). A
// limit cut through a tie set (same priority, created_at within one
// second) lands at a different row on two workspaces seeded seconds
// apart, so the limited rows are not compared across sides. Instead each
// side's limited rows must be, in order, a prefix of that SAME side's
// PrefixOf listing, both sides must return as many rows, and the two
// PrefixOf listings must hold the same ids.
PrefixOf []string `yaml:"prefix_of"`
// IgnoreFields are extra JSON keys dropped before comparing.
IgnoreFields []string `yaml:"ignore_fields"`
// ExpectExit is the exit code both sides must produce (default 0). An
// allowlisted shape must state it: the embedded run is held to it even
// though the served run is only held to the allowlisted refusal.
ExpectExit *int `yaml:"expect_exit"`
// ExpectStderr, when set, must match both sides' stderr (only the
// embedded side's on an allowlisted shape).
ExpectStderr string `yaml:"expect_stderr"`
// Verify are reads run on both sides after the shape and compared as json:
// how a write is checked for having done the same thing on both backends.
Verify [][]string `yaml:"verify"`
// Requests, when set, is exactly how many requests the served run of Args
// makes through the reference proxy (not its setup or verify reads). Each
// is a sequential round trip, so the count is the shape's latency floor
// over a gateway: a change that adds one fails here, and one that saves
// one updates the pin.
Requests *int `yaml:"requests"`
// Pending marks a known failure and names the slice that fixes it.
Pending *pending `yaml:"pending"`
}
// wantExit is the exit code the embedded run must produce.
func (s shape) wantExit() int {
if s.ExpectExit == nil {
return 0
}
return *s.ExpectExit
}
type pending struct {
Slice string `yaml:"slice"`
Reason string `yaml:"reason"`
}
// allowEntry is testdata/allowlist.yaml: a shape that is EXPECTED to be
// refused over http, permanently, for a stated reason. The served run must
// fail and match Refusal; if it ever succeeds the entry is stale and fails.
// The embedded run is still held to the shape's expect_exit and
// expect_stderr, and nothing else of the shape is checked.
type allowEntry struct {
ID string `yaml:"id"`
Reason string `yaml:"reason"`
Refusal string `yaml:"refusal"`
}
// refusalMarkers are the texts a refusal of an operation over http carries:
// issueops.ErrUnsupported, encode.RefusedError, the client's capability
// preflight (wire.CapabilityError, which never reaches the proxy), the
// server's loopback-only unlimited-read 400, an unrouted 404, and a strict
// decoder's unknown member.
var refusalMarkers = regexp.MustCompile(`(?i)not supported by the|not expressible on the v0 wire|loopback-only|capability "[^"]+" not advertised|does not advertise capability|no such route on this server|unknown_parameter|unknown query parameter|json: unknown field`)
// volatileKey names JSON members that legitimately differ between two
// workspaces fed the same commands: timestamps and revision tokens.
var volatileKey = regexp.MustCompile(`(^|_)at$|^revision$|^row_version$|^expected_revision$|^current_revision$`)
// callerTimeKey names the timestamps a shape's own arguments set (bd create
// --defer, --due). They are compared as given, neither dropped as volatile
// nor scrubbed to <ts>, so a client that sends the wrong one fails; a shape
// must give them as absolute dates, since a relative one resolves against
// each side's own clock.
var callerTimeKey = map[string]bool{"defer_until": true, "due_at": true}
var timestampText = regexp.MustCompile(`\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}(:\d{2}(\.\d+)?)?(Z|[+-]\d{2}:?\d{2})?`)
func loadCorpus(t *testing.T) (*corpusFile, map[string]allowEntry) {
t.Helper()
raw, err := os.ReadFile("testdata/corpus.yaml")
if err != nil {
t.Fatalf("read corpus: %v", err)
}
var c corpusFile
dec := yaml.NewDecoder(strings.NewReader(string(raw)))
dec.KnownFields(true)
if err := dec.Decode(&c); err != nil {
t.Fatalf("parse testdata/corpus.yaml: %v", err)
}
rawAllow, err := os.ReadFile("testdata/allowlist.yaml")
if err != nil {
t.Fatalf("read allowlist: %v", err)
}
var entries []allowEntry
dec = yaml.NewDecoder(strings.NewReader(string(rawAllow)))
dec.KnownFields(true)
if err := dec.Decode(&entries); err != nil {
t.Fatalf("parse testdata/allowlist.yaml: %v", err)
}
allow := map[string]allowEntry{}
for _, e := range entries {
if e.ID == "" || strings.TrimSpace(e.Reason) == "" || e.Refusal == "" {
t.Fatalf("allowlist entry %+v needs id, reason and refusal", e)
}
allow[e.ID] = e
}
return &c, allow
}
// TestCorpusFileIsWellFormed runs without the embedded engine: it keeps the
// data honest (unique ids, a source and a slice for every pending mark, no
// allowlist entry for a shape that does not exist, no shape both pending and
// allowlisted, an allowlisted shape states its embedded exit code and
// carries no check that the allowlist would skip, every expect_stderr and
// refusal compiles, and the reference profile loads).
func TestCorpusFileIsWellFormed(t *testing.T) {
c, allow := loadCorpus(t)
seen := map[string]bool{}
for _, s := range c.Shapes {
if s.ID == "" || len(s.Args) == 0 {
t.Errorf("shape %+v needs an id and args", s)
continue
}
if seen[s.ID] {
t.Errorf("duplicate shape id %q", s.ID)
}
seen[s.ID] = true
if strings.TrimSpace(s.Source) == "" {
t.Errorf("shape %s names no source", s.ID)
}
if s.Pending != nil && (s.Pending.Slice == "" || strings.TrimSpace(s.Pending.Reason) == "") {
t.Errorf("shape %s is pending without a slice and a reason", s.ID)
}
if _, ok := allow[s.ID]; ok {
if s.Pending != nil {
t.Errorf("shape %s is both pending and allowlisted; pick one", s.ID)
}
if s.ExpectExit == nil {
t.Errorf("shape %s is allowlisted without expect_exit; state the exit code the embedded run must produce", s.ID)
}
if modeOf(s) != "exit" || len(s.Verify) > 0 {
t.Errorf("shape %s is allowlisted, so only its exit code and stderr are checked; give it compare: exit and no verify", s.ID)
}
if s.Requests != nil {
t.Errorf("shape %s is allowlisted, so its request count is not checked; drop requests", s.ID)
}
}
switch s.Compare {
case "", "json", "ids", "count", "text", "exit":
default:
t.Errorf("shape %s: unknown compare mode %q", s.ID, s.Compare)
}
if len(s.PrefixOf) > 0 && s.Compare != "ids" {
t.Errorf("shape %s: prefix_of needs compare: ids", s.ID)
}
if _, err := regexp.Compile(s.ExpectStderr); err != nil {
t.Errorf("shape %s: expect_stderr: %v", s.ID, err)
}
if s.Requests != nil && *s.Requests < 0 {
t.Errorf("shape %s: requests %d is negative", s.ID, *s.Requests)
}
}
for id, entry := range allow {
if !seen[id] {
t.Errorf("allowlist names %q, which is not a corpus shape", id)
}
if _, err := regexp.Compile(entry.Refusal); err != nil {
t.Errorf("allowlist entry %s: refusal: %v", id, err)
}
}
for _, a := range c.Files {
if (a.Content == "") == (a.Bulk == nil) {
t.Errorf("asset %s needs exactly one of content and bulk", a.Name)
}
}
loadReferenceProfile(t)
}
// side is one workspace the corpus runs in.
type side struct {
name string
dir string
files string
env []string
}
type outcome struct {
id, status, detail string
requests int64
}
// corpusParts is how many parts the shapes are dealt across. Each part is a
// top-level test of its own (TestServedCorpusPart1..N, servedCorpusParts)
// that starts its own server and seeds its own pair of workspaces, so the
// embedded lane runs each part in a Bazel shard of its own
// (served_pinned_shards.txt pins part k to shard k). The parts can be split
// because no shape depends on another's effects: every comparison is the
// served side against the embedded side after the same commands, and each
// part keeps corpus order, so its reads still run on the bare seed before
// any of its writes (see testdata/corpus.yaml's header).
//
// Four parts, from the embedded lane's measured part times (PR #7538): each
// part's server start and concurrent seed take ~62-76s and the 127 shapes
// ~242s together, so four parts ran 114-146s each and three ran 170-180s.
// Three would save one setup (~75 test-seconds a run), but the longest part
// is the embedded lane's served long pole, on the gate's critical path
// (forks' above all), so the ~34s it saves is worth more.
const corpusParts = 4
// servedCorpusParts are the parts' tests, one per part, in part order.
var servedCorpusParts = []func(*testing.T){
TestServedCorpusPart1, TestServedCorpusPart2, TestServedCorpusPart3, TestServedCorpusPart4,
}
func TestServedCorpusPart1(t *testing.T) { testServedCorpus(t, 1) }
func TestServedCorpusPart2(t *testing.T) { testServedCorpus(t, 2) }
func TestServedCorpusPart3(t *testing.T) { testServedCorpus(t, 3) }
func TestServedCorpusPart4(t *testing.T) { testServedCorpus(t, 4) }
// corpusPartNameErr fails a part test whose name is not its part's: a
// TestServedCorpusPart3 that ran part 2 would run part 2's shapes twice and
// silently drop its own. A part outside 1..corpusParts (a stray
// TestServedCorpusPart5 left after the parts shrink) would run no shapes.
func corpusPartNameErr(name string, part int) error {
if part < 1 || part > corpusParts {
return fmt.Errorf("%s runs corpus part %d; there are parts 1..%d (corpusParts)", name, part, corpusParts)
}
if want := fmt.Sprintf("TestServedCorpusPart%d", part); name != want {
return fmt.Errorf("%s runs corpus part %d; only %s may (fix its testServedCorpus call)", name, part, want)
}
return nil
}
// corpusPart returns the shapes part (1..corpusParts) runs.
func corpusPart(shapes []shape, part int) []shape {
return corpusPartOf(shapes, part, corpusParts)
}
// corpusPartOf deals shapes round robin, in corpus order, across parts parts
// and returns part's (1-based) share: shapes part-1, part-1+parts, and so on.
// Round robin keeps each part a mix of the corpus's reads and writes in
// their original order.
func corpusPartOf(shapes []shape, part, parts int) []shape {
var out []shape
for i := part - 1; i < len(shapes); i += parts {
out = append(out, shapes[i])
}
return out
}
// testServedCorpus is the suite, for one part of the corpus. Each shape is a
// subtest; a pending shape is still RUN and then skipped with what it did, so
// a slice that fixes it sees the subtest fail with "now passes; remove the
// pending mark". BEADS_CORPUS_SKIP_PENDING=1 skips pending shapes without
// running them. BEADS_CORPUS_REPORT=<path> writes a JSON summary of every
// part this process has run.
func testServedCorpus(t *testing.T, part int) {
// First, before the engine gate: a part test wired to the wrong part
// fails in every lane, not only where the corpus runs.
if err := corpusPartNameErr(t.Name(), part); err != nil {
t.Fatal(err)
}
skipUnlessEmbeddedDolt(t)
c, allow := loadCorpus(t)
shapes := corpusPart(c.Shapes, part)
profile := loadReferenceProfile(t)
bin := buildBD(t)
common := []string{
"BEADS_ACTOR=worker",
"CLAUDE_SESSION_ID=corpus-session-s23",
"BD_BACKUP_ENABLED=false",
"BD_EXPORT_AUTO=false",
}
// The embedded side needs no server: init and seed it on a goroutine
// while this one starts the server and seeds the served side. Each side
// has its own directories, env and bd processes (prepareSide), and each
// still runs the seed in order, so the seeded data is what it was when
// the two sides were seeded command by command in turn. The deferred
// cancel and Wait run on every exit, a t.Fatal included, so the goroutine
// never outlives the test or its TempDirs.
setupStart := time.Now()
ctx, cancel := context.WithCancel(context.Background())
var seeding sync.WaitGroup
defer seeding.Wait()
defer cancel()
local := &side{name: "embedded", dir: t.TempDir(), files: t.TempDir(), env: common}
var localErr error
seeding.Add(1)
go func() {
defer seeding.Done()
localErr = prepareSide(ctx, t, bin, c, local,
[]string{"init", "-p", corpusPrefix, "--non-interactive", "--skip-hooks", "--skip-agents", "-q"})
if localErr != nil {
cancel()
}
}()
serverAddr := startCorpusServer(t)
proxy := newReferenceProxy(t, profile, serverAddr)
proxyAddr := startProxy(t, proxy)
served := &side{name: "served", dir: t.TempDir(), files: t.TempDir(),
env: append([]string{"BEADS_HTTP_TOKEN=" + proxyAddr + "=" + corpusToken}, common...)}
servedErr := prepareSide(ctx, t, bin, c, served,
[]string{"connect", "http://" + proxyAddr, "--expect-project-id", corpusProjectID, "--json"})
if servedErr != nil {
cancel()
}
seeding.Wait()
// The side that failed first is the one to report; the other may only
// have seen the cancel.
for _, err := range []error{servedErr, localErr} {
if err != nil && !errors.Is(err, context.Canceled) {
t.Fatal(err)
}
}
t.Logf("part %d setup (server start and both sides seeded concurrently): %s", part, time.Since(setupStart).Round(100*time.Millisecond))
proxy.takeRefusals()
skipPending := os.Getenv("BEADS_CORPUS_SKIP_PENDING") == "1"
var outcomes []outcome
for _, s := range shapes {
s := s
t.Run(s.ID, func(t *testing.T) {
o := outcome{id: s.ID}
defer func() { outcomes = append(outcomes, o) }()
if s.Pending != nil && skipPending {
o.status = "pending:" + s.Pending.Slice
t.Skipf("pending %s: %s", s.Pending.Slice, s.Pending.Reason)
}
before := proxy.requests.Load()
failures := runShape(t, bin, s, served, local, allow, proxy)
o.requests = proxy.requests.Load() - before
entry, allowed := allow[s.ID]
switch {
case hasCorpusBug(failures):
// The embedded side itself disagrees with the corpus: no pending
// mark or allowlist entry may hide that, or a pending shape that
// can never pass would sit in the corpus forever.
o.status = "FAIL(corpus)"
o.detail = failures[0]
for _, f := range failures {
t.Error(f)
}
case s.Pending != nil && len(failures) == 0:
o.status = "FAIL(pending-now-passes)"
t.Errorf("shape is marked pending %s but now passes on the reference profile; remove the pending mark from testdata/corpus.yaml", s.Pending.Slice)
case s.Pending != nil:
o.status = "pending:" + s.Pending.Slice
o.detail = failures[0]
t.Skipf("pending %s: %s\nobserved:\n%s", s.Pending.Slice, s.Pending.Reason, strings.Join(failures, "\n"))
case len(failures) > 0:
o.status = "FAIL"
o.detail = failures[0]
for _, f := range failures {
t.Error(f)
}
case allowed:
o.status = "allowed"
o.detail = entry.Reason
default:
o.status = "pass"
}
})
}
summarize(t, part, len(c.Shapes), outcomes)
}
// runShape runs one shape on both sides and returns every way the served run
// fell short. It never calls t.Error itself, so the caller can turn a pending
// shape's failures into a skip.
func runShape(t *testing.T, bin string, s shape, served, local *side, allow map[string]allowEntry, proxy *referenceProxy) []string {
t.Helper()
var fails []string
failf := func(format string, a ...any) { fails = append(fails, fmt.Sprintf(format, a...)) }
wantStderr, err := regexp.Compile(s.ExpectStderr)
if err != nil {
failf("CORPUS BUG: expect_stderr %q: %v", s.ExpectStderr, err)
return fails
}
for _, args := range s.Setup {
for _, sd := range []*side{served, local} {
if r := runBD(t, bin, sd.dir, sd.env, "", expand(context.Background(), t, bin, sd, args)...); r.code != 0 {
failf("setup %v failed on %s: %s", args, sd.name, r)
return fails
}
}
}
proxy.takeRefusals()
args := expand(context.Background(), t, bin, served, s.Args)
before := proxy.requests.Load()
sr := runBD(t, bin, served.dir, served.env, s.Stdin, args...)
servedRequests := proxy.requests.Load() - before
wireRefusals := proxy.takeRefusals()
lr := runBD(t, bin, local.dir, local.env, s.Stdin, expand(context.Background(), t, bin, local, s.Args)...)
t.Logf("bd %s\nserved: %s\nembedded: exit=%d", strings.Join(s.Args, " "), sr, lr.code)
if len(wireRefusals) > 0 {
t.Logf("reference-profile refusals on the wire: %v", wireRefusals)
}
// The embedded run is the oracle for every shape, an allowlisted one
// included: when it no longer does what the shape says, the shape is
// wrong or bd changed, whatever the served run did.
if lr.code != s.wantExit() {
failf("CORPUS BUG: the embedded run exited %d, want %d; the shape itself is wrong or bd changed: %s", lr.code, s.wantExit(), lr)
return fails
}
if s.ExpectStderr != "" && !wantStderr.MatchString(lr.stderr) {
failf("CORPUS BUG: embedded stderr does not match %q: %s", s.ExpectStderr, lr.stderr)
return fails
}
if entry, ok := allow[s.ID]; ok {
re, err := regexp.Compile(entry.Refusal)
if err != nil {
failf("allowlist refusal regexp for %s: %v", s.ID, err)
return fails
}
if sr.code == 0 {
failf("allowlisted (%s) but the served run SUCCEEDED; drop it from testdata/allowlist.yaml and give it a comparison", entry.Reason)
} else if !re.MatchString(sr.stderr + sr.stdout) {
failf("allowlisted refusal did not match %q (a different failure than the one allowed): %s", entry.Refusal, sr)
}
return fails
}
if m := refusalMarkers.FindString(sr.stderr + sr.stdout); m != "" {
failf("served run carries a refusal (%q): %s", m, sr)
} else if len(wireRefusals) > 0 && sr.code != 0 {
failf("served run failed on a reference-profile refusal %v: %s", wireRefusals, sr)
}
if sr.code != lr.code {
failf("exit code: served %d, embedded %d: %s", sr.code, lr.code, sr)
}
if s.ExpectStderr != "" && !wantStderr.MatchString(sr.stderr) {
failf("served stderr does not match %q (embedded does): %s", s.ExpectStderr, sr)
}
if s.Requests != nil && servedRequests != int64(*s.Requests) {
failf("the served run made %d requests, want exactly %d (requests); a change that saves one updates the pin", servedRequests, *s.Requests)
}
if len(fails) > 0 {
return fails
}
if len(s.PrefixOf) > 0 {
vs := runBD(t, bin, served.dir, served.env, "", expand(context.Background(), t, bin, served, s.PrefixOf)...)
vl := runBD(t, bin, local.dir, local.env, "", expand(context.Background(), t, bin, local, s.PrefixOf)...)
if vs.code != 0 || vl.code != 0 {
failf("prefix_of %v: exit served %d, embedded %d: served %s", s.PrefixOf, vs.code, vl.code, vs)
} else if d := comparePrefix(sr.stdout, lr.stdout, vs.stdout, vl.stdout); d != "" {
failf("output parity (ids, prefix_of): %s", d)
}
} else if d := compareOutputs(s, sr.stdout, lr.stdout); d != "" {
failf("output parity (%s): %s", modeOf(s), d)
}
for _, args := range s.Verify {
vs := runBD(t, bin, served.dir, served.env, "", expand(context.Background(), t, bin, served, args)...)
vl := runBD(t, bin, local.dir, local.env, "", expand(context.Background(), t, bin, local, args)...)
if vs.code != vl.code {
failf("verify %v: exit served %d, embedded %d: served %s", args, vs.code, vl.code, vs)
continue
}
if vl.code != 0 {
continue // both refused the read (e.g. a deleted id): equal is the check
}
if d := compareJSON(vs.stdout, vl.stdout, s.IgnoreFields, false); d != "" {
failf("verify %v diverged after the write: %s", args, d)
}
}
return fails
}
func hasCorpusBug(failures []string) bool {
for _, f := range failures {
if strings.HasPrefix(f, "CORPUS BUG") {
return true
}
}
return false
}
func modeOf(s shape) string {
if s.Compare == "" {
return "json"
}
return s.Compare
}
func compareOutputs(s shape, served, local string) string {
switch modeOf(s) {
case "exit":
return ""
case "text":
a, b := scrubText(served), scrubText(local)
if a != b {
return fmt.Sprintf("text differs\nserved:\n%s\nembedded:\n%s", clip(a, 3000), clip(b, 3000))
}
return ""
case "count":
a, errA := topLevelLen(served)
b, errB := topLevelLen(local)
if errA != nil || errB != nil {
return fmt.Sprintf("count: served err=%v embedded err=%v\nserved:\n%s", errA, errB, clip(served, 2000))
}
if a != b {
return fmt.Sprintf("row count: served %d, embedded %d", a, b)
}
return ""
case "ids":
a, errA := idList(served, s.Ordered)
b, errB := idList(local, s.Ordered)
if errA != nil || errB != nil {
return fmt.Sprintf("ids: served err=%v embedded err=%v\nserved:\n%s", errA, errB, clip(served, 2000))
}
if !reflect.DeepEqual(a, b) {
return fmt.Sprintf("ids differ\nserved (%d): %v\nembedded (%d): %v", len(a), a, len(b), b)
}
return ""
default:
return compareJSON(served, local, s.IgnoreFields, s.Ordered)
}
}
// comparePrefix holds a limited listing to its unlimited form on each side:
// see shape.PrefixOf.
func comparePrefix(served, local, servedAll, localAll string) string {
lists := make([][]string, 4)
for i, out := range []string{served, local, servedAll, localAll} {
ids, err := idList(out, true)
if err != nil {
return fmt.Sprintf("listing %d: %v\n%s", i, err, clip(out, 2000))
}
lists[i] = ids
}
s, l, sAll, lAll := lists[0], lists[1], lists[2], lists[3]
if len(s) != len(l) {
return fmt.Sprintf("row count: served %d, embedded %d", len(s), len(l))
}
for _, c := range []struct {
name string
rows, all []string
}{{"served", s, sAll}, {"embedded", l, lAll}} {
if len(c.rows) > len(c.all) || !reflect.DeepEqual(c.rows, c.all[:len(c.rows)]) {
return fmt.Sprintf("%s limited rows are not a prefix of its own unlimited listing\nlimited: %v\nunlimited: %v", c.name, c.rows, c.all)
}
}
sSet := append([]string(nil), sAll...)
lSet := append([]string(nil), lAll...)
sort.Strings(sSet)
sort.Strings(lSet)
if !reflect.DeepEqual(sSet, lSet) {
return fmt.Sprintf("unlimited ids differ\nserved (%d): %v\nembedded (%d): %v", len(sSet), sSet, len(lSet), lSet)
}
return ""
}
func scrubText(s string) string {
return strings.TrimSpace(timestampText.ReplaceAllString(s, "<ts>"))
}
func decode(s string) (any, error) {
var v any
if err := json.Unmarshal([]byte(strings.TrimSpace(s)), &v); err != nil {
return nil, fmt.Errorf("not JSON: %w", err)
}
return v, nil
}
// rows finds the row array in a bd --json payload: the payload itself, or the
// first array member of an envelope object.
func rows(v any) ([]any, bool) {
switch x := v.(type) {
case []any:
return x, true
case map[string]any:
for _, k := range []string{"issues", "data", "items", "results"} {
if arr, ok := x[k].([]any); ok {
return arr, true
}
}
}
return nil, false
}
func topLevelLen(s string) (int, error) {
v, err := decode(s)
if err != nil {
return 0, err
}
arr, ok := rows(v)
if !ok {
return 0, fmt.Errorf("no row array in output")
}
return len(arr), nil
}
func idList(s string, ordered bool) ([]string, error) {
v, err := decode(s)
if err != nil {
return nil, err
}
arr, ok := rows(v)
if !ok {
return nil, fmt.Errorf("no row array in output")
}
out := []string{}
for _, r := range arr {
if m, ok := r.(map[string]any); ok {
if id, ok := m["id"].(string); ok {
out = append(out, id)
}
}
}
if !ordered {
sort.Strings(out)
}
return out, nil
}
func compareJSON(served, local string, ignore []string, ordered bool) string {
a, errA := decode(served)
b, errB := decode(local)
if errA != nil || errB != nil {
return fmt.Sprintf("served err=%v embedded err=%v\nserved:\n%s\nembedded:\n%s", errA, errB, clip(served, 2000), clip(local, 2000))
}
drop := map[string]bool{}
for _, k := range ignore {
drop[k] = true
}
a, b = normalize(a, drop, ordered), normalize(b, drop, ordered)
if path, x, y, same := firstDiff("$", a, b); !same {
return fmt.Sprintf("first difference at %s: served=%s embedded=%s", path, brief(x), brief(y))
}
return ""
}
func normalize(v any, drop map[string]bool, ordered bool) any {
switch x := v.(type) {
case map[string]any:
out := make(map[string]any, len(x))
for k, val := range x {
if drop[k] {
continue
}
if callerTimeKey[k] {
out[k] = val
continue
}
if volatileKey.MatchString(k) {
continue
}
out[k] = normalize(val, drop, ordered)
}
return out
case []any:
out := make([]any, len(x))
for i, e := range x {
out[i] = normalize(e, drop, ordered)
}
if !ordered {
sort.SliceStable(out, func(i, j int) bool { return sortKey(out[i]) < sortKey(out[j]) })
}
return out
case string:
return timestampText.ReplaceAllString(x, "<ts>")
default:
return v
}
}
func sortKey(v any) string {
if m, ok := v.(map[string]any); ok {
for _, k := range []string{"id", "issue_id", "key"} {
if s, ok := m[k].(string); ok {
return k + "=" + s
}
}
if inner, ok := m["issue"].(map[string]any); ok {
if s, ok := inner["id"].(string); ok {
return "issue.id=" + s
}
}
}
raw, _ := json.Marshal(v)
return string(raw)
}
func firstDiff(path string, a, b any) (string, any, any, bool) {
switch x := a.(type) {
case map[string]any:
y, ok := b.(map[string]any)
if !ok {
return path, a, b, false
}
keys := map[string]bool{}
for k := range x {
keys[k] = true
}
for k := range y {
keys[k] = true
}
sorted := make([]string, 0, len(keys))
for k := range keys {
sorted = append(sorted, k)
}
sort.Strings(sorted)
for _, k := range sorted {
xv, xok := x[k]
yv, yok := y[k]
if !xok || !yok {
return path + "." + k, xv, yv, false
}
if p, l, r, same := firstDiff(path+"."+k, xv, yv); !same {
return p, l, r, false
}
}
return "", nil, nil, true
case []any:
y, ok := b.([]any)
if !ok {
return path, a, b, false
}
if len(x) != len(y) {
return path + ".length", len(x), len(y), false
}
for i := range x {
if p, l, r, same := firstDiff(path+"["+strconv.Itoa(i)+"]", x[i], y[i]); !same {
return p, l, r, false
}
}
return "", nil, nil, true
default:
if reflect.DeepEqual(a, b) {
return "", nil, nil, true
}
return path, a, b, false
}
}
func brief(v any) string {
if v == nil {
return "<absent>"
}
raw, _ := json.Marshal(v)
return clip(string(raw), 400)
}
var placeholder = regexp.MustCompile(`\{(file|rev):([^}]+)\}`)
// expand substitutes {file:NAME} and {rev:ID} in args for side sd. It never
// fails t (a {rev:} it cannot read becomes "0"), so prepareSide may call it
// off the test's goroutine; its {rev:} lookup runs under ctx, so a cancelled
// prepareSide starts no further bd there either.
func expand(ctx context.Context, t *testing.T, bin string, sd *side, args []string) []string {
t.Helper()
out := make([]string, len(args))
for i, a := range args {
out[i] = placeholder.ReplaceAllStringFunc(a, func(m string) string {
parts := placeholder.FindStringSubmatch(m)
switch parts[1] {
case "file":
return filepath.Join(sd.files, parts[2])
default:
r, err := execBD(ctx, bin, sd.dir, sd.env, "", "show", parts[2], "--json")
if err != nil {
t.Logf("{rev:%s} on %s: %v", parts[2], sd.name, err)
return "0"
}
if r.code != 0 {
t.Logf("{rev:%s} on %s: show failed: %s", parts[2], sd.name, r)
return "0"
}
v, err := decode(r.stdout)
if err != nil {
return "0"
}
if arr, ok := rows(v); ok && len(arr) > 0 {
v = arr[0]
}
if m, ok := v.(map[string]any); ok {
if rev, ok := m["revision"].(string); ok {
return rev
}
}
return "0"
}
})
}
return out
}
// prepareSide attaches sd to its store with bd attach (connect or init),
// writes the corpus's asset files into sd.files and runs the seed on sd, in
// order. It touches only sd's own directories and bd processes and returns a
// failure as an error instead of failing t, so testServedCorpus runs it for
// the two sides at once; it stops before its next bd once ctx is done.
func prepareSide(ctx context.Context, t *testing.T, bin string, c *corpusFile, sd *side, attach []string) error {
t.Helper()
r, err := execBD(ctx, bin, sd.dir, sd.env, "", attach...)
if err != nil {
return err
}
if r.code != 0 {
return fmt.Errorf("bd %s on %s: %s", strings.Join(attach, " "), sd.name, r)
}
if err := writeAssets(c.Files, sd.files); err != nil {
return fmt.Errorf("%s: %w", sd.name, err)
}
for _, args := range c.Seed {
if err := ctx.Err(); err != nil {
return err
}
r, err := execBD(ctx, bin, sd.dir, sd.env, "", expand(ctx, t, bin, sd, args)...)
if err != nil {
return err
}
if r.code != 0 {
return fmt.Errorf("seed %v on %s failed; the seed must use shapes that work on the reference profile: %s", args, sd.name, r)
}
}
return nil
}
func writeAssets(assets []corpusAsset, dir string) error {
for _, a := range assets {
content := a.Content
if a.Bulk != nil {
content = bulkPlan(*a.Bulk)
}
if err := os.WriteFile(filepath.Join(dir, a.Name), []byte(content), 0o600); err != nil {
return fmt.Errorf("write asset %s: %w", a.Name, err)
}
}
return nil
}
func bulkPlan(b bulkGraph) string {
type node struct {
Key string `json:"key"`
ID string `json:"id"`
Title string `json:"title"`
Type string `json:"type"`
Priority int `json:"priority"`
Ephemeral bool `json:"ephemeral,omitempty"`
Metadata map[string]string `json:"metadata,omitempty"`
}
plan := struct {
CommitMessage string `json:"commit_message"`
Nodes []node `json:"nodes"`
}{CommitMessage: "corpus bulk " + b.IDPrefix}
for i := 1; i <= b.Count; i++ {
id := fmt.Sprintf("%s-%03d", b.IDPrefix, i)
plan.Nodes = append(plan.Nodes, node{Key: id, ID: id, Title: "bulk " + id, Type: "task",
Priority: b.Priority, Ephemeral: b.Ephemeral, Metadata: b.Metadata})
}
raw, _ := json.MarshalIndent(plan, "", " ")
return string(raw)
}
// reported is every outcome of every part this process has run, in the order
// the parts ran, for BEADS_CORPUS_REPORT.
var reported []outcome
func summarize(t *testing.T, part, total int, outcomes []outcome) {
t.Helper()
counts := map[string]int{}
var lines []string
for _, o := range outcomes {
key := o.status
if strings.HasPrefix(key, "pending:") {
key = "pending"
}
counts[key]++
lines = append(lines, fmt.Sprintf("%-26s %-48s req=%-3d %s", o.status, o.id, o.requests, firstLine(o.detail)))
}
t.Logf("corpus summary, part %d of %d (%d of %d shapes): %v\n%s", part, corpusParts, len(outcomes), total, counts, strings.Join(lines, "\n"))
reported = append(reported, outcomes...)
if path := os.Getenv("BEADS_CORPUS_REPORT"); path != "" {
type row struct {
ID string `json:"id"`
Status string `json:"status"`
Requests int64 `json:"requests"`
Detail string `json:"detail,omitempty"`
}
var out []row
for _, o := range reported {
out = append(out, row{o.id, o.status, o.requests, o.detail})
}
raw, _ := json.MarshalIndent(out, "", " ")
if err := os.WriteFile(path, raw, 0o600); err != nil {
t.Errorf("write BEADS_CORPUS_REPORT: %v", err)
}
}
}
func firstLine(s string) string {
s = strings.TrimSpace(s)
if i := strings.IndexByte(s, '\n'); i >= 0 {
s = s[:i]
}
return clip(s, 160)
}

View file

@ -1,355 +0,0 @@
//go:build cgo
package corpus_test
import (
"context"
"encoding/json"
"net/http"
"os"
"path/filepath"
"slices"
"strings"
"sync"
"testing"
"time"
"github.com/steveyegge/beads/internal/httpapi"
"github.com/steveyegge/beads/internal/storage/embeddeddolt"
"github.com/steveyegge/beads/internal/types"
)
// gateCheckRequestLog records every request the reference proxy forwards.
type gateCheckRequestLog struct {
mu sync.Mutex
seen []string
next http.Handler
}
func (l *gateCheckRequestLog) ServeHTTP(w http.ResponseWriter, r *http.Request) {
l.mu.Lock()
l.seen = append(l.seen, r.Method+" "+r.URL.Path)
l.mu.Unlock()
l.next.ServeHTTP(w, r)
}
func (l *gateCheckRequestLog) take() []string {
l.mu.Lock()
defer l.mu.Unlock()
out := l.seen
l.seen = nil
return out
}
func gateCheckWrites(reqs []string) []string {
var writes []string
for _, r := range reqs {
if !strings.HasPrefix(r, http.MethodGet+" ") {
writes = append(writes, r)
}
}
return writes
}
// TestServedGateCheckOverAwaitTypedGates runs `bd gate check` over HTTP, through
// the reference proxy, against REAL await-typed gates, on a server that
// advertises neither gate token (issues.create.gates, issues.update.gates; the
// profile is masked here, so this holds whatever reference_server.json
// advertises). No create through it carries await_*: the gates are seeded
// straight into the served store before it listens, and every outcome is read
// back from that store:
//
// - --dry-run writes nothing;
// - an expired timer closes, a pending one stays open;
// - a bead gate whose target is open records its sighting (issues.update),
// and one whose target is closed closes;
// - a merged gh:pr gate closes, a closed one escalates and stays open;
// - a gh:run gate with a workflow-name hint discovers its run but cannot
// persist await_id through a server without issues.update.gates: the
// client refuses the patch before the dial, that gate's error names the
// missing token and the server, not a Go method, and await_id is
// untouched;
// - a persisted proto's gates are templates: listed, but no sweep evaluates
// or writes them, and they take no row of --limit (they sort first here).
//
// The corpus.yaml shapes prove the listing only (their gates have no
// await_type); this is the test that proves what the sweep does to the gates.
func TestServedGateCheckOverAwaitTypedGates(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
ctx := context.Background()
store, err := embeddeddolt.Open(ctx, t.TempDir(), corpusDatabase, "main")
if err != nil {
t.Fatalf("open the served store: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if err := store.SetConfig(ctx, "issue_prefix", corpusPrefix); err != nil {
t.Fatalf("set the issue prefix: %v", err)
}
// The templates keep P0 and every other row gets P2, so the store's default
// order puts the template gates ahead of every live one.
seed := func(i *types.Issue) {
t.Helper()
i.Status = types.StatusOpen
i.Title = i.ID
if !i.IsTemplate {
i.Priority = 2
}
if err := store.CreateIssue(ctx, i, "seed"); err != nil {
t.Fatalf("seed %s: %v", i.ID, err)
}
}
seed(&types.Issue{ID: "e2e-tgt-open", IssueType: "task"})
seed(&types.Issue{ID: "e2e-tgt-closed", IssueType: "task"})
if err := store.CloseIssue(ctx, "e2e-tgt-closed", "done", "seed", ""); err != nil {
t.Fatalf("close e2e-tgt-closed: %v", err)
}
seed(&types.Issue{ID: "e2e-g-timer", IssueType: "gate", AwaitType: "timer", Timeout: time.Millisecond})
seed(&types.Issue{ID: "e2e-g-timer-pending", IssueType: "gate", AwaitType: "timer", Timeout: 100 * time.Hour})
seed(&types.Issue{ID: "e2e-g-bead-open", IssueType: "gate", AwaitType: "bead", AwaitID: "e2e-tgt-open"})
seed(&types.Issue{ID: "e2e-g-bead-closed", IssueType: "gate", AwaitType: "bead", AwaitID: "e2e-tgt-closed"})
seed(&types.Issue{ID: "e2e-g-pr-merged", IssueType: "gate", AwaitType: "gh:pr", AwaitID: "11"})
seed(&types.Issue{ID: "e2e-g-pr-closed", IssueType: "gate", AwaitType: "gh:pr", AwaitID: "12"})
seed(&types.Issue{ID: "e2e-g-run-hint", IssueType: "gate", AwaitType: "gh:run", AwaitID: "ci-wf"})
seed(&types.Issue{ID: "e2e-tpl-timer", IssueType: "gate", AwaitType: "timer", Timeout: time.Millisecond, IsTemplate: true})
seed(&types.Issue{ID: "e2e-tpl-bead", IssueType: "gate", AwaitType: "bead", AwaitID: "e2e-tgt-open", IsTemplate: true})
seed(&types.Issue{ID: "e2e-tpl-run", IssueType: "gate", AwaitType: "gh:run", AwaitID: "ci-wf", IsTemplate: true})
tokenFile := filepath.Join(t.TempDir(), "tokens")
if err := os.WriteFile(tokenFile, []byte(corpusToken+"\n"), 0o600); err != nil {
t.Fatalf("write the token file: %v", err)
}
auth, err := httpapi.NewTokenFileAuth(tokenFile)
if err != nil {
t.Fatalf("load the token file: %v", err)
}
cfg := corpusServeConfig(t, store)
cfg.AllowNonLoopback = true
cfg.Auth = auth
srv, err := httpapi.Listen(cfg)
if err != nil {
t.Fatalf("bind the in-process server: %v", err)
}
serveCtx, cancel := context.WithCancel(context.Background())
done := make(chan struct{})
go func() { defer close(done); _ = srv.Serve(serveCtx) }()
t.Cleanup(func() {
cancel()
select {
case <-done:
case <-time.After(30 * time.Second):
t.Error("the in-process server did not shut down")
}
})
// The gh:run case pins a server that cannot take an await_id patch, so the
// profile is held without issues.update.gates whatever
// reference_server.json advertises: upgrading the reference profile must
// not turn this case into a different test.
profile := loadReferenceProfile(t)
profile.Capabilities = slices.DeleteFunc(profile.Capabilities, func(c string) bool { return c == "issues.update.gates" })
proxy := newReferenceProxy(t, profile, srv.Addr())
reqs := &gateCheckRequestLog{next: proxy}
proxyAddr := startProxy(t, reqs)
// gh and gt are fakes on PATH: gh answers the run discovery and the two PR
// states, gt records each escalation.
binDir := t.TempDir()
gh := `#!/bin/sh
case "$1 $2" in
"run list") echo '[{"databaseId":4242,"name":"ci-wf","status":"completed","conclusion":"success","createdAt":"2026-10-15T00:00:00Z","workflowName":"ci-wf"}]' ;;
"run view") echo '{"status":"completed","conclusion":"success","name":"ci-wf"}' ;;
"pr view") if [ "$3" = "11" ]; then echo '{"state":"MERGED","title":"m"}'; else echo '{"state":"CLOSED","title":"c"}'; fi ;;
*) echo "unexpected gh $*" >&2; exit 3 ;;
esac
`
if err := os.WriteFile(filepath.Join(binDir, "gh"), []byte(gh), 0o755); err != nil {
t.Fatalf("write fake gh: %v", err)
}
if err := os.WriteFile(filepath.Join(binDir, "gt"), []byte("#!/bin/sh\nexit 0\n"), 0o755); err != nil {
t.Fatalf("write fake gt: %v", err)
}
dir := t.TempDir()
env := []string{
"BEADS_HTTP_TOKEN=" + proxyAddr + "=" + corpusToken,
"BEADS_ACTOR=worker",
"BD_BACKUP_ENABLED=false",
"BD_EXPORT_AUTO=false",
"PATH=" + binDir + string(os.PathListSeparator) + os.Getenv("PATH"),
}
if r := runBD(t, bin, dir, env, "", "connect", "http://"+proxyAddr, "--expect-project-id", corpusProjectID, "--json"); r.code != 0 {
t.Fatalf("bd connect: %s", r)
}
reqs.take()
time.Sleep(50 * time.Millisecond) // the 1ms timer is expired by now
get := func(id string) *types.Issue {
t.Helper()
issue, err := store.GetIssue(ctx, id)
if err != nil {
t.Fatalf("read %s back: %v", id, err)
}
return issue
}
wantStatus := func(id string, want types.Status) {
t.Helper()
if got := get(id).Status; got != want {
t.Errorf("%s status = %s, want %s", id, got, want)
}
}
seenOf := func(id string) string {
t.Helper()
var meta map[string]json.RawMessage
raw := get(id).Metadata
if len(raw) == 0 {
return ""
}
if err := json.Unmarshal(raw, &meta); err != nil {
t.Fatalf("%s metadata %s: %v", id, raw, err)
}
var seen string
_ = json.Unmarshal(meta["await_seen"], &seen)
return seen
}
allGates := []string{"e2e-g-timer", "e2e-g-timer-pending", "e2e-g-bead-open", "e2e-g-bead-closed", "e2e-g-pr-merged", "e2e-g-pr-closed", "e2e-g-run-hint"}
t.Run("dry-run writes nothing", func(t *testing.T) {
r := runBD(t, bin, dir, env, "", "gate", "check", "--dry-run")
if r.code != 0 {
t.Fatalf("bd gate check --dry-run: %s", r)
}
if w := gateCheckWrites(reqs.take()); len(w) != 0 {
t.Fatalf("--dry-run sent writes %v\n%s", w, r)
}
for _, id := range allGates {
wantStatus(id, types.StatusOpen)
}
if seen := seenOf("e2e-g-bead-open"); seen != "" {
t.Errorf("--dry-run recorded a sighting %q", seen)
}
if got := get("e2e-g-run-hint").AwaitID; got != "ci-wf" {
t.Errorf("--dry-run persisted await_id %q", got)
}
})
t.Run("limit counts only live gates", func(t *testing.T) {
// bd gate list still lists templates, so its first three rows show the
// order the sweep's own listing would be cut from.
r := runBD(t, bin, dir, env, "", "gate", "list", "--limit", "3", "--json")
var listed []types.Issue
if start := strings.Index(r.stdout, "["); r.code != 0 || start < 0 || json.Unmarshal([]byte(r.stdout[start:]), &listed) != nil {
t.Fatalf("bd gate list --limit 3 --json: %s", r)
}
var ids []string
for _, g := range listed {
if strings.HasPrefix(g.ID, "e2e-tpl-") {
ids = append(ids, g.ID)
}
}
if len(listed) != 3 || len(ids) != 3 {
t.Fatalf("bd gate list --limit 3 listed %d gates, %d of them templates (%v), want the three template gates first", len(listed), len(ids), ids)
}
reqs.take()
r = runBD(t, bin, dir, env, "", "gate", "check", "--dry-run", "--limit", "3")
if r.code != 0 {
t.Fatalf("bd gate check --dry-run --limit 3: %s", r)
}
if w := gateCheckWrites(reqs.take()); len(w) != 0 {
t.Fatalf("--dry-run sent writes %v\n%s", w, r)
}
if !strings.Contains(r.stdout, "Checked 3 gates") {
t.Errorf("--limit 3 behind three template gates must still check three live gates:\n%s", r)
}
if strings.Contains(r.stdout+r.stderr, "e2e-tpl-") {
t.Errorf("a template gate was checked:\n%s", r)
}
})
t.Run("timer sweep closes the expired timer", func(t *testing.T) {
r := runBD(t, bin, dir, env, "", "gate", "check", "--type=timer", "--escalate")
if r.code != 0 {
t.Fatalf("bd gate check --type=timer --escalate: %s", r)
}
reqs.take()
wantStatus("e2e-g-timer", types.StatusClosed)
wantStatus("e2e-g-timer-pending", types.StatusOpen)
wantStatus("e2e-tpl-timer", types.StatusOpen)
})
t.Run("bead sweep records the sighting and closes the done gate", func(t *testing.T) {
r := runBD(t, bin, dir, env, "", "gate", "check", "--type=bead")
if r.code != 0 {
t.Fatalf("bd gate check --type=bead: %s", r)
}
writes := gateCheckWrites(reqs.take())
sighted := false
for _, w := range writes {
if strings.Contains(w, "e2e-g-bead-open") {
sighted = true
}
if strings.Contains(w, "e2e-tpl-bead") {
t.Errorf("the sweep wrote to the template gate: %s", w)
}
}
if !sighted {
t.Errorf("no write to e2e-g-bead-open reached the server; writes: %v\n%s", writes, r)
}
if seen := seenOf("e2e-g-bead-open"); seen != "e2e-tgt-open" {
t.Errorf("e2e-g-bead-open await_seen = %q, want e2e-tgt-open\n%s", seen, r)
}
if seen := seenOf("e2e-tpl-bead"); seen != "" {
t.Errorf("e2e-tpl-bead recorded a sighting %q; a template gate is never checked", seen)
}
wantStatus("e2e-g-bead-open", types.StatusOpen)
wantStatus("e2e-g-bead-closed", types.StatusClosed)
})
t.Run("gh:pr sweep closes the merged PR gate", func(t *testing.T) {
r := runBD(t, bin, dir, env, "", "gate", "check", "--type=gh:pr", "--escalate")
if r.code != 0 {
t.Fatalf("bd gate check --type=gh:pr --escalate: %s", r)
}
reqs.take()
wantStatus("e2e-g-pr-merged", types.StatusClosed)
wantStatus("e2e-g-pr-closed", types.StatusOpen)
if !strings.Contains(r.stdout, "e2e-g-pr-closed: ESCALATE") {
t.Errorf("closed PR gate was not escalated:\n%s", r)
}
})
t.Run("gh:run await_id persist refuses by the missing token", func(t *testing.T) {
r := runBD(t, bin, dir, env, "", "gate", "check", "--type=gh:run")
if r.code == 0 {
t.Fatalf("bd gate check --type=gh:run succeeded; the reference server does not advertise issues.update.gates: %s", r)
}
if w := gateCheckWrites(reqs.take()); len(w) != 0 {
t.Errorf("the refused await_id persist sent writes %v", w)
}
if !strings.Contains(r.stderr, "e2e-g-run-hint") || !strings.Contains(r.stderr, `does not advertise capability "issues.update.gates"`) {
t.Errorf("gh:run error does not name the gate and the missing issues.update.gates token:\n%s", r)
}
if !strings.Contains(r.stderr, "bd serve at http://"+proxyAddr) {
t.Errorf("gh:run error does not name the server it reached:\n%s", r)
}
if strings.Contains(r.stderr, "e2e-tpl-run") {
t.Errorf("the template gh:run gate was checked:\n%s", r)
}
// The capability refusal names the wire operation (updateIssue) that
// needs the token; the role and store methods stay out of it.
for _, leak := range []string{"UpdateIssue", "Lifecycle.Update"} {
if strings.Contains(r.stderr, leak) {
t.Errorf("gh:run error leaks %q:\n%s", leak, r)
}
}
if got := get("e2e-g-run-hint").AwaitID; got != "ci-wf" {
t.Errorf("e2e-g-run-hint await_id = %q, want ci-wf untouched", got)
}
wantStatus("e2e-g-run-hint", types.StatusOpen)
if got := get("e2e-tpl-run").AwaitID; got != "ci-wf" {
t.Errorf("e2e-tpl-run await_id = %q, want ci-wf untouched", got)
}
})
}

View file

@ -1,333 +0,0 @@
//go:build cgo
package corpus_test
import (
"context"
"errors"
"fmt"
"io"
"net"
"net/http"
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
"sync"
"testing"
"time"
"github.com/steveyegge/beads/internal/httpapi"
"github.com/steveyegge/beads/internal/storage"
"github.com/steveyegge/beads/internal/storage/domain"
"github.com/steveyegge/beads/internal/storage/embeddeddolt"
"github.com/steveyegge/beads/internal/testutil/bazeltest"
)
const (
corpusProjectID = "proj-corpus-s23"
corpusDatabase = "corpus"
corpusPrefix = "e2e"
// corpusToken is the bearer the in-process server accepts. The reference
// deployment authenticates every request, so the suite does too.
// #nosec G101 -- a throwaway test credential for an httptest-scoped server.
corpusToken = "corpus-s23-test-token"
// bdTimeout bounds one bd subprocess so a hung shape fails rather than
// stalling the whole suite.
bdTimeout = 90 * time.Second
)
// startCorpusServer binds the in-process server the way the reference
// deployment is bound: AllowNonLoopback with a bearer token file. The socket is
// still 127.0.0.1 (this suite never leaves the host), but every behavior the
// server keys off its bind mode — the loopback-only refusal of an unlimited
// read above all — is the non-loopback one, because that is decided by
// Config.AllowNonLoopback and not by the address.
func startCorpusServer(t *testing.T) string {
t.Helper()
beadsDir := t.TempDir()
ctx := context.Background()
store, err := embeddeddolt.Open(ctx, beadsDir, corpusDatabase, "main")
if err != nil {
t.Fatalf("open the served store: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if err := store.SetConfig(ctx, "issue_prefix", corpusPrefix); err != nil {
t.Fatalf("set the issue prefix: %v", err)
}
tokenFile := filepath.Join(t.TempDir(), "tokens")
if err := os.WriteFile(tokenFile, []byte(corpusToken+"\n"), 0o600); err != nil {
t.Fatalf("write the token file: %v", err)
}
auth, err := httpapi.NewTokenFileAuth(tokenFile)
if err != nil {
t.Fatalf("load the token file: %v", err)
}
cfg := corpusServeConfig(t, store)
cfg.AllowNonLoopback = true
cfg.Auth = auth
srv, err := httpapi.Listen(cfg)
if err != nil {
t.Fatalf("bind the in-process server: %v", err)
}
serveCtx, cancel := context.WithCancel(context.Background())
done := make(chan struct{})
go func() { defer close(done); _ = srv.Serve(serveCtx) }()
t.Cleanup(func() {
cancel()
select {
case <-done:
case <-time.After(30 * time.Second):
t.Error("the in-process server did not shut down")
}
})
return srv.Addr()
}
// startProxy serves h on an ephemeral loopback port.
func startProxy(t *testing.T, h http.Handler) string {
t.Helper()
srv := &http.Server{Handler: h, ReadHeaderTimeout: 10 * time.Second}
ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("listen for the reference proxy: %v", err)
}
go func() { _ = srv.Serve(ln) }()
t.Cleanup(func() { _ = srv.Close() })
return ln.Addr().String()
}
// corpusServeConfig takes every role off the store, as bd serve does. It
// mirrors backend/http's e2eServeConfig (a sibling test package, so it cannot
// be imported).
func corpusServeConfig(t *testing.T, s storage.DoltStorage) httpapi.Config {
t.Helper()
cfg := httpapi.Config{
Addr: "127.0.0.1:0",
Stdout: io.Discard,
Stderr: io.Discard,
Workspace: domain.ContextInfo{ProjectID: corpusProjectID, Database: corpusDatabase},
}
var err error
must := func(name string) {
t.Helper()
if err != nil {
t.Fatalf("%s(): %v", name, err)
}
}
cfg.Reader, err = s.IssueReader()
must("IssueReader")
cfg.Claimer, err = s.IssueClaimer()
must("IssueClaimer")
cfg.ReadyClaimer, err = s.ReadyClaimer()
must("ReadyClaimer")
cfg.Releaser, err = s.Releaser()
must("Releaser")
cfg.Lifecycle, err = s.IssueLifecycle()
must("IssueLifecycle")
cfg.Settings, err = s.WorkspaceConfig()
must("WorkspaceConfig")
cfg.Stats, err = s.StatsReporter()
must("StatsReporter")
cfg.CycleDetector, err = s.CycleDetector()
must("CycleDetector")
cfg.EdgeReader, err = s.EdgeReader()
must("EdgeReader")
cfg.GraphCounter, err = s.GraphCounter()
must("GraphCounter")
cfg.BatchGetter, err = s.BatchGetter()
must("BatchGetter")
cfg.LeaseReclaimer, err = s.LeaseReclaimer()
must("LeaseReclaimer")
cfg.Heartbeater, err = s.Heartbeater()
must("Heartbeater")
cfg.BlockedLister, err = s.BlockedLister()
must("BlockedLister")
cfg.Relations, err = s.IssueRelations()
must("IssueRelations")
cfg.Commenter, err = s.Commenter()
must("Commenter")
cfg.BlockingAnnotator, err = s.BlockingAnnotator()
must("BlockingAnnotator")
cfg.TreeWalker, err = s.TreeWalker()
must("TreeWalker")
cfg.ReadyCounter, err = s.ReadyCounter()
must("ReadyCounter")
cfg.Counter, err = s.Counter()
must("Counter")
cfg.Querier, err = s.Querier()
must("Querier")
cfg.Sweeper, err = s.Sweeper()
must("Sweeper")
cfg.Deleter, err = s.Deleter()
must("Deleter")
cfg.BatchCreator, err = s.BatchCreator()
must("BatchCreator")
cfg.BatchCloser, err = s.BatchCloser()
must("BatchCloser")
cfg.DependencyEditor, err = s.DependencyEditor()
must("DependencyEditor")
cfg.MetadataCAS, err = s.MetadataCAS()
must("MetadataCAS")
cfg.BatchApplier, err = s.BatchApplier()
must("BatchApplier")
cfg.Memories, err = s.Memories()
must("Memories")
return cfg
}
// This file is the corpus tier's cgo half; see TestCorpusTierIsLinkedWhenRequired.
func init() { corpusTierLinked = true }
// skipUnlessEmbeddedDolt is the served tier's gate, as in backend/http.
func skipUnlessEmbeddedDolt(t *testing.T) {
t.Helper()
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") == "1" {
return
}
if os.Getenv("BEADS_HTTP_TEST_REQUIRED") == "1" {
t.Fatal("BEADS_HTTP_TEST_REQUIRED=1 but BEADS_TEST_EMBEDDED_DOLT is not 1; the http corpus tier is not enforced")
}
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run the http command-corpus tier")
}
type bdResult struct {
stdout, stderr string
code int
}
func (r bdResult) String() string {
return fmt.Sprintf("exit=%d\nstdout:\n%s\nstderr:\n%s", r.code, clip(r.stdout, 4000), clip(r.stderr, 4000))
}
func clip(s string, n int) string {
if len(s) <= n {
return s
}
return s[:n] + fmt.Sprintf("\n... (%d more bytes)", len(s)-n)
}
// runBD runs the built bd binary in dir with a hermetic environment.
func runBD(t *testing.T, bin, dir string, env []string, stdin string, args ...string) bdResult {
t.Helper()
r, err := execBD(context.Background(), bin, dir, env, stdin, args...)
if err != nil {
t.Fatal(err)
}
return r
}
// execBD is runBD without the testing.T: it returns an error, rather than
// failing a test, when bd could not be run at all or ctx was cancelled, so it
// is safe on a goroutine that is not the test's. A bd that runs and fails is
// a bdResult with its exit code, as in runBD.
func execBD(ctx context.Context, bin, dir string, env []string, stdin string, args ...string) (bdResult, error) {
if err := ctx.Err(); err != nil {
return bdResult{}, err
}
ctx, cancel := context.WithTimeout(ctx, bdTimeout)
defer cancel()
cmd := exec.CommandContext(ctx, bin, args...)
cmd.Dir = dir
cmd.Env = minimalBDEnv(dir, env...)
if stdin != "" {
cmd.Stdin = strings.NewReader(stdin)
}
var o, e strings.Builder
cmd.Stdout, cmd.Stderr = &o, &e
err := cmd.Run()
code := 0
if err != nil {
var ee *exec.ExitError
switch {
case errors.Is(ctx.Err(), context.DeadlineExceeded):
code = -1
e.WriteString(fmt.Sprintf("\n[corpus harness] bd timed out after %s", bdTimeout))
case ctx.Err() != nil:
return bdResult{}, fmt.Errorf("bd %s: %w", strings.Join(args, " "), ctx.Err())
case errors.As(err, &ee):
code = ee.ExitCode()
default:
return bdResult{}, fmt.Errorf("running bd %s: %v", strings.Join(args, " "), err)
}
}
return bdResult{stdout: o.String(), stderr: e.String(), code: code}, nil
}
// minimalBDEnv is backend/http's hermetic bd environment: PATH and the few
// variables a Go binary needs, HOME repointed at dir, nothing BEADS_* carried
// over from the invoking shell. extra is applied last.
func minimalBDEnv(dir string, extra ...string) []string {
env := []string{
"HOME=" + dir,
"BD_DISABLE_METRICS=1",
"BD_DISABLE_EVENT_FLUSH=1",
}
for _, key := range []string{"PATH", "TMPDIR", "SYSTEMROOT", "WINDIR"} {
if v, ok := os.LookupEnv(key); ok {
env = append(env, key+"="+v)
}
}
return append(env, extra...)
}
var (
buildBDOnce sync.Once
bdBinPath string
bdBuildErr error
bdBinOwnBuild bool
)
// buildBD builds bd from this tree once per test process (or takes Bazel's
// prebuilt binary). TestMain deletes the build.
func buildBD(t *testing.T) string {
t.Helper()
buildBDOnce.Do(func() {
if bazeltest.IsBazel() {
bdBinPath, bdBuildErr = bazeltest.PrebuiltBD()
return
}
if prebuilt, err := bazeltest.PrebuiltBD(); err != nil || prebuilt != "" {
bdBinPath, bdBuildErr = prebuilt, err
return
}
dir, err := os.MkdirTemp(os.Getenv("TMPDIR"), "bd-corpus")
if err != nil {
bdBuildErr = fmt.Errorf("mkdir temp for bd binary: %w", err)
return
}
bin := filepath.Join(dir, "bd-corpus")
cmd := exec.Command("go", "build", "-tags", "gms_pure_go", "-o", bin, "./cmd/bd")
cmd.Dir = repoRoot()
if out, err := cmd.CombinedOutput(); err != nil {
bdBuildErr = fmt.Errorf("build bd: %w\n%s", err, out)
_ = os.RemoveAll(dir)
return
}
bdBinPath = bin
bdBinOwnBuild = true
})
if bdBuildErr != nil {
t.Fatal(bdBuildErr)
}
if bdBinPath == "" {
t.Fatal("no bd binary: Bazel did not provide one")
}
return bdBinPath
}
func TestMain(m *testing.M) {
code := m.Run()
if bdBinOwnBuild && bdBinPath != "" {
_ = os.RemoveAll(filepath.Dir(bdBinPath))
}
os.Exit(code)
}
func repoRoot() string {
_, file, _, _ := runtime.Caller(0) // <repo>/backend/http/corpus/harness_test.go
return filepath.Dir(filepath.Dir(filepath.Dir(filepath.Dir(file))))
}

View file

@ -1,279 +0,0 @@
//go:build cgo
package corpus_test
import (
"bytes"
"encoding/json"
"fmt"
"io"
"maps"
"net/http"
"net/http/httputil"
"net/url"
"os"
"regexp"
"slices"
"sort"
"strings"
"sync"
"sync/atomic"
"testing"
"github.com/steveyegge/beads/internal/httpapi"
"github.com/steveyegge/beads/internal/httpapi/apigen"
)
// referenceProfile is testdata/reference_server.json: the wire surface of the
// deployed server the corpus must work against. See README.md.
type referenceProfile struct {
Capabilities []string `json:"capabilities"`
ContextMembers []string `json:"context_members"`
Operations []referenceOperation `json:"operations"`
}
type referenceOperation struct {
Method string `json:"method"`
Path string `json:"path"`
OperationID string `json:"operation_id"`
Query []string `json:"query"`
Body []string `json:"body"`
pattern *regexp.Regexp
query map[string]bool
body map[string]bool
}
func loadReferenceProfile(t *testing.T) *referenceProfile {
t.Helper()
raw, err := os.ReadFile("testdata/reference_server.json")
if err != nil {
t.Fatalf("read the reference server profile: %v", err)
}
var p referenceProfile
if err := json.Unmarshal(raw, &p); err != nil {
t.Fatalf("parse testdata/reference_server.json: %v", err)
}
if len(p.Capabilities) == 0 || len(p.Operations) == 0 || len(p.ContextMembers) == 0 {
t.Fatal("testdata/reference_server.json is missing capabilities, operations or context_members")
}
for i := range p.Operations {
op := &p.Operations[i]
pattern, err := templatePattern(op.Path)
if err != nil {
t.Fatalf("testdata/reference_server.json: operation %s path %q: %v", op.OperationID, op.Path, err)
}
op.pattern = pattern
op.query = setOf(op.Query)
op.body = setOf(op.Body)
}
return &p
}
// templatePattern turns an OpenAPI path template into an anchored regexp. A
// path parameter never spans a "/" or a ":" (AIP-136 custom methods hang off
// the last segment as {id}:verb, and no issue id, config key or memory key
// carries a raw colon), so /issues/{id} does not swallow /issues/{id}:claim.
// A "{" with no "}" is an error: the profile is edited by hand, and without the
// check the loop would never advance past it.
func templatePattern(tmpl string) (*regexp.Regexp, error) {
var b strings.Builder
b.WriteString("^")
for {
open := strings.IndexByte(tmpl, '{')
if open < 0 {
b.WriteString(regexp.QuoteMeta(tmpl))
break
}
closeAt := strings.IndexByte(tmpl[open:], '}')
if closeAt < 0 {
return nil, fmt.Errorf("unclosed { in %q", tmpl[open:])
}
b.WriteString(regexp.QuoteMeta(tmpl[:open]))
b.WriteString(`[^/:]+`)
tmpl = tmpl[open+closeAt+1:]
}
b.WriteString("$")
return regexp.Compile(b.String())
}
func setOf(xs []string) map[string]bool {
m := make(map[string]bool, len(xs))
for _, x := range xs {
m[x] = true
}
return m
}
// referenceProxy fronts the in-process server and makes it answer the way the
// reference server answers, at the wire level, for everything this suite can
// see from a client:
//
// - GET /v0/beads/context publishes only the reference ContextResponse
// members (so no wire_revision: the reference server predates it) and
// exactly the reference capability set, whatever this build advertises;
// - a request for an operation the reference document does not publish gets
// the server's own unrouted 404 problem;
// - a query parameter or top-level JSON request member the reference
// operation does not declare gets the server's own 400 unknown_parameter
// problem naming it — which is how the real reference server answers,
// since its decoder is strict.
//
// Responses are otherwise passed through untouched. That is deliberately
// generous in one direction (a response member the reference server would not
// send still reaches the client) and is the residual fidelity gap README.md
// records.
type referenceProxy struct {
profile *referenceProfile
upstream *url.URL
rp *httputil.ReverseProxy
requests atomic.Int64
mu sync.Mutex
refused []string // "METHOD path: why", for the per-shape log
}
func newReferenceProxy(t *testing.T, profile *referenceProfile, upstreamAddr string) *referenceProxy {
t.Helper()
u, err := url.Parse("http://" + upstreamAddr)
if err != nil {
t.Fatalf("parse upstream address: %v", err)
}
p := &referenceProxy{profile: profile, upstream: u}
p.rp = &httputil.ReverseProxy{
Rewrite: func(r *httputil.ProxyRequest) {
r.SetURL(u) // also rewrites Host, so the server's Host gate sees its own bind
},
FlushInterval: -1, // events:watch streams
}
return p
}
func (p *referenceProxy) takeRefusals() []string {
p.mu.Lock()
defer p.mu.Unlock()
out := p.refused
p.refused = nil
return out
}
func (p *referenceProxy) noteRefusal(r *http.Request, why string) {
p.mu.Lock()
defer p.mu.Unlock()
p.refused = append(p.refused, fmt.Sprintf("%s %s: %s", r.Method, r.URL.Path, why))
}
func (p *referenceProxy) match(r *http.Request) *referenceOperation {
path := r.URL.EscapedPath()
var best *referenceOperation
for i := range p.profile.Operations {
op := &p.profile.Operations[i]
if op.Method != r.Method || !op.pattern.MatchString(path) {
continue
}
// Prefer the most literal template when two match (none do today).
if best == nil || len(op.Path) > len(best.Path) {
best = op
}
}
return best
}
func (p *referenceProxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
p.requests.Add(1)
if r.Method == http.MethodGet && r.URL.Path == "/v0/beads/context" {
p.serveContext(w, r)
return
}
op := p.match(r)
if op == nil {
p.noteRefusal(r, "operation not published by the reference server")
detail := "no such route on this server"
httpapi.Write(w, httpapi.Result{Problem: apigen.Problem{
Status: http.StatusNotFound,
Title: http.StatusText(http.StatusNotFound),
Code: string(httpapi.CodeNotFound),
Detail: &detail,
}})
return
}
if offender := firstUnknown(slices.Collect(maps.Keys(r.URL.Query())), op.query); offender != "" {
p.noteRefusal(r, "query parameter "+offender+" unknown to "+op.OperationID)
httpapi.Write(w, httpapi.InvalidArgument(offender, httpapi.ReasonUnknownParameter,
"unknown query parameter "+offender))
return
}
if r.Body != nil && r.Body != http.NoBody {
raw, err := io.ReadAll(r.Body)
_ = r.Body.Close()
if err != nil {
http.Error(w, "reference proxy: read body: "+err.Error(), http.StatusBadGateway)
return
}
r.Body = io.NopCloser(bytes.NewReader(raw))
r.ContentLength = int64(len(raw))
var members map[string]json.RawMessage
if len(bytes.TrimSpace(raw)) > 0 && json.Unmarshal(raw, &members) == nil {
if offender := firstUnknown(slices.Collect(maps.Keys(members)), op.body); offender != "" {
p.noteRefusal(r, "request member "+offender+" unknown to "+op.OperationID)
httpapi.Write(w, httpapi.InvalidArgument(offender, httpapi.ReasonUnknownParameter,
"json: unknown field \""+offender+"\""))
return
}
}
}
p.rp.ServeHTTP(w, r)
}
// firstUnknown names the smallest key not in known, the same deterministic
// choice the server makes, or "" when every key is known.
func firstUnknown(keys []string, known map[string]bool) string {
sort.Strings(keys)
for _, k := range keys {
if !known[k] {
return k
}
}
return ""
}
func (p *referenceProxy) serveContext(w http.ResponseWriter, r *http.Request) {
out := r.Clone(r.Context())
out.URL.Scheme, out.URL.Host, out.Host = p.upstream.Scheme, p.upstream.Host, p.upstream.Host
out.RequestURI = ""
resp, err := http.DefaultTransport.RoundTrip(out)
if err != nil {
http.Error(w, "reference proxy: "+err.Error(), http.StatusBadGateway)
return
}
defer resp.Body.Close()
raw, err := io.ReadAll(resp.Body)
if err != nil {
http.Error(w, "reference proxy: "+err.Error(), http.StatusBadGateway)
return
}
if resp.StatusCode != http.StatusOK {
maps.Copy(w.Header(), resp.Header)
w.WriteHeader(resp.StatusCode)
_, _ = w.Write(raw)
return
}
var body map[string]json.RawMessage
if err := json.Unmarshal(raw, &body); err != nil {
http.Error(w, "reference proxy: decode context: "+err.Error(), http.StatusBadGateway)
return
}
keep := setOf(p.profile.ContextMembers)
for k := range body {
if !keep[k] {
delete(body, k)
}
}
caps, _ := json.Marshal(p.profile.Capabilities)
body["capabilities"] = caps
masked, _ := json.Marshal(body)
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
_, _ = w.Write(masked)
}

View file

@ -1,23 +0,0 @@
package corpus_test
import (
"os"
"testing"
)
// corpusTierLinked reports whether this test binary links the corpus tier.
// harness_test.go, which builds only under cgo like every other file in this
// package, sets it from its init.
var corpusTierLinked bool
// TestCorpusTierIsLinkedWhenRequired is the one corpus check that builds
// without cgo. skipUnlessEmbeddedDolt turns a missing BEADS_TEST_EMBEDDED_DOLT
// into a failure under BEADS_HTTP_TEST_REQUIRED=1, but it lives in a cgo file:
// with cgo off the go tool drops every other file in this package, so no
// corpus test exists to fail, and a required run would pass having run nothing.
func TestCorpusTierIsLinkedWhenRequired(t *testing.T) {
if os.Getenv("BEADS_HTTP_TEST_REQUIRED") == "1" && !corpusTierLinked {
t.Fatal("BEADS_HTTP_TEST_REQUIRED=1 but this test binary was built without cgo, which drops " +
"the http command corpus (every other file in this package); build it with CGO_ENABLED=1")
}
}

View file

@ -1,12 +0,0 @@
# Pinned shards for tools/bazel/go_test_pinned_shard.sh. Not pin_shards.py's:
# each corpus part (corpus_test.go's corpusParts; TestServedCorpusPart1..N)
# runs alone in the shard of its number, on its own server and seed, and the
# binary's round-robin runs the package's other (engine-free) tests in the
# one shard left over. Change corpusParts, this file and the target's
# shard_count together (scripts TestCorpusPartsArePinnedOnePerShard).
#
# <pinned shard> <TestName>
1 TestServedCorpusPart1
2 TestServedCorpusPart2
3 TestServedCorpusPart3
4 TestServedCorpusPart4

View file

@ -1,29 +0,0 @@
# Shapes that are EXPECTED to be refused on a served workspace, permanently.
# The served run must fail and its output must match `refusal`; if it ever
# succeeds, the entry is stale and the suite fails until it is removed. The
# embedded run is still held to the shape's expect_exit, which an allowlisted
# shape must state, and to its expect_stderr: a shape that stops doing what it
# says on the embedded backend fails as a corpus bug, not as allowed.
# A gap some slice will close is NOT listed here: it is a `pending` mark on the
# shape in corpus.yaml instead.
- id: gc-sql-ready-projection
reason: >-
bd sql needs a Dolt sql-server workspace: the embedded backend refuses it
too (the shape's expect_exit and expect_stderr pin that), and an http
workspace refuses it with the same "embedded mode" text. gc must not issue
it against a remote workspace (DESIGN B3 #10 and B6: gc reads the ready
projection through roles there).
refusal: "'bd sql' is not yet supported"
- id: gc-sql-release-fallback
reason: >-
bd sql needs a Dolt sql-server workspace and the embedded backend refuses
it too; gc's ReleaseIfCurrent fallback must take the conditional update
path on a remote workspace (DESIGN B3 #10).
refusal: "'bd sql' is not yet supported"
- id: mc-meta-set
reason: >-
`bd meta set` is not an OSS bd command (pack scripts written against an
older pinned CLI); it fails on the embedded backend too. The packs should
use `bd update --set-metadata`, which the corpus covers.
refusal: 'unknown command "meta"'

View file

@ -1,882 +0,0 @@
# Served command corpus (slice S23): every distinct bd command shape the
# orchestrator (gc) and its packs/formulas issue against a work store.
#
# Sources:
# gc: gascity origin/main internal/beads/bdstore*.go, internal/config/workquery.go,
# cmd/gc (BdStore subprocess shapes, work_query/scale_check/on_boot/on_death
# shell, hook claim, agent-script actions, doctor/preflight probes).
# mc: pack, formula, prompt and script invocations counted across the
# maintainer packs (flag sets, not values; values here are representative).
#
# Each shape runs on a served workspace (bd connect to an in-process bd serve,
# non-loopback bind mode, bearer auth, masked to testdata/reference_server.json)
# and on an embedded workspace, with BEADS_ACTOR=worker and CLAUDE_SESSION_ID set
# on both. See README.md for the fields. Reads come first; writes after them
# each own their target ids (e2e-t-*), so write order never changes a read.
# The shapes are dealt round robin, in this order, across the suite's parts,
# and each part seeds its own workspaces: a shape may rely on the seed and its
# own setup, never on another shape having run.
#
# pending: {slice, reason} marks a known failure. The shape still runs; when it
# passes the subtest FAILS until the mark is removed. That is how a slice proves
# itself. Permanent refusals live in allowlist.yaml instead.
files:
- name: seed-core.json
content: |
{"commit_message": "corpus seed", "nodes": [
{"key": "r1", "id": "e2e-r1", "title": "Routed open task", "type": "task", "priority": 1, "labels": ["lane:a"], "metadata": {"gc.routed_to": "pool-a"}},
{"key": "r2", "id": "e2e-r2", "title": "Held routed task", "type": "task", "labels": ["hold:mayor"], "metadata": {"gc.routed_to": "pool-a"}},
{"key": "r3", "id": "e2e-r3", "title": "Routed epic", "type": "epic", "metadata": {"gc.routed_to": "pool-a"}},
{"key": "wf1", "id": "e2e-wf1", "title": "Workflow root", "type": "task", "metadata": {"gc.run_target": "pool-a", "gc.kind": "workflow"}},
{"key": "a1", "id": "e2e-a1", "title": "Alice bug", "type": "bug", "assignee": "alice"},
{"key": "ip1", "id": "e2e-ip1", "title": "Worker in progress", "type": "task", "priority": 0, "assignee": "worker", "metadata": {"gc.routed_to": "pool-a"}},
{"key": "wr", "id": "e2e-wr", "title": "Worker ready task", "type": "task", "assignee": "worker"},
{"key": "ipna", "id": "e2e-ipna", "title": "Orphaned in progress", "type": "task", "metadata": {"gc.routed_to": "pool-a"}},
{"key": "ipnb", "id": "e2e-ipnb", "title": "Orphaned workflow", "type": "task", "metadata": {"gc.run_target": "pool-a", "gc.kind": "workflow"}},
{"key": "blk", "id": "e2e-blk", "title": "Blocked by r1", "type": "task", "deps": [{"target": "r1"}]},
{"key": "done", "id": "e2e-done", "title": "Closed task", "type": "task"},
{"key": "ext", "id": "e2e-ext", "title": "GitHub source", "type": "task", "external_ref": "gh-123", "metadata": {"gc.kind": "github_source", "gc.github.kind": "issue", "gc.github.repo": "o/r"}},
{"key": "ep", "id": "e2e-ep", "title": "Epic", "type": "epic"},
{"key": "ep.1", "id": "e2e-ep.1", "title": "Epic child one", "type": "task", "parent_key": "ep"},
{"key": "ep.2", "id": "e2e-ep.2", "title": "Epic child two", "type": "task", "parent_key": "ep"},
{"key": "mol", "id": "e2e-mol", "title": "Molecule root", "type": "epic"},
{"key": "mol.1", "id": "e2e-mol.1", "title": "step one", "type": "task", "assignee": "worker", "parent_key": "mol"},
{"key": "mol.2", "id": "e2e-mol.2", "title": "step two", "type": "task", "parent_key": "mol", "deps": [{"target": "mol.1"}], "metadata": {"gc.root_bead_id": "e2e-mol", "gc.routed_to": "pool-a"}},
{"key": "mol.3", "id": "e2e-mol.3", "title": "step three", "type": "task", "parent_key": "mol"},
{"key": "mac", "id": "e2e-mac", "title": "Auto-close molecule", "type": "epic"},
{"key": "mac.1", "id": "e2e-mac.1", "title": "done step", "type": "task", "parent_key": "mac"},
{"key": "mac.2", "id": "e2e-mac.2", "title": "last step", "type": "task", "assignee": "worker", "parent_key": "mac"},
{"key": "wisp-1", "id": "e2e-wisp-1", "title": "Wisp wisp-1", "type": "task", "ephemeral": true, "metadata": {"gc.routed_to": "pool-a"}, "labels": ["lane:w"]},
{"key": "wisp-2", "id": "e2e-wisp-2", "title": "Wisp wisp-2", "type": "task", "ephemeral": true, "assignee": "worker", "labels": ["lane:w"]},
{"key": "wisp-wr", "id": "e2e-wisp-wr", "title": "Wisp worker ready", "type": "task", "ephemeral": true, "priority": 1, "assignee": "worker"},
{"key": "wisp-c", "id": "e2e-wisp-c", "title": "Wisp wisp-c", "type": "task", "ephemeral": true},
{"key": "wisp-p", "id": "e2e-wisp-p", "title": "Wisp wisp-p", "type": "task", "ephemeral": true},
{"key": "wisp-m", "id": "e2e-wisp-m", "title": "Wisp molecule", "type": "epic", "ephemeral": true},
{"key": "wisp-m.1", "id": "e2e-wisp-m.1", "title": "wisp step", "type": "task", "ephemeral": true, "parent_key": "wisp-m"},
{"key": "gate-o", "id": "e2e-gate-o", "title": "Open gate", "type": "gate"},
{"key": "gate-c", "id": "e2e-gate-c", "title": "Closed gate", "type": "gate"},
{"key": "wisp-gate", "id": "e2e-wisp-gate", "title": "Wisp gate", "type": "gate", "ephemeral": true},
{"key": "t-upd", "id": "e2e-t-upd", "title": "target upd", "type": "task", "labels": ["lane:z"]},
{"key": "t-upd2", "id": "e2e-t-upd2", "title": "target upd2", "type": "task"},
{"key": "t-m1", "id": "e2e-t-m1", "title": "target m1", "type": "task"},
{"key": "t-m2", "id": "e2e-t-m2", "title": "target m2", "type": "task"},
{"key": "t-claim", "id": "e2e-t-claim", "title": "target claim", "type": "task"},
{"key": "t-claim2", "id": "e2e-t-claim2", "title": "target claim2", "type": "task"},
{"key": "t-rev", "id": "e2e-t-rev", "title": "target rev", "type": "task"},
{"key": "t-rev2", "id": "e2e-t-rev2", "title": "target rev2", "type": "task"},
{"key": "t-sling", "id": "e2e-t-sling", "title": "target sling", "type": "task"},
{"key": "t-as", "id": "e2e-t-as", "title": "target as", "type": "task"},
{"key": "t-ms", "id": "e2e-t-ms", "title": "target ms", "type": "task"},
{"key": "t-msc", "id": "e2e-t-msc", "title": "target msc", "type": "task"},
{"key": "t-um", "id": "e2e-t-um", "title": "target um", "type": "task", "metadata": {"k": "v"}},
{"key": "t-notes", "id": "e2e-t-notes", "title": "target notes", "type": "task"},
{"key": "t-er", "id": "e2e-t-er", "title": "target er", "type": "task"},
{"key": "t-md", "id": "e2e-t-md", "title": "target md", "type": "task"},
{"key": "t-asg", "id": "e2e-t-asg", "title": "target asg", "type": "task"},
{"key": "t-dac", "id": "e2e-t-dac", "title": "target dac", "type": "task"},
{"key": "t-c1", "id": "e2e-t-c1", "title": "target c1", "type": "task"},
{"key": "t-c2", "id": "e2e-t-c2", "title": "target c2", "type": "task"},
{"key": "t-c3", "id": "e2e-t-c3", "title": "target c3", "type": "task"},
{"key": "t-c4", "id": "e2e-t-c4", "title": "target c4", "type": "task"},
{"key": "t-c5", "id": "e2e-t-c5", "title": "target c5", "type": "task"},
{"key": "t-d1", "id": "e2e-t-d1", "title": "target d1", "type": "task"},
{"key": "t-d2", "id": "e2e-t-d2", "title": "target d2", "type": "task"},
{"key": "t-d3", "id": "e2e-t-d3", "title": "target d3", "type": "task"},
{"key": "t-d4", "id": "e2e-t-d4", "title": "target d4", "type": "task"},
{"key": "t-df1", "id": "e2e-t-df1", "title": "target df1", "type": "task"},
{"key": "t-df2", "id": "e2e-t-df2", "title": "target df2", "type": "task"},
{"key": "t-da", "id": "e2e-t-da", "title": "target da", "type": "task"},
{"key": "t-db", "id": "e2e-t-db", "title": "target db", "type": "task"},
{"key": "t-l", "id": "e2e-t-l", "title": "target l", "type": "task"},
{"key": "t-as2", "id": "e2e-t-as2", "title": "target as2", "type": "task"},
{"key": "t-cm", "id": "e2e-t-cm", "title": "target cm", "type": "task"},
{"key": "t-rel", "id": "e2e-t-rel", "title": "target rel", "type": "task", "assignee": "worker"},
{"key": "t-xfer", "id": "e2e-t-xfer", "title": "target xfer", "type": "task", "assignee": "worker"},
{"key": "t-ifa", "id": "e2e-t-ifa", "title": "target ifa", "type": "task", "assignee": "worker", "metadata": {"seeded": "keep"}},
{"key": "t-death", "id": "e2e-t-death", "title": "target death", "type": "task", "assignee": "worker"},
{"key": "t-rc", "id": "e2e-t-rc", "title": "target rc", "type": "task", "assignee": "worker"},
{"key": "t-hb", "id": "e2e-t-hb", "title": "target hb", "type": "task"},
{"key": "t-hb2", "id": "e2e-t-hb2", "title": "target hb2", "type": "task"},
{"key": "t-hb3", "id": "e2e-t-hb3", "title": "target hb3", "type": "task"},
{"key": "t-boot", "id": "e2e-t-boot", "title": "target boot", "type": "task"},
{"key": "t-ro", "id": "e2e-t-ro", "title": "target reopen", "type": "task"},
{"key": "t-dr", "id": "e2e-t-dr", "title": "target dep remove", "type": "task", "deps": [{"target": "t-db"}]},
{"key": "t-dc", "id": "e2e-t-dc", "title": "cascade root", "type": "epic"},
{"key": "t-dc.1", "id": "e2e-t-dc.1", "title": "cascade child", "type": "task", "parent_key": "t-dc"},
{"key": "t-gcr", "id": "e2e-t-gcr", "title": "target gate create", "type": "task"},
{"key": "t-gct", "id": "e2e-t-gct", "title": "target gate check", "type": "task"},
{"key": "t-gw", "id": "e2e-t-gw", "title": "target gate waiter", "type": "gate"},
{"key": "t-gaw", "id": "e2e-t-gaw", "title": "target gate await id", "type": "gate"}
]}
- name: bulk-ready-a.json
bulk: {id_prefix: e2e-bra, count: 60, priority: 3, metadata: {gc.routed_to: pool-a}}
- name: bulk-ready-b.json
bulk: {id_prefix: e2e-brb, count: 60, priority: 3, metadata: {gc.routed_to: pool-a}}
- name: bulk-wisp-a.json
bulk: {id_prefix: e2e-wisp-bwa, count: 55, priority: 3, ephemeral: true, metadata: {gc.routed_to: pool-a}}
- name: bulk-wisp-b.json
bulk: {id_prefix: e2e-wisp-bwb, count: 55, priority: 3, ephemeral: true, metadata: {gc.routed_to: pool-a}}
- name: graph-small.json
content: |
{"commit_message": "gc graph apply", "nodes": [
{"key": "root", "id": "e2e-g-root", "title": "graph root", "type": "epic", "metadata": {"gc.kind": "workflow"}},
{"key": "s1", "id": "e2e-g-s1", "title": "graph step 1", "type": "task", "parent_key": "root", "assignee": "worker", "labels": ["lane:g"], "metadata": {"gc.routed_to": "pool-a"}},
{"key": "s2", "id": "e2e-g-s2", "title": "graph step 2", "type": "task", "parent_key": "root"}
], "edges": [{"from_key": "s2", "to_key": "s1", "type": "blocks"}]}
- name: graph-eph.json
content: |
{"nodes": [
{"key": "root", "id": "e2e-wisp-g-root", "title": "wisp graph root", "type": "epic"},
{"key": "s1", "id": "e2e-wisp-g-s1", "title": "wisp graph step", "type": "task", "parent_key": "root"}
]}
- name: delete-list.txt
content: |
e2e-t-df1
e2e-t-df2
seed:
- [create, --graph, "{file:seed-core.json}", --json]
- [create, --graph, "{file:bulk-ready-a.json}", --json]
- [create, --graph, "{file:bulk-ready-b.json}", --json]
- [create, --graph, "{file:bulk-wisp-a.json}", --json]
- [create, --graph, "{file:bulk-wisp-b.json}", --json]
# Graph plans carry no status: a node created in_progress or closed stamps
# started_at/closed_at, which batchApply's create vocabulary cannot carry
# (gc's own plans never set a status). Lifecycle goes through update/close.
- [update, e2e-ip1, e2e-ipna, e2e-ipnb, e2e-mol.1, e2e-mac.2, e2e-t-rel, e2e-t-xfer, e2e-t-ifa, e2e-t-death, e2e-t-rc, e2e-t-boot, --status, in_progress]
- [update, e2e-wisp-2, --status, in_progress]
- [close, --force, e2e-done, e2e-ep.2, e2e-mol.3, e2e-mac.1, e2e-t-ro, e2e-gate-c]
- [comments, add, e2e-r1, "seed comment"]
shapes:
# ---------------------------------------------------------------- show
# requests pins each show's round trips (mc-5dkzp): resolving the id,
# fetching the row and reading it for output are one request per id, which
# the per-command read memo answers once.
- id: gc-show-json
source: gc bdstore.go BdStore.Get (show --json <id>); counts must not read 0
args: [show, --json, e2e-blk]
requests: 1
- id: gc-show-json-batch
source: gc bdstore_exact_batch.go GetExactBatch
args: [show, --json, e2e-r1, e2e-a1, e2e-blk, e2e-mol]
requests: 4
- id: gc-show-json-wisp
source: gc workquery.go blocked_by enrichment; wisps live in the ready tier
args: [show, e2e-wisp-1, --json]
requests: 1
- id: gc-show-id-flag
source: gc cmd_bd_show_watch.go bdWatchRunner (show --json --id=<id>)
args: [show, --json, --id=e2e-r1]
requests: 1
# The worker holds eight in-progress issues; e2e-ip1 is the only P0 among
# them, so "first in the store's default order" (priority first) names it on
# both sides. Among equal priorities the order rests on created_at, and a
# seed that straddles a second boundary on one side only picked another issue.
- id: gc-show-current
source: gc cmd_bd_show_watch.go bdWatchRunner (show --current --json)
args: [show, --current, --json]
requests: 3
- id: gc-show-missing
source: gc BdStore.Get not-found classification (routing fallbacks)
args: [show, --json, e2e-nonexistent]
expect_exit: 1
expect_stderr: "(?i)not found"
compare: exit
requests: 1
# Text show reads the row, then its dependents and its comments: three
# different URLs the memo cannot collapse.
- id: mc-show-text
source: mc prompts (bd show <id>, ~80)
args: [show, e2e-r1]
compare: text
requests: 3
# ---------------------------------------------------------------- ready
# e2e-wr and e2e-wisp-wr are the only open rows assigned to the worker when
# these shapes run, so the assignee shapes compare real rows: a client that
# sends the wrong assignee or drops --include-ephemeral returns a different
# list. The wisp is P1 and the task P2, so --limit=1 picks the wisp on both
# sides by priority alone.
- id: gc-ready-unlimited
source: gc bdstore.go bdReadyArgs (BdStore.Ready, ready --json --limit 0)
args: [ready, --json, --limit, "0"]
compare: ids
- id: gc-ready-ephemeral-assignee-unlimited
source: gc bdstore.go bdReadyArgs with --include-ephemeral --assignee
args: [ready, --json, --include-ephemeral, --assignee, worker, --limit, "0"]
compare: ids
- id: gc-ready-pool-demand
source: gc workquery.go bdReadyPoolDemandShell (scale_check, --limit=20)
args: [ready, --metadata-field, gc.routed_to=pool-a, --unassigned, --exclude-type=epic, --exclude-label, "hold:mayor", --exclude-label, "hold:external", --json, --limit=20]
compare: ids
- id: gc-ready-pool-demand-unlimited
source: gc workquery.go bdReadyPoolDemandShell (work_query, --include-ephemeral --limit 0)
args: [ready, --include-ephemeral, --metadata-field, gc.routed_to=pool-a, --unassigned, --exclude-type=epic, --exclude-label, "hold:mayor", --exclude-label, "hold:external", --json, --limit, "0"]
compare: ids
- id: gc-ready-workflow-migration
source: gc workquery.go bdReadyPoolDemandMigrationShell (--sort oldest --limit 0)
args: [ready, --include-ephemeral, --metadata-field, gc.run_target=pool-a, --metadata-field, gc.kind=workflow, --unassigned, --exclude-type=epic, --exclude-label, "hold:mayor", --exclude-label, "hold:external", --json, --sort, oldest, --limit, "0"]
compare: ids
- id: gc-ready-graph-anchor
source: gc workquery.go assignedGraphWorkflowAnchorReadyFunctionScript
args: [ready, --include-ephemeral, --metadata-field, gc.root_bead_id=e2e-mol, --metadata-field, gc.routed_to=pool-a, --exclude-type=epic, --exclude-label, "hold:mayor", --exclude-label, "hold:external", --json, --sort, oldest, --limit=20]
compare: ids
- id: gc-ready-assigned-tier
source: gc workquery.go assignedReadyTierCommand (--assignee=<id> --limit=1)
args: [ready, --include-ephemeral, --assignee=worker, --json, --limit=1]
compare: ids
- id: gc-ready-probe
source: gc examples/bd gc-beads-bd.sh (bare bd ready probe)
args: [ready]
compare: exit
- id: mc-ready-json
source: mc scripts/prompts (bd ready --json, ~36)
args: [ready, --json]
compare: ids
- id: mc-ready-mol
source: mc skills/pr-review (bd ready --mol <root>)
args: [ready, --mol, e2e-mol, --json]
- id: mc-ready-parent
source: mc skills/pr-review (bd ready --parent <root>)
args: [ready, --parent, e2e-ep, --json]
compare: ids
# ---------------------------------------------------------------- list
- id: gc-list-full-filters
source: gc bdstore.go listViaBDList (List/ListByLabel/ListByMetadata)
args: [list, --json, --label=lane:a, --status=open, --type=task, --include-infra, --include-gates, --limit, "0", --metadata-field, gc.routed_to=pool-a]
- id: gc-list-ping
source: gc bdstore.go BdStore.Ping (list --json --limit 0)
args: [list, --json, --limit, "0"]
compare: ids
- id: gc-list-limit1
source: gc doctor_gate_sandbox.go / doctor_store_preflight.go
args: [list, --json, --limit, "1"]
compare: count
- id: gc-list-readonly
source: gc doctor_v2_session_migration.go readOnlyBdRunner
args: [--readonly, list, --json, --limit, "1"]
compare: count
- id: gc-list-assignee-status
source: gc bdstore.go listViaBDList (ListByAssignee)
args: [list, --json, --assignee=worker, --status=in_progress, --include-infra, --include-gates, --limit, "0"]
- id: gc-list-all-created-before
source: gc bdstore.go listViaBDList (--all --created-before --include-templates --skip-labels)
args: [list, --json, --all, --created-before, "2100-01-01T00:00:00Z", --include-infra, --include-gates, --include-templates, --limit, "0", --skip-labels]
compare: ids
- id: gc-list-children
source: gc bdstore.go listViaBDList (Children, --parent)
args: [list, --json, --include-infra, --include-gates, --limit, "0", --parent, e2e-ep, --all]
- id: gc-list-in-progress-tier
source: gc workquery.go assignedInProgressTierCommandWithLimit
args: [list, --status, in_progress, --assignee=worker, --json, --limit=20]
- id: gc-list-on-death
source: gc workquery.go EffectiveOnDeath
args: [list, --assignee=worker, --status=in_progress, --json]
- id: gc-list-on-boot
source: gc workquery.go on_boot recovery (--no-assignee)
args: [list, --metadata-field, gc.routed_to=pool-a, --status=in_progress, --no-assignee, --json]
pending: {slice: "SRV-1", reason: "S15b sends --no-assignee as listIssues no_assignee behind issues.list.noAssignee, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListScopeFiltersOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-list-on-boot-workflow
source: gc workquery.go on_boot recovery, workflow lane
args: [list, --metadata-field, gc.run_target=pool-a, --metadata-field, gc.kind=workflow, --status=in_progress, --no-assignee, --json]
pending: {slice: "SRV-1", reason: "S15b sends --no-assignee as listIssues no_assignee behind issues.list.noAssignee, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListScopeFiltersOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-list-meta-status
source: mc assets snapshot.md (list --json --limit --metadata-field --status)
args: [list, --json, --limit, "50", --metadata-field, gc.routed_to=pool-a, --status, open]
compare: ids
# More than 50 rows match, most at one priority: --limit 50 cuts a tie set
# whose created_at order differs between the two seeds, so each side's 50
# rows are held to its own unlimited listing instead.
prefix_of: [list, --json, --limit, "0", --metadata-field, gc.routed_to=pool-a, --status, open]
- id: mc-list-github-source
source: mc github-intake (list --all --json --limit --metadata-field x3)
args: [list, --metadata-field, gc.kind=github_source, --metadata-field, gc.github.kind=issue, --metadata-field, gc.github.repo=o/r, --all, --json, --limit, "0"]
- id: mc-list-all-type
source: mc normalized_candidate_graph.py (list --all --type)
args: [list, --all, --type, epic, --json, --limit, "50"]
- id: mc-list-include-gates-infra-label
source: mc mol-normalized-issue-pr-v1 (list --all --include-gates --include-infra --json --label --limit)
args: [list, --all, --include-gates, --include-infra, --json, --label, "lane:a", --limit, "0"]
- id: mc-list-title
source: mc mol-normalized-issue-pr-v1 (list --all --include-infra --json --limit --title)
args: [list, --all, --include-infra, --json, --limit, "10", --title, "Routed open task"]
pending: {slice: "SRV-1", reason: "S15b sends --title as listIssues title behind issues.list.title, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListScopeFiltersOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-list-id
source: mc skills/pr-review (list --all --id --json --limit)
args: [list, --all, --id, "e2e-r1,e2e-a1", --json, --limit, "0"]
pending: {slice: "SRV-1", reason: "S15b sends --id as listIssues id behind issues.list.ids, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListScopeFiltersOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-polecat-title-contains
source: gascity core formulas/mol-polecat-base.toml (list --title-contains --status a,b,c --json)
args: [list, --title-contains, "Routed", --status, "open,in_progress,blocked", --json]
pending: {slice: "SRV-1", reason: "--title-contains folds onto listIssues title behind issues.list.title, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListScopeFiltersOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-polecat-title-contains-closed-after
source: gascity core formulas/mol-polecat-base.toml (pre-flight 3d, list --title-contains --status closed --closed-after DATE --json)
args: [list, --title-contains, "closed task", --status, closed, --closed-after, "2000-01-01", --json]
pending: {slice: "SRV-1", reason: "needs issues.list.title (--title-contains folds onto listIssues title) and issues.list.filters (closed_after), which the reference server does not advertise, so the client refuses before dialing; remove the mark when reference_server.json is upgraded"}
- id: gc-polecat-closed-after
source: gascity core formulas/mol-polecat-base.toml:267 (list --title-contains --status closed --closed-after --json)
args: [list, --title-contains, "task", --status, closed, --closed-after, "2000-01-01", --json]
compare: ids
pending: {slice: "SRV-1", reason: "needs issues.list.title (--title-contains folds onto listIssues title) and issues.list.filters (closed_after), which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListFilterParityOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: wf-session-cleanup
source: an order cleanup script's closed-session sweep (list --all --include-infra --include-gates --status closed --label --closed-before --updated-before)
args: [list, --json, --all, --include-infra, --include-gates, --status, closed, --label, "lane:a", --closed-before, "2100-01-01T00:00:00Z", --updated-before, "2100-01-01T00:00:00Z", --limit, "0"]
compare: ids
pending: {slice: "SRV-1", reason: "needs issues.list.filters, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListFilterParityOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: list-filter-priority-range
source: bd list --priority-min/--priority-max (listing filter parity)
args: [list, --json, --priority-min, "1", --priority-max, "3", --limit, "0"]
compare: ids
pending: {slice: "SRV-1", reason: "needs issues.list.filters, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListFilterParityOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: list-filter-exclude-type-no-parent
source: bd list --exclude-type --no-parent (listing filter parity)
args: [list, --json, --exclude-type, epic, --no-parent, --limit, "0"]
compare: ids
pending: {slice: "SRV-1", reason: "needs issues.list.filters, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListFilterParityOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: list-filter-updated-after
source: bd list --updated-after (listing filter parity)
args: [list, --json, --updated-after, "2000-01-01", --limit, "0"]
compare: ids
pending: {slice: "SRV-1", reason: "needs issues.list.filters, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_ListFilterParityOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-list-assignee-status
source: mc review summaries (list --assignee --json --limit --status)
args: [list, --assignee, alice, --json, --limit, "10", --status, open]
- id: mc-list-label-text
source: mc normalized_child_launch.py (list --label)
args: [list, --label, "lane:a"]
compare: text
- id: mc-list-plain
source: mc scripts (bare bd list)
args: [list]
compare: exit
- id: mc-children
source: mc prompts (bd children <epic>)
args: [children, e2e-ep, --json]
# ---------------------------------------------------------------- query / count / search
- id: gc-query-wisps
source: gc bdstore.go listEphemeral (query --json "ephemeral=true AND ..." --limit N)
args: [query, --json, "ephemeral=true AND label=lane:w", --limit, "50"]
- id: gc-query-wisps-all
source: gc bdstore.go listEphemeral with IncludeClosed (--all)
args: [query, --json, "ephemeral=true AND status=in_progress", --all, --limit, "50"]
- id: gc-query-wisp-by-id
source: gc bdstore.go getEphemeralByID
args: [query, --json, "ephemeral=true AND id=e2e-wisp-1", --all, --limit, "1"]
- id: gc-query-wisps-unlimited
source: gc workquery.go bdQueryEphemeralStatusShell (--limit=0, wisp tier)
args: [query, --json, "ephemeral=true AND status=open", --limit=0]
compare: ids
- id: mc-query
source: mc pr_merge.py (bd query)
args: [query, --json, "status=open AND priority<=1", --limit, "50"]
- id: gc-count
source: gc native CountIssues fallback (count without scope)
args: [count, --json]
- id: gc-count-status
source: gc count with a status filter
args: [count, --json, --status, open]
- id: mc-search
source: mc mol-bug-report-flow-v2 (bd search)
args: [search, "Routed", --json]
compare: ids
pending: {slice: "S6c+SRV-1", reason: "S26 sends bd search as listIssues q behind issues.list.search, which the reference server does not advertise, so the client refuses before dialing; remove the mark when reference_server.json is upgraded"}
- id: mc-status
source: mc normalized_child_launch.py (bd status)
args: [status, --json]
# ---------------------------------------------------------------- deps / graph reads
- id: gc-dep-list
source: gc bdstore.go DepList
args: [dep, list, e2e-blk, --json]
- id: gc-dep-list-up
source: gc bdstore.go DepList (--direction=up)
args: [dep, list, e2e-r1, --json, --direction=up]
- id: gc-dep-list-batch
source: gc bdstore.go DepListBatch
args: [dep, list, e2e-blk, e2e-mol.2, --json]
- id: mc-dep-tree
source: mc pr_review.py city_dep_subtree (dep tree <root> --json)
args: [dep, tree, e2e-mol, --json]
- id: gc-blocked
source: gc bdstore_ready_projection.go fetchReadyProjectionViaBlocked
args: [blocked, --json]
pending: {slice: "SRV-1", reason: "bd blocked dials listBlockedIssues behind blocked.list, which the reference server does not advertise, so the client refuses at its capability preflight (pinned passing against the current server by backend/http TestE2E_BlockedOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-blocked-flags
source: gc bdstore_ready_projection.go readiness door (bd blocked --flags --json, ids on stdin)
args: [blocked, --flags, --json]
stdin: "e2e-mol\ne2e-mol.1\ne2e-mol.2\ne2e-no-such-row\n"
compare: json
pending: {slice: "SRV-1", reason: "bd blocked --flags reads listBlockingAnnotations is_blocked behind dependencies.blocking.isBlocked, which the reference server does not advertise, so the client refuses at its capability preflight (pinned passing against the current server by backend/http TestE2E_BlockedFlagsOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-blocked-flags-raw
source: gc bdstore_ready_projection.go readiness door (the stored is_blocked column, bd blocked --flags --raw --json, ids on stdin)
args: [blocked, --flags, --raw, --json]
stdin: "e2e-mol\ne2e-mol.1\ne2e-mol.2\ne2e-no-such-row\n"
compare: json
pending: {slice: "SRV-1", reason: "bd blocked --flags reads listBlockingAnnotations is_blocked behind dependencies.blocking.isBlocked, which the reference server does not advertise, so the client refuses at its capability preflight (pinned passing against the current server by backend/http TestE2E_BlockedFlagsOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: gc-blocked-parent
source: bd blocked --parent (the molecule-scoped blocked listing)
args: [blocked, --json, --parent, e2e-mol]
pending: {slice: "SRV-1", reason: "bd blocked dials listBlockedIssues behind blocked.list, which the reference server does not advertise, so the client refuses at its capability preflight (pinned passing against the current server by backend/http TestE2E_BlockedOverHTTP); remove the mark when reference_server.json is upgraded"}
# ---------------------------------------------------------------- molecules
- id: mc-mol-current
source: mc worker prompts (bd mol current, ~38; inferred from in_progress work)
args: [mol, current, --json]
- id: mc-mol-current-text
source: mc gc-role-worker template (bd mol current, text)
args: [mol, current]
compare: text
- id: mc-mol-current-id
source: mc prompts (bd mol current <id>)
args: [mol, current, e2e-mol, --json]
- id: mc-mol-progress
source: mc prompts (bd mol progress <id>)
args: [mol, progress, e2e-mol, --json]
# ---------------------------------------------------------------- config / probes / local
- id: gc-config-get-types
source: gc beads_provider_lifecycle.go / checks_custom_types.go (config get --json types.custom)
args: [config, get, --json, types.custom]
- id: gc-config-get-prefix
source: gc gc-beads-bd.sh (config get issue_prefix)
args: [config, get, issue_prefix]
compare: text
- id: gc-types
source: gc checks_custom_types.go (types --json)
args: [types, --json]
- id: gc-context
source: gc beads_preflight_checker.go (context --json); never touches the store
args: [context, --json]
compare: exit
- id: gc-version
source: gc bdstore_blocked_repair.go BDVersion
args: [version]
compare: exit
- id: gc-ping
source: gc cmd_beads_city_migrate_proxied.go / dashboard (ping --json)
args: [ping, --json]
compare: exit
- id: mc-prime
source: mc formulas (bd prime)
args: [prime]
compare: exit
- id: gc-sql-ready-projection
source: gc bdstore_ready_projection.go fetchReadyProjection
args: [sql, "select id,is_blocked from issues where status <> 'closed' union all select id,is_blocked from wisps where status <> 'closed'", --json]
expect_exit: 1
expect_stderr: "'bd sql' is not yet supported"
compare: exit
- id: gc-sql-release-fallback
source: gc bdstore.go ReleaseIfCurrent fallback (sql UPDATE)
args: [sql, --json, "UPDATE issues SET status='open', assignee='' WHERE id='e2e-t-rel' AND status='in_progress' AND assignee='worker'"]
expect_exit: 1
expect_stderr: "'bd sql' is not yet supported"
compare: exit
- id: gc-purge-dry-run
source: gc bdstore.go Purge (purge --json --dry-run)
args: [purge, --json, --dry-run]
compare: exit
pending: {slice: "SRV-1", reason: "purge needs the sweep tokens the reference server does not advertise (B3 #13); remove the mark when reference_server.json is upgraded"}
- id: gc-recompute-blocked
source: gc bdstore_blocked_repair.go RecomputeBlocked
args: [recompute-blocked, --json]
compare: exit
- id: gc-backup-status
source: gc checks_proxied_backup_coverage.go (backup status --json)
args: [backup, status, --json]
compare: exit
# The seed holds an open gate, a closed gate and an ephemeral gate, so the
# open listing and the --all listing answer different, non-empty sets.
- id: mc-gate-list
source: gc core pack order renudge-stale-human-gates.sh (gc bd gate list --limit 0 --json)
args: [gate, list, --limit, "0", --json]
- id: mc-gate-list-all
source: core pack orders (gate list --all)
args: [gate, list, --all, --json]
# gate check lists the open gates through the same ListGates entry. No
# seeded gate carries an await type (the seed graph carries no gate members;
# mc-gate-check-timer-resolves below creates a real timer gate), so the
# typed sweeps find nothing of their type and the untyped one lists the open
# gates and evaluates none: the listing is what these shapes prove served,
# and nothing resolves, escalates (no gt exec) or writes.
- id: mc-gate-check-timer
source: gc core pack gate-sweep.sh (bd gate check --type=timer --escalate)
args: [gate, check, --type=timer, --escalate]
compare: text
- id: mc-gate-check-gh
source: gc core pack gate-sweep.sh (bd gate check --type=gh --escalate)
args: [gate, check, --type=gh, --escalate]
compare: text
- id: gate-check-all
source: bd gate check (every open gate)
args: [gate, check]
compare: text
- id: gc-export-all
source: gc core pack reaper (gc bd export --all -o F)
args: [export, --all, -o, "{file:export.jsonl}"]
compare: exit
# ================================================================ writes
# ---------------------------------------------------------------- create
- id: gc-create-full
source: gc bdstore.go CreateWithStorage (every optional flag but --parent)
args: [create, --json, "gc created", -t, task, --id, e2e-n1, --priority, "1", --description, "made by gc", --assignee, worker, --deps, e2e-r1, --labels, "lane:n,x", --metadata, '{"gc.routed_to":"pool-a"}']
compare: exit
verify: [[show, --json, e2e-n1]]
- id: gc-create-parent
source: gc bdstore.go CreateWithStorage (--parent, server-minted child id)
args: [create, --json, "gc child", -t, task, --parent, e2e-ep]
compare: exit
verify: [[show, --json, e2e-ep.3]]
- id: gc-create-ephemeral
source: gc bdstore.go CreateWithStorage (--ephemeral)
args: [create, --json, "gc wisp", -t, task, --id, e2e-wisp-n2, --ephemeral, --metadata, '{"gc.routed_to":"pool-a"}']
compare: exit
verify: [[show, --json, e2e-wisp-n2]]
- id: gc-create-no-history
source: gc bdstore.go CreateWithStorage (--no-history, agent beads)
args: [create, --json, "gc agent bead", -t, task, --id, e2e-n3, --no-history]
compare: exit
verify: [[show, --json, e2e-n3]]
- id: gc-create-defer
source: gc bdstore.go CreateWithStorage (--defer RFC3339)
args: [create, --json, "gc deferred", -t, task, --id, e2e-n4, --defer, "2100-01-01T00:00:00Z"]
compare: exit
verify: [[show, --json, e2e-n4]]
- id: mc-create-external-ref
source: mc snapshot.md (create --external-ref --labels --metadata --type)
args: [create, "triaged issue", --external-ref, gh-999, --labels, "triage", --metadata, '{"gc.kind":"github_source"}', --type, task, --id, e2e-n5, --json]
compare: exit
verify: [[show, --json, e2e-n5]]
- id: mc-create-text
source: mc prompts (bd create, text output)
args: [create, "plain create", --type, task, --id, e2e-n6]
compare: exit
verify: [[show, --json, e2e-n6]]
- id: gc-create-graph
source: gc bdstore_graph_apply.go ApplyGraphPlanWithStorage
args: [create, --graph, "{file:graph-small.json}", --json]
verify: [[show, --json, e2e-g-root, e2e-g-s1, e2e-g-s2]]
- id: gc-create-graph-ephemeral
source: gc bdstore_graph_apply.go (--ephemeral by storage class)
args: [create, --graph, "{file:graph-eph.json}", --json, --ephemeral]
verify: [[show, --json, e2e-wisp-g-root, e2e-wisp-g-s1]]
# ---------------------------------------------------------------- update
- id: gc-update-fields
source: gc bdstore.go bdUpdateArgs (Update)
args: [update, --json, e2e-t-upd, --title, "updated", --status, in_progress, --type, bug, --priority, "1", --description, "new", --assignee, bob, --set-metadata, a=1, --set-metadata, b=2, --add-label, x, --remove-label, "lane:z"]
compare: exit
verify: [[show, --json, e2e-t-upd]]
- id: gc-update-parent
source: gc bdstore.go bdUpdateArgs (--parent)
args: [update, --json, e2e-t-upd2, --parent, e2e-ep]
compare: exit
verify: [[show, --json, e2e-t-upd2]]
- id: gc-update-many
source: gc bdstore.go UpdateAll / setMetadataBatchAll
args: [update, --json, e2e-t-m1, e2e-t-m2, --set-metadata, gc.batch=1, --priority, "3"]
compare: exit
verify: [[show, --json, e2e-t-m1, e2e-t-m2]]
- id: gc-update-claim
source: gc bdstore.go BdStore.Claim and gc hook --claim (update <id> --claim --json)
args: [update, e2e-t-claim, --claim, --json]
compare: exit
verify: [[show, --json, e2e-t-claim]]
- id: gc-update-claim-actor
source: gc cmd_agent_script.go bd_claim (update <id> --claim --actor X)
args: [update, e2e-t-claim2, --claim, --actor, alice]
compare: exit
verify: [[show, --json, e2e-t-claim2]]
- id: gc-update-claim-wisp
source: gc ready queues include ephemeral work; claiming a wisp
args: [update, e2e-wisp-c, --claim, --json]
compare: exit
verify: [[show, --json, e2e-wisp-c]]
pending: {slice: "SRV-1", reason: "the reference server lacks UpdateIssueRequest.claim, and the claimIssue fallback excludes wisps (B3 #6); remove the mark when reference_server.json is upgraded"}
- id: gc-update-if-revision
source: gc bdstore_conditional.go UpdateIfMatch / CompareAndSetMetadataKey
args: [update, e2e-t-rev, --set-metadata, k=v, --if-revision, "{rev:e2e-t-rev}"]
compare: exit
verify: [[show, --json, e2e-t-rev]]
- id: gc-update-if-revision-stale
source: gc bdstore_conditional.go UpdateIfMatch mismatch (exit 13)
args: [update, e2e-t-rev2, --set-metadata, k=v, --if-revision, "1"]
expect_exit: 13
compare: exit
verify: [[show, --json, e2e-t-rev2]]
- id: gc-update-release-if-current
source: gc bdstore_conditional_release.go releaseIfCurrentViaBdVerb
args: [update, e2e-t-rel, --if-assignee, worker, --if-status, in_progress, --status, open, --assignee, ""]
compare: exit
verify: [[show, --json, e2e-t-rel]]
- id: gc-update-transfer-if-current
source: gc bdstore_conditional_release.go TransferIfCurrent
args: [update, e2e-t-xfer, --if-assignee, worker, --if-status, in_progress, --assignee, alice]
compare: exit
verify: [[show, --json, e2e-t-xfer]]
- id: gc-update-if-assignment
source: gc bdstore_conditional.go UpdateIfAssignment
args: [update, --json, e2e-t-ifa, --set-metadata, k=v, --if-status, in_progress, --if-assignee, worker]
compare: exit
verify: [[show, --json, e2e-t-ifa]]
# e2e-t-ifa is seeded with metadata seeded=keep, so each refused (exit 13)
# update's verify still holds that the refusal left existing metadata
# alone, in whichever corpus part runs it (the parts seed separately, so
# the k=v written by gc-update-if-assignment may not be there).
- id: gc-update-if-assignment-assignee-stale
source: gc bdstore_conditional.go UpdateIfAssignment mismatch (exit 13)
args: [update, --json, e2e-t-ifa, --set-metadata, probe=a, --if-status, in_progress, --if-assignee, nobody]
expect_exit: 13
compare: exit
verify: [[show, --json, e2e-t-ifa]]
- id: gc-update-if-assignment-status-stale
source: gc bdstore_conditional.go UpdateIfAssignment mismatch (exit 13)
args: [update, --json, e2e-t-ifa, --set-metadata, probe=s, --if-status, open, --if-assignee, worker]
expect_exit: 13
compare: exit
verify: [[show, --json, e2e-t-ifa]]
- id: gc-update-on-death
source: gc workquery.go on_death (update --assignee "" --status open --set-metadata)
args: [update, e2e-t-death, --assignee, "", --status, open, --set-metadata, gc.run_target=pool-a]
compare: exit
verify: [[show, --json, e2e-t-death]]
- id: gc-update-on-boot
source: gc workquery.go on_boot (update <id> --status open)
args: [update, e2e-t-boot, --status, open]
compare: exit
verify: [[show, --json, e2e-t-boot]]
- id: gc-update-sling
source: gc workquery.go DefaultSlingQuery (update --set-metadata gc.routed_to=)
args: [update, e2e-t-sling, --set-metadata, gc.routed_to=pool-b]
compare: exit
verify: [[show, --json, e2e-t-sling]]
- id: gc-update-agent-script
source: gc cmd_agent_script.go bd_update (--assignee --status --append-notes --set-metadata)
args: [update, e2e-t-as, --assignee, worker, --status, in_progress, --append-notes, "agent note", --set-metadata, k=v]
compare: exit
verify: [[show, --json, e2e-t-as]]
- id: gc-update-dolt-auto-commit-off
source: gc bdstore.go bdTransientWriteArgs (--dolt-auto-commit off prefix)
args: [--dolt-auto-commit, "off", update, --json, e2e-t-dac, --set-metadata, k=v]
compare: exit
verify: [[show, --json, e2e-t-dac]]
- id: mc-update-meta-status
source: mc prompts (update --set-metadata --status, ~151)
args: [update, e2e-t-ms, --set-metadata, review.verdict=iterate, --status, in_progress]
compare: exit
verify: [[show, --json, e2e-t-ms]]
- id: mc-update-meta-status-closed
source: mc prompts (update --set-metadata --status closed, under Claude Code)
args: [update, e2e-t-msc, --set-metadata, review.verdict=done, --status, closed]
compare: exit
verify: [[show, --json, e2e-t-msc]]
pending: {slice: "S6d", reason: "a silent data difference, not a refusal: the update succeeds on both sides under CLAUDE_SESSION_ID, but the served update records no closed_by_session (an http update patch cannot carry one, so the CLI drops it without a word; bd close does carry it) where embedded records the session, so the verify show differs (B3 #7)"}
- id: mc-update-unset-metadata
source: mc adopt-pr-operator (update --unset-metadata)
args: [update, e2e-t-um, --unset-metadata, k]
compare: exit
verify: [[show, --json, e2e-t-um]]
- id: mc-update-notes
source: mc github fix-issue formula (update --notes)
args: [update, e2e-t-notes, --notes, "notes text"]
compare: exit
verify: [[show, --json, e2e-t-notes]]
- id: mc-update-external-ref-metadata
source: mc snapshot.md (update --external-ref --metadata)
args: [update, e2e-t-er, --external-ref, gh-1, --metadata, '{"gc.kind":"github_source"}']
compare: exit
verify: [[show, --json, e2e-t-er]]
- id: mc-update-metadata
source: mc build-base prepare.md (update --metadata)
args: [update, e2e-t-md, --metadata, '{"x":"1"}']
compare: exit
verify: [[show, --json, e2e-t-md]]
- id: mc-update-assignee
source: mc review reports (update --assignee)
args: [update, e2e-t-asg, --assignee, bob]
compare: exit
verify: [[show, --json, e2e-t-asg]]
# ---------------------------------------------------------------- close / reopen
- id: gc-close-force-reason-many
source: gc bdstore.go bdCloseArgs (CloseAll/CloseAllWithReason)
args: [close, --force, --json, --reason, done, e2e-t-c1, e2e-t-c2]
compare: exit
verify: [[show, --json, e2e-t-c1, e2e-t-c2]]
- id: gc-close-if-revision
source: gc bdstore_conditional.go CloseIfMatch
args: [close, --force, --json, e2e-t-c3, --if-revision, "{rev:e2e-t-c3}"]
compare: exit
verify: [[show, --json, e2e-t-c3]]
- id: mc-close-text
source: mc formulas (bd close <id>)
args: [close, e2e-t-c4]
compare: exit
verify: [[show, --json, e2e-t-c4]]
- id: mc-close-reason
source: mc build-basic-review (bd close --reason)
args: [close, e2e-t-c5, --reason, "review applied"]
compare: exit
verify: [[show, --json, e2e-t-c5]]
- id: gc-close-last-step-autocloses-molecule
source: gc/mc molecule lifecycle (closing the last open step closes the root)
args: [close, --force, --json, e2e-mac.2]
compare: exit
verify: [[show, --json, e2e-mac]]
- id: gc-reopen
source: gc bdstore.go Reopen
args: [reopen, --json, e2e-t-ro]
compare: exit
verify: [[show, --json, e2e-t-ro]]
# ---------------------------------------------------------------- delete / reclaim / promote / burn
- id: gc-delete
source: gc bdstore.go Delete
args: [delete, --force, --json, e2e-t-d1]
compare: exit
verify: [[show, --json, e2e-t-d1]]
- id: gc-delete-if-revision
source: gc bdstore_conditional.go DeleteIfMatch
args: [delete, --force, --json, e2e-t-d2, --if-revision, "{rev:e2e-t-d2}"]
compare: exit
verify: [[show, --json, e2e-t-d2]]
- id: gc-delete-batch
source: gc bdstore.go DeleteBatch (no --json)
args: [delete, e2e-t-d3, e2e-t-d4, --force]
compare: exit
verify: [[show, --json, e2e-t-d3]]
- id: gc-delete-cascade
source: gc cmd_convoy_dispatch.go deleteWorkflowMatches
args: [delete, e2e-t-dc, --cascade, --force]
compare: exit
verify: [[show, --json, e2e-t-dc.1]]
- id: mc-delete-from-file
source: mc session_cleanup.py / core reaper (delete --from-file)
args: [delete, --from-file, "{file:delete-list.txt}", --force]
compare: exit
verify: [[show, --json, e2e-t-df1]]
- id: gc-reclaim
source: gc bdstore.go ReclaimStale (reclaim --id <id> --json)
args: [reclaim, --id, e2e-t-rc, --json]
compare: exit
verify: [[show, --json, e2e-t-rc]]
pending: {slice: "SRV-1", reason: "the reference server does not advertise issues.reclaim (B3 #12), so the client refuses at its capability preflight"}
- id: gc-heartbeat
source: gc formulas/mol-do-work.toml:47 (gc bd heartbeat <id> -> bd heartbeat)
setup: [[update, e2e-t-hb, --claim]]
args: [heartbeat, e2e-t-hb, --json]
verify: [[show, --json, e2e-t-hb]]
pending: {slice: "reference-server-heartbeat", reason: "the reference server does not advertise issues.heartbeat, so the client refuses at its capability preflight; pinned passing by backend/http TestE2E_HeartbeatOverHTTP; remove the mark when reference_server.json is upgraded"}
- id: gc-heartbeat-non-holder
source: gc formulas/mol-do-work.toml:47 (a worker heartbeating a bead another actor holds)
setup: [[update, e2e-t-hb2, --claim, --actor, alice]]
args: [heartbeat, e2e-t-hb2]
expect_exit: 1
expect_stderr: "(?i)claimed by|alice"
compare: exit
pending: {slice: "reference-server-heartbeat", reason: "the reference server does not advertise issues.heartbeat, so the client refuses at its capability preflight; pinned passing by backend/http TestE2E_HeartbeatOverHTTP; remove the mark when reference_server.json is upgraded"}
- id: gc-heartbeat-closed
source: gc formulas/mol-do-work.toml:47 (a worker heartbeating a bead that was closed under it)
setup: [[update, e2e-t-hb3, --claim], [close, e2e-t-hb3]]
args: [heartbeat, e2e-t-hb3]
expect_exit: 1
expect_stderr: "(?i)status closed|is closed"
compare: exit
pending: {slice: "reference-server-heartbeat", reason: "the reference server does not advertise issues.heartbeat, so the client refuses at its capability preflight; pinned passing by backend/http TestE2E_HeartbeatOverHTTP; remove the mark when reference_server.json is upgraded"}
- id: gc-heartbeat-wisp
source: gc formulas/mol-do-work.toml:47 (a heartbeat on a wisp, which is never leased)
args: [heartbeat, e2e-wisp-2]
expect_exit: 1
expect_stderr: "(?i)ephemeral"
compare: exit
pending: {slice: "reference-server-heartbeat", reason: "the reference server does not advertise issues.heartbeat, so the client refuses at its capability preflight; pinned passing by backend/http TestE2E_HeartbeatOverHTTP; remove the mark when reference_server.json is upgraded"}
- id: mc-promote
source: mc mol-normalized-issue-pr-v1 (promote --reason)
args: [promote, e2e-wisp-p, --reason, "keep it"]
compare: exit
pending: {slice: "SRV-1", reason: "the reference server does not advertise issues.update.persistence, so the client refuses at its capability preflight"}
- id: mc-mol-burn
source: mc review fixtures (mol burn --force)
args: [mol, burn, e2e-wisp-m, --force]
compare: exit
verify: [[show, --json, e2e-wisp-m.1]]
pending: {slice: "S17", reason: "mol burn needs RunInTransaction (B3 #14)"}
# ---------------------------------------------------------------- deps / comments / labels / config writes
- id: gc-dep-add
source: gc bdstore.go DepAdd
args: [dep, add, e2e-t-da, e2e-t-db, --type, blocks]
compare: exit
verify: [[dep, list, e2e-t-da, --json]]
- id: gc-dep-remove
source: gc bdstore.go DepRemove
args: [dep, remove, e2e-t-dr, e2e-t-db]
compare: exit
verify: [[dep, list, e2e-t-dr, --json]]
- id: mc-comment
source: mc bug_hunt.py (bd comment <id> <text>)
args: [comment, e2e-t-cm, "a comment"]
compare: exit
verify: [[comments, e2e-t-cm, --json]]
ignore_fields: [id] # comment ids are minted per workspace
- id: mc-comments-list
source: mc prompts (bd comments <id>)
args: [comments, e2e-r1, --json]
ignore_fields: [id] # comment ids are minted per workspace
- id: mc-label-add
source: mc prompts (bd label add)
args: [label, add, e2e-t-l, "lane:q"]
compare: exit
verify: [[show, --json, e2e-t-l]]
- id: mc-assign
source: mc prompts (bd assign)
args: [assign, e2e-t-as2, alice]
compare: exit
verify: [[show, --json, e2e-t-as2]]
- id: gc-config-set-types
source: gc beads_provider_lifecycle.go (config set types.custom a,b)
args: [config, set, types.custom, "corpus-a,corpus-b"]
compare: exit
verify: [[config, get, --json, types.custom]]
- id: mc-meta-set
source: mc adopt-pr-review checks (bd meta set <id> k=v)
args: [meta, set, e2e-r1, review.verdict=done]
expect_exit: 1
expect_stderr: 'unknown command "meta"'
compare: exit
# ---------------------------------------------------------------- gates
# The gate writes: create (one createIssue carrying the gate members and the
# blocks edge), a real timer gate resolving under gate check, add-waiter (a
# guarded waiters patch) and update --await-id. A --timeout=1ns timer is
# expired by the time gate check runs, so the resolution is deterministic.
- id: mc-gate-create-timer
source: core formulas / gate-sweep (bd gate create --type=timer --timeout --blocks)
args: [gate, create, --type=timer, --timeout=1ns, --blocks, e2e-t-gcr, --json]
ignore_fields: [id] # each side mints its own gate id
pending: {slice: "SRV-1", reason: "bd gate create sends the gate members on createIssue behind issues.create.gates, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_GatesOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-gate-check-timer-resolves
source: core gate-sweep.sh (gate check --type=timer --escalate) over a real timer gate
setup: [[gate, create, --type=timer, --timeout=1ns, --blocks, e2e-t-gct]]
args: [gate, check, --type=timer, --escalate]
compare: exit
verify: [[ready, --json, --limit, "0"]] # e2e-t-gct is ready on both sides
ignore_fields: [depends_on_id] # its (closed) gate's id is minted per workspace
pending: {slice: "SRV-1", reason: "the setup bd gate create sends the gate members on createIssue behind issues.create.gates, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_GatesOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-gate-add-waiter
source: bd done --phase-complete (gate add-waiter)
args: [gate, add-waiter, e2e-t-gw, "rig/workers/a"]
compare: text
verify: [[show, --json, e2e-t-gw]]
pending: {slice: "SRV-1", reason: "bd gate add-waiter sends waiters on updateIssue behind issues.update.gates, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_GatesOverHTTP); remove the mark when reference_server.json is upgraded"}
- id: mc-update-await-id
source: gate discover / gate check gh:run persist (update --await-id)
args: [update, e2e-t-gaw, --await-id, "12345", --json]
compare: exit
verify: [[show, --json, e2e-t-gaw]]
pending: {slice: "SRV-1", reason: "bd update --await-id sends await_id on updateIssue behind issues.update.gates, which the reference server does not advertise, so the client refuses before dialing (pinned passing against the current server by backend/http TestE2E_GatesOverHTTP); remove the mark when reference_server.json is upgraded"}

View file

@ -1,595 +0,0 @@
{
"comment": [
"The reference server profile the corpus suite masks the in-process server to.",
"It is the wire surface of a deployed bd 1.3.0 `bd serve` that predates wire_revision:",
"capabilities is that server's advertised ContextResponse.capabilities (read off a live GET /v0/beads/context),",
"context_members is its ContextResponse property set, and operations are the method, path template,",
"query parameter names and top-level JSON request members of its published OpenAPI document (MIT).",
"Regenerate by hand when the reference deployment is upgraded; see README.md."
],
"capabilities": [
"config.get",
"config.list",
"config.set",
"config.unset",
"dependencies.add",
"dependencies.blocking",
"dependencies.count",
"dependencies.cycles",
"dependencies.list",
"dependencies.remove",
"dependencies.tree",
"events.list",
"events.watch",
"issues.addComment",
"issues.batchApply",
"issues.batchClose",
"issues.batchCreate",
"issues.casMetadata",
"issues.claim",
"issues.claimNext",
"issues.close",
"issues.count",
"issues.create",
"issues.delete",
"issues.get",
"issues.list",
"issues.list.sort",
"issues.query",
"issues.related",
"issues.release",
"issues.reopen",
"issues.sweep",
"issues.update",
"memories.forget",
"memories.get",
"memories.list",
"memories.remember",
"policy.external_dependencies",
"project.enforce",
"ready.count",
"ready.list",
"stats.get"
],
"context_members": [
"api_version",
"backend",
"bd_version",
"beads_dir",
"capabilities",
"database",
"dolt_mode",
"project_id",
"repo_root",
"schema_version"
],
"operations": [
{
"method": "GET",
"path": "/healthz",
"operation_id": "health",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/config",
"operation_id": "listSettings",
"query": [],
"body": []
},
{
"method": "DELETE",
"path": "/v0/beads/config/{key}",
"operation_id": "unsetSetting",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/config/{key}",
"operation_id": "getSetting",
"query": [],
"body": []
},
{
"method": "PUT",
"path": "/v0/beads/config/{key}",
"operation_id": "setSetting",
"query": [],
"body": [
"value"
]
},
{
"method": "GET",
"path": "/v0/beads/context",
"operation_id": "getContext",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/dependencies",
"operation_id": "listDependencies",
"query": [
"issue_id",
"type"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/dependencies/blocking",
"operation_id": "listBlockingAnnotations",
"query": [
"issue_id"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/dependencies/cycles",
"operation_id": "listDependencyCycles",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/dependencies/tree",
"operation_id": "getDependencyTree",
"query": [
"direction",
"max_depth",
"root_id",
"status"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/dependencies:add",
"operation_id": "addDependencies",
"query": [],
"body": [
"actor",
"edges"
]
},
{
"method": "GET",
"path": "/v0/beads/dependencies:count",
"operation_id": "countDependencyEdges",
"query": [
"direction",
"issue_id",
"status",
"type"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/dependencies:remove",
"operation_id": "removeDependency",
"query": [],
"body": [
"actor",
"depends_on_id",
"issue_id"
]
},
{
"method": "GET",
"path": "/v0/beads/events",
"operation_id": "listEvents",
"query": [
"limit",
"since"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/events:watch",
"operation_id": "watchEvents",
"query": [
"since"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/issues",
"operation_id": "listIssues",
"query": [
"all",
"assignee",
"brief",
"created_after",
"created_before",
"cursor",
"exclude_label",
"has_metadata_key",
"include_ephemeral",
"include_gates",
"include_infra",
"include_templates",
"label",
"label_any",
"limit",
"metadata_field",
"parent",
"reverse",
"sort",
"status",
"type"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/issues",
"operation_id": "createIssue",
"query": [],
"body": [
"acceptance_criteria",
"actor",
"assignee",
"defer_until",
"dependencies",
"description",
"design",
"due_at",
"ephemeral",
"estimated_minutes",
"external_ref",
"force_id_prefix",
"id",
"inherit_labels_from_parent",
"issue_type",
"labels",
"metadata",
"no_history",
"notes",
"owner",
"parent_id",
"priority",
"sender",
"status",
"title",
"waits_for"
]
},
{
"method": "GET",
"path": "/v0/beads/issues/{id}",
"operation_id": "getIssue",
"query": [
"brief_deps",
"include_comments",
"include_dependents"
],
"body": []
},
{
"method": "PATCH",
"path": "/v0/beads/issues/{id}",
"operation_id": "updateIssue",
"query": [],
"body": [
"actor",
"expected_assignee",
"expected_status",
"expected_version",
"force_assignee_transfer",
"force_close_policy",
"patch"
]
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}/comments",
"operation_id": "addComment",
"query": [],
"body": [
"author",
"text"
]
},
{
"method": "GET",
"path": "/v0/beads/issues/{id}/related",
"operation_id": "listRelatedIssues",
"query": [
"direction",
"type"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}:casMetadata",
"operation_id": "compareAndSetMetadata",
"query": [],
"body": [
"actor",
"expected",
"key",
"value"
]
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}:claim",
"operation_id": "claimIssue",
"query": [],
"body": [
"actor"
]
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}:close",
"operation_id": "closeIssue",
"query": [],
"body": [
"actor",
"expected_version",
"force",
"reason",
"session"
]
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}:release",
"operation_id": "releaseIssue",
"query": [],
"body": [
"actor",
"expected_assignee",
"force"
]
},
{
"method": "POST",
"path": "/v0/beads/issues/{id}:reopen",
"operation_id": "reopenIssue",
"query": [],
"body": [
"actor",
"expected_version",
"reason"
]
},
{
"method": "POST",
"path": "/v0/beads/issues:batchApply",
"operation_id": "applyBatch",
"query": [],
"body": [
"actor",
"force_id_prefix",
"items",
"provenance",
"skip_per_edge_cycle_check"
]
},
{
"method": "POST",
"path": "/v0/beads/issues:batchClose",
"operation_id": "batchCloseIssues",
"query": [],
"body": [
"actor",
"claim_next",
"force",
"items",
"session"
]
},
{
"method": "POST",
"path": "/v0/beads/issues:batchCreate",
"operation_id": "batchCreateIssues",
"query": [],
"body": [
"actor",
"items"
]
},
{
"method": "POST",
"path": "/v0/beads/issues:claimNext",
"operation_id": "claimNextIssue",
"query": [
"assignee",
"exclude_label",
"exclude_type",
"has_metadata_key",
"include_deferred",
"include_ephemeral",
"label",
"label_any",
"label_pattern",
"label_regex",
"metadata_field",
"parent",
"priority",
"sort",
"type",
"unassigned"
],
"body": [
"actor"
]
},
{
"method": "GET",
"path": "/v0/beads/issues:count",
"operation_id": "countIssues",
"query": [
"assignee",
"closed_after",
"closed_before",
"created_after",
"created_before",
"desc_contains",
"empty_description",
"group_by",
"id",
"include_infra",
"label",
"label_any",
"metadata_field",
"no_assignee",
"no_labels",
"notes_contains",
"priority",
"priority_max",
"priority_min",
"status",
"title",
"title_contains",
"type",
"updated_after",
"updated_before"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/issues:delete",
"operation_id": "deleteIssues",
"query": [],
"body": [
"actor",
"cascade",
"dry_run",
"expected_version",
"force",
"ids"
]
},
{
"method": "GET",
"path": "/v0/beads/issues:query",
"operation_id": "queryIssues",
"query": [
"all",
"limit",
"q",
"reverse",
"sort"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/issues:sweep",
"operation_id": "sweepIssues",
"query": [],
"body": [
"actor",
"closed_before",
"dry_run",
"pattern",
"protect_referenced",
"tier"
]
},
{
"method": "GET",
"path": "/v0/beads/memories",
"operation_id": "listMemories",
"query": [
"search"
],
"body": []
},
{
"method": "POST",
"path": "/v0/beads/memories",
"operation_id": "rememberMemory",
"query": [],
"body": [
"content",
"key"
]
},
{
"method": "DELETE",
"path": "/v0/beads/memories/{key}",
"operation_id": "forgetMemory",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/memories/{key}",
"operation_id": "getMemory",
"query": [],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/ready",
"operation_id": "listReadyWork",
"query": [
"assignee",
"brief",
"exclude_label",
"exclude_type",
"has_metadata_key",
"include_deferred",
"include_ephemeral",
"label",
"label_any",
"label_pattern",
"label_regex",
"limit",
"metadata_field",
"parent",
"priority",
"sort",
"type",
"unassigned"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/ready:count",
"operation_id": "countReadyWork",
"query": [
"assignee",
"exclude_label",
"exclude_type",
"has_metadata_key",
"include_deferred",
"include_ephemeral",
"label",
"label_any",
"label_pattern",
"label_regex",
"metadata_field",
"parent",
"priority",
"type",
"unassigned"
],
"body": []
},
{
"method": "GET",
"path": "/v0/beads/stats",
"operation_id": "getStats",
"query": [
"assignee",
"skip_blocked"
],
"body": []
}
]
}

View file

@ -12,12 +12,6 @@ import (
// persist a secret, and must FAIL CLOSED: a configured source that errors
// aborts the request rather than silently downgrading to an unauthenticated
// one.
//
// Authorize is called once per request, not once per attempt: a read whose
// first attempt stalls or has its connection reset is resent once with the
// same headers, up to the client's overall timeout later. A provider whose
// credentials are single-use or short-lived should expect that resend to draw
// a 401, which reaches Refresh like any other.
type CredentialProvider = httpclient.CredentialProvider
const (
@ -53,14 +47,11 @@ func NewBearerProvider(base *url.URL) *BearerProvider {
//
// A multi-tenant embedder (for example gc, Gas City: one process serving many
// workspaces, called "cities") that wants a distinct credential per workspace
// wraps that workspace's own provider in a ProvidedCredential when it opens
// through the registry (the direct door takes the provider itself, as
// Options.Credential): the registered dialer Register installs is
// wraps that workspace's own provider in a ProvidedCredential rather than
// calling Open directly: the registered dialer Register installs is
// process-wide and cannot hold one credential per tenant, but the per-open
// OpenWith seam can, and this is the opaque wrapper type that seam
// recognizes. Either way the supplied provider is the ONLY credential the
// open uses, and no ambient credential, CA or plaintext grant is read; see the
// package doc's "Credentials" section. See httpclient.ResolveCredential and
// recognizes. See httpclient.ResolveCredential and
// backends.OpenOptions.Credential's own doc comment for the single-tenant
// ambient-ladder default this exists to opt out of.
type ProvidedCredential = httpclient.ProvidedCredential

View file

@ -1,287 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"context"
"encoding/json"
"errors"
"os/exec"
"reflect"
"sort"
"strings"
"testing"
"github.com/steveyegge/beads/internal/storage/issueops"
)
// runBDStdin is runBD with stdin.
func runBDStdin(t *testing.T, f *remoteRolesFixture, stdin string, args ...string) bdResult {
t.Helper()
cmd := exec.Command(f.bin, args...)
cmd.Dir = f.dir
cmd.Env = minimalBDEnv(f.dir)
cmd.Stdin = strings.NewReader(stdin)
var o, e strings.Builder
cmd.Stdout, cmd.Stderr = &o, &e
err := cmd.Run()
code := 0
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
code = exitErr.ExitCode()
} else if err != nil {
t.Fatalf("run bd %v: %v", args, err)
}
return bdResult{stdout: o.String(), stderr: e.String(), code: code}
}
type blockedFlagRow struct {
ID string `json:"id"`
IsBlocked bool `json:"is_blocked"`
}
func parseBlockedFlags(t *testing.T, out string) []blockedFlagRow {
t.Helper()
var rows []blockedFlagRow
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &rows); err != nil {
t.Fatalf("parse bd blocked --flags --json: %v\n%s", err, out)
}
if rows == nil {
t.Fatalf("bd blocked --flags --json printed null, want an array: %s", out)
}
return rows
}
// flagStdin is every id the fixture created, in title order, plus an id that
// names no row, a blank line and a repeat: the omitted, ignored and collapsed
// cases.
func flagStdin(f *remoteRolesFixture) string {
titles := make([]string, 0, len(f.ids))
for title := range f.ids {
titles = append(titles, title)
}
sort.Strings(titles)
var b strings.Builder
for _, title := range titles {
b.WriteString(f.ids[title] + "\n")
}
b.WriteString("\n " + f.ids[titles[0]] + " \ne2e-no-such-row\n")
return b.String()
}
// TestE2E_BlockedFlagsOverHTTP runs `bd blocked --flags --json` (the blocked
// flag per id read from stdin, the readiness column gc projects) through the
// real `bd` binary against an in-process `bd serve` and against a local
// embedded workspace holding the same graph, and requires the same JSON once
// each generated id is mapped to its title. Over HTTP the read is
// listBlockingAnnotations with is_blocked; an older server's handshake is
// refused before the dial, naming dependencies.blocking.isBlocked.
//
// It also pins that this is the FLAG and not the listing: a row whose stored
// flag is set with no nameable blocker reads true here and is absent from
// `bd blocked --json`.
func TestE2E_BlockedFlagsOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
seed := func(f *remoteRolesFixture) {
f.seed()
blocker := f.create("blocker", "-t", "task")
gp := f.create("gate-parent", "-t", "epic")
kid := f.create("gate-kid", "-t", "task")
f.mustRun(nil, "dep", "add", kid, gp, "--type", "parent-child")
f.mustRun(nil, "dep", "add", gp, blocker)
}
t.Run("served equals local", func(t *testing.T) {
addr := startE2EServer(t)
local := newEmbeddedFixture(t, bin)
seed(local)
served := newHTTPFixture(t, bin, addr)
seed(served)
lr := runBDStdin(t, local, flagStdin(local), "blocked", "--flags", "--json")
sr := runBDStdin(t, served, flagStdin(served), "blocked", "--flags", "--json")
if lr.code != 0 || sr.code != 0 {
t.Fatalf("exit local=%d served=%d\nlocal: %s %s\nserved: %s %s", lr.code, sr.code, lr.stdout, lr.stderr, sr.stdout, sr.stderr)
}
normalize := func(f *remoteRolesFixture, rows []blockedFlagRow) []blockedFlagRow {
titleOf := map[string]string{}
for title, id := range f.ids {
titleOf[id] = title
}
out := make([]blockedFlagRow, 0, len(rows))
for _, row := range rows {
if title, ok := titleOf[row.ID]; ok {
row.ID = title
}
out = append(out, row)
}
return out
}
want := normalize(local, parseBlockedFlags(t, lr.stdout))
got := normalize(served, parseBlockedFlags(t, sr.stdout))
if !reflect.DeepEqual(want, got) {
t.Errorf("served bd blocked --flags --json differs from the local command:\nlocal: %v\nserved: %v", want, got)
}
if len(want) != len(local.ids) {
t.Errorf("local answered %d rows for %d ids (the unknown id omitted, the repeat collapsed): %v", len(want), len(local.ids), want)
}
blocked := map[string]bool{}
for _, row := range got {
blocked[row.ID] = row.IsBlocked
}
for title, wantBlocked := range map[string]bool{
"loner": true, "child-x": true, "gate-parent": true, "gate-kid": true,
"blocker": false, "child-b": false, "parent": false,
} {
if blocked[title] != wantBlocked {
t.Errorf("%s is_blocked = %v, want %v (rows %v)", title, blocked[title], wantBlocked, got)
}
}
// Byte-for-byte the same members in the same order.
if strings.Count(lr.stdout, "\n") != strings.Count(sr.stdout, "\n") {
t.Errorf("line counts differ:\nlocal:\n%s\nserved:\n%s", lr.stdout, sr.stdout)
}
// Nothing piped is an empty array.
if r := runBDStdin(t, served, "", "blocked", "--flags", "--json"); r.code != 0 || strings.TrimSpace(r.stdout) != "[]" {
t.Errorf("empty stdin: exit %d stdout %q, want [] and exit 0", r.code, r.stdout)
}
// The listing's filters are refused, not silently ignored.
if r := runBDStdin(t, served, "x\n", "blocked", "--flags", "--json", "--label", "a"); r.code != 1 {
t.Errorf("--flags --label exited %d, want 1: %s", r.code, r.stdout)
}
})
t.Run("the flag, not the listing", func(t *testing.T) {
addr, reference := startE2EServerWithStore(t, e2eProjectID, e2eDatabase)
served := newHTTPFixture(t, bin, addr)
stale := served.create("stale")
if err := reference.RunEventsMaintenanceTx(context.Background(), func(ctx context.Context, tx issueops.DBTX) error {
_, err := tx.ExecContext(ctx, "UPDATE issues SET is_blocked = 1 WHERE id = ?", stale)
return err
}); err != nil {
t.Fatalf("set the stale flag: %v", err)
}
rows := parseBlockedFlags(t, runBDStdin(t, served, stale+"\n", "blocked", "--flags", "--json").stdout)
if len(rows) != 1 || rows[0].ID != stale || !rows[0].IsBlocked {
t.Errorf("--flags for a stale-flagged row = %v, want [{%s true}]", rows, stale)
}
listing := served.mustRun(nil, "blocked", "--json").stdout
if strings.Contains(listing, stale) {
t.Errorf("bd blocked --json lists %s, which has no nameable blocker: %s", stale, listing)
}
})
t.Run("raw is the stored column", func(t *testing.T) {
addr, reference := startE2EServerWithStore(t, e2eProjectID, e2eDatabase)
local := newEmbeddedFixture(t, bin)
seed(local)
served := newHTTPFixture(t, bin, addr)
seed(served)
flagsOf := func(f *remoteRolesFixture, stdin string, args ...string) map[string]bool {
t.Helper()
r := runBDStdin(t, f, stdin, append([]string{"blocked", "--flags", "--json"}, args...)...)
if r.code != 0 {
t.Fatalf("bd blocked --flags --json %v exited %d: %s %s", args, r.code, r.stdout, r.stderr)
}
titleOf := map[string]string{}
for title, id := range f.ids {
titleOf[id] = title
}
out := map[string]bool{}
for _, row := range parseBlockedFlags(t, r.stdout) {
key := row.ID
if title, ok := titleOf[row.ID]; ok {
key = title
}
out[key] = row.IsBlocked
}
return out
}
localRaw := flagsOf(local, flagStdin(local), "--raw")
servedRaw := flagsOf(served, flagStdin(served), "--raw")
if !reflect.DeepEqual(localRaw, servedRaw) {
t.Errorf("served --raw differs from local --raw:\nlocal: %v\nserved: %v", localRaw, servedRaw)
}
lr := runBDStdin(t, local, flagStdin(local), "blocked", "--flags", "--json", "--raw")
sr := runBDStdin(t, served, flagStdin(served), "blocked", "--flags", "--json", "--raw")
if strings.Count(lr.stdout, "\n") != strings.Count(sr.stdout, "\n") {
t.Errorf("--raw line counts differ:\nlocal:\n%s\nserved:\n%s", lr.stdout, sr.stdout)
}
// child-x is blocked ONLY by an unsatisfied external ref: the policy
// flag says blocked, the stored column does not.
decorated := flagsOf(served, flagStdin(served))
if !decorated["child-x"] || servedRaw["child-x"] || localRaw["child-x"] {
t.Errorf("child-x (externally blocked only): --flags %v, --raw served %v local %v; want true, false, false",
decorated["child-x"], servedRaw["child-x"], localRaw["child-x"])
}
// Locally blocked rows read the same either way.
for _, title := range []string{"loner", "gate-parent", "gate-kid", "blocker"} {
if decorated[title] != servedRaw[title] {
t.Errorf("%s: --flags %v, --raw %v; a local blocker is the column", title, decorated[title], servedRaw[title])
}
}
// A stale flag (set, no blocker) is the column, so both read true.
stale := served.create("stale")
if err := reference.RunEventsMaintenanceTx(context.Background(), func(ctx context.Context, tx issueops.DBTX) error {
_, err := tx.ExecContext(ctx, "UPDATE issues SET is_blocked = 1 WHERE id = ?", stale)
return err
}); err != nil {
t.Fatalf("set the stale flag: %v", err)
}
if got := flagsOf(served, stale+"\n", "--raw"); !got["stale"] {
t.Errorf("--raw for the stale-flagged row = %v, want true", got)
}
if got := flagsOf(served, stale+"\n"); !got["stale"] {
t.Errorf("--flags for the stale-flagged row = %v, want true", got)
}
// --raw qualifies --flags only.
if r := runBDStdin(t, served, "", "blocked", "--json", "--raw"); r.code != 1 || !strings.Contains(r.stdout+r.stderr, "--raw") {
t.Errorf("bd blocked --raw without --flags: exit %d %s %s, want exit 1 naming --raw", r.code, r.stdout, r.stderr)
}
// A server that applies the policy answers the decorated flag and the
// wire cannot ask it for the column: --raw is refused there, before
// the annotation read, rather than answered with the policy flag.
proxyAddr, counter := startMaskingProxy(t, addr, func(body map[string]any) {
caps, _ := body["capabilities"].([]any)
body["capabilities"] = append(caps, "policy.external_dependencies")
})
enforced := newHTTPFixture(t, bin, proxyAddr)
counter.reset()
r := runBDStdin(t, enforced, served.ids["child-x"]+"\n", "blocked", "--flags", "--json", "--raw")
if r.code != 1 || !strings.Contains(r.stdout+r.stderr, "policy.external_dependencies") {
t.Errorf("--raw against a policy server: exit %d %s %s, want exit 1 naming the policy token", r.code, r.stdout, r.stderr)
}
for _, p := range counter.snapshot() {
if strings.Contains(p, "/v0/beads/dependencies/blocking") {
t.Errorf("a refused --raw dialed %s", p)
}
}
})
t.Run("older server mask", func(t *testing.T) {
addr := startE2EServer(t)
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
counter.reset()
r := runBDStdin(t, f, "e2e-anything\n", "blocked", "--flags", "--json")
if r.code != 1 {
t.Fatalf("bd blocked --flags against a server without the token exited %d, want 1: %s", r.code, r.stdout)
}
if !strings.Contains(r.stdout+r.stderr, "dependencies.blocking.isBlocked") {
t.Errorf("refusal does not name the missing capability: stdout=%s stderr=%s", r.stdout, r.stderr)
}
for _, p := range counter.snapshot() {
if strings.Contains(p, "/v0/beads/dependencies/blocking") {
t.Errorf("a refused bd blocked --flags dialed %s", p)
}
}
})
}

View file

@ -1,229 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"reflect"
"slices"
"strings"
"testing"
)
// TestE2E_BlockedOverHTTP runs `bd blocked --json` (the blocked door gc's
// readiness projection reads) through the real `bd` binary against an
// in-process `bd serve`, and against a local embedded workspace holding the
// same graph.
//
// Over HTTP the CLI takes the store's BlockedLister, which dials
// GET /v0/beads/blocked behind blocked.list. The two answers must be the same
// JSON once the values that cannot agree between two workspaces (each row's
// generated id, and its timestamps) are mapped out: the same rows, the same
// members, the same blockers (local, parent-attributed and external), in the
// same order. Against a server that does not advertise blocked.list (an older
// server's handshake) the client refuses before the dial, naming the token.
func TestE2E_BlockedOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
seedBlocked := func(f *remoteRolesFixture) {
f.seed()
// A plain blocks edge, a blocked parent's child attributed to the
// parent, and a labelled blocked row for the filter arms.
blocker := f.create("blocker", "-t", "task", "-p", "1")
gp := f.create("gate-parent", "-t", "epic", "-p", "2")
// Its own priority: rows tied on priority and created_at fall to the
// id order, and ids are generated per workspace, so a tie would order
// the two workspaces differently.
kid := f.create("gate-kid", "-t", "task", "-p", "3")
tagged := f.create("tagged", "-t", "task", "-p", "1", "-l", "lane:a")
// Blocked by nothing but an unsatisfied external ref, as child-x is,
// and labelled: the decorator lists such rows itself, after the label
// query ran, so the filter arms must judge them too.
extTagged := f.create("ext-tagged", "-t", "task", "-p", "4", "-l", "lane:a")
f.mustRun(nil, "dep", "add", kid, gp, "--type", "parent-child")
f.mustRun(nil, "dep", "add", gp, blocker)
f.mustRun(nil, "dep", "add", tagged, blocker)
f.mustRun(nil, "dep", "add", extTagged, "external:other:cap")
}
local := newEmbeddedFixture(t, bin)
seedBlocked(local)
served := newHTTPFixture(t, bin, addr)
seedBlocked(served)
for _, args := range [][]string{
{"blocked", "--json"},
{"blocked", "--json", "--label", "lane:a"},
{"blocked", "--json", "--label-any", "lane:a"},
{"blocked", "--json", "--exclude-label", "lane:a"},
{"blocked", "--json", "--parent", "{gate-parent}"},
{"blocked", "--json", "--label", "no-such-label"},
} {
t.Run(strings.Join(args[1:], " "), func(t *testing.T) {
want := local.mustRun(nil, local.expand(args)...).stdout
got := served.mustRun(nil, served.expand(args)...).stdout
if strings.TrimSpace(want) == "null" || strings.TrimSpace(got) == "null" {
t.Fatalf("bd blocked --json printed null: local=%s served=%s", want, got)
}
if w, g := normalizeBlocked(t, local, want), normalizeBlocked(t, served, got); !reflect.DeepEqual(w, g) {
t.Errorf("served bd blocked --json differs from the local command:\nlocal: %v\nserved: %v", w, g)
}
if w, g := blockedKeyOrder(t, want), blockedKeyOrder(t, got); !reflect.DeepEqual(w, g) {
t.Errorf("served member order %v differs from the local command's %v", g, w)
}
})
}
t.Run("names the external blocker", func(t *testing.T) {
got := normalizeBlocked(t, served, served.mustRun(nil, "blocked", "--json").stdout)
found := false
for _, row := range got {
if row["id"] == "child-x" {
found = reflect.DeepEqual(row["blocked_by"], []any{"external:other:cap"})
}
}
if !found {
t.Errorf("served bd blocked --json does not list child-x blocked by its external ref: %v", got)
}
})
// The arms above compare the two answers, which agree just as well when
// both list a row the filter rules out. These pin which rows each filter
// leaves, the external-only ones (child-x unlabelled, ext-tagged
// labelled) among them.
for _, tc := range []struct {
args []string
want []string // the whole listing, when set
listed, ruled []string
}{
{args: []string{"--label", "lane:a"}, want: []string{"ext-tagged", "tagged"}},
{args: []string{"--label-any", "lane:a"}, want: []string{"ext-tagged", "tagged"}},
{args: []string{"--label", "no-such-label"}, want: []string{}},
{args: []string{"--exclude-label", "lane:a"}, listed: []string{"child-x"}, ruled: []string{"ext-tagged", "tagged"}},
} {
t.Run("filters external-only rows "+strings.Join(tc.args, " "), func(t *testing.T) {
for _, f := range []struct {
name string
f *remoteRolesFixture
}{{"local", local}, {"served", served}} {
got := f.f.titlesOf(f.f.mustRun(nil, append([]string{"blocked", "--json"}, tc.args...)...).stdout)
if tc.want != nil && !slices.Equal(got, tc.want) {
t.Errorf("%s bd blocked %s listed %v, want %v", f.name, strings.Join(tc.args, " "), got, tc.want)
}
for _, title := range tc.listed {
if !slices.Contains(got, title) {
t.Errorf("%s bd blocked %s does not list %s: %v", f.name, strings.Join(tc.args, " "), title, got)
}
}
for _, title := range tc.ruled {
if slices.Contains(got, title) {
t.Errorf("%s bd blocked %s lists %s, which the filter rules out: %v", f.name, strings.Join(tc.args, " "), title, got)
}
}
}
})
}
t.Run("older server mask", func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
counter.reset()
r := f.run(nil, "blocked", "--json")
if r.code != 1 {
t.Fatalf("bd blocked against a server without blocked.list exited %d, want 1: %s", r.code, r.stdout)
}
if !strings.Contains(r.stdout+r.stderr, "blocked.list") {
t.Errorf("refusal does not name the missing capability: stdout=%s stderr=%s", r.stdout, r.stderr)
}
for _, p := range counter.snapshot() {
if strings.Contains(p, "/v0/beads/blocked") {
t.Errorf("a refused bd blocked dialed %s; the refusal must come before the dial", p)
}
}
})
}
// normalizeBlocked parses `bd blocked --json` and maps out what two
// workspaces cannot share: each id (and each blocker id) becomes the title the
// fixture created it under, and every timestamp member is blanked.
func normalizeBlocked(t *testing.T, f *remoteRolesFixture, out string) []map[string]any {
t.Helper()
var rows []map[string]any
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &rows); err != nil {
t.Fatalf("parse bd blocked --json: %v\n%s", err, out)
}
titleOf := map[string]string{}
for title, id := range f.ids {
titleOf[id] = title
}
var walk func(key string, v any) any
walk = func(key string, v any) any {
switch v := v.(type) {
case map[string]any:
for k, inner := range v {
v[k] = walk(k, inner)
}
return v
case []any:
for i := range v {
v[i] = walk("", v[i])
}
return v
case string:
if strings.HasSuffix(key, "_at") {
return "<time>"
}
if title, ok := titleOf[v]; ok {
return title
}
}
return v
}
for _, row := range rows {
walk("", row)
}
return rows
}
// blockedKeyOrder is the member order of each row as printed, so the two
// encodings are compared as text, not only as values.
func blockedKeyOrder(t *testing.T, out string) [][]string {
t.Helper()
var rows []json.RawMessage
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &rows); err != nil {
t.Fatalf("parse bd blocked --json: %v\n%s", err, out)
}
order := make([][]string, 0, len(rows))
for _, raw := range rows {
dec := json.NewDecoder(strings.NewReader(string(raw)))
var keys []string
depth := 0
for {
tok, err := dec.Token()
if err != nil {
break
}
switch v := tok.(type) {
case json.Delim:
if v == '{' || v == '[' {
depth++
} else {
depth--
}
case string:
if depth == 1 {
keys = append(keys, v)
// Skip the value.
var skip json.RawMessage
if err := dec.Decode(&skip); err != nil {
t.Fatalf("decode value of %s: %v", v, err)
}
}
}
}
order = append(order, keys)
}
return order
}

View file

@ -733,15 +733,6 @@ func startE2EServer(t *testing.T) string {
// the one a prior `bd connect` already pinned, to prove the pin is honored
// rather than silently replaced.
func startE2EServerWithIdentity(t *testing.T, projectID, database string) string {
t.Helper()
addr, _ := startE2EServerWithStore(t, projectID, database)
return addr
}
// startE2EServerWithStore is startE2EServerWithIdentity that also hands back
// the reference store the server serves, for a test that must plant or age
// state no wire verb can reach (an aged lease row).
func startE2EServerWithStore(t *testing.T, projectID, database string) (string, *embeddeddolt.EmbeddedDoltStore) {
t.Helper()
beadsDir := t.TempDir()
ctx := context.Background()
@ -770,7 +761,7 @@ func startE2EServerWithStore(t *testing.T, projectID, database string) (string,
t.Error("the in-process server did not shut down")
}
})
return srv.Addr(), reference
return srv.Addr()
}
func e2eServeConfig(t *testing.T, s storage.DoltStorage, projectID, database string) httpapi.Config {
@ -812,10 +803,6 @@ func e2eServeConfig(t *testing.T, s storage.DoltStorage, projectID, database str
fail("BatchGetter")
cfg.LeaseReclaimer, err = s.LeaseReclaimer()
fail("LeaseReclaimer")
cfg.Heartbeater, err = s.Heartbeater()
fail("Heartbeater")
cfg.BlockedLister, err = s.BlockedLister()
fail("BlockedLister")
cfg.Relations, err = s.IssueRelations()
fail("IssueRelations")
cfg.Commenter, err = s.Commenter()

View file

@ -1,203 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"maps"
"os"
"path/filepath"
"strconv"
"strings"
"testing"
)
type exportLine struct {
Type string `json:"_type"`
ID string `json:"id"`
Ephemeral bool `json:"ephemeral"`
NoHistory bool `json:"no_history"`
WispPlane *bool `json:"wisp_plane"`
Labels []string `json:"labels"`
CommentCount int `json:"comment_count"`
DepCount int `json:"dependency_count"`
Dependencies []struct {
IssueID string `json:"issue_id"`
DependsOnID string `json:"depends_on_id"`
Type string `json:"type"`
} `json:"dependencies"`
Comments []struct {
Text string `json:"text"`
} `json:"comments"`
// Key and Value are a memory record's fields.
Key string `json:"key"`
Value string `json:"value"`
}
// plane renders the explicit wisps-plane marker: "absent", "true" or "false".
func (l exportLine) plane() string {
if l.WispPlane == nil {
return "absent"
}
return strconv.FormatBool(*l.WispPlane)
}
func readExportRecords(t *testing.T, path string) []exportLine {
t.Helper()
data, err := os.ReadFile(path)
if err != nil {
t.Fatalf("read export: %v", err)
}
var out []exportLine
for _, line := range strings.Split(strings.TrimSpace(string(data)), "\n") {
if line == "" {
continue
}
var rec exportLine
if err := json.Unmarshal([]byte(line), &rec); err != nil {
t.Fatalf("parse export line %q: %v", line, err)
}
out = append(out, rec)
}
return out
}
func readExportLines(t *testing.T, path string) map[string]exportLine {
t.Helper()
out := map[string]exportLine{}
for _, rec := range readExportRecords(t, path) {
if rec.Type == "issue" {
out[rec.ID] = rec
}
}
return out
}
// readExportMemories returns an export's memory records, value by key.
func readExportMemories(t *testing.T, path string) map[string]string {
t.Helper()
out := map[string]string{}
for _, rec := range readExportRecords(t, path) {
if rec.Type == "memory" {
out[rec.Key] = rec.Value
}
}
return out
}
func wantExportMemories(t *testing.T, export string, got, want map[string]string) {
t.Helper()
if !maps.Equal(got, want) {
t.Errorf("%s memories = %v, want %v", export, got, want)
}
}
// TestE2E_ExportOverHTTP is S21. `bd export` read through the raw SearchIssues
// method and the bulk relation reads, which the http backend refuses, so gc's
// JSONL-export order failed on every remote scope. It now composes served role
// reads (issueops.ReadExport): the rows with their labels and counts, every
// row's dependency records and the comment bodies. Memories come from the
// served memory plane (listMemories): the settings enumeration withholds every
// kv.* row, so a remote export that read them there carried none.
//
// The no-history row pins the one place this route still differs from the
// local ones. No served read publishes plane membership, so the row is
// exported without the wisp_plane marker, and a current import pins it to the
// durable issues plane: the data-safe side, since a wrong marker would drop a
// durable row's relations (bd-r9uce). Serving the membership (bd-1lbvas)
// flips those assertions: the row is then marked and re-imports as a wisp.
func TestE2E_ExportOverHTTP(t *testing.T) {
bd := connectE2EWorkspace(t, "worker")
blocked := createE2EIssue(t, bd, "blocked work")
blocker := createE2EIssue(t, bd, "blocker")
mustRun(t, bd, "dep", "add", blocked, blocker, "--json")
mustRun(t, bd, "label", "add", blocked, "lane:x", "--json")
mustRun(t, bd, "comments", "add", blocked, "an export comment")
closed := createE2EIssue(t, bd, "closed work")
mustRun(t, bd, "close", closed, "--json")
wisp := firstJSONField(t, mustRun(t, bd, "create", "a wisp", "--ephemeral", "--json").stdout, "id")
noHistory := firstJSONField(t, mustRun(t, bd, "create", "a no-history wisp", "--no-history", "--json").stdout, "id")
memories := map[string]string{
"export-alpha": "remembered over http",
"export-beta": "a second memory",
}
for key, content := range memories {
mustRun(t, bd, "remember", content, "--key", key)
}
dir := t.TempDir()
all := filepath.Join(dir, "all.jsonl")
mustRun(t, bd, "export", "--all", "-o", all)
wantExportMemories(t, "bd export --all", readExportMemories(t, all), memories)
got := readExportLines(t, all)
for _, id := range []string{blocked, blocker, closed, wisp, noHistory} {
if _, ok := got[id]; !ok {
t.Errorf("bd export --all is missing %s; got %d issues", id, len(got))
}
}
rec := got[blocked]
if len(rec.Dependencies) != 1 || rec.Dependencies[0].DependsOnID != blocker || rec.DepCount != 1 {
t.Errorf("%s dependencies = %+v (count %d), want one edge onto %s", blocked, rec.Dependencies, rec.DepCount, blocker)
}
if len(rec.Labels) != 1 || rec.Labels[0] != "lane:x" {
t.Errorf("%s labels = %v, want [lane:x]", blocked, rec.Labels)
}
if rec.CommentCount != 1 || len(rec.Comments) != 1 || rec.Comments[0].Text != "an export comment" {
t.Errorf("%s comments = %+v (count %d), want the one comment", blocked, rec.Comments, rec.CommentCount)
}
if !got[wisp].Ephemeral {
t.Errorf("%s exported without ephemeral: %+v", wisp, got[wisp])
}
if rec := got[noHistory]; !rec.NoHistory || rec.plane() != "absent" {
t.Errorf("%s exported as no_history=%v wisp_plane=%s, want no_history with no marker", noHistory, rec.NoHistory, rec.plane())
}
// The default export keeps every status and the no-history row, and drops
// the true wisp.
def := filepath.Join(dir, "default.jsonl")
mustRun(t, bd, "export", "-o", def)
gotDef := readExportLines(t, def)
if _, ok := gotDef[wisp]; ok {
t.Errorf("bd export (default) exported the wisp %s", wisp)
}
for _, id := range []string{blocked, blocker, closed, noHistory} {
if _, ok := gotDef[id]; !ok {
t.Errorf("bd export (default) is missing %s", id)
}
}
if rec := gotDef[noHistory]; rec.plane() != "absent" {
t.Errorf("bd export (default) stamped %s wisp_plane=%s, want no marker", noHistory, rec.plane())
}
// Memories are opt-in: absent by default, present with --include-memories.
wantExportMemories(t, "bd export (default)", readExportMemories(t, def), map[string]string{})
withMemories := filepath.Join(dir, "memories.jsonl")
mustRun(t, bd, "export", "--include-memories", "-o", withMemories)
wantExportMemories(t, "bd export --include-memories", readExportMemories(t, withMemories), memories)
// Import the remote export into a fresh local workspace and export it
// again there. The local route stamps wisp_plane from table membership,
// which the locally created control row proves, so the imported row's
// missing marker means it sits in the durable issues table.
bin := buildBD(t)
localDir := t.TempDir()
local := func(args ...string) bdResult {
t.Helper()
return runBD(t, bin, localDir, []string{"BEADS_ACTOR=worker"}, args...)
}
mustRun(t, local, "init", "--prefix", "e2e", "--quiet")
mustRun(t, local, "import", "-i", all)
control := firstJSONField(t, mustRun(t, local, "create", "a local no-history wisp", "--no-history", "--json").stdout, "id")
back := filepath.Join(dir, "reexport.jsonl")
mustRun(t, local, "export", "--all", "-o", back)
gotBack := readExportLines(t, back)
if rec, ok := gotBack[control]; !ok || rec.plane() != "true" {
t.Fatalf("local control %s exported with wisp_plane=%s (present=%v), want true", control, rec.plane(), ok)
}
wantExportMemories(t, "the local re-export", readExportMemories(t, back), memories)
if rec, ok := gotBack[noHistory]; !ok {
t.Errorf("the local re-export is missing the imported %s", noHistory)
} else if !rec.NoHistory || rec.plane() != "absent" {
t.Errorf("imported %s re-exported as no_history=%v wisp_plane=%s, want no_history on the durable plane (no marker)", noHistory, rec.NoHistory, rec.plane())
}
}

View file

@ -1,315 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"fmt"
"net/http"
"os"
"path/filepath"
"slices"
"strings"
"sync"
"testing"
"time"
)
// gateTokens are the two behavior tokens the gate commands depend on:
// issues.create.gates for a create carrying gate members (bd gate create),
// issues.update.gates for an await_id or waiters patch (bd gate add-waiter,
// bd gate discover, gate check's gh:run persist, bd update --await-id).
var gateTokens = []string{"issues.create.gates", "issues.update.gates"}
// withoutGateTokens rewrites the handshake into a server that predates the
// gate members: the live capability list minus the two gate tokens.
func withoutGateTokens(body map[string]any) {
caps, _ := body["capabilities"].([]any)
kept := make([]any, 0, len(caps))
for _, c := range caps {
if s, _ := c.(string); slices.Contains(gateTokens, s) {
continue
}
kept = append(kept, c)
}
body["capabilities"] = kept
}
// gateShow is the subset of `bd show --json` the gate cases read.
type gateShow struct {
ID string `json:"id"`
Status string `json:"status"`
IssueType string `json:"issue_type"`
AwaitType string `json:"await_type"`
AwaitID string `json:"await_id"`
Timeout int64 `json:"timeout"`
Waiters []string `json:"waiters"`
}
func showGate(t *testing.T, f *remoteRolesFixture, id string) gateShow {
t.Helper()
out := strings.TrimSpace(f.mustRun(nil, "show", id, "--json").stdout)
var rows []gateShow
if err := json.Unmarshal([]byte(out), &rows); err != nil {
var one gateShow
if err1 := json.Unmarshal([]byte(out), &one); err1 != nil {
t.Fatalf("parse bd show --json: %v\n%s", err, out)
}
return one
}
if len(rows) == 0 {
t.Fatalf("bd show %s --json returned no row", id)
}
return rows[0]
}
func readyIDs(t *testing.T, f *remoteRolesFixture) map[string]bool {
t.Helper()
ids := map[string]bool{}
for _, row := range jsonRows(t, f.mustRun(nil, "ready", "--json", "--limit", "0").stdout) {
if id, ok := row["id"].(string); ok {
ids[id] = true
}
}
return ids
}
func writesOf(paths []string) []string {
var writes []string
for _, p := range paths {
if !strings.HasPrefix(p, http.MethodGet+" ") {
writes = append(writes, p)
}
}
return writes
}
// TestE2E_GatesOverHTTP runs the gate commands through the real `bd` binary
// against an in-process `bd serve`.
//
// Against a server that advertises the gate tokens:
// - `bd gate create` is ONE createIssue carrying the gate members and the
// blocks edge (timer, gh:run and bead gates), and the blocked issue
// leaves the ready set;
// - `bd gate check --type=timer` closes an expired timer gate and the
// blocked issue becomes ready;
// - `bd gate add-waiter` registers a waiter once (the repeat writes nothing);
// - `bd update --await-id` sets await_id.
//
// Against a server that does not advertise them, each command is refused
// before any write, naming the token it needs, and nothing changes.
func TestE2E_GatesOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
proxyAddr, counter := startCountingProxy(t, addr)
f := newHTTPFixture(t, bin, proxyAddr)
var waiterGate string
t.Run("advertised", func(t *testing.T) {
timerTarget := f.create("timer target")
counter.reset()
created := f.mustRun(nil, "gate", "create", "--type=timer", "--timeout=1ns", "--blocks", timerTarget, "--json")
if w := writesOf(counter.snapshot()); !slices.Equal(w, []string{"POST /v0/beads/issues"}) {
t.Errorf("gate create wrote %v, want exactly one createIssue", w)
}
timerGate := firstJSONField(t, created.stdout, "id")
if g := showGate(t, f, timerGate); g.IssueType != "gate" || g.AwaitType != "timer" || g.Timeout != 1 || g.Status != "open" {
t.Errorf("timer gate reads back %+v, want an open timer gate with a 1ns timeout", g)
}
if readyIDs(t, f)[timerTarget] {
t.Errorf("%s is ready while its gate is open", timerTarget)
}
time.Sleep(10 * time.Millisecond)
r := f.mustRun(nil, "gate", "check", "--type=timer", "--escalate")
if !strings.Contains(r.stdout, "1 resolved") {
t.Errorf("gate check --type=timer = %q, want one resolved gate", r.stdout)
}
if g := showGate(t, f, timerGate); g.Status != "closed" {
t.Errorf("expired timer gate %s is %s after gate check, want closed", timerGate, g.Status)
}
if !readyIDs(t, f)[timerTarget] {
t.Errorf("%s is not ready after its timer gate resolved", timerTarget)
}
runTarget := f.create("run target")
runGate := firstJSONField(t, f.mustRun(nil, "gate", "create", "--type=gh:run", "--await-id=ci-wf", "--repo=owner/repo", "--blocks", runTarget, "--json").stdout, "id")
if g := showGate(t, f, runGate); g.AwaitType != "gh:run" || g.AwaitID != "ci-wf" {
t.Errorf("gh:run gate reads back %+v, want await gh:run ci-wf", g)
}
awaited := f.create("awaited bead")
beadTarget := f.create("bead target")
beadGate := firstJSONField(t, f.mustRun(nil, "gate", "create", "--type=bead", "--await-id", awaited, "--blocks", beadTarget, "--json").stdout, "id")
if g := showGate(t, f, beadGate); g.AwaitType != "bead" || g.AwaitID != awaited {
t.Errorf("bead gate reads back %+v, want await bead %s", g, awaited)
}
waiterGate = beadGate
counter.reset()
r = f.mustRun(nil, "gate", "add-waiter", beadGate, "rig/workers/a")
if !strings.Contains(r.stdout, "Added waiter to gate "+beadGate+": rig/workers/a") {
t.Errorf("add-waiter output = %q", r.stdout)
}
if w := writesOf(counter.snapshot()); len(w) != 1 || !strings.HasPrefix(w[0], "PATCH /v0/beads/issues/") {
t.Errorf("add-waiter wrote %v, want one updateIssue", w)
}
counter.reset()
r = f.mustRun(nil, "gate", "add-waiter", beadGate, "rig/workers/a")
if !strings.Contains(r.stdout, "Waiter already registered on gate "+beadGate) {
t.Errorf("repeat add-waiter output = %q", r.stdout)
}
if w := writesOf(counter.snapshot()); len(w) != 0 {
t.Errorf("a repeat add-waiter wrote %v", w)
}
f.mustRun(nil, "gate", "add-waiter", beadGate, "rig/workers/b")
if g := showGate(t, f, beadGate); !slices.Equal(g.Waiters, []string{"rig/workers/a", "rig/workers/b"}) {
t.Errorf("waiters = %v, want [rig/workers/a rig/workers/b]", g.Waiters)
}
f.mustRun(nil, "update", runGate, "--await-id", "12345", "--json")
if g := showGate(t, f, runGate); g.AwaitID != "12345" {
t.Errorf("await_id after update --await-id = %q, want 12345", g.AwaitID)
}
})
// A convoy registering on one gate at once: every adder must exit 0 and
// every waiter must be on the gate. Each round of simultaneous guarded
// writes has one winner, so this pins the retry backoff, not just the
// compare-and-set.
t.Run("concurrent add-waiter", func(t *testing.T) {
const adders = 10
target := f.create("convoy target")
gate := firstJSONField(t, f.mustRun(nil, "gate", "create", "--blocks", target, "--json").stdout, "id")
results := make([]bdResult, adders+1)
var wg sync.WaitGroup
start := make(chan struct{})
for i := 0; i <= adders; i++ {
waiter := fmt.Sprintf("rig/workers/c%d", i%adders) // the last one repeats c0
wg.Add(1)
go func(i int) {
defer wg.Done()
<-start
results[i] = f.run(nil, "gate", "add-waiter", gate, waiter)
}(i)
}
close(start)
wg.Wait()
for i, r := range results {
if r.code != 0 {
t.Errorf("adder %d exited %d: %s", i, r.code, r.stderr)
}
}
got := showGate(t, f, gate).Waiters
slices.Sort(got)
var want []string
for i := 0; i < adders; i++ {
want = append(want, fmt.Sprintf("rig/workers/c%d", i))
}
slices.Sort(want)
if !slices.Equal(got, want) {
t.Errorf("waiters after %d concurrent adders = %v, want each exactly once: %v", adders+1, got, want)
}
})
// gate discover over HTTP: a fake gh answers the run listing, and the
// discovered run ID is recorded through updateIssue (issues.update.gates).
binDir := t.TempDir()
gh := `#!/bin/sh
case "$1 $2" in
"run list") echo '[{"databaseId":4242,"name":"ci-wf","status":"in_progress","conclusion":"","createdAt":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","workflowName":"ci-wf","headBranch":"main"}]' ;;
*) echo "unexpected gh $*" >&2; exit 3 ;;
esac
`
if err := os.WriteFile(filepath.Join(binDir, "gh"), []byte(gh), 0o755); err != nil {
t.Fatalf("write fake gh: %v", err)
}
ghEnv := []string{"PATH=" + binDir + string(os.PathListSeparator) + os.Getenv("PATH")}
t.Run("discover", func(t *testing.T) {
target := f.create("discover target")
gate := firstJSONField(t, f.mustRun(nil, "gate", "create", "--type=gh:run", "--await-id=ci-wf", "--blocks", target, "--json").stdout, "id")
counter.reset()
r := f.run(ghEnv, "gate", "discover")
if r.code != 0 {
t.Fatalf("gate discover exited %d: %s %s", r.code, r.stdout, r.stderr)
}
if !strings.Contains(r.stdout, "Updated 1 gate(s)") {
t.Errorf("gate discover output = %q, want one updated gate", r.stdout)
}
if w := writesOf(counter.snapshot()); len(w) != 1 || !strings.HasPrefix(w[0], "PATCH /v0/beads/issues/") {
t.Errorf("gate discover wrote %v, want one updateIssue", w)
}
if g := showGate(t, f, gate); g.AwaitID != "4242" {
t.Errorf("await_id after discover = %q, want 4242", g.AwaitID)
}
})
t.Run("refused without the tokens", func(t *testing.T) {
if waiterGate == "" {
t.Skip("the advertised case created no gate")
}
maskedAddr, maskedCounter := startMaskingProxy(t, addr, withoutGateTokens)
m := newHTTPFixture(t, bin, maskedAddr)
target := m.create("masked target")
before := showGate(t, f, waiterGate)
cases := []struct {
name string
args []string
token string
}{
{"gate create", []string{"gate", "create", "--type=timer", "--timeout=1h", "--blocks", target}, "issues.create.gates"},
{"gate create human", []string{"gate", "create", "--blocks", target}, "issues.create.gates"},
{"gate add-waiter", []string{"gate", "add-waiter", waiterGate, "rig/workers/c"}, "issues.update.gates"},
{"update --await-id", []string{"update", waiterGate, "--await-id", "999"}, "issues.update.gates"},
}
for _, tc := range cases {
maskedCounter.reset()
r := m.run(nil, tc.args...)
if r.code == 0 {
t.Errorf("%s against a server without %s exited 0: %s", tc.name, tc.token, r.stdout)
}
if !strings.Contains(r.stderr, tc.token) {
t.Errorf("%s refusal does not name %s: %s", tc.name, tc.token, r.stderr)
}
if w := writesOf(maskedCounter.snapshot()); len(w) != 0 {
t.Errorf("a refused %s wrote %v; the refusal must come before any write", tc.name, w)
}
}
// gate discover finds the run but cannot record it: the gate's error
// names the token, nothing is written, and the command fails rather
// than reporting the gate as updated.
runTarget := f.create("masked discover target")
runGate := firstJSONField(t, f.mustRun(nil, "gate", "create", "--type=gh:run", "--await-id=ci-wf", "--blocks", runTarget, "--json").stdout, "id")
maskedCounter.reset()
r := m.run(ghEnv, "gate", "discover")
if r.code == 0 {
t.Errorf("gate discover against a server without issues.update.gates exited 0: %s", r.stdout)
}
if !strings.Contains(r.stderr, "issues.update.gates") || !strings.Contains(r.stderr, runGate) {
t.Errorf("gate discover refusal does not name the gate and issues.update.gates: %s", r.stderr)
}
if strings.Contains(r.stdout, "Updated 1") {
t.Errorf("gate discover reported the refused gate as updated: %s", r.stdout)
}
if w := writesOf(maskedCounter.snapshot()); len(w) != 0 {
t.Errorf("a refused gate discover wrote %v", w)
}
if g := showGate(t, f, runGate); g.AwaitID != "ci-wf" {
t.Errorf("await_id after a refused discover = %q, want ci-wf untouched", g.AwaitID)
}
if !readyIDs(t, m)[target] {
t.Errorf("%s left the ready set though every gate create was refused", target)
}
after := showGate(t, f, waiterGate)
if after.AwaitID != before.AwaitID || !slices.Equal(after.Waiters, before.Waiters) {
t.Errorf("refused writes changed the gate: before %+v after %+v", before, after)
}
})
}

View file

@ -1,185 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"context"
"encoding/json"
"strings"
"testing"
"time"
"github.com/steveyegge/beads/internal/storage/issueops"
)
// TestE2E_HeartbeatOverHTTP runs `bd heartbeat <id>` — the keepalive gc's
// mol-do-work formula issues every ~90s (`gc bd heartbeat`, corpus shapes
// gc-heartbeat*) — through the real `bd` binary against an in-process `bd
// serve`.
//
// The CLI takes the store's Heartbeater, which over HTTP dials POST
// /v0/beads/issues/{id}:heartbeat. What a worker relies on is pinned here end
// to end: exit 0 and the {"id","status":"heartbeat","owner"} shape for the
// holder, with the row's revision and updated_at UNCHANGED (the heartbeat
// writes only the lease, so the holder's guarded writes keep their token);
// exit 1 for a foreign holder (whose lease stays untouched), a closed issue, a
// wisp and an unclaimed issue, each saying which. Against a server that does
// not advertise issues.heartbeat (an older server's handshake shape) the
// client refuses BEFORE the dial, naming the token, and never falls back.
func TestE2E_HeartbeatOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr, reference := startE2EServerWithStore(t, e2eProjectID, e2eDatabase)
leaseRow := func(id string) string {
t.Helper()
var row string
if err := reference.RunEventsMaintenanceTx(context.Background(), func(ctx context.Context, tx issueops.DBTX) error {
return tx.QueryRowContext(ctx,
"SELECT CONCAT(holder, '|', CAST(lease_expires_at AS CHAR), '|', CAST(heartbeat_at AS CHAR)) FROM leases WHERE issue_id = ?", id,
).Scan(&row)
}); err != nil {
t.Fatalf("read the lease row on %s: %v", id, err)
}
return row
}
ageLease := func(id string) {
t.Helper()
aged := time.Now().UTC().Add(-time.Minute).Truncate(time.Second)
if err := reference.RunEventsMaintenanceTx(context.Background(), func(ctx context.Context, tx issueops.DBTX) error {
_, err := tx.ExecContext(ctx, "UPDATE leases SET lease_expires_at = ?, heartbeat_at = ? WHERE issue_id = ?", aged, aged, id)
return err
}); err != nil {
t.Fatalf("age the lease on %s: %v", id, err)
}
}
heartbeatPosts := func(paths []string) int {
n := 0
for _, p := range paths {
if strings.HasPrefix(p, "POST ") && strings.HasSuffix(p, ":heartbeat") {
n++
}
}
return n
}
t.Run("advertised", func(t *testing.T) {
proxyAddr, counter := startCountingProxy(t, addr)
f := newHTTPFixture(t, bin, proxyAddr)
id := f.create("heartbeat target")
f.mustRun(nil, "update", id, "--claim", "--actor", "worker-7")
before := f.mustRun(nil, "show", id, "--json").stdout
revision := firstJSONField(t, before, "revision")
if revision == "" {
t.Fatalf("bd show --json reported no revision: %s", before)
}
updatedAt := firstJSONField(t, before, "updated_at")
counter.reset()
r := f.mustRun(nil, "heartbeat", id, "--actor", "worker-7", "--json")
var out map[string]any
if err := json.Unmarshal([]byte(strings.TrimSpace(r.stdout)), &out); err != nil {
t.Fatalf("parse bd heartbeat --json: %v\n%s", err, r.stdout)
}
if out["id"] != id || out["status"] != "heartbeat" || out["owner"] != "worker-7" {
t.Errorf("bd heartbeat --json = %v, want {id: %s, status: heartbeat, owner: worker-7}", out, id)
}
if n := heartbeatPosts(counter.snapshot()); n != 1 {
t.Errorf("bd heartbeat sent %d :heartbeat requests, want exactly one: %v", n, counter.snapshot())
}
for _, p := range counter.snapshot() {
if strings.HasPrefix(p, "PATCH ") || (strings.HasPrefix(p, "POST ") && !strings.HasSuffix(p, ":heartbeat")) {
t.Errorf("bd heartbeat sent %s; a heartbeat writes nothing but the lease", p)
}
}
after := f.mustRun(nil, "show", id, "--json").stdout
if got := firstJSONField(t, after, "revision"); got != revision {
t.Errorf("revision moved across a heartbeat: %s -> %s; a guarded write against the pre-heartbeat token would now fail", revision, got)
}
if got := firstJSONField(t, after, "updated_at"); got != updatedAt {
t.Errorf("updated_at moved across a heartbeat: %s -> %s", updatedAt, got)
}
// The holder's guarded write with the pre-heartbeat token still lands.
f.mustRun(nil, "update", id, "--notes", "still mine", "--if-revision", revision, "--actor", "worker-7")
// A second heartbeat is fine: it only moves the expiry later.
f.mustRun(nil, "heartbeat", id, "--actor", "worker-7")
})
t.Run("refusals", func(t *testing.T) {
f := newHTTPFixture(t, bin, addr)
foreign := f.create("held by alice")
f.mustRun(nil, "update", foreign, "--claim", "--actor", "alice")
// Aged first, so a heartbeat that ignored the holder fence would
// really change the row rather than rewrite the claim's own second.
ageLease(foreign)
held := leaseRow(foreign)
r := f.run(nil, "heartbeat", foreign, "--actor", "bob")
if r.code != 1 || !strings.Contains(r.stderr, "claimed by alice") {
t.Errorf("heartbeat by a non-holder: exit %d stderr=%s, want exit 1 naming the holder", r.code, r.stderr)
}
if got := leaseRow(foreign); got != held {
t.Errorf("a refused heartbeat by a non-holder moved alice's lease: %s -> %s", held, got)
}
// Each lease_not_held names the one state it found, and no other.
says := func(what, stderr, want string, not ...string) {
t.Helper()
if !strings.Contains(stderr, want) {
t.Errorf("heartbeat on %s: stderr=%s, want it to say %q", what, stderr, want)
}
for _, n := range not {
if strings.Contains(stderr, n) {
t.Errorf("heartbeat on %s: stderr=%s says %q, which is not the state it found", what, stderr, n)
}
}
}
closed := f.create("closed under its worker")
f.mustRun(nil, "update", closed, "--claim", "--actor", "worker-7")
f.mustRun(nil, "close", closed, "--actor", "worker-7")
r = f.run(nil, "heartbeat", closed, "--actor", "worker-7")
if r.code != 1 {
t.Errorf("heartbeat on a closed issue exited %d, want 1: %s", r.code, r.stderr)
}
says("a closed issue", r.stderr, "is closed", "ephemeral", "not claimed")
wisp := f.create("a wisp is never leased", "--ephemeral")
r = f.run(nil, "heartbeat", wisp, "--actor", "worker-7")
if r.code != 1 {
t.Errorf("heartbeat on a wisp exited %d, want 1: %s", r.code, r.stderr)
}
says("a wisp", r.stderr, "ephemeral wisp", "closed", "not claimed")
unclaimed := f.create("never claimed")
r = f.run(nil, "heartbeat", unclaimed, "--actor", "worker-7")
if r.code != 1 {
t.Errorf("heartbeat on an unclaimed issue exited %d, want 1: %s", r.code, r.stderr)
}
says("an unclaimed issue", r.stderr, "not claimed", "closed", "ephemeral")
})
t.Run("older server mask", func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
id := f.create("an old server cannot refresh this lease")
f.mustRun(nil, "update", id, "--claim", "--actor", "worker-7")
counter.reset()
r := f.run(nil, "heartbeat", id, "--actor", "worker-7")
if r.code != 1 {
t.Fatalf("bd heartbeat against a server without issues.heartbeat exited %d, want 1: %s", r.code, r.stdout)
}
if !strings.Contains(r.stderr, "issues.heartbeat") {
t.Errorf("refusal does not name the missing capability: %s", r.stderr)
}
for _, p := range counter.snapshot() {
if !strings.HasPrefix(p, "GET ") {
t.Errorf("a refused heartbeat sent %s; the refusal must come before any write", p)
}
}
})
}

View file

@ -1,137 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"strings"
"testing"
)
// TestE2E_LinkOverHTTP runs `bd link` through the real `bd` binary against an
// in-process `bd serve`.
//
// bd link writes through the DependencyEditor role (one addDependencies
// request), so it is served over http for any type a workspace spells, well-
// known or not: the server takes any 1-32 character type. Its own checks —
// a non-empty type of at most 32 characters — refuse before anything is
// written, and an edge that already exists with another type reports the
// typed conflict.
func TestE2E_LinkOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
proxyAddr, counter := startCountingProxy(t, addr)
f := newHTTPFixture(t, bin, proxyAddr)
t.Run("custom types are served", func(t *testing.T) {
for _, depType := range []string{"owned-by", "ships-in", "available-in", "excluded-from", "advances", "launches", "blocks"} {
from := f.create("link source " + depType)
to := f.create("link target " + depType)
counter.reset()
r := f.mustRun(nil, "link", from, to, "--type", depType, "--json")
var out map[string]any
if err := json.Unmarshal([]byte(strings.TrimSpace(r.stdout)), &out); err != nil {
t.Fatalf("bd link --json: %v\n%s", err, r.stdout)
}
if out["status"] != "added" || out["issue_id"] != from || out["depends_on_id"] != to || out["type"] != depType {
t.Errorf("bd link --type %s --json = %v, want added %s -> %s", depType, out, from, to)
}
adds := 0
for _, p := range counter.snapshot() {
if p == "POST /v0/beads/dependencies:add" {
adds++
}
}
if adds != 1 {
t.Errorf("bd link --type %s sent %d addDependencies requests, want exactly one: %v", depType, adds, counter.snapshot())
}
list := f.mustRun(nil, "dep", "list", from, "--json").stdout
if !depListHas(t, list, to, depType) {
t.Errorf("bd dep list %s does not show the %s edge to %s: %s", from, depType, to, list)
}
}
})
t.Run("text output names both issues", func(t *testing.T) {
from := f.create("text link source")
to := f.create("text link target")
r := f.mustRun(nil, "link", from, to, "--type", "owned-by")
if !strings.Contains(r.stdout, "Linked:") || !strings.Contains(r.stdout, "text link source") ||
!strings.Contains(r.stdout, "text link target") || !strings.Contains(r.stdout, "(owned-by)") {
t.Errorf("bd link output = %q, want the Linked line with both titles and the type", r.stdout)
}
})
t.Run("invalid types refuse before any write", func(t *testing.T) {
from := f.create("invalid link source")
to := f.create("invalid link target")
for _, depType := range []string{"", strings.Repeat("x", 33)} {
counter.reset()
r := f.run(nil, "link", from, to, "--type", depType)
if r.code == 0 {
t.Fatalf("bd link --type %q exited 0: %s", depType, r.stdout)
}
if !strings.Contains(r.stderr, "invalid dependency type") {
t.Errorf("bd link --type %q stderr = %s, want the invalid-type refusal", depType, r.stderr)
}
for _, p := range counter.snapshot() {
if !strings.HasPrefix(p, "GET ") {
t.Errorf("bd link --type %q wrote %s; the refusal must come before any write", depType, p)
}
}
}
if list := f.mustRun(nil, "dep", "list", from, "--json").stdout; depListHas(t, list, to, "") {
t.Errorf("a refused link left an edge %s -> %s: %s", from, to, list)
}
})
t.Run("an edge of another type is a typed conflict", func(t *testing.T) {
from := f.create("conflict source")
to := f.create("conflict target")
f.mustRun(nil, "link", from, to, "--type", "owned-by")
r := f.run(nil, "link", from, to, "--type", "ships-in")
if r.code == 0 {
t.Fatalf("bd link over an existing owned-by edge with ships-in exited 0: %s", r.stdout)
}
// The server answers the role's typed conflict as 409
// dependency_exists, which the client surfaces verbatim.
if !strings.Contains(r.stderr, "dependency_exists") || !strings.Contains(r.stderr, "different type") {
t.Errorf("conflict stderr = %s, want the typed dependency_exists conflict", r.stderr)
}
list := f.mustRun(nil, "dep", "list", from, "--json").stdout
if !depListHas(t, list, to, "owned-by") || depListHas(t, list, to, "ships-in") {
t.Errorf("the conflicting link changed the edge: %s", list)
}
// Re-asserting the same edge is idempotent.
f.mustRun(nil, "link", from, to, "--type", "owned-by")
})
}
// depListHas reports whether `bd dep list --json` lists an edge to target of
// depType (any type when depType is empty).
func depListHas(t *testing.T, out, target, depType string) bool {
t.Helper()
trimmed := strings.TrimSpace(out)
if trimmed == "" || trimmed == "null" {
return false
}
var rows []map[string]any
if err := json.Unmarshal([]byte(trimmed), &rows); err != nil {
t.Fatalf("parse bd dep list --json: %v\n%s", err, out)
}
for _, row := range rows {
if row["id"] != target && row["depends_on_id"] != target {
continue
}
if depType == "" {
return true
}
if row["dependency_type"] == depType || row["type"] == depType {
return true
}
}
return false
}

View file

@ -1,254 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"slices"
"strings"
"testing"
)
// listScopeShapes are the tokened `bd list` shapes, with the token each needs
// and the titles each must answer on the scope seed. Five are corpus shapes
// (backend/http/corpus/testdata/corpus.yaml) and one pins the title fold:
// - gc-list-on-boot: gc's default on_boot hook, run on every agent boot;
// - gc-list-on-boot-workflow: the same recovery, workflow lane;
// - mc-list-title: the PR-intake formula's `--title "$SUBJECT"`;
// - gc-polecat-title-contains: the polecat pre-flight's open-bead lookup,
// `--title-contains "$SYMPTOM_KEY"`, folded onto `title`;
// - title-and-title-contains-equal (not a corpus shape): one value under
// both title flags is one `title`;
// - mc-list-id: the pr-review skill's `--id <ids>`.
var listScopeShapes = []struct {
corpusID string
args []string
token string
want []string
}{
{"gc-list-on-boot",
[]string{"list", "--metadata-field", "gc.routed_to=pool-a", "--status=in_progress", "--no-assignee", "--json"},
"issues.list.noAssignee", []string{"orphan-ip"}},
{"gc-list-on-boot-workflow",
[]string{"list", "--metadata-field", "gc.run_target=pool-a", "--metadata-field", "gc.kind=workflow", "--status=in_progress", "--no-assignee", "--json"},
"issues.list.noAssignee", []string{"orphan-wf"}},
// Case-insensitive substring, every status.
{"mc-list-title",
[]string{"list", "--all", "--include-infra", "--json", "--limit", "10", "--title", "CHILD-A"},
"issues.list.title", []string{"child-a"}},
// --title-contains folds onto the same `title` parameter: case-insensitive
// substring, and the status set leaves the closed child-c out.
{"gc-polecat-title-contains",
[]string{"list", "--title-contains", "CHILD", "--status", "open,in_progress,blocked", "--json"},
"issues.list.title", []string{"child-a", "child-b", "child-x"}},
// The same value under both flags is one predicate.
{"title-and-title-contains-equal",
[]string{"list", "--all", "--title", "child-a", "--title-contains", "child-a", "--json"},
"issues.list.title", []string{"child-a"}},
// A closed id in the set is listed under --all; ids outside it are not.
{"mc-list-id",
[]string{"list", "--all", "--id", "{child-c},{loner}", "--json", "--limit", "0"},
"issues.list.ids", []string{"child-c", "loner"}},
}
// seedListScope adds the on_boot recovery rows to the shared seed: one
// unassigned in-progress row per lane, and an ASSIGNED in-progress row on the
// routed lane, which --no-assignee must leave out.
func (f *remoteRolesFixture) seedListScope() {
f.t.Helper()
ip := f.create("orphan-ip", "-t", "task")
f.mustRun(nil, "update", ip, "-s", "in_progress", "--set-metadata", "gc.routed_to=pool-a")
wf := f.create("orphan-wf", "-t", "task")
f.mustRun(nil, "update", wf, "-s", "in_progress", "--set-metadata", "gc.run_target=pool-a", "--set-metadata", "gc.kind=workflow")
owned := f.create("owned-ip", "-t", "task", "-a", "worker")
f.mustRun(nil, "update", owned, "-s", "in_progress", "--set-metadata", "gc.routed_to=pool-a", "--set-metadata", "gc.run_target=pool-a", "--set-metadata", "gc.kind=workflow")
}
// TestE2E_ListScopeFiltersOverHTTP is S15b. `bd list --no-assignee`, `--title`
// and `--id` refused over http (the list encoder had no parameter for them);
// they now ride listIssues' `no_assignee`, `title` and `id`, each behind its
// own behavior token, and the server applies them through the same Reader
// role a local `bd list` reads through. Each corpus shape must answer the
// rows an embedded workspace answers, and exactly the rows it names.
//
// Against a server that lacks a token (the MC production server's handshake
// shape, which predates all three) each shape refuses BEFORE dialing
// listIssues, naming the token, rather than answering a wider listing.
func TestE2E_ListScopeFiltersOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
remote := newHTTPFixture(t, bin, addr)
local := newEmbeddedFixture(t, bin)
for _, f := range []*remoteRolesFixture{remote, local} {
f.seed()
f.seedListScope()
}
for _, shape := range listScopeShapes {
t.Run(shape.corpusID, func(t *testing.T) {
r := remote.run(nil, remote.expand(shape.args)...)
if r.code != 0 {
t.Fatalf("http: bd %s failed (exit %d): stderr=%s", strings.Join(shape.args, " "), r.code, r.stderr)
}
l := local.mustRun(nil, local.expand(shape.args)...)
got, want := remote.titlesOf(r.stdout), local.titlesOf(l.stdout)
if !slices.Equal(got, want) {
t.Errorf("http rows %v, embedded rows %v", got, want)
}
if !slices.Equal(got, shape.want) {
t.Errorf("http rows %v, want exactly %v", got, shape.want)
}
})
}
t.Run("MC server mask refuses before dialing", func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
f.ids = remote.ids // same workspace behind the proxy
for _, shape := range listScopeShapes {
counter.reset()
r := f.run(nil, f.expand(shape.args)...)
if r.code == 0 {
t.Errorf("%s: bd %s exited 0 against a server lacking %s: %s", shape.corpusID, strings.Join(shape.args, " "), shape.token, r.stdout)
continue
}
if !strings.Contains(r.stderr, shape.token) {
t.Errorf("%s: the refusal does not name %s: stderr=%s", shape.corpusID, shape.token, r.stderr)
}
for _, p := range counter.snapshot() {
if p == "GET /v0/beads/issues" {
t.Errorf("%s: dialed listIssues against a server lacking %s: %v", shape.corpusID, shape.token, counter.snapshot())
break
}
}
}
})
}
// listFilterShapes are the `bd list` shapes that ride the listing filters
// behind issues.list.filters, each with the titles it must answer on the seed
// plus seedListFilters. Five are corpus shapes and one pins the title pair the
// fold leaves:
// - wf-session-cleanup: the session-cleanup sweep's closed-and-stale scan;
// - gc-polecat-closed-after: the polecat formula's "has the fix landed"
// check (title substring, closed after a cutoff);
// - list-filter-priority-range, list-filter-exclude-type-no-parent and
// list-filter-updated-after: one representative per remaining family;
// - title-and-title-contains-differ (not a corpus shape): a `--title` and a
// `--title-contains` that differ ride `title` and `title_contains`
// together, and the server applies both.
var listFilterShapes = []struct {
corpusID string
args []string
want []string
}{
{"wf-session-cleanup",
[]string{"list", "--json", "--all", "--include-infra", "--include-gates", "--status", "closed", "--label", "lane:a",
"--closed-before", "2100-01-01T00:00:00Z", "--updated-before", "2100-01-01T00:00:00Z", "--limit", "0"},
[]string{"lane task closed"}},
{"gc-polecat-closed-after",
[]string{"list", "--title-contains", "task", "--status", "closed", "--closed-after", "2000-01-01", "--json"},
[]string{"lane task closed", "other lane task closed"}},
{"list-filter-priority-range",
[]string{"list", "--json", "--priority-min", "1", "--priority-max", "3", "--limit", "0"},
[]string{"child-a", "child-b", "loner", "open task p2", "parent", "tmpl"}},
{"list-filter-exclude-type-no-parent",
[]string{"list", "--json", "--exclude-type", "epic", "--no-parent", "--limit", "0"},
[]string{"loner", "open task p2", "p4 row", "tmpl"}},
{"list-filter-updated-after",
[]string{"list", "--json", "--updated-after", "2000-01-01", "--limit", "0"},
[]string{"child-a", "child-b", "child-x", "loner", "open task p2", "p4 row", "parent", "tmpl"}},
// Either substring alone answers more: "child" every child, "a" the
// lane tasks, parent and open task p2 too.
{"title-and-title-contains-differ",
[]string{"list", "--all", "--title", "child", "--title-contains", "a", "--json"},
[]string{"child-a"}},
}
// seedListFilters adds the rows the filter shapes split: two closed tasks on
// different lanes (the label keeps one out of the session-cleanup scan, the
// title substring keeps child-c out of the polecat check), a P4 row the
// priority range leaves out, and an open P2 task beside it.
func (f *remoteRolesFixture) seedListFilters() {
f.t.Helper()
a := f.create("lane task closed", "-t", "task", "-l", "lane:a")
b := f.create("other lane task closed", "-t", "task", "-l", "lane:b")
f.mustRun(nil, "close", a, "--reason", "done")
f.mustRun(nil, "close", b, "--reason", "done")
f.create("p4 row", "-t", "task", "-p", "4")
f.create("open task p2", "-t", "task", "-p", "2")
}
// withoutListFilters rewrites the handshake into a server that is current in
// every respect but one: it does not advertise issues.list.filters.
func withoutListFilters(body map[string]any) {
caps, _ := body["capabilities"].([]any)
kept := make([]any, 0, len(caps))
for _, c := range caps {
if c != "issues.list.filters" {
kept = append(kept, c)
}
}
body["capabilities"] = kept
}
// TestE2E_ListFilterParityOverHTTP: `bd list`'s time bounds and every other
// filter the listing refused over http now ride listIssues behind the one
// behavior token issues.list.filters, applied by the same Reader role a local
// `bd list` reads through. Each shape must answer the rows an embedded
// workspace answers, and exactly the rows it names.
//
// Against a server that does not advertise the token each shape refuses
// BEFORE dialing listIssues, naming the token, rather than answering a wider
// listing.
func TestE2E_ListFilterParityOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
remote := newHTTPFixture(t, bin, addr)
local := newEmbeddedFixture(t, bin)
for _, f := range []*remoteRolesFixture{remote, local} {
f.seed()
f.seedListFilters()
}
for _, shape := range listFilterShapes {
t.Run(shape.corpusID, func(t *testing.T) {
r := remote.run(nil, shape.args...)
if r.code != 0 {
t.Fatalf("http: bd %s failed (exit %d): stderr=%s", strings.Join(shape.args, " "), r.code, r.stderr)
}
l := local.mustRun(nil, shape.args...)
got, want := remote.titlesOf(r.stdout), local.titlesOf(l.stdout)
if !slices.Equal(got, want) {
t.Errorf("http rows %v, embedded rows %v", got, want)
}
if !slices.Equal(got, shape.want) {
t.Errorf("http rows %v, want exactly %v", got, shape.want)
}
})
}
t.Run("a server without issues.list.filters refuses before dialing", func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, withoutListFilters)
f := newHTTPFixture(t, bin, proxyAddr)
f.ids = remote.ids // same workspace behind the proxy
for _, shape := range listFilterShapes {
counter.reset()
r := f.run(nil, shape.args...)
if r.code == 0 {
t.Errorf("%s: bd %s exited 0 against a server lacking issues.list.filters: %s", shape.corpusID, strings.Join(shape.args, " "), r.stdout)
continue
}
if !strings.Contains(r.stderr+r.stdout, "issues.list.filters") {
t.Errorf("%s: the refusal does not name issues.list.filters: stdout=%s stderr=%s", shape.corpusID, r.stdout, r.stderr)
}
for _, p := range counter.snapshot() {
if p == "GET /v0/beads/issues" {
t.Errorf("%s: dialed listIssues against a server lacking issues.list.filters: %v", shape.corpusID, counter.snapshot())
break
}
}
}
})
}

View file

@ -1,221 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"net"
"net/http"
"net/http/httputil"
"net/url"
"os"
"path/filepath"
"slices"
"strings"
"sync"
"testing"
)
// recordedRequest is one request the query-recording proxy forwarded.
type recordedRequest struct {
method, path string
query url.Values
}
func (r recordedRequest) String() string {
if len(r.query) == 0 {
return r.method + " " + r.path
}
return r.method + " " + r.path + "?" + r.query.Encode()
}
// queryRecorder keeps each request's decoded query beside its method and path,
// so a case can assert WHICH ids a read named rather than only how many reads a
// command made. requestCounter records paths alone, which cannot tell a read of
// the listed ids from a read of every id in the workspace.
type queryRecorder struct {
mu sync.Mutex
reqs []recordedRequest
}
func (q *queryRecorder) reset() {
q.mu.Lock()
defer q.mu.Unlock()
q.reqs = nil
}
func (q *queryRecorder) snapshot() []recordedRequest {
q.mu.Lock()
defer q.mu.Unlock()
return append([]recordedRequest(nil), q.reqs...)
}
// startQueryRecordingProxy is startCountingProxy that also records each
// request's query.
func startQueryRecordingProxy(t *testing.T, upstream string) (string, *queryRecorder) {
t.Helper()
target, err := url.Parse("http://" + upstream)
if err != nil {
t.Fatal(err)
}
rec := &queryRecorder{}
proxy := httputil.NewSingleHostReverseProxy(target)
ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatal(err)
}
srv := &http.Server{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
rec.mu.Lock()
rec.reqs = append(rec.reqs, recordedRequest{method: r.Method, path: r.URL.Path, query: r.URL.Query()})
rec.mu.Unlock()
proxy.ServeHTTP(w, r)
})}
go func() { _ = srv.Serve(ln) }()
t.Cleanup(func() { _ = srv.Close() })
return ln.Addr().String(), rec
}
// TestE2E_ListTextRenderingsReadOnlyTheListedIssuesEdges pins the dependency
// read behind `bd list`'s text renderings over http — the default tree, --deps,
// a page cut by --limit, the --parent tree and --format — to ONE anchored
// listDependencies request naming exactly the listed issues.
//
// It used to be GetAllDependencyRecords, which over http enumerates every issue
// id in the workspace (all=true, 200 per page) and then reads every id's edges
// in chunks of 100: O(workspace/100) sequential requests for a 20-row page,
// 62 requests and ~6 s against a ~3.8k-issue workspace at ~50 ms a round trip.
// Every rendering reads only edges OWNED by a listed issue, so the listed ids
// are the whole question. The fixture makes the difference visible on a small
// workspace: a closed issue the default listing hides owns a parent-child edge
// onto the listed parent and a blocks edge onto a listed issue, and a read of
// the whole workspace would name it as an anchor.
//
// The ids are not dotted, so the nesting the tree prints can only have come
// from the parent-child edges this read returned: if the read failed, the tree
// would fall back to dotted-id nesting and print every issue as a root.
func TestE2E_ListTextRenderingsReadOnlyTheListedIssuesEdges(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
proxyAddr, rec := startQueryRecordingProxy(t, startE2EServer(t))
f := newHTTPFixture(t, bin, proxyAddr)
// One graph apply seeds the whole fixture, so setup costs two subprocesses
// rather than one per issue and edge. An edge reads "from depends on to".
plan := filepath.Join(t.TempDir(), "plan.json")
if err := os.WriteFile(plan, []byte(`{
"nodes": [
{"key": "parent", "title": "tree parent", "type": "epic", "priority": 0},
{"key": "a", "title": "tree child a", "type": "task", "priority": 1},
{"key": "b", "title": "tree child b", "type": "task", "priority": 2},
{"key": "loner", "title": "tree loner", "type": "task", "priority": 3},
{"key": "hidden", "title": "tree hidden", "type": "task", "priority": 1}
],
"edges": [
{"from_key": "a", "to_key": "parent", "type": "parent-child"},
{"from_key": "b", "to_key": "parent", "type": "parent-child"},
{"from_key": "b", "to_key": "a", "type": "blocks"},
{"from_key": "loner", "to_key": "a", "type": "related"},
{"from_key": "hidden", "to_key": "parent", "type": "parent-child"},
{"from_key": "hidden", "to_key": "loner", "type": "blocks"}
]
}`), 0o600); err != nil {
t.Fatal(err)
}
var applied struct {
IDs map[string]string `json:"ids"`
}
if out := f.mustRun(nil, "create", "--graph", plan, "--json").stdout; json.Unmarshal([]byte(out), &applied) != nil || len(applied.IDs) != 5 {
t.Fatalf("bd create --graph --json did not report the five ids: %s", out)
}
parent, childA, childB := applied.IDs["parent"], applied.IDs["a"], applied.IDs["b"]
loner, hidden := applied.IDs["loner"], applied.IDs["hidden"]
// Closed separately: the batch create cannot carry a closed row's
// closed_at over the wire. --force because hidden is blocked by loner.
f.mustRun(nil, "close", hidden, "--reason", "done", "--force")
// Through the subtest's own t: f.mustRun fails the PARENT test, which a
// subtest may not do.
run := func(t *testing.T, args ...string) string {
t.Helper()
r := runBD(t, f.bin, f.dir, nil, args...)
if r.code != 0 {
t.Fatalf("bd %s failed (exit %d): stdout=%s stderr=%s", strings.Join(args, " "), r.code, r.stdout, r.stderr)
}
return r.stdout
}
// The --json listing is the budget's base: a text rendering of a page may
// cost that page plus its ONE edge read. Its count does not depend on the
// page size below the 200-row page, so one measurement serves every page.
rec.reset()
run(t, "list", "--json")
base := len(rec.snapshot())
listed := []string{parent, childA, childB, loner}
for _, tc := range []struct {
name string
args []string
anchors []string
// page marks a rendering of the listing's page, held to the --json
// budget; the --parent tree is a walk, not a page.
page bool
want []string
}{
{
name: "tree", args: []string{"list"}, anchors: listed, page: true,
want: []string{"├── ○ " + childA, "└── ○ " + childB},
},
{
name: "deps all", args: []string{"list", "--deps=all"}, anchors: listed, page: true,
want: []string{"[depends-on]", "[related]"},
},
{
name: "truncated page", args: []string{"list", "--limit", "2"}, anchors: []string{parent, childA}, page: true,
want: []string{"└── ○ " + childA},
},
{
name: "parent tree", args: []string{"list", "--parent", parent}, anchors: []string{parent, childA, childB},
want: []string{"├── ○ " + childA, "└── ○ " + childB},
},
{
name: "format digraph", args: []string{"list", "--format", "digraph"}, anchors: listed, page: true,
want: []string{childA + " " + parent, childB + " " + parent, childB + " " + childA, loner + " " + childA},
},
} {
t.Run(tc.name, func(t *testing.T) {
rec.reset()
out := run(t, tc.args...)
reqs := rec.snapshot()
t.Logf("bd %s: %d requests: %v", strings.Join(tc.args, " "), len(reqs), reqs)
var edgeReads []recordedRequest
for _, r := range reqs {
if r.path == "/v0/beads/dependencies" {
edgeReads = append(edgeReads, r)
}
}
if len(edgeReads) != 1 {
t.Fatalf("bd %s made %d listDependencies requests, want exactly 1 (the listed issues' edges): %v",
strings.Join(tc.args, " "), len(edgeReads), edgeReads)
}
got := slices.Sorted(slices.Values(edgeReads[0].query["issue_id"]))
want := slices.Sorted(slices.Values(tc.anchors))
if !slices.Equal(got, want) {
t.Errorf("bd %s read the edges of %v, want exactly the listed issues %v",
strings.Join(tc.args, " "), got, want)
}
if tc.page && len(reqs) > base+1 {
t.Errorf("bd %s made %d requests; bd list --json makes %d, and the text rendering may add only its one edge read",
strings.Join(tc.args, " "), len(reqs), base)
}
for _, w := range tc.want {
if !strings.Contains(out, w) {
t.Errorf("bd %s output lacks %q:\n%s", strings.Join(tc.args, " "), w, out)
}
}
if strings.Contains(out, hidden) {
t.Errorf("bd %s printed the closed issue %s, which the default listing hides:\n%s",
strings.Join(tc.args, " "), hidden, out)
}
})
}
}

View file

@ -1,305 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"strings"
"testing"
)
// TestE2E_MoleculesOverHTTP drives the molecule workflow a gc worker runs —
// `bd create --parent`, `bd mol current`, `bd mol progress`, `bd ready --mol`,
// `bd close --continue` and the molecule auto-close after the last step —
// through the real `bd` binary against an in-process `bd serve` (slices S16
// and S19).
//
// Every one of these used to fail or, worse, answer silently over http. Each
// now has one library entry the server runs: the create role mints the child
// id, the molecule view (issueops.ViewMolecule) answers the reads, the
// close runs the auto-close in its own transaction (auto_close_molecule), and
// `close --continue` is the advanceMolecule operation, whose claim sets the
// assignee and never takes a step someone else holds.
func TestE2E_MoleculesOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
workspace := t.TempDir()
bd := func(args ...string) bdResult {
t.Helper()
return runBD(t, bin, workspace, nil, append([]string{"--actor", "alice"}, args...)...)
}
mustBD := func(args ...string) bdResult {
t.Helper()
r := bd(args...)
if r.code != 0 {
t.Fatalf("bd %s failed (exit %d): stdout=%s stderr=%s", strings.Join(args, " "), r.code, r.stdout, r.stderr)
}
return r
}
status := func(id string) string {
t.Helper()
return firstJSONField(t, mustBD("show", id, "--json").stdout, "status")
}
mustBD("connect", "http://"+addr, "--expect-project-id", e2eProjectID, "--json")
root := firstJSONField(t, mustBD("create", "Patrol molecule", "-t", "molecule", "--json").stdout, "id")
if root == "" {
t.Fatal("bd create (molecule root) produced no id")
}
// S19: the server mints <parent>.<n>; the client no longer asks a raw
// GetNextChildID the http backend does not serve.
step1 := firstJSONField(t, mustBD("create", "Step one", "--parent", root, "--json").stdout, "id")
step2 := firstJSONField(t, mustBD("create", "Step two", "--parent", root, "--json").stdout, "id")
step3 := firstJSONField(t, mustBD("create", "Step three", "--parent", root, "--json").stdout, "id")
if step1 != root+".1" || step2 != root+".2" || step3 != root+".3" {
t.Fatalf("create --parent minted %q, %q and %q, want %q, %q and %q", step1, step2, step3, root+".1", root+".2", root+".3")
}
// An explicit --id beside --parent is still refused locally, before any mint.
if r := bd("create", "Both", "--parent", root, "--id", root+".9", "--json"); r.code == 0 {
t.Errorf("create --parent --id succeeded; want the existing refusal: %s", r.stdout)
}
mustBD("dep", "add", step2, step1, "--json")
mustBD("dep", "add", step3, step1, "--json")
mustBD("update", step1, "-s", "in_progress", "-a", "alice", "--json")
// Someone else holds step two: the advance must skip it, not take it.
mustBD("update", step2, "-a", "bob", "--json")
// S16: mol current with an id is a non-empty answer whose current step is
// the in-progress one.
current := decodeMolecules(t, mustBD("mol", "current", root, "--json").stdout)
if len(current) != 1 || current[0].MoleculeID != root {
t.Fatalf("mol current %s = %+v, want the one molecule %s", root, current, root)
}
if current[0].CurrentStep == nil || current[0].CurrentStep.ID != step1 || current[0].Total != 3 {
t.Fatalf("mol current %s current=%v total=%d, want current %s of 3", root, current[0].CurrentStep, current[0].Total, step1)
}
// The step is the FULL row: the raw dependents read over http is getIssue's
// shallow projection, which zeroes the assignee a worker prompt reads.
if got := current[0].CurrentStep.Assignee; got != "alice" {
t.Errorf("mol current %s current step assignee = %q, want alice (full step row)", root, got)
}
progress := mustBD("mol", "progress", root, "--json").stdout
if n := jsonIntField(t, progress, "total"); n != 3 {
t.Errorf("mol progress total = %d, want 3: %s", n, progress)
}
if id := firstJSONField(t, progress, "current_step_id"); id != step1 {
t.Errorf("mol progress current_step_id = %q, want %q: %s", id, step1, progress)
}
// mol show reads through the same library entry (issueops.LoadMolecule).
var shown struct {
Root struct{ ID string } `json:"root"`
Issues []struct {
ID string `json:"id"`
Assignee string `json:"assignee"`
} `json:"issues"`
}
showOut := mustBD("mol", "show", root, "--json").stdout
if err := json.Unmarshal([]byte(strings.TrimSpace(showOut)), &shown); err != nil {
t.Fatalf("parse mol show: %v\n%s", err, showOut)
}
if shown.Root.ID != root || len(shown.Issues) != 4 {
t.Errorf("mol show %s = root %q with %d issues, want %s and 4 (root + 3 steps): %s", root, shown.Root.ID, len(shown.Issues), root, showOut)
}
t.Run("mol current without an id", func(t *testing.T) {
r := bd("mol", "current", "--json")
// Whatever the backend can do, it must not answer an EMPTY list for an
// agent with a molecule in progress: that was the swallowed refusal.
if r.code == 0 && len(decodeMolecules(t, r.stdout)) == 0 {
t.Fatalf("mol current (no id) answered an empty list while %s is in progress: stderr=%s", step1, r.stderr)
}
if r.code != 0 {
t.Fatalf("mol current (no id) failed (exit %d): %s stdout=%s", r.code, r.stderr, r.stdout)
}
got := decodeMolecules(t, r.stdout)
if len(got) != 1 || got[0].MoleculeID != root {
t.Errorf("mol current (no id) = %+v, want molecule %s", got, root)
}
})
// ready --mol: the step rows are the full rows (the corpus mark
// mc-ready-mol was the shallow projection dropping the assignee).
var ready struct {
Steps []struct {
Issue struct {
ID string `json:"id"`
Assignee string `json:"assignee"`
} `json:"issue"`
} `json:"steps"`
}
readyOut := mustBD("ready", "--mol", root, "--json").stdout
if err := json.Unmarshal([]byte(strings.TrimSpace(readyOut)), &ready); err != nil {
t.Fatalf("parse ready --mol: %v\n%s", err, readyOut)
}
sawStep1 := false
for _, step := range ready.Steps {
if step.Issue.ID == step1 {
sawStep1 = true
if step.Issue.Assignee != "alice" {
t.Errorf("ready --mol %s step %s assignee = %q, want alice (full step row)", root, step1, step.Issue.Assignee)
}
}
}
if !sawStep1 {
t.Errorf("ready --mol %s did not list the in-progress step %s: %s", root, step1, readyOut)
}
// close --continue: step two is first in line but bob holds it, so the
// advance claims step three for alice — a real claim, assignee set.
cont := mustBD("close", step1, "--continue", "--json")
var contBody struct {
Continue struct {
NextStep *struct{ ID string } `json:"next_step"`
AutoAdvanced bool `json:"auto_advanced"`
MoleculeID string `json:"molecule_id"`
} `json:"continue"`
}
if err := json.Unmarshal([]byte(strings.TrimSpace(cont.stdout)), &contBody); err != nil {
t.Fatalf("parse close --continue output: %v\n%s", err, cont.stdout)
}
if !contBody.Continue.AutoAdvanced || contBody.Continue.NextStep == nil || contBody.Continue.NextStep.ID != step3 ||
contBody.Continue.MoleculeID != root {
t.Errorf("close --continue = %s, want auto-advance to %s in %s (skipping %s, held by bob)", cont.stdout, step3, root, step2)
}
if got := status(step3); got != "in_progress" {
t.Errorf("%s status after close --continue = %q, want in_progress", step3, got)
}
if got := firstJSONField(t, mustBD("show", step3, "--json").stdout, "assignee"); got != "alice" {
t.Errorf("%s assignee after close --continue = %q, want alice (a claim, not a status flip)", step3, got)
}
if got := firstJSONField(t, mustBD("show", step2, "--json").stdout, "assignee"); got != "bob" || status(step2) != "open" {
t.Errorf("%s after close --continue = %s/%q, want open and still bob's", step2, status(step2), got)
}
if got := status(root); got == "closed" {
t.Fatalf("molecule %s closed with %s still open", root, step2)
}
// Closing the last steps auto-closes the molecule root.
mustBD("close", step3)
if got := status(root); got == "closed" {
t.Fatalf("molecule %s closed with %s still open", root, step2)
}
last := mustBD("close", step2, "--force")
if strings.Contains(last.stderr, "could not") {
t.Errorf("close %s warned: %s", step2, last.stderr)
}
if got := status(root); got != "closed" {
t.Errorf("molecule %s status after its last step closed = %q, want closed (auto-close): stdout=%s stderr=%s",
root, got, last.stdout, last.stderr)
}
}
type e2eMolecule struct {
MoleculeID string `json:"molecule_id"`
Total int `json:"total"`
CurrentStep *struct {
ID string `json:"id"`
Assignee string `json:"assignee"`
} `json:"current_step"`
}
func decodeMolecules(t *testing.T, out string) []e2eMolecule {
t.Helper()
var got []e2eMolecule
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &got); err != nil {
t.Fatalf("parse mol current output: %v\n%s", err, out)
}
return got
}
// TestE2E_MoleculeCloseAgainstAnOlderServer is `bd close` on a molecule step
// against a server that advertises neither issues.close.autoCloseMolecule nor
// issues.advanceMolecule (an older bd serve, or one whose orchestrator owns
// the molecule lifecycle). Neither gap may be silent:
//
// - close --continue refuses BEFORE closing, so the step is not left closed
// with the next step unclaimed;
// - a plain close goes out without the auto-close request and names the
// molecule it did not auto-close on stderr.
func TestE2E_MoleculeCloseAgainstAnOlderServer(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr, _ := startMaskingProxy(t, startE2EServer(t), func(body map[string]any) {
caps, _ := body["capabilities"].([]any)
kept := caps[:0]
for _, c := range caps {
if c != "issues.close.autoCloseMolecule" && c != "issues.advanceMolecule" {
kept = append(kept, c)
}
}
body["capabilities"] = kept
})
workspace := t.TempDir()
bd := func(args ...string) bdResult {
t.Helper()
return runBD(t, bin, workspace, nil, append([]string{"--actor", "alice"}, args...)...)
}
mustBD := func(args ...string) bdResult {
t.Helper()
r := bd(args...)
if r.code != 0 {
t.Fatalf("bd %s failed (exit %d): stdout=%s stderr=%s", strings.Join(args, " "), r.code, r.stdout, r.stderr)
}
return r
}
status := func(id string) string {
t.Helper()
return firstJSONField(t, mustBD("show", id, "--json").stdout, "status")
}
mustBD("connect", "http://"+addr, "--expect-project-id", e2eProjectID, "--json")
root := firstJSONField(t, mustBD("create", "Old-server molecule", "-t", "molecule", "--json").stdout, "id")
step := firstJSONField(t, mustBD("create", "First step", "--parent", root, "--json").stdout, "id")
last := firstJSONField(t, mustBD("create", "Last step", "--parent", root, "--json").stdout, "id")
epic := firstJSONField(t, mustBD("create", "Ordinary epic", "-t", "epic", "--json").stdout, "id")
child := firstJSONField(t, mustBD("create", "Only epic child", "--parent", epic, "--json").stdout, "id")
cont := bd("close", step, "--continue", "--json")
if cont.code == 0 {
t.Fatalf("close --continue succeeded against a server without issues.advanceMolecule: %s", cont.stdout)
}
if !strings.Contains(cont.stderr+cont.stdout, "issues.advanceMolecule") || !strings.Contains(cont.stderr+cont.stdout, "nothing was closed") {
t.Errorf("close --continue refusal does not name the missing operation: stdout=%s stderr=%s", cont.stdout, cont.stderr)
}
if got := status(step); got == "closed" {
t.Fatalf("close --continue refused but %s is closed: the refusal came after the close", step)
}
// The notice is owed only where the close left an auto-closing molecule
// complete with its root open: not for a step whose molecule still has an
// open step, and not under an ordinary epic, which never auto-closes.
for _, id := range []string{step, child} {
if r := mustBD("close", id, "--json"); strings.Contains(r.stderr, "issues.close.autoCloseMolecule") {
t.Errorf("close of %s completed no auto-closing molecule but printed the unserved auto-close notice: stderr=%s", id, r.stderr)
}
}
// The close that completes the molecule names its root, and so does an
// idempotent re-close while the root stays open.
for _, attempt := range []string{"close", "re-close"} {
r := mustBD("close", last, "--json")
if !strings.Contains(r.stderr, "completed molecule "+root) || !strings.Contains(r.stderr, "issues.close.autoCloseMolecule") {
t.Errorf("%s of %s against a server without the auto-close gave no notice naming %s: stderr=%s", attempt, last, root, r.stderr)
}
}
for _, id := range []string{step, last, child} {
if got := status(id); got != "closed" {
t.Errorf("%s status = %q, want closed", id, got)
}
}
if got := status(root); got == "closed" {
t.Errorf("molecule %s closed although the server was not asked to auto-close it", root)
}
// The root the notice names closes by hand; then nothing is owed.
mustBD("close", root, "--json")
if r := mustBD("close", last, "--json"); strings.Contains(r.stderr, "issues.close.autoCloseMolecule") {
t.Errorf("re-close of %s under the closed %s printed the unserved auto-close notice: stderr=%s", last, root, r.stderr)
}
}

View file

@ -1,115 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"strings"
"testing"
)
// TestE2E_PromoteOverHTTP runs `bd promote <wisp> --reason ...` — the shape
// MC's PR-intake formula (mol-normalized-issue-pr-v1) issues, corpus shape
// mc-promote — through the real `bd` binary against an in-process `bd serve`
// (slice S21b).
//
// The CLI runs issueops.Promote, the entry the direct route runs too: one
// updateIssue carrying `patch.persistence: persistent` (the role's plane move,
// in one server transaction) and then the promotion comment. Against a server
// that does not advertise issues.update.persistence — the MC server's
// handshake shape — the client refuses BEFORE the dial, naming the token, and
// nothing is written.
func TestE2E_PromoteOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
t.Run("advertised", func(t *testing.T) {
proxyAddr, counter := startCountingProxy(t, addr)
f := newHTTPFixture(t, bin, proxyAddr)
wisp := f.create("wisp to keep", "--ephemeral", "-l", "keep-me")
if !showJSONBool(t, f.mustRun(nil, "show", wisp, "--json").stdout, "ephemeral") {
t.Fatalf("created %s is not ephemeral; nothing to promote", wisp)
}
counter.reset()
r := f.mustRun(nil, "promote", wisp, "--reason", "keep it")
if !strings.Contains(r.stdout, "Promoted "+wisp+" to permanent bead") {
t.Errorf("bd promote output = %q, want the promotion line", r.stdout)
}
if strings.Contains(r.stderr, "Warning") {
t.Errorf("bd promote warned: %s", r.stderr)
}
patches := 0
for _, p := range counter.snapshot() {
if strings.HasPrefix(p, "PATCH /v0/beads/issues/") {
patches++
}
}
if patches != 1 {
t.Errorf("bd promote sent %d updateIssue requests, want exactly one: %v", patches, counter.snapshot())
}
show := f.mustRun(nil, "show", wisp, "--json").stdout
if showJSONBool(t, show, "ephemeral") {
t.Errorf("%s is still ephemeral after bd promote: %s", wisp, show)
}
if !strings.Contains(show, "keep-me") {
t.Errorf("%s lost its label across the promotion: %s", wisp, show)
}
comments := f.mustRun(nil, "comments", wisp, "--json").stdout
if !strings.Contains(comments, "Promoted from Level 0: keep it") {
t.Errorf("%s carries no promotion comment: %s", wisp, comments)
}
// A durable row is refused with the sentence bd promote always printed,
// and so is a second promotion of the same row.
again := f.run(nil, "promote", wisp)
if again.code == 0 || !strings.Contains(again.stderr, "is not a wisp (already persistent)") {
t.Errorf("re-promote: exit %d stderr=%s, want the not-a-wisp refusal", again.code, again.stderr)
}
missing := f.run(nil, "promote", "e2e-absent-wisp9")
if missing.code == 0 {
t.Errorf("promote of an absent id exited 0: %s", missing.stdout)
}
})
t.Run("MC server mask", func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
wisp := f.create("wisp the old server cannot promote", "--ephemeral")
counter.reset()
r := f.run(nil, "promote", wisp, "--reason", "keep it")
if r.code == 0 {
t.Fatalf("bd promote against a server without issues.update.persistence exited 0: %s", r.stdout)
}
if !strings.Contains(r.stderr, "issues.update.persistence") {
t.Errorf("refusal does not name the missing capability: %s", r.stderr)
}
for _, p := range counter.snapshot() {
if !strings.HasPrefix(p, "GET ") {
t.Errorf("a refused promote wrote %s; the refusal must come before any write", p)
}
}
if !showJSONBool(t, f.mustRun(nil, "show", wisp, "--json").stdout, "ephemeral") {
t.Errorf("%s left the wisp plane though the promote was refused", wisp)
}
})
}
// showJSONBool reads a boolean member of `bd show --json`'s first row; an
// absent member (omitempty) reads false.
func showJSONBool(t *testing.T, out, field string) bool {
t.Helper()
var generic any
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &generic); err != nil {
t.Fatalf("parse bd show --json: %v\n%s", err, out)
}
if rows, ok := generic.([]any); ok && len(rows) > 0 {
generic = rows[0]
}
row, _ := generic.(map[string]any)
b, _ := row[field].(bool)
return b
}

View file

@ -1,51 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"slices"
"strings"
"testing"
)
// TestE2E_CloseRereadsItsOwnWrite (mc-5dkzp): the per-command read memo must
// never answer a read with a row from before this command's own write. Against
// the MC server's handshake (no issues.close.autoCloseMolecule) bd close runs
// the molecule auto-close check client side after the close, and that check
// re-reads the closed row. Two halves hold it:
//
// - The wire: the re-read reaches the server after the close's write. A memo
// that survived the write answers it from the pre-close response, and no
// request is made.
// - What the user sees: a lone molecule closed by the command is its own
// root. Read fresh it is closed and nothing is said; where the check reads
// the root's status, a memoized pre-close row reads as a completed,
// still-open molecule and the close prints a false "completed molecule"
// note.
//
// A hook-payload test cannot guard this: the http write roles fire hooks from
// the write's own response, never from a re-read.
func TestE2E_CloseRereadsItsOwnWrite(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
proxyAddr, counter := startMaskingProxy(t, addr, mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
mol := f.create("lonely molecule", "-t", "molecule")
// bd close resolves and reads the row before it writes, so a memo that
// survived the write would still hold the open row.
counter.reset()
res := f.mustRun(nil, "close", mol)
uris := counter.uriSnapshot()
t.Logf("bd close: %s", strings.Join(uris, ", "))
if strings.Contains(res.stderr, "completed molecule") {
t.Fatalf("bd close re-read its own closed row from before the write and named it a completed, still-open molecule: %s", res.stderr)
}
write := slices.Index(uris, "POST /v0/beads/issues:batchClose")
if write < 0 {
t.Fatalf("bd close %s sent no batchClose: %q", mol, uris)
}
if !slices.Contains(uris[write+1:], "GET /v0/beads/issues/"+mol) {
t.Fatalf("bd close %s did not re-read the row from the server after closing it (%q): a read after the command's own write was answered from before it", mol, uris)
}
}

View file

@ -1,46 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"encoding/json"
"strings"
"testing"
)
// TestE2E_RecomputeBlockedOverHTTP is S25. On a remote backend
// `bd recompute-blocked` is a no-op that exits 0: the server maintains
// is_blocked on every write and the column lives in its database. --json still
// carries rows_corrected (gc parses it) and says the server maintains the flag.
func TestE2E_RecomputeBlockedOverHTTP(t *testing.T) {
bd := connectE2EWorkspace(t, "worker")
// A blocked edge exists, so there is state the server derived; the client
// must not claim to have repaired or refused it.
blocked := createE2EIssue(t, bd, "blocked")
blocker := createE2EIssue(t, bd, "blocker")
mustRun(t, bd, "dep", "add", blocked, blocker, "--json")
r := mustRun(t, bd, "recompute-blocked", "--json")
var body struct {
RowsCorrected *int `json:"rows_corrected"`
MaintainedBy string `json:"maintained_by"`
}
if err := json.Unmarshal([]byte(strings.TrimSpace(r.stdout)), &body); err != nil {
t.Fatalf("parse recompute-blocked --json: %v\n%s", err, r.stdout)
}
if body.RowsCorrected == nil || *body.RowsCorrected != 0 || body.MaintainedBy != "server" {
t.Fatalf("recompute-blocked --json = %s, want rows_corrected 0 and maintained_by server", r.stdout)
}
text := mustRun(t, bd, "recompute-blocked")
if !strings.Contains(text.stdout, "maintained by the bd serve backend") {
t.Errorf("recompute-blocked text does not say the server maintains the flag: %s", text.stdout)
}
// The ready set still reflects the edge: nothing was rewritten.
ready := jsonIDSet(t, mustRun(t, bd, "ready", "--json").stdout)
if ready[blocked] || !ready[blocker] {
t.Errorf("bd ready after recompute-blocked = %v, want %s ready and %s blocked", ready, blocker, blocked)
}
}

View file

@ -1,724 +0,0 @@
//go:build cgo
// Served e2e for S6b/S6c/S6d (written fresh for OSS beads). Every case drives
// the real `bd` binary over the wire and, where the answer is a listing or a
// count, against an embedded workspace seeded the same way — parity, not just
// "it exited 0".
package bdhttp_test
import (
"bytes"
"encoding/json"
"io"
"net"
"net/http"
"net/http/httputil"
"net/url"
"os"
"path/filepath"
"slices"
"sort"
"strconv"
"strings"
"sync"
"testing"
)
// remoteRolesFixture is one workspace seeded through the CLI, whichever
// backend it selects. Titles identify rows across the two workspaces, whose
// minted ids differ.
type remoteRolesFixture struct {
t *testing.T
bin string
dir string
ids map[string]string // title -> id
}
func (f *remoteRolesFixture) run(env []string, args ...string) bdResult {
f.t.Helper()
return runBD(f.t, f.bin, f.dir, env, args...)
}
func (f *remoteRolesFixture) mustRun(env []string, args ...string) bdResult {
f.t.Helper()
r := f.run(env, args...)
if r.code != 0 {
f.t.Fatalf("bd %s failed (exit %d): stdout=%s stderr=%s", strings.Join(args, " "), r.code, r.stdout, r.stderr)
}
return r
}
func (f *remoteRolesFixture) create(title string, args ...string) string {
f.t.Helper()
r := f.mustRun(nil, append([]string{"create", title, "--json"}, args...)...)
id := firstJSONField(f.t, r.stdout, "id")
if id == "" {
f.t.Fatalf("bd create %q --json produced no id: %s", title, r.stdout)
}
f.ids[title] = id
return id
}
// seed builds the same graph in either workspace:
//
// epic "parent"
// ├─ "child-a" task, label gc:a, assignee alice, in_progress, meta k=v
// ├─ "child-b" bug, label gc:b
// ├─ "child-c" task, closed
// └─ "child-x" task, blocked by external:other:cap (unresolvable project)
// "loner" task, priority 3, a comment, depends on child-b
// "tmpl" task, template
func (f *remoteRolesFixture) seed() {
f.t.Helper()
parent := f.create("parent", "-t", "epic")
a := f.create("child-a", "-t", "task", "-l", "gc:a", "-a", "alice")
b := f.create("child-b", "-t", "bug", "-l", "gc:b")
c := f.create("child-c", "-t", "task")
x := f.create("child-x", "-t", "task", "-p", "0")
loner := f.create("loner", "-t", "task", "-p", "3")
f.create("tmpl", "-t", "task")
for _, child := range []string{a, b, c, x} {
f.mustRun(nil, "dep", "add", child, parent, "--type", "parent-child")
}
f.mustRun(nil, "dep", "add", x, "external:other:cap")
f.mustRun(nil, "dep", "add", loner, b)
f.mustRun(nil, "update", a, "-s", "in_progress", "--set-metadata", "k=v")
f.mustRun(nil, "close", c, "--reason", "done")
f.mustRun(nil, "comments", "add", loner, "a comment")
f.mustRun(nil, "update", f.ids["tmpl"], "--set-metadata", "kind=template")
}
func (f *remoteRolesFixture) titlesOf(out string) []string {
f.t.Helper()
titles := f.orderedTitlesOf(out)
sort.Strings(titles)
return titles
}
// orderedTitlesOf is titlesOf in the listing's own order.
func (f *remoteRolesFixture) orderedTitlesOf(out string) []string {
f.t.Helper()
rows := jsonRows(f.t, out)
titles := make([]string, 0, len(rows))
for _, row := range rows {
if title, ok := row["title"].(string); ok {
titles = append(titles, title)
}
}
return titles
}
// jsonRows parses a listing: a bare array, or the object envelope
// (`--skip-labels` adds a meta block) whose "issues" member holds it.
func jsonRows(t *testing.T, out string) []map[string]any {
t.Helper()
trimmed := []byte(strings.TrimSpace(out))
var rows []map[string]any
if err := json.Unmarshal(trimmed, &rows); err == nil {
return rows
}
var envelope map[string]json.RawMessage
if err := json.Unmarshal(trimmed, &envelope); err != nil {
t.Fatalf("parse JSON listing: %v\n%s", err, out)
}
for _, key := range []string{"issues", "data", "items"} {
if raw, ok := envelope[key]; ok {
if err := json.Unmarshal(raw, &rows); err != nil {
t.Fatalf("parse JSON listing member %q: %v\n%s", key, err, out)
}
return rows
}
}
t.Fatalf("JSON listing has no row array: %s", out)
return nil
}
// expand replaces {title} placeholders with this workspace's id for that title.
func (f *remoteRolesFixture) expand(args []string) []string {
out := make([]string, len(args))
for i, arg := range args {
for title, id := range f.ids {
arg = strings.ReplaceAll(arg, "{"+title+"}", id)
}
out[i] = arg
}
return out
}
func newEmbeddedFixture(t *testing.T, bin string) *remoteRolesFixture {
t.Helper()
f := &remoteRolesFixture{t: t, bin: bin, dir: t.TempDir(), ids: map[string]string{}}
f.mustRun(nil, "init", "--prefix", "e2e", "--quiet")
return f
}
func newHTTPFixture(t *testing.T, bin, addr string) *remoteRolesFixture {
t.Helper()
f := &remoteRolesFixture{t: t, bin: bin, dir: t.TempDir(), ids: map[string]string{}}
f.mustRun(nil, "connect", "http://"+addr, "--expect-project-id", e2eProjectID, "--json")
return f
}
// requestCounter is a loopback reverse proxy in front of the in-process
// server that counts the requests a command makes, by path. uris records the
// same requests with their query, for a test that tells a bare read from one
// that asks for more of the row.
type requestCounter struct {
mu sync.Mutex
paths []string
uris []string
}
func (c *requestCounter) reset() {
c.mu.Lock()
defer c.mu.Unlock()
c.paths = nil
c.uris = nil
}
func (c *requestCounter) snapshot() []string {
c.mu.Lock()
defer c.mu.Unlock()
return append([]string(nil), c.paths...)
}
// uriSnapshot is snapshot with each request's query: "GET /path?query".
func (c *requestCounter) uriSnapshot() []string {
c.mu.Lock()
defer c.mu.Unlock()
return append([]string(nil), c.uris...)
}
func startCountingProxy(t *testing.T, upstream string) (string, *requestCounter) {
t.Helper()
return startMaskingProxy(t, upstream, nil)
}
// mcServerCapabilities is the capability list the MC production server
// (bd-enterprise 5464806e97) advertises, read off its handshake on
// 2026-10-09 (mc-http-switch DESIGN.md A3). It notably includes
// policy.external_dependencies and lacks every newer token.
var mcServerCapabilities = []string{
"config.get", "config.list", "config.set", "config.unset",
"dependencies.add", "dependencies.blocking", "dependencies.count", "dependencies.cycles",
"dependencies.list", "dependencies.remove", "dependencies.tree",
"events.list", "events.watch",
"issues.addComment", "issues.batchApply", "issues.batchClose", "issues.batchCreate",
"issues.casMetadata", "issues.claim", "issues.claimNext", "issues.close", "issues.count",
"issues.create", "issues.delete", "issues.get", "issues.list", "issues.list.sort",
"issues.query", "issues.related", "issues.release", "issues.reopen", "issues.sweep", "issues.update",
"memories.forget", "memories.get", "memories.list", "memories.remember",
"policy.external_dependencies", "project.enforce", "ready.count", "ready.list", "stats.get",
}
// mcContextMask rewrites the handshake into the MC server's shape: no
// wire_revision member and exactly its capability list.
func mcContextMask(body map[string]any) {
delete(body, "wire_revision")
caps := make([]any, len(mcServerCapabilities))
for i, c := range mcServerCapabilities {
caps[i] = c
}
body["capabilities"] = caps
}
// startMaskingProxy is startCountingProxy that also rewrites every handshake
// (GET /v0/beads/context) body through mask, when one is given.
func startMaskingProxy(t *testing.T, upstream string, mask func(map[string]any)) (string, *requestCounter) {
t.Helper()
target, err := url.Parse("http://" + upstream)
if err != nil {
t.Fatal(err)
}
counter := &requestCounter{}
proxy := httputil.NewSingleHostReverseProxy(target)
if mask != nil {
proxy.ModifyResponse = func(resp *http.Response) error {
if resp.Request.URL.Path != "/v0/beads/context" || resp.StatusCode != http.StatusOK {
return nil
}
raw, err := io.ReadAll(resp.Body)
_ = resp.Body.Close()
if err != nil {
return err
}
var body map[string]any
if err := json.Unmarshal(raw, &body); err != nil {
return err
}
mask(body)
if raw, err = json.Marshal(body); err != nil {
return err
}
resp.Body = io.NopCloser(bytes.NewReader(raw))
resp.ContentLength = int64(len(raw))
resp.Header.Set("Content-Length", strconv.Itoa(len(raw)))
return nil
}
}
ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatal(err)
}
srv := &http.Server{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
counter.mu.Lock()
counter.paths = append(counter.paths, r.Method+" "+r.URL.Path)
counter.uris = append(counter.uris, r.Method+" "+r.URL.RequestURI())
counter.mu.Unlock()
proxy.ServeHTTP(w, r)
})}
go func() { _ = srv.Serve(ln) }()
t.Cleanup(func() { _ = srv.Close() })
return ln.Addr().String(), counter
}
// TestE2E_ListWithGCFiltersMatchesEmbedded is S6c's list case: `bd list` used
// to refuse over http (the external-deps decorator rebuilt the reader from the
// stubbed SearchIssuesWithCounts). Every list shape gc's BdStore emits, plus
// `bd children`, must answer the same rows as an embedded workspace.
func TestE2E_ListWithGCFiltersMatchesEmbedded(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
remote := newHTTPFixture(t, bin, startE2EServer(t))
local := newEmbeddedFixture(t, bin)
remote.seed()
local.seed()
base := []string{"list", "--json", "--include-infra", "--include-gates"}
shapes := [][]string{
append(append([]string{}, base...), "--limit", "50"),
append(append([]string{}, base...), "--limit", "0"),
append(append([]string{}, base...), "--limit", "50", "--all"),
append(append([]string{}, base...), "--limit", "50", "--label=gc:a"),
append(append([]string{}, base...), "--limit", "50", "--assignee=alice"),
append(append([]string{}, base...), "--limit", "50", "--status=in_progress"),
append(append([]string{}, base...), "--limit", "50", "--status=closed", "--all"),
append(append([]string{}, base...), "--limit", "50", "--type=bug"),
append(append([]string{}, base...), "--limit", "50", "--parent", "{parent}"),
append(append([]string{}, base...), "--limit", "50", "--parent", "{parent}", "--all"),
append(append([]string{}, base...), "--limit", "50", "--metadata-field", "k=v"),
append(append([]string{}, base...), "--limit", "50", "--metadata-field", "k=v", "--status=in_progress", "--assignee=alice", "--label=gc:a", "--type=task", "--parent", "{parent}"),
append(append([]string{}, base...), "--limit", "50", "--include-templates"),
append(append([]string{}, base...), "--limit", "50", "--skip-labels"),
append(append([]string{}, base...), "--limit", "50", "--created-before", "2999-01-01T00:00:00Z"),
{"list", "--json"},
{"children", "{parent}", "--json"},
}
for _, shape := range shapes {
name := strings.Join(shape, " ")
r := remote.run(nil, remote.expand(shape)...)
if r.code != 0 {
t.Errorf("http: bd %s failed (exit %d): stderr=%s", name, r.code, r.stderr)
continue
}
l := local.mustRun(nil, local.expand(shape)...)
got, want := remote.titlesOf(r.stdout), local.titlesOf(l.stdout)
if strings.Join(got, ",") != strings.Join(want, ",") {
t.Errorf("bd %s: http rows %v, embedded rows %v", name, got, want)
}
}
// A limit that cuts the listing. The seed holds four P2 rows, so --limit 2
// cuts a priority tie whose created_at order differs between two
// workspaces seeded seconds apart: the limited rows are not compared
// across sides. Each side's rows must instead be, in order, a prefix of
// that SAME side's unlimited listing, and both sides return two rows.
limited := append(append([]string{}, base...), "--limit", "2")
unlimited := append(append([]string{}, base...), "--limit", "0")
for _, f := range []*remoteRolesFixture{remote, local} {
cut := f.orderedTitlesOf(f.mustRun(nil, limited...).stdout)
all := f.orderedTitlesOf(f.mustRun(nil, unlimited...).stdout)
if len(cut) != 2 || len(all) < 2 || !slices.Equal(cut, all[:2]) {
t.Errorf("bd %s on %s: rows %v are not the first two of its --limit 0 listing %v", strings.Join(limited, " "), f.dir, cut, all)
}
}
}
// TestE2E_ShowJSONCountsMatchEmbedded is S6c's count case: over http the
// decorator's store-backed reader hydrated `bd show --json`'s counts from
// stubbed reads and printed zeros without an error.
func TestE2E_ShowJSONCountsMatchEmbedded(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
remote := newHTTPFixture(t, bin, startE2EServer(t))
local := newEmbeddedFixture(t, bin)
remote.seed()
local.seed()
type counts struct{ deps, dependents, comments float64 }
read := func(f *remoteRolesFixture, title string) counts {
r := f.mustRun(nil, "show", f.ids[title], "--json")
var rows []map[string]any
if err := json.Unmarshal([]byte(strings.TrimSpace(r.stdout)), &rows); err != nil || len(rows) != 1 {
t.Fatalf("parse bd show --json for %s: %v\n%s", title, err, r.stdout)
}
num := func(k string) float64 { v, _ := rows[0][k].(float64); return v }
return counts{num("dependency_count"), num("dependent_count"), num("comment_count")}
}
nonZero := false
for _, title := range []string{"parent", "child-b", "child-x", "loner"} {
got, want := read(remote, title), read(local, title)
if got != want {
t.Errorf("bd show %s --json counts: http %+v, embedded %+v", title, got, want)
}
if want != (counts{}) {
nonZero = true
}
}
if !nonZero {
t.Fatal("fixture produced no non-zero count; the parity check proves nothing")
}
}
// TestE2E_DefaultDepTreeOverHTTP is S6c's tree case: the default (down) `bd
// dep tree` used to refuse (GetDependencyTree). It must render the same nodes
// as embedded, including the synthetic external leaf the client-side policy
// hangs off a node with an external dependency.
func TestE2E_DefaultDepTreeOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
remote := newHTTPFixture(t, bin, startE2EServer(t))
local := newEmbeddedFixture(t, bin)
remote.seed()
local.seed()
for _, title := range []string{"child-x", "loner"} {
r := remote.run(nil, "dep", "tree", remote.ids[title])
if r.code != 0 {
t.Fatalf("http: bd dep tree %s failed (exit %d): stderr=%s", title, r.code, r.stderr)
}
l := local.mustRun(nil, "dep", "tree", local.ids[title])
normalize := func(out string, f *remoteRolesFixture) string {
for t, id := range f.ids {
out = strings.ReplaceAll(out, id, "<"+t+">")
}
return out
}
if got, want := normalize(r.stdout, remote), normalize(l.stdout, local); got != want {
t.Errorf("bd dep tree %s:\nhttp:\n%s\nembedded:\n%s", title, got, want)
}
}
tree := remote.mustRun(nil, "dep", "tree", remote.ids["child-x"])
if !strings.Contains(tree.stdout, "cap (external)") {
t.Errorf("http dep tree of child-x lacks the external leaf: %s", tree.stdout)
}
if !strings.Contains(tree.stdout, remote.ids["parent"]) {
t.Errorf("http dep tree of child-x lacks its parent: %s", tree.stdout)
}
}
// TestE2E_ExternalDependencyBlockingStillEnforced pins that the passthrough
// kept the client-side policy against a server that does not advertise
// policy.external_dependencies: the externally blocked child-x (priority 0,
// so it sorts first) never reaches ready, a direct claim, an unforced close,
// or `bd ready --claim`; `bd list` still marks it blocked.
func TestE2E_ExternalDependencyBlockingStillEnforced(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
f := newHTTPFixture(t, bin, startE2EServer(t))
f.seed()
x := f.ids["child-x"]
ready := f.mustRun(nil, "ready", "--json")
if jsonIDSet(t, ready.stdout)[x] {
t.Errorf("bd ready listed the externally blocked %s: %s", x, ready.stdout)
}
readyOne := f.mustRun(nil, "ready", "--json", "--limit", "1")
if ids := jsonIDSet(t, readyOne.stdout); len(ids) != 1 || ids[x] {
t.Errorf("bd ready --limit 1 = %v; want exactly one row and not %s (the widened window must still fill the page)", ids, x)
}
if r := f.run(nil, "update", x, "--claim", "--json"); r.code == 0 || !strings.Contains(r.stderr, "external:other:cap") {
t.Errorf("bd update --claim of the externally blocked %s: exit %d, stderr=%s; want a refusal naming the blocker", x, r.code, r.stderr)
}
if r := f.run(nil, "close", x, "--json"); r.code == 0 || !strings.Contains(r.stderr, "external:other:cap") {
t.Errorf("bd close of the externally blocked %s: exit %d, stderr=%s; want a refusal naming the blocker", x, r.code, r.stderr)
}
if r := f.run([]string{"CLAUDE_SESSION_ID=sess-x"}, "update", x, "-s", "closed", "--json"); r.code == 0 || !strings.Contains(r.stderr, "external:other:cap") {
t.Errorf("bd update -s closed of the externally blocked %s: exit %d, stderr=%s; want a refusal naming the blocker", x, r.code, r.stderr)
}
claimed := f.mustRun(nil, "ready", "--claim", "--json")
if id := firstJSONField(t, claimed.stdout, "id"); id == "" || id == x {
t.Errorf("bd ready --claim claimed %q; want an unblocked issue, never %s: %s", id, x, claimed.stdout)
}
list := f.mustRun(nil, "list", "--json", "--limit", "50")
for _, row := range jsonRows(t, list.stdout) {
if row["id"] == x && row["status"] == "closed" {
t.Errorf("child-x was closed despite the refusals: %v", row)
}
}
if r := f.run(nil, "show", x, "--json"); r.code != 0 {
t.Fatalf("bd show %s failed: %s", x, r.stderr)
}
if r := f.mustRun(nil, "close", x, "--force", "--json"); r.code != 0 {
t.Fatalf("bd close --force %s failed: %s", x, r.stderr)
}
}
// TestE2E_CloseAndReopenUnderClaudeSession is S6d: under Claude Code every bd
// process carries CLAUDE_SESSION_ID, and over http `bd update -s closed`
// refused (closed_by_session has no wire member) while `bd reopen` always
// refused (its fixed Provenance label has none either). Both must work, the
// dropped session must be named on stderr (typed or ambient, never silent),
// and `bd close` must still record the session its wire operation does carry.
func TestE2E_CloseAndReopenUnderClaudeSession(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
f := newHTTPFixture(t, bin, startE2EServer(t))
session := []string{"CLAUDE_SESSION_ID=sess-s6d"}
id := f.create("closable", "-t", "task")
status := func() map[string]any {
r := f.mustRun(nil, "show", id, "--json")
var rows []map[string]any
if err := json.Unmarshal([]byte(strings.TrimSpace(r.stdout)), &rows); err != nil || len(rows) != 1 {
t.Fatalf("parse bd show: %v\n%s", err, r.stdout)
}
return rows[0]
}
// The MC hot shape: metadata and status in one update, session ambient.
ambient := f.mustRun(session, "update", id, "--set-metadata", "phase=done", "--status", "closed", "--json")
if !strings.Contains(ambient.stderr, "CLAUDE_SESSION_ID is not recorded") {
t.Errorf("the ambient session was dropped without a notice: stderr=%s", ambient.stderr)
}
if row := status(); row["status"] != "closed" {
t.Fatalf("after update -s closed under CLAUDE_SESSION_ID: %v", row)
}
reopen := f.mustRun(session, "reopen", id, "--json")
if !strings.Contains(reopen.stdout, id) {
t.Errorf("bd reopen --json did not report %s: %s", id, reopen.stdout)
}
if row := status(); row["status"] != "open" {
t.Fatalf("after reopen: %v", row)
}
// An explicit --session is honored too, and says it was not recorded.
explicit := f.mustRun(nil, "update", id, "-s", "closed", "--session", "typed-session", "--json")
if !strings.Contains(explicit.stderr, "--session is not recorded") {
t.Errorf("explicit --session over http gave no notice: stderr=%s", explicit.stderr)
}
if row := status(); row["status"] != "closed" {
t.Fatalf("after update -s closed --session: %v", row)
}
f.mustRun(nil, "reopen", id, "--reason", "again", "--json")
// bd close carries the session on its own wire member.
f.mustRun(session, "close", id, "--json")
row := status()
if row["status"] != "closed" || row["closed_by_session"] != "sess-s6d" {
t.Errorf("after bd close under CLAUDE_SESSION_ID: status=%v closed_by_session=%v; want closed/sess-s6d", row["status"], row["closed_by_session"])
}
f.mustRun(session, "reopen", id, "--json")
if row := status(); row["status"] != "open" {
t.Errorf("after the second reopen: %v", row)
}
}
// TestE2E_ShowMissingIDIsNotFoundInOneLookup is S6b: `bd show <missing>`
// made five round trips and then reported "SearchIssueIDs not supported". It
// must classify as not found — the same exit and stdout as embedded — after a
// single issue lookup.
func TestE2E_ShowMissingIDIsNotFoundInOneLookup(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
proxyAddr, counter := startCountingProxy(t, startE2EServer(t))
remote := newHTTPFixture(t, bin, proxyAddr)
local := newEmbeddedFixture(t, bin)
remote.create("present")
for _, missing := range []string{"e2e-nope", "nope"} {
counter.reset()
r := remote.run(nil, "show", missing, "--json")
paths := counter.snapshot()
l := local.run(nil, "show", missing, "--json")
if r.code != l.code || r.code == 0 {
t.Errorf("bd show %s: http exit %d, embedded exit %d; want the same non-zero not-found exit", missing, r.code, l.code)
}
if strings.TrimSpace(r.stdout) != strings.TrimSpace(l.stdout) {
t.Errorf("bd show %s --json stdout differs:\nhttp: %s\nembedded: %s", missing, r.stdout, l.stdout)
}
if !strings.Contains(r.stderr, "Issue "+missing+" not found") || strings.Contains(r.stderr, "not supported") {
t.Errorf("bd show %s over http is not classified as not found: stderr=%s", missing, r.stderr)
}
lookups := 0
for _, p := range paths {
if strings.HasPrefix(p, "GET /v0/beads/issues/") {
lookups++
}
}
// A prefixed id is one exact lookup and nothing else: no prefix
// vocabulary, no repeated probe, no settings read for contributor
// auto-routing (a remote workspace configures that locally). A bare
// hash also reads the prefix vocabulary once (behind the handshake
// that read's capability check) and tries its prefixed spelling.
wantLookups, maxTotal := 1, 1
if !strings.Contains(missing, "-") {
wantLookups, maxTotal = 2, 4
}
if lookups != wantLookups {
t.Errorf("bd show %s made %d issue lookups, want %d: %v", missing, lookups, wantLookups, paths)
}
if len(paths) > maxTotal {
t.Errorf("bd show %s made %d requests in all, want at most %d: %v", missing, len(paths), maxTotal, paths)
}
}
// A present id still resolves, abbreviation-free.
if r := remote.run(nil, "show", remote.ids["present"], "--json"); r.code != 0 {
t.Errorf("bd show of a present id failed over http: %s", r.stderr)
}
}
// TestE2E_PingOverHTTP: `bd ping` ran a one-row SearchIssues, which the http
// backend refuses; it now reads the authenticated server context.
func TestE2E_PingOverHTTP(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
proxyAddr, counter := startCountingProxy(t, startE2EServer(t))
f := newHTTPFixture(t, bin, proxyAddr)
counter.reset()
r := f.mustRun(nil, "ping", "--json")
if status := firstJSONField(t, r.stdout, "status"); status != "ok" {
t.Errorf("bd ping --json status = %q: %s", status, r.stdout)
}
sawContext := false
for _, p := range counter.snapshot() {
if p == "GET /v0/beads/context" {
sawContext = true
}
}
if !sawContext {
t.Errorf("bd ping made no context request: %v", counter.snapshot())
}
// A dead server is a failed ping, not a stale success.
sidecar := filepath.Join(f.dir, ".beads", "http_target.json")
data, err := os.ReadFile(sidecar)
if err != nil {
t.Fatal(err)
}
dead := strings.ReplaceAll(string(data), proxyAddr, "127.0.0.1:1")
if err := os.WriteFile(sidecar, []byte(dead), 0o600); err != nil {
t.Fatal(err)
}
if r := f.run(nil, "ping", "--json"); r.code == 0 {
t.Errorf("bd ping against a dead server exited 0: %s", r.stdout)
}
}
// TestE2E_ClaimOfAbsentIDIsGCNotFound is S24-T: gc's hook claims through
// `bd update <id> --claim --json` on the work store and, on a not-found,
// escalates to its own wisp store (gascity BdStore.Claim -> isBdNotFound).
// Over http an absent id must therefore answer a not-found gc's matcher
// accepts — never a refusal — in at most two round trips, against both the
// current server and the MC server's handshake shape.
func TestE2E_ClaimOfAbsentIDIsGCNotFound(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
for _, tc := range []struct {
name string
mask func(map[string]any)
}{
{"current server", nil},
{"MC server mask", mcContextMask},
} {
t.Run(tc.name, func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, tc.mask)
f := newHTTPFixture(t, bin, proxyAddr)
present := f.create("claimable")
counter.reset()
r := f.run([]string{"BEADS_ACTOR=gc-hook"}, "update", "e2e-absent9", "--claim", "--json")
paths := counter.snapshot()
if r.code == 0 {
t.Fatalf("bd update <absent> --claim exited 0: %s", r.stdout)
}
// gascity internal/beads/bdstore.go isBdNotFound, verbatim. The
// error gc classifies carries stderr (and stdout's --json
// envelope when stderr is empty), so stderr must match alone.
isBdNotFound := func(msg string) bool {
msg = strings.ToLower(msg)
return strings.Contains(msg, "not found") ||
strings.Contains(msg, "no issue found") ||
strings.Contains(msg, "no issues found")
}
if !isBdNotFound(r.stderr) || (r.stdout != "" && !isBdNotFound(r.stdout)) {
t.Errorf("absent-id claim is not a gc not-found: stdout=%s stderr=%s", r.stdout, r.stderr)
}
for _, bad := range []string{"not supported", "already claimed", "already assigned"} {
if strings.Contains(strings.ToLower(r.stderr+r.stdout), bad) {
t.Errorf("absent-id claim output mentions %q: stdout=%s stderr=%s", bad, r.stdout, r.stderr)
}
}
if len(paths) > 2 {
t.Errorf("absent-id claim made %d requests, want at most 2: %v", len(paths), paths)
}
// A present id still claims through the same shape.
ok := f.run([]string{"BEADS_ACTOR=gc-hook"}, "update", present, "--claim", "--json")
if ok.code != 0 || firstJSONField(t, ok.stdout, "assignee") != "gc-hook" {
t.Errorf("claim of a present id: exit %d stdout=%s stderr=%s", ok.code, ok.stdout, ok.stderr)
}
})
}
}
// TestE2E_AdvertisedExternalPolicyIsPassedThrough is the other half of the
// design 3.6 rule, against the MC server's handshake shape: a server that
// advertises policy.external_dependencies has applied it, so the client reads
// no dependency edges for it on list, ready, claim, show or close.
func TestE2E_AdvertisedExternalPolicyIsPassedThrough(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
proxyAddr, counter := startMaskingProxy(t, startE2EServer(t), mcContextMask)
f := newHTTPFixture(t, bin, proxyAddr)
id := f.create("plain")
other := f.create("other")
f.mustRun(nil, "dep", "add", id, "external:other:cap")
counter.reset()
f.mustRun(nil, "list", "--json", "--limit", "50")
f.mustRun(nil, "ready", "--json", "--limit", "10")
f.mustRun(nil, "show", id, "--json")
f.mustRun(nil, "update", other, "--claim", "--json")
// claim-next is the server's ONE atomic operation, not a client-side
// read-then-claim loop. Only its own requests count: the MC handshake
// lacks issues.update.claim, so the claim of other above went to
// claimIssue by design.
readyClaimFrom := len(counter.snapshot())
f.mustRun(nil, "ready", "--claim", "--json")
var claimNexts, byID int
for _, p := range counter.snapshot()[readyClaimFrom:] {
switch {
case p == "POST /v0/beads/issues:claimNext":
claimNexts++
case strings.HasPrefix(p, "POST /v0/beads/issues/") && strings.HasSuffix(p, ":claim"):
byID++
}
}
if claimNexts != 1 || byID != 0 {
t.Errorf("claimNext requests = %d, by-id claims = %d; want one atomic claim-next and no by-id claim: %v", claimNexts, byID, counter.snapshot())
}
f.mustRun(nil, "close", other, "--json")
// The close policy check is the client-side policy's last chance: it runs
// before the close request, so only the reads up to that request count
// here. The molecule auto-close is not a client read any more; it rides on
// the close request itself (auto_close_molecule) and the server performs
// it inside the close.
paths := counter.snapshot()
for _, p := range paths {
if strings.HasPrefix(p, "POST /v0/beads/issues:batchClose") {
break
}
if strings.HasPrefix(p, "GET /v0/beads/dependencies") {
t.Errorf("client-side policy ran against a server advertising policy.external_dependencies: %s in %v", p, paths)
break
}
}
}

View file

@ -1,98 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"strings"
"testing"
)
// TestE2E_PerCommandRequestBudget pins how many sequential gateway requests
// each everyday bd command makes over the http backend (bts-xpw.3.14.6,
// beads-team-server docs/v0-gateway-latency.md option F). On the hosted /v0
// path every request costs ~0.33 s warm, and a command makes them strictly one
// after another, so the request count IS the command's latency floor.
//
// The budgets are ceilings, not exact counts: a change that makes a command
// cheaper passes, a change that adds a round trip fails here first. Both the
// current server's handshake and the MC server's (fewer capabilities, no
// wire_revision) are held to the same ceilings.
func TestE2E_PerCommandRequestBudget(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
for _, tc := range []struct {
name string
mask func(map[string]any)
// over raises a step's budget for this handshake shape, where the
// server lacks a capability the step otherwise relies on.
over map[string]int
}{
// The in-process server composes no external-dependency policy, so
// its handshake lacks policy.external_dependencies and the client
// applies the policy itself with extra reads. A deployed bd serve
// (hosted included) enforces it and says so; advertise it here so
// the budget measures that shape.
{"current server", advertiseExternalPolicy, nil},
// The MC server predates issues.close.autoCloseMolecule, so a close
// there also runs the molecule auto-close check client side (an edge
// read and a re-read of the closed row).
{"MC server mask", mcContextMask, map[string]int{"close": 5}},
} {
t.Run(tc.name, func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, tc.mask)
f := newHTTPFixture(t, bin, proxyAddr)
target := f.create("budget target", "-t", "task")
other := f.create("budget other", "-t", "task")
closing := f.create("budget closing", "-t", "task")
f.mustRun(nil, "comments", "add", target, "seed comment")
for _, step := range []struct {
name string
budget int
args []string
}{
{"ready", 2, []string{"ready", "--json"}},
// The limit hides rows, and without BD_JSON_ENVELOPE nothing
// prints their count: one listing, no ready:count after it.
{"ready --limit 1", 2, []string{"ready", "--json", "--limit", "1"}},
{"list", 4, []string{"list", "--json"}},
{"show", 1, []string{"show", target, "--json"}},
// The first ready learned the server's external-dependency
// policy from the handshake; a later process reads it from the
// policy cache instead of fetching the context again.
{"ready, policy cached", 1, []string{"ready", "--json"}},
{"create", 2, []string{"create", "budget created", "-t", "task", "--json"}},
{"update --append-notes", 3, []string{"update", target, "--append-notes", "more", "--json"}},
{"update --status", 3, []string{"update", target, "--status", "in_progress", "--json"}},
{"close", 3, []string{"close", closing, "--json"}},
{"comments add", 3, []string{"comments", "add", target, "a budget comment"}},
{"dep add", 5, []string{"dep", "add", target, other}},
} {
counter.reset()
f.mustRun(nil, step.args...)
paths := counter.snapshot()
t.Logf("bd %s: %d requests: %s", step.name, len(paths), strings.Join(paths, ", "))
budget := step.budget
if over, ok := tc.over[step.name]; ok {
budget = over
}
if len(paths) > budget {
t.Errorf("bd %s made %d gateway requests, budget %d: %v", step.name, len(paths), budget, paths)
}
}
})
}
}
// advertiseExternalPolicy adds policy.external_dependencies to the handshake's
// capabilities, the shape of a deployed bd serve that enforces the policy.
func advertiseExternalPolicy(body map[string]any) {
caps, _ := body["capabilities"].([]any)
for _, c := range caps {
if c == "policy.external_dependencies" {
return
}
}
body["capabilities"] = append(caps, "policy.external_dependencies")
}

View file

@ -1,72 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"testing"
)
// TestE2E_SearchOverHTTP is S26. `bd search` called the raw SearchIssues
// method, which the http backend refuses ("partial-id search is not available
// over HTTP"); it now asks Reader.List with the text in ListRequest.Query,
// which travels as listIssues' `q` behind issues.list.search.
func TestE2E_SearchOverHTTP(t *testing.T) {
bd := connectE2EWorkspace(t, "worker")
routed := createE2EIssue(t, bd, "Routed pool work")
alsoRouted := createE2EIssue(t, bd, "re-routed later")
closedRouted := createE2EIssue(t, bd, "routed and done")
other := createE2EIssue(t, bd, "something else")
mustRun(t, bd, "close", closedRouted, "--json")
// A refusal of the raw SearchIssuesWithCounts seam is the S26 regression
// itself, not a missing dependency: S6c (the externaldeps reader
// passthrough) is underneath, so nothing on this route reaches that seam.
r := bd("search", "ROUTED", "--json")
if r.code != 0 {
t.Fatalf("bd search failed (exit %d): stdout=%s stderr=%s", r.code, r.stdout, r.stderr)
}
got := jsonIDSet(t, r.stdout)
// Case-insensitive, every status (search includes closed by default).
for _, id := range []string{routed, alsoRouted, closedRouted} {
if !got[id] {
t.Errorf("bd search ROUTED missed %s: %s", id, r.stdout)
}
}
if got[other] {
t.Errorf("bd search ROUTED matched %s, whose title does not contain it: %s", other, r.stdout)
}
// --status narrows, as on a local workspace.
open := jsonIDSet(t, mustRun(t, bd, "search", "routed", "--status", "open", "--json").stdout)
if open[closedRouted] || !open[routed] {
t.Errorf("bd search routed --status open = %v, want %s without %s", open, routed, closedRouted)
}
// An id matches even when the title does not contain it.
byID := jsonIDSet(t, mustRun(t, bd, "search", other, "--json").stdout)
if !byID[other] {
t.Errorf("bd search %s did not match the issue by its id: %v", other, byID)
}
// A search filter rides listIssues behind issues.list.filters and narrows
// rather than being dropped: "pool" is in a TITLE here and in no
// description, so the answer is empty, where a dropped filter would answer
// every routed row.
r = bd("search", "routed", "--desc-contains", "pool", "--json")
if r.code != 0 {
t.Fatalf("bd search --desc-contains failed over http (exit %d): stdout=%s stderr=%s", r.code, r.stdout, r.stderr)
}
if narrowed := jsonIDSet(t, r.stdout); len(narrowed) != 0 {
t.Errorf("bd search routed --desc-contains pool = %v, want nothing: no description contains it", narrowed)
}
// And it matches: a description carrying the token answers exactly that
// row, so the empty answer above is the filter narrowing, not a filter
// that matches nothing for some other reason.
mustRun(t, bd, "update", alsoRouted, "--description", "a lantern in the description", "--json")
matched := jsonIDSet(t, mustRun(t, bd, "search", "routed", "--desc-contains", "LANTERN", "--json").stdout)
if len(matched) != 1 || !matched[alsoRouted] {
t.Errorf("bd search routed --desc-contains LANTERN = %v, want exactly %s, whose description contains it", matched, alsoRouted)
}
}

View file

@ -1,88 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"strings"
"testing"
)
// connectE2EWorkspace starts an in-process server and returns a workspace
// `bd connect`ed to it, plus a runner that drives the built binary there as
// the given actor.
func connectE2EWorkspace(t *testing.T, actor string) func(args ...string) bdResult {
t.Helper()
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
workspace := t.TempDir()
env := []string{"BEADS_ACTOR=" + actor}
if r := runBD(t, bin, workspace, env, "connect", "http://"+addr, "--expect-project-id", e2eProjectID, "--json"); r.code != 0 {
t.Fatalf("bd connect failed (exit %d): stdout=%s stderr=%s", r.code, r.stdout, r.stderr)
}
return func(args ...string) bdResult {
t.Helper()
return runBD(t, bin, workspace, env, args...)
}
}
func mustRun(t *testing.T, bd func(args ...string) bdResult, args ...string) bdResult {
t.Helper()
r := bd(args...)
if r.code != 0 {
t.Fatalf("bd %s failed (exit %d): stdout=%s stderr=%s", strings.Join(args, " "), r.code, r.stdout, r.stderr)
}
return r
}
func createE2EIssue(t *testing.T, bd func(args ...string) bdResult, title string) string {
t.Helper()
id := firstJSONField(t, mustRun(t, bd, "create", title, "--json").stdout, "id")
if id == "" {
t.Fatalf("bd create %q --json produced no id", title)
}
return id
}
// TestE2E_ShowCurrentOverHTTP is S6e. `bd show --current` used to read the
// actor's in-progress work through the raw SearchIssues method, which the http
// backend refuses; the refusal was swallowed and the command printed the
// LAST-TOUCHED issue instead, exit 0. It now reads through the Querier role
// (queryIssues), so the in-progress issue wins over a more recently touched
// one, and a hooked issue is found when nothing is in progress.
func TestE2E_ShowCurrentOverHTTP(t *testing.T) {
bd := connectE2EWorkspace(t, "worker")
current := createE2EIssue(t, bd, "the work in progress")
hooked := createE2EIssue(t, bd, "hooked work")
touched := createE2EIssue(t, bd, "touched last")
mustRun(t, bd, "update", current, "--status", "in_progress", "--assignee", "worker", "--json")
// Touch another issue AFTER claiming, so last-touched is not the current
// issue: the old swallowed refusal answered with exactly this one.
mustRun(t, bd, "update", touched, "--priority", "1", "--json")
showCurrent := func() string {
t.Helper()
r := mustRun(t, bd, "show", "--current", "--json")
return firstJSONField(t, r.stdout, "id")
}
if got := showCurrent(); got != current {
t.Fatalf("bd show --current = %s, want the in-progress %s (last touched was %s)", got, current, touched)
}
// Nothing in progress: the hooked issue assigned to the actor is current.
mustRun(t, bd, "update", current, "--status", "open", "--assignee", "", "--json")
mustRun(t, bd, "update", hooked, "--status", "hooked", "--assignee", "worker", "--json")
mustRun(t, bd, "update", touched, "--priority", "2", "--json")
if got := showCurrent(); got != hooked {
t.Fatalf("bd show --current = %s, want the hooked %s (last touched was %s)", got, hooked, touched)
}
// Neither: last-touched is the answer, and only now.
mustRun(t, bd, "update", hooked, "--status", "open", "--assignee", "", "--json")
mustRun(t, bd, "update", touched, "--priority", "3", "--json")
if got := showCurrent(); got != touched {
t.Fatalf("bd show --current = %s, want the last-touched %s when nothing is in progress or hooked", got, touched)
}
}

View file

@ -1,89 +0,0 @@
//go:build cgo
package bdhttp_test
import (
"slices"
"strings"
"testing"
)
// TestE2E_ShowFetchesTheIssueOnce (mc-5dkzp) pins the exact requests, path AND
// query, each bd show shape makes over the http backend. bd show resolves the
// id, fetches the row, then reads it for output: three reads of one URL that
// the per-command read memo answers with one request. A read that drifts to a
// URL of its own (a new parameter, or a default spelled out) still fits a
// request ceiling of two, so this is an exact list, not a budget: a change that
// makes show cheaper updates the list here too.
//
// Text show's dependents and comments sections are separate reads of the same
// row with include_dependents and include_comments, which the memo cannot
// collapse; a later change that reads them in one request updates that step.
func TestE2E_ShowFetchesTheIssueOnce(t *testing.T) {
skipUnlessEmbeddedDolt(t)
bin := buildBD(t)
addr := startE2EServer(t)
for _, tc := range []struct {
name string
mask func(map[string]any)
}{
{"current server", advertiseExternalPolicy},
{"MC server mask", mcContextMask},
} {
t.Run(tc.name, func(t *testing.T) {
proxyAddr, counter := startMaskingProxy(t, addr, tc.mask)
f := newHTTPFixture(t, bin, proxyAddr)
target := f.create("once target", "-t", "task")
other := f.create("once other", "-t", "task")
f.mustRun(nil, "dep", "add", target, other)
f.mustRun(nil, "comments", "add", target, "seed comment")
get := func(id, query string) string {
uri := "GET /v0/beads/issues/" + id
if query != "" {
uri += "?" + query
}
return uri
}
for _, step := range []struct {
args []string
want []string
}{
{[]string{"show", target, "--json"}, []string{get(target, "")}},
{[]string{"show", "--json", "--id=" + target}, []string{get(target, "")}},
{[]string{"show", target, "--short"}, []string{get(target, "")}},
{[]string{"show", target, other, "--json"}, []string{get(target, ""), get(other, "")}},
{[]string{"show", target}, []string{
get(target, ""),
get(target, "include_dependents=true"),
get(target, "include_comments=true"),
}},
} {
counter.reset()
f.mustRun(nil, step.args...)
if got := counter.uriSnapshot(); !slices.Equal(got, step.want) {
t.Errorf("bd %s:\n got %q\n want %q", strings.Join(step.args, " "), got, step.want)
}
}
// BD_HTTP_READ_MEMO=0 turns the memo off: the same show asks
// the server again for every read of the row.
counter.reset()
f.mustRun([]string{"BD_HTTP_READ_MEMO=0"}, "show", target, "--json")
got := counter.uriSnapshot()
if bare := countOf(got, get(target, "")); bare < 2 {
t.Errorf("BD_HTTP_READ_MEMO=0 bd show %s --json read the row %d times (%q); the kill switch must turn the memo off", target, bare, got)
}
})
}
}
func countOf(list []string, want string) int {
n := 0
for _, s := range list {
if s == want {
n++
}
}
return n
}

View file

@ -24,38 +24,6 @@
// each workspace it opens, without the process-wide dialer being asked to
// serve two tenants with one fixed credential.
//
// # Credentials: one per open, never one per host
//
// A process may open many projects — on one server or several, each with a
// credential of its own (gc's per-city and per-rig credentials). The rule that
// keeps them apart: when a credential is handed to an open or a handshake, it
// is the ONLY credential that open or handshake uses.
//
// - Options.Credential (Open, Handshake, Connect) and
// backends.OpenOptions.Credential carrying a ProvidedCredential (the
// registry's OpenWith seam, beads.OpenBestAvailableWith) both take this
// explicit path.
// - On it no bearer ladder is built, so BEADS_HTTP_TOKEN,
// BEADS_HTTP_TOKEN_COMMAND and the credentials file (BEADS_CREDENTIALS_FILE,
// keyed [host:port]) are never read. CA trust comes from Target.CAFile alone
// (never BEADS_HTTP_CA_FILE), and the plaintext-to-non-loopback grant from
// Target.AllowInsecureCredential alone (never BEADS_HTTP_ALLOW_INSECURE).
// The open reads no process environment on the credential's account.
// - The provider is held by the one store (or the one handshake) it was
// handed to, and anything it resolves or caches lives there. This package
// and the one beneath it keep no process-wide credential state: there is no
// cache keyed by host[:port] for two projects behind the same server to
// share. (The only process-wide transport state is the CA-scoped
// *http.Transport pool, keyed by CA file and carrying no credential; the
// Authorization header is set per request by the store's own provider.)
//
// Only with NO credential does an open fall back to the ambient ladder keyed
// by host[:port] — the single-tenant CLI posture. A multi-tenant embedder
// should pass a credential on every open, and can make a missing one a loud
// refusal on the registry seam with Options.RequireCredential. A process-wide
// credential is refused outright: Register panics on a non-nil
// Options.Credential, because the dialer it installs serves every workspace.
//
// # Stability
//
// EXPERIMENTAL, on the same terms as the backend package this sits beside.
@ -82,7 +50,7 @@ const UserAgentSuffix = httpclient.WireUserAgentSuffix
// with.
//
// The zero value is usable and is what the CLI's own wiring amounts to: the
// built-in bearer credential ladder (Credential nil), this module's default User-Agent, and
// built-in bearer credential ladder, this module's default User-Agent, and
// the standard http transport.
type Options struct {
// UserAgent identifies the embedding build on every request. Empty sends
@ -90,15 +58,9 @@ type Options struct {
UserAgent string
// HTTPClient replaces the transport — a tuned timeout, a proxy, a custom
// TLS config, an httptest server in a test. Nil builds one. The client is
// used as given except for two things the underlying wire client always
// does. It forces redirect handling off: a followed 30x would replay the
// Authorization header at whatever host the Location named. And for a
// batch apply of more than 100 items it raises a Timeout shorter than 6
// minutes to 6 minutes, for that request alone: bd serve gives such a
// request an extended budget and commits it even after the client has
// given up, so a shorter Timeout reports a failure for a write that
// lands. A client with no Timeout stays unbounded; a call's context still
// bounds it.
// used as given except for redirect handling, which the underlying wire
// client always forces off: a followed 30x would replay the Authorization
// header at whatever host the Location named.
HTTPClient *http.Client
// RequireCredential makes the registered backend's OpenWith seam refuse a
// registered open with no OpenOptions.Credential, rather than silently
@ -114,19 +76,6 @@ type Options struct {
// httpclient.ResolveCredential and backends.OpenOptions.Credential's own
// doc comment.
RequireCredential bool
// Credential, when non-nil, is the ONLY credential Open, Handshake and
// Connect authorize with: the call reads no ambient token, token command,
// credentials file, CA env or plaintext env (see the package doc's
// "Credentials" section and httpclient.DialWithCredential). It is the
// direct-door twin of backends.OpenOptions.Credential carrying a
// ProvidedCredential{Provider: Credential}. CA trust on this path is
// Target.CAFile, and the plaintext grant Target.AllowInsecureCredential.
//
// The provider is used by the one store or handshake it is handed to, so
// whatever it caches is per store. Register refuses (panics on) a non-nil
// Credential: its dialer is process-wide, and one credential for every
// workspace is exactly what this field exists to avoid.
Credential CredentialProvider
}
// Register adds the http store to the backend registry under the name "http"
@ -145,9 +94,6 @@ type Options struct {
// error, so it must have exactly one production call site. Call it once,
// before any concurrent store access.
func Register(opts Options) {
if opts.Credential != nil {
panic("bdhttp.Register: Options.Credential is per open, not process-wide; pass it to Open/Handshake, or as a ProvidedCredential in backends.OpenOptions")
}
base := httpclient.DialOptions{UserAgent: opts.UserAgent, HTTPClient: opts.HTTPClient}
backends.Register(httpclient.Backend, backends.Backend{
Open: httpclient.NewFromConfig,
@ -167,21 +113,16 @@ func Register(opts Options) {
// configuration, or minted per tenant — and would otherwise have to write a
// .beads directory for the sole benefit of a registry lookup. Registration is
// not required and does not affect it: Open dials fresh from the Options it is
// handed. With Options.Credential set, that credential is the only one used, and
// no ambient credential, CA or plaintext grant is read; without it, Open uses
// the same built-in bearer ladder Open/OpenReadOnly use.
// handed, using the same built-in bearer ladder Open/OpenReadOnly use (see
// Options.RequireCredential's doc for why a per-tenant credential belongs on
// the registry's OpenWith seam instead, via beads.OpenBestAvailableWith).
//
// The store carries no local metadata file, which is benign: the two
// per-user keys it would hold read as unset and write nowhere.
func Open(ctx context.Context, target Target, opts Options) (backend.DoltStorage, error) {
base := httpclient.DialOptions{UserAgent: opts.UserAgent, HTTPClient: opts.HTTPClient}
var conn *httpclient.Conn
var err error
if opts.Credential != nil {
conn, err = httpclient.DialWithCredential(target, opts.Credential, base)
} else {
conn, err = httpclient.DialWith(target, httpclient.NewBearerProvider(target.BaseURL), httpclient.DialOptionsForTarget(target, base))
}
dialOpts := httpclient.DialOptionsForTarget(target, httpclient.DialOptions{UserAgent: opts.UserAgent, HTTPClient: opts.HTTPClient})
creds := httpclient.NewBearerProvider(target.BaseURL)
conn, err := httpclient.DialWith(target, creds, dialOpts)
if err != nil {
return nil, err
}
@ -198,21 +139,15 @@ func Open(ctx context.Context, target Target, opts Options) (backend.DoltStorage
// mismatch comes back as *ProjectMismatchError, which names both ids plus the
// server's own database and repo root.
//
// It dials with the same credentials Open would given the same Options, so a
// probe can never verify a server the store then cannot reach: Options.Credential
// when set (and then nothing ambient), else the built-in bearer ladder.
// It dials with the same credentials Open would, so a probe can never verify
// a server the store then cannot reach.
func Handshake(ctx context.Context, target Target, opts Options) (*ServerSnapshot, error) {
base := httpclient.DialOptions{UserAgent: opts.UserAgent, HTTPClient: opts.HTTPClient}
var body *apigen.ContextResponse
var err error
if opts.Credential != nil {
body, err = httpclient.HandshakeWithCredential(ctx, target, opts.Credential, base)
} else {
// httpclient.Handshake dials via httpclient.Dial, which binds the
// same built-in bearer ladder (httpclient.NewBearerProvider) Open
// uses above.
body, err = httpclient.Handshake(ctx, target, httpclient.DialOptionsForTarget(target, base))
}
dialOpts := httpclient.DialOptionsForTarget(target, httpclient.DialOptions{UserAgent: opts.UserAgent, HTTPClient: opts.HTTPClient})
// httpclient.Handshake dials via httpclient.Dial, which binds the same
// built-in bearer ladder (httpclient.NewBearerProvider) Open uses above —
// "the same credentials Open would use" holds without restating the dial
// here.
body, err := httpclient.Handshake(ctx, target, dialOpts)
if err != nil {
return nil, err
}

View file

@ -4,8 +4,9 @@ package bdhttp_test
// contribution: TestOpenNeedsNoWorkspaceOnDisk, the ServerSnapshot field-set
// drift guard, TestHandshakeReportsAWrongServer, and the activation sidecar
// round trip carry the same reasoning. Dropped or reshaped for OSS: the
// Credentials-hook tests (OSS takes a per-call Options.Credential instead;
// its tests are in per_open_credential_test.go), ServerInfo / lazy ServerContext (the OSS Store
// Credentials-hook tests (OSS Open/Handshake dial through the built-in bearer
// ladder only — see Options.RequireCredential's doc — there is no per-call
// hook to assert on here), ServerInfo / lazy ServerContext (the OSS Store
// does not expose that interface), and ServerSnapshot's field set itself,
// which follows DESIGN.txt exactly (WireRevision in place of the ORM-backed
// field bd-enterprise used). No bd-enterprise-specific wording carries over.

View file

@ -1,444 +0,0 @@
package bdhttp_test
// Written fresh for OSS beads S6f (no bd-enterprise source copied): one
// process opening several projects, on the same server, each with its own
// credential (gc's per-city / per-rig credentials).
import (
"context"
"errors"
"io"
"net/http"
"net/http/httptest"
"net/url"
"os"
"path/filepath"
"strings"
"sync"
"testing"
"github.com/steveyegge/beads/backend"
bdhttp "github.com/steveyegge/beads/backend/http"
"github.com/steveyegge/beads/internal/storage"
"github.com/steveyegge/beads/internal/storage/backends"
)
// twoProjectServer is ONE bd serve stand-in (one host:port) mounting two
// projects under their own path roots, recording the Authorization header
// each project saw. The host:port ladder cannot tell the two apart; only a
// per-open credential can.
type twoProjectServer struct {
*httptest.Server
mu sync.Mutex
auths map[string][]string // mount -> Authorization headers seen
}
func newTwoProjectServer(t *testing.T, mounts ...string) *twoProjectServer {
t.Helper()
s := &twoProjectServer{auths: map[string][]string{}}
s.Server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
for _, mount := range mounts {
if r.URL.Path != "/"+mount+"/v0/beads/context" {
continue
}
s.mu.Lock()
s.auths[mount] = append(s.auths[mount], r.Header.Get("Authorization"))
s.mu.Unlock()
w.Header().Set("Content-Type", "application/json")
_, _ = w.Write([]byte(`{"api_version":"v0","backend":"dolt","bd_version":"9.9.9",` +
`"beads_dir":"/srv/.beads","capabilities":["issues.get","issues.list"],` +
`"database":"beads","dolt_mode":"server","project_id":"proj-` + mount + `","repo_root":"/srv",` +
`"schema_version":1,"wire_revision":1,"min_client_wire_revision":1}`))
return
}
http.NotFound(w, r)
}))
t.Cleanup(s.Server.Close)
return s
}
func (s *twoProjectServer) target(t *testing.T, mount string) bdhttp.Target {
t.Helper()
base, err := url.Parse(s.URL + "/" + mount)
if err != nil {
t.Fatalf("parse the test server URL: %v", err)
}
return bdhttp.Target{BaseURL: base, ExpectProjectID: "proj-" + mount}
}
func (s *twoProjectServer) wantAuthorization(t *testing.T, mount, want string) {
t.Helper()
s.mu.Lock()
defer s.mu.Unlock()
got := s.auths[mount]
if len(got) == 0 {
t.Fatalf("project %q saw no requests at all", mount)
}
for i, auth := range got {
if auth != want {
t.Errorf("project %q request %d carried Authorization %q, want %q", mount, i, auth, want)
}
}
}
// poisonAmbient arms every ambient credential source for 127.0.0.1 with a
// token that must never reach the wire: the env token, a token command, and a
// credentials file section for the server's exact host:port.
func poisonAmbient(t *testing.T, server *httptest.Server) {
t.Helper()
base, err := url.Parse(server.URL)
if err != nil {
t.Fatalf("parse the test server URL: %v", err)
}
t.Setenv(bdhttp.TokenEnv, "127.0.0.1=ambient-env-token")
t.Setenv(bdhttp.TokenCommandEnv, "127.0.0.1=echo ambient-command-token")
credFile := filepath.Join(t.TempDir(), "credentials")
body := "[" + base.Host + "]\npassword = ambient-file-token\n"
if err := os.WriteFile(credFile, []byte(body), 0o600); err != nil {
t.Fatalf("write credentials file: %v", err)
}
t.Setenv("BEADS_CREDENTIALS_FILE", credFile)
}
// TestTwoStoresOnOneHostEachSendTheirOwnToken is the G7 shape: one process,
// one server (one host:port), two projects, two credentials. Each store must
// send its own token on every request, and neither may pick up the other's
// or the ambient one — through the direct door and the registry's OpenWith
// seam alike.
func TestTwoStoresOnOneHostEachSendTheirOwnToken(t *testing.T) {
server := newTwoProjectServer(t, "alpha", "beta", "gamma", "delta")
poisonAmbient(t, server.Server)
ctx := context.Background()
// The direct door: bdhttp.Open with Options.Credential.
alpha, err := bdhttp.Open(ctx, server.target(t, "alpha"), bdhttp.Options{
HTTPClient: server.Client(), Credential: &recordingProvider{token: "alpha-token"},
})
if err != nil {
t.Fatalf("Open alpha: %v", err)
}
t.Cleanup(func() { _ = alpha.Close() })
beta, err := bdhttp.Open(ctx, server.target(t, "beta"), bdhttp.Options{
HTTPClient: server.Client(), Credential: &recordingProvider{token: "beta-token"},
})
if err != nil {
t.Fatalf("Open beta: %v", err)
}
t.Cleanup(func() { _ = beta.Close() })
// The registry seam: OpenWith with a ProvidedCredential per workspace.
registerForTest(t, bdhttp.Options{HTTPClient: server.Client(), RequireCredential: true})
registered, ok := backend.Lookup(backendName)
if !ok {
t.Fatal("the http backend is not registered")
}
openRegistered := func(mount, token string) backend.DoltStorage {
t.Helper()
beadsDir := filepath.Join(t.TempDir(), ".beads")
if err := os.MkdirAll(beadsDir, 0o700); err != nil {
t.Fatalf("create workspace: %v", err)
}
if err := bdhttp.SaveTarget(beadsDir, server.target(t, mount)); err != nil {
t.Fatalf("save the activation sidecar: %v", err)
}
store, err := registered.OpenWith(ctx, beadsDir, backends.OpenOptions{
Credential: bdhttp.ProvidedCredential{Provider: &recordingProvider{token: token}},
})
if err != nil {
t.Fatalf("OpenWith %s: %v", mount, err)
}
t.Cleanup(func() { _ = store.Close() })
return store
}
gamma := openRegistered("gamma", "gamma-token")
delta := openRegistered("delta", "delta-token")
// Interleave the reads so a credential cached per host by whichever open
// ran first would show up on the others.
for round := 0; round < 2; round++ {
for name, store := range map[string]backend.DoltStorage{"alpha": alpha, "beta": beta, "gamma": gamma, "delta": delta} {
got, err := store.GetMetadata(ctx, "_project_id")
if err != nil {
t.Fatalf("GetMetadata %s: %v", name, err)
}
if got != "proj-"+name {
t.Errorf("store %s reached project %q", name, got)
}
}
}
for _, mount := range []string{"alpha", "beta", "gamma", "delta"} {
server.wantAuthorization(t, mount, "Bearer "+mount+"-token")
}
}
// TestExplicitCredentialOverridesTheAmbientToken: with BEADS_HTTP_TOKEN,
// BEADS_HTTP_TOKEN_COMMAND and the credentials file all naming this server,
// an explicit Options.Credential is still the only thing sent. The control
// open without one proves the poison is live (the ambient ladder does pick
// it up), so the explicit result is not a vacuous pass.
func TestExplicitCredentialOverridesTheAmbientToken(t *testing.T) {
server := newTwoProjectServer(t, "alpha", "beta")
poisonAmbient(t, server.Server)
ctx := context.Background()
store, err := bdhttp.Open(ctx, server.target(t, "alpha"), bdhttp.Options{
HTTPClient: server.Client(), Credential: &recordingProvider{token: "explicit-token"},
})
if err != nil {
t.Fatalf("Open: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if _, err := store.GetMetadata(ctx, "_project_id"); err != nil {
t.Fatalf("GetMetadata: %v", err)
}
server.wantAuthorization(t, "alpha", "Bearer explicit-token")
control, err := bdhttp.Open(ctx, server.target(t, "beta"), bdhttp.Options{HTTPClient: server.Client()})
if err != nil {
t.Fatalf("Open (ambient control): %v", err)
}
t.Cleanup(func() { _ = control.Close() })
if _, err := control.GetMetadata(ctx, "_project_id"); err != nil {
t.Fatalf("GetMetadata (ambient control): %v", err)
}
server.wantAuthorization(t, "beta", "Bearer ambient-env-token")
}
// TestExplicitCredentialSurvivesBrokenAmbientEnv is the behavioural proof
// that the explicit door reads no environment: every ambient variable it
// could consult is set to a value the ambient path refuses outright (an
// unscoped token, an unscoped CA pattern), and the explicit open and
// handshake still succeed. The control shows the same env does break an
// ambient handshake.
func TestExplicitCredentialSurvivesBrokenAmbientEnv(t *testing.T) {
server := newTwoProjectServer(t, "alpha")
t.Setenv(bdhttp.TokenEnv, "unscoped-token-is-refused")
t.Setenv(bdhttp.TokenCommandEnv, "unscoped-command-is-refused")
t.Setenv("BEADS_HTTP_CA_FILE", "/no/such/ca.pem")
t.Setenv("BEADS_CREDENTIALS_FILE", filepath.Join(t.TempDir(), "absent"))
ctx := context.Background()
opts := bdhttp.Options{HTTPClient: server.Client(), Credential: &recordingProvider{token: "explicit-token"}}
if _, err := bdhttp.Handshake(ctx, server.target(t, "alpha"), opts); err != nil {
t.Fatalf("Handshake with a Credential consulted the broken ambient env: %v", err)
}
store, err := bdhttp.Open(ctx, server.target(t, "alpha"), opts)
if err != nil {
t.Fatalf("Open with a Credential: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if _, err := store.GetMetadata(ctx, "_project_id"); err != nil {
t.Fatalf("GetMetadata with a Credential consulted the broken ambient env: %v", err)
}
server.wantAuthorization(t, "alpha", "Bearer explicit-token")
if _, err := bdhttp.Handshake(ctx, server.target(t, "alpha"), bdhttp.Options{HTTPClient: server.Client()}); err == nil {
t.Fatal("the ambient handshake succeeded under a malformed unscoped token; the control no longer proves anything")
}
}
// TestHandshakeWithACredential: the pre-connect probe authorizes with the
// credential it is handed, not the ambient ladder, so it verifies exactly
// what the tenant's store will send.
func TestHandshakeWithACredential(t *testing.T) {
server := newTwoProjectServer(t, "alpha")
poisonAmbient(t, server.Server)
provider := &recordingProvider{token: "probe-token"}
snapshot, err := bdhttp.Handshake(context.Background(), server.target(t, "alpha"), bdhttp.Options{
HTTPClient: server.Client(), Credential: provider,
})
if err != nil {
t.Fatalf("Handshake: %v", err)
}
if snapshot.ProjectID != "proj-alpha" {
t.Errorf("snapshot project = %q, want proj-alpha", snapshot.ProjectID)
}
server.wantAuthorization(t, "alpha", "Bearer probe-token")
provider.mu.Lock()
calls := provider.calls
provider.mu.Unlock()
if calls == 0 {
t.Error("the handshake never asked the supplied provider to authorize")
}
}
// plaintextRemote stands in for a bd serve reached over plain http at a
// non-loopback address (the TLS-terminating proxy a plaintext grant exists
// for) without opening a socket. It answers the handshake, and not_found for
// anything else, and records the Authorization header of every request that
// actually reached it.
type plaintextRemote struct {
mu sync.Mutex
auths []string
}
func (r *plaintextRemote) RoundTrip(req *http.Request) (*http.Response, error) {
if req.Body != nil {
_ = req.Body.Close()
}
r.mu.Lock()
r.auths = append(r.auths, req.Header.Get("Authorization"))
r.mu.Unlock()
status, contentType, body := http.StatusNotFound, "application/problem+json", `{"status":404,"code":"not_found"}`
if strings.HasSuffix(req.URL.Path, "/v0/beads/context") {
status, contentType = http.StatusOK, "application/json"
body = `{"api_version":"v0","backend":"dolt","bd_version":"9.9.9",` +
`"beads_dir":"/srv/.beads","capabilities":["issues.get"],` +
`"database":"beads","dolt_mode":"server","project_id":"proj-remote","repo_root":"/srv",` +
`"schema_version":1,"wire_revision":1,"min_client_wire_revision":1}`
}
return &http.Response{
StatusCode: status,
Header: http.Header{"Content-Type": {contentType}},
Body: io.NopCloser(strings.NewReader(body)),
ContentLength: -1,
Request: req,
}, nil
}
func (r *plaintextRemote) seen() []string {
r.mu.Lock()
defer r.mu.Unlock()
return append([]string(nil), r.auths...)
}
// TestExplicitCredentialIgnoresTheEnvPlaintextGrant pins, at each production
// door, that BEADS_HTTP_ALLOW_INSECURE=1 grants an explicit credential
// nothing. Against a plain-http, non-loopback target, the registry's OpenWith
// (ProvidedCredential), Open and Handshake (Options.Credential) each refuse
// before any request reaches the transport, and the refusal names the grant
// that does work there. Every other explicit-door test dials loopback, where
// the guard returns before it reads the variable, so a door reverted to the
// env-consulting DialWith passed them all.
//
// Each door's control differs from its refused leg only in
// Target.AllowInsecureCredential, and must send the explicit token exactly
// once. The ambient control shows the same environment does grant the
// built-in ladder plaintext, so the refusals are the door's doing and not a
// variable nobody reads.
func TestExplicitCredentialIgnoresTheEnvPlaintextGrant(t *testing.T) {
hermeticEnv(t)
t.Setenv("BEADS_HTTP_ALLOW_INSECURE", "1")
registerForTest(t, bdhttp.Options{})
registered, ok := backend.Lookup(backendName)
if !ok {
t.Fatal("the http backend is not registered")
}
ctx := context.Background()
remote, err := url.Parse("http://198.51.100.1/") // RFC 5737 TEST-NET-2: never dialed.
if err != nil {
t.Fatalf("parse the remote URL: %v", err)
}
doors := []struct {
name string
// call drives one request through the door with a fresh explicit
// credential and returns that request's error. plaintextRemote
// answers the issue read not_found, which GetIssue reports as
// storage.ErrNotFound; that request reached the remote, so the
// store doors count it as success.
call func(t *testing.T, target bdhttp.Target, client *http.Client) error
}{
{"OpenWith", func(t *testing.T, target bdhttp.Target, client *http.Client) error {
beadsDir := filepath.Join(t.TempDir(), ".beads")
if err := os.MkdirAll(beadsDir, 0o700); err != nil {
t.Fatalf("create workspace: %v", err)
}
if err := bdhttp.SaveTarget(beadsDir, target); err != nil {
t.Fatalf("save the activation sidecar: %v", err)
}
store, err := registered.OpenWith(ctx, beadsDir, backends.OpenOptions{
Credential: bdhttp.ProvidedCredential{Provider: &recordingProvider{token: "explicit-token"}},
HTTPClient: client,
})
if err != nil {
t.Fatalf("OpenWith: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if _, err = store.GetIssue(ctx, "bd-1"); errors.Is(err, storage.ErrNotFound) {
return nil
}
return err
}},
{"Open", func(t *testing.T, target bdhttp.Target, client *http.Client) error {
store, err := bdhttp.Open(ctx, target, bdhttp.Options{
HTTPClient: client, Credential: &recordingProvider{token: "explicit-token"},
})
if err != nil {
t.Fatalf("Open: %v", err)
}
t.Cleanup(func() { _ = store.Close() })
if _, err = store.GetIssue(ctx, "bd-1"); errors.Is(err, storage.ErrNotFound) {
return nil
}
return err
}},
{"Handshake", func(t *testing.T, target bdhttp.Target, client *http.Client) error {
_, err := bdhttp.Handshake(ctx, target, bdhttp.Options{
HTTPClient: client, Credential: &recordingProvider{token: "explicit-token"},
})
return err
}},
}
for _, door := range doors {
t.Run(door.name, func(t *testing.T) {
refused := &plaintextRemote{}
err := door.call(t, bdhttp.Target{BaseURL: remote}, &http.Client{Transport: refused})
if err == nil || !strings.Contains(err.Error(), "refusing to send a credential") {
t.Fatalf("got %v, want the plaintext refusal: BEADS_HTTP_ALLOW_INSECURE=1 must grant an explicit credential nothing", err)
}
if msg := err.Error(); strings.Contains(msg, "BEADS_HTTP_ALLOW_INSECURE") || !strings.Contains(msg, "Target.AllowInsecureCredential") {
t.Errorf("refusal %q must name Target.AllowInsecureCredential, the grant this door honors, and not BEADS_HTTP_ALLOW_INSECURE, which it never reads", msg)
}
if got := refused.seen(); len(got) != 0 {
t.Errorf("the transport saw %d request(s) %q; the refusal must stop the credential before the wire", len(got), got)
}
granted := &plaintextRemote{}
if err := door.call(t, bdhttp.Target{BaseURL: remote, AllowInsecureCredential: true}, &http.Client{Transport: granted}); err != nil {
t.Fatalf("with Target.AllowInsecureCredential: %v", err)
}
if got := granted.seen(); len(got) != 1 || got[0] != "Bearer explicit-token" {
t.Errorf("with Target.AllowInsecureCredential the transport saw %q, want one request carrying the explicit token", got)
}
})
}
// Control: the same environment does grant the built-in ladder plaintext.
t.Setenv(bdhttp.TokenEnv, "198.51.100.1=ambient-token")
ambient := &plaintextRemote{}
if _, err := bdhttp.Handshake(ctx, bdhttp.Target{BaseURL: remote}, bdhttp.Options{HTTPClient: &http.Client{Transport: ambient}}); err != nil {
t.Fatalf("ambient Handshake under BEADS_HTTP_ALLOW_INSECURE=1: %v; the control no longer shows the variable is live", err)
}
if got := ambient.seen(); len(got) != 1 || got[0] != "Bearer ambient-token" {
t.Errorf("the ambient Handshake sent %q, want one request carrying the ambient token", got)
}
}
// TestRegisterRefusesAProcessWideCredential: the registered dialer serves
// every workspace in the process, so a credential on it would be one
// credential for every tenant — exactly what Options.Credential is for
// avoiding. Register panics before touching the registry.
func TestRegisterRefusesAProcessWideCredential(t *testing.T) {
hermeticEnv(t)
defer func() {
if backend.Registered(backendName) {
backend.Deregister(backendName)
t.Error("the refused Register still put http in the registry")
}
}()
var msg string
func() {
defer func() {
if r := recover(); r != nil {
msg, _ = r.(string)
}
}()
bdhttp.Register(bdhttp.Options{Credential: &recordingProvider{token: "global"}})
}()
if !strings.Contains(msg, "per open") {
t.Fatalf("Register with a Credential did not panic with the per-open refusal (got %q)", msg)
}
}

View file

@ -1,29 +0,0 @@
# Pinned shards for tools/bazel/go_test_pinned_shard.sh. Generated by
# tools/bazel/pin_shards.py; regenerate rather than edit (see its usage).
#
# Every top-level test measured at >= 3s, bin-packed
# longest-first onto these shards; every other test runs in the
# binary's own round-robin shards. Measured seconds per pinned shard:
# 135 125 126 134 124 123
# Unpinned tests: 28, 0s in total.
#
# <pinned shard> <TestName>
1 TestE2E_ClaimOfAbsentIDIsGCNotFound
1 TestE2E_ExternalDependencyBlockingStillEnforced
1 TestE2E_SwitchingBackToDoltLeavesOriginalIdentityIntact
2 TestE2E_CloseAndReopenUnderClaudeSession
2 TestE2E_ForceConnectWritesSucceedDespiteDifferingLocalProjectID
2 TestE2E_ListWithGCFiltersMatchesEmbedded
3 TestE2E_BDOverHTTP
3 TestE2E_DefaultDepTreeOverHTTP
3 TestE2E_ShowMissingIDIsNotFoundInOneLookup
4 TestE2E_ConnectClearRestoresThePreviousBackend
4 TestE2E_MoleculesOverHTTP
4 TestE2E_SearchOverHTTP
4 TestE2E_ShowCurrentOverHTTP
5 TestE2E_RecomputeBlockedOverHTTP
5 TestE2E_ReconnectRefusesADifferentProjectUnlessForced
5 TestE2E_ShowJSONCountsMatchEmbedded
6 TestE2E_AdvertisedExternalPolicyIsPassedThrough
6 TestE2E_MoleculeCloseAgainstAnOlderServer
6 TestE2E_PingOverHTTP

View file

@ -118,7 +118,6 @@ const (
EventLabelAdded = types.EventLabelAdded
EventLabelRemoved = types.EventLabelRemoved
EventLeaseReclaimed = types.EventLeaseReclaimed
EventLeaseRearmed = types.EventLeaseRearmed
EventCompacted = types.EventCompacted
)

View file

@ -99,18 +99,6 @@ func configuredBackendUnavailable(backend, beadsDir string, cfg *configfile.Conf
}
}
// UnsupportedWorkspaceFormatError is returned by OpenBestAvailable,
// OpenBestAvailableWith, OpenFromConfig and OpenGated when the workspace
// declares a data model this build cannot open: a metadata.json graph_mode
// other than "dependency", such as the "link" workspaces graph-preview builds
// of bd write, or the .beads/graph-preview-format marker those builds write
// beside it (FormatMarker), whatever the metadata says. Nothing was opened,
// created or modified. Match it with errors.As to read BeadsDir, GraphMode and
// FormatMarker; the bd CLI refuses the same workspaces with exit code 16.
// Aliased here because internal/configfile is unimportable outside this
// module.
type UnsupportedWorkspaceFormatError = configfile.UnsupportedWorkspaceFormatError
// Transaction provides atomic multi-operation support within a database transaction.
// Use Storage.RunInTransaction() to obtain a Transaction instance.
type Transaction = beads.Transaction
@ -381,9 +369,6 @@ func Open(ctx context.Context, dbPath string) (Storage, error) {
// name configuration.
// beadsDir is the path to the .beads directory.
func OpenFromConfig(ctx context.Context, beadsDir string) (Storage, error) {
if err := configfile.CheckDiscoveredWorkspaceFormat(beadsDir); err != nil {
return nil, err
}
return dolt.NewFromConfigWithOptions(ctx, beadsDir, &dolt.Config{CreateIfMissing: true})
}
@ -418,11 +403,6 @@ func OpenFromConfig(ctx context.Context, beadsDir string) (Storage, error) {
// operation holds one exclusively; zero means fail fast. A busy gate is
// reported as ErrGateBusy (match with errors.Is).
func OpenGated(ctx context.Context, beadsDir string, wait time.Duration) (Storage, error) {
// Before the gates: taking them creates gate files in and beside a
// workspace this build must leave untouched.
if err := configfile.CheckDiscoveredWorkspaceFormat(beadsDir); err != nil {
return nil, err
}
wsGate, err := workspacegate.ForWorkspace(beadsDir)
if err != nil {
return nil, err

View file

@ -46,11 +46,6 @@ func OpenBestAvailable(ctx context.Context, beadsDir string) (Storage, error) {
// typed refusal (the matching ErrXWithoutOpenWith sentinel), never a silent
// open with the field ignored.
func OpenBestAvailableWith(ctx context.Context, beadsDir string, opts OpenOptions) (Storage, error) {
// Before Load, which can migrate a legacy config.json, and before any
// backend is chosen, as the CLI store factories do.
if err := configfile.CheckDiscoveredWorkspaceFormat(beadsDir); err != nil {
return nil, err
}
cfg, err := configfile.Load(beadsDir)
if err != nil {
return nil, fmt.Errorf("loading storage metadata: %w", err)

View file

@ -32,11 +32,6 @@ func OpenBestAvailable(ctx context.Context, beadsDir string) (Storage, error) {
// rationale; behavior here is identical except that embedded Dolt is
// unavailable without CGO.
func OpenBestAvailableWith(ctx context.Context, beadsDir string, opts OpenOptions) (Storage, error) {
// Before Load, which can migrate a legacy config.json, and before any
// backend is chosen, as the CLI store factories do.
if err := configfile.CheckDiscoveredWorkspaceFormat(beadsDir); err != nil {
return nil, err
}
cfg, err := configfile.Load(beadsDir)
if err != nil {
return nil, fmt.Errorf("loading storage metadata: %w", err)

View file

@ -38,10 +38,6 @@ Which tier a test belongs in, and which command runs it, is decided by
6. Regenerate the CLI reference with `scripts/generate-cli-docs.sh`;
`scripts/check-cli-docs-drift.sh` fails a PR whose command-surface change
leaves the generated docs stale.
7. Regenerate the command-surface goldens and review the testdata diff:
`BD_UPDATE_GOLDEN=1 CGO_ENABLED=1 go test -tags gms_pure_go ./cmd/bd -run '^TestCommand(Tree|Help)Golden$'`.
`TestCommandTreeGolden` fails on any added, removed or reworded command or
flag until you do.
Prefer a flag on an existing command over a new command, and route
recovery/repair operations to `bd doctor --fix`; see the CLI design principles
@ -89,9 +85,6 @@ no linter enforces it).
or serialize the call under `stdioMutex`.
- `TestCorpusGolden` (`protocol/`) — no unreviewed change to the `--json`
wire shapes.
- `TestCommandTreeGolden` and `TestCommandHelpGolden` — no unreviewed change
to the command tree (every command and flag, hidden ones included) or to
the pinned `--help` output in `testdata/command_tree/`.
Fresh-workspace command fixtures call `isolateBeadsDirForTest(t)` before
setup or dispatch and must not use `t.Parallel()`.

View file

@ -12,23 +12,6 @@ go_binary(
srcs = ["testdata/preflight-go.go"],
)
# The external `dolt` stand-in for TestRunCompactDoltTargetsOnlyAuthorizedActiveDatabase
# (compact_gc_target_test.go), entirely env-driven at run time, so one
# prebuilt copy covers every test case and mode: the test never needs a host
# Go toolchain under Bazel (bazeltest.RunfileEnv, BEADS_TEST_COMPACT_GC_FIXTURE).
# pure/race pinned explicitly, like :bd_for_tests: stdlib-only (encoding/json,
# fmt, os), so it needs neither cgo nor the race detector, and nothing about
# it depends on either; pinning keeps that true whatever --config the
# consuming go_test builds under (prcore/embedded/doltserver-*), instead of
# relying on this tiny fixture happening to inherit a compatible default.
go_binary(
name = "compact_gc_fixture",
testonly = True,
srcs = ["testdata/compact-gc-fixture.go"],
pure = "on",
race = "off",
)
go_library(
name = "bd_lib",
srcs = [
@ -49,7 +32,6 @@ go_library(
"backup_restore.go",
"batch.go",
"batch_proxied_server.go",
"blocked_flags.go",
"bootstrap.go",
"branch.go",
"capability_registry.go",
@ -218,7 +200,6 @@ go_library(
"list_format.go",
"list_input.go",
"list_output.go",
"list_page_edges.go",
"list_proxied_server.go",
"list_roles.go",
"list_show_filter_modes.go",
@ -251,7 +232,6 @@ go_library(
"mol_progress.go",
"mol_proxied_server.go",
"mol_ready_gated.go",
"mol_roles.go",
"mol_seed.go",
"mol_show.go",
"mol_squash.go",
@ -298,7 +278,6 @@ go_library(
"recompute_blocked_proxied_server.go",
"relate.go",
"relate_proxied_server.go",
"remote_backend.go",
"remote_migrate_gate.go",
"rename.go",
"rename_prefix.go",
@ -316,13 +295,13 @@ go_library(
"schema.go",
"schema_skew.go",
"search.go",
"search_proxied_server.go",
"send_metrics.go",
"serve.go",
"setup.go",
"ship.go",
"show.go",
"show_children.go",
"show_current.go",
"show_display.go",
"show_format.go",
"show_proxied_server.go",
@ -375,13 +354,9 @@ go_library(
"version.go",
"version_proxied_server.go",
"version_tracking.go",
"versioned_history.go",
"versioned_history_switch.go",
"versions.go",
"where.go",
"wisp.go",
"wisp_proxied_server.go",
"workspace_format_guard.go",
"workspace_gate.go",
"worktree.go",
"worktree_cmd.go",
@ -421,8 +396,6 @@ go_library(
"//internal/hooks",
"//internal/httpapi",
"//internal/httpclient",
"//internal/httpclient/wire",
"//internal/initprocs",
"//internal/jira",
"//internal/linear",
"//internal/lockfile",
@ -468,7 +441,6 @@ go_library(
"//internal/utils",
"//internal/validation",
"//internal/versioncheck",
"//internal/versionedhistory",
"//internal/workapi",
"//internal/workspacegate",
"//internal/worktreeremove",
@ -526,7 +498,6 @@ go_binary(
race = "off",
visibility = [
"//backend/http:__pkg__",
"//backend/http/corpus:__pkg__",
"//cmd/bd:__subpackages__",
"//internal/beads:__pkg__",
"//internal/storage/uow:__pkg__",
@ -549,7 +520,6 @@ go_test(
"actor_test.go",
"ado_roundtrip_test.go",
"ado_test.go",
"agent_artifacts_embedded_test.go",
"agent_hook_test.go",
"assign_fence_embedded_test.go",
"assign_fence_proxied_test.go",
@ -576,7 +546,6 @@ go_test(
"batch_parity_test.go",
"batch_test.go",
"blocked_embedded_test.go",
"blocked_flags_test.go",
"blocked_proxied_integration_test.go",
"bootstrap_backend_guard_test.go",
"bootstrap_embedded_test.go",
@ -607,7 +576,6 @@ go_test(
"cobra_flag_reset_test.go",
"codex_hook_test.go",
"command_telemetry_test.go",
"command_tree_golden_test.go",
"comment_promote_embedded_test.go",
"comment_proxied_integration_test.go",
"comment_reserved_word_test.go",
@ -625,8 +593,6 @@ go_test(
"compact_tier2_embedded_test.go",
"completions_test.go",
"config_apply_test.go",
"config_commit_server_integration_test.go",
"config_commit_write_test.go",
"config_drift_test.go",
"config_drift_windows_test.go",
"config_embedded_test.go",
@ -698,7 +664,6 @@ go_test(
"defer_wake_proxied_integration_test.go",
"defer_wake_server_test.go",
"delete_embedded_test.go",
"delete_exact_id_test.go",
"delete_if_revision_proxied_concurrency_test.go",
"delete_input_test.go",
"delete_proxied_integration_test.go",
@ -718,8 +683,6 @@ go_test(
"dependency_hierarchy_embedded_test.go",
"diff_embedded_test.go",
"directory_flag_test.go",
"discovery_refusal_pins_embedded_test.go",
"discovery_refusal_pins_test.go",
"doctor_backend_guard_test.go",
"doctor_check_gate_test.go",
"doctor_context_test.go",
@ -761,7 +724,6 @@ go_test(
"dolt_remote_add_test.go",
"dolt_remote_adopt_test.go",
"dolt_remote_json_test.go",
"dolt_remote_origin_guard_embedded_test.go",
"dolt_remote_origin_guard_test.go",
"dolt_remote_remove_proxied_integration_test.go",
"dolt_remote_reset_data_embedded_test.go",
@ -798,7 +760,6 @@ go_test(
"export_exclude_owner_test.go",
"export_max_rows_gate_test.go",
"export_proxied_integration_test.go",
"export_source_role_test.go",
"export_source_wisp_subset_test.go",
"export_test.go",
"external_policy_direct_integration_test.go",
@ -811,13 +772,10 @@ go_test(
"find_duplicates_test.go",
"flags_test.go",
"flatten_embedded_test.go",
"format_json_alias_embedded_test.go",
"formula_fixture_proxied_test.go",
"formula_help_test.go",
"formula_primitives_test.go",
"formula_schema_test.go",
"gate_add_waiter_contention_test.go",
"gate_check_listing_test.go",
"gate_check_proxied_integration_test.go",
"gate_discover_test.go",
"gate_embedded_test.go",
@ -844,8 +802,6 @@ go_test(
"graph_apply_thread_spawner_embedded_test.go",
"graph_embedded_test.go",
"graph_export_test.go",
"graph_mode_admission_e2e_test.go",
"graph_mode_dependency_embedded_test.go",
"graph_proxied_integration_test.go",
"graph_test.go",
"graph_visual_test.go",
@ -875,7 +831,6 @@ go_test(
"identity_preview_refusal_test.go",
"if_revision_embedded_test.go",
"if_revision_gc_matcher_embedded_test.go",
"if_revision_ordinary_cas_embedded_test.go",
"if_revision_proxied_close_delete_test.go",
"if_revision_proxied_integration_test.go",
"if_revision_reassign_fence_embedded_test.go",
@ -898,19 +853,14 @@ go_test(
"info_kv_exclusion_test.go",
"info_proxied_integration_test.go",
"info_test.go",
"init_agent_test.go",
"init_cancel_e2e_test.go",
"init_commit_test.go",
"init_embedded_test.go",
"init_explicit_beads_dir_embedded_test.go",
"init_external_autostart_test.go",
"init_external_message_test.go",
"init_gateway_test.go",
"init_git_bootstrap_routing_test.go",
"init_guard_force_e2e_test.go",
"init_guard_test.go",
"init_home_guard_cgo_test.go",
"init_home_guard_test.go",
"init_hooks_test.go",
"init_metrics_test.go",
"init_mode_inherit_test.go",
@ -953,8 +903,6 @@ go_test(
"legacy_upgrade_guard_e2e_test.go",
"legacy_upgrade_guard_empty_root_test.go",
"legacy_upgrade_guard_external_server_test.go",
"legacy_upgrade_guard_init_flag_e2e_test.go",
"legacy_upgrade_guard_init_flag_test.go",
"legacy_upgrade_guard_test.go",
"legacy_upgrade_guard_witness_test.go",
"linear_roundtrip_test.go",
@ -970,9 +918,6 @@ go_test(
"list_helpers_test.go",
"list_limit_policy_test.go",
"list_output_test.go",
"list_page_edges_embedded_test.go",
"list_page_edges_store_test.go",
"list_page_edges_test.go",
"list_proxied_integration_test.go",
"list_proxied_watch_max_rows_test.go",
"list_ready_brief_test.go",
@ -1019,9 +964,7 @@ go_test(
"mol_bond_gwn_test.go",
"mol_bond_proxied_integration_test.go",
"mol_bond_ref_attach_test.go",
"mol_bond_routing_test.go",
"mol_bond_test.go",
"mol_bond_var_validation_test.go",
"mol_burn_proxied_integration_test.go",
"mol_current_proxied_integration_test.go",
"mol_distill_proxied_integration_test.go",
@ -1035,7 +978,6 @@ go_test(
"mol_ready_gated_hint_test.go",
"mol_ready_gated_proxied_integration_test.go",
"mol_ready_gated_test.go",
"mol_route_parity_integration_test.go",
"mol_show_proxied_integration_test.go",
"mol_squash_embedded_test.go",
"mol_squash_proxied_integration_test.go",
@ -1059,7 +1001,6 @@ go_test(
"pour_unknown_vars_test.go",
"pour_wisp_var_validation_test.go",
"preflight_test.go",
"prime_disabled_test.go",
"prime_divergence_test.go",
"prime_embedded_test.go",
"prime_gemini_hook_test.go",
@ -1106,7 +1047,6 @@ go_test(
"ready_embedded_test.go",
"ready_explain_ids_test.go",
"ready_input_test.go",
"ready_json_no_total_test.go",
"ready_max_rows_proxied_test.go",
"ready_max_rows_test.go",
"ready_proxied_integration_test.go",
@ -1141,11 +1081,8 @@ go_test(
"restore_embedded_test.go",
"restore_test.go",
"root_context_lifecycle_test.go",
"routed_local_near_miss_test.go",
"routed_mutation_test.go",
"routed_test.go",
"routing_notice_test.go",
"routing_read_remote_test.go",
"routing_read_test.go",
"rules_test.go",
"sandbox_test.go",
@ -1153,9 +1090,6 @@ go_test(
"schema_test.go",
"search_embedded_test.go",
"search_proxied_integration_test.go",
"search_routes_embedded_test.go",
"search_routes_parity_test.go",
"search_routes_proxied_test.go",
"search_test.go",
"send_metrics_diagnostics_test.go",
"serve_batch_close_proxied_integration_test.go",
@ -1169,7 +1103,6 @@ go_test(
"serve_delete_proxied_integration_test.go",
"serve_dependencies_proxied_integration_test.go",
"serve_edge_counts_proxied_integration_test.go",
"serve_graph_mode_env_test.go",
"serve_inprocess_test.go",
"serve_list_sort_proxied_integration_test.go",
"serve_proxied_integration_test.go",
@ -1265,7 +1198,6 @@ go_test(
"test_helpers_test.go",
"test_repo_beads_guard_darwin_test.go",
"test_repo_beads_guard_test.go",
"test_repo_git_guard_test.go",
"test_wait_helper_test.go",
"thread_test.go",
"tips_example_test.go",
@ -1312,24 +1244,13 @@ go_test(
"version_embedded_test.go",
"version_test.go",
"version_tracking_test.go",
"versioned_history_construction_test.go",
"versioned_history_e2e_test.go",
"versioned_history_serve_e2e_test.go",
"versioned_history_switch_scan_embedded_test.go",
"versioned_history_switch_scan_proxied_integration_test.go",
"versioned_history_switch_test.go",
"versions_switch_embedded_test.go",
"versions_test.go",
"where_cgo_test.go",
"where_embedded_test.go",
"where_test.go",
"wisp_abandoned_test.go",
"wisp_gc_active_embedded_test.go",
"wisp_gc_cascade_age_test.go",
"wisp_gc_purge_closed_embedded_test.go",
"wisp_proxied_integration_test.go",
"wisp_test.go",
"workspace_format_guard_test.go",
"workspace_gate_test.go",
"workspace_identity_test.go",
"worktree_cmd_test.go",
@ -1346,11 +1267,9 @@ go_test(
],
data = glob(["testdata/**"]) + [
":bd_for_tests",
":compact_gc_fixture",
":go_srcs",
":preflight_go_fixture",
"//:bd_test_files",
"//:go_srcs",
"//cmd/bd/doctor:go_srcs",
"//cmd/bd/doctor/fix:go_srcs",
"//internal/storage/embeddeddolt/cmd:go_srcs",
@ -1360,7 +1279,6 @@ go_test(
env = {
"BEADS_TEST_BD_BINARY": "$(rlocationpath :bd_for_tests)",
"BEADS_TEST_GOFMT": "$(rlocationpath @go_sdk//:bin/gofmt)",
"BEADS_TEST_COMPACT_GC_FIXTURE": "$(rlocationpath :compact_gc_fixture)",
"BEADS_TEST_PREFLIGHT_GO": "$(rlocationpath :preflight_go_fixture)",
},
shard_count = 16,
@ -1383,10 +1301,6 @@ go_test(
"//internal/githooksenv",
"//internal/hooks",
"//internal/httpapi",
"//internal/httpclient",
"//internal/httpclient/encode",
"//internal/httpclient/wire",
"//internal/initprocs",
"//internal/linear",
"//internal/metrics",
"//internal/migration",
@ -1413,12 +1327,10 @@ go_test(
"//internal/storage/issueops",
"//internal/storage/journalscan",
"//internal/storage/kvkeys",
"//internal/storage/memoryops",
"//internal/storage/schema",
"//internal/storage/uow",
"//internal/storage/versioncontrolops",
"//internal/telemetry",
"//internal/templates/agents",
"//internal/testutil",
"//internal/testutil/bazeltest",
"//internal/testutil/credentialcmd",
@ -1491,7 +1403,7 @@ go_test(
)
# bd_embedded_test and bd_embedded_part2_test run the TestEmbedded* functions
# of cmd/bd's _test.go files between them: the manifest's 100-shard block
# of *_embedded_test.go between them: the manifest's 100-shard block
# (duration-balanced; see scripts/ci/embedded_cmd_test_durations.json) is
# more than Bazel's 50-shard cap per rule, so bd_embedded_test runs its
# shards 1-50 and bd_embedded_part2_test its shards 51-100
@ -1499,12 +1411,13 @@ go_test(
# check_shard_coverage.py fails unless the two ranges tile the block exactly
# once). Both run this configuration's bd_test with
# BEADS_TEST_EMBEDDED_DOLT=1 and the race bd (//cmd/bd:bd under
# --config=embedded) as the subprocess binary. PR Risk's legacy fork/push
# jobs, "Test (Embedded Dolt Cmd N/20)" (pr-risk.yml), which used to run 20
# shards of their own hand-assigned block in the same manifest file, no
# longer exist; the manifest now holds only this 100-shard block. Each
# repeats bd_test's `env` (the wrapper cannot inherit it). The two
# shard_counts must sum to --shard-total, the manifest block's shard total.
# --config=embedded) as the subprocess binary. This is a *different* shard
# count from PR Risk's legacy fork/push jobs, "Test (Embedded Dolt Cmd
# N/20)" (pr-risk.yml): those keep running 20 shards of their own, frozen
# hand-assigned block in the same manifest file — shard k here is not the
# same split as their shard k. Each repeats bd_test's `env` (the wrapper
# cannot inherit it). The two shard_counts must sum to --shard-total, the
# manifest block's shard total.
#
# Tags:
# embedded: the embedded-Dolt tier; excluded from --config=prcore/ci,
@ -1596,14 +1509,15 @@ sh_test(
# functions, assigned by the manifest's 34-shard block (duration-balanced;
# see scripts/ci/proxied_test_durations.json), against this configuration's
# (race) bd_test with BEADS_TEST_PROXIED_SERVER=1 and the non-race
# bd_for_tests as the subprocess binary. PR Risk's legacy fork/push jobs,
# "Test (Proxied Dolt Cmd N/15)" (pr-risk.yml), which used to run 15 shards
# of their own frozen bd-init-cost-proxy block in the same manifest file, no
# longer exist; the manifest now holds only this 34-shard block. The shared
# proxied harness gets its dolt sql-server from internal/testutil's local
# backend (the pinned dolt in the test wrapper's runfiles) instead of a
# container, and fails instead of skipping when it cannot start one. It
# repeats bd_test's `env`.
# bd_for_tests as the subprocess binary. This is a *different* shard count
# from PR Risk's legacy fork/push jobs, "Test (Proxied Dolt Cmd N/15)"
# (pr-risk.yml): those keep running 15 shards of their own,
# frozen bd-init-cost-proxy block in the same manifest file — shard k here
# is not the same split as their shard k. PR Risk builds its bd-cmd-test
# with -race, as here. The shared proxied harness gets its dolt sql-server from
# internal/testutil's local backend (the pinned dolt in the test
# wrapper's runfiles) instead of the jobs' container, and fails instead
# of skipping when it cannot start one. It repeats bd_test's `env`.
# shard_count must stay equal to the manifest block's shard total.
#
# Tags:
@ -1641,7 +1555,7 @@ sh_test(
"BEADS_TEST_REQUIRE_DOLT_CONTAINER": "1",
# The external-unix / outage-matrix subtests bridge endpoints with
# socat, which the workers have: fail rather than skip if it is
# missing (requireSocat). The retired GitHub lane left this unset.
# missing (requireSocat). The legacy GitHub lane leaves this unset.
"BEADS_TEST_REQUIRE_SOCAT": "1",
# The 4-vCPU runner shape: -test.parallel defaults to GOMAXPROCS, and
# the job runs 4 tests at once, not one per worker core (39
@ -1688,7 +1602,6 @@ sh_test(
data = [
":bd_for_tests",
":bd_test",
":compact_gc_fixture",
":go_srcs",
":preflight_go_fixture",
"@go_sdk//:bin/gofmt",
@ -1697,7 +1610,6 @@ sh_test(
"BEADS_TEST_BD_BINARY": "$(rlocationpath :bd_for_tests)",
"BEADS_TEST_DOLT_SERVER": "local",
"BEADS_TEST_GOFMT": "$(rlocationpath @go_sdk//:bin/gofmt)",
"BEADS_TEST_COMPACT_GC_FIXTURE": "$(rlocationpath :compact_gc_fixture)",
"BEADS_TEST_PREFLIGHT_GO": "$(rlocationpath :preflight_go_fixture)",
"BEADS_TEST_PROXIED_LOCAL": "1",
"BEADS_TEST_REQUIRE_DOLT_CONTAINER": "1",
@ -1734,27 +1646,18 @@ sh_test(
sh_test(
name = "bd_dolt_server_test",
size = "large",
# args' -test.timeout=19m fires (with a goroutine dump) before Bazel's
# 1200s action limit (eternal under the lane's --test_timeout), which
# kills without one.
# --config=doltserver-cmd's -test.timeout=19m fires (with a goroutine
# dump) before Bazel's 1200s action limit (eternal under the lane's
# --test_timeout), which kills without one.
timeout = "eternal",
srcs = ["//tools/bazel:go_test_pinned_shard.sh"],
args = [
"$(rootpath :dolt_server_pinned_shards.txt)",
"$(rootpath :bd_test)",
# Item 5 A2: moved from --config=doltserver-cmd's --test_arg
# (go_test_pinned_shard.sh forwards args after its own, so this
# lands last in argv, same as the config's --test_arg did). Go's own
# timeout fires first and dumps every goroutine to test.log, which
# Bazel's 1200s cap does not. The move keeps this out of
# --config=dolt-int, whose other member (server-storage) has a 15m
# Go timeout of its own.
"-test.timeout=19m",
],
data = [
":bd_for_tests",
":bd_test",
":compact_gc_fixture",
":dolt_server_pinned_shards.txt",
":preflight_go_fixture",
"@go_sdk//:bin/gofmt",
@ -1765,11 +1668,7 @@ sh_test(
# The integration jobs' global git identity (tools/bazel/test_env.sh).
"BEADS_TEST_GIT_IDENTITY": "1",
"BEADS_TEST_GOFMT": "$(rlocationpath @go_sdk//:bin/gofmt)",
"BEADS_TEST_COMPACT_GC_FIXTURE": "$(rlocationpath :compact_gc_fixture)",
"BEADS_TEST_PREFLIGHT_GO": "$(rlocationpath :preflight_go_fixture)",
# Item 5 A2: moved from --config=doltserver-cmd's --test_env, so
# --config=dolt-int does not set it for server-storage's targets too.
"BEADS_TEST_REQUIRE_EXCLUDE_PERMISSION": "1",
"BEADS_TEST_REQUIRE_DOLT_CONTAINER": "1",
# TestSharedServerConcurrent (skipped everywhere else) as a bounded
# smoke: 6 concurrent bd clients, 3 per database, against 2

View file

@ -1,310 +0,0 @@
//go:build cgo
package main
import (
"errors"
"fmt"
"os"
"os/exec"
"path/filepath"
"strings"
"testing"
"github.com/steveyegge/beads/internal/templates/agents"
)
// TestEmbeddedInitAgentArtifactsGolden pins the Claude agent artifacts a real
// `bd init` writes — .claude/settings.json with its hook events and commands,
// CLAUDE.md and AGENTS.md with their managed sections — and what
// `bd setup claude --check`, `--remove` and a reinstall then report and leave
// behind, through the bd binary. Each scenario is a transcript golden under
// testdata/agent_artifacts/, so a change to any artifact or outcome (a new
// hook event, a changed command, new template text and its hash) shows up as
// a reviewed golden diff.
//
// A managed section is shown by its BEGIN marker line (profile and hash) and a
// pointer to the internal/templates/agents golden that pins its bytes
// (TestManagedSectionGolden), after checking the file holds exactly that
// section; one that matches no rendered variant is shown in full. The
// in-process `bd setup claude` scenarios are pinned by
// TestClaudeSetupArtifactsGolden in cmd/bd/setup.
//
// The scenarios run a direct (embedded) bd init with no Dolt remote. Not
// pinned here: a proxied-server bd init, which installs no Codex section and
// decides HasRemote from its own remote URL; a bd init with a remote, which
// renders the managed section's with-remote variant; and the Cursor files.
// AGENTS.md is shown in full apart from its managed section, so a change to
// its wrapper text or its Codex section can pass the cmd/bd/setup and
// internal/templates/agents tests and fail only here.
//
// bd runs with HOME outside the project, so an artifact written to the home
// directory instead of the project shows up under $HOME.
//
// Regenerate with
//
// BEADS_TEST_EMBEDDED_DOLT=1 BD_UPDATE_GOLDEN=1 go test -tags gms_pure_go ./cmd/bd/ -run TestEmbeddedInitAgentArtifactsGolden
func TestEmbeddedInitAgentArtifactsGolden(t *testing.T) {
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt integration tests")
}
t.Parallel()
bd := buildEmbeddedBD(t)
scenarios := []struct {
name string
initArgs []string
steps [][]string
}{
{
name: "init-default",
initArgs: []string{"--prefix", "aa"},
steps: [][]string{
{"setup", "claude", "--check"},
{"setup", "claude"},
{"setup", "claude", "--remove"},
{"setup", "claude", "--check"},
{"setup", "claude"},
{"setup", "claude", "--check"},
},
},
{
name: "init-agents-profile-full",
initArgs: []string{"--prefix", "ab", "--agents-profile", "full"},
steps: [][]string{
{"setup", "claude", "--check"},
},
},
}
for _, sc := range scenarios {
t.Run(sc.name, func(t *testing.T) {
t.Parallel()
// bdInit, with HOME in a directory of its own.
dir, home := t.TempDir(), t.TempDir()
initGitRepoAt(t, dir)
database, seeded := seededInitDatabase(sc.initArgs)
if seeded {
seedEmbeddedSchema(t, dir, database)
}
initArgs := append([]string{"init", "--quiet"}, sc.initArgs...)
if stdout, stderr, exitCode := runAgentArtifactCommand(t, bd, dir, home, initArgs...); exitCode != 0 {
t.Fatalf("bd %s: exit %d\nstdout:\n%s\nstderr:\n%s", strings.Join(initArgs, " "), exitCode, stdout, stderr)
}
if seeded {
requireSeededEmbeddedInit(t, filepath.Join(dir, ".beads"), database)
}
var transcript strings.Builder
fmt.Fprintf(&transcript, "# bd init agent artifact transcript: %s\n", sc.name)
fmt.Fprintf(&transcript, "# Regenerate with BEADS_TEST_EMBEDDED_DOLT=1 BD_UPDATE_GOLDEN=1 go test -tags gms_pure_go ./cmd/bd/ -run TestEmbeddedInitAgentArtifactsGolden\n")
fmt.Fprintf(&transcript, "\n=== bd %s\n", strings.Join(initArgs, " "))
previous := map[string]string{}
writeAgentArtifactChanges(t, &transcript, dir, home, previous)
for _, args := range sc.steps {
stdout, stderr, exitCode := runAgentArtifactCommand(t, bd, dir, home, args...)
fmt.Fprintf(&transcript, "\n=== bd %s\n", strings.Join(args, " "))
fmt.Fprintf(&transcript, "exit: %d\n", exitCode)
writeAgentArtifactBlock(&transcript, "stdout", normalizeAgentArtifactOutput(stdout, dir, home))
writeAgentArtifactBlock(&transcript, "stderr", normalizeAgentArtifactOutput(stderr, dir, home))
writeAgentArtifactChanges(t, &transcript, dir, home, previous)
}
assertAgentArtifactGolden(t, filepath.Join("testdata", "agent_artifacts", sc.name+".golden"), transcript.String())
})
}
}
// agentArtifactPaths are the Claude agent artifacts bd init and bd setup
// claude write in a project ($PROJECT), and those in the home directory
// ($HOME): the $HOME/.claude/ files a global install writes, and the
// $HOME/CLAUDE.md an older --global run from $HOME wrote.
var agentArtifactPaths = []string{
"$PROJECT/.claude/settings.json",
"$PROJECT/.claude/settings.local.json",
"$PROJECT/AGENTS.md",
"$PROJECT/CLAUDE.md",
"$HOME/.claude/settings.json",
"$HOME/.claude/CLAUDE.md",
"$HOME/CLAUDE.md",
}
// agentArtifactManagedSections maps each managed section bd renders to the
// internal/templates/agents golden file that pins its bytes.
var agentArtifactManagedSections = []struct {
golden string
profile agents.Profile
opts agents.RenderOpts
}{
{golden: "managed-section-minimal.md", profile: agents.ProfileMinimal, opts: agents.RenderOpts{HasRemote: true}},
{golden: "managed-section-minimal-no-remote.md", profile: agents.ProfileMinimal, opts: agents.RenderOpts{}},
{golden: "managed-section-minimal-user.md", profile: agents.ProfileMinimal, opts: agents.UserLevelRenderOpts()},
{golden: "managed-section-full.md", profile: agents.ProfileFull, opts: agents.RenderOpts{HasRemote: true}},
{golden: "managed-section-full-no-remote.md", profile: agents.ProfileFull, opts: agents.RenderOpts{}},
{golden: "managed-section-full-user.md", profile: agents.ProfileFull, opts: agents.UserLevelRenderOpts()},
}
// elideAgentArtifactManagedSection replaces the body of a managed section
// that is byte-identical to a rendered variant with a pointer to that
// variant's golden, keeping the BEGIN marker line (profile and hash) and the
// END marker.
func elideAgentArtifactManagedSection(content string) string {
const endMarker = "<!-- END BEADS INTEGRATION -->\n"
begin := strings.Index(content, "<!-- BEGIN BEADS INTEGRATION")
if begin < 0 {
return content
}
rel := strings.Index(content[begin:], endMarker)
if rel < 0 {
return content
}
end := begin + rel + len(endMarker)
section := content[begin:end]
for _, v := range agentArtifactManagedSections {
if section == agents.RenderSectionWithOpts(v.profile, v.opts) {
marker, _, _ := strings.Cut(section, "\n")
return content[:begin] + marker + "\n[managed section body: byte-identical to internal/templates/agents/testdata/" + v.golden + "]\n" + endMarker + content[end:]
}
}
return content
}
// runAgentArtifactCommand runs bd in dir with HOME at home and returns its
// stdout, stderr and exit code.
func runAgentArtifactCommand(t *testing.T, bd, dir, home string, args ...string) (stdout, stderr string, exitCode int) {
t.Helper()
cmd := exec.Command(bd, args...)
cmd.Dir = dir
cmd.Env = agentArtifactEnv(dir, home)
outBuf, errBuf, err := runCommandBuffers(t, cmd)
if err != nil {
var exitErr *exec.ExitError
if !errors.As(err, &exitErr) {
t.Fatalf("bd %s: %v", strings.Join(args, " "), err)
}
exitCode = exitErr.ExitCode()
}
return outBuf.String(), errBuf.String(), exitCode
}
// agentArtifactEnv is bdEnv(dir) with HOME at home and without the caller's
// BD_OTEL_* and OTEL_* variables: bd warns on stderr about a legacy BD_OTEL_*
// one whether or not telemetry is on, and the transcript pins stderr byte for
// byte. (clearTelemetryEnv cannot be used: it calls t.Setenv, and these tests
// run in parallel.)
func agentArtifactEnv(dir, home string) []string {
var env []string
for _, e := range bdEnv(dir) {
if strings.HasPrefix(e, "BD_OTEL_") || strings.HasPrefix(e, "OTEL_") || strings.HasPrefix(e, "HOME=") {
continue
}
env = append(env, e)
}
return append(env, "HOME="+home)
}
// writeAgentArtifactChanges appends every artifact created, modified or
// deleted since previous (which it then updates), with its contents.
func writeAgentArtifactChanges(t *testing.T, b *strings.Builder, dir, home string, previous map[string]string) {
t.Helper()
roots := strings.NewReplacer("$PROJECT", dir, "$HOME", home)
changed := false
for _, path := range agentArtifactPaths {
data, err := os.ReadFile(filepath.FromSlash(roots.Replace(path)))
before, existed := previous[path]
switch {
case os.IsNotExist(err):
if existed {
fmt.Fprintf(b, "--- files: deleted %s\n", path)
delete(previous, path)
changed = true
}
case err != nil:
t.Fatalf("read %s: %v", path, err)
case !existed || before != string(data):
verb := "created"
if existed {
verb = "modified"
}
shown := string(data)
if strings.HasSuffix(path, ".md") {
shown = elideAgentArtifactManagedSection(shown)
}
writeAgentArtifactBlock(b, fmt.Sprintf("files: %s %s", verb, path), shown)
previous[path] = string(data)
changed = true
}
}
if !changed {
b.WriteString("--- files: unchanged\n")
}
}
// writeAgentArtifactBlock appends a titled block, marking empty content and a
// missing trailing newline so neither is lost in the golden.
func writeAgentArtifactBlock(b *strings.Builder, title, content string) {
fmt.Fprintf(b, "--- %s\n", title)
switch {
case content == "":
b.WriteString("(empty)\n")
case !strings.HasSuffix(content, "\n"):
b.WriteString(content)
b.WriteString("\n(no newline at end of file)\n")
default:
b.WriteString(content)
}
}
// normalizeAgentArtifactOutput replaces the project and home directories (as
// given and with symlinks resolved, since bd reports the paths it sees) with
// $PROJECT and $HOME and uses forward slashes, so the transcript is the same
// on every host.
func normalizeAgentArtifactOutput(s, dir, home string) string {
for _, root := range []struct{ path, label string }{{dir, "$PROJECT"}, {home, "$HOME"}} {
if resolved, err := filepath.EvalSymlinks(root.path); err == nil && resolved != root.path {
s = strings.ReplaceAll(s, resolved, root.label)
}
s = strings.ReplaceAll(s, root.path, root.label)
}
if filepath.Separator != '/' {
s = strings.ReplaceAll(s, string(filepath.Separator), "/")
}
return s
}
// assertAgentArtifactGolden compares got with the golden file at path, or
// rewrites the file when BD_UPDATE_GOLDEN=1.
func assertAgentArtifactGolden(t *testing.T, path, got string) {
t.Helper()
if os.Getenv("BD_UPDATE_GOLDEN") == "1" {
if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
t.Fatalf("mkdir %s: %v", filepath.Dir(path), err)
}
if err := os.WriteFile(path, []byte(got), 0o644); err != nil {
t.Fatalf("write golden %s: %v", path, err)
}
t.Logf("updated golden %s", path)
return
}
want, err := os.ReadFile(path)
if err != nil {
t.Fatalf("read golden %s (regenerate with BD_UPDATE_GOLDEN=1): %v", path, err)
}
if got == string(want) {
return
}
wantLines, gotLines := strings.Split(string(want), "\n"), strings.Split(got, "\n")
line := func(lines []string, i int) string {
if i >= len(lines) {
return "(end of output)"
}
return fmt.Sprintf("%q", lines[i])
}
i := 0
for i < len(wantLines) && i < len(gotLines) && wantLines[i] == gotLines[i] {
i++
}
t.Errorf("bd init agent artifacts drifted from %s (regenerate with BD_UPDATE_GOLDEN=1 if intended)\nfirst difference at line %d:\n want: %s\n got: %s\n--- got ---\n%s", path, i+1, line(wantLines, i), line(gotLines, i), got)
}

View file

@ -63,12 +63,6 @@ Examples:
if result != nil {
result.Close()
}
// A concurrent `bd delete` that commits before this resolution
// is the same lost race as one that commits inside the guarded
// write below.
if reported, ok := reportIfRevisionTargetGone("assigning", id, err, ifRevision); ok {
return reported
}
return HandleErrorRespectJSON("resolving %s: %v", id, err)
}
if result == nil || result.Issue == nil {

View file

@ -43,7 +43,7 @@ func bdRunOK(t *testing.T, bd, dir string, args ...string) string {
return string(out)
}
// TestEmbeddedReassignFenceCLI drives the bd-98s5c live-claim reassign fence
// TestReassignFenceCLI drives the bd-98s5c live-claim reassign fence
// end-to-end: plain `bd update -a` and `bd assign` were the last unfenced
// cross-actor takeover path (--claim, unclaim, and close all refuse without
// --force). The fence must refuse ONLY the silent steamroll — a different
@ -51,7 +51,7 @@ func bdRunOK(t *testing.T, bd, dir string, args ...string) string {
// leave routine dispatch untouched: open-bead reassigns, self-edits,
// idempotent re-asserts, pool-alias takes, and holder-aware --if-assignee
// transfers all proceed without --force.
func TestEmbeddedReassignFenceCLI(t *testing.T) {
func TestReassignFenceCLI(t *testing.T) {
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt integration tests")
}

View file

@ -12,23 +12,10 @@ import (
// the rejection inspects it (read-only) so a workspace that already holds a Dolt
// database is told to fix the stale "backend" value rather than to export and
// reinitialize. Pass "" only where there is genuinely no workspace directory.
//
// It also refuses metadata that declares a workspace format this build cannot
// open (checkWorkspaceFormat). Command admission refuses those first, and the
// store factories check before their migrating configfile.Load
// (checkDiscoveredWorkspaceFormat), so here it backs up any other caller that
// validates metadata it loaded itself. It returns early for a nil cfg, so that
// backstop covers the graph format marker only when metadata was loaded; a
// caller that may have none must check beadsDir with
// checkDiscoveredWorkspaceFormat or command admission first, as every caller
// does today.
func validateConfiguredBackend(cfg *configfile.Config, beadsDir string) error {
if cfg == nil {
return nil
}
if err := checkWorkspaceFormat(cfg, beadsDir); err != nil {
return err
}
if backends.Registered(cfg.Backend) {
return nil
}
@ -93,16 +80,14 @@ func openStoreError(backendName string, err error) error {
return fmt.Errorf("failed to open database: %w", err)
}
// backendNameForErrorFraming best-effort reads metadata.json to learn which
// backendNameForErrorFraming best-effort loads metadata.json to learn which
// backend a failed open was for, so a caller that does not already have cfg
// in scope (for example direct mode's single-shot store-open) can still give
// openStoreError the name it needs. A failure to even read the config
// degrades to "" — openStoreError's default, Dolt-shaped framing — rather
// than compounding one error with another. It reads with LoadForDiscovery:
// the open it frames may have just refused the workspace, and
// configfile.Load would migrate a legacy config.json into metadata.json.
// than compounding one error with another.
func backendNameForErrorFraming(beadsDir string) string {
cfg, err := configfile.LoadForDiscovery(beadsDir)
cfg, err := configfile.Load(beadsDir)
if err != nil || cfg == nil {
return ""
}
@ -110,12 +95,6 @@ func backendNameForErrorFraming(beadsDir string) string {
}
func loadDoltBackendConfig(beadsDir string) (*configfile.Config, error) {
// Refuse a workspace format this build cannot open before configfile.Load,
// which would otherwise migrate a legacy config.json into metadata.json
// before requireDoltBackend's own format check could refuse it.
if err := checkDiscoveredWorkspaceFormat(beadsDir); err != nil {
return nil, err
}
cfg, err := configfile.Load(beadsDir)
if err != nil {
return nil, fmt.Errorf("loading config: %w", err)

View file

@ -53,8 +53,6 @@ After adding, run 'bd backup sync' to push your data.`,
SilenceUsage: true,
SilenceErrors: true,
RunE: func(cmd *cobra.Command, args []string) error {
CheckReadonly("backup init")
evt := metrics.NewCommandEvent("backup-init")
defer func() {
if c := metrics.Global(); c != nil {
@ -136,8 +134,6 @@ Run 'bd backup init <path>' first to configure a destination.`,
SilenceUsage: true,
SilenceErrors: true,
RunE: func(cmd *cobra.Command, args []string) error {
CheckReadonly("backup sync")
evt := metrics.NewCommandEvent("backup-sync")
defer func() {
if c := metrics.Global(); c != nil {
@ -443,8 +439,6 @@ backup configuration. The backup data at the destination is not deleted.`,
SilenceUsage: true,
SilenceErrors: true,
RunE: func(cmd *cobra.Command, args []string) error {
CheckReadonly("backup remove")
evt := metrics.NewCommandEvent("backup-remove")
defer func() {
if c := metrics.Global(); c != nil {

View file

@ -217,78 +217,3 @@ func TestEmbeddedBackupConcurrent(t *testing.T) {
t.Error("backup destination should exist after concurrent syncs")
}
}
// TestEmbeddedBackupRestoreStrictReadonly pins the refusal of a strict
// --readonly restore. A restore replaces the store, so CheckReadonly must stop
// it with the standard message before the command takes the exclusive workspace
// gate. Embedded mode used to be stopped only by the storage layer
// ("embeddeddolt: store is read-only"), after the gate had already left its
// holder files in the workspace. The control proves the fixture really does
// restore when --readonly is not asked for, so "the store is unchanged" below
// cannot be vacuous.
func TestEmbeddedBackupRestoreStrictReadonly(t *testing.T) {
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt backup tests")
}
t.Parallel()
bd := buildEmbeddedBD(t)
// newWorkspace returns a workspace whose live store holds one issue its
// backup does not (three against two), so a restore that really ran shows up
// as a changed issue count. Each case gets its own: a restore that runs
// replaces the store and would hide a leak from the next.
newWorkspace := func(t *testing.T, prefix string) (dir, backupDir string) {
t.Helper()
dir, _, _ = bdInit(t, bd, "--prefix", prefix)
bdCreateSilent(t, bd, dir, "issue in the backup A")
bdCreateSilent(t, bd, dir, "issue in the backup B")
backupDir = filepath.Join(t.TempDir(), "dolt-backup")
if err := os.MkdirAll(backupDir, 0o750); err != nil {
t.Fatal(err)
}
bdBackup(t, bd, dir, "init", "file://"+backupDir)
bdBackup(t, bd, dir, "sync")
bdCreateSilent(t, bd, dir, "issue created after the backup")
return dir, backupDir
}
t.Run("control_restore_without_readonly", func(t *testing.T) {
dir, backupDir := newWorkspace(t, "rrctl")
stdout, stderr, code := runBDMigrationFreeze(t, bd, dir, "backup", "restore", "--force", backupDir)
if code != 0 {
t.Fatalf("restore without --readonly exited %d\nstdout:\n%s\nstderr:\n%s", code, stdout, stderr)
}
if !strings.Contains(stdout, "Restore complete") {
t.Errorf("stdout is missing %q:\n%s", "Restore complete", stdout)
}
if got := len(bdListJSON(t, bd, dir)); got != 2 {
t.Errorf("issue count after a real restore = %d, want 2: the backup holds two issues and the live store held three", got)
}
})
for _, tc := range []struct {
name string
prefix string
flags []string
}{
{"readonly", "rrro", []string{"--readonly"}},
{"readonly_sandbox", "rrrosb", []string{"--readonly", "--sandbox"}},
} {
t.Run(tc.name, func(t *testing.T) {
dir, backupDir := newWorkspace(t, tc.prefix)
before := snapshotWorkspace(t, dir)
args := append(append([]string{}, tc.flags...), "backup", "restore", "--force", backupDir)
stdout, stderr, code := runBDMigrationFreeze(t, bd, dir, args...)
assertStrictReadonlyRestoreRefused(t, stdout, stderr, code)
assertWorkspaceUnchanged(t, dir, before)
if got := len(bdListJSON(t, bd, dir)); got != 3 {
t.Errorf("issue count after the refused restore = %d, want 3: the restore replaced the store", got)
}
})
}
}

View file

@ -34,8 +34,6 @@ To initialize and restore in one step, use: bd init && bd backup restore`,
SilenceUsage: true,
SilenceErrors: true,
RunE: func(cmd *cobra.Command, args []string) error {
CheckReadonly("backup restore")
evt := metrics.NewCommandEvent("backup-restore")
defer func() {
if c := metrics.Global(); c != nil {

View file

@ -4,22 +4,14 @@ package main
import (
"context"
"encoding/json"
"fmt"
"os"
"path/filepath"
"slices"
"sort"
"strings"
"testing"
"time"
"github.com/steveyegge/beads/internal/beads"
"github.com/steveyegge/beads/internal/configfile"
"github.com/steveyegge/beads/internal/git"
"github.com/steveyegge/beads/internal/storage/dolt"
"github.com/steveyegge/beads/internal/testutil"
"github.com/steveyegge/beads/internal/types"
)
func TestBackupRestoreMissingDir(t *testing.T) {
@ -92,257 +84,3 @@ func TestSyncProjectIDFromDB_NoWorkspaceUsesActiveWorkspaceError(t *testing.T) {
t.Fatalf("syncProjectIDFromDB should not create local .beads, stat err = %v", statErr)
}
}
// strictReadonlyRestoreRefusal is the line CheckReadonly prints when a write
// command is run under strict --readonly.
const strictReadonlyRestoreRefusal = "Error: operation 'backup restore' is not allowed in read-only mode\n"
// assertStrictReadonlyRestoreRefused checks one refused `bd --readonly backup
// restore` run: the standard CheckReadonly refusal (text and exit code), nothing
// on stdout, and none of the storage-layer message that embedded mode gives when
// the command gets past CheckReadonly and opens the store.
func assertStrictReadonlyRestoreRefused(t *testing.T, stdout, stderr string, code int) {
t.Helper()
if code != 1 {
t.Errorf("exit code = %d, want 1\nstdout:\n%s\nstderr:\n%s", code, stdout, stderr)
}
if !strings.Contains(stderr, strictReadonlyRestoreRefusal) {
t.Errorf("stderr is missing the standard refusal %q:\n%s", strictReadonlyRestoreRefusal, stderr)
}
if strings.Contains(stderr, "embeddeddolt: store is read-only") {
t.Errorf("stderr carries the storage-layer refusal, so the command opened the store before being refused:\n%s", stderr)
}
if strings.TrimSpace(stdout) != "" {
t.Errorf("stdout should be empty when the restore is refused, got:\n%s", stdout)
}
}
// workspaceSnapshot is what a refused command must leave alone: the entries of
// the project directory (the workspace gate file and its holder sidecar sit
// beside .beads, not in it) and everything below .beads, content included.
type workspaceSnapshot struct {
projectEntries []string
beads readonlyTreeSnapshot
}
func snapshotWorkspace(t *testing.T, dir string) workspaceSnapshot {
t.Helper()
entries, err := os.ReadDir(dir)
if err != nil {
t.Fatal(err)
}
names := make([]string, 0, len(entries))
for _, e := range entries {
names = append(names, e.Name())
}
return workspaceSnapshot{
projectEntries: names,
beads: snapshotReadonlyTree(t, filepath.Join(dir, ".beads")),
}
}
// assertWorkspaceUnchanged fails, naming each path, when the workspace under dir
// no longer matches a snapshot taken before a refused command.
func assertWorkspaceUnchanged(t *testing.T, dir string, before workspaceSnapshot) {
t.Helper()
after := snapshotWorkspace(t, dir)
var diffs []string
for _, name := range before.projectEntries {
if !slices.Contains(after.projectEntries, name) {
diffs = append(diffs, "removed: "+name)
}
}
for _, name := range after.projectEntries {
if !slices.Contains(before.projectEntries, name) {
diffs = append(diffs, "created: "+name)
}
}
for path, want := range before.beads.Entries {
switch got, ok := after.beads.Entries[path]; {
case !ok:
diffs = append(diffs, "removed: .beads/"+path)
case got != want:
diffs = append(diffs, "changed: .beads/"+path)
}
}
for path := range after.beads.Entries {
if _, ok := before.beads.Entries[path]; !ok {
diffs = append(diffs, "created: .beads/"+path)
}
}
if len(diffs) == 0 {
return
}
sort.Strings(diffs)
const show = 20
if len(diffs) > show {
diffs = append(diffs[:show], fmt.Sprintf("... and %d more", len(diffs)-show))
}
t.Errorf("the refused restore changed the workspace:\n%s", strings.Join(diffs, "\n"))
}
// TestBackupRestoreStrictReadonlyServerMode is the server-mode counterpart of
// TestEmbeddedBackupRestoreStrictReadonly. Server mode is where the missing
// refusal mattered: no storage layer stops a server connection, so a
// `bd --readonly backup restore --force` ran to the end and replaced the store.
// It drives the built bd as a subprocess because CheckReadonly exits the
// process. Both the fixture's backup and the restore run inside the Dolt
// server, against the same path on the server's own filesystem, so a local
// and a containerized test server both serve.
func TestBackupRestoreStrictReadonlyServerMode(t *testing.T) {
if testDoltServerPort == 0 {
t.Skip("Dolt test server not available")
}
if testutil.DoltContainerCrashed() {
t.Skipf("Dolt test server crashed: %v", testutil.DoltContainerCrashError())
}
bd := buildBDForInitTests(t)
// newWorkspace builds a server-mode workspace on the test server whose live
// store holds one issue its backup does not (three against two), so a restore
// that really ran shows up as a changed issue count. Each case gets its own: a
// restore that runs replaces the store and would hide a leak from the next.
newWorkspace := func(t *testing.T) (dir string, env []string, backupDir string) {
t.Helper()
dir = t.TempDir()
beadsDir := filepath.Join(dir, ".beads")
if err := os.MkdirAll(beadsDir, 0o700); err != nil {
t.Fatal(err)
}
database := uniqueTestDBName(t)
if err := (&configfile.Config{
Backend: configfile.BackendDolt,
DoltMode: configfile.DoltModeServer,
DoltServerHost: "127.0.0.1",
DoltServerPort: testDoltServerPort,
DoltDatabase: database,
}).Save(beadsDir); err != nil {
t.Fatalf("save workspace metadata: %v", err)
}
ctx := context.Background()
seedStore, err := dolt.New(ctx, &dolt.Config{
Path: filepath.Join(beadsDir, "dolt"),
BeadsDir: beadsDir,
ServerHost: "127.0.0.1",
ServerPort: testDoltServerPort,
Database: database,
CreateIfMissing: true,
})
if err != nil {
t.Fatalf("create the server-mode database: %v", err)
}
t.Cleanup(func() { dropTestDatabase(database, testDoltServerPort) })
defer func() { _ = seedStore.Close() }()
if err := seedStore.SetConfig(ctx, "issue_prefix", "rr"); err != nil {
t.Fatalf("set issue_prefix: %v", err)
}
seed := func(id, title string) {
t.Helper()
now := time.Now()
issue := &types.Issue{
ID: id,
Title: title,
Status: types.StatusOpen,
Priority: 2,
IssueType: types.TypeTask,
CreatedAt: now,
UpdatedAt: now,
}
if err := seedStore.CreateIssue(ctx, issue, "test-user"); err != nil {
t.Fatalf("create issue %s: %v", id, err)
}
}
commit := func(message string) {
t.Helper()
if err := seedStore.Commit(ctx, message); err != nil && !strings.Contains(err.Error(), "nothing to commit") {
t.Fatalf("commit %q: %v", message, err)
}
}
seed("rr-1", "issue in the backup A")
seed("rr-2", "issue in the backup B")
commit("issues the backup holds")
backupDir = filepath.Join(t.TempDir(), "dolt-backup")
if err := os.MkdirAll(backupDir, 0o750); err != nil {
t.Fatal(err)
}
if err := seedStore.BackupDatabase(ctx, backupDir); err != nil {
t.Fatalf("back up the database (the Dolt server must be able to write %s): %v", backupDir, err)
}
seed("rr-3", "issue created after the backup")
commit("issue the backup lacks")
env = []string{
"BEADS_TEST_MODE=1",
// The subprocess connects to a testdb_* database on the test server;
// this is the opt-in the test-database firewall asks for.
"BEADS_TEST_SERVER=1",
"BEADS_DIR=" + beadsDir,
"XDG_CONFIG_HOME=" + t.TempDir(),
// Keep the subprocess's circuit-breaker state in the suite's own
// directory rather than the host's temp dir.
"BEADS_TEST_CIRCUIT_DIR=" + os.Getenv("BEADS_TEST_CIRCUIT_DIR"),
}
return dir, env, backupDir
}
issueCount := func(t *testing.T, dir string, env []string) int {
t.Helper()
stdout, stderr, code := runBDMigrationFreezeWithEnv(t, bd, dir, env, "list", "--json")
if code != 0 {
t.Fatalf("bd list --json exited %d\nstdout:\n%s\nstderr:\n%s", code, stdout, stderr)
}
start := strings.Index(stdout, "[")
if start < 0 {
t.Fatalf("no JSON array in bd list --json output:\n%s", stdout)
}
var issues []json.RawMessage
if err := json.Unmarshal([]byte(stdout[start:]), &issues); err != nil {
t.Fatalf("parse bd list --json output: %v\n%s", err, stdout)
}
return len(issues)
}
// The control proves the fixture really does restore when --readonly is not
// asked for, so "the store is unchanged" below cannot be vacuous.
t.Run("control_restore_without_readonly", func(t *testing.T) {
dir, env, backupDir := newWorkspace(t)
stdout, stderr, code := runBDMigrationFreezeWithEnv(t, bd, dir, env, "backup", "restore", "--force", backupDir)
if code != 0 {
t.Fatalf("restore without --readonly exited %d\nstdout:\n%s\nstderr:\n%s", code, stdout, stderr)
}
if !strings.Contains(stdout, "Restore complete") {
t.Errorf("stdout is missing %q:\n%s", "Restore complete", stdout)
}
if got := issueCount(t, dir, env); got != 2 {
t.Errorf("issue count after a real restore = %d, want 2: the backup holds two issues and the live store held three", got)
}
})
for _, tc := range []struct {
name string
flags []string
}{
{"readonly", []string{"--readonly"}},
{"readonly_sandbox", []string{"--readonly", "--sandbox"}},
} {
t.Run(tc.name, func(t *testing.T) {
dir, env, backupDir := newWorkspace(t)
before := snapshotWorkspace(t, dir)
args := append(append([]string{}, tc.flags...), "backup", "restore", "--force", backupDir)
stdout, stderr, code := runBDMigrationFreezeWithEnv(t, bd, dir, env, args...)
assertStrictReadonlyRestoreRefused(t, stdout, stderr, code)
assertWorkspaceUnchanged(t, dir, before)
if got := issueCount(t, dir, env); got != 3 {
t.Errorf("issue count after the refused restore = %d, want 3: the restore replaced the store", got)
}
})
}
}

View file

@ -234,7 +234,7 @@ func TestEmbeddedBlockedLabelFilters(t *testing.T) {
}
})
// the blocked role normalizes, as every sibling label filter does.
// blockedFilterFromFlags normalizes, as every sibling label filter does.
// Without it an untrimmed value returns nothing and is indistinguishable
// from "nothing blocked carries that label".
t.Run("leading_space_is_trimmed_like_every_other_label_filter", func(t *testing.T) {

View file

@ -1,167 +0,0 @@
package main
import (
"bufio"
"context"
"fmt"
"io"
"strings"
"github.com/spf13/cobra"
"github.com/steveyegge/beads/internal/storage"
"github.com/steveyegge/beads/internal/storage/uow"
"github.com/steveyegge/beads/issueops"
)
// blockedFlagRow is one line of `bd blocked --flags --json`: an id the caller
// named and the blocked flag bd holds for it.
type blockedFlagRow struct {
ID string `json:"id"`
IsBlocked bool `json:"is_blocked"`
}
// blockedFlagFilterFlags are the listing's filters, which --flags does not
// take: it answers about the ids it is handed, not about a set it derives.
var blockedFlagFilterFlags = []string{"parent", "label", "label-any", "exclude-label"}
// runBlockedFlags is `bd blocked --flags`: the blocked flag for each id read
// from stdin (one per line; blank lines and repeats ignored), through the
// issueops.BlockedFlags library entry over the route's BlockingAnnotator.
//
// IT IS THE FLAG, NOT THE LISTING. The listing narrows the stored flag to
// rows bd can name a blocker for; this answers the flag itself, the column
// `bd ready` filters on, so a row whose flag is set with no nameable blocker
// reads true here and is absent from the listing. Where the
// external-dependency policy applies, an unsatisfied external: blocker sets
// the flag as it keeps the row out of `bd ready`.
//
// Every id that names a row on either plane is answered, in the order the ids
// were first given, a closed row included (its flag is whatever is stored);
// an id naming no row is omitted. Over HTTP the read is
// listBlockingAnnotations with is_blocked, behind
// dependencies.blocking.isBlocked; a server without that token is refused
// before the dial, naming it.
//
// --raw answers the stored column itself, without the external-dependency
// decoration (blockedFlagsAnnotator): exactly what reading is_blocked from
// the issues and wisps tables returns.
func runBlockedFlags(cmd *cobra.Command, ctx context.Context, in io.Reader) error {
for _, name := range blockedFlagFilterFlags {
if cmd.Flags().Changed(name) {
return HandleErrorRespectJSON("--flags answers the ids read from stdin and takes no --%s", name)
}
}
ids, err := readBlockedFlagIDs(in)
if err != nil {
return HandleErrorRespectJSON("reading ids from stdin: %v", err)
}
raw, _ := cmd.Flags().GetBool("raw")
annotator, err := blockedFlagsAnnotator(ctx, raw)
if err != nil {
return HandleErrorRespectJSON("%v", err)
}
flags, err := issueops.BlockedFlags(ctx, annotator, ids)
if err != nil {
return HandleErrorRespectJSON("%v", err)
}
rows := make([]blockedFlagRow, 0, len(flags))
seen := make(map[string]bool, len(ids))
for _, id := range ids {
blocked, ok := flags[id]
if !ok || seen[id] {
continue
}
seen[id] = true
rows = append(rows, blockedFlagRow{ID: id, IsBlocked: blocked})
}
if jsonOutput {
return outputJSON(rows)
}
for _, row := range rows {
state := "not blocked"
if row.IsBlocked {
state = "blocked"
}
fmt.Printf("%s\t%s\n", row.ID, state)
}
return nil
}
// readBlockedFlagIDs reads one id per line, trimmed, skipping blank lines.
func readBlockedFlagIDs(in io.Reader) ([]string, error) {
var ids []string
scanner := bufio.NewScanner(in)
scanner.Buffer(make([]byte, 0, 64*1024), 1024*1024)
for scanner.Scan() {
if id := strings.TrimSpace(scanner.Text()); id != "" {
ids = append(ids, id)
}
}
return ids, scanner.Err()
}
// blockedFlagsAnnotator is the BlockingAnnotator for the route this
// invocation runs: the store's own accessor on the direct routes (dolt,
// embedded dolt, HTTP), and the proxied-server provider's on the proxied one.
// Both carry the external-dependency decoration the rest of bd reads through.
//
// With raw it is the same role taken from BENEATH every decorator (the
// innermost store, the innermost provider), so the answer is the stored
// is_blocked column and nothing else: an unsatisfied external: blocker does
// not set it, because the column has never known about other projects.
func blockedFlagsAnnotator(ctx context.Context, raw bool) (issueops.BlockingAnnotator, error) {
if !raw {
if usesProxiedServer() {
return proxiedBlockingAnnotator()
}
if store == nil {
return nil, fmt.Errorf("no storage available")
}
return store.BlockingAnnotator()
}
if usesProxiedServer() {
if uowProvider == nil {
return nil, fmt.Errorf("proxied-server UOW provider not initialized")
}
src, ok := uow.UnwrapProvider(uowProvider).(uow.BlockingAnnotatorSource)
if !ok {
return nil, fmt.Errorf("proxied-server provider %T does not offer the blocking-decoration surface", uowProvider)
}
return src.BlockingAnnotator()
}
if store == nil {
return nil, fmt.Errorf("no storage available")
}
base := storage.UnwrapStore(store)
if err := refuseRawFlagsFromAPolicyServer(ctx, base); err != nil {
return nil, err
}
return base.BlockingAnnotator()
}
// refuseRawFlagsFromAPolicyServer refuses --raw against a served workspace
// whose server applies the external-dependency policy itself
// (policy.external_dependencies). That server's blocking annotation already
// sets the flag for an unsatisfied external: blocker, the v0 wire has no
// member that asks it for the bare column, and the decorated flag cannot be
// turned back into the column on this side (a row that is externally blocked
// may or may not also carry the stored flag). Answering anyway would be the
// decorated flag spelled as the raw one. Against a server that does not apply
// the policy, its annotation IS the column, and --raw is served.
func refuseRawFlagsFromAPolicyServer(ctx context.Context, base storage.DoltStorage) error {
prober, ok := base.(storage.ExternalDependencyPolicyProber)
if !ok {
return nil
}
enforced, err := prober.ServerEnforcesExternalDependencyPolicy(ctx)
if err != nil {
return err
}
if enforced {
return fmt.Errorf("bd blocked --flags --raw is not served by this workspace's server: it applies the " +
"external-dependency policy (policy.external_dependencies) to the blocked flag it answers, and the v0 " +
"wire cannot ask it for the stored column; use bd blocked --flags (the policy-aware flag)")
}
return nil
}

View file

@ -1,57 +0,0 @@
package main
import (
"slices"
"testing"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
)
// TestBlockedFlagsRefusesEveryListingFilter pins blockedFlagFilterFlags to the
// flags blockedCmd registers. --flags answers the ids read from stdin, so a
// listing filter it does not refuse is silently ignored: a filter added to
// blockedCmd but not to the refusal list would answer every id while the
// caller believes the answer was narrowed. The reverse direction catches an
// entry naming no registered flag, which Changed never reports as set.
//
// It walks Flags() and PersistentFlags() with VisitAll, not LocalFlags(),
// which would merge the root's persistent flags into blockedCmd for the rest
// of the process (see TestNoSubcommandShadowsRootJSONFlag). A root flag that
// an earlier in-process run already merged in is skipped by identity, and
// cobra's own --help by its annotation.
func TestBlockedFlagsRefusesEveryListingFilter(t *testing.T) {
// The flags --flags itself reads: the mode switch and its qualifier.
modeFlags := []string{"flags", "raw"}
var registered []string
visit := func(f *pflag.Flag) {
if f == rootCmd.PersistentFlags().Lookup(f.Name) || len(f.Annotations[cobra.FlagSetByCobraAnnotation]) > 0 {
return
}
if !slices.Contains(registered, f.Name) {
registered = append(registered, f.Name)
}
}
blockedCmd.PersistentFlags().VisitAll(visit)
blockedCmd.Flags().VisitAll(visit)
for _, name := range modeFlags {
if !slices.Contains(registered, name) {
t.Errorf("blockedCmd registers no --%s; this test's mode flags are stale", name)
}
}
for _, name := range registered {
if !slices.Contains(modeFlags, name) && !slices.Contains(blockedFlagFilterFlags, name) {
t.Errorf("--%s is registered on blockedCmd but --flags does not refuse it: add it to blockedFlagFilterFlags, or to this test's mode flags if --flags reads it", name)
}
}
for _, name := range blockedFlagFilterFlags {
if slices.Contains(modeFlags, name) {
t.Errorf("blockedFlagFilterFlags refuses --%s, which --flags itself reads", name)
}
if !slices.Contains(registered, name) {
t.Errorf("blockedFlagFilterFlags names --%s, which blockedCmd does not register", name)
}
}
}

View file

@ -5,8 +5,6 @@ package main
import (
"bytes"
"encoding/json"
"os/exec"
"slices"
"strings"
"testing"
@ -83,68 +81,6 @@ func TestProxiedServerBlocked(t *testing.T) {
}
})
t.Run("flags_reads_ids_from_stdin", func(t *testing.T) {
t.Parallel()
p := newSharedProxiedProject(t, bd, "bkf")
blocker := bdProxiedCreate(t, bd, p.dir, "Flag blocker")
dependent := bdProxiedCreate(t, bd, p.dir, "Flag dependent", "--deps", "depends-on:"+blocker.ID)
cmd := exec.Command(bd, "blocked", "--flags", "--json")
cmd.Dir = p.dir
cmd.Env = bdProxiedEnv(p.dir)
cmd.Stdin = strings.NewReader(dependent.ID + "\n" + blocker.ID + "\nbk-no-such-row\n")
var stdout, stderr bytes.Buffer
cmd.Stdout, cmd.Stderr = &stdout, &stderr
if err := cmd.Run(); err != nil {
t.Fatalf("bd blocked --flags --json: %v\nstdout:\n%s\nstderr:\n%s", err, stdout.String(), stderr.String())
}
var rows []struct {
ID string `json:"id"`
IsBlocked bool `json:"is_blocked"`
}
if err := json.Unmarshal(bytes.TrimSpace(stdout.Bytes()), &rows); err != nil {
t.Fatalf("parse: %v\n%s", err, stdout.String())
}
if len(rows) != 2 || rows[0].ID != dependent.ID || !rows[0].IsBlocked || rows[1].ID != blocker.ID || rows[1].IsBlocked {
t.Errorf("rows = %+v, want [{%s true} {%s false}] (unknown id omitted)", rows, dependent.ID, blocker.ID)
}
})
t.Run("flags_raw_is_the_stored_column", func(t *testing.T) {
t.Parallel()
p := newSharedProxiedProject(t, bd, "bkr")
ext := bdProxiedCreate(t, bd, p.dir, "Externally blocked only")
if _, stderr, err := bdProxiedRunBuffers(t, bd, p.dir, "dep", "add", ext.ID, "external:otherproj:cap"); err != nil {
t.Fatalf("dep add external: %v\n%s", err, stderr)
}
flag := func(args ...string) bool {
t.Helper()
cmd := exec.Command(bd, append([]string{"blocked", "--flags", "--json"}, args...)...)
cmd.Dir = p.dir
cmd.Env = bdProxiedEnv(p.dir)
cmd.Stdin = strings.NewReader(ext.ID + "\n")
var stdout, stderr bytes.Buffer
cmd.Stdout, cmd.Stderr = &stdout, &stderr
if err := cmd.Run(); err != nil {
t.Fatalf("bd blocked --flags %v: %v\n%s\n%s", args, err, stdout.String(), stderr.String())
}
var rows []struct {
ID string `json:"id"`
IsBlocked bool `json:"is_blocked"`
}
if err := json.Unmarshal(bytes.TrimSpace(stdout.Bytes()), &rows); err != nil || len(rows) != 1 {
t.Fatalf("parse %v: %v\n%s", args, err, stdout.String())
}
return rows[0].IsBlocked
}
if !flag() {
t.Errorf("--flags for an externally blocked row = false, want true (the policy flag)")
}
if flag("--raw") {
t.Errorf("--flags --raw for an externally blocked row = true, want false (the stored column)")
}
})
t.Run("empty_case", func(t *testing.T) {
t.Parallel()
p := newSharedProxiedProject(t, bd, "bk2")
@ -189,42 +125,4 @@ func TestProxiedServerBlocked(t *testing.T) {
t.Errorf("non-descendant %s leaked into --parent result", outside.ID)
}
})
t.Run("label_filters_apply_to_external_only_rows", func(t *testing.T) {
t.Parallel()
p := newSharedProxiedProject(t, bd, "bkl")
// A row blocked only by an unsatisfied external ref is listed by the
// unit-of-work decorator after the label query ran, so the filters
// must judge it by its own labels, read hydrated.
tagged := bdProxiedCreate(t, bd, p.dir, "Externally blocked, labelled", "-l", "lane:a")
bare := bdProxiedCreate(t, bd, p.dir, "Externally blocked, unlabelled")
for _, id := range []string{tagged.ID, bare.ID} {
if _, stderr, err := bdProxiedRunBuffers(t, bd, p.dir, "dep", "add", id, "external:otherproj:cap"); err != nil {
t.Fatalf("dep add %s external: %v\n%s", id, err, stderr)
}
}
for _, tc := range []struct {
args []string
want []string
}{
{nil, []string{tagged.ID, bare.ID}},
{[]string{"--label", "lane:a"}, []string{tagged.ID}},
{[]string{"--label-any", "lane:a"}, []string{tagged.ID}},
{[]string{"--exclude-label", "lane:a"}, []string{bare.ID}},
} {
got := bdProxiedBlockedJSON(t, bd, p, tc.args...)
ids := make([]string, 0, len(got))
for _, bi := range got {
ids = append(ids, bi.ID)
if bi.ID == tagged.ID && !slices.Equal(bi.Labels, []string{"lane:a"}) {
t.Errorf("bd blocked %v: %s prints labels %v, want [lane:a]", tc.args, bi.ID, bi.Labels)
}
}
slices.Sort(ids)
slices.Sort(tc.want)
if !slices.Equal(ids, tc.want) {
t.Errorf("bd blocked %v listed %v, want %v", tc.args, ids, tc.want)
}
}
})
}

View file

@ -207,12 +207,6 @@ Examples:
}
if beadsDir == "" {
// Discovery passes over a .beads marked only by a legacy
// config.json. One in a format this build cannot open is refused
// as that, not reported as no workspace.
if err := checkUndiscoveredWorkspaceFormat(); err != nil {
return handleWorkspaceGuardError(err)
}
if jsonOutput {
if err := outputJSON(noWorkspaceBootstrapPayload()); err != nil {
return err
@ -225,7 +219,7 @@ Examples:
}
if err := guardLegacyUpgradeWorkspace(beadsDir); err != nil {
return handleWorkspaceGuardError(err)
return HandleError("%v", err)
}
// Load config from .beads/metadata.json. When the beadsDir was
@ -240,9 +234,7 @@ Examples:
}
if cfg == nil {
cfg, err = findParentConfig(beadsDir)
if isUnsupportedWorkspaceFormat(err) {
return handleWorkspaceGuardError(err)
} else if err != nil {
if err != nil {
return HandleError("failed to load ancestor storage metadata: %v; no storage database was opened or modified; fix or restore metadata.json and retry", err)
}
}
@ -282,11 +274,7 @@ Examples:
}
if err := executeBootstrapPlan(plan, cfg, nonInteractive); err != nil {
// The error can carry sync.remote verbatim, credentials and all:
// sanitizeURL passes through a URL net/url cannot parse (a
// password with an unencoded "#" or "?"), and Dolt's "invalid
// remote url:" repeats it. Scrub it where it is printed.
return HandleError("Bootstrap failed: %s", scrubURLCredentials(err.Error()))
return HandleError("Bootstrap failed: %v", err)
}
return nil
},
@ -1594,9 +1582,6 @@ func isNonInteractiveBootstrap(flagValue bool) bool {
// parent workspace does. Returns nil if no parent config is found. A malformed
// or unreadable ancestor metadata file is authoritative and returned as an error;
// bootstrap must not skip it and select a more distant workspace or defaults.
// An ancestor holding the graph format marker without metadata it can read is
// a graph workspace, refused like one whose metadata declares graph_mode,
// rather than skipped or reported as a metadata load failure.
func findParentConfig(beadsDir string) (*configfile.Config, error) {
// Start from the parent of beadsDir's enclosing directory.
// beadsDir is typically "<project>/.beads", so we start from <project>'s parent.
@ -1614,9 +1599,6 @@ func findParentConfig(beadsDir string) (*configfile.Config, error) {
for dir, ok := walk.Next(); ok; dir, ok = walk.Next() {
candidate := filepath.Join(dir, ".beads")
cfg, err := configfile.LoadForDiscovery(candidate)
if (err != nil || cfg == nil) && hasGraphFormatMarker(candidate) {
return nil, &configfile.UnsupportedWorkspaceFormatError{BeadsDir: candidate, FormatMarker: true}
}
if err != nil {
return nil, fmt.Errorf("%s: %w", configfile.ConfigPath(candidate), err)
}
@ -1674,31 +1656,25 @@ func isGitCodeRepoURL(rawURL string) bool {
// urlHostname extracts the lowercase hostname from a URL without importing
// net/url. Handles scheme://[user@]host[:port]/path and SCP git@host:path.
//
// The host part is cut out before userinfo is stripped through its last "@",
// so an "@" in a path, query or fragment never selects the host (mc-gcmer).
// For a scheme URL the host part is the authority, which ends at the first
// "/", "?" or "#" — the host net/url, and so Dolt, would dial. For SCP it is
// everything before the first ":", unless a "/" comes first, which makes it a
// local path (the split doltremote.FromGitURL makes).
func urlHostname(rawURL string) string {
if sep := strings.Index(rawURL, "://"); sep >= 0 {
rest := rawURL[sep+3:]
if end := strings.IndexAny(rest, "/?#"); end >= 0 {
rest = rest[:end]
}
if at := strings.LastIndex(rest, "@"); at >= 0 {
if at := strings.Index(rest, "@"); at >= 0 {
rest = rest[at+1:]
}
if slash := strings.Index(rest, "/"); slash >= 0 {
rest = rest[:slash]
}
if colon := strings.Index(rest, ":"); colon >= 0 {
rest = rest[:colon]
}
return strings.ToLower(rest)
}
// SCP-style: git@github.com:org/repo
if colon := strings.Index(rawURL, ":"); colon >= 0 && !strings.Contains(rawURL[:colon], "/") {
if at := strings.LastIndex(rawURL[:colon], "@"); at >= 0 {
return strings.ToLower(rawURL[at+1 : colon])
if at := strings.Index(rawURL, "@"); at >= 0 {
rest := rawURL[at+1:]
if colon := strings.Index(rest, ":"); colon >= 0 {
return strings.ToLower(rest[:colon])
}
}
return ""

Some files were not shown because too many files have changed in this diff Show more