beads/cmd/bd/protocol/memory_contract_test.go
Steve Yegge 08881217b6 test(protocol): pin §E/§M/§V conformance clauses at the CLI level (wy-ge2h8)
Conformance corpus WP4 from PROPOSAL-beads-protocol-v0.md §11: the errors,
memories, and versioning clauses that the manifest listed as TODO. All of them
are CLI-surface clauses, so they land in cmd/bd/protocol — the corpus an
alternate implementation replays against its own binary.

Pinned:
  E3  exit codes 10 (remote-divergence refused), 12 (destroy-token missing),
      130 (prompt canceled), asserted as LITERALS, not as bd's Go constants —
      the clause freezes the numbers a script branches on.
  E4  error classes distinguishable from the message alone: not-found,
      already-claimed (naming the holder), not-claimable (naming the state),
      validation.
  E5  --json errors are {error, hint?, schema_version:1}.
  M1  memory CRUD surface (remember / recall / memories / forget).
  M4  reserved namespace: `bd kv set memory.*` refuses and names the owner.
  V2  designated-migrator gate; BD_ALLOW_REMOTE_MIGRATE=1 is the way through.
  V3  schema-skew refusal, and the BD_IGNORE_SCHEMA_SKEW downgrade to a warning.

Rebased onto origin/main and the exit-130 prompt deadline widened to 120s: that
case is the one init test on the SUCCESS path (initEnv pins the suite's Dolt
server), so it pays a full store creation before the wizard prompts — the old
15s deadline fired mid-init and misreported a missing prompt (wy-wst4r).

Landed via wy-wst4r after the original close of wy-ge2h8 cited a wyvern-side
doc-only commit and left this 1005-line corpus stranded on a local branch.

Agent-Signature: claude-code-opus-4.8-high on behalf of Steve Yegge
2026-07-13 10:30:24 -07:00

105 lines
3.7 KiB
Go

// memory_contract_test.go — protocol v0 §M (memories).
//
// M1 (model). A memory is a (key, value) pair in a namespace separate from
// issues, with the surface: bd remember / bd memories (list, search) /
// bd recall <key> / bd forget <key>. This file pins that CRUD surface at the
// CLI level — the four verbs, the round trip through the store, and the
// post-forget disappearance.
//
// M4 (reserved namespace). The memory keyspace is reserved to the memory
// commands: a generic KV surface MUST NOT write into it. bd stores memories as
// kv.memory.* rows, so an unbarred `bd kv set memory.x` would mint something
// indistinguishable from a `bd remember` memory — and the merge resolver
// auto-resolves kv.memory.* conflicts with --theirs (GH#2474), so a remote pull
// could silently overwrite the operator's deliberate KV value. The bar is what
// keeps the namespace owned.
package protocol
import (
"strings"
"testing"
)
// TestProtocol_MemoryCRUDSurface pins §M1: the remember → recall → list →
// search → forget cycle over the frozen CLI surface.
func TestProtocol_MemoryCRUDSurface(t *testing.T) {
t.Parallel()
w := newWorkspace(t)
const (
key = "auth-jwt"
text = "auth module uses JWT not sessions"
)
// Create.
w.run("remember", text, "--key", key)
// Read by key.
recalled := w.run("recall", key)
if !strings.Contains(recalled, text) {
t.Errorf("bd recall %s did not return the stored value (§M1):\n%s", key, recalled)
}
// List.
list := w.run("memories")
if !strings.Contains(list, key) {
t.Errorf("bd memories does not list the stored key (§M1):\n%s", list)
}
// Search (bd memories <term>).
found := w.run("memories", "JWT")
if !strings.Contains(found, text) {
t.Errorf("bd memories JWT did not match the stored memory (§M1):\n%s", found)
}
// Update in place: same key, new value.
const updated = "auth module uses JWT with a 15m TTL"
w.run("remember", updated, "--key", key)
recalled = w.run("recall", key)
if !strings.Contains(recalled, updated) {
t.Errorf("bd remember --key did not overwrite in place (§M1):\n%s", recalled)
}
// Delete.
w.run("forget", key)
if _, code := w.runExpectError("recall", key); code == 0 {
t.Errorf("bd recall after forget exited 0, want nonzero (§M1/§E2)")
}
if list := w.run("memories"); strings.Contains(list, key) {
t.Errorf("forgotten key still listed by bd memories (§M1):\n%s", list)
}
}
// TestProtocol_MemoryReservedNamespace pins §M4: the generic KV surface must
// refuse to write into the memory namespace, and the refusal must point at the
// commands that own it.
func TestProtocol_MemoryReservedNamespace(t *testing.T) {
t.Parallel()
w := newWorkspace(t)
// Control: an ordinary KV key is accepted, so the refusal below is about the
// namespace and not about `bd kv set` being broken.
w.run("kv", "set", "deploy-target", "staging")
if got := w.run("kv", "get", "deploy-target"); !strings.Contains(got, "staging") {
t.Fatalf("bd kv set/get round trip failed for an ordinary key:\n%s", got)
}
for _, key := range []string{"memory.auth-jwt", "memory.nested.key"} {
out, code := w.runExpectError("kv", "set", key, "smuggled")
if code == 0 {
t.Errorf("bd kv set %s exited 0, want refusal (§M4)", key)
}
lower := strings.ToLower(out)
if !strings.Contains(lower, "reserved") {
t.Errorf("bd kv set %s: refusal does not say the namespace is reserved (§M4):\n%s", key, out)
}
if !strings.Contains(lower, "bd remember") {
t.Errorf("bd kv set %s: refusal does not name the owning command (§M4):\n%s", key, out)
}
}
// The bar must not have leaked a value into the memory namespace.
if out := w.run("memories"); strings.Contains(out, "smuggled") {
t.Errorf("a refused kv set still reached the memory namespace (§M4):\n%s", out)
}
}