Ten agents over 216 files, one directory-balanced group each, working to a rubric that named what to cut (duplication narration, restatement of the next line, the governing rule echoed in every command file, throat-clearing) and what to keep (traps, invariants, security, tracker ids, behaviour changes, and the "why a naive simplification destroys this assertion" rationale). Net 1,523 lines. Density against this repo's own per-directory norm on main: cmd/bd 33.6% -> 27.3% (main 10.7%) internal/storage 26.1% -> 23.1% (main 14.1%) backend/conformance 34.0% -> 29.6% (main 22.8%) internal/httpapi 30.9% -> 27.8% (main 30.6%, now below) overall 34.7% -> 31.6% Every agent landed at 18-25% rather than the 30% asked for, and every one gave the same reason independently: what remained was on the keep list. Ten separate judgements agreeing is the most useful result here — the prose is dense, but it is mostly load-bearing, and the shortfall is the honest answer rather than a failure to try. TWO REVERTS, both to protect something worth more than the lines. issueops/ is back to its pre-trim state, giving up 610 lines. The conformance contracts cite the leaf docs BY LINE — "pins treewalker.go:52-66" — 155 times. Trimming the cited files silently repointed those at whatever text moved into those numbers, across agent boundaries so no agent could see it. A semantic remapper recovered 141 of them, but 23 needed judgement and several landed on struct fields. The leaf docs are the spec the contracts are written against; they are the one place in this change where dense prose IS the deliverable, and keeping them stable is worth more than the 610 lines. tree_walker_contract.go and version_reconciler_contract.go went back for the same reason: an agent had deleted a paragraph containing a citation, so positional restoration could not align them. After the reverts, exactly 5 citations point into a still-trimmed file and 2 of those are weak — both in cmd/bd/config_guard_test.go, which this series never touched and whose citations were already wrong on main (init.go:361 pointed at a closing brace; the guard it names is at init.go:1499). VERIFICATION. A guard strips every comment and all whitespace from each of the 193 modified files at HEAD and in the worktree and requires the two to be byte-identical, so a code change cannot hide in a comment diff. It handles `//` inside string and raw-string literals, and was tested against a deliberate code change before being trusted. gofmt clean, go build, go vet, golangci-lint 0 issues, and the two AST-based tests that PARSE trimmed files — the timed provider binding pin over claim.go and the serve database-source gate over serve.go — both pass. One real defect found while trimming: checkDatabaseSource's doc block ran into `// sourceRoles is ...` with no blank line, so godoc attached thirty-one lines of the wrong prose to func sourceRoles and left checkDatabaseSource undocumented. Fixed by separating them.
59 lines
1.9 KiB
Go
59 lines
1.9 KiB
Go
package httpapi
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/steveyegge/beads/internal/httpapi/apigen"
|
|
"github.com/steveyegge/beads/issueops"
|
|
)
|
|
|
|
// handleDependencyCycles answers GET /v0/beads/dependencies/cycles.
|
|
//
|
|
// WHAT IS NOT HERE, as for the read operations next door: no graph is built, no
|
|
// table is chosen, no path is rotated and no report is sorted. The
|
|
// canonicalization the document promises is inside issueops.CycleDetector's
|
|
// implementation, which `bd dep cycles` reaches through the same accessor; a
|
|
// handler that ordered the answer for itself would be a second definition of
|
|
// "canonical".
|
|
//
|
|
// The element type is an ALIAS of issueops.Cycle — the same struct the CLI's
|
|
// --json marshals — so there is no second wire struct here and there must never
|
|
// be one.
|
|
func (s *Server) handleDependencyCycles(w http.ResponseWriter, r *http.Request) {
|
|
if !s.requireNoQuery(w, r) {
|
|
return
|
|
}
|
|
|
|
detector, err := s.cycleDetector(r)
|
|
if err != nil {
|
|
s.failErr(w, r, err)
|
|
return
|
|
}
|
|
report, err := detector.DetectCycles(r.Context(), issueops.DetectCyclesRequest{})
|
|
if err != nil {
|
|
s.failErr(w, r, err)
|
|
return
|
|
}
|
|
|
|
writeJSON(w, apigen.CyclesPage{
|
|
Items: wireCycles(report.Cycles),
|
|
// Always false: this operation takes no limit, so nothing truncates the
|
|
// report. It is emitted rather than omitted because the document types
|
|
// it as required, and because a client must not have to tell "not
|
|
// truncated" from "this server does not say".
|
|
HasMore: false,
|
|
})
|
|
}
|
|
|
|
// wireCycles projects the role's report onto the generated envelope's element
|
|
// type, which is an alias of the role's own struct.
|
|
//
|
|
// It exists for the one thing that is not free: the document says `items` is an
|
|
// empty array and never null. Making the guarantee here as well means the wire
|
|
// promise does not depend on the role keeping its own.
|
|
func wireCycles(cycles []issueops.Cycle) []apigen.Cycle {
|
|
if cycles == nil {
|
|
return []apigen.Cycle{}
|
|
}
|
|
return cycles
|
|
}
|