* ci(bazel): embedded-Dolt tier 20/5 -> 40/14 duration-balanced shards (F1)
Give the Bazel-only bazel-embedded job its own duration-balanced manifest
blocks for //cmd/bd:bd_embedded_test (20 -> 40 shards) and
//internal/storage/embeddeddolt:embeddeddolt_embedded_test (5 -> 14
shards), decoupled from PR Risk's/main.yml's legacy frozen 20/5-shard
fork/push jobs, mirroring F2's bd_proxied_test precedent.
- Measured every TestEmbedded* / embeddeddolt test's wall time in
isolation; split 21 cmd-tier and 1 storage-tier single top-level test
over 180s into disjoint sub-tests (3 irreducible exceptions left:
TestEmbeddedUpdateConcurrent 475s, TestEmbeddedCloseConcurrent 308s,
TestLargeBatchApplyStatementCounts712_Embedded 261s).
- New scripts/ci/gen_embedded_{cmd,storage}_shard_manifest.py +
_embedded_shard_manifest_lib.py generate/check duration-balanced
manifest blocks (LPT packing, incremental --write/--repack, exact-once
--check), chosen at N=40/M=14 where the heaviest shard reaches the
irreducible-test floor.
- Fixed 18 stale legacy 20-shard cmd manifest entries (and 1 storage
entry) left over from earlier test splits, which would have hard-failed
every shard of PR Risk's real test-embedded-cmd jobs on their next run.
- New scripts/embedded_shard_count_test.go policy tests tie the
Bazel-only block's shard count to bazel.yml's check_shard_coverage.py
argument and catch generator staleness; generalized
TestBazelRetiredLanesCheckListedTestsRan's live-shard-count dispatch
from bd_proxied_test-only to a map covering both embedded targets;
removed TestBazelEmbeddedJobMirrorsEmbeddedTier's now-invalid
BUILD.bazel-shard-count-equals-PR-Risk-matrix assertion.
- Verified: go test ./scripts/..., bazel test //scripts:scripts_test,
actionlint, make ci-pr-policy, make bazel-sync-check all pass; full
local bazel test of both targets at 40/14 shards passes 2/2; mutation
testing confirms each new/changed policy test fails exactly when it
should.
See ~/beads-bazel-plan/f1/impl-report.md for full detail.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* fix(embedded-dolt): skip 712-item statement-count assertion under -race (F1)
TestLargeBatchApplyStatementCounts712_Embedded genuinely costs ~260-300s
under -race (confirmed by solo re-measurement: 298.60s) -- 14014 real SQL
statement round-trips through the race-instrumented in-process Dolt engine,
not an artifact and not splittable (one indivisible ApplyBatchInTx
transaction). It was the storage tier's single-test floor for CI shard
packing.
Apply the exact precedent TestLargeBatchApplyWallClock_Embedded already set
for its 1000-item shape: skip this assertion under raceEnabled (the cost is
race-instrumentation overhead on the Dolt engine's own internal
goroutine/lock machinery, not this test's own logic) and extend nightly.yml's
"Embedded Dolt batch-apply suite (non-race)" step's -run regex so the full
pinned 14014-statement baseline still runs, non-race, every night. Verified
directly: under -race the assertion now skips in 0.00s; without -race it
still runs and asserts Total=14015 (within the existing +/-2 tolerance) in
36.76s.
Updates scripts/ci_workflow_test.go's
TestNightlyFullTestRunsEmbeddedDoltBatchApplySuite to match the extended
regex.
Storage tier's new single-test ceiling under the per-PR -race lane drops
from ~260.7s to 152.38s (TestBatchApplyContract).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* ci(bazel): correct cmd-tier long-pole durations, re-pack embedded manifolds (F1)
Investigated coordinator item 2 (single-test long poles): TestEmbeddedUpdateConcurrent
(recorded 475.39s) and TestEmbeddedCloseConcurrent (recorded 308.06s), plus
the two other >180s cmd-tier entries from the same capture
(TestEmbeddedInitA 196.94s, TestEmbeddedEpicCloseEligibleReason 192.47s).
Root cause: NOT host contention, NOT backoff/retry sleeps (bdRunWithFlockRetry
contributes negligibly), NOT race-instrumented-subprocess overhead alone.
These numbers were captured via `bazel --nohome_rc test --config=embedded`
with the then-current 20-shard legacy manifest (~10-11 tests/shard) and
`-test.parallel=4`. Go's t.Parallel() starts each parallel test's elapsed
clock when its function is invoked, before the Parallel() call blocks it
waiting for a free one-of-4 slot -- so a test queued behind several other
heavy shard-mates has that queueing wait baked into its own recorded
`--- PASS: TestX (Ys)` time. This is shard-composition-dependent scheduling
delay, not a cost intrinsic to the test.
Confirmed two ways in an isolated clone (not this worktree, per the
no-plain-go-test-from-a-beads-checkout rule):
- Solo (no rivals at all): 151.83s / 106.48s / 63.58s / 66.08s.
- All four together with the real -race -test.parallel=4 flags and exactly
4 tests requested (so nobody queues -- parallel slots == test count):
141.34s / 113.80s / 69.79s / 74.63s.
Both agree closely and both are far below the capture-time numbers.
F1's LPT packer already isolates the heaviest tests into shards with few or
no other heavy rivals (TestEmbeddedUpdateConcurrent lands alone in its own
40-shard-block shard), so under the new manifest these tests see little to
no queueing delay in real CI. None of the four needed splitting, parallel
subtests, or raceEnabled-scaled N: once correctly measured, none exceeds the
180s single-test guideline (new corrected weights: 155.0 / 115.0 / 72.0 /
77.0s). Corrected scripts/ci/embedded_cmd_test_durations.json accordingly
(with a doc-comment explaining the methodology and both confirmations) and
re-packed the 40-shard Bazel-only block (--repack --write); --check passes
(exact-once coverage of all 241 discovered tests). The frozen legacy 20-shard
block is untouched and independently re-verified exact-once by simulating
embedded-test-shard.sh across all 20 shards (241/241 tests, no
duplicates/misses/errors).
New cmd-tier single-test ceiling: 179.47s (TestEmbeddedCloseAlreadyClosed,
likely itself somewhat inflated by the same mechanism but already under the
180s line as recorded, so no action needed).
Also updates scripts/ci/embedded_storage_test_durations.json: the prior
commit's raceEnabled-skip for TestLargeBatchApplyStatementCounts712_Embedded
means it now costs ~0s in the per-PR -race lane bazel-embedded actually
packs for (not its real ~260-300s non-race cost, which nightly.yml still
exercises) -- weight set to 1.0 with a doc comment tying it to the skip in
large_batch_apply_measure_test.go. Re-packed the 14-shard Bazel-only block
accordingly; --check passes (exact-once coverage of all 387 discovered
tests, excluding TestMain/TestConformance per that file's existing
convention). The frozen legacy 5-shard block is untouched and independently
re-verified exact-once via embedded-storage-test-shard.sh simulation
(388/388 tests, no duplicates/misses/errors).
Verification: go test ./scripts/... (includes the nightly.yml policy test),
make ci-pr-policy, make bazel-sync-check, actionlint all pass. Real local
`bazel --nohome_rc test --config=embedded //cmd/bd:bd_embedded_test
//internal/storage/embeddeddolt:embeddeddolt_embedded_test`
(--local_test_jobs=8, both targets together, on a shared/noisy sandbox host)
passes both targets; per-shard wall time from each shard's test.xml: cmd/bd
max 218.9s (shard 23/40, min 20.6s), storage max 251.1s (shard 5/14, min
0.98s) -- down from the prior oversubscribed sweep's 783.41s / 351.94s and
well under the single-test-floor-based ~475s projection this slice started
from. Projected tier lane time (max of the two targets, real dedicated CI
runners should do at least this well): ~251s, under the 5-minute target.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* test(embedded): un-vacuous TestEmbeddedDepB edges, split epic-close test, trim concurrency stress N (F1 review)
Coordinator review follow-ups on the F1 embedded-Dolt resharding slice:
- TestEmbeddedDepB (one of TestEmbeddedDep's two CI-speed split halves) was
asserting its tree_* subtests against an edgeless graph, passing
vacuously; restores the same parent-child/blocks edges TestEmbeddedDepA
builds so those subtests exercise real multi-node traversal (review S2).
- TestEmbeddedEpicCloseEligibleReason split into
TestEmbeddedEpicCloseEligibleReasonFlag/...Output for CI shard balance,
matching the project's established single-concern split pattern.
- TestEmbeddedUpdateConcurrent/TestEmbeddedCloseConcurrent's
issuesPerWorker reduced 5->2: under real concurrent-shard-load
measurement these were genuine (not queueing-artifact) serialized-write
costs; 2 preserves every invariant the test checks (duplicate-ID
detection across all workers, one non-decreasing-list-count check per
worker) at a fraction of the serialized work.
- large712ShapeName: the 712-shape's race skip and its zero-match guard now
share one named constant instead of two independent literal shape-name
strings, so a future rename of the shape can't silently skip the pinned
statement-count assertion under race (review N2).
- Comment-only fixes (review N5) in files referencing test names since
renamed/split by this slice's earlier work: close_proxied_integration_test.go,
graph_apply_test.go, storage_class_proxied_integration_test.go,
tests/regression/discovery_test.go, plus doc-comment path cleanups (N1:
drop unverified ~/beads-bazel-plan paths/bead ids in favor of the
committed duration JSON files and engdocs/TESTING.md).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* ci(bazel): re-derive embedded-Dolt durations under concurrent load; cap cmd shards at Bazel's 50-shard limit (F1 round 2)
Coordinator review required re-deriving every per-test duration weight from
a single, consistent, CI-realistic measurement (all shards running
concurrently, -test.parallel=4, race-enabled) instead of the prior pass's
mix of crowded-shard captures and solo/4-together spot-corrections, and
required measuring per-shard wall time via BEP testAttemptDuration rather
than a shard's outer test.xml <testsuites time> (which can include a
different, already-finished shard-mate's setup/teardown).
- scripts/ci/embedded_cmd_test_durations.json (242 tests) and
scripts/ci/embedded_storage_test_durations.json (387 tests) rewritten in
full from one consistent sweep. Every entry is now a fresh measurement;
none is a carried-over capture-time value or an unverified estimate. Both
files' _comment blocks retract the earlier "queueing delay baked into a
test's own reported elapsed time" theory (testing.go's (*T).Parallel does
not add wait time to a blocked test's own clock) and document the real
methodology.
- Only one cmd-tier test remains over 200s (TestEmbeddedListFiltering,
239.70s), already under the ~240s ceiling; no further top-level splits
were needed this round.
- New finding: Bazel hard-caps shard_count at 50 per sh_test-like rule
("Having more than 50 shards is indicative of poor test organization";
a native analysis-time limit, not configurable). The previous 88-shard
plan for //cmd/bd:bd_embedded_test (chosen as the LPT-packed floor before
this limit was discovered) is reverted to 50, Bazel's real ceiling.
Repacking the fresh weights at 50 shards gives a heaviest shard of
409.6s -- above the single-test floor of 239.7s, because 50 bins is not
enough headroom over the suite's ~20145 measured test-seconds to flatten
every bin to that floor. This makes the <=5 min lane target unreachable
for the cmd tier via resharding alone within Bazel's native per-rule
limit; see ~/beads-bazel-plan/f1/impl-report.md section 3c for the full
writeup and the two remaining levers (suite-wide speedups or a
multi-Bazel-rule split), neither attempted in this slice.
- internal/storage/embeddeddolt gets 15 Bazel-only shards (unaffected by
the 50-shard cap): LPT-packed heaviest shard 225.3s, within target.
- cmd/bd/BUILD.bazel, internal/storage/embeddeddolt/BUILD.bazel,
.github/workflows/bazel.yml, engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md,
scripts/embedded_shard_count_test.go, scripts/pr_risk_bazel_coverage_test.go,
scripts/ci/gen_embedded_cmd_shard_manifest.py updated to the corrected
50/15 shard counts (and, for the generator, N3: --write without an
explicit total_shards now errors instead of silently regenerating the
frozen legacy 20-shard block).
- .github/scripts/embedded-{cmd,storage}-test-shards.txt: re-packed
Bazel-only blocks at 50/15; frozen legacy 20/5 blocks untouched except for
N5 fixes to stale entries left by this slice's earlier test splits
(TestShardScriptsListOnlyRealTests catches this class of bug; both
legacy blocks reconfirmed exact-once).
- .github/workflows/nightly.yml / scripts/ci_workflow_test.go (N4): the
embedded-dolt batch-apply nightly step now runs with `if: ${{
!cancelled() }}` and its own explicit `-timeout 20m`, independent of the
job-level timeout, with both halves now asserted by
TestNightlyFullTestRunsEmbeddedDoltBatchApplySuite.
Verified: gofmt -l clean, go vet ./scripts/... clean, go test ./scripts/...
green, both generators' --check pass at 50/15 (and legacy 20/5 remain
exact-once via the frozen-block invariant).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* test(ci): rename embedded manifest staleness tests out of the ^TestEmbedded skip
The allowlisted go-test leg runs with -skip ^TestEmbedded, so tests named
TestEmbedded*ShardManifestGeneratorNotStale never ran there and the leg
failed with "matched no test that ran".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Gas City Adopt-PR <adopt-pr@gascity.local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
351 lines
11 KiB
Go
351 lines
11 KiB
Go
//go:build cgo
|
|
|
|
package main
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/storage"
|
|
)
|
|
|
|
// bdFederation runs "bd federation" with extra args. Returns combined output.
|
|
func bdFederation(t *testing.T, bd, dir string, args ...string) string {
|
|
t.Helper()
|
|
fullArgs := append([]string{"federation"}, args...)
|
|
cmd := exec.Command(bd, fullArgs...)
|
|
cmd.Dir = dir
|
|
cmd.Env = bdEnv(dir)
|
|
stdout, stderr, err := runCommandBuffers(t, cmd)
|
|
if err != nil {
|
|
t.Fatalf("bd federation %s failed: %v\nstdout:\n%s\nstderr:\n%s", strings.Join(args, " "), err, stdout.String(), stderr.String())
|
|
}
|
|
return stdout.String()
|
|
}
|
|
|
|
// bdFederationFail runs "bd federation" expecting failure.
|
|
func bdFederationFail(t *testing.T, bd, dir string, args ...string) string {
|
|
t.Helper()
|
|
fullArgs := append([]string{"federation"}, args...)
|
|
cmd := exec.Command(bd, fullArgs...)
|
|
cmd.Dir = dir
|
|
cmd.Env = bdEnv(dir)
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
t.Fatalf("bd federation %s should have failed, got: %s", strings.Join(args, " "), out)
|
|
}
|
|
return string(out)
|
|
}
|
|
|
|
// assertExactJSONKeys pins a JSON object's key set: every wanted key present,
|
|
// nothing else added.
|
|
func assertExactJSONKeys(t *testing.T, what string, obj map[string]json.RawMessage, want ...string) {
|
|
t.Helper()
|
|
wanted := make(map[string]bool, len(want))
|
|
for _, key := range want {
|
|
wanted[key] = true
|
|
if _, ok := obj[key]; !ok {
|
|
t.Errorf("%s is missing key %q", what, key)
|
|
}
|
|
}
|
|
for key := range obj {
|
|
if !wanted[key] {
|
|
t.Errorf("%s gained key %q, want only %v", what, key, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFormatFederationPeerListJSONPreservesLegacyKeys(t *testing.T) {
|
|
formatted := formatFederationPeerListJSON([]storage.RemoteInfo{{
|
|
Name: "town-beta",
|
|
URL: "file:///tmp/town-beta",
|
|
}})
|
|
|
|
raw, err := json.Marshal(formatted)
|
|
if err != nil {
|
|
t.Fatalf("marshal federation peer JSON: %v", err)
|
|
}
|
|
body := string(raw)
|
|
if !strings.Contains(body, `"Name":"town-beta"`) || !strings.Contains(body, `"URL":"file:///tmp/town-beta"`) {
|
|
t.Fatalf("formatted JSON should preserve legacy Name/URL keys, got %s", body)
|
|
}
|
|
if strings.Contains(body, `"name"`) || strings.Contains(body, `"url"`) {
|
|
t.Fatalf("formatted JSON should not expose lowercase RemoteInfo storage tags, got %s", body)
|
|
}
|
|
}
|
|
|
|
// TestEmbeddedFederationPeers and TestEmbeddedFederationStatus were split
|
|
// from TestEmbeddedFederation (originally ~282s, measured under
|
|
// --config=embedded) into 2 top-level tests over disjoint subtest groups,
|
|
// for CI shard balance (see scripts/ci/embedded_cmd_test_durations.json and
|
|
// engdocs/TESTING.md). Every original subtest is preserved exactly once.
|
|
func TestEmbeddedFederationPeers(t *testing.T) {
|
|
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
|
|
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt federation tests")
|
|
}
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
|
|
t.Run("list_peers_empty", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdlst0")
|
|
|
|
out := bdFederation(t, bd, dir, "list-peers")
|
|
if !strings.Contains(out, "No federation peers") {
|
|
t.Errorf("expected 'No federation peers', got: %s", out)
|
|
}
|
|
})
|
|
|
|
t.Run("list_peers_empty_json", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdlstj")
|
|
|
|
out := bdFederation(t, bd, dir, "list-peers", "--json")
|
|
// Should be valid JSON (empty array or null)
|
|
out = strings.TrimSpace(out)
|
|
if out != "null" && out != "[]" {
|
|
// Try parsing as JSON array
|
|
var result []interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("expected valid JSON array, got: %s", out)
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("add_peer_simple", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdadd")
|
|
|
|
out := bdFederation(t, bd, dir, "add-peer", "test-peer", "file:///tmp/fake-peer")
|
|
if !strings.Contains(out, "test-peer") {
|
|
t.Errorf("expected peer name in output, got: %s", out)
|
|
}
|
|
|
|
// Verify it appears in list
|
|
listOut := bdFederation(t, bd, dir, "list-peers")
|
|
if !strings.Contains(listOut, "test-peer") {
|
|
t.Errorf("expected 'test-peer' in list, got: %s", listOut)
|
|
}
|
|
})
|
|
|
|
t.Run("add_peer_json", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdaddj")
|
|
|
|
out := bdFederation(t, bd, dir, "add-peer", "json-peer", "file:///tmp/json-peer", "--json")
|
|
var result map[string]interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("failed to parse JSON: %v\n%s", err, out)
|
|
}
|
|
if added, _ := result["added"].(string); added != "json-peer" {
|
|
t.Errorf("expected added='json-peer', got %q", added)
|
|
}
|
|
})
|
|
|
|
t.Run("add_peer_with_credentials", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdcred")
|
|
|
|
out := bdFederation(t, bd, dir, "add-peer", "auth-peer", "file:///tmp/auth-peer",
|
|
"--user", "admin", "--password", "secret", "--json")
|
|
var result map[string]interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("failed to parse JSON: %v\n%s", err, out)
|
|
}
|
|
if hasAuth, _ := result["has_auth"].(bool); !hasAuth {
|
|
t.Error("expected has_auth=true")
|
|
}
|
|
})
|
|
|
|
t.Run("add_peer_with_sovereignty", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdsov")
|
|
|
|
out := bdFederation(t, bd, dir, "add-peer", "sov-peer", "file:///tmp/sov-peer",
|
|
"--sovereignty", "T2", "--json")
|
|
var result map[string]interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("failed to parse JSON: %v\n%s", err, out)
|
|
}
|
|
if sov, _ := result["sovereignty"].(string); sov != "T2" {
|
|
t.Errorf("expected sovereignty='T2', got %q", sov)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestEmbeddedFederationStatus(t *testing.T) {
|
|
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
|
|
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt federation tests")
|
|
}
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
|
|
t.Run("remove_peer", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdrm")
|
|
|
|
bdFederation(t, bd, dir, "add-peer", "removable", "file:///tmp/removable")
|
|
|
|
// Verify it exists
|
|
listOut := bdFederation(t, bd, dir, "list-peers")
|
|
if !strings.Contains(listOut, "removable") {
|
|
t.Fatalf("peer should exist before removal, got: %s", listOut)
|
|
}
|
|
|
|
// Remove it
|
|
out := bdFederation(t, bd, dir, "remove-peer", "removable")
|
|
if !strings.Contains(out, "removable") {
|
|
t.Errorf("expected peer name in removal output, got: %s", out)
|
|
}
|
|
|
|
// Verify it's gone
|
|
listOut = bdFederation(t, bd, dir, "list-peers")
|
|
if strings.Contains(listOut, "removable") {
|
|
t.Errorf("peer should be gone after removal, got: %s", listOut)
|
|
}
|
|
})
|
|
|
|
t.Run("remove_peer_json", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdrmj")
|
|
|
|
bdFederation(t, bd, dir, "add-peer", "rm-json", "file:///tmp/rm-json")
|
|
|
|
out := bdFederation(t, bd, dir, "remove-peer", "rm-json", "--json")
|
|
var result map[string]interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("failed to parse JSON: %v\n%s", err, out)
|
|
}
|
|
if removed, _ := result["removed"].(string); removed != "rm-json" {
|
|
t.Errorf("expected removed='rm-json', got %q", removed)
|
|
}
|
|
})
|
|
|
|
t.Run("status_no_peers", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdst0")
|
|
|
|
out := bdFederation(t, bd, dir, "status")
|
|
if !strings.Contains(out, "No federation peers") {
|
|
t.Errorf("expected 'No federation peers', got: %s", out)
|
|
}
|
|
})
|
|
|
|
// Machine B: the peer row arrived with the database, the machine-local
|
|
// credential key did not. Status must point at the local key rather than
|
|
// report the peer as unreachable (GH#5085 review).
|
|
t.Run("status_credential_key_mismatch", func(t *testing.T) {
|
|
dir, beadsDir, _ := bdInit(t, bd, "--prefix", "fdkey")
|
|
|
|
bdFederation(t, bd, dir, "add-peer", "keyless", "file:///tmp/keyless",
|
|
"--user", "admin", "--password", "secret")
|
|
|
|
otherKey := make([]byte, 32)
|
|
if _, err := io.ReadFull(rand.Reader, otherKey); err != nil {
|
|
t.Fatalf("generate replacement key: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(beadsDir, ".beads-credential-key"), otherKey, 0600); err != nil {
|
|
t.Fatalf("write replacement key: %v", err)
|
|
}
|
|
|
|
out := bdFederation(t, bd, dir, "status")
|
|
if !strings.Contains(out, "Local credential error") {
|
|
t.Errorf("expected the local-credential label, got: %s", out)
|
|
}
|
|
if strings.Contains(out, "Unreachable:") {
|
|
t.Errorf("a local key failure should not be reported as unreachable, got: %s", out)
|
|
}
|
|
for _, want := range []string{".beads-credential-key", "machine-local", "bd federation add-peer"} {
|
|
if !strings.Contains(out, want) {
|
|
t.Errorf("status output does not mention %q, got: %s", want, out)
|
|
}
|
|
}
|
|
|
|
// The local-credential signal is a text-mode label carried by an
|
|
// unexported field, so --json keeps exactly the keys it had before that
|
|
// field existed. Asserted with the failing peer present, which is the
|
|
// only shape where the field is set.
|
|
jsonOut := bdFederation(t, bd, dir, "status", "--json")
|
|
var payload map[string]json.RawMessage
|
|
if err := json.Unmarshal([]byte(jsonOut), &payload); err != nil {
|
|
t.Fatalf("failed to parse status --json: %v\n%s", err, jsonOut)
|
|
}
|
|
// schema_version comes from the outputJSON envelope, not from this command.
|
|
assertExactJSONKeys(t, "status --json", payload, "peers", "pendingChanges", "schema_version")
|
|
|
|
var peers []map[string]json.RawMessage
|
|
if err := json.Unmarshal(payload["peers"], &peers); err != nil {
|
|
t.Fatalf("failed to parse status --json peers: %v\n%s", err, jsonOut)
|
|
}
|
|
if len(peers) != 1 {
|
|
t.Fatalf("status --json peers length = %d, want 1: %s", len(peers), jsonOut)
|
|
}
|
|
assertExactJSONKeys(t, "status --json peer", peers[0], "Status", "URL", "Reachable", "ReachError")
|
|
})
|
|
|
|
t.Run("status_json_no_peers", func(t *testing.T) {
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdstj")
|
|
|
|
out := bdFederation(t, bd, dir, "status", "--json")
|
|
var result map[string]interface{}
|
|
if err := json.Unmarshal([]byte(out), &result); err != nil {
|
|
t.Fatalf("failed to parse JSON: %v\n%s", err, out)
|
|
}
|
|
if _, ok := result["peers"]; !ok {
|
|
t.Error("missing 'peers' in status JSON")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestEmbeddedFederationConcurrent(t *testing.T) {
|
|
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
|
|
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt federation tests")
|
|
}
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "fdconc")
|
|
|
|
const numWorkers = 10
|
|
|
|
type result struct {
|
|
worker int
|
|
out string
|
|
err error
|
|
}
|
|
|
|
results := make([]result, numWorkers)
|
|
var wg sync.WaitGroup
|
|
wg.Add(numWorkers)
|
|
|
|
for w := 0; w < numWorkers; w++ {
|
|
go func(worker int) {
|
|
defer wg.Done()
|
|
peerName := fmt.Sprintf("conc-peer-%d", worker)
|
|
peerURL := fmt.Sprintf("file:///tmp/conc-peer-%d", worker)
|
|
cmd := exec.Command(bd, "federation", "add-peer", peerName, peerURL)
|
|
cmd.Dir = dir
|
|
cmd.Env = bdEnv(dir)
|
|
out, err := cmd.CombinedOutput()
|
|
results[worker] = result{worker: worker, out: string(out), err: err}
|
|
}(w)
|
|
}
|
|
wg.Wait()
|
|
|
|
successes := 0
|
|
for _, r := range results {
|
|
if strings.Contains(r.out, "panic") {
|
|
t.Errorf("worker %d panicked:\n%s", r.worker, r.out)
|
|
}
|
|
if r.err == nil {
|
|
successes++
|
|
} else if !strings.Contains(r.out, "one writer at a time") {
|
|
t.Errorf("worker %d failed with unexpected error: %v\n%s", r.worker, r.err, r.out)
|
|
}
|
|
}
|
|
if successes < 1 {
|
|
t.Errorf("expected at least 1 successful add-peer, got %d", successes)
|
|
}
|
|
t.Logf("%d/%d federation workers succeeded", successes, numWorkers)
|
|
}
|