beads/internal
Eddie the Engineer d05dac1c3e test(roles): pin the BatchGetter pure tier and the spec ids caps
Review fixes, iteration 1. The review approved with no blocker or major
finding and three minors, and this commit takes all three. It changes
tests and one comment only, and every new assertion was mutation-probed
with go test -overlay.

- storage/issueops: add batchget_test.go, the database-free tier that
  FinishGetMany's doc already claimed ("pinned without a database") but
  that no test supplied. It pins:
  - the cap is checked before the blank scan (an over-cap request with
    a blank at position 0 answers *TooManyIDsError);
  - the bound is inclusive;
  - dedupe keeps the first mention, does not trim, and never writes
    through the caller's slice;
  - Issues and Missing both follow request order;
  - both slices are never nil;
  - ExecuteGetMany refuses one id repeated past the cap before any
    query (a sqlmock with no expectations).
  Ten mutants were each killed by exactly their intended test, with the
  rest of the package green: last-mention, sort, trim, in-place dedupe,
  blank-before-cap, >=, nil Missing, nil Issues, dedupe-before-validate
  and validate-after-query.
- httpapi: TestSpecDefaultsMatchSharedConstants now checks ids.maxItems
  against the enforced bound on the two request bodies that carry an
  `ids` list: batchGetIssues against issueops.MaxGetManyIDs, and
  deleteIssues against maxDeleteIDs. Each body is reached through its
  operation's own requestBody $ref. Setting either constant to 999 turns
  only this test red. The spec's other list caps (batch
  create/close/apply items, dependency edge lists) stay ungated, as
  before.
- cmd/bd/serve.go: the batchGetter field comment said its accessor
  "does NOT recurse through the hook decorator". HookFiringStore.
  BatchGetter does recurse to the inner getter; it just doesn't wrap
  the result. The comment now says that.

Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-05 17:40:58 +00:00
..
ado build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
atomicfile build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
audit build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
beads fix(routing): bind role detection to the bd -C target repo (re-port of #4242) (#5243) 2026-10-04 05:47:27 -07:00
ceiling test(bazel): fully green //..., tag taxonomy + docker lane, sharding, test sandbox ceiling (#6871) 2026-09-27 20:19:38 -07:00
compact build(bazel): integration-tag lane (--config=integration) matching main.yml (#6916) 2026-09-28 14:11:34 -07:00
config fix(config): bd config unset reported success while the key stayed set (#5760) 2026-10-01 05:07:04 -07:00
configfile Fix ResolveServerMode ambient port-var handling and the KillStaleServers regression it introduced (#5934) 2026-09-30 07:13:57 -07:00
creds test(credentials): make remaining credential-command fixtures native-Windows portable (#5748) (#5749) 2026-09-30 18:30:25 -07:00
debug build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
doltremote fix(doltremote): treat s3:// as a native Dolt remote scheme (#5948) 2026-09-29 06:28:57 -07:00
doltserver feat(backends): registry Remote + OpenWith options; beads.OpenBestAvailableWith for embedders (#7188) 2026-10-04 09:34:36 -07:00
doltversion build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
eventsjournal build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
execenv test(bazel): runfiles helpers + declared inputs for scan-guard tests (#6828) 2026-09-27 08:24:08 -07:00
fdhygiene build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
formula fix(ci,tests): un-hide TestEmbedded* tests, fence cmd/bd tests from ancestor .beads, cut #7051 race long poles, fix main lint (#7128) 2026-10-03 04:18:14 -07:00
git fix: macOS main job — /private/var symlink in test repo pin; bash 3.2-safe CI scripts (#7165) 2026-10-03 23:08:51 -07:00
gitenv fix(hooks): identify the index context behind tracked-file refusals (#6457) 2026-09-27 18:07:43 -07:00
githooksenv test(bazel): runfiles helpers + declared inputs for scan-guard tests (#6828) 2026-09-27 08:24:08 -07:00
github feat(github): sync epic/child and blocks relationships to GitHub (#5971) 2026-10-01 01:22:00 -07:00
gitignore fix(worktree): preserve CRLF gitignore appends (#5677) 2026-09-30 01:46:12 -07:00
gitlab build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
gittraceenv test(bazel): runfiles helpers + declared inputs for scan-guard tests (#6828) 2026-09-27 08:24:08 -07:00
hooks fix(hooks): warn on unsupported async execution (#5673) 2026-10-01 01:08:04 -07:00
httpapi test(roles): pin the BatchGetter pure tier and the spec ids caps 2026-10-05 17:40:58 +00:00
httpclient fix(roles): sync client vocabulary and repo gates with issues:batchGet 2026-10-05 16:18:57 +00:00
idgen build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
jira perf(storage): SearchIssueSummaries narrow-projection foundation (be-nu4.3) (#3458) 2026-10-01 01:19:24 -07:00
linear test(bazel): fully green //..., tag taxonomy + docker lane, sharding, test sandbox ceiling (#6871) 2026-09-27 20:19:38 -07:00
lockfile build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
memoryapi build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
metrics test(bazel): fully green //..., tag taxonomy + docker lane, sharding, test sandbox ceiling (#6871) 2026-09-27 20:19:38 -07:00
migration build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
molecules test(testutil): opt-in local dolt sql-server backend for Dolt-backed tests (#6891) 2026-09-28 04:06:49 -07:00
notion fix(notion): make the query page bound configurable and honour Retry-After (#6006) 2026-10-04 07:16:26 -07:00
procid build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
query build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
recipes build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
remotecache fix(doltremote): treat s3:// as a native Dolt remote scheme (#5948) 2026-09-29 06:28:57 -07:00
routing fix(routing): bind role detection to the bd -C target repo (re-port of #4242) (#5243) 2026-10-04 05:47:27 -07:00
storage test(roles): pin the BatchGetter pure tier and the spec ids caps 2026-10-05 17:40:58 +00:00
telemetry fix(roles): close S7 review gaps — revision on wire, BUILD sync, handler tests 2026-10-05 15:47:43 +00:00
templates fix(ci,tests): un-hide TestEmbedded* tests, fence cmd/bd tests from ancestor .beads, cut #7051 race long poles, fix main lint (#7128) 2026-10-03 04:18:14 -07:00
testutil ci: fix red nightly (Bazel-skip allowlist, credential helper init); rerun-safe Bazel artifacts (#7096) 2026-10-02 05:42:05 -07:00
timeparsing build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
tracker ci(bazel): dolt-server lane on remote execution (replaces the docker lane) (#6898) 2026-09-28 05:17:36 -07:00
types fix(roles): close S7 review gaps — revision on wire, BUILD sync, handler tests 2026-10-05 15:47:43 +00:00
ui fix(uimd): render bd show DESCRIPTION with terminal's actual background (#5776) 2026-10-01 00:55:37 -07:00
uimd fix(uimd): render bd show DESCRIPTION with terminal's actual background (#5776) 2026-10-01 00:55:37 -07:00
utils Refuse reserved words and fuzzy id matches on bd comment writes (#5393) 2026-10-01 05:04:32 -07:00
validation build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00
versioncheck fix(release): name the version-drift remedies that work (#7083) 2026-10-01 11:34:06 -07:00
workapi feat(count): Counter scope — ParentID, NoParent, ExcludeTypes, ExcludeStatus (issues.count.scope) (#7199) 2026-10-05 02:57:14 -07:00
workspacegate fix(gate): ordinary commands wait for maintenance operations, fairly; init waits up to 60s (#7225) 2026-10-05 00:03:48 -07:00
worktreeremove build(bazel): side-by-side Bazel scaffold + policy tests (#6798) 2026-09-27 03:41:02 -07:00