* test(cmd/bd): reset cobra flags between in-process runs; keep them out of parallel tests
runBDInProcess and runBDInProcessAllowError execute the package-level
rootCmd tree again and again in one process, and cobra never resets a
flag between Execute calls: a value one invocation parsed (create's
--title, --labels, list's --status, ...) and its Changed bit stayed on the
FlagSet, so the next invocation saw it, and a slice flag that had been
set appended to the stale value instead of replacing it. With a Dolt test
server (the only setup in which these tests run) that failed about 20
TestCLI_* tests depending on suite order.
TestMain now snapshots every flag of the tree (snapshotCommandFlags,
after all init()s registered them, before any test runs) and both runners
put the tree back before and after each run (resetCommandFlags): the
pointee of each flag.Value is restored (for pflag's scalar types that is
the bound variable; for slice types it also clears the internal "changed"
bit, so the next Set replaces), slice contents via SliceValue.Replace,
and Changed=false. TestResetCommandFlagsRestoresEveryFlag sets every flag
of the real tree and checks the reset. The ad-hoc --title reset in
TestCLI_CreateRejectsEmptyTitle_ProxiedServerMode is no longer needed.
Seven TestCLI_Comment* tests called t.Parallel() around the runners.
inProcessMutex serializes the runners only against each other, so their
chdir, stdio swap, env and config re-initialization raced every other
parallel test (data races on config globals; TestCobraParallelPolicyGuard
failing to read its own source files after a concurrent chdir). They run
serially now, and the guard treats the two runners like rootCmd.Execute.
Also two stale TestCLI_Create* cases: DryRunWithRigPrefix exercised a
create --prefix flag that no longer exists, and the flag-like-title cases
passed "--help" or "--foo-bar" where cobra parses them as flags; they now
pass the title after "--", the only way it reaches create's own guard.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): fix the ADO round-trip and bulk-delete tests that rotted unseen
Both need the integration tag and a Dolt test server, which no CI lane
gave cmd/bd (BEADS_TEST_SKIP=dolt everywhere), so they failed unnoticed:
- TestADORoundTrip* stored ado.pat in the database. ado.pat is a secret
read only from config.yaml or AZURE_DEVOPS_PAT (config.IsYamlOnlyKey),
so the tracker found no PAT. The fixture sets AZURE_DEVOPS_PAT.
- TestBulkDeleteNoResurrection expected GetIssue to return (nil, nil) for
a deleted issue; the Dolt store reports storage.ErrNotFound.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): fix parity, completion and notion tests that only fail with a Dolt server
These are Dolt-gated (integration tag + test server), so no CI lane ran
them and they rotted:
- TestParityCreate*/TestParityReopenErrorExits1Silently: bd create
auto-routes via routing.DetectUserRole("."), which warns "beads.role
not configured (GH#2950)" on stderr when the working directory's git
config has no beads.role. The suite pins the configured case, so the
parity env now sets beads.role=maintainer in a test-owned global git
config ($XDG_CONFIG_HOME/git/config; the role lookup scrubs every
GIT_CONFIG_* variable, so those cannot be used).
- TestIssueIDCompletion: issueIDCompletion resolves a database path
before looking at the open store and returns nothing when there is
none; the test now sets dbPath to its store's path.
- TestIssueIDCompletion_UsesWorktreeFallbackWhenStoreNil and
TestGetNotionConfigReadsDBPathWhenStoreUnset: the code under test
reopens the store from metadata.json, which names a database but not
the per-test branch of the shared database that newTestStore uses, so
the reopened store saw none of the test's rows. They now use their own
database (newTestStoreIsolatedDB).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): fix stale doctor/e2e/autocommit/readonly Dolt-gated tests
These need the integration tag and a Dolt test server, which no CI lane
gave cmd/bd, so they rotted unseen:
- TestE2E_DoctorFixMetadataRoundtrip, TestE2E_MigrateDoltMetadata,
TestDoctorCheckHealthReportsVersionMismatchOnRepoLocalPort: bd init now
defaults to embedded mode, where `bd sql` and `bd dolt start` are
refused. Init with --server on a repo-local server of their own
(repoLocalServerEnv: the suite's shared-server port vars cleared, server
stopped at cleanup) and start it explicitly, since BEADS_TEST_MODE=1 never
auto-starts one. MigrateDoltMetadata's DELETE also needed `key` quoted.
- TestDoctor{Conventions,Pollution}MaxRows_EnvOnly_Exits2: bdRunRaw drops
every BEADS_* variable, so the subprocess hit dolt.New's test-database
firewall (exit 1) before the row cap; pass BEADS_TEST_SERVER=1.
- TestDoltAutoCommit_On_WritesAdvanceHead: the embedded engine keeps its
data under .beads/embeddeddolt, not .beads/dolt; findDoltRepoDir looks
in both.
- TestValidateCheck_AllClean: bd doctor validate runs five checks since
the cross-table duplicates check was added.
- TestConfigValidateReadOnlyIsHermetic: readonly commands take a shared
workspace gate, whose lock file (.beads/dolt.gate.lock) workspacegate
creates on first use by design; compare the .beads tree without gate
lock files.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): undo each in-process execution's env and storage-mode leaks
Every in-process run of the bd command tree (runBDInProcess and the many
tests that call rootCmd.Execute directly) leaves process state behind:
PersistentPreRun exports the selected workspace as BEADS_DIR, loads its
.beads/.env, and records the workspace's mode in serverMode /
proxiedServerMode. With a Dolt test server, later tests in the same shard
then resolved a deleted fixture ("no active beads workspace found",
"migration sidecar is missing"), ran subprocess bd against the wrong
workspace ("recorded as proxied-server in .beads/metadata.json"), or took
the proxied path in RunE-level tests ("proxied-server UOW provider not
initialized", a nil-UOW panic in reopenProxiedResolve that killed a shard).
TestMain now registers a cobra initializer/finalizer pair
(installExecuteIsolation) that snapshots the environment and the two mode
globals when an execution starts and restores them when it ends; the
runners' restoreEnvSnapshot shares the helper. TestDoltConfigEnvironmentOverrides
used os.Setenv + defer os.Unsetenv, which deleted the suite's
BEADS_DOLT_SERVER_PORT (the test server's port) for every later test; it
uses t.Setenv now.
Full integration-tagged cmd/bd suite against a hermetic dolt (16 shards):
18 order-dependent failures and the shard panic gone; the 27 remaining
failures all fail alone too.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(init): keep --quiet quiet through the Claude/Codex/Cursor auto-setup
`bd init --quiet` ("Suppress output") still printed the project
integration installers' progress to stdout ("Installing Claude hooks for
this project...", "Claude Code integration installed", ...): the
installers write to os.Stdout unconditionally. Point stdout at the null
device around them while quiet; their failures keep going to stderr as
before. Found by TestInitCommand's quiet case, which asserts no output and
had not run in CI (Dolt-gated).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(init): bring the Dolt-gated init tests up to the current init contract
These tests need a Dolt test server, so no CI lane ran them and they
drifted from the product:
- Embedded is init's default mode, so the server-mode assertions
(.beads/dolt, opening the database on the test server, dolt_mode
"server" in metadata.json) now pass --server (TestInitCommand,
TestInitAlreadyInitialized, TestInitRedirect, TestInitBEADS_DIR,
TestInitDoltMetadata, TestInitDoltMetadataNoGit, TestInitDatabaseFlag's
metadata subtests). The in-process ones reset rootCmd's flags around
themselves so --server cannot leak into later in-process inits.
- Each server init gets its own --database: the suite shares one test
server, and a "test" database another test created belongs to another
project (init refuses: PROJECT IDENTITY MISMATCH).
- The marker tests seed a current-era version witness: the legacy-upgrade
guard refuses a non-empty .beads/dolt without one.
- The redirect test provisions the canonical target with config.yaml: bd
ignores a redirect to a directory with no project files (#4692).
- Shared-server inits get a free port of their own
(sharedServerTestEnv): the inherited BEADS_DOLT_SERVER_PORT is the
suite's test server, which a shared-server start refuses as another
project's, and the default shared port is 3308, a developer's live
server.
- --shared-server's config.yaml is now nested YAML (dolt: shared-server:
true); parse it instead of matching the old flat line.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): run the Dolt-gated tests that skipped on a bare dolt.New
setupTestDB (config, kv and Linear round-trip tests), setupGatedTestDB
(mol ready --gated) and the rename-prefix and bd sql tests opened stores
with dolt.New(&dolt.Config{Path: ...}): no server port, no
CreateIfMissing, so against a running test server they got "database ...
not found" and skipped as "Dolt server not available". They now use the
suite's newTestStore helpers (skip only when no test server runs), and
what that exposed is fixed test-side:
- TestCustomStatusConfig: custom_statuses is read back ORDER BY name;
look statuses up by name / expect name order.
- TestLinearRoundTripCoreFields, TestLinearPullMilestonesCreatesEpicHierarchy:
linear.api_key is a yaml-only secret (LINEAR_API_KEY), push now needs an
explicit linear.state_map, and batch push uses TeamLabels and
issueBatchCreate, which the mock server now answers.
- TestSqlCommand: bd sql refuses in the default embedded mode; set
serverMode for the server-backed store, and stop discarding RunE errors.
- TestE2E_AutoStartedRepoLocalServerPersistsAcrossCommands skipped on
this process's embedded mode although every bd it runs is a subprocess
on a --server workspace; gate on the dolt binary instead and stop the
auto-started server at cleanup.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): no fixed "unused" port, no swallowed JSON, no leaked front-door server
Three more things the Dolt-backed cmd/bd run exposed:
- TestTestServerConnection, TestSharedServerCfgNilHonorsSharedServer and
the two TestLegacyGuard* e2e tests pointed bd at 127.0.0.1:59999 as a
port nothing listens on. Any process on the host may hold it; a
listener that accepts and resets turns the expected "connection
refused" / "Dolt server unreachable" into another error. They take a
just-freed port from closedLoopbackPort (testutil.FindFreePort) now.
- TestDoltSetConfigJSONOutput and TestDoltSetConfigWithUpdateConfig
created .beads 0755, so bd's permissions warning landed in the JSON
under test and the tests skipped ("output not pure JSON") every run.
The fixture uses 0700, and non-JSON output fails instead of skipping.
- TestMigrateDoltModeFrontDoor's closing show/list auto-start a
repo-local server after the reverse migration; nothing stopped it, so
the suite's leak check failed (when the opt-in
BEADS_TEST_MIGRATION_FRONTDOOR suite runs). It stops it at cleanup.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* ci(bazel): advisory cmd/bd Dolt-server tier (bazel-cmd-dolt)
No CI lane ran cmd/bd's Dolt-gated tests (TestCLI_*, the init and
store-backed suites, the doctor/e2e tests): main.yml's integration shards,
nightly's Full Test Suite, and Bazel's --config=prcore/ci and
--config=integration all pass BEADS_TEST_SKIP=dolt, so cmd/bd's TestMain
never starts a test server and those tests skip; the proxied and embedded
tiers run only their manifests' tests. They rotted unseen.
//cmd/bd:bd_dolt_server_test (tag dolt-server-cmd) runs the whole
integration-tagged cmd/bd suite, the integration build's bd_test, against
a hermetic dolt sql-server: BEADS_TEST_DOLT_SERVER=local starts it from
the pinned dolt in the test wrapper's runfiles, and
BEADS_TEST_REQUIRE_DOLT_CONTAINER=1 fails the target instead of skipping
into a cached pass. No test selection: the Go binary shards itself over
every top-level test (32 shards), so each runs exactly once, and
check_testcases.py fails a shard that ran none. --config=doltserver-cmd
has exactly --config=integration's build flags, so the two lanes share
bd_test's compile; prcore/ci and integration exclude the tag.
bazel.yml's new bazel-cmd-dolt job runs it exactly where bazel-integration
runs (same if: remotely on the farm for same-repo PRs, fork-ro/fork-rw,
and locally with the read-only cache in mode cache for forks). It is
advisory: job-level continue-on-error keeps a failure out of the call's
aggregate (BAZEL), and pr.yml's ci-gate reads its result (BAZEL_CMD_DOLT)
but requires it only while the committed top-level flag
BAZEL_CMD_DOLT_REQUIRED is "true" (now "false"; flipping it is the one
change needed). bazel-gate.sh accepts its skip in modes skip and local.
Policy tests: a third lane category in TestBazelLaneIsGatedAlongsideLegacy
(bazelFlagGatedLanes: gate env wired, never statically required, added by
the run script exactly when the pinned flag is "true"), the gate
simulation over every mode with the flag off (advisory: nothing it
reports reddens the gate) and on (exactly a gated lane), the cache-mode
and execution-mode checks, the tag taxonomy and prcore/integration
exclusions, and TestBazelCmdDoltJob (job steps, timeouts, .bazelrc
config equal to integration's build with no dolt skip or test selection,
the target's dolt-server rules, and bd_test's env repeated).
Measured locally (all fixes in this series, 32 shards, 16 at a time on a
shared host): 3267 top-level tests, all shards pass, max shard 313s (one
5001-issue export test, 214s, sets it), mean 100s.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(init): hand the project installers a writer instead of swapping os.Stdout
The --quiet fix earlier in this series pointed the process-global
os.Stdout at the null device around the Claude/Codex/Cursor installers.
That works, but it mutates a global from inside a cobra Run: anything else
writing to stdout meanwhile (a goroutine, a future concurrent installer)
would vanish, and a concurrent read of os.Stdout is a data race.
The installers already write through env structs with stdout/stderr
fields. setup.ProjectInstallOutput carries the two writers, and
InstallClaudeProjectTo / InstallCodexProjectTo / InstallCursorProjectTo
use them (the old entry points keep the process streams). init passes
QuietProjectInstallOutput() under --quiet: progress discarded, error lines
still on stderr. The proxied-server init path (domain adapter
InstallClaudeProject now takes quiet) does the same, so its
"Installing Claude hooks..." is quiet too.
Consistent error policy under --quiet: errors still reach stderr. init's
own "Warning: failed to setup <installer>" lines were suppressed under
--quiet while the installers' "Error:" lines were not, and some installer
failures (Cursor rules) print nothing themselves; the warnings now print
whether or not quiet, like the installers' errors.
Coverage in required lanes: TestProjectInstallersReportToTheGivenOutput
(cmd/bd/setup) and TestEmbeddedInitA/basic, which now asserts that
`bd init --quiet` with agents enabled installs the Claude hooks and prints
none of the installers' progress (verified to fail with the quiet output
disabled).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(export): exercise the incremental-export fallback with a small threshold
TestTryIncrementalExport_ThresholdExceededFallsBack seeded
incrementalExportThreshold+1 = 5001 issues to cross the threshold. Batch
create is one transaction but still several statements per issue, so under
-race against the shared test server it took ~214 s, the longest test in
cmd/bd's Dolt-backed suite by far. The behaviour under test is only
"more changed issues than the threshold -> full export fallback".
incrementalExportThreshold becomes a var (same value), and the test, which
is not parallel, sets it to 20 and seeds 21 issues: 214 s -> 0.6 s.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(cmd/bd): tighten the flag-reset self-test, guards and canaries
Review follow-ups:
- TestResetCommandFlagsRestoresEveryFlag no longer skips a flag it cannot
set: a flag type without a sample value, a Set error, or a non-pointer
Value (which resetCommandFlags could not restore) is an error, so a new
flag type cannot go untested. resetCommandFlags documents that it also
resets flag-bound package globals.
- TestCobraParallelPolicyGuard treats .ExecuteC/.ExecuteContext/
.ExecuteContextC like .Execute (the per-execution isolation writes the
mode globals; a parallel execution would race).
- TestConfigValidateReadOnlyIsHermetic ignores only the gate a readonly
command takes (.beads/dolt.gate.lock and its .info sidecar), not any
"*.gate.lock*" file, so a new unexpected gate still trips the canary.
- TestCLI_CreateRejectsFlagLikeTitles: a bare `bd create --foo-bar` must
fail and create no issue (bd-2c0's intent), next to the "--" cases.
- TestCustomStatusConfig cites why statuses come back in name order: the
normalized custom_statuses table (#2961, 8537d943b) has no ordinal and is
read ORDER BY name, like custom_types; the test predates it.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* ci(bazel): run the cmd/bd Dolt-server tier in 16 shards
Each shard pays ~30-40 s of fixed cost (TestMain plus its own dolt
sql-server), so 32 shards spent roughly 40% of the lane's executor time on
setup and added 32 farm actions to every PR touching cmd/bd. With the
5001-issue export test cut to under a second, 16 shards measure (locally,
--nocache_test_results): max 186 s, mean 137 s, 2,187 executor-seconds
(vs ~2,800-3,200 at 32), all 3,267 top-level tests, every shard passing.
TestBazelCmdDoltJob pins the count; bazel.yml's timing comment is
restated (cache mode ~20-30 minutes).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Gas City Adopt-PR <adopt-pr@gascity.local>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
752 lines
21 KiB
Go
752 lines
21 KiB
Go
//go:build cgo && integration
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/steveyegge/beads/internal/ado"
|
|
"github.com/steveyegge/beads/internal/storage/dolt"
|
|
"github.com/steveyegge/beads/internal/tracker"
|
|
"github.com/steveyegge/beads/internal/types"
|
|
)
|
|
|
|
// mockADOServer is a stateful mock that stores only what the ADO client sends,
|
|
// plus server-derived fields (WorkItemType from URL, default state, timestamps).
|
|
// Routes match the real URL shape: /{project}/_apis/wit/...
|
|
type mockADOServer struct {
|
|
mu sync.Mutex
|
|
items map[int]*ado.WorkItem
|
|
nextID int
|
|
project string
|
|
}
|
|
|
|
func newMockADOServer(project string) *mockADOServer {
|
|
return &mockADOServer{
|
|
items: make(map[int]*ado.WorkItem),
|
|
nextID: 1,
|
|
project: project,
|
|
}
|
|
}
|
|
|
|
func (m *mockADOServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
path := r.URL.Path
|
|
|
|
switch {
|
|
case strings.Contains(path, "/_apis/wit/wiql"):
|
|
m.handleWIQL(w, r)
|
|
case strings.Contains(path, "/_apis/wit/workitems/$") && r.Method == http.MethodPost:
|
|
m.handleCreate(w, r)
|
|
case strings.Contains(path, "/_apis/wit/workitems") && r.Method == http.MethodGet && !strings.Contains(path, "/_apis/wit/workitems/"):
|
|
m.handleBatchGet(w, r)
|
|
case strings.Contains(path, "/_apis/wit/workitems/") && r.Method == http.MethodPatch:
|
|
m.handleUpdate(w, r)
|
|
default:
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
fmt.Fprintf(w, "unhandled: %s %s", r.Method, path)
|
|
}
|
|
}
|
|
|
|
func (m *mockADOServer) handleWIQL(w http.ResponseWriter, r *http.Request) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
// Return all stored work item IDs.
|
|
refs := make([]ado.WIQLWorkItemRef, 0, len(m.items))
|
|
for id := range m.items {
|
|
refs = append(refs, ado.WIQLWorkItemRef{ID: id})
|
|
}
|
|
resp := ado.WIQLResult{WorkItems: refs}
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.NewEncoder(w).Encode(resp)
|
|
}
|
|
|
|
func (m *mockADOServer) handleBatchGet(w http.ResponseWriter, r *http.Request) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
idsStr := r.URL.Query().Get("ids")
|
|
if idsStr == "" {
|
|
json.NewEncoder(w).Encode(map[string]interface{}{"value": []interface{}{}})
|
|
return
|
|
}
|
|
|
|
var items []ado.WorkItem
|
|
for _, s := range strings.Split(idsStr, ",") {
|
|
id, err := strconv.Atoi(strings.TrimSpace(s))
|
|
if err != nil {
|
|
continue
|
|
}
|
|
if wi, ok := m.items[id]; ok {
|
|
items = append(items, *wi)
|
|
}
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
raw, _ := json.Marshal(items)
|
|
json.NewEncoder(w).Encode(map[string]json.RawMessage{"value": raw})
|
|
}
|
|
|
|
func (m *mockADOServer) handleCreate(w http.ResponseWriter, r *http.Request) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
// Extract type from URL: /{project}/_apis/wit/workitems/$Task
|
|
// Go's HTTP server already URL-decodes the path, so $User%20Story → $User Story.
|
|
path := r.URL.Path
|
|
dollarIdx := strings.LastIndex(path, "/$")
|
|
typeName := "Task"
|
|
if dollarIdx >= 0 {
|
|
typeName = path[dollarIdx+2:]
|
|
}
|
|
// Strip query params if present (shouldn't be, but defensive)
|
|
if qIdx := strings.Index(typeName, "?"); qIdx >= 0 {
|
|
typeName = typeName[:qIdx]
|
|
}
|
|
|
|
body, err := io.ReadAll(r.Body)
|
|
if err != nil {
|
|
http.Error(w, "bad request", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
var ops []ado.PatchOperation
|
|
if err := json.Unmarshal(body, &ops); err != nil {
|
|
http.Error(w, "invalid patch ops", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
id := m.nextID
|
|
m.nextID++
|
|
now := time.Now().UTC().Format("2006-01-02T15:04:05.000Z")
|
|
|
|
fields := map[string]interface{}{
|
|
ado.FieldWorkItemType: typeName,
|
|
ado.FieldCreatedDate: now,
|
|
ado.FieldChangedDate: now,
|
|
ado.FieldAreaPath: m.project,
|
|
ado.FieldTeamProject: m.project,
|
|
}
|
|
|
|
for _, op := range ops {
|
|
if op.Op == "add" || op.Op == "replace" {
|
|
fieldName := strings.TrimPrefix(op.Path, "/fields/")
|
|
fields[fieldName] = op.Value
|
|
}
|
|
}
|
|
|
|
// If no state was set, default to "New" (ADO behavior).
|
|
if _, hasState := fields[ado.FieldState]; !hasState {
|
|
fields[ado.FieldState] = "New"
|
|
}
|
|
|
|
apiURL := fmt.Sprintf("http://localhost/%s/_apis/wit/workItems/%d", m.project, id)
|
|
wi := &ado.WorkItem{
|
|
ID: id,
|
|
Rev: 1,
|
|
Fields: fields,
|
|
URL: apiURL,
|
|
}
|
|
m.items[id] = wi
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.NewEncoder(w).Encode(wi)
|
|
}
|
|
|
|
func (m *mockADOServer) handleUpdate(w http.ResponseWriter, r *http.Request) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
// Extract ID from URL: /{project}/_apis/wit/workitems/{id}
|
|
path := r.URL.Path
|
|
lastSlash := strings.LastIndex(path, "/")
|
|
if lastSlash < 0 {
|
|
http.Error(w, "missing work item ID", http.StatusBadRequest)
|
|
return
|
|
}
|
|
id, err := strconv.Atoi(path[lastSlash+1:])
|
|
if err != nil {
|
|
http.Error(w, "invalid work item ID", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
wi, ok := m.items[id]
|
|
if !ok {
|
|
http.Error(w, "not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
|
|
body, err := io.ReadAll(r.Body)
|
|
if err != nil {
|
|
http.Error(w, "bad request", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
var ops []ado.PatchOperation
|
|
if err := json.Unmarshal(body, &ops); err != nil {
|
|
http.Error(w, "invalid patch ops", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Simulate ADO state transition validation: reject invalid direct jumps.
|
|
// E.g., New→Closed is not allowed (must go through Active→Resolved→Closed).
|
|
currentState, _ := wi.Fields[ado.FieldState].(string)
|
|
for _, op := range ops {
|
|
fieldName := strings.TrimPrefix(op.Path, "/fields/")
|
|
if fieldName == ado.FieldState {
|
|
targetState, _ := op.Value.(string)
|
|
if !m.isValidTransition(currentState, targetState) {
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
json.NewEncoder(w).Encode(map[string]string{
|
|
"message": fmt.Sprintf("Invalid state transition from %q to %q", currentState, targetState),
|
|
})
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
for _, op := range ops {
|
|
if op.Op == "add" || op.Op == "replace" {
|
|
fieldName := strings.TrimPrefix(op.Path, "/fields/")
|
|
wi.Fields[fieldName] = op.Value
|
|
}
|
|
}
|
|
wi.Rev++
|
|
wi.Fields[ado.FieldChangedDate] = time.Now().UTC().Format("2006-01-02T15:04:05.000Z")
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.NewEncoder(w).Encode(wi)
|
|
}
|
|
|
|
// isValidTransition checks if a state transition is allowed (Agile process).
|
|
// Rejects jumps that skip intermediate states (e.g., New→Closed).
|
|
func (m *mockADOServer) isValidTransition(from, to string) bool {
|
|
if from == to {
|
|
return true
|
|
}
|
|
// Model simplified Agile transitions.
|
|
allowed := map[string]map[string]bool{
|
|
"New": {"Active": true},
|
|
"Active": {"New": true, "Resolved": true, "Closed": true},
|
|
"Resolved": {"Active": true, "Closed": true},
|
|
"Closed": {"Active": true},
|
|
}
|
|
if targets, ok := allowed[from]; ok {
|
|
return targets[to]
|
|
}
|
|
// Unknown states: allow anything.
|
|
return true
|
|
}
|
|
|
|
func (m *mockADOServer) itemCount() int {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
return len(m.items)
|
|
}
|
|
|
|
// adoTestStore creates a DoltStore for ADO round-trip tests using the Docker
|
|
// container infrastructure. Uses newTestStoreIsolatedDB for per-test DB isolation.
|
|
func adoTestStore(t *testing.T, prefix string) *dolt.DoltStore {
|
|
t.Helper()
|
|
// ado.pat is a secret, read from config.yaml or AZURE_DEVOPS_PAT and
|
|
// never from the database (config.IsYamlOnlyKey), so a SetConfig of it
|
|
// on the store would leave the tracker without a PAT.
|
|
t.Setenv("AZURE_DEVOPS_PAT", "test-pat")
|
|
dbPath := filepath.Join(t.TempDir(), ".beads", "dolt")
|
|
return newTestStoreIsolatedDB(t, dbPath, prefix)
|
|
}
|
|
|
|
// TestADORoundTripCoreFields tests push→pull fidelity for core fields:
|
|
// title, description, priority, status, type, and external_ref.
|
|
func TestADORoundTripCoreFields(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
project := "TestProject"
|
|
|
|
// --- 1. Setup source DB ---
|
|
sourceStore := adoTestStore(t, "bd")
|
|
|
|
// Start mock server
|
|
mock := newMockADOServer(project)
|
|
server := httptest.NewServer(mock)
|
|
defer server.Close()
|
|
|
|
// Configure ADO settings in source store
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := sourceStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig(%s): %v", k, err)
|
|
}
|
|
}
|
|
|
|
// --- 2. Seed source DB with varied issues ---
|
|
type seedIssue struct {
|
|
title string
|
|
description string
|
|
priority int
|
|
status types.Status
|
|
issueType types.IssueType
|
|
}
|
|
seeds := []seedIssue{
|
|
{"Critical security fix", "Fix the auth bypass vulnerability", 0, types.StatusOpen, types.TypeBug},
|
|
{"Add search feature", "Implement full-text search for issues", 1, types.StatusInProgress, types.TypeFeature},
|
|
{"Update dependencies", "Routine dep update for Q2", 3, types.StatusClosed, types.TypeTask},
|
|
}
|
|
|
|
sourceIssueIDs := make([]string, 0, len(seeds))
|
|
for i, s := range seeds {
|
|
issue := &types.Issue{
|
|
ID: fmt.Sprintf("bd-rt-%d", i),
|
|
Title: s.title,
|
|
Description: s.description,
|
|
Priority: s.priority,
|
|
Status: s.status,
|
|
IssueType: s.issueType,
|
|
}
|
|
if s.status == types.StatusClosed {
|
|
now := time.Now()
|
|
issue.ClosedAt = &now
|
|
}
|
|
if err := sourceStore.CreateIssue(ctx, issue, "test-actor"); err != nil {
|
|
t.Fatalf("CreateIssue(%s): %v", issue.ID, err)
|
|
}
|
|
sourceIssueIDs = append(sourceIssueIDs, issue.ID)
|
|
}
|
|
|
|
// --- 3. Push to mock ADO ---
|
|
at := &ado.Tracker{}
|
|
if err := at.Init(ctx, sourceStore); err != nil {
|
|
t.Fatalf("Tracker.Init: %v", err)
|
|
}
|
|
|
|
pushEngine := tracker.NewEngine(at, sourceStore, "test-actor")
|
|
|
|
pushResult, err := pushEngine.Sync(ctx, tracker.SyncOptions{Push: true})
|
|
if err != nil {
|
|
t.Fatalf("Push sync failed: %v", err)
|
|
}
|
|
if pushResult.Stats.Created != len(seeds) {
|
|
t.Fatalf("expected %d pushed, got created=%d", len(seeds), pushResult.Stats.Created)
|
|
}
|
|
|
|
// Verify external refs were written
|
|
for _, id := range sourceIssueIDs {
|
|
issue, err := sourceStore.GetIssue(ctx, id)
|
|
if err != nil {
|
|
t.Fatalf("GetIssue(%s) after push: %v", id, err)
|
|
}
|
|
if issue.ExternalRef == nil || *issue.ExternalRef == "" {
|
|
t.Errorf("issue %s: expected external_ref after push, got nil", id)
|
|
}
|
|
}
|
|
|
|
// Verify mock server received all issues
|
|
if got := mock.itemCount(); got != len(seeds) {
|
|
t.Fatalf("mock server has %d items, want %d", got, len(seeds))
|
|
}
|
|
|
|
// --- 4. Setup target DB (fresh) ---
|
|
targetStore := adoTestStore(t, "bd")
|
|
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := targetStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig(%s) target: %v", k, err)
|
|
}
|
|
}
|
|
|
|
// --- 5. Pull from mock ADO into fresh DB ---
|
|
at2 := &ado.Tracker{}
|
|
if err := at2.Init(ctx, targetStore); err != nil {
|
|
t.Fatalf("Tracker.Init (target): %v", err)
|
|
}
|
|
|
|
pullEngine := tracker.NewEngine(at2, targetStore, "test-actor")
|
|
pullEngine.PullHooks = buildADOPullHooksForTest(ctx, targetStore)
|
|
|
|
pullResult, err := pullEngine.Sync(ctx, tracker.SyncOptions{Pull: true})
|
|
if err != nil {
|
|
t.Fatalf("Pull sync failed: %v", err)
|
|
}
|
|
if pullResult.Stats.Created != len(seeds) {
|
|
t.Fatalf("expected %d pulled/created, got created=%d", len(seeds), pullResult.Stats.Created)
|
|
}
|
|
|
|
// --- 6. Assert fidelity ---
|
|
pulledIssues, err := targetStore.SearchIssues(ctx, "", types.IssueFilter{})
|
|
if err != nil {
|
|
t.Fatalf("SearchIssues on target: %v", err)
|
|
}
|
|
if len(pulledIssues) != len(seeds) {
|
|
t.Fatalf("target has %d issues, want %d", len(pulledIssues), len(seeds))
|
|
}
|
|
|
|
pulledByRef := make(map[string]*types.Issue)
|
|
for _, issue := range pulledIssues {
|
|
if issue.ExternalRef != nil && *issue.ExternalRef != "" {
|
|
pulledByRef[*issue.ExternalRef] = issue
|
|
}
|
|
}
|
|
|
|
for i, id := range sourceIssueIDs {
|
|
source, err := sourceStore.GetIssue(ctx, id)
|
|
if err != nil {
|
|
t.Fatalf("GetIssue(%s) from source: %v", id, err)
|
|
}
|
|
if source.ExternalRef == nil {
|
|
t.Fatalf("source issue %s has no external_ref", id)
|
|
}
|
|
|
|
pulled, ok := pulledByRef[*source.ExternalRef]
|
|
if !ok {
|
|
t.Fatalf("seed[%d] %s: no pulled issue with external_ref %s", i, id, *source.ExternalRef)
|
|
}
|
|
|
|
t.Run(fmt.Sprintf("seed_%d_%s", i, source.Title), func(t *testing.T) {
|
|
if pulled.Title != source.Title {
|
|
t.Errorf("title: got %q, want %q", pulled.Title, source.Title)
|
|
}
|
|
|
|
if pulled.Priority != source.Priority {
|
|
t.Errorf("priority: got %d, want %d", pulled.Priority, source.Priority)
|
|
}
|
|
|
|
if pulled.Status != source.Status {
|
|
t.Errorf("status: got %q, want %q", pulled.Status, source.Status)
|
|
}
|
|
|
|
if pulled.IssueType != source.IssueType {
|
|
t.Errorf("type: got %q, want %q", pulled.IssueType, source.IssueType)
|
|
}
|
|
|
|
if pulled.ExternalRef == nil || *pulled.ExternalRef != *source.ExternalRef {
|
|
pulledRef := "<nil>"
|
|
if pulled.ExternalRef != nil {
|
|
pulledRef = *pulled.ExternalRef
|
|
}
|
|
t.Errorf("external_ref: got %q, want %q", pulledRef, *source.ExternalRef)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestADORoundTripBlockedStatus tests that blocked status survives a round-trip
|
|
// via the beads:blocked tag mechanism (ADO has no native blocked state).
|
|
func TestADORoundTripBlockedStatus(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
project := "TestProject"
|
|
|
|
sourceStore := adoTestStore(t, "bd")
|
|
|
|
mock := newMockADOServer(project)
|
|
server := httptest.NewServer(mock)
|
|
defer server.Close()
|
|
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := sourceStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig(%s): %v", k, err)
|
|
}
|
|
}
|
|
|
|
// Create a blocked issue
|
|
issue := &types.Issue{
|
|
ID: "bd-blocked-1",
|
|
Title: "Blocked on upstream fix",
|
|
Status: types.StatusBlocked,
|
|
IssueType: types.TypeTask,
|
|
Priority: 2,
|
|
}
|
|
if err := sourceStore.CreateIssue(ctx, issue, "test-actor"); err != nil {
|
|
t.Fatalf("CreateIssue: %v", err)
|
|
}
|
|
|
|
// Push
|
|
at := &ado.Tracker{}
|
|
if err := at.Init(ctx, sourceStore); err != nil {
|
|
t.Fatalf("Init: %v", err)
|
|
}
|
|
pushEngine := tracker.NewEngine(at, sourceStore, "test-actor")
|
|
if _, err := pushEngine.Sync(ctx, tracker.SyncOptions{Push: true}); err != nil {
|
|
t.Fatalf("Push: %v", err)
|
|
}
|
|
|
|
// Pull into fresh DB
|
|
targetStore := adoTestStore(t, "bd")
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := targetStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig target: %v", err)
|
|
}
|
|
}
|
|
|
|
at2 := &ado.Tracker{}
|
|
if err := at2.Init(ctx, targetStore); err != nil {
|
|
t.Fatalf("Init target: %v", err)
|
|
}
|
|
pullEngine := tracker.NewEngine(at2, targetStore, "test-actor")
|
|
pullEngine.PullHooks = buildADOPullHooksForTest(ctx, targetStore)
|
|
if _, err := pullEngine.Sync(ctx, tracker.SyncOptions{Pull: true}); err != nil {
|
|
t.Fatalf("Pull: %v", err)
|
|
}
|
|
|
|
pulled, err := targetStore.SearchIssues(ctx, "", types.IssueFilter{})
|
|
if err != nil {
|
|
t.Fatalf("SearchIssues: %v", err)
|
|
}
|
|
if len(pulled) != 1 {
|
|
t.Fatalf("got %d issues, want 1", len(pulled))
|
|
}
|
|
if pulled[0].Status != types.StatusBlocked {
|
|
t.Errorf("status: got %q, want %q", pulled[0].Status, types.StatusBlocked)
|
|
}
|
|
}
|
|
|
|
// TestADORoundTripLossyPriority tests the lossy priority mapping behavior.
|
|
// beads priorities 3 and 4 both map to ADO priority 4. On a fresh pull, ADO 4
|
|
// maps back to beads 3, so priority 4 (Backlog) is lost. This test documents
|
|
// the current behavior:
|
|
// - P3 survives round-trip (ADO 4 → beads 3)
|
|
// - P4 degrades to P3 (ADO 4 → beads 3) — this is a known lossy mapping
|
|
func TestADORoundTripLossyPriority(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
project := "TestProject"
|
|
|
|
sourceStore := adoTestStore(t, "bd")
|
|
|
|
mock := newMockADOServer(project)
|
|
server := httptest.NewServer(mock)
|
|
defer server.Close()
|
|
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := sourceStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig(%s): %v", k, err)
|
|
}
|
|
}
|
|
|
|
// Create issues with priority 3 (Low) and 4 (Backlog) — both map to ADO 4
|
|
for _, p := range []int{3, 4} {
|
|
issue := &types.Issue{
|
|
ID: fmt.Sprintf("bd-lossy-p%d", p),
|
|
Title: fmt.Sprintf("Priority %d issue", p),
|
|
Status: types.StatusOpen,
|
|
IssueType: types.TypeTask,
|
|
Priority: p,
|
|
}
|
|
if err := sourceStore.CreateIssue(ctx, issue, "test-actor"); err != nil {
|
|
t.Fatalf("CreateIssue(p%d): %v", p, err)
|
|
}
|
|
}
|
|
|
|
// Push to ADO
|
|
at := &ado.Tracker{}
|
|
if err := at.Init(ctx, sourceStore); err != nil {
|
|
t.Fatalf("Init: %v", err)
|
|
}
|
|
pushEngine := tracker.NewEngine(at, sourceStore, "test-actor")
|
|
if _, err := pushEngine.Sync(ctx, tracker.SyncOptions{Push: true}); err != nil {
|
|
t.Fatalf("Push: %v", err)
|
|
}
|
|
|
|
// Pull into fresh DB (simulating a different machine)
|
|
targetStore := adoTestStore(t, "bd")
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := targetStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig target: %v", err)
|
|
}
|
|
}
|
|
|
|
at2 := &ado.Tracker{}
|
|
if err := at2.Init(ctx, targetStore); err != nil {
|
|
t.Fatalf("Init target: %v", err)
|
|
}
|
|
pullEngine := tracker.NewEngine(at2, targetStore, "test-actor")
|
|
pullEngine.PullHooks = buildADOPullHooksForTest(ctx, targetStore)
|
|
if _, err := pullEngine.Sync(ctx, tracker.SyncOptions{Pull: true}); err != nil {
|
|
t.Fatalf("Pull: %v", err)
|
|
}
|
|
|
|
pulled, err := targetStore.SearchIssues(ctx, "", types.IssueFilter{})
|
|
if err != nil {
|
|
t.Fatalf("SearchIssues: %v", err)
|
|
}
|
|
if len(pulled) != 2 {
|
|
t.Fatalf("got %d issues, want 2", len(pulled))
|
|
}
|
|
|
|
// P3 survives perfectly (ADO 4 → beads 3)
|
|
// P4 degrades to P3 (known lossy mapping: ADO 4 → beads 3)
|
|
for _, issue := range pulled {
|
|
switch {
|
|
case strings.Contains(issue.Title, "Priority 3"):
|
|
if issue.Priority != 3 {
|
|
t.Errorf("P3 issue: got priority %d, want 3", issue.Priority)
|
|
}
|
|
case strings.Contains(issue.Title, "Priority 4"):
|
|
// Documented lossy behavior: P4 becomes P3 after fresh round-trip
|
|
if issue.Priority != 3 {
|
|
t.Errorf("P4 issue (lossy): got priority %d, want 3 (degraded from 4)", issue.Priority)
|
|
}
|
|
default:
|
|
t.Errorf("unexpected issue title: %q", issue.Title)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestADORoundTripLabels tests that user labels survive a round-trip and
|
|
// internal beads:* tags are correctly filtered on pull.
|
|
func TestADORoundTripLabels(t *testing.T) {
|
|
|
|
ctx := context.Background()
|
|
project := "TestProject"
|
|
|
|
sourceStore := adoTestStore(t, "bd")
|
|
|
|
mock := newMockADOServer(project)
|
|
server := httptest.NewServer(mock)
|
|
defer server.Close()
|
|
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := sourceStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig(%s): %v", k, err)
|
|
}
|
|
}
|
|
|
|
issue := &types.Issue{
|
|
ID: "bd-labels-1",
|
|
Title: "Issue with labels",
|
|
Status: types.StatusOpen,
|
|
IssueType: types.TypeBug,
|
|
Priority: 1,
|
|
Labels: []string{"backend", "urgent", "api"},
|
|
}
|
|
if err := sourceStore.CreateIssue(ctx, issue, "test-actor"); err != nil {
|
|
t.Fatalf("CreateIssue: %v", err)
|
|
}
|
|
|
|
// Push
|
|
at := &ado.Tracker{}
|
|
if err := at.Init(ctx, sourceStore); err != nil {
|
|
t.Fatalf("Init: %v", err)
|
|
}
|
|
pushEngine := tracker.NewEngine(at, sourceStore, "test-actor")
|
|
if _, err := pushEngine.Sync(ctx, tracker.SyncOptions{Push: true}); err != nil {
|
|
t.Fatalf("Push: %v", err)
|
|
}
|
|
|
|
// Pull into fresh DB
|
|
targetStore := adoTestStore(t, "bd")
|
|
for k, v := range map[string]string{
|
|
"ado.url": server.URL,
|
|
"ado.project": project,
|
|
} {
|
|
if err := targetStore.SetConfig(ctx, k, v); err != nil {
|
|
t.Fatalf("SetConfig target: %v", err)
|
|
}
|
|
}
|
|
|
|
at2 := &ado.Tracker{}
|
|
if err := at2.Init(ctx, targetStore); err != nil {
|
|
t.Fatalf("Init target: %v", err)
|
|
}
|
|
pullEngine := tracker.NewEngine(at2, targetStore, "test-actor")
|
|
pullEngine.PullHooks = buildADOPullHooksForTest(ctx, targetStore)
|
|
if _, err := pullEngine.Sync(ctx, tracker.SyncOptions{Pull: true}); err != nil {
|
|
t.Fatalf("Pull: %v", err)
|
|
}
|
|
|
|
pulled, err := targetStore.SearchIssues(ctx, "", types.IssueFilter{})
|
|
if err != nil {
|
|
t.Fatalf("SearchIssues: %v", err)
|
|
}
|
|
if len(pulled) != 1 {
|
|
t.Fatalf("got %d issues, want 1", len(pulled))
|
|
}
|
|
|
|
// Verify labels survived and no beads:* tags leaked through
|
|
gotLabels := pulled[0].Labels
|
|
wantLabels := []string{"backend", "urgent", "api"}
|
|
if len(gotLabels) != len(wantLabels) {
|
|
t.Errorf("labels: got %v, want %v", gotLabels, wantLabels)
|
|
} else {
|
|
gotSet := make(map[string]bool)
|
|
for _, l := range gotLabels {
|
|
gotSet[l] = true
|
|
}
|
|
for _, l := range wantLabels {
|
|
if !gotSet[l] {
|
|
t.Errorf("missing label %q in pulled issue", l)
|
|
}
|
|
}
|
|
}
|
|
// Ensure no beads:* tags leaked
|
|
for _, l := range gotLabels {
|
|
if strings.HasPrefix(l, "beads:") {
|
|
t.Errorf("internal tag leaked through: %q", l)
|
|
}
|
|
}
|
|
}
|
|
|
|
// buildADOPullHooksForTest mirrors buildADOPullHooks from ado.go but works
|
|
// with an explicit store instead of global state.
|
|
func buildADOPullHooksForTest(ctx context.Context, st interface {
|
|
SearchIssues(ctx context.Context, query string, filter types.IssueFilter) ([]*types.Issue, error)
|
|
}) *tracker.PullHooks {
|
|
hooks := &tracker.PullHooks{}
|
|
|
|
existingIssues, err := st.SearchIssues(ctx, "", types.IssueFilter{})
|
|
usedIDs := make(map[string]bool)
|
|
if err == nil {
|
|
for _, issue := range existingIssues {
|
|
if issue.ID != "" {
|
|
usedIDs[issue.ID] = true
|
|
}
|
|
}
|
|
}
|
|
|
|
seq := 0
|
|
hooks.GenerateID = func(_ context.Context, issue *types.Issue) error {
|
|
if issue.ID == "" {
|
|
seq++
|
|
issue.ID = fmt.Sprintf("bd-ado-%d", seq)
|
|
for usedIDs[issue.ID] {
|
|
seq++
|
|
issue.ID = fmt.Sprintf("bd-ado-%d", seq)
|
|
}
|
|
usedIDs[issue.ID] = true
|
|
}
|
|
return nil
|
|
}
|
|
|
|
return hooks
|
|
}
|