bd admin compact --tier 2 hard-errors "not yet implemented", yet the command help, --stats output, and several docs advertised "Tier 2: Ultra compression (90 days closed, 95% reduction)" as if it worked. Make the surface honest: - Reject --tier != 1 early with a clear "not yet implemented; only --tier 1 is available" message instead of failing deep inside a mode. - --stats labels Tier 2 "not yet implemented" and drops the bogus 95% savings estimate; the JSON tier2 block gains "implemented": false. - Update command/flag help, the plugin skill doc, and the examples README; regenerate the generated CLI reference. New embedded e2e asserts --tier 2 errors and --stats no longer advertises 95%. No attempt to implement Tier 2 (semantics undefined); only the false advertising is removed. Refs #4463 Agent-Signature: claude-opus-4-8-high on behalf of maphew
54 lines
1.7 KiB
Go
54 lines
1.7 KiB
Go
//go:build cgo
|
|
|
|
package main
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestEmbeddedAdminCompactTier2Honesty verifies that the unimplemented Tier 2
|
|
// is not advertised as a working capability: invoking it errors with a clear
|
|
// "not yet implemented" message, and --stats does not promise Tier 2 savings.
|
|
func TestEmbeddedAdminCompactTier2Honesty(t *testing.T) {
|
|
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
|
|
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt integration tests")
|
|
}
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
dir, _, _ := bdInit(t, bd, "--prefix", "t2")
|
|
|
|
t.Run("tier2_rejected", func(t *testing.T) {
|
|
// --analyze reaches the tier guard (read-only, direct-mode path).
|
|
cmd := exec.Command(bd, "admin", "compact", "--analyze", "--tier", "2")
|
|
cmd.Dir = dir
|
|
cmd.Env = bdEnv(dir)
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
t.Fatalf("expected --tier 2 to fail, but succeeded:\n%s", out)
|
|
}
|
|
if !strings.Contains(string(out), "not yet implemented") {
|
|
t.Errorf("expected 'not yet implemented' message, got:\n%s", out)
|
|
}
|
|
})
|
|
|
|
t.Run("stats_does_not_advertise_tier2", func(t *testing.T) {
|
|
cmd := exec.Command(bd, "admin", "compact", "--stats")
|
|
cmd.Dir = dir
|
|
cmd.Env = bdEnv(dir)
|
|
stdout, stderr, err := runCommandBuffers(t, cmd)
|
|
if err != nil {
|
|
t.Fatalf("bd admin compact --stats failed: %v\nstdout:\n%s\nstderr:\n%s", err, stdout.String(), stderr.String())
|
|
}
|
|
out := stdout.String()
|
|
if !strings.Contains(out, "not yet implemented") {
|
|
t.Errorf("expected Tier 2 to be marked 'not yet implemented' in --stats, got:\n%s", out)
|
|
}
|
|
if strings.Contains(out, "95%") {
|
|
t.Errorf("--stats still advertises a Tier 2 savings estimate (95%%):\n%s", out)
|
|
}
|
|
})
|
|
}
|