beads/cmd/bd/config_proxied_server.go
CI Bot 67d38d2620 Trim this series' comments toward the repo's own density
Ten agents over 216 files, one directory-balanced group each, working to a
rubric that named what to cut (duplication narration, restatement of the next
line, the governing rule echoed in every command file, throat-clearing) and
what to keep (traps, invariants, security, tracker ids, behaviour changes, and
the "why a naive simplification destroys this assertion" rationale).

Net 1,523 lines. Density against this repo's own per-directory norm on main:

  cmd/bd              33.6% -> 27.3%   (main 10.7%)
  internal/storage    26.1% -> 23.1%   (main 14.1%)
  backend/conformance 34.0% -> 29.6%   (main 22.8%)
  internal/httpapi    30.9% -> 27.8%   (main 30.6%, now below)
  overall             34.7% -> 31.6%

Every agent landed at 18-25% rather than the 30% asked for, and every one gave
the same reason independently: what remained was on the keep list. Ten separate
judgements agreeing is the most useful result here — the prose is dense, but it
is mostly load-bearing, and the shortfall is the honest answer rather than a
failure to try.

TWO REVERTS, both to protect something worth more than the lines.

issueops/ is back to its pre-trim state, giving up 610 lines. The conformance
contracts cite the leaf docs BY LINE — "pins treewalker.go:52-66" — 155 times.
Trimming the cited files silently repointed those at whatever text moved into
those numbers, across agent boundaries so no agent could see it. A semantic
remapper recovered 141 of them, but 23 needed judgement and several landed on
struct fields. The leaf docs are the spec the contracts are written against;
they are the one place in this change where dense prose IS the deliverable, and
keeping them stable is worth more than the 610 lines. tree_walker_contract.go
and version_reconciler_contract.go went back for the same reason: an agent had
deleted a paragraph containing a citation, so positional restoration could not
align them.

After the reverts, exactly 5 citations point into a still-trimmed file and 2 of
those are weak — both in cmd/bd/config_guard_test.go, which this series never
touched and whose citations were already wrong on main (init.go:361 pointed at
a closing brace; the guard it names is at init.go:1499).

VERIFICATION. A guard strips every comment and all whitespace from each of the
193 modified files at HEAD and in the worktree and requires the two to be
byte-identical, so a code change cannot hide in a comment diff. It handles `//`
inside string and raw-string literals, and was tested against a deliberate code
change before being trusted. gofmt clean, go build, go vet, golangci-lint 0
issues, and the two AST-based tests that PARSE trimmed files — the timed
provider binding pin over claim.go and the serve database-source gate over
serve.go — both pass.

One real defect found while trimming: checkDatabaseSource's doc block ran into
`// sourceRoles is ...` with no blank line, so godoc attached thirty-one lines
of the wrong prose to func sourceRoles and left checkDatabaseSource
undocumented. Fixed by separating them.
2026-08-06 08:06:59 +00:00

60 lines
2.3 KiB
Go

package main
import (
"context"
"errors"
"fmt"
"github.com/steveyegge/beads/internal/storage/uow"
"github.com/steveyegge/beads/issueops"
)
// proxiedWorkspaceConfig hands back the guarded workspace-settings surface for
// the proxied-server provider, through the provider's OWN capability accessor —
// the same two-step proxiedCounter performs.
//
// Routing the four single-key `bd config` verbs through the role fixed a copy
// that had drifted: the proxied `set` stored `status.custom` without
// re-synchronizing the custom_statuses and custom_types tables that reads
// consult FIRST, so a proxied `bd config set types.custom` reported success and
// never took effect.
func proxiedWorkspaceConfig() (issueops.WorkspaceConfig, error) {
if uowProvider == nil {
return nil, errors.New("proxied-server UOW provider not initialized")
}
src, ok := uowProvider.(uow.WorkspaceConfigSource)
if !ok {
return nil, fmt.Errorf("proxied-server provider %T does not offer the workspace-settings surface", uowProvider)
}
return src.WorkspaceConfig()
}
// runConfigSetManyProxiedServer writes a whole batch of settings in ONE unit of
// work, which is the fifth verb and the one that stays off the role.
//
// The batch is the point of `bd config set-many` — one Dolt commit for N keys
// rather than N, which is what makes it usable in CI — and
// TestProxiedServerConfigSetMany pins it. issueops.WorkspaceConfig writes one
// setting per call and commits each, as its contract says, so routing this
// through it would turn a three-key batch into three commits.
//
// It does NOT re-implement the role's refusals: cmd/bd/config.go applies them
// to every pair, before any of them is written.
func runConfigSetManyProxiedServer(ctx context.Context, keys, values []string) error {
if len(keys) == 0 {
return nil
}
if uowProvider == nil {
return HandleErrorRespectJSON("proxied-server UOW provider not initialized")
}
return uow.RunTx(ctx, uowProvider, func(ctx context.Context, uw uow.UnitOfWork) (string, error) {
cfgUC := uw.ConfigUseCase()
for i, k := range keys {
if err := cfgUC.SetConfig(ctx, k, values[i]); err != nil {
return "", fmt.Errorf("setting config %s: %w", k, err)
}
}
return fmt.Sprintf("bd: config set-many (%d keys)", len(keys)), nil
})
}