* test(bazel): isolate the bazel test environment like pr-core's go test Every `bazel test` process now runs under //tools/bazel:test_env (wired with `test --run_under`), a wrapper that mirrors scripts/ci/lib/test-env.sh: a private HOME/USERPROFILE, XDG_CONFIG_HOME, DOLT_ROOT_PATH and empty GIT_CONFIG_GLOBAL, GIT_CONFIG_NOSYSTEM, BEADS_TEST_IGNORE_REPO_CONFIG, and the same scrub of workspace/Dolt-server variables. Everything lives in one fresh mktemp directory under /tmp that is removed when the test exits, so TMPDIR (t.TempDir) stays short enough for unix sockets and is never shared between concurrent runs. This replaces `--test_env=HOME` (the client's HOME string entered the action key and was shipped to remote workers, where it does not exist: the embeddeddolt suite panicked on "stat /home/ubuntu") and the shared `--test_tmpdir=/tmp/bbt`. No host path or client env enters the action key. bd_test (~10 min under -race -short) and embeddeddolt_test (~6 min) get size = "large" / timeout = "long" instead of Bazel's 300 s default; pr-core gives go test -timeout=30m. rules_shell (already in the module graph) becomes a direct dep for sh_binary. MODULE.bazel.lock records the pybind11 extension that building these test targets evaluates, so `make bazel-sync` is stable. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(bazel): inject the bd binary into subprocess tests (slice B3) Tests that exec bd used to `go build` it themselves, which cannot work under `bazel test` (no Go toolchain or module tree in the sandbox or on a remote worker): 135 cmd/bd subtests failed with "go build failed", and protocol, doctor and uow failed the same way. - //cmd/bd:bd_for_tests: a go_binary named bd, race = "off" (the non-race gms_pure_go binary these tests build today, even under --config=prcore). - bd_test, protocol_test, doctor_test and uow_test declare it as data and set BEADS_TEST_BD_BINARY to its $(rlocationpath). - bazeltest.PrebuiltBD is the one resolver: under Bazel it resolves the rlocationpath through runfiles (via the new bazeltest.RunfileEnv) and requires it; under plain go test it keeps today's semantics (absolute form of BEADS_TEST_BD_BINARY, or "" so the caller builds bd). - cmd/bd's findPrebuiltBDBinary delegates to it, and the sites that read the variable by hand (init_embedded, shared_server_integration, cli_fast, migrate front door) now go through findPrebuiltBDBinary; uow calls it directly. - Raw `go build` sites that never honored the variable (protocol, doctor dolt_e2e, test/conformance e2e, internal/beads integration TestMain) use it only under Bazel, so go test is unchanged; protocol and doctor fail instead of skipping when the injection is miswired. tests/regression is left alone (it builds candidate and baseline binaries on purpose). - The read-only canary still forces a source build under go test; under Bazel the injected binary is already built from this tree. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(bazel): declare what cmd/bd and doctor tests read under bazel With bd injected, the remaining //cmd/bd:bd_test and //cmd/bd/doctor failures under `bazel test` were inputs the tests read from the checkout without declaring them (they were hidden behind the go-build failures before): - source-scanning guards (capability registry, events-journal construction, serve database source) parse cmd/bd, cmd/bd/doctor, cmd/bd/doctor/fix and internal/storage/embeddeddolt/cmd: those packages get go_srcs filegroups (tools/bazel/go_srcs.py) declared as data; serve_test resolves its package dir with bazeltest.CallerDir. - .githooks (managed-section parity) and examples/formulas/primitives are declared through //:bd_test_files. - the gofmt preflight tests exec gofmt: under Bazel they use the Go SDK's, declared as data and named by BEADS_TEST_GOFMT (bazeltest.RunfileEnv). - TestGOMODCACHENotUnderTestHome guards in-test `go build`, which does not happen under Bazel, so it skips there. - doctor's TestCheckDeletionsManifest_LegacyFile only passed because the process cwd happened to be inside a git checkout; its fixture is now a git repo and the check runs in it. go test behavior is unchanged except that the deletions-manifest test no longer depends on the caller's cwd. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(bazel): give test_env a dolt identity; never fail on cleanup beads_test_env_enter sets a dolt user.name/user.email in the fresh DOLT_ROOT_PATH; test_env.sh created it empty, so tests that shell out to dolt (remotecache, storage/dolt) failed with 'Author identity unknown'. Write config_global.json directly (no dolt exec per test). Also keep rm -rf in the EXIT trap from overriding the test's exit status when a leftover child is still writing to the tmp root. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * build(bazel): re-sync BUILD files with main Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
45 lines
1.6 KiB
Go
45 lines
1.6 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/testutil/bazeltest"
|
|
)
|
|
|
|
// TestGOMODCACHENotUnderTestHome guards the testMainInner fix that pins
|
|
// GOMODCACHE before re-homing HOME to a temp dir. The default module cache
|
|
// is $HOME/go/pkg/mod; if it is left to follow the fake test HOME, every
|
|
// in-test `go build` (buildEmbeddedBD) re-downloads the full module set —
|
|
// slow, and a hard failure when offline.
|
|
//
|
|
// By the time any test runs, TestMain -> testMainInner has already:
|
|
// - set HOME to a temp dir (testTempRoot), and
|
|
// - pinned GOMODCACHE to the real module cache.
|
|
//
|
|
// So GOMODCACHE must be set and must NOT resolve under the current HOME.
|
|
func TestGOMODCACHENotUnderTestHome(t *testing.T) {
|
|
if bazeltest.IsBazel() {
|
|
t.Skip("no in-test go build under bazel: bd is injected through BEADS_TEST_BD_BINARY")
|
|
}
|
|
home := os.Getenv("HOME")
|
|
if home == "" {
|
|
t.Skip("HOME not set; testMainInner did not run")
|
|
}
|
|
|
|
modcache := os.Getenv("GOMODCACHE")
|
|
if modcache == "" {
|
|
t.Fatalf("GOMODCACHE is empty after test setup: the module cache will default to $HOME/go/pkg/mod (%s), forcing buildEmbeddedBD to re-download every dependency into the temp HOME",
|
|
filepath.Join(home, "go", "pkg", "mod"))
|
|
}
|
|
|
|
absHome, _ := filepath.Abs(home)
|
|
absCache, _ := filepath.Abs(modcache)
|
|
rel, err := filepath.Rel(absHome, absCache)
|
|
if err == nil && rel != ".." && !strings.HasPrefix(rel, ".."+string(filepath.Separator)) && rel != "." {
|
|
t.Fatalf("GOMODCACHE (%s) resolves under the test HOME (%s): the module cache followed the fake HOME, so buildEmbeddedBD must re-download all modules",
|
|
absCache, absHome)
|
|
}
|
|
}
|