* ci(bazel): embedded-Dolt tier 20/5 -> 40/14 duration-balanced shards (F1)
Give the Bazel-only bazel-embedded job its own duration-balanced manifest
blocks for //cmd/bd:bd_embedded_test (20 -> 40 shards) and
//internal/storage/embeddeddolt:embeddeddolt_embedded_test (5 -> 14
shards), decoupled from PR Risk's/main.yml's legacy frozen 20/5-shard
fork/push jobs, mirroring F2's bd_proxied_test precedent.
- Measured every TestEmbedded* / embeddeddolt test's wall time in
isolation; split 21 cmd-tier and 1 storage-tier single top-level test
over 180s into disjoint sub-tests (3 irreducible exceptions left:
TestEmbeddedUpdateConcurrent 475s, TestEmbeddedCloseConcurrent 308s,
TestLargeBatchApplyStatementCounts712_Embedded 261s).
- New scripts/ci/gen_embedded_{cmd,storage}_shard_manifest.py +
_embedded_shard_manifest_lib.py generate/check duration-balanced
manifest blocks (LPT packing, incremental --write/--repack, exact-once
--check), chosen at N=40/M=14 where the heaviest shard reaches the
irreducible-test floor.
- Fixed 18 stale legacy 20-shard cmd manifest entries (and 1 storage
entry) left over from earlier test splits, which would have hard-failed
every shard of PR Risk's real test-embedded-cmd jobs on their next run.
- New scripts/embedded_shard_count_test.go policy tests tie the
Bazel-only block's shard count to bazel.yml's check_shard_coverage.py
argument and catch generator staleness; generalized
TestBazelRetiredLanesCheckListedTestsRan's live-shard-count dispatch
from bd_proxied_test-only to a map covering both embedded targets;
removed TestBazelEmbeddedJobMirrorsEmbeddedTier's now-invalid
BUILD.bazel-shard-count-equals-PR-Risk-matrix assertion.
- Verified: go test ./scripts/..., bazel test //scripts:scripts_test,
actionlint, make ci-pr-policy, make bazel-sync-check all pass; full
local bazel test of both targets at 40/14 shards passes 2/2; mutation
testing confirms each new/changed policy test fails exactly when it
should.
See ~/beads-bazel-plan/f1/impl-report.md for full detail.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* fix(embedded-dolt): skip 712-item statement-count assertion under -race (F1)
TestLargeBatchApplyStatementCounts712_Embedded genuinely costs ~260-300s
under -race (confirmed by solo re-measurement: 298.60s) -- 14014 real SQL
statement round-trips through the race-instrumented in-process Dolt engine,
not an artifact and not splittable (one indivisible ApplyBatchInTx
transaction). It was the storage tier's single-test floor for CI shard
packing.
Apply the exact precedent TestLargeBatchApplyWallClock_Embedded already set
for its 1000-item shape: skip this assertion under raceEnabled (the cost is
race-instrumentation overhead on the Dolt engine's own internal
goroutine/lock machinery, not this test's own logic) and extend nightly.yml's
"Embedded Dolt batch-apply suite (non-race)" step's -run regex so the full
pinned 14014-statement baseline still runs, non-race, every night. Verified
directly: under -race the assertion now skips in 0.00s; without -race it
still runs and asserts Total=14015 (within the existing +/-2 tolerance) in
36.76s.
Updates scripts/ci_workflow_test.go's
TestNightlyFullTestRunsEmbeddedDoltBatchApplySuite to match the extended
regex.
Storage tier's new single-test ceiling under the per-PR -race lane drops
from ~260.7s to 152.38s (TestBatchApplyContract).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* ci(bazel): correct cmd-tier long-pole durations, re-pack embedded manifolds (F1)
Investigated coordinator item 2 (single-test long poles): TestEmbeddedUpdateConcurrent
(recorded 475.39s) and TestEmbeddedCloseConcurrent (recorded 308.06s), plus
the two other >180s cmd-tier entries from the same capture
(TestEmbeddedInitA 196.94s, TestEmbeddedEpicCloseEligibleReason 192.47s).
Root cause: NOT host contention, NOT backoff/retry sleeps (bdRunWithFlockRetry
contributes negligibly), NOT race-instrumented-subprocess overhead alone.
These numbers were captured via `bazel --nohome_rc test --config=embedded`
with the then-current 20-shard legacy manifest (~10-11 tests/shard) and
`-test.parallel=4`. Go's t.Parallel() starts each parallel test's elapsed
clock when its function is invoked, before the Parallel() call blocks it
waiting for a free one-of-4 slot -- so a test queued behind several other
heavy shard-mates has that queueing wait baked into its own recorded
`--- PASS: TestX (Ys)` time. This is shard-composition-dependent scheduling
delay, not a cost intrinsic to the test.
Confirmed two ways in an isolated clone (not this worktree, per the
no-plain-go-test-from-a-beads-checkout rule):
- Solo (no rivals at all): 151.83s / 106.48s / 63.58s / 66.08s.
- All four together with the real -race -test.parallel=4 flags and exactly
4 tests requested (so nobody queues -- parallel slots == test count):
141.34s / 113.80s / 69.79s / 74.63s.
Both agree closely and both are far below the capture-time numbers.
F1's LPT packer already isolates the heaviest tests into shards with few or
no other heavy rivals (TestEmbeddedUpdateConcurrent lands alone in its own
40-shard-block shard), so under the new manifest these tests see little to
no queueing delay in real CI. None of the four needed splitting, parallel
subtests, or raceEnabled-scaled N: once correctly measured, none exceeds the
180s single-test guideline (new corrected weights: 155.0 / 115.0 / 72.0 /
77.0s). Corrected scripts/ci/embedded_cmd_test_durations.json accordingly
(with a doc-comment explaining the methodology and both confirmations) and
re-packed the 40-shard Bazel-only block (--repack --write); --check passes
(exact-once coverage of all 241 discovered tests). The frozen legacy 20-shard
block is untouched and independently re-verified exact-once by simulating
embedded-test-shard.sh across all 20 shards (241/241 tests, no
duplicates/misses/errors).
New cmd-tier single-test ceiling: 179.47s (TestEmbeddedCloseAlreadyClosed,
likely itself somewhat inflated by the same mechanism but already under the
180s line as recorded, so no action needed).
Also updates scripts/ci/embedded_storage_test_durations.json: the prior
commit's raceEnabled-skip for TestLargeBatchApplyStatementCounts712_Embedded
means it now costs ~0s in the per-PR -race lane bazel-embedded actually
packs for (not its real ~260-300s non-race cost, which nightly.yml still
exercises) -- weight set to 1.0 with a doc comment tying it to the skip in
large_batch_apply_measure_test.go. Re-packed the 14-shard Bazel-only block
accordingly; --check passes (exact-once coverage of all 387 discovered
tests, excluding TestMain/TestConformance per that file's existing
convention). The frozen legacy 5-shard block is untouched and independently
re-verified exact-once via embedded-storage-test-shard.sh simulation
(388/388 tests, no duplicates/misses/errors).
Verification: go test ./scripts/... (includes the nightly.yml policy test),
make ci-pr-policy, make bazel-sync-check, actionlint all pass. Real local
`bazel --nohome_rc test --config=embedded //cmd/bd:bd_embedded_test
//internal/storage/embeddeddolt:embeddeddolt_embedded_test`
(--local_test_jobs=8, both targets together, on a shared/noisy sandbox host)
passes both targets; per-shard wall time from each shard's test.xml: cmd/bd
max 218.9s (shard 23/40, min 20.6s), storage max 251.1s (shard 5/14, min
0.98s) -- down from the prior oversubscribed sweep's 783.41s / 351.94s and
well under the single-test-floor-based ~475s projection this slice started
from. Projected tier lane time (max of the two targets, real dedicated CI
runners should do at least this well): ~251s, under the 5-minute target.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* test(embedded): un-vacuous TestEmbeddedDepB edges, split epic-close test, trim concurrency stress N (F1 review)
Coordinator review follow-ups on the F1 embedded-Dolt resharding slice:
- TestEmbeddedDepB (one of TestEmbeddedDep's two CI-speed split halves) was
asserting its tree_* subtests against an edgeless graph, passing
vacuously; restores the same parent-child/blocks edges TestEmbeddedDepA
builds so those subtests exercise real multi-node traversal (review S2).
- TestEmbeddedEpicCloseEligibleReason split into
TestEmbeddedEpicCloseEligibleReasonFlag/...Output for CI shard balance,
matching the project's established single-concern split pattern.
- TestEmbeddedUpdateConcurrent/TestEmbeddedCloseConcurrent's
issuesPerWorker reduced 5->2: under real concurrent-shard-load
measurement these were genuine (not queueing-artifact) serialized-write
costs; 2 preserves every invariant the test checks (duplicate-ID
detection across all workers, one non-decreasing-list-count check per
worker) at a fraction of the serialized work.
- large712ShapeName: the 712-shape's race skip and its zero-match guard now
share one named constant instead of two independent literal shape-name
strings, so a future rename of the shape can't silently skip the pinned
statement-count assertion under race (review N2).
- Comment-only fixes (review N5) in files referencing test names since
renamed/split by this slice's earlier work: close_proxied_integration_test.go,
graph_apply_test.go, storage_class_proxied_integration_test.go,
tests/regression/discovery_test.go, plus doc-comment path cleanups (N1:
drop unverified ~/beads-bazel-plan paths/bead ids in favor of the
committed duration JSON files and engdocs/TESTING.md).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* ci(bazel): re-derive embedded-Dolt durations under concurrent load; cap cmd shards at Bazel's 50-shard limit (F1 round 2)
Coordinator review required re-deriving every per-test duration weight from
a single, consistent, CI-realistic measurement (all shards running
concurrently, -test.parallel=4, race-enabled) instead of the prior pass's
mix of crowded-shard captures and solo/4-together spot-corrections, and
required measuring per-shard wall time via BEP testAttemptDuration rather
than a shard's outer test.xml <testsuites time> (which can include a
different, already-finished shard-mate's setup/teardown).
- scripts/ci/embedded_cmd_test_durations.json (242 tests) and
scripts/ci/embedded_storage_test_durations.json (387 tests) rewritten in
full from one consistent sweep. Every entry is now a fresh measurement;
none is a carried-over capture-time value or an unverified estimate. Both
files' _comment blocks retract the earlier "queueing delay baked into a
test's own reported elapsed time" theory (testing.go's (*T).Parallel does
not add wait time to a blocked test's own clock) and document the real
methodology.
- Only one cmd-tier test remains over 200s (TestEmbeddedListFiltering,
239.70s), already under the ~240s ceiling; no further top-level splits
were needed this round.
- New finding: Bazel hard-caps shard_count at 50 per sh_test-like rule
("Having more than 50 shards is indicative of poor test organization";
a native analysis-time limit, not configurable). The previous 88-shard
plan for //cmd/bd:bd_embedded_test (chosen as the LPT-packed floor before
this limit was discovered) is reverted to 50, Bazel's real ceiling.
Repacking the fresh weights at 50 shards gives a heaviest shard of
409.6s -- above the single-test floor of 239.7s, because 50 bins is not
enough headroom over the suite's ~20145 measured test-seconds to flatten
every bin to that floor. This makes the <=5 min lane target unreachable
for the cmd tier via resharding alone within Bazel's native per-rule
limit; see ~/beads-bazel-plan/f1/impl-report.md section 3c for the full
writeup and the two remaining levers (suite-wide speedups or a
multi-Bazel-rule split), neither attempted in this slice.
- internal/storage/embeddeddolt gets 15 Bazel-only shards (unaffected by
the 50-shard cap): LPT-packed heaviest shard 225.3s, within target.
- cmd/bd/BUILD.bazel, internal/storage/embeddeddolt/BUILD.bazel,
.github/workflows/bazel.yml, engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md,
scripts/embedded_shard_count_test.go, scripts/pr_risk_bazel_coverage_test.go,
scripts/ci/gen_embedded_cmd_shard_manifest.py updated to the corrected
50/15 shard counts (and, for the generator, N3: --write without an
explicit total_shards now errors instead of silently regenerating the
frozen legacy 20-shard block).
- .github/scripts/embedded-{cmd,storage}-test-shards.txt: re-packed
Bazel-only blocks at 50/15; frozen legacy 20/5 blocks untouched except for
N5 fixes to stale entries left by this slice's earlier test splits
(TestShardScriptsListOnlyRealTests catches this class of bug; both
legacy blocks reconfirmed exact-once).
- .github/workflows/nightly.yml / scripts/ci_workflow_test.go (N4): the
embedded-dolt batch-apply nightly step now runs with `if: ${{
!cancelled() }}` and its own explicit `-timeout 20m`, independent of the
job-level timeout, with both halves now asserted by
TestNightlyFullTestRunsEmbeddedDoltBatchApplySuite.
Verified: gofmt -l clean, go vet ./scripts/... clean, go test ./scripts/...
green, both generators' --check pass at 50/15 (and legacy 20/5 remain
exact-once via the frozen-block invariant).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* test(ci): rename embedded manifest staleness tests out of the ^TestEmbedded skip
The allowlisted go-test leg runs with -skip ^TestEmbedded, so tests named
TestEmbedded*ShardManifestGeneratorNotStale never ran there and the leg
failed with "matched no test that ran".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Gas City Adopt-PR <adopt-pr@gascity.local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
343 lines
14 KiB
Go
343 lines
14 KiB
Go
//go:build cgo
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/types"
|
|
)
|
|
|
|
// The proxied-server mirror of TestEmbeddedCreateStorageClassConflicts /
|
|
// TestEmbeddedCreateStorageClassBatchAndMisc (one TestEmbeddedCreateStorageClass
|
|
// before the F1 CI-speed split). This is the
|
|
// transport the field report was filed against and the one Enterprise builds
|
|
// run: every `--storage-class` value was accepted and dropped, so an
|
|
// `ephemeral` request minted a DURABLE row and the durable-class-on-wisp-plane
|
|
// conflict the direct door rejects was silently collapsed.
|
|
//
|
|
// Every assertion reads the raw cell out of the server's own tables, because
|
|
// the JSON the command prints is the request's own struct on some routes and
|
|
// would agree with itself either way.
|
|
//
|
|
// CI note: this shard is gated on BEADS_TEST_PROXIED_SERVER=1 and runs mostly
|
|
// only on push-to-main, so it is meant to be run locally alongside any change
|
|
// to the create input path.
|
|
func TestProxiedServerStorageClass(t *testing.T) {
|
|
requireSharedProxiedServer(t)
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
|
|
// storageClassCell pins the at-rest form (NULL vs literal) on whichever
|
|
// plane the row was supposed to land on.
|
|
storageClassCell := func(t *testing.T, db *sql.DB, table, id string) sql.NullString {
|
|
t.Helper()
|
|
var got sql.NullString
|
|
//nolint:gosec // G202: table is a test-local literal, never caller input
|
|
if err := db.QueryRowContext(context.Background(), "SELECT storage_class FROM "+table+" WHERE id = ?", id).Scan(&got); err != nil {
|
|
t.Fatalf("query %s.storage_class for %s: %v", table, id, err)
|
|
}
|
|
return got
|
|
}
|
|
|
|
// Batch doors mint their own ids, so their rows are found by title. An
|
|
// absent row is "" rather than a failure: the PLANE is what is under test.
|
|
idByTitle := func(t *testing.T, db *sql.DB, table, title string) string {
|
|
t.Helper()
|
|
var id string
|
|
//nolint:gosec // G202: table is a test-local literal, never caller input
|
|
err := db.QueryRowContext(context.Background(), "SELECT id FROM "+table+" WHERE title = ?", title).Scan(&id)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return ""
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("query %s by title %q: %v", table, title, err)
|
|
}
|
|
return id
|
|
}
|
|
|
|
setStorageClassConfig := func(t *testing.T, p proxiedProject, key, value string) {
|
|
t.Helper()
|
|
if out, err := bdProxiedRun(t, bd, p.dir, "config", "set", key, value); err != nil {
|
|
t.Fatalf("config set %s: %v\n%s", key, err, out)
|
|
}
|
|
}
|
|
|
|
// THE FIELD REPORT: `--storage-class unversioned` on this door left the cell
|
|
// NULL, so the class could never be read back — and `bd update` has no
|
|
// storage-class surface, which makes a create-time drop unrepairable.
|
|
t.Run("explicit_unversioned_persists", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pu")
|
|
issue := bdProxiedCreate(t, bd, p.dir, "Unversioned bead", "-d", "x", "--storage-class", "unversioned")
|
|
if issue.StorageClass != types.StorageClassUnversioned {
|
|
t.Errorf("JSON storage_class = %q, want unversioned", issue.StorageClass)
|
|
}
|
|
db := openProxiedDB(t, p)
|
|
if cell := storageClassCell(t, db, "issues", issue.ID); !cell.Valid || cell.String != "unversioned" {
|
|
t.Errorf("DB cell = %+v, want 'unversioned'", cell)
|
|
}
|
|
})
|
|
|
|
t.Run("default_and_explicit_versioned_stay_null", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pv")
|
|
db := openProxiedDB(t, p)
|
|
|
|
plain := bdProxiedCreate(t, bd, p.dir, "Plain bead", "-d", "x")
|
|
if cell := storageClassCell(t, db, "issues", plain.ID); cell.Valid {
|
|
t.Errorf("plain create: DB cell = %q, want NULL", cell.String)
|
|
}
|
|
// C2.4: the explicit versioned spelling normalizes to the same NULL, so
|
|
// a NULL cell here is correct rather than the bug.
|
|
explicit := bdProxiedCreate(t, bd, p.dir, "Versioned bead", "-d", "x", "--storage-class", "versioned")
|
|
if cell := storageClassCell(t, db, "issues", explicit.ID); cell.Valid {
|
|
t.Errorf("explicit versioned: DB cell = %q, want NULL", cell.String)
|
|
}
|
|
})
|
|
|
|
// WORSE THAN A NO-OP before the fix: this minted a durable versioned row for
|
|
// a request that asked for ephemeral.
|
|
t.Run("ephemeral_spelling_routes_to_wisp_plane", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pe")
|
|
issue := bdProxiedCreate(t, bd, p.dir, "Ephemeral bead", "-d", "x", "--storage-class", "ephemeral")
|
|
if !issue.Ephemeral {
|
|
t.Errorf("--storage-class ephemeral should set the ephemeral flag")
|
|
}
|
|
db := openProxiedDB(t, p)
|
|
var count int
|
|
if err := db.QueryRowContext(context.Background(), "SELECT COUNT(*) FROM issues WHERE id = ?", issue.ID).Scan(&count); err != nil {
|
|
t.Fatalf("query issues: %v", err)
|
|
}
|
|
if count != 0 {
|
|
t.Errorf("an ephemeral request minted a DURABLE row %s", issue.ID)
|
|
}
|
|
var ephemeral int
|
|
if err := db.QueryRowContext(context.Background(), "SELECT ephemeral FROM wisps WHERE id = ?", issue.ID).Scan(&ephemeral); err != nil {
|
|
t.Fatalf("query wisps: %v", err)
|
|
}
|
|
if ephemeral != 1 {
|
|
t.Errorf("wisps.ephemeral = %d, want 1", ephemeral)
|
|
}
|
|
if cell := storageClassCell(t, db, "wisps", issue.ID); cell.Valid {
|
|
t.Errorf("wisp row cell = %q, want NULL (wisp-plane rows derive their class)", cell.String)
|
|
}
|
|
})
|
|
|
|
// Finding A of #5164, unfixed on this route until now: the direct door
|
|
// rejects the contradiction, this one silently made the row a wisp.
|
|
t.Run("durable_class_with_wisp_plane_is_rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pf")
|
|
db := openProxiedDB(t, p)
|
|
for _, planeFlag := range []string{"--ephemeral", "--no-history"} {
|
|
out := bdProxiedCreateFail(t, bd, p.dir, "Conflicting "+planeFlag, "-d", "x", planeFlag, "--storage-class", "versioned")
|
|
// Byte-identical to the direct door's message.
|
|
if !strings.Contains(out, "conflicts with --ephemeral/--no-history") {
|
|
t.Errorf("%s: expected the wisp-plane conflict error, got:\n%s", planeFlag, out)
|
|
}
|
|
if id := idByTitle(t, db, "wisps", "Conflicting "+planeFlag); id != "" {
|
|
t.Errorf("%s: a refused create left wisp %s behind", planeFlag, id)
|
|
}
|
|
if id := idByTitle(t, db, "issues", "Conflicting "+planeFlag); id != "" {
|
|
t.Errorf("%s: a refused create left issue %s behind", planeFlag, id)
|
|
}
|
|
}
|
|
out := bdProxiedCreateFail(t, bd, p.dir, "Doubly ephemeral", "-d", "x", "--no-history", "--storage-class", "ephemeral")
|
|
if !strings.Contains(out, "--storage-class ephemeral and --no-history are mutually exclusive") {
|
|
t.Errorf("expected the ephemeral/no-history exclusion, got:\n%s", out)
|
|
}
|
|
})
|
|
|
|
// Release-audit finding #48: the per-type default was resolved only by the
|
|
// direct door, so the same config.yaml produced different rows depending on
|
|
// which transport the workspace was initialized with.
|
|
t.Run("per_type_config_default", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pc")
|
|
setStorageClassConfig(t, p, "storage-class.task", "unversioned")
|
|
db := openProxiedDB(t, p)
|
|
|
|
byDefault := bdProxiedCreate(t, bd, p.dir, "Defaulted bead", "-d", "x", "-t", "task")
|
|
if cell := storageClassCell(t, db, "issues", byDefault.ID); !cell.Valid || cell.String != "unversioned" {
|
|
t.Errorf("config default: DB cell = %+v, want 'unversioned'", cell)
|
|
}
|
|
// Flag over config (C1.3), and versioned normalizes back to NULL.
|
|
forced := bdProxiedCreate(t, bd, p.dir, "Forced versioned", "-d", "x", "-t", "task", "--storage-class", "versioned")
|
|
if cell := storageClassCell(t, db, "issues", forced.ID); cell.Valid {
|
|
t.Errorf("explicit versioned over config default: DB cell = %q, want NULL", cell.String)
|
|
}
|
|
// Other types are untouched by the task default.
|
|
bug := bdProxiedCreate(t, bd, p.dir, "A bug", "-d", "x", "-t", "bug")
|
|
if cell := storageClassCell(t, db, "issues", bug.ID); cell.Valid {
|
|
t.Errorf("other type: DB cell = %q, want NULL", cell.String)
|
|
}
|
|
// A config-derived durable class is not a caller contradiction, so it
|
|
// YIELDS to the explicit plane instead of blocking the create.
|
|
yielded := bdProxiedCreate(t, bd, p.dir, "Ephemeral over config", "-d", "x", "-t", "task", "--ephemeral")
|
|
if !yielded.Ephemeral {
|
|
t.Errorf("--ephemeral over config default should set the ephemeral flag")
|
|
}
|
|
if cell := storageClassCell(t, db, "wisps", yielded.ID); cell.Valid {
|
|
t.Errorf("config-derived unversioned leaked to the wisp row: %q", cell.String)
|
|
}
|
|
})
|
|
|
|
// buildMarkdownBatchRequest is ONE projection shared by both transports, so
|
|
// this is the proxied half of the same fix the embedded suite covers.
|
|
t.Run("markdown_batch", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pm")
|
|
db := openProxiedDB(t, p)
|
|
writeBatch := func(t *testing.T, name, body string) string {
|
|
t.Helper()
|
|
path := filepath.Join(p.dir, name)
|
|
if err := os.WriteFile(path, []byte(body), 0o600); err != nil {
|
|
t.Fatalf("write markdown plan: %v", err)
|
|
}
|
|
return path
|
|
}
|
|
|
|
unversioned := writeBatch(t, "unversioned.md", `## Proxied batch one
|
|
|
|
### Description
|
|
First.
|
|
|
|
## Proxied batch two
|
|
|
|
### Description
|
|
Second.
|
|
`)
|
|
if out, err := bdProxiedRun(t, bd, p.dir, "create", "--file", unversioned, "--storage-class", "unversioned"); err != nil {
|
|
t.Fatalf("create --file: %v\n%s", err, out)
|
|
}
|
|
for _, title := range []string{"Proxied batch one", "Proxied batch two"} {
|
|
id := idByTitle(t, db, "issues", title)
|
|
if id == "" {
|
|
t.Fatalf("%s was not created", title)
|
|
}
|
|
if cell := storageClassCell(t, db, "issues", id); !cell.Valid || cell.String != "unversioned" {
|
|
t.Errorf("%s (%s): DB cell = %+v, want 'unversioned'", title, id, cell)
|
|
}
|
|
}
|
|
|
|
ephemeral := writeBatch(t, "ephemeral.md", `## Proxied batch wisp
|
|
|
|
### Description
|
|
Third.
|
|
`)
|
|
if out, err := bdProxiedRun(t, bd, p.dir, "create", "--file", ephemeral, "--storage-class", "ephemeral"); err != nil {
|
|
t.Fatalf("create --file --storage-class ephemeral: %v\n%s", err, out)
|
|
}
|
|
if id := idByTitle(t, db, "wisps", "Proxied batch wisp"); id == "" {
|
|
t.Error("--file --storage-class ephemeral should land its rows in wisps")
|
|
}
|
|
|
|
conflicting := writeBatch(t, "conflict.md", `## Proxied batch refused
|
|
|
|
### Description
|
|
Fourth.
|
|
`)
|
|
out, err := bdProxiedRun(t, bd, p.dir, "create", "--file", conflicting, "--ephemeral", "--storage-class", "versioned")
|
|
if err == nil {
|
|
t.Fatalf("durable class with --ephemeral should be refused, got:\n%s", out)
|
|
}
|
|
if !strings.Contains(string(out), "conflicts with --ephemeral/--no-history") {
|
|
t.Errorf("expected the wisp-plane conflict error, got:\n%s", out)
|
|
}
|
|
if id := idByTitle(t, db, "issues", "Proxied batch refused"); id != "" {
|
|
t.Errorf("a refused --file left %s behind", id)
|
|
}
|
|
})
|
|
|
|
t.Run("markdown_batch_per_type_config_default", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pb")
|
|
setStorageClassConfig(t, p, "storage-class.task", "unversioned")
|
|
db := openProxiedDB(t, p)
|
|
|
|
path := filepath.Join(p.dir, "defaults.md")
|
|
if err := os.WriteFile(path, []byte(`## Proxied default task
|
|
|
|
### Description
|
|
Task body.
|
|
|
|
## Proxied default bug
|
|
|
|
### Type
|
|
bug
|
|
|
|
### Description
|
|
Bug body.
|
|
`), 0o600); err != nil {
|
|
t.Fatalf("write markdown plan: %v", err)
|
|
}
|
|
if out, err := bdProxiedRun(t, bd, p.dir, "create", "--file", path); err != nil {
|
|
t.Fatalf("create --file: %v\n%s", err, out)
|
|
}
|
|
taskID := idByTitle(t, db, "issues", "Proxied default task")
|
|
if cell := storageClassCell(t, db, "issues", taskID); !cell.Valid || cell.String != "unversioned" {
|
|
t.Errorf("task template: DB cell = %+v, want the storage-class.task default", cell)
|
|
}
|
|
bugID := idByTitle(t, db, "issues", "Proxied default bug")
|
|
if cell := storageClassCell(t, db, "issues", bugID); cell.Valid {
|
|
t.Errorf("bug template: DB cell = %q, want NULL (the task default must not spill)", cell.String)
|
|
}
|
|
})
|
|
|
|
t.Run("graph_rejects_plan_wide_storage_class", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pg")
|
|
path := filepath.Join(p.dir, "plan.json")
|
|
if err := os.WriteFile(path, []byte(`{"nodes":[{"key":"a","title":"Proxied graph node","description":"n"}]}`), 0o600); err != nil {
|
|
t.Fatalf("write graph plan: %v", err)
|
|
}
|
|
out := bdProxiedCreateFail(t, bd, p.dir, "--graph", path, "--storage-class", "unversioned")
|
|
if !strings.Contains(out, "set storage_class per node in the plan instead") {
|
|
t.Errorf("error should point at the per-node field, got:\n%s", out)
|
|
}
|
|
// The per-node field is the mechanism that works, on this transport too.
|
|
perNode := filepath.Join(p.dir, "per-node.json")
|
|
if err := os.WriteFile(perNode, []byte(`{"nodes":[{"key":"a","title":"Proxied per-node","description":"n","storage_class":"unversioned"}]}`), 0o600); err != nil {
|
|
t.Fatalf("write graph plan: %v", err)
|
|
}
|
|
if out, err := bdProxiedRun(t, bd, p.dir, "create", "--graph", perNode); err != nil {
|
|
t.Fatalf("create --graph with a per-node class: %v\n%s", err, out)
|
|
}
|
|
db := openProxiedDB(t, p)
|
|
id := idByTitle(t, db, "issues", "Proxied per-node")
|
|
if cell := storageClassCell(t, db, "issues", id); !cell.Valid || cell.String != "unversioned" {
|
|
t.Errorf("per-node class: DB cell = %+v, want 'unversioned'", cell)
|
|
}
|
|
})
|
|
|
|
// The dry-run preview builds the same issue the real create does, so it
|
|
// inherits the fix — and a preview that showed a class the create would not
|
|
// write would be worse than none.
|
|
t.Run("dry_run_preview_shows_the_resolved_class", func(t *testing.T) {
|
|
t.Parallel()
|
|
p := newSharedProxiedProject(t, bd, "pd")
|
|
setStorageClassConfig(t, p, "storage-class.bug", "unversioned")
|
|
|
|
preview := bdProxiedCreate(t, bd, p.dir, "Previewed bead", "-d", "x", "--dry-run", "--storage-class", "unversioned")
|
|
if preview.StorageClass != types.StorageClassUnversioned {
|
|
t.Errorf("dry-run preview storage_class = %q, want unversioned", preview.StorageClass)
|
|
}
|
|
fromConfig := bdProxiedCreate(t, bd, p.dir, "Previewed default", "-d", "x", "-t", "bug", "--dry-run")
|
|
if fromConfig.StorageClass != types.StorageClassUnversioned {
|
|
t.Errorf("dry-run preview of the config default = %q, want unversioned", fromConfig.StorageClass)
|
|
}
|
|
wisp := bdProxiedCreate(t, bd, p.dir, "Previewed wisp", "-d", "x", "--dry-run", "--storage-class", "ephemeral")
|
|
if !wisp.Ephemeral || wisp.StorageClass != "" {
|
|
t.Errorf("dry-run preview of the ephemeral spelling: ephemeral=%v class=%q", wisp.Ephemeral, wisp.StorageClass)
|
|
}
|
|
})
|
|
}
|