beads/internal/httpapi/claim_next.go
Julian Knutsen 601be8a6bf
feat(list): bd list's remaining filters over http behind issues.list.filters (#7647)
* feat(list): bd list's remaining filters over http behind issues.list.filters

Over http every `bd list` filter beyond the created bounds and the title,
id and no-assignee scope refused (time bounds, priority range, text and external-ref
matches, spec, label pattern/regex, exclude-type, no-parent, no-labels,
empty-description, pinned/no-pinned, deferred, overdue, mol/wisp type).
The library entry already applied all of them: issueops.Reader.List via
workapi.BuildListFilter, shared by the CLI and the handler. This adds
only the wire.

- Server: GET /v0/beads/issues decodes 29 new optional parameters
  (listFilterParams, decode only; countIssues' names where it already
  spells the filter) into the existing ListRequest, behind one new
  behavior token, issues.list.filters. mol_type/wisp_type are closed
  enums refused by name (an empty value too). wire_revision stays 2;
  apigen and the wireshape golden are regenerated (additive only).
- Every RFC 3339 bound the listing and count decode is normalized to UTC,
  so an offset-bearing bound selects what its Z twin does on a zone-less
  timestamp column.
- workapi.BuildListFilter refuses PinnedFlag with NoPinnedFlag
  (ErrValidation, the CLI's own sentence) instead of letting PinnedFlag
  win; over http that is a 400 on no_pinned.
- Client: the encoder sends the members (encode.ListFiltersMembers, one
  list read by the encoder, the pre-dial gate and a spec-parity test).
  Against a server not advertising the token, httpReader.List refuses
  before dialing with ErrUnsupported naming issues.list.filters. The 29
  E-ListRequest ledger refusal rows retire; the ledger doc is updated;
  skew flag mappings added.
- Tests: handler decode/parity/enum/UTC/malformed/pinned-pair tests;
  encode member/gate/spec parity and bound encoding; per-member
  ride-behind-token and pre-dial skew refusal; two new Reader contract
  cases on every leg (dolt, embedded, uow, served): the eight time
  bounds at exact boundaries (strict, whole-second truncation, NULL never
  matches, +02:00 equals UTC) and one in/out row per remaining family;
  three served Reader cases unparked; TestE2E_ListFilterParityOverHTTP
  (served == embedded, masked server refuses naming the token, no dial);
  five corpus shapes marked pending until the reference server profile
  advertises the token.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* feat(list): exclude_status on listIssues, the 30th issues.list.filters member

issueops.ListRequest gains ExcludeStatus: statuses to leave out of a
listing, appended to the default exclusions (never re-admitting what they
hide), comma-separated or repeated, and validated against the workspace's
statuses by the same rule CountRequest.ExcludeStatus uses (an unknown name
is ErrValidation). The rule moves into one shared function,
workapi.ParseExcludeStatus, called by both builders. With AllFlag it reads
the active set without enumerating every status, so an http-backed caller
can list O(active) rows instead of the whole history.

- Server: listIssues decodes a repeatable `exclude_status` under the same
  issues.list.filters token (no new token); an unknown name is a 400 on
  exclude_status. apigen and the wireshape golden are regenerated
  (additive).
- Client: the encoder sends it and it joins encode.ListFiltersMembers, so
  the pre-dial gate asks for the token.
- It is refused together with ReadyFlag, like the other members the ready
  query cannot carry.
- No `bd list --exclude-status` flag yet (it would need the CLI docs
  regenerated); the member is reachable through the library and the wire.

Tests: builder unit test (append, AllFlag, comma split, unknown name);
handler decode and 400; encoder, round-trip and gate; Reader contract
cases on every leg (active set under AllFlag, repeated and comma values,
adds to the defaults, narrows an explicit Status, unknown name refused).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix(list): label_regex compile errors are 400s; review polish for list filters

- An invalid `label_regex` on GET /v0/beads/issues, /v0/beads/ready and
  /v0/beads/ready:count is now `400 invalid_argument` (`invalid_value` on
  `label_regex`) instead of `500 internal`. The database still compiles
  the pattern in its own dialect; a request that sent a regex and earned
  the engine's "regular expression is invalid" refusal is attributed to
  the parameter (failRegexReadErr). The same text on a request with no
  regex stays a server fault.
- mol_type and wisp_type refuse each other's vocabulary (tests pin
  `mol_type=heartbeat` and `wisp_type=swarm`), so the call-site
  allowlist, not just the spec enum, is covered.
- exclude_status with a workspace custom status: leg tests on the
  embedded store and over the served wire (accepted and applied; a name in
  no vocabulary refused). ReaderFixture cannot configure custom statuses,
  so these sit beside the count's twin rather than in the contract.
- The search e2e gains a positive arm: --desc-contains returns exactly the
  row whose description carries the token.
- Docs: `all` plus `exclude_status` keeps every status not named (pinned,
  hooked and custom done/frozen included unless named), not "the active
  set"; label_regex documents its 400. A corpus source line is made
  neutral; a test message says 30.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix(list): compose issues.list.filters with the --title-contains fold

#7631, now on main, folds `bd list --title-contains` onto listIssues
`title` and refuses the TitleContains left over from a --title and
--title-contains pair that differs, because the listing then had one
title parameter. This branch publishes `title_contains` behind
issues.list.filters, so that leftover now rides it beside `title` and
the server applies both. Neither half is dropped, and against a server
without the token the pre-dial gate refuses, naming issues.list.filters.

- encode.FoldTitleContains still runs first; its doc now says where a
  differing pair goes.
- Tests: the fold table expects `title` plus `title_contains` for a
  differing pair, including the ſ/s pair strings.EqualFold would match;
  the differing-pair refusal names issues.list.filters; the
  list_filters_test sweep pairs its TitleContains probe with a differing
  TitleSearch, since a lone one asks only for issues.list.title; the e2e
  differing-pair refusal becomes a listFilterShapes row that answers
  exactly child-a over http and embedded, and refuses before dialing
  without the token.
- The gc-polecat-closed-after corpus shape's pending reason also names
  issues.list.title. The CHANGELOG --title-contains entry no longer
  lists the differing pair and --closed-after as refused.

Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* build(bazel): auto-sync BUILD files

Applied from the bazel-sync-patch artifact of https://github.com/gastownhall/beads/actions/runs/39013611268
(`make bazel-sync`: gazelle, tools/bazel/go_srcs.py, bazel mod tidy).
Only BUILD.bazel, MODULE.bazel and MODULE.bazel.lock are ever pushed; see
scripts/bazel-autofix-push.sh.

* fix(list): serve --priority-max in search parity, refuse the parent pair

The proxied tier's search parity table still expected a remote
`bd search --priority-max 1` to refuse, because listIssues could not
carry it. This branch serves priority_max behind issues.list.filters,
so the remote route answered and the dolt-race shard went red in
TestProxiedServerSearchRoutesAgree. The row now expects the answer on
every route. It was the last wireCan=false row; the branch stays, with
a comment, for the next flag listIssues cannot carry.

- ParentID with NoParent: a served listing now carries no_parent beside
  parent, and ANDing the two answered only the edge-less rows under the
  parent's dotted id. BuildListFilter refuses the pair with
  ErrValidation, in the sentence bd list and BuildCountFilter already
  use, so issueops.Reader.List refuses it on every backend and the
  listing answers 400 on no_parent. Pinned by a builder test, a reader
  conformance case (dolt, embedded, uow, served http) and two httpapi
  tests.
- POST /v0/beads/issues:claimNext shares the ready listing's
  label_regex but answered a pattern the database cannot compile with
  500. It now gives the listing's 400 invalid_value on label_regex,
  through the helper the listing's mapping is split into.
- The descendant walk's ledger rows said listIssues publishes no
  parameter for members it now serves behind issues.list.filters. They
  now say the walk does not send them yet, and that --flat or --json
  asks listIssues directly. The ExcludeStatus, Pinned and ExcludeTypes
  rows, the parentwalk.go header, the walk table's doc and two walk test
  comments are corrected the same way, and the ledger doc is
  regenerated. parentWalkRefusals notes that a member moved off the list
  must check issues.list.filters itself, because the walk dials past
  the listing's pre-dial gate.
- Spec: the listing's no_parent documents the pair's 400, the count's
  exclude_status no longer says it has no listing counterpart, and
  claimNext's label_regex documents its 400. types.gen.go is
  regenerated. Comment-only: countFilters, and readyScopeFields'
  ExcludeStatus entry.
- CHANGELOG and README say the default `bd list --parent` tree view
  does not carry the new filters yet; the label_regex entry names
  claimNext, and a Changed entry records the parent-pair refusal.

Second review pass: docs and comments only, no behavior change.

- The prose copies of the issues.list.filters member set now match
  ListFiltersMembers: CapIssuesListFilters and wire.CapListFilters name
  the status exclusion, and the spec's capabilities text names
  label-regex.
- Every time bound on the listing and the count goes through
  q.timestamp, which normalizes it to UTC, and sqlbuild compares it
  strictly at whole-second precision. listIssues' created_before and
  created_after, and countIssues' created, updated and closed bounds,
  now say so in the words the new listing bounds use. The count's
  updated bounds also say what they filter, and its closed bounds say
  that a NULL closed_at never matches. types.gen.go is regenerated.
- README and CHANGELOG: `--flat` or `--json` applies the filters to the
  parent's direct children, not its whole subtree.
- The 29 listRefusal rows this branch serves stay deleted rather than
  kept as retired rows, as #7550 deleted its TitleSearch, IDFilter and
  NoAssignee rows when it served them. The CHANGELOG now says the rows
  are removed, not retired.

Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-17 11:21:18 +00:00

133 lines
5.8 KiB
Go

package httpapi
import (
"errors"
"net/http"
"github.com/steveyegge/beads/internal/httpapi/apigen"
"github.com/steveyegge/beads/issueops"
)
// claimNextRequestMembers is the document's member list for ClaimNextRequest.
// It carries the actor and nothing else — the FILTER is in the query string,
// for the reason the schema gives — and the schema is
// additionalProperties: false, so anything else is refused BY NAME.
var claimNextRequestMembers = []string{claimActorMember}
// handleClaimNext takes ONE ready issue and hands it back claimed.
//
// It exists to retire a RACE, not to save a round trip. A client composing
// GET /v0/beads/ready with POST /v0/beads/issues/{id}:claim reads a row that
// another agent claims before the second request arrives, so it earns a 409 for
// a row it was correctly offered — and a fleet polling one queue spends its
// requests losing those races. Selection, the compare-and-set and the hydration
// share one transaction here, so the row cannot move between being chosen and
// being reported.
//
// THE FILTER IS THE LISTING'S, decoded by readyFilters itself rather than by a
// copy that admits the same names. That is the same argument countReadyWork
// makes for sharing it: a claim answering a different question than `bd ready`
// shows would hand an agent work the listing never offered it.
//
// A COLLECTION-LEVEL CUSTOM METHOD, spelled the way issues:sweep is: the
// segment is a literal, so the router registers the documented path and no
// dispatcher exception is needed. It names no id because the caller names a
// QUESTION — which is also why it has no 404.
//
// Hooks do not fire and the per-command auto-commit machinery does not run,
// exactly as for the claim.
func (s *Server) handleClaimNext(w http.ResponseWriter, r *http.Request) {
q := newQuery(r.URL.Query())
req := issueops.ClaimNextRequest{Filter: readyFilters(q)}
// EXPLICIT, always, for handleReady's reason: the storage layer maps an
// empty sort policy to hybrid, and forwarding an absent `sort` as "" would
// silently adopt that fallback while the document still reads
// `default: priority`. It matters more here than on the listing — the sort
// decides WHICH row this operation writes to, not merely what order rows
// are printed in.
req.Filter.Sort = q.oneOf("sort", readySortDefault, "hybrid", "priority", "oldest")
// `limit` is REFUSED BY VALUE rather than left to the unknown-parameter
// rule, and the distinction is the difference between two client
// recoveries. `unknown_parameter` means "this server does not know that
// name — version skew, degrade or fall back", which would be a lie: the
// name is one this server knows perfectly well on the sibling listing.
// This operation will not ACT on it, which is `invalid_value`.
if q.has("limit") {
q.invalid("limit", "this operation takes no `limit`: it delivers the one row it wins, "+
"and its scan must stay unbounded or a window of rows a racing agent already took would report nothing to claim")
}
if !s.acceptQuery(w, r, q) {
return
}
actor, ok := s.claimNextActor(w, r)
if !ok {
return
}
req.Actor = actor
claimer, err := s.readyClaimer(r)
if err != nil {
s.failErr(w, r, err)
return
}
result, err := claimer.ClaimNext(r.Context(), req)
if err != nil {
// The claim's scan compiles label_regex in the database's own dialect,
// so a pattern it cannot compile is the caller's typo and wins nothing:
// the 400 on that parameter the ready listing gives for the same filter.
if s.refuseUncompilableRegex(w, r, err, req.Filter.LabelRegex) {
return
}
s.failClaimNext(w, r, err)
return
}
// A nil row is a 200 with `claimed` ABSENT, which is the role's own answer
// rather than this handler's interpretation: an empty ready front is the
// steady state of a drained queue, and a polling agent that had to classify
// an error to discover it would be pattern-matching prose.
writeJSON(w, apigen.ClaimNextResponse{Claimed: result.Claimed})
}
// claimNextActor decodes the one body member. It is the close's bodyActor
// behind the claim's refuse-the-rest-by-name check, because this body has
// exactly one member and the document says so.
func (s *Server) claimNextActor(w http.ResponseWriter, r *http.Request) (string, bool) {
if !s.requireJSONContent(w, r) {
return "", false
}
members, res := decodeJSONObjectBody(w, r)
if res != nil {
s.fail(w, r, *res)
return "", false
}
if offender, unknown := unknownMember(members, claimNextRequestMembers); unknown {
s.failUnknownMember(w, r, offender, claimNextRequestMembers)
return "", false
}
return s.bodyActor(w, r, members)
}
// failClaimNext answers a failed claim.
//
// IT HAS NO 409 AND NO 404 ARM, and both absences are the operation's contract
// rather than an omission. There is no id to have missed, and a row another
// agent took is simply not in the set this claim scanned — the role walks past
// it. The whole refusal vocabulary beyond the edge is the role's ErrValidation,
// which reaches the wire as the 400 the document promises, and the database's
// refusal of an uncompilable label_regex, which handleClaimNext attributes to
// that parameter before it gets here.
//
// The role's own validation is defensively unreachable: an empty actor is
// refused at the edge, and the two fields it refuses beyond that — Limit and
// Offset — have no wire spelling this handler will fill. It is mapped anyway,
// because the alternative if that stops being true is a 500 for a request the
// caller could have fixed.
func (s *Server) failClaimNext(w http.ResponseWriter, r *http.Request, err error) {
if !errors.Is(err, issueops.ErrValidation) {
s.failErr(w, r, err)
return
}
s.event("request_refused", "request_id", requestInfo(r.Context()).id, "error", err.Error())
s.fail(w, r, InvalidArgument("", ReasonInvalidValue,
"the request was refused by this workspace's own validation; nothing was written"))
}