* feat(list): bd list's remaining filters over http behind issues.list.filters Over http every `bd list` filter beyond the created bounds and the title, id and no-assignee scope refused (time bounds, priority range, text and external-ref matches, spec, label pattern/regex, exclude-type, no-parent, no-labels, empty-description, pinned/no-pinned, deferred, overdue, mol/wisp type). The library entry already applied all of them: issueops.Reader.List via workapi.BuildListFilter, shared by the CLI and the handler. This adds only the wire. - Server: GET /v0/beads/issues decodes 29 new optional parameters (listFilterParams, decode only; countIssues' names where it already spells the filter) into the existing ListRequest, behind one new behavior token, issues.list.filters. mol_type/wisp_type are closed enums refused by name (an empty value too). wire_revision stays 2; apigen and the wireshape golden are regenerated (additive only). - Every RFC 3339 bound the listing and count decode is normalized to UTC, so an offset-bearing bound selects what its Z twin does on a zone-less timestamp column. - workapi.BuildListFilter refuses PinnedFlag with NoPinnedFlag (ErrValidation, the CLI's own sentence) instead of letting PinnedFlag win; over http that is a 400 on no_pinned. - Client: the encoder sends the members (encode.ListFiltersMembers, one list read by the encoder, the pre-dial gate and a spec-parity test). Against a server not advertising the token, httpReader.List refuses before dialing with ErrUnsupported naming issues.list.filters. The 29 E-ListRequest ledger refusal rows retire; the ledger doc is updated; skew flag mappings added. - Tests: handler decode/parity/enum/UTC/malformed/pinned-pair tests; encode member/gate/spec parity and bound encoding; per-member ride-behind-token and pre-dial skew refusal; two new Reader contract cases on every leg (dolt, embedded, uow, served): the eight time bounds at exact boundaries (strict, whole-second truncation, NULL never matches, +02:00 equals UTC) and one in/out row per remaining family; three served Reader cases unparked; TestE2E_ListFilterParityOverHTTP (served == embedded, masked server refuses naming the token, no dial); five corpus shapes marked pending until the reference server profile advertises the token. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(list): exclude_status on listIssues, the 30th issues.list.filters member issueops.ListRequest gains ExcludeStatus: statuses to leave out of a listing, appended to the default exclusions (never re-admitting what they hide), comma-separated or repeated, and validated against the workspace's statuses by the same rule CountRequest.ExcludeStatus uses (an unknown name is ErrValidation). The rule moves into one shared function, workapi.ParseExcludeStatus, called by both builders. With AllFlag it reads the active set without enumerating every status, so an http-backed caller can list O(active) rows instead of the whole history. - Server: listIssues decodes a repeatable `exclude_status` under the same issues.list.filters token (no new token); an unknown name is a 400 on exclude_status. apigen and the wireshape golden are regenerated (additive). - Client: the encoder sends it and it joins encode.ListFiltersMembers, so the pre-dial gate asks for the token. - It is refused together with ReadyFlag, like the other members the ready query cannot carry. - No `bd list --exclude-status` flag yet (it would need the CLI docs regenerated); the member is reachable through the library and the wire. Tests: builder unit test (append, AllFlag, comma split, unknown name); handler decode and 400; encoder, round-trip and gate; Reader contract cases on every leg (active set under AllFlag, repeated and comma values, adds to the defaults, narrows an explicit Status, unknown name refused). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(list): label_regex compile errors are 400s; review polish for list filters - An invalid `label_regex` on GET /v0/beads/issues, /v0/beads/ready and /v0/beads/ready:count is now `400 invalid_argument` (`invalid_value` on `label_regex`) instead of `500 internal`. The database still compiles the pattern in its own dialect; a request that sent a regex and earned the engine's "regular expression is invalid" refusal is attributed to the parameter (failRegexReadErr). The same text on a request with no regex stays a server fault. - mol_type and wisp_type refuse each other's vocabulary (tests pin `mol_type=heartbeat` and `wisp_type=swarm`), so the call-site allowlist, not just the spec enum, is covered. - exclude_status with a workspace custom status: leg tests on the embedded store and over the served wire (accepted and applied; a name in no vocabulary refused). ReaderFixture cannot configure custom statuses, so these sit beside the count's twin rather than in the contract. - The search e2e gains a positive arm: --desc-contains returns exactly the row whose description carries the token. - Docs: `all` plus `exclude_status` keeps every status not named (pinned, hooked and custom done/frozen included unless named), not "the active set"; label_regex documents its 400. A corpus source line is made neutral; a test message says 30. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(list): compose issues.list.filters with the --title-contains fold #7631, now on main, folds `bd list --title-contains` onto listIssues `title` and refuses the TitleContains left over from a --title and --title-contains pair that differs, because the listing then had one title parameter. This branch publishes `title_contains` behind issues.list.filters, so that leftover now rides it beside `title` and the server applies both. Neither half is dropped, and against a server without the token the pre-dial gate refuses, naming issues.list.filters. - encode.FoldTitleContains still runs first; its doc now says where a differing pair goes. - Tests: the fold table expects `title` plus `title_contains` for a differing pair, including the ſ/s pair strings.EqualFold would match; the differing-pair refusal names issues.list.filters; the list_filters_test sweep pairs its TitleContains probe with a differing TitleSearch, since a lone one asks only for issues.list.title; the e2e differing-pair refusal becomes a listFilterShapes row that answers exactly child-a over http and embedded, and refuses before dialing without the token. - The gc-polecat-closed-after corpus shape's pending reason also names issues.list.title. The CHANGELOG --title-contains entry no longer lists the differing pair and --closed-after as refused. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(bazel): auto-sync BUILD files Applied from the bazel-sync-patch artifact of https://github.com/gastownhall/beads/actions/runs/39013611268 (`make bazel-sync`: gazelle, tools/bazel/go_srcs.py, bazel mod tidy). Only BUILD.bazel, MODULE.bazel and MODULE.bazel.lock are ever pushed; see scripts/bazel-autofix-push.sh. * fix(list): serve --priority-max in search parity, refuse the parent pair The proxied tier's search parity table still expected a remote `bd search --priority-max 1` to refuse, because listIssues could not carry it. This branch serves priority_max behind issues.list.filters, so the remote route answered and the dolt-race shard went red in TestProxiedServerSearchRoutesAgree. The row now expects the answer on every route. It was the last wireCan=false row; the branch stays, with a comment, for the next flag listIssues cannot carry. - ParentID with NoParent: a served listing now carries no_parent beside parent, and ANDing the two answered only the edge-less rows under the parent's dotted id. BuildListFilter refuses the pair with ErrValidation, in the sentence bd list and BuildCountFilter already use, so issueops.Reader.List refuses it on every backend and the listing answers 400 on no_parent. Pinned by a builder test, a reader conformance case (dolt, embedded, uow, served http) and two httpapi tests. - POST /v0/beads/issues:claimNext shares the ready listing's label_regex but answered a pattern the database cannot compile with 500. It now gives the listing's 400 invalid_value on label_regex, through the helper the listing's mapping is split into. - The descendant walk's ledger rows said listIssues publishes no parameter for members it now serves behind issues.list.filters. They now say the walk does not send them yet, and that --flat or --json asks listIssues directly. The ExcludeStatus, Pinned and ExcludeTypes rows, the parentwalk.go header, the walk table's doc and two walk test comments are corrected the same way, and the ledger doc is regenerated. parentWalkRefusals notes that a member moved off the list must check issues.list.filters itself, because the walk dials past the listing's pre-dial gate. - Spec: the listing's no_parent documents the pair's 400, the count's exclude_status no longer says it has no listing counterpart, and claimNext's label_regex documents its 400. types.gen.go is regenerated. Comment-only: countFilters, and readyScopeFields' ExcludeStatus entry. - CHANGELOG and README say the default `bd list --parent` tree view does not carry the new filters yet; the label_regex entry names claimNext, and a Changed entry records the parent-pair refusal. Second review pass: docs and comments only, no behavior change. - The prose copies of the issues.list.filters member set now match ListFiltersMembers: CapIssuesListFilters and wire.CapListFilters name the status exclusion, and the spec's capabilities text names label-regex. - Every time bound on the listing and the count goes through q.timestamp, which normalizes it to UTC, and sqlbuild compares it strictly at whole-second precision. listIssues' created_before and created_after, and countIssues' created, updated and closed bounds, now say so in the words the new listing bounds use. The count's updated bounds also say what they filter, and its closed bounds say that a NULL closed_at never matches. types.gen.go is regenerated. - README and CHANGELOG: `--flat` or `--json` applies the filters to the parent's direct children, not its whole subtree. - The 29 listRefusal rows this branch serves stay deleted rather than kept as retired rows, as #7550 deleted its TitleSearch, IDFilter and NoAssignee rows when it served them. The CHANGELOG now says the rows are removed, not retired. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
219 lines
8.7 KiB
Go
219 lines
8.7 KiB
Go
package workapi
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/steveyegge/beads/internal/types"
|
|
"github.com/steveyegge/beads/internal/utils"
|
|
"github.com/steveyegge/beads/issueops"
|
|
)
|
|
|
|
// countGroupColumns is the closed set issueops.CountByGroupRequest.GroupBy
|
|
// promises, mapped to what the storage seam calls each dimension. It exists so
|
|
// an unknown value is refused HERE, as ErrValidation, rather than reaching
|
|
// storage and coming back as an unclassifiable "unsupported groupBy" string.
|
|
var countGroupColumns = map[issueops.CountGroup]string{
|
|
issueops.CountGroupStatus: "status",
|
|
issueops.CountGroupPriority: "priority",
|
|
issueops.CountGroupType: "type",
|
|
issueops.CountGroupAssignee: "assignee",
|
|
issueops.CountGroupLabel: "label",
|
|
}
|
|
|
|
// ValidateCountGroup resolves a grouping dimension to the name the storage
|
|
// seam takes, refusing anything outside the published set with ErrValidation.
|
|
func ValidateCountGroup(group issueops.CountGroup) (string, error) {
|
|
column, ok := countGroupColumns[group]
|
|
if !ok {
|
|
return "", fmt.Errorf("invalid group '%s'. Valid values: status, priority, type, assignee, label%.0w",
|
|
group, issueops.ErrValidation)
|
|
}
|
|
return column, nil
|
|
}
|
|
|
|
// BuildCountFilter turns a count request into the storage-level filter: the
|
|
// single definition of what `bd count` means, which every implementation of
|
|
// issueops.Counter builds through.
|
|
//
|
|
// It is a SEPARATE builder rather than a call into BuildListFilter with the
|
|
// paging fields blanked out, because the two commands disagree about the
|
|
// default answer: a listing hides closed, pinned, template and gate rows, and a
|
|
// count hides none of them. The one place they must agree is --include-infra,
|
|
// pinned by a golden-style test comparing this builder's output against
|
|
// BuildListFilter's for the same request (count_test.go, GH#4387).
|
|
//
|
|
// cfg supplies the workspace's infra vocabulary and its custom status names.
|
|
// It is read under IncludeInfra AND whenever ExcludeStatus is non-empty (the
|
|
// exclusion is validated against the workspace's statuses), so a caller must
|
|
// load it in both cases; a zero ListConfig falls back to the default infra set
|
|
// and the built-in statuses only.
|
|
func BuildCountFilter(in issueops.CountRequest, cfg ListConfig) (types.IssueFilter, error) {
|
|
filter := types.IssueFilter{
|
|
TitleSearch: in.TitleSearch,
|
|
TitleContains: in.TitleContains,
|
|
DescriptionContains: in.DescContains,
|
|
NotesContains: in.NotesContains,
|
|
CreatedAfter: in.CreatedAfter,
|
|
CreatedBefore: in.CreatedBefore,
|
|
UpdatedAfter: in.UpdatedAfter,
|
|
UpdatedBefore: in.UpdatedBefore,
|
|
ClosedAfter: in.ClosedAfter,
|
|
ClosedBefore: in.ClosedBefore,
|
|
EmptyDescription: in.EmptyDesc,
|
|
NoAssignee: in.NoAssignee,
|
|
NoLabels: in.NoLabels,
|
|
Priority: in.Priority,
|
|
PriorityMin: in.PriorityMin,
|
|
PriorityMax: in.PriorityMax,
|
|
}
|
|
if len(in.MetadataFields) > 0 {
|
|
filter.MetadataFields = in.MetadataFields
|
|
}
|
|
if in.HasMetadataKey != "" {
|
|
filter.HasMetadataKey = in.HasMetadataKey
|
|
}
|
|
if err := ValidateMetadataFilters(in.MetadataFields, in.HasMetadataKey); err != nil {
|
|
return types.IssueFilter{}, err
|
|
}
|
|
|
|
// Status and IssueType are taken as written. Neither is validated against
|
|
// the workspace vocabulary: issueops.CountRequest promises an unrecognized
|
|
// name matches nothing rather than failing.
|
|
if in.Status != "" && in.Status != "all" {
|
|
status := types.Status(in.Status)
|
|
filter.Status = &status
|
|
}
|
|
if in.IssueType != "" {
|
|
issueType := types.IssueType(in.IssueType)
|
|
filter.IssueType = &issueType
|
|
}
|
|
if in.Assignee != "" {
|
|
assignee := in.Assignee
|
|
filter.Assignee = &assignee
|
|
}
|
|
|
|
// NormalizeLabels allocates its own slice, so the caller's Labels and
|
|
// LabelsAny are read and never written — the snapshot promise on
|
|
// issueops.Counter.
|
|
if labels := utils.NormalizeLabels(in.Labels); len(labels) > 0 {
|
|
filter.Labels = labels
|
|
}
|
|
if labelsAny := utils.NormalizeLabels(in.LabelsAny); len(labelsAny) > 0 {
|
|
filter.LabelsAny = labelsAny
|
|
}
|
|
if ids := utils.NormalizeLabels(strings.Split(in.IDFilter, ",")); len(ids) > 0 {
|
|
filter.IDs = ids
|
|
}
|
|
|
|
// ParentID and NoParent are refused together, matching `bd list`'s CLI
|
|
// refusal of the same combination (cmd/bd/list_input.go) with the same
|
|
// wording — the role raises it as ErrValidation so a caller reaching this
|
|
// builder from any front door (HTTP, proxied CLI, a future client) gets
|
|
// the same refusal the primary CLI's flag parser gives, rather than the
|
|
// role silently answering the empty intersection.
|
|
if in.ParentID != "" && in.NoParent {
|
|
return types.IssueFilter{}, fmt.Errorf("--parent and --no-parent are mutually exclusive%.0w", issueops.ErrValidation)
|
|
}
|
|
if in.ParentID != "" {
|
|
parentID := in.ParentID
|
|
filter.ParentID = &parentID
|
|
}
|
|
if in.NoParent {
|
|
filter.NoParent = true
|
|
}
|
|
|
|
// ExcludeTypes is appended to, not assigned: applyCountIncludeInfra (below)
|
|
// contributes its own "gate" exclusion, and the two sets must compose
|
|
// rather than one silently discarding the other, exactly as
|
|
// BuildListFilter's ExcludeTypes and applyTypeSuppressions compose.
|
|
for _, raw := range in.ExcludeTypes {
|
|
for _, t := range strings.Split(raw, ",") {
|
|
t = strings.TrimSpace(t)
|
|
if t != "" {
|
|
filter.ExcludeTypes = append(filter.ExcludeTypes, types.IssueType(utils.NormalizeIssueType(t)))
|
|
}
|
|
}
|
|
}
|
|
|
|
// ExcludeStatus takes names as written but — unlike Status and IssueType
|
|
// above — IS validated against the workspace vocabulary (built-in statuses
|
|
// plus cfg's custom ones, the same set ApplyStatusFilter checks in
|
|
// list.go). An exclusion list is built by hand from a status name, so a
|
|
// misspelled entry here would silently exclude nothing and OVERCOUNT
|
|
// rather than undercount, which is a worse failure mode than the
|
|
// match-nothing treatment Status and IssueType accept above — so a typo
|
|
// is ErrValidation instead.
|
|
excluded, err := ParseExcludeStatus(in.ExcludeStatus, cfg.CustomStatusNames())
|
|
if err != nil {
|
|
return types.IssueFilter{}, err
|
|
}
|
|
filter.ExcludeStatus = append(filter.ExcludeStatus, excluded...)
|
|
|
|
if in.IncludeInfra {
|
|
applyCountIncludeInfra(&filter, in.IssueType, in.IncludeEphemeral, cfg)
|
|
} else if !in.IncludeEphemeral {
|
|
filter.SkipWisps = true
|
|
}
|
|
return filter, nil
|
|
}
|
|
|
|
// applyCountIncludeInfra switches the count filter to the wisps-inclusive mode
|
|
// of `bd list --include-infra` (GH#4387). It mirrors the BuildListFilter
|
|
// defaults that determine list's cardinality so that, for any filter set,
|
|
// `bd count --include-infra <filters>` returns exactly the number of rows
|
|
// `bd list --include-infra <filters> --all` materializes:
|
|
//
|
|
// - the wisps table is merged in (SkipWisps=false), picking up no_history
|
|
// beads and ephemeral wisps, like list's merge path;
|
|
// - template molecules are excluded (list's default);
|
|
// - gate beads are excluded unless requested via --type gate;
|
|
// - counting an infra type (agent/role/message, or the store-configured set)
|
|
// routes to the ephemeral wisps tier, like list's infra-type listing —
|
|
// unless includeEphemeral is also set, which lifts that narrowing on both
|
|
// builders, so the durable rows of that type are counted as they are
|
|
// listed.
|
|
//
|
|
// A count without IncludeInfra never calls this. It keeps its historical
|
|
// durable-only semantics unless IncludeEphemeral admits the wisps tier: the
|
|
// first of the changes above, with none of the rest.
|
|
func applyCountIncludeInfra(filter *types.IssueFilter, issueType string, includeEphemeral bool, cfg ListConfig) {
|
|
filter.SkipWisps = false
|
|
|
|
isTemplate := false
|
|
filter.IsTemplate = &isTemplate
|
|
|
|
if issueType != "gate" {
|
|
filter.ExcludeTypes = append(filter.ExcludeTypes, "gate")
|
|
}
|
|
|
|
if issueType != "" && cfg.IsInfra(issueType) && !includeEphemeral {
|
|
ephemeral := true
|
|
filter.Ephemeral = &ephemeral
|
|
}
|
|
}
|
|
|
|
// ParseExcludeStatus reads a caller's status exclusion list — the count's and
|
|
// the listing's ExcludeStatus, one rule for both — into the statuses it names.
|
|
// Entries may be comma-separated and are trimmed; blanks are skipped. Each
|
|
// name IS validated against the workspace vocabulary (built-in statuses plus
|
|
// customStatusNames): a misspelled exclusion would silently exclude nothing
|
|
// and answer a WIDER set, so a typo is ErrValidation instead.
|
|
func ParseExcludeStatus(raw []string, customStatusNames []string) ([]types.Status, error) {
|
|
var out []types.Status
|
|
for _, entry := range raw {
|
|
for _, s := range strings.Split(entry, ",") {
|
|
s = strings.TrimSpace(s)
|
|
if s == "" {
|
|
continue
|
|
}
|
|
status := types.Status(s)
|
|
if !status.IsValidWithCustom(customStatusNames) {
|
|
return nil, fmt.Errorf("invalid exclude-status %q (valid: %s)%.0w",
|
|
s, ValidStatusList(customStatusNames), issueops.ErrValidation)
|
|
}
|
|
out = append(out, status)
|
|
}
|
|
}
|
|
return out, nil
|
|
}
|