beads/issueops/molecule.go
Julian Knutsen a2d43e6792
fix(mol): molecule reads, auto-close and close --continue over http through issueops entries (S16) (#7513)
* fix(create): let a remote backend mint the --parent child id

`bd create --parent` always called the raw GetNextChildID first, which the
http backend does not serve, so every child create on a remote workspace
refused before writing anything. The Lifecycle role already mints
<parent>.<n> for a create that carries a ParentID and no id of its own, on
every backend and inside the create's own transaction; conformance
RunIssueOperationsCreateUnderAParentMintsTheNextChildID pins it on every leg,
the served one included (and the bd-enterprise postgres leg the MC server
runs). So the create route needs no new capability token: on a registered
Remote backend the client skips the raw reservation and lets the server mint.
The local route keeps its reservation so its Dolt commit staging is
unchanged, and an explicit --id beside --parent is still refused up front.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mol): molecule reads, auto-close and close --continue over issueops roles

Over the http backend three molecule paths failed, and two of them
silently:

- `bd mol current` / `bd mol progress` without an id answered "no molecules"
  because the in_progress listing (a raw SearchIssues shape) and the parent
  walk (raw GetDependencyRecordsForIssues) were refused and the refusal was
  swallowed; with an id they refused on raw GetMoleculeProgress.
- The molecule auto-close after `bd close` never ran: findParentMolecules
  swallowed the same refused edge read into "not part of a molecule".
- `bd close --continue` claimed the next step in a raw RunInTransaction.

The direct route now reads molecules through roleMolStore, which answers
through roles every backend serves: EdgeReader (batched at the wire's 100
anchors) for the parent walk, BatchGetter for the roots (Get per id where a
server does not publish issues.batchGet), Relations for the step rows (full
rows; the raw dependents read over http is getIssue's shallow projection,
which zeroed step assignees) and the progress counts, and Reader.List for the
in_progress/hooked listings. The auto-close closes the root through
Lifecycle.Close, and the --continue claim is one Lifecycle.Update guarded by
ExpectedStatus=open.

No refusal is swallowed any more: findParentMolecules, the molecule finders
and the hooked scan return their errors; `mol current/progress` report them;
the auto-close stays best effort but warns on stderr; AdvanceToNextStep only
moves on to the next ready step when the claim LOST a race (status mismatch,
not claimable, already claimed) and returns anything else. The one heuristic
still skipped is the id-pattern heal in loadDescendants, and only for an
ErrUnsupported backend that cannot express an id-prefix search; other
failures now surface. `mol current`/`mol progress` leave the
types.IssueFilter forbidigo hole, since they no longer build a filter.

gc does not depend on bd's molecule auto-close: it runs its own
(cmd/gc/molecule_autoclose.go, from the bd on_close hook and the
controller's bead-close events). Its worker prompts do run `bd mol current`.

Served e2e (TestE2E_MoleculesOverHTTP): create --parent mints <root>.1/.2,
mol current <id> is non-empty with the full in-progress step, mol progress
counts, close --continue auto-advances, closing the last step auto-closes
the root. `mol current` without an id now refuses out loud on this stack
(asserted: never an empty list); its non-empty assertion is skipped until
S6c (externaldeps reader passthrough) is underneath.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mol): list molecule candidates with the four wire knobs, drop the S6c skip

On top of S6c the in_progress listing behind 'bd mol current' (no id)
reaches the v0 wire encoder, which refuses ListRequest.IncludeAllTypes.
Ask for templates, gates, infra and ephemeral rows explicitly, which the
wire publishes, and run the 'mol current without an id' served case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(issueops): one library entry each for molecule auto-close, advance and reads

The molecule rules lived only in cmd/bd, in copies that disagreed: two
auto-close implementations that closed the root through different
library entries outside the step close's transaction, a `close
--continue` claim that set no assignee and could take a step another
agent held on the direct and http routes, and three progress counts.
Every molecule rule now has one implementation in the public issueops
package, composed over three roles every backend serves (BatchGetter,
Relations, EdgeReader): MoleculeRoots, LoadMolecule, AnalyzeMolecule,
ViewMolecule, ReadMoleculeProgress, ActiveMoleculeIDs,
CompletedMolecule. Membership is the parent-child edge.

Auto-close: CloseRequest.AutoCloseMolecule and
CloseBatchRequest.AutoCloseMolecule (opt-in, so gc's own auto-close is
not doubled) close the molecule root a close completed IN THE SAME
TRANSACTION, unforced and guarded on the root revision read there:
storageissueops.CloseCompletedMoleculeInTx on the store backends (the
role bodies bound to the caller's tx, TxMoleculeReader) and
uow.CloseCompletedMoleculeInUOW on the unit of work. It replays on an
idempotent re-close, reports the root on CloseResult/CloseOutcome
.AutoClosedMolecule, and a root its own close policy refuses stays open
and is reported (MoleculeAutoCloseRefusal) without failing the step.

Advance: a new MoleculeStepper role (storage.DoltStorage accessor,
uow.MoleculeStepperSource) whose one implementation,
issueops.NewMoleculeStepper, claims the next ready step through the
Claimer (Lifecycle.Update's Claim for a wisp step): assignee set, a step
another actor holds skipped, never taken.

HTTP: closeIssue/batchCloseIssues carry auto_close_molecule behind the
issues.close.autoCloseMolecule behavior token, and POST
/v0/beads/issues/{id}:advanceMolecule (issues.advanceMolecule) serves
the stepper. Handlers only decode, call the role and encode. The client
sends the member and dials the operation only where advertised; against
an older server it DEGRADES rather than refuses — it runs the same
library rule over its own roles (issueops.CloseCompletedMolecule after
the close, NewMoleculeStepper for the advance), so the outcome is the
same in more round trips. The capability fallbacks that lived in
cmd/bd move into the client: BatchGetter answers one getIssue per id
without issues.batchGet, and EdgeReader splits past the operation's 100
anchors.

Conformance: RunMolecule* on dolt, embedded, uow and http (the http leg
twice: served, and against a server with the tokens struck out).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(cmd/bd): molecule commands and create --parent through the library entries

`bd close`, `bd close --continue`, `bd mol current`, `bd mol progress`,
`bd ready --mol` and `bd create --parent` now call the one library entry
for each rule on every route (direct, proxied server, remote):

- close (batch, --if-revision, proxied) sets CloseRequest/
  CloseBatchRequest.AutoCloseMolecule and only reports what the library
  closed in the step close's transaction. autoCloseCompletedMolecule,
  autoCloseProxiedCompletedMolecule and closeCompletedMoleculeRoot are
  gone, and so is the separate post-close write.
- --continue is the route's MoleculeStepper role: a real claim (the
  assignee is set) that skips a step another actor holds. Before, the
  direct and http routes flipped the status only and could take it.
  AdvanceToNextStep, ClaimStepIfOpen and its two implementations are
  gone.
- mol current / mol progress / ready --mol read through
  issueops.ViewMolecule, ReadMoleculeProgress, ActiveMoleculeIDs and
  LoadMolecule/AnalyzeMolecule over the route's roles. Over http this
  fixes the missing step assignee on `ready --mol` (corpus mark
  mc-ready-mol). The proxied route's SearchIssues fallback, the role
  store, the third progress count and the cmd/bd copy of the readiness
  analysis are deleted; only presentation stays here.
- create --parent asks the create role to mint the child id on every
  route (the local CLI reservation is gone) and to inherit the parent's
  labels (InheritLabelsFromParent) inside the create. The dry-run
  preview still shows the labels, and a failed label read there is
  reported, not swallowed.

TestProxiedServerMoleculeLifecycleAgreesOnEveryRoute runs one molecule
lifecycle through the real binary on the direct, proxied and remote
(`bd connect` to `bd serve`) routes and requires the same rows and the
same JSON on all three. The served e2e now also pins the held-step skip,
the claimed step's assignee and the full rows of `ready --mol`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(httpclient): refuse molecule auto-close and advance before dialing an older server

The client used to DEGRADE against a server without
issues.close.autoCloseMolecule / issues.advanceMolecule: it closed the step
without the member and ran a second, client-side copy of the auto-close
(issueops.CloseCompletedMolecule) in its own transactions, and composed the
stepper over its own roles. That kept two executions of each rule alive.
Now the rule runs in ONE place, the server's library: a close or batch close
that sets AutoCloseMolecule, and an Advance, refuse before anything is dialed
with the typed capability error (storage.ErrUnsupported, Capability naming the
token). The composed single-item batch leg now carries the member too.

- issueops.CloseCompletedMolecule (the role-composed form) is gone.
  MoleculeRootClose is the one root close request (unforced, the auto-close
  reason, the session, guarded on the root revision read), and both
  in-transaction bodies (storage issueops CloseCompletedMoleculeInTx, uow
  CloseCompletedMoleculeInUOW) build from it.
- MoleculeView.Ready is `bd ready --mol`'s list (every analysis-ready node,
  hydrated), so ready --mol and mol current derive from ViewMolecule alone.

Tests: unit pre-dial refusal and member pins (httpclient molecule_test.go),
TestServedMoleculeRefusesAgainstAnOlderServer (step stays open, nothing
claimed) replacing the degraded contract arm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cmd/bd): ask for the molecule auto-close only where the route serves it

The refuse-before-dialing client made every `bd close` over http fail
against a server that does not advertise issues.close.autoCloseMolecule
(an older bd serve, or the MC server shape, whose orchestrator owns the
molecule lifecycle): the CLI always set AutoCloseMolecule.
storage.ServesMoleculeAutoClose answers, through every decorator, whether a
store's closes may carry the flag (MoleculeAutoCloseProber, implemented by
httpclient.Store from its handshake; every local backend serves it). The
direct batch close and the --if-revision close set the flag from it; the
proxied route always serves it. Against a silent server the close goes out
without the member and the server's side owns the auto-close.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(backend/http): scope the advertised-policy check to reads before the close

The close policy check is the client-side policy's last chance: it runs
before the close request, so only the reads up to that request count. A
read after the close (the old-server molecule notice reads the closed
step's edges) is not the external-dependency policy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(backend/http/corpus): drop the six marks S16 and S19 retire

With the molecule library entries underneath, mol current (with and
without an id, json and text), mol progress and ready --mol read through
issueops.LoadMolecule over the roles, and create --parent lets the server
mint the child id. Those six shapes pass on the reference profile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cmd/bd): never silent against a server without the molecule tokens

Against a server that advertises neither issues.close.autoCloseMolecule
nor issues.advanceMolecule (an older bd serve, or one whose orchestrator
owns the molecule lifecycle):

- `bd close --continue` closed the step and only then found the advance
  refused, leaving the step closed and the next step unclaimed. It now
  asks storage.ServesMoleculeAdvance (a MoleculeAdvanceProber the http
  store answers from its handshake; local backends always serve it)
  BEFORE the close and refuses up front, saying nothing was closed.
- `bd close` went out without auto_close_molecule and said nothing. When
  the closed step belongs to a molecule (issueops.MoleculeRoot), a notice
  on stderr now names the molecule and the missing token: its auto-close
  is the server's to run. The batch and --if-revision closes both say it.

The served e2e masks both tokens out of the handshake and checks the
up-front refusal (the step stays open) and the notice; the httpclient
unit test pins ServesMoleculeAdvance to the handshake.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(cmd/bd): mol show through issueops.LoadMolecule on every route

`bd mol show` still loaded the molecule through cmd/bd's
loadTemplateSubgraph (raw GetIssue, GetDependentsWithMetadata and
GetDependencyRecords, plus an id-pattern child probe), while mol current,
mol progress and ready --mol read through the library. It now loads
through issueops.LoadMolecule over the route's molecule roles (the direct
store's, or the proxied provider's), so membership is the parent-child
edge everywhere and the http route reads through roles the server serves.
The served e2e checks mol show's root and step count.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: the molecule auto-close fails the step's close on a non-policy error; stale comments

CloseRequest.AutoCloseMolecule and CloseCompletedMoleculeInTx now say what
changed when the auto-close moved into the close's transaction: a root
close the close policy refuses still leaves the root open and is reported,
but any other failure (a storage error, a lost race on the root's revision)
fails the step's close with it, where the CLI used to close the root
afterwards and only warn.

Stale: the advanceMolecule vocabulary entry said the client composes the
stepper over its own roles when unserved (it refuses before dialing), and
the graph-create collision probe called itself best-effort by transport
(the http GetIssue miss is storage.ErrNotFound like every other store's).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changelog): the molecule tokens and the S16/S19 behaviours

Entries for issues.close.autoCloseMolecule and issues.advanceMolecule, the
issueops molecule entries, the auto-close inside the step's close (and a
non-policy failure of it failing the close), the real claim behind
close --continue, the molecule reads on every route, the notice and the
up-front --continue refusal against a server without the tokens, and
create --parent / mol reads over http.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(httpclient): regenerate unsupported_gen.go for MoleculeStepper

The PR adds MoleculeStepper() to storage.DoltStorage (200 -> 201
methods). httpclient implements it by hand, but the generated shell's
trailer still counted 200, so
//internal/storage/unsupportedgen:unsupportedgen_test
(TestGeneratedShellIsFresh) failed in Bazel / test and
Bazel / integration, turning CI Gate / Required red.

Regenerated with `go generate ./internal/httpclient`; the only change
is the trailer count (143 of 201 methods generated; 58 left).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(molecule): auto-close refusals, write skew, close --json, docs

Review fixes for #7513, numbered as in each iteration's review
synthesis.

Iteration 1:

F1: a close guard's refusal of the root (TemplateReadOnlyError,
PinnedError, CloseNotAssigneeError) is an auto-close refusal, like the
close policy's: the root stays open and is reported, and the step's
close stands. Pinned by the new conformance case
RunMoleculeGuardedRootKeepsTheStepClose on dolt, embedded, uow and the
served http client.

F2: two closes that finish a molecule's last two steps in concurrent
transactions each read the other's step as open, so neither closed the
root and both committed. Every auto-close now rewrites the root's
coordination cell before it decides the root (local_metadata
molecule-coordination/v1/<shard>, the dependency coordination idiom and
sharding with a FreshRowLock value), in both twins
(CloseCompletedMoleculesInTx and CloseCompletedMoleculesInUOW). Two
deciders of one root now conflict at commit (1213), and the retry reads
the winner's close and closes the root. This is the synthesis's option
(c), applied through a coordination cell instead of the root row; it
needs no post-commit second transaction and no engine lock. The
deterministic two-transaction regression fails without the touch and
passes with it on dolt and uow; the concurrent-close tests end with the
root closed in every round, reported by exactly one close.

F3: the auto-close checks the root's eligibility before walking any
step, MoleculeStepsClosed stops at the first open step, and a batch
decides each root once and reports it on the first item under it.

F4: ErrVersionMismatch on the root is not a refusal; it fails the
step's close with it. The classifier unit test pins this. A conformance
case cannot stage that race deterministically through the public roles.

F5: storage.ServesMoleculeAdvance answers (bool, error), and bd close
--continue refuses before closing anything when the handshake cannot be
read.

F6: the CHANGELOG and the stepper and batch-closer doc comments say
what the code does.

F7: the unserved-auto-close notice fires only when the close left an
auto-closing molecule with every step closed and its root open
(issueops.CompletedMolecule): again on a re-close, once per root in a
batch, never for a step under an ordinary epic or an unfinished
molecule. Proxied mol show, mol current and mol progress again report a
read unit of work that cannot be opened as itself, not as a molecule
that was not found.

F8: the write-ledger comment says the close is refused before dialing.
The dead FirstClosed/LastClosed guards in mol progress pre-exist on main
and are left as they are.

Iteration 2:

F1: on the proxied route, bd ready --mol reported a read unit
of work it could not open twice: once as itself, then as "molecule
'<id>' not found", which under --json is a second error document on
stdout. It now returns moleculeNotResolved, as mol show, mol current and
mol progress do. TestProxiedReadyMolReportsAnUnopenableReadOnce drives
runMoleculeReady with a provider whose NewUOW fails and wants one Error:
line, or one JSON document; both subtests fail with the old return.

F2: the coordination cell serializes every concurrent close of a step
under an open auto-closing root, not only the closes that finish the
molecule. That is the price of deciding the root in the step's
transaction, so it is documented (TouchMoleculeCoordinationInTx, the
UOW twin, CloseRequest.AutoCloseMolecule, the CHANGELOG) and pinned on
dolt and uow: two sibling closes with a third step still open conflict
(both commit when the touch is removed, on either twin), and a six-step
fan-out closes every step through the store's retry, with the root
closed and reported by exactly one close. The synthesis's alternative,
a post-commit recheck by any close that read a step open, is not taken:
it is a second, best-effort transaction after the step's commit, the
shape this PR exists to remove.

F3: MoleculeRootClose's doc no longer promises that a step reopened
between the completion read and the root close fails the step's close.
The guard is the root's RowVersion, which a step reopen never writes;
the doc now says what the guard covers and that this race goes
undetected (it is inherited from the CLI's old post-commit auto-close).

F4: the user docs describe the auto-close. docs/workflows/molecules.md
replaces "Closing the last child does not close the molecule root"
with which roots close and which stay open, the refusal warning, the
unserved-server note and the --json members, and documents the claiming
--continue and parent-child step membership;
docs/reference/json-schema.md gains a bd close --json section. These
are main-only behaviors on pages pinned to v1.2.2 (docs/cli-docs.pin):
a maintainer call against §1 of
engdocs/decisions/2026-07-17-docs-release-pin.md, as in #6508, #5855,
#5997 and #5092. The auto-close itself shipped in v1.2.2
(cmd/bd/close.go autoCloseCompletedMolecule), so the old sentence was
already wrong at the pin. docs/cli-reference/ is generated from the
pinned release and is not hand-edited; the bd close and bd mol show
help texts carry the same facts and reach it at the next pin bump.

F5: bd close --json reports the auto-close. The entry of a close that
completed a molecule gains auto_closed_molecule (the root it closed) or
molecule_auto_close_refusal (why the root stayed open), the HTTP API's
names, on the direct, proxied and --if-revision routes. The members sit
beside the issue's own rather than wrapping the output in an object the
way --suggest-next does: an object would change the output's shape
exactly when a close completes a molecule and break every consumer that
reads an array, while members leave each entry decoding as the closed
issue, compose with `closed` under the flag objects, and leave a plain
close's bytes unchanged. Pinned on the embedded and proxied tiers
(TestEmbeddedCloseJSONReportsMoleculeAutoClose, TestProxiedServerClose2B
json_reports_*, and both --if-revision replay tests), all red without
the change.

F6: cmd/bd's BeadsTemplateLabel is issueops.MoleculeTemplateLabel, so
the template commands and molecule membership cannot drift apart.

F7: the UOW twin's revision probe says that it writes nothing,
and the BatchCloseRequest.auto_close_molecule spec description has its
verb back (apigen regenerated, no drift).

Iteration 3:

F1: on the unit-of-work route (bd serve, the proxied CLI), a refused
root's molecule_auto_close_refusal and warning carried the use case's
and repository's wrapping ("close <id>: db:
IssueSQLRepository.CloseChecked <id>: ...") around the refusal, where
the tx twin and the docs give the refusal alone. Both twins now report
it through RefusedMoleculeAutoClose, which answers the refusing guard's
or policy's own sentence. RunMoleculeRefusedRootKeepsTheStepClose,
RunMoleculeGuardedRootKeepsTheStepClose and the embedded and proxied
close --json tests want that exact sentence; the uow conformance leg
and the proxied test fail without the unwrap.

F2: the docs no longer promise ErrVersionMismatch for a write to the
root that races its auto-close. The root's read and its revision check
share one transaction snapshot, so that write conflicts with the root
close at commit and the retry decides the root again; the close fails
only if it still conflicts when its retry budget runs out
(MoleculeRootClose, IsMoleculeAutoCloseRefusal,
CloseRequest.AutoCloseMolecule, the tx twin's comment, the CHANGELOG
and the OpenAPI description, apigen regenerated).

F3: TestEmbeddedCloseJSONReportsMoleculeAutoClose moves above
TestEmbeddedCloseConcurrent's doc comment, which documents its own test
again.

F4: bd mol progress counting direct steps while the auto-close counts
every descendant predates this PR; it is left for a follow-up.

F5: cmd/bd's molReader drops GetMoleculeProgress, which nothing called
once mol progress read through issueops.ReadMoleculeProgress.

Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Gas City Adopt-PR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-12 19:50:34 +00:00

869 lines
29 KiB
Go

package issueops
import (
"context"
"errors"
"fmt"
"sort"
"github.com/steveyegge/beads/internal/types"
)
// MoleculeTemplateLabel is the label that marks an epic as a template-driven
// molecule root. `bd mol distill` writes it; a poured molecule's root is
// TypeMolecule instead and carries no label.
const MoleculeTemplateLabel = "template"
// MoleculeReader is the read surface every molecule operation in this file is
// composed over: three roles every backend serves.
//
// - BatchGetter answers the molecule root and the parent walk's candidate
// roots, labeled, in either plane.
// - Relations answers a node's inbound parent-child steps as FULL rows, in
// either plane.
// - EdgeReader answers the parent walk (a step's outgoing parent-child edge)
// and the blocking edges between a molecule's steps.
//
// THE MOLECULE RULES HAVE ONE IMPLEMENTATION, and it is the functions below.
// A caller that reads committed state binds them to the roles
// (NewMoleculeReader). A close that must decide inside its own
// transaction binds them to the same three role BODIES running against that
// transaction (internal/storage/issueops.TxMoleculeReader, and the unit-of-work
// backend's MoleculeReaderInUOW), so a molecule's membership, completion and
// readiness mean one thing on every backend and every route.
//
// Membership is the parent-child EDGE. A child whose id merely looks
// hierarchical (<root>.<n>) but carries no edge is not a step: no role can
// express an id-pattern scan, and a rule only some routes could apply would
// make the same molecule answer differently per route.
type MoleculeReader struct {
BatchGetter
Relations
EdgeReader
}
// MoleculeReaderOver binds one value that answers all three role reads — an
// in-transaction binding, a test double — as a MoleculeReader.
func MoleculeReaderOver(r interface {
BatchGetter
Relations
EdgeReader
}) MoleculeReader {
return MoleculeReader{BatchGetter: r, Relations: r, EdgeReader: r}
}
func (r MoleculeReader) usable() bool {
return r.BatchGetter != nil && r.Relations != nil && r.EdgeReader != nil
}
// moleculeRoleSource is the accessor set a store or a unit-of-work provider
// offers for the three roles a MoleculeReader composes.
type moleculeRoleSource interface {
BatchGetter() (BatchGetter, error)
IssueRelations() (Relations, error)
EdgeReader() (EdgeReader, error)
}
// NewMoleculeReader binds a MoleculeReader to src's own role accessors, so
// every decorator src wears (hooks, telemetry, policy) stays in the path. src
// is a storage.DoltStorage or a unit-of-work provider.
func NewMoleculeReader(src moleculeRoleSource) (MoleculeReader, error) {
if src == nil {
return MoleculeReader{}, fmt.Errorf("%w: molecule reader needs a role source", ErrValidation)
}
getter, err := src.BatchGetter()
if err != nil {
return MoleculeReader{}, err
}
relations, err := src.IssueRelations()
if err != nil {
return MoleculeReader{}, err
}
edges, err := src.EdgeReader()
if err != nil {
return MoleculeReader{}, err
}
return MoleculeReader{BatchGetter: getter, Relations: relations, EdgeReader: edges}, nil
}
// IsMoleculeRoot reports whether issue is the root of a molecule: an epic, a
// TypeMolecule root (`bd mol pour`), or anything carrying the template label.
func IsMoleculeRoot(issue *Issue) bool {
if issue == nil {
return false
}
if issue.IssueType == types.TypeEpic || issue.IssueType == types.TypeMolecule {
return true
}
return hasLabel(issue, MoleculeTemplateLabel)
}
// AutoClosesWhenComplete reports whether a molecule root closes itself when
// its last step closes. Molecule-typed and ephemeral roots do, and so does a
// template-driven epic; an ordinary epic stays open so it becomes explicit,
// close-eligible work instead of closing as a side effect.
func AutoClosesWhenComplete(root *Issue) bool {
if root == nil {
return false
}
if root.IssueType == types.TypeMolecule || root.Ephemeral {
return true
}
return root.IssueType == types.TypeEpic && hasLabel(root, MoleculeTemplateLabel)
}
func hasLabel(issue *Issue, label string) bool {
for _, l := range issue.Labels {
if l == label {
return true
}
}
return false
}
// maxMoleculeDepth bounds the parent walk, so a parent-child cycle ends.
const maxMoleculeDepth = 50
// MoleculeRoots walks parent-child edges up from every id and answers, for
// each id that belongs to a molecule, the id of its molecule root. An id whose
// topmost ancestor is not a molecule root (IsMoleculeRoot) is omitted, and so
// is an id that names nothing. A root that is itself a molecule root answers
// itself.
//
// The walk is level by level, one edge read per level for every chain at
// once, so its cost is the depth of the deepest chain, not the number of ids.
// A read the backend fails or refuses is RETURNED: answering "not in a
// molecule" for a read that never happened is how a molecule root gets
// stranded open.
func MoleculeRoots(ctx context.Context, r MoleculeReader, ids []string) (map[string]string, error) {
rows, err := moleculeRootRows(ctx, r, ids)
if err != nil {
return nil, err
}
out := make(map[string]string, len(rows))
for start, root := range rows {
out[start] = root.ID
}
return out, nil
}
// moleculeRootRows is MoleculeRoots answering each id's molecule root ROW, as
// the walk read it.
func moleculeRootRows(ctx context.Context, r MoleculeReader, ids []string) (map[string]*Issue, error) {
out := map[string]*Issue{}
if len(ids) == 0 {
return out, nil
}
if !r.usable() {
return nil, fmt.Errorf("%w: molecule reads need a reader", ErrValidation)
}
topOf := make(map[string]string, len(ids))
current := make(map[string]string, len(ids))
for _, id := range ids {
current[id] = id
}
for depth := 0; depth < maxMoleculeDepth && len(current) > 0; depth++ {
level := distinctValues(current)
parentOf, err := parentChildParents(ctx, r, level)
if err != nil {
return nil, err
}
next := make(map[string]string, len(current))
for start, at := range current {
if parent, ok := parentOf[at]; ok {
next[start] = parent
} else {
topOf[start] = at
}
}
current = next
}
for start, at := range current {
topOf[start] = at
}
tops, err := getIssues(ctx, r, distinctValues(topOf))
if err != nil {
return nil, fmt.Errorf("loading molecule roots: %w", err)
}
for start, top := range topOf {
if root := tops[top]; IsMoleculeRoot(root) {
out[start] = root
}
}
return out, nil
}
// MoleculeRoot is MoleculeRoots for one id: the id's molecule root, or "" when
// it belongs to no molecule.
func MoleculeRoot(ctx context.Context, r MoleculeReader, id string) (string, error) {
roots, err := MoleculeRoots(ctx, r, []string{id})
if err != nil {
return "", err
}
return roots[id], nil
}
// parentChildParents answers each id's first outgoing parent-child target.
func parentChildParents(ctx context.Context, r MoleculeReader, ids []string) (map[string]string, error) {
res, err := r.ReadEdges(ctx, EdgeReadRequest{IDs: ids, Types: []types.DependencyType{types.DepParentChild}})
if err != nil {
return nil, fmt.Errorf("walking parent-child edges: %w", err)
}
parentOf := make(map[string]string, len(res.Anchors))
for _, anchor := range res.Anchors {
for _, edge := range anchor.Edges {
if edge != nil && edge.Type == types.DepParentChild {
parentOf[anchor.ID] = edge.DependsOnID
break
}
}
}
return parentOf, nil
}
// getIssues reads ids through the BatchGetter in batches the role accepts and
// answers them by id. Missing ids are absent.
func getIssues(ctx context.Context, r MoleculeReader, ids []string) (map[string]*Issue, error) {
out := make(map[string]*Issue, len(ids))
for start := 0; start < len(ids); start += MaxGetManyIDs {
end := min(start+MaxGetManyIDs, len(ids))
res, err := r.GetMany(ctx, GetManyRequest{IDs: ids[start:end]})
if err != nil {
return nil, err
}
for _, issue := range res.Issues {
if issue != nil {
out[issue.ID] = issue
}
}
}
return out, nil
}
func distinctValues(m map[string]string) []string {
seen := make(map[string]bool, len(m))
out := make([]string, 0, len(m))
for _, v := range m {
if !seen[v] {
seen[v] = true
out = append(out, v)
}
}
sort.Strings(out)
return out
}
// MoleculeGraph is a molecule root, every step under it and the edges between
// them.
type MoleculeGraph struct {
// Root is the molecule root, labeled.
Root *Issue
// Issues holds the root first, then every descendant in depth-first
// pre-order of the parent-child edges.
Issues []*Issue
// Dependencies holds every stored edge whose two ends are both in Issues.
Dependencies []*Dependency
// IssueMap indexes Issues by id.
IssueMap map[string]*Issue
}
// LoadMolecule reads the molecule rooted at rootID: the root, every
// parent-child descendant as a full row, and the edges between them. A root
// that names nothing is ErrNotFound. A parent-child cycle terminates.
func LoadMolecule(ctx context.Context, r MoleculeReader, rootID string) (*MoleculeGraph, error) {
if !r.usable() {
return nil, fmt.Errorf("%w: molecule reads need a reader", ErrValidation)
}
roots, err := getIssues(ctx, r, []string{rootID})
if err != nil {
return nil, fmt.Errorf("loading molecule %s: %w", rootID, err)
}
root := roots[rootID]
if root == nil {
return nil, fmt.Errorf("%w: molecule %s", ErrNotFound, rootID)
}
g := &MoleculeGraph{Root: root, Issues: []*Issue{root}, IssueMap: map[string]*Issue{root.ID: root}}
if err := loadMoleculeChildren(ctx, r, g, root.ID); err != nil {
return nil, err
}
ids := make([]string, len(g.Issues))
for i, issue := range g.Issues {
ids[i] = issue.ID
}
edges, err := r.ReadEdges(ctx, EdgeReadRequest{IDs: ids})
if err != nil {
return nil, fmt.Errorf("reading molecule %s edges: %w", rootID, err)
}
for _, anchor := range edges.Anchors {
for _, edge := range anchor.Edges {
if edge == nil {
continue
}
if _, ok := g.IssueMap[edge.DependsOnID]; ok {
g.Dependencies = append(g.Dependencies, edge)
}
}
}
return g, nil
}
func loadMoleculeChildren(ctx context.Context, r MoleculeReader, g *MoleculeGraph, parentID string) error {
children, err := r.Related(ctx, RelatedRequest{
ID: parentID,
Direction: RelationIn,
Types: []types.DependencyType{types.DepParentChild},
})
if errors.Is(err, ErrNotFound) {
return nil
}
if err != nil {
return fmt.Errorf("reading the steps of %s: %w", parentID, err)
}
for _, child := range children {
if child == nil || child.DependencyType != types.DepParentChild {
continue
}
if _, seen := g.IssueMap[child.ID]; seen {
continue
}
issue := child.Issue
g.Issues = append(g.Issues, &issue)
g.IssueMap[issue.ID] = &issue
if err := loadMoleculeChildren(ctx, r, g, issue.ID); err != nil {
return err
}
}
return nil
}
// MoleculeStepInfo is one node's readiness inside its molecule.
type MoleculeStepInfo struct {
StepID string `json:"step_id"`
Status string `json:"status"`
IsReady bool `json:"is_ready"` // Can start now (no open blocker)
ParallelGroup string `json:"parallel_group"` // Steps sharing a group can run concurrently
BlockedBy []string `json:"blocked_by"` // Open steps blocking this one
Blocks []string `json:"blocks"` // Steps this one blocks
CanParallel []string `json:"can_parallel"` // Steps that can run in parallel with this one
}
// MoleculeAnalysis is the readiness and parallelism of every node of a
// molecule, root included.
type MoleculeAnalysis struct {
MoleculeID string `json:"molecule_id"`
TotalSteps int `json:"total_steps"`
ReadySteps int `json:"ready_steps"`
ParallelGroups map[string][]string `json:"parallel_groups"` // group id -> step ids
Steps map[string]*MoleculeStepInfo `json:"steps"`
}
// AnalyzeMolecule computes readiness from the edges inside the molecule
// rather than from the workspace ready query, which excludes ephemeral rows (a
// wisp molecule's steps are ephemeral by definition). A node is ready when it
// is open or in progress and no open node blocks it through a blocks,
// conditional-blocks or waits-for edge. Nodes at the same blocking depth that
// do not block each other share a parallel group.
func AnalyzeMolecule(g *MoleculeGraph) *MoleculeAnalysis {
analysis := &MoleculeAnalysis{
MoleculeID: g.Root.ID,
TotalSteps: len(g.Issues),
ParallelGroups: make(map[string][]string),
Steps: make(map[string]*MoleculeStepInfo),
}
blockedBy := make(map[string]map[string]bool)
blocks := make(map[string]map[string]bool)
parentChildren := make(map[string][]string)
for _, issue := range g.Issues {
blockedBy[issue.ID] = make(map[string]bool)
blocks[issue.ID] = make(map[string]bool)
}
for _, dep := range g.Dependencies {
if dep.Type == types.DepParentChild {
parentChildren[dep.DependsOnID] = append(parentChildren[dep.DependsOnID], dep.IssueID)
}
}
for _, dep := range g.Dependencies {
switch dep.Type {
case types.DepBlocks, types.DepConditionalBlocks:
if _, ok := blockedBy[dep.IssueID]; ok {
blockedBy[dep.IssueID][dep.DependsOnID] = true
}
if _, ok := blocks[dep.DependsOnID]; ok {
blocks[dep.DependsOnID][dep.IssueID] = true
}
case types.DepWaitsFor:
children := parentChildren[dep.DependsOnID]
if len(children) == 0 {
continue
}
if types.ParseWaitsForGateMetadata(dep.Metadata) == types.WaitsForAnyChildren && anyClosed(g, children) {
continue
}
// For all-children (and unresolved any-children) every open child
// blocks the gate.
for _, childID := range children {
child := g.IssueMap[childID]
if child == nil || child.Status == types.StatusClosed {
continue
}
if _, ok := blockedBy[dep.IssueID]; ok {
blockedBy[dep.IssueID][childID] = true
}
if _, ok := blocks[childID]; ok {
blocks[childID][dep.IssueID] = true
}
}
}
}
for _, issue := range g.Issues {
info := &MoleculeStepInfo{StepID: issue.ID, Status: string(issue.Status), BlockedBy: []string{}, Blocks: []string{}}
for blockerID := range blockedBy[issue.ID] {
if blocker := g.IssueMap[blockerID]; blocker != nil && blocker.Status != types.StatusClosed {
info.BlockedBy = append(info.BlockedBy, blockerID)
}
}
for blockedID := range blocks[issue.ID] {
info.Blocks = append(info.Blocks, blockedID)
}
info.IsReady = (issue.Status == types.StatusOpen || issue.Status == types.StatusInProgress) && len(info.BlockedBy) == 0
if info.IsReady {
analysis.ReadySteps++
}
sort.Strings(info.BlockedBy)
sort.Strings(info.Blocks)
analysis.Steps[issue.ID] = info
}
depths := blockingDepths(g, blockedBy)
depthGroups := make(map[int][]string)
for _, issue := range g.Issues {
depthGroups[depths[issue.ID]] = append(depthGroups[depths[issue.ID]], issue.ID)
}
groupCounter := 0
for depth := 0; depth <= len(g.Issues); depth++ {
groupCounter = groupParallelSteps(analysis, depthGroups[depth], blocks, blockedBy, groupCounter)
}
return analysis
}
func anyClosed(g *MoleculeGraph, ids []string) bool {
for _, id := range ids {
if child := g.IssueMap[id]; child != nil && child.Status == types.StatusClosed {
return true
}
}
return false
}
// groupParallelSteps unions the steps at one blocking depth that do not block
// each other and names every group of two or more. It answers the updated
// group counter.
func groupParallelSteps(analysis *MoleculeAnalysis, steps []string, blocks, blockedBy map[string]map[string]bool, counter int) int {
if len(steps) == 0 {
return counter
}
parent := make(map[string]string, len(steps))
for _, id := range steps {
parent[id] = id
}
find := func(x string) string {
for parent[x] != x {
parent[x] = parent[parent[x]]
x = parent[x]
}
return x
}
for i, a := range steps {
for _, b := range steps[i+1:] {
if !blocks[a][b] && !blocks[b][a] && !blockedBy[a][b] && !blockedBy[b][a] {
if pa, pb := find(a), find(b); pa != pb {
parent[pa] = pb
}
}
}
}
groups := make(map[string][]string)
var order []string
for _, id := range steps {
root := find(id)
if _, ok := groups[root]; !ok {
order = append(order, root)
}
groups[root] = append(groups[root], id)
}
for _, root := range order {
members := groups[root]
if len(members) < 2 {
continue
}
counter++
name := fmt.Sprintf("group-%d", counter)
analysis.ParallelGroups[name] = members
for _, id := range members {
info := analysis.Steps[id]
info.ParallelGroup = name
for _, other := range members {
if other != id {
info.CanParallel = append(info.CanParallel, other)
}
}
sort.Strings(info.CanParallel)
}
}
return counter
}
// blockingDepths answers each node's blocking depth: 0 with no open blocker,
// one more than its deepest open blocker otherwise. A cycle counts as 0.
func blockingDepths(g *MoleculeGraph, blockedBy map[string]map[string]bool) map[string]int {
depths := make(map[string]int)
visiting := make(map[string]bool)
var depthOf func(id string) int
depthOf = func(id string) int {
if d, ok := depths[id]; ok {
return d
}
if visiting[id] {
return 0
}
visiting[id] = true
deepest := -1
for blockerID := range blockedBy[id] {
if blocker := g.IssueMap[blockerID]; blocker != nil && blocker.Status != types.StatusClosed {
deepest = max(deepest, depthOf(blockerID))
}
}
depths[id] = deepest + 1
return depths[id]
}
for _, issue := range g.Issues {
depthOf(issue.ID)
}
return depths
}
// Molecule step states, as MoleculeStep.State spells them.
const (
MoleculeStepDone = "done"
MoleculeStepCurrent = "current"
MoleculeStepReady = "ready"
MoleculeStepBlocked = "blocked"
MoleculeStepPending = "pending"
)
// MoleculeStep is one step of a MoleculeView.
type MoleculeStep struct {
Issue *Issue
// State is one of the MoleculeStep* constants: done (closed), current (in
// progress), blocked (status blocked), ready (open, no open blocker inside
// the molecule) or pending.
State string
IsCurrent bool
}
// MoleculeView is where a molecule stands: every step's state, the progress
// counts, the step in progress and the next ready one.
type MoleculeView struct {
Graph *MoleculeGraph
Analysis *MoleculeAnalysis
// Steps holds every step (the root excluded) ordered by how many blocking
// edges inside the molecule each one waits on, fewest first, stable over
// the graph's own order.
Steps []*MoleculeStep
// Completed counts the closed steps and Total every step.
Completed int
Total int
// CurrentStep is the step in progress (the last one in graph order when
// several are); NextStep the first ready step.
CurrentStep *Issue
NextStep *Issue
// Ready holds every node the analysis marks ready (open or in progress
// with no open blocker inside the molecule), root included, in graph
// order: `bd ready --mol`'s list, hydrated rows (assignee and all).
Ready []*Issue
}
// Complete reports whether every step of the molecule is closed.
func (v *MoleculeView) Complete() bool { return v.Completed >= v.Total }
// ViewMolecule loads the molecule rooted at rootID and derives its view.
func ViewMolecule(ctx context.Context, r MoleculeReader, rootID string) (*MoleculeView, error) {
g, err := LoadMolecule(ctx, r, rootID)
if err != nil {
return nil, err
}
return MoleculeViewOf(g), nil
}
// MoleculeViewOf derives the view of an already loaded graph.
func MoleculeViewOf(g *MoleculeGraph) *MoleculeView {
analysis := AnalyzeMolecule(g)
view := &MoleculeView{Graph: g, Analysis: analysis, Total: len(g.Issues) - 1}
for _, issue := range g.Issues {
if info := analysis.Steps[issue.ID]; info != nil && info.IsReady {
view.Ready = append(view.Ready, issue)
}
if issue.ID == g.Root.ID {
continue
}
step := &MoleculeStep{Issue: issue}
switch issue.Status {
case types.StatusClosed:
step.State = MoleculeStepDone
view.Completed++
case types.StatusInProgress:
step.State = MoleculeStepCurrent
step.IsCurrent = true
view.CurrentStep = issue
case types.StatusBlocked:
step.State = MoleculeStepBlocked
default:
if info := analysis.Steps[issue.ID]; info != nil && info.IsReady {
step.State = MoleculeStepReady
if view.NextStep == nil {
view.NextStep = issue
}
} else {
step.State = MoleculeStepPending
}
}
view.Steps = append(view.Steps, step)
}
sortStepsByBlockers(view.Steps, g)
return view
}
// ReadySteps answers the steps whose state is ready, in view order.
func (v *MoleculeView) ReadySteps() []*Issue {
var out []*Issue
for _, step := range v.Steps {
if step.State == MoleculeStepReady {
out = append(out, step.Issue)
}
}
return out
}
func sortStepsByBlockers(steps []*MoleculeStep, g *MoleculeGraph) {
inSteps := make(map[string]bool, len(steps))
for _, step := range steps {
inSteps[step.Issue.ID] = true
}
waits := make(map[string]int, len(steps))
for _, dep := range g.Dependencies {
if dep.Type == types.DepBlocks && inSteps[dep.IssueID] && inSteps[dep.DependsOnID] {
waits[dep.IssueID]++
}
}
sort.SliceStable(steps, func(i, j int) bool {
return waits[steps[i].Issue.ID] < waits[steps[j].Issue.ID]
})
}
// MoleculeProgress is a molecule's progress counts over its DIRECT
// parent-child steps.
type MoleculeProgress = types.MoleculeProgressStats
// ReadMoleculeProgress counts the direct steps of the molecule rooted at
// rootID without loading the whole graph. A root that names nothing is
// ErrNotFound.
func ReadMoleculeProgress(ctx context.Context, r MoleculeReader, rootID string) (*MoleculeProgress, error) {
if !r.usable() {
return nil, fmt.Errorf("%w: molecule reads need a reader", ErrValidation)
}
roots, err := getIssues(ctx, r, []string{rootID})
if err != nil {
return nil, fmt.Errorf("loading molecule %s: %w", rootID, err)
}
root := roots[rootID]
if root == nil {
return nil, fmt.Errorf("%w: molecule %s", ErrNotFound, rootID)
}
children, err := r.Related(ctx, RelatedRequest{
ID: rootID,
Direction: RelationIn,
Types: []types.DependencyType{types.DepParentChild},
})
if err != nil {
return nil, fmt.Errorf("reading the steps of %s: %w", rootID, err)
}
return MoleculeProgressOf(root, children), nil
}
// MoleculeProgressOf folds a root's inbound parent-child neighbors into its
// progress counts. CurrentStepID is the first in-progress step in the order
// given.
func MoleculeProgressOf(root *Issue, children []*RelatedIssue) *MoleculeProgress {
stats := &MoleculeProgress{}
if root != nil {
stats.MoleculeID, stats.MoleculeTitle = root.ID, root.Title
}
for _, child := range children {
if child == nil || child.DependencyType != types.DepParentChild {
continue
}
stats.Total++
switch child.Status {
case types.StatusClosed:
stats.Completed++
case types.StatusInProgress:
stats.InProgress++
if stats.CurrentStepID == "" {
stats.CurrentStepID = child.ID
}
}
}
return stats
}
// CompletedMolecule answers the molecule root that closing stepID completed
// and that closes itself when complete (AutoClosesWhenComplete): the root is
// open and every step under it is closed. It answers nil when stepID belongs
// to no molecule, when the root is already closed or does not auto-close, or
// when a step is still open. It writes nothing; the caller closes the root,
// guarded on the RowVersion of the root it answers.
//
// It is AutoClosingMoleculeRoots then MoleculeStepsClosed, so a step under an
// ordinary epic, or under a root already closed, never reads the steps.
func CompletedMolecule(ctx context.Context, r MoleculeReader, stepID string) (*Issue, error) {
roots, err := AutoClosingMoleculeRoots(ctx, r, []string{stepID})
if err != nil {
return nil, err
}
root := roots[stepID]
if root == nil {
return nil, nil
}
complete, err := MoleculeStepsClosed(ctx, r, root.ID)
if err != nil || !complete {
return nil, err
}
return root, nil
}
// AutoClosingMoleculeRoots answers, for each id whose molecule root is open
// and closes itself when complete (AutoClosesWhenComplete), that root's row:
// the roots a close of ids could complete. It is the parent walk and the root
// rows MoleculeRoots reads, and nothing more — it never reads a molecule's
// steps — so a caller deciding several closes reads each root once and walks
// only the molecules that could auto-close.
func AutoClosingMoleculeRoots(ctx context.Context, r MoleculeReader, ids []string) (map[string]*Issue, error) {
rows, err := moleculeRootRows(ctx, r, ids)
if err != nil {
return nil, err
}
for id, root := range rows {
if root.Status == types.StatusClosed || !AutoClosesWhenComplete(root) {
delete(rows, id)
}
}
return rows, nil
}
// MoleculeStepsClosed reports whether every parent-child descendant of rootID
// is closed — the steps LoadMolecule would load. It reads one level of steps
// at a time and answers false at the first step that is not closed, so an
// incomplete molecule costs the reads up to its first open step, not a load of
// the whole tree. A root with no steps answers true; a parent-child cycle
// terminates.
func MoleculeStepsClosed(ctx context.Context, r MoleculeReader, rootID string) (bool, error) {
if !r.usable() {
return false, fmt.Errorf("%w: molecule reads need a reader", ErrValidation)
}
seen := map[string]bool{rootID: true}
pending := []string{rootID}
for len(pending) > 0 {
parentID := pending[len(pending)-1]
pending = pending[:len(pending)-1]
children, err := r.Related(ctx, RelatedRequest{
ID: parentID,
Direction: RelationIn,
Types: []types.DependencyType{types.DepParentChild},
})
if errors.Is(err, ErrNotFound) {
continue
}
if err != nil {
return false, fmt.Errorf("reading the steps of %s: %w", parentID, err)
}
for _, child := range children {
if child == nil || child.DependencyType != types.DepParentChild || seen[child.ID] {
continue
}
if child.Status != types.StatusClosed {
return false, nil
}
seen[child.ID] = true
pending = append(pending, child.ID)
}
}
return true, nil
}
// MoleculeAutoCloseReason is the close reason a molecule root's auto-close
// records.
const MoleculeAutoCloseReason = "all steps complete"
// IsMoleculeAutoCloseRefusal reports whether err is a refusal of a completed
// molecule's root close — an outcome that leaves the root open without failing
// the step close that completed it: the close policy (a live blocker,
// ErrCloseBlocked; open children, *CloseOpenChildrenError) or a close guard (a
// template root, *TemplateReadOnlyError; a pinned root, *PinnedError; a root
// assigned to someone else, *CloseNotAssigneeError). The root close is
// unforced (MoleculeRootClose), so every guard holds for it exactly as it does
// for a direct close of the root. A guard only reads, before the close writes
// anything, and a policy refusal rolls back to the close's savepoint, so a
// refusal leaves the step close's transaction as it found it.
//
// ErrVersionMismatch on the root is NOT a refusal: should a backend's check
// ever see a revision its read did not, it fails the step's close
// (CloseRequest.AutoCloseMolecule). A write to the root that races the close
// does not produce it (MoleculeRootClose).
func IsMoleculeAutoCloseRefusal(err error) bool {
var (
openChildren *CloseOpenChildrenError
template *TemplateReadOnlyError
pinned *PinnedError
notAssignee *CloseNotAssigneeError
)
return errors.Is(err, ErrCloseBlocked) ||
errors.As(err, &openChildren) ||
errors.As(err, &template) ||
errors.As(err, &pinned) ||
errors.As(err, &notAssignee)
}
// MoleculeRootClose is the ONE close request a molecule auto-close sends for a
// root it found complete (AutoClosingMoleculeRoots, then MoleculeStepsClosed,
// read in the transaction that closes it): unforced, recording
// MoleculeAutoCloseReason and the step close's session, and guarded on the
// RowVersion of root as that read answered it. Every backend's
// in-transaction auto-close (CloseRequest.AutoCloseMolecule) builds its root
// close from it.
//
// The guard covers the root row's lifecycle state and nothing else (the
// version family's rule: it guards a row's lifecycle state, not its graph).
// Every backend reads the root and checks its revision in one transaction
// snapshot, so a status, assignee or started_at write that another
// transaction commits to the root after the read does not trip the guard. It
// conflicts with the root close at commit instead, and the backend's retry
// re-reads the root and decides again (a root another actor now holds is a
// refusal, and the step's close stands); only a close still conflicting when
// its retry budget runs out fails, with the serialization error. The guard
// does not cover the steps: reopening a step writes no root row, so a reopen
// that races the auto-close is not detected, and the root can close over the
// reopened step.
func MoleculeRootClose(root *Issue, actor, session string) CloseRequest {
version := root.RowVersion
return CloseRequest{
Actor: actor,
IssueID: root.ID,
Reason: MoleculeAutoCloseReason,
Session: session,
ExpectedVersion: &version,
}
}