* perf(dolt): be-1he eliminate 12s `dolt remote -v` against multi-db server roots
Three layers of defense for the bd 12s slow-path bug:
- Layer 1: migrateServerRootRemotes skips when rootDir/.dolt/repo_state.json
is missing. Multi-database server roots have only sql-server.info; running
`dolt remote -v` there takes ~12s to fail.
- Layer 2: ListCLIRemotes wraps the dolt subprocess in a 2s context timeout.
Backstops Layer 1 against any future variant of the broken-parent-dir case.
- Layer 3: autoMigrateOnVersionBump does a read-only probe of bd_version
before opening writeable. Read-only stores skip syncCLIRemotesToSQL, so a
stale .local_version (e.g. from a multi-binary install) no longer triggers
the slow path on every command.
End-user impact pre-fix: gc mail inbox 60-80s, gc status 30s+ hangs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: release gate PASS for be-1he (3-layer slow-path fix)
* docs(repro): add be-1he slow-path repro script (be-vxngmn)
Adds scripts/repro-be-1he-slow-path/repro.sh + REPRO.md demonstrating
the 12-second `dolt remote -v` slow path on multi-DB server roots.
Satisfies coffeegoddd's review request: "We need a beads-only repro of
this to prove its a bug."
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(cli): regenerate CLI reference after slow-path fix rebase
Output of ./scripts/generate-cli-docs.sh ./bd and ./scripts/generate-llms-full.sh.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(cli): regenerate CLI reference + llms-full with pure-go bd
The previous regen (0aeb5934e) was built with a CGO-enabled bd, which
includes the CGO-only `bd federation` subcommands. CI builds the docs
binary with CGO_ENABLED=0 (scripts/ci/pr-policy.sh build_docs_binary),
so check-doc-flags rejected the extra federation subcommand pages.
Regenerated docs/CLI_REFERENCE.md, the federation cli-reference pages
(live + versioned 1.0.0/1.0.4/1.0.5), and website/static/llms-full.txt
with a CGO_ENABLED=0 binary. check-doc-flags + check-doc-freshness now
pass locally under LC_ALL=C.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(release-gate): correct be-1he layer description to match shipped diff
The PR body and this gate doc both described a "Layer 1" repo_state.json
sentinel in internal/storage/dolt/federation.go, but the actual diff never
touched that file - only cmd/bd/version_tracking.go (Layer 3) and
internal/storage/doltutil/remotes.go (Layer 2) are changed. Correct the
gate doc's commit table, acceptance-criteria row, and follow-up/out-of-scope
notes to describe only what ships. No code or test changes; Layer 2 and
Layer 3 remain independently verified as still-needed on current main
(ListCLIRemotes has no timeout, no equivalent sentinel exists).
Agent-Signature: claude-sonnet-medium on behalf of maphew
* fix(dolt): scope ListCLIRemotes timeout, fix repro.sh, purge Layer 1 narrative
Addresses the cross-vendor review's four should-fixes plus the comment nit
(gastownhall/beads#3710 review, 2026-07-24):
1. ListCLIRemotes' 2s cap could turn a slow-but-valid dolt remote -v into
"remote absent": FindCLIRemote folds any error (including a timeout) into
"", and EnsureCLIRemote then blind-adds on that signal, which hard-fails
if the remote actually exists. Chose the "scope the cap" fix over
"propagate DeadlineExceeded distinctly": it's fully contained inside
ListCLIRemotes (no changes needed at the three call sites - remotes.go:192
ensure-path, store.go:1958 URL match via hasMatchingCLIRemote, and
doctor/federation.go:127, which already treats errors distinctly from "no
remotes"), whereas threading a sentinel error type through FindCLIRemote's
string-returning signature and its callers touches more surface for the
same outcome. ListCLIRemotes now stats dbPath/.dolt/repo_state.json: 2s
cap when absent (the known broken multi-DB server-root case - there's
never a real answer coming from there), 30s cap otherwise (a real repo's
`dolt remote -v` is ~130ms even loaded, so 30s only bites a genuinely hung
subprocess). Added TestListCLIRemotesTimeout covering both branches,
following the t.TempDir() pattern already used in
persisted_remotes_test.go.
2. repro.sh's baseline `dolt remote -v` ran in the invocation directory, not
$SERVER_ROOT, so the central "slow" measurement never exercised the
constructed broken root. Fixed to `(cd "$SERVER_ROOT" && dolt remote -v
2>&1) || true`, matching the correct subshell pattern already used later
in the script. Also relabeled the "PARTIAL FIX ... Layer 2 timeout capped
it" branch: the 2s cap lives in bd's Go code, not dolt, and this script
calls the raw dolt binary directly - it's never capped. Relabeled to
describe the underlying dolt slowness the script demonstrates instead of
implying bd's timeout is in play here.
3. `dolt init --quiet` isn't supported by dolt 2.2.x and set -e killed the
script before it reached the summary. Redirected output instead
(`dolt init >/dev/null 2>&1`). Ran repro.sh end-to-end locally (dolt
2.2.0): completes with exit 0, and the fixed subshell now shows real
timing/output from inside $SERVER_ROOT.
4. Purged the unshipped "Layer 1" (federation.go sentinel) narrative from
repro.sh and REPRO.md - same reconciliation already done for the release
gate doc and PR body. Both files now describe only the two layers that
ship (remotes.go timeout, version_tracking.go read-only probe), with a
short note that an earlier draft described a Layer 1 that never landed.
5. cmd/bd/version_tracking.go:195-197 comment cited syncCLIRemotesToSQL,
which doesn't exist anywhere in the tree, and overstated the read-only
probe's benefit. On current main the writeable-open gate reads remotes
via doltutil.PersistedRemotes (a fast on-disk repo_state.json probe, no
dolt subprocess), so the probe saves an initSchema round-trip, not a 12s
hang. Corrected.
Agent-Signature: claude-sonnet-medium on behalf of maphew
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: matt wilkie <maphew@gmail.com>