* test(count): pin include_ephemeral as the plane bit and nothing else
PR #6240 added `bd count --include-ephemeral` so a count can reach the
wisps table without IncludeInfra's other three changes: dropping
templates, dropping gates, and routing an infra type to the ephemeral
tier. Nothing asserted that second half. Routing IncludeEphemeral
through the builder's infra branch, or mapping `include_ephemeral` onto
IncludeInfra in the HTTP handler or the CLI, passed every existing test.
- workapi: TestCountIncludeEphemeralIsThePlaneBitAndNothingElse, the
count twin of the list pin. IncludeEphemeral (no type, a named type,
an infra type) leaves IsTemplate, ExcludeTypes and Ephemeral unset;
IncludeInfra still sets all four.
- httpapi: TestCountForwardsTheEphemeralPlaneParameter sends each plane
parameter alone and asserts the exact request the role receives.
- cmd/bd: TestCountIncludeEphemeralFlagShape pins the flag, its false
default, and that --include-ephemeral alone leaves IncludeInfra false.
Each new test fails against its mutant, and it is the only test that
does:
- builder: `if in.IncludeInfra || in.IncludeEphemeral`
- handler: `IncludeInfra: q.boolean("include_infra") || q.boolean("include_ephemeral")`
- CLI: `IncludeInfra: includeInfra || includeEphemeral`
Post-merge review follow-up for #6240.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(count): name include_ephemeral where the plane prose said include_infra alone
#6240 added a second way to reach the wisps tier, but several statements
still said only include_infra could reach it:
- spec, countIssues "Planes": "DURABLE-PLANE ONLY unless include_infra
is set" now names both knobs and says what include_ephemeral changes.
- spec, include_infra: "Unset, the count is durable-plane only" now holds
only with include_ephemeral also unset (types.gen.go regenerated).
- issueops.CountRequest: the same "Unset" sentence on IncludeInfra and on
IncludeEphemeral, each now conditional on the other knob.
- workapi.applyCountIncludeInfra: "a count without IncludeInfra keeps its
durable-only semantics" now allows for IncludeEphemeral.
- httpapi countFilters: the "plane switch" comment named one knob;
IncludeEphemeral now has its own comment saying why it is never folded
into IncludeInfra.
- count_test.go: the default-plane comment names both zero values, and
the stale "25 filters" / "26th filter" literals are dropped (the
struct has 26 fields).
Comment and spec-prose only; `make api-check` is green.
Post-merge review follow-up for #6240.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Eddie the Engineer <adopt-pr@gascity.local>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>