beads/issueops
Julian Knutsen 8995f2471e
test(count): pin --include-ephemeral as the plane bit alone, and fix the plane prose (post-merge #6240) (#6998)
* test(count): pin include_ephemeral as the plane bit and nothing else

PR #6240 added `bd count --include-ephemeral` so a count can reach the
wisps table without IncludeInfra's other three changes: dropping
templates, dropping gates, and routing an infra type to the ephemeral
tier. Nothing asserted that second half. Routing IncludeEphemeral
through the builder's infra branch, or mapping `include_ephemeral` onto
IncludeInfra in the HTTP handler or the CLI, passed every existing test.

- workapi: TestCountIncludeEphemeralIsThePlaneBitAndNothingElse, the
  count twin of the list pin. IncludeEphemeral (no type, a named type,
  an infra type) leaves IsTemplate, ExcludeTypes and Ephemeral unset;
  IncludeInfra still sets all four.
- httpapi: TestCountForwardsTheEphemeralPlaneParameter sends each plane
  parameter alone and asserts the exact request the role receives.
- cmd/bd: TestCountIncludeEphemeralFlagShape pins the flag, its false
  default, and that --include-ephemeral alone leaves IncludeInfra false.

Each new test fails against its mutant, and it is the only test that
does:
- builder: `if in.IncludeInfra || in.IncludeEphemeral`
- handler: `IncludeInfra: q.boolean("include_infra") || q.boolean("include_ephemeral")`
- CLI:     `IncludeInfra: includeInfra || includeEphemeral`

Post-merge review follow-up for #6240.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(count): name include_ephemeral where the plane prose said include_infra alone

#6240 added a second way to reach the wisps tier, but several statements
still said only include_infra could reach it:

- spec, countIssues "Planes": "DURABLE-PLANE ONLY unless include_infra
  is set" now names both knobs and says what include_ephemeral changes.
- spec, include_infra: "Unset, the count is durable-plane only" now holds
  only with include_ephemeral also unset (types.gen.go regenerated).
- issueops.CountRequest: the same "Unset" sentence on IncludeInfra and on
  IncludeEphemeral, each now conditional on the other knob.
- workapi.applyCountIncludeInfra: "a count without IncludeInfra keeps its
  durable-only semantics" now allows for IncludeEphemeral.
- httpapi countFilters: the "plane switch" comment named one knob;
  IncludeEphemeral now has its own comment saying why it is never folded
  into IncludeInfra.
- count_test.go: the default-plane comment names both zero values, and
  the stale "25 filters" / "26th filter" literals are dropped (the
  struct has 26 fields).

Comment and spec-prose only; `make api-check` is green.

Post-merge review follow-up for #6240.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Eddie the Engineer <adopt-pr@gascity.local>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 01:14:25 -07:00
..
batchapplier.go Add issueops.BatchApplier: one plan, one transaction (#5480) 2026-08-09 06:59:34 -07:00
batchcloser.go Pin the is_blocked invariant as a postcondition of the roles that maintain it (#5436) 2026-08-08 11:23:34 -07:00
batchcreator.go feat(create): put bd create --file behind the BatchCreator role (bd-lu170) 2026-08-05 16:43:11 +00:00
blockedstate.go Pin the is_blocked invariant as a postcondition of the roles that maintain it (#5436) 2026-08-08 11:23:34 -07:00
blockingannotator.go feat(list): put bd list behind Reader.List and the new BlockingAnnotator role (bd-5k21g) 2026-08-06 02:56:57 +00:00
bootstrapper.go feat(init): put bd init's identity seam behind Bootstrapper and InitVerifier (bd-zl3u8) 2026-08-06 03:01:33 +00:00
BUILD.bazel test(bazel): runfiles helpers + declared inputs for scan-guard tests (#6828) 2026-09-27 08:24:08 -07:00
claimer.go chore: retire a zombie test, drop a dead field, true up two leaf docs (#5492) 2026-08-09 10:42:34 -07:00
claimer_external_test.go Add issueops.Claimer and route the HTTP claim through it (#5334) 2026-08-04 08:40:18 -07:00
commenter.go chore: retire a zombie test, drop a dead field, true up two leaf docs (#5492) 2026-08-09 10:42:34 -07:00
counter.go test(count): pin --include-ephemeral as the plane bit alone, and fix the plane prose (post-merge #6240) (#6998) 2026-10-01 01:14:25 -07:00
cycledetector.go feat(dep): detect cycles through tracks edges (#6148) 2026-09-30 20:20:17 -07:00
deleter.go Add DeleteRequest.ExpectedVersion: a compare-and-delete on the named row (#5481) 2026-08-09 07:17:54 -07:00
dependencyeditor.go feat(purge): live-dependent protection, --wisps-plane selector, hour-precision --older-than, --limit (#6883) 2026-09-28 00:57:24 -07:00
edgereader.go feat(issueops): put multi-id bd dep list behind the EdgeReader role (bd-nhsno) 2026-08-05 09:42:06 +00:00
errors.go feat(serve): name the blockers on a live-blocker not_closable (#6893) 2026-10-01 00:51:06 -07:00
graphcounter.go docs: the ext-api-store documentation tranche — post-#5516 auth sweep, wave doc coherence, role checklist refresh (#5545) 2026-08-10 08:05:07 -07:00
importer.go fix(import): seed issue_prefix from config.yaml before the batch guard needs it (#6624) 2026-09-26 15:01:04 -07:00
initverifier.go feat(init): put bd init's identity seam behind Bootstrapper and InitVerifier (bd-zl3u8) 2026-08-06 03:01:33 +00:00
issueops.go chore(api): mark new exported packages experimental before v1.3.0 (#6036) 2026-08-29 16:01:30 -07:00
issueops_external_test.go feat(serve): name the blockers on a live-blocker not_closable (#6893) 2026-10-01 00:51:06 -07:00
metadatacas.go docs: the ext-api-store documentation tranche — post-#5516 auth sweep, wave doc coherence, role checklist refresh (#5545) 2026-08-10 08:05:07 -07:00
querier.go fix(query): apply bd list's piped-output limit policy to bd query (#6229) (#6744) 2026-09-26 02:50:09 -07:00
reader.go fix(list): expose comment bodies in bd list/show --json (be-73x) (#6473) 2026-09-27 02:12:13 -07:00
reader_ready_scope.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
readyclaimer.go feat(workapi,storage): opt-in Brief projection for the list and ready pages (#5554) 2026-08-10 10:45:23 -07:00
readycounter.go feat(ready): put bd ready's published total behind the ReadyCounter role (bd-s10oa) 2026-08-05 09:47:24 +00:00
relations.go feat(issueops): put every issue capability behind one library surface 2026-08-04 12:27:56 -07:00
releaser.go fix: canonicalActor collapses the --/__ axes correctly; claim-verify uses ActorMatches (be-p7dzx, bundled be-vc51) (#5856) 2026-08-19 13:23:35 -07:00
statsreporter.go fix(status): disclose the counted rows bd list will not show (#5763) 2026-09-30 15:44:40 -07:00
sweeper.go feat(purge): live-dependent protection, --wisps-plane selector, hour-precision --older-than, --limit (#6883) 2026-09-28 00:57:24 -07:00
treewalker.go Converge Offset and MaxRows on all three legs, and fix the panic and the breaker hole under them (#5435) 2026-08-08 11:37:09 -07:00
versionreconciler.go feat(issueops): put the startup version reconciler behind the VersionReconciler role (bd-gkmft) 2026-08-05 16:35:01 +00:00
workspaceconfig.go Refuse kv.* point reads on the settings role and stop printing them (#5493) 2026-08-09 11:06:51 -07:00