The whole fix-package DB-backed suite was silently skipping, locally and in
CI: newFixTestStore predates the dolt.New create-guard and never passed
CreateIfMissing, so every test using it hit the skip path (bd-nxt5e).
Re-enabling it surfaced what the darkness was hiding:
- newIdentityTestStore built database names from full subtest names, blowing
past Dolt's name length limit — 4/5 TestVerifyFixTargetIdentity subtests
were failing. Names are now hashed like newFixTestStore's.
- The same missing CreateIfMissing bug in maintenance_cgo_test.go,
migrate_import_test.go, and metadata_dolt_test.go setups.
- A real product bug (bd-kjfsq): DatabaseVersionWithBdVersion's fresh-clone
branch — whose explicit purpose is creating the store — calls
dolt.NewFromConfig without CreateIfMissing, so doctor --fix has failed
with 'database not found' on exactly the fresh clones it exists for since
the create-guard landed. Caught by
TestDatabaseVersionWithBdVersion_ImportsJSONL the moment its skip fell.
Guard against regression: requireFixDoltContainer centralizes the
no-container skip and honors BEADS_FIX_REQUIRE_DOLT=1 (mirroring the
protocol package's BEADS_PROTOCOL_REQUIRE_DOLT), set in the test-domain-uow
CI job — which already pulls the Dolt image — so a missing container is a
hard failure there, never a silent skip. Once the container is up, dolt.New
failures are t.Fatal, not t.Skip.
Full package suite vs the real container: 92 passed, 0 failed; remaining
skips are bd-binary E2E tests and removed-feature stubs.
Claude-Session: https://claude.ai/code/session_01L5Z2ovQDzoMFDxyRe87vD5
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>