beads/.github/scripts
CI Bot b9c6629188 test(storage): demote the duplicated keyset and max-rows backend tests
RunSearchPaging now owns these behaviors in the shared suite, and both
backends run it through their own TestConformance -> RunAll. Keeping the
backend-local copies would leave the same scenario asserted at two layers.
The deletions ride the same PR as the block that supersedes them, so no
window exists where a behavior has zero owning proofs.

The five retired embeddeddolt tests also leave the CI shard manifest
(.github/scripts/embedded-storage-test-shards.txt), which is why that file
moves in this commit rather than a follow-up: embedded-storage-test-shard.sh
validates every manifest entry against the discovered test set and exits 1
on a miss, and it does so for every shard, not only the shards owning the
stale names. Nothing is re-added — the script hash-distributes tests that
are not listed, and the manifest's own comment stops citing the retired
TestSearchIssues_MaxRows_* family as a spreading example.

Every retired assertion and its new owner, all under
backend/conformance RunSearchPaging:

internal/storage/dolt/keyset_search_test.go (partial; file kept)
  TestSearchIssuesKeysetSameSecondOverflow
    one-shot (created_at DESC, id ASC) order
      -> KeysetWalkLosesNothingAndRepeatsNothing, one-shot leg
    page-size-2 walk: nothing dropped, no id twice, page within Limit
      -> KeysetWalkLosesNothingAndRepeatsNothing, walk leg
    resume after k-a3 = [k-a4 k-a5 k-older]
      -> KeysetResumeAnswersTheStrictlyAfterRows, mid-group leg
    ksIDs / ksEqual helpers -> conformance orderedIDs + reflect.DeepEqual
  TestSearchIssuesKeysetPlanIsIndexed -> KEPT. EXPLAIN sargability is Dolt
    planner residue, outside the observable contract, and cannot move.

internal/storage/embeddeddolt/keyset_search_test.go (file deleted)
  TestSearchIssuesKeysetEmbedded — the same two assertions as the dolt
  twin above, same owners, reached on this backend through RunAll.

internal/storage/dolt/search_max_rows_test.go (file deleted)
  MaxRows_NotExceeded (rows under cap -> all rows, nil)
    -> MaxRowsAnswersTheTypedRefusal/UnderTheCapIsAnOrdinaryResult
  Exceeded/FlagSource (errors.As, Found>3, Cap=3, Source "--max-rows")
    -> .../OverTheCapAnswersTheTypedRefusal/cap3
  Exceeded/EnvSource (Cap=2, Source "BEADS_MAX_ROWS")
    -> .../OverTheCapAnswersTheTypedRefusal/cap2
  MaxRows_Zero_NoCap -> .../ZeroDisablesTheCap
  WithLimit/LimitUnderCap_NoError
    -> .../ALimitAtOrUnderTheCapCannotFireIt/limit3_cap100
  WithLimit/LimitEqualsCap_NoError
    -> .../ALimitAtOrUnderTheCapCannotFireIt/limit3_cap3
  WithLimit/LimitOverCap_FiresCap -> .../ALimitOverTheCapStillFiresIt
  WithLimit/OnlyCap_FiresOnOverage
    -> .../OverTheCapAnswersTheTypedRefusal/cap4

internal/storage/embeddeddolt/search_max_rows_test.go (file deleted)
  The same eight assertions as its dolt twin, same owners, reached on this
  backend through RunAll.

The shared cases are stronger than what they retire on three counts: the
retired cap tests asserted only len(results), where the new legs assert the
whole id set; the at-the-cap boundary (cap == matching rows) was never
covered; and the AfterID:"" group start and filter composition had no
backend-local copy at all.

Co-Authored-By: Claude Fable <noreply@anthropic.com>
2026-08-07 20:32:19 +00:00
..
ci-capability-selector.sh ci: shadow PR Risk capability ownership (bd-8yjq8.1) (#5324) 2026-08-03 20:06:16 -07:00
ci-embedded-tier.sh Tier embedded Dolt CI for PRs (bd-0gz) (#3459) 2026-04-24 07:53:23 -07:00
ci-gate.sh Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
docs-render-check.sh chore: purge deleted docs-pipeline references from release tooling, CI, and repo plumbing 2026-07-12 11:07:26 -07:00
embedded-cmd-test-shards.txt Rebalance embedded cmd CI shards (bd-8zg) (#3499) 2026-04-25 17:58:51 -07:00
embedded-storage-test-shard.sh ci: shard Embedded Dolt Storage into 5 manifest-driven shards (#5117) 2026-07-28 22:16:48 -07:00
embedded-storage-test-shards.txt test(storage): demote the duplicated keyset and max-rows backend tests 2026-08-07 20:32:19 +00:00
embedded-test-shard.sh Rebalance embedded cmd CI shards (bd-8zg) (#3499) 2026-04-25 17:58:51 -07:00
proxied-cmd-test-shards.txt fix(prime): route proxied memory read through the server plane (bd-mm8wf) (#5367) 2026-08-05 12:12:03 -07:00
proxied-test-shard.sh /.github/{scripts,workflows}: shard it 2026-07-15 18:19:36 -07:00