'./scripts/test.sh' with no flags could never produce a green full-suite receipt: cmd/bd tripped the 3m per-package go test deadline (panic 'test timed out', one test running at 0s — the package alarm, not a hang). Measured on the reporting machine class: ~494s of serial test time across ~770 tests, dominated by (1) a dozen test helpers that each 'go build' the full cgo bd binary inside the test run and (2) subprocess tests spawning bd + embedded Dolt per invocation. Three-part fix, no naked timeout bump: - scripts/test.sh now prebuilds bd once and exports BEADS_TEST_BD_BINARY — the same fast path CI has used all along (main.yml prebuilt artifact); the local runner just never got it. Binary lands in the test-env root so cleanup is inherited; caller-supplied values win; skipped when the requested packages can't include cmd/bd. - Every in-test builder now honors BEADS_TEST_BD_BINARY (six sites built unconditionally before). The repo-root ./bd reuse in buildBDForInitTests and cli_fast_test is REMOVED: it silently ran subprocess tests against whatever stale binary sat in the checkout root — a two-day-old one produced phantom TestCreateDepsAtomicity failures during this investigation. Tests must exercise the checkout's source or an explicitly supplied binary, never an incidental artifact. - Default TIMEOUT raised 3m -> 10m with the measurement recorded in the comment: it is cmd/bd's floor, not an arbitrary pick. Claude-Session: https://claude.ai/code/session_01EF8QbCbF6JnTuoCKvu9xiG Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
//go:build scripttests
|
|
// +build scripttests
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"rsc.io/script"
|
|
"rsc.io/script/scripttest"
|
|
)
|
|
|
|
func TestScripts(t *testing.T) {
|
|
// Skip on Windows - test scripts use sh -c which requires Unix shell
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("scripttest uses Unix shell commands (sh -c), skipping on Windows")
|
|
}
|
|
|
|
// Locate or build the bd binary. Prebuilt fast path (scripts/test.sh and
|
|
// CI export BEADS_TEST_BD_BINARY, wy-4mtr0); the scripts invoke plain
|
|
// `bd` via `sh -c`, so the prebuilt is only usable when its basename is
|
|
// exactly the expected executable name.
|
|
exeName := "bd"
|
|
binDir := t.TempDir()
|
|
exe := filepath.Join(binDir, exeName)
|
|
if prebuilt, err := findPrebuiltBDBinary(); err == nil && prebuilt != "" && filepath.Base(prebuilt) == exeName {
|
|
exe = prebuilt
|
|
binDir = filepath.Dir(prebuilt)
|
|
} else if err := exec.Command("go", "build", "-tags", "gms_pure_go", "-o", exe, ".").Run(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create minimal engine with default commands plus bd
|
|
timeout := 2 * time.Second
|
|
engine := script.NewEngine()
|
|
engine.Cmds["bd"] = script.Program(exe, nil, timeout)
|
|
|
|
// Add binDir to PATH so 'sh -c bd ...' works in test scripts
|
|
currentPath := os.Getenv("PATH")
|
|
env := []string{"PATH=" + binDir + ":" + currentPath}
|
|
|
|
// Run all tests
|
|
scripttest.Test(t, context.Background(), engine, env, "testdata/*.txt")
|
|
}
|