* feat(http): bd blocked over bd serve (blocked.list) through issueops.BlockedLister
`bd blocked` refused against an HTTP workspace: it called the legacy
GetBlockedIssues, which the HTTP backend stubs as unsupported. It now runs
one role on every route, and bd serve publishes that role.
- Role: issueops.BlockedLister.ListBlocked(BlockedRequest{ParentID, Labels,
LabelsAny, ExcludeLabels}) -> BlockedResult{Items}. One body,
internal/storage/issueops.ExecuteListBlockedInTx over the unchanged
GetBlockedIssuesInTx; labels normalized in the role (BlockedFilter);
Items never nil and in a total order (priority, created_at desc, id).
- Legs: DoltStore (read tx), EmbeddedDoltStore (read conn), uow (read unit
of work through the use case's GetBlockedIssues, so the
external-dependency uow decorator applies). Census: storage.DoltStorage
gains BlockedLister(); HookFiringStore passes it through (a read),
telemetry wraps it, uow.notifyingProvider, externaldeps.uowProvider and
httpapi.timedProvider build it.
- externaldeps.Store.BlockedLister is built over its own GetBlockedIssues,
so local `bd blocked` output is unchanged. Over a remote store it takes
the server's listing when the server advertises
policy.external_dependencies, else decorates the server's listing here
through EdgeReader and BatchGetter (decorateBlocked, factored out of
GetBlockedIssues).
- Wire: GET /v0/beads/blocked (listBlockedIssues; parent, label,
label_any, exclude_label) answering BlockedPage {items, has_more} with
the new x-go-type-pinned BlockedIssue schema, behind the new
blocked.list token. apigen and the wire-shape golden regenerated; the
golden diff is additive only, so wire_revision stays 2.
Config.BlockedLister is a required role, wired in bd serve.
- Client: httpclient.Store.BlockedLister dials through Store.dispatch, so
an older server is refused BEFORE the dial with *wire.CapabilityError
naming blocked.list. The legacy Store.GetBlockedIssues rides the role
(page and row cap applied to its answer) and leaves the unsupported
shell. Divergence ledger row F-blocked retired.
- CLI: `bd blocked` takes BlockedLister() from the store on the direct
routes and from the provider's BlockedListerSource on the proxied route;
runBlockedProxiedServer is deleted. --json output is the same rows in
the same order, [] when empty.
Tests: backend/conformance RunBlockedLister (10 cases: direct blocker,
child attributed to its blocked parent, closed blocker, wisp plane, pinned
status, parent filter, label filters with normalization, order, empty
slice, request not mutated) on dolt, embedded, uow and the served HTTP
client; httpapi handler tests (mapping, unknown/repeated params,
projection, capability); httpclient stub tests (pre-dial refusal naming
the token, encoding, projection, legacy door paging); skew and vocabulary
counts; TestE2E_BlockedOverHTTP (served `bd blocked --json` equals the
local command's after mapping ids and timestamps, member order included,
external blocker named, older-server refusal with no dial); corpus
gc-blocked re-marked and gc-blocked-parent added, both pending until the
reference server advertises blocked.list.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(blocked): pin server-side external decoration, refuse has_more, serve the legacy door over http
Review fixes for the blocked.list slice.
- Server-side external decoration is now pinned on the compositions bd
serve answers from. TestWrapUOWProviderBlockedListerNamesExternalBlockers
lists through the wrapped unit-of-work provider's own BlockedLister
accessor (the bd serve provider path) and requires an external-only row
and a mixed row to carry their external: refs; building that lister over
the inner provider fails it. TestServedBlockedListerCarriesExternalRefs-
WhenTheServerEnforces serves the store-shaped composition
(externaldeps.Store.BlockedLister, policy advertised) and requires the
operation's own answer, through the undecorated client role, to carry the
refs, and the client's decorated chain to return it unchanged; serving
the inner store's lister fails it.
- The client refuses an answer reporting has_more with the new typed
httpclient.TruncatedListingError instead of returning a short listing:
the operation has no cursor, and a caller reads a missing row as
unblocked. The legacy door inherits it.
- externaldeps.Store.GetBlockedIssues over an http store reads the extra
sources through the served roles (EdgeReader, BatchGetter) instead of the
raw GetIssuesByIDs / GetDependencyRecordsForIssues the http backend
refuses, and the decoration skips the source read when there is nothing
to load. The legacy door on the CLI chain (bd mol stale, the wisp
commands) now answers over http in both policy modes;
TestServedLegacyGetBlockedIssuesThroughTheDecorator pins it, paging
included. bd ready --explain still refuses on its other raw reads; the
CHANGELOG says so.
- Docs: the spec and the retired F-blocked ledger row state that the
listing is unpaged, bounded by the client's 32 MiB response limit
(refused, never read in part), and that has_more is refused.
- Contract: new cases for waits-for and conditional-blocks blockers, no
type exclusions (gate, epic), and a stale flag with no nameable blocker
(on the legs that can write the column: dolt, embedded; skipped
elsewhere with the reason). Order seeds explicit created_at values with
five rows tied on priority and created_at, two of them wisps, so only the
id tiebreak orders them; dropping the tiebreak now fails every run.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* feat(blocked): bd blocked --flags, the blocked flag per id from stdin
`bd blocked --flags [--json]` reads ids from stdin, one per line (blank
lines and repeats ignored), and prints the blocked flag bd holds for each:
with --json, [{"id","is_blocked"}] in the order the ids were first given,
omitting an id that names no row on either plane, [] for no input. It is
the readiness column a consumer otherwise had to read with `bd sql`, so no
such consumer needs a local-only command.
It is the FLAG, not the listing: `bd blocked` narrows the stored flag to
rows it can name a blocker for, and --flags does not, so a row whose flag
is set with no nameable blocker reads true here and is absent from the
listing. Where the external-dependency policy applies, an unsatisfied
external: blocker sets the flag, as it keeps the row out of `bd ready`.
One library entry on every route: issueops.BlockedFlags over the route's
BlockingAnnotator (the store's accessor on dolt, embedded and HTTP, the
provider's on the proxied route). Over HTTP that is listBlockingAnnotations
with is_blocked behind dependencies.blocking.isBlocked; a server without
that token is refused before the dial, naming it. No wire change. The
listing's filter flags are refused with --flags rather than ignored.
Tests: TestE2E_BlockedFlagsOverHTTP (served JSON equals the local command's
after mapping ids to titles, unknown id omitted, repeat collapsed, [] on
empty stdin, filters refused; a stale-flagged row with no blocker reads
true and is absent from `bd blocked --json`, which fails if --flags is
derived from the listing; an older server's handshake refused naming the
token with no dial); TestProxiedServerBlocked/flags_reads_ids_from_stdin on
the proxied route; corpus gc-blocked-flags, pending until the reference
server advertises the token. CHANGELOG entry.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* feat(blocked): bd blocked --flags --raw, the stored is_blocked column
`bd blocked --flags --raw [--json]` answers the stored is_blocked column
for each id read from stdin, exactly what reading is_blocked from the issues
and wisps tables returns, without the external-dependency policy: a row
blocked only by an unsatisfied external: ref reads false (the policy-aware
--flags reads true), and a stale flag reads true either way. Same output
shape as --flags. This lets a consumer move off a `bd sql` read of the
column with no change in what it reads. The default --flags is unchanged.
The role is taken from beneath every decorator: storage.UnwrapStore on the
direct routes, uow.UnwrapProvider on the proxied route. Over HTTP the
innermost store is the http client, whose annotation read is the server's
answer: against a server that does not advertise
policy.external_dependencies that answer is the column, and --raw is
served. A server that advertises it decorates the flag it answers, the v0
wire has no member asking it for the column, and the decorated flag cannot
be turned back into the column client-side, so --raw against such a server
is refused before the annotation read, naming the token, rather than
answered with the decorated flag. --raw without --flags is refused.
Tests: TestE2E_BlockedFlagsOverHTTP/raw_is_the_stored_column (served --raw
equals local --raw; the externally-blocked-only row reads true with --flags
and false with --raw on both; locally blocked rows agree; a stale-flagged
row reads true in both modes; --raw without --flags exits 1; a server
advertising the policy refuses --raw with no annotation request);
TestProxiedServerBlocked/flags_raw_is_the_stored_column; corpus
gc-blocked-flags-raw (pending until the reference server advertises
dependencies.blocking.isBlocked). Routing --raw through the decorated
annotator fails the e2e. CHANGELOG entry.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* docs(changelog): bd blocked --flags --raw is for the local and proxied routes
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(blocked): give the e2e gate-kid its own priority; document --flags answers closed ids
TestE2E_BlockedOverHTTP seeded gate-parent and gate-kid at one priority, so
when both landed in the same second their order fell to the generated ids,
which differ between the local and the served workspace: the comparison
failed intermittently. gate-kid now has its own priority. Ten runs on the
embedded lane pass.
bd blocked --flags answers a closed id too, with its stored flag; a SQL read
of the column filtered on status <> 'closed' leaves it out. Said in the
command's doc and the CHANGELOG.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(blocked): apply label filters to external-only blocked rows
The external-dependency policy appends a row blocked only by an
unsatisfied external: ref after the label query has run, so --label,
--label-any and --exclude-label never judged it: bd blocked and
GET /v0/beads/blocked listed it whatever its labels, on every route.
Both decorators now filter those rows by the request's labels. The uow
decorator reads them through GetMany, chunked at MaxGetManyIDs, so their
labels are hydrated; GetIssuesByIDs left them empty, which also printed
them unlabelled on the proxied route.
Review fixes (adopt-pr apply-fixes, iteration 1):
- major #1: label filters on external-only rows in the store and uow
decorators, with absence-asserting arms in the unit, served httpclient
(server- and client-enforced policy), e2e and proxied tiers; the spec
and the role doc say such rows are narrowed like every other row.
- minor #2: the policy.external_dependencies token prose names the
blocked listing (spec, routes.go, regenerated types.gen.go).
- minor #6: SERVE_RUNBOOK and the allowUnlimited comment record the
blocked listing's unbounded whole-set answer and why.
- minor #10: BlockedLister telemetry-outermost and typed-unsupported pins
beside the ReadyCounter pair, plus the externaldeps wrap pin.
- nit #9: F-blocked names --flags --raw's refusal against a server that
applies the policy (ledger.go and the regenerated ledger doc).
- nit #11: the remote BlockedLister no longer builds a local lister it
then discards.
Review fixes (adopt-pr apply-fixes, iteration 2; the review approved at
940 with one minor and two nits, none gating):
- minor (the --flags refusal list was unpinned): the new
TestBlockedFlagsRefusesEveryListingFilter pins blockedFlagFilterFlags
to the flags blockedCmd registers, in both directions. Every
registered flag except --flags and --raw must be refused, and every
entry must name a registered flag. The test walks Flags() rather than
LocalFlags(), so it does not merge the root's persistent flags into
blockedCmd, and it skips inherited root flags and cobra's --help.
Mutants:
- four fail it: a new filter flag left off the list, a dropped
entry, a misspelled entry, and --raw added to the list;
- a simulated earlier in-process run (merged root flags plus --help)
stays green, and fails once either skip is removed.
- nit (the remote branch's span): the remote BlockedLister comment now
says why that lister is not wrapped again. The inner lister already
carries telemetry's span, so wrapping would nest a second span of the
same name. The comment also says what runs outside that span.
- nit (duplicated order comparator): left as is. finishBlockedIssues
predates this PR, so merging the two sorts would refactor existing
code with no review pass left after this one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Gas City Adopt-PR
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
910 lines
34 KiB
Go
910 lines
34 KiB
Go
package beads_test
|
|
|
|
import (
|
|
"errors"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads"
|
|
"github.com/steveyegge/beads/internal/storage"
|
|
"github.com/steveyegge/beads/internal/storage/dolt"
|
|
"github.com/steveyegge/beads/internal/telemetry"
|
|
)
|
|
|
|
// TestReadyClaimerLayersHooksOutsideTelemetry pins the decorator order the
|
|
// claim accessor produces against the order cmd/bd assembles the chain in
|
|
// (storage_chain.go: telemetry first, hooks outermost), the same property
|
|
// TestIssueLifecycleLayersHooksOutsideTelemetry pins for the write role. A
|
|
// blind delegation at either decorator would still satisfy Storage and would
|
|
// still compile.
|
|
func TestReadyClaimerLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
claimer, err := storage.NewHookFiringStore(instrumented, nil).ReadyClaimer()
|
|
if err != nil {
|
|
t.Fatalf("ReadyClaimer() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(claimer).String(); got != "*storage.hookReadyClaimer" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
// TestBatchCloserLayersHooksOutsideTelemetry is the same pin for the
|
|
// close-many role.
|
|
func TestBatchCloserLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
closer, err := storage.NewHookFiringStore(instrumented, nil).BatchCloser()
|
|
if err != nil {
|
|
t.Fatalf("BatchCloser() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(closer).String(); got != "*storage.hookBatchCloser" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
// TestReadyClaimerExposesTypedUnsupportedError pins the typed error a backend
|
|
// returns when it cannot serve the role, reachable through the public alias
|
|
// without importing internal/storage.
|
|
func TestReadyClaimerExposesTypedUnsupportedError(t *testing.T) {
|
|
claimer, err := (*dolt.DoltStore)(nil).ReadyClaimer()
|
|
if claimer != nil {
|
|
t.Fatalf("ReadyClaimer() claimer = %T, want nil", claimer)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("ReadyClaimer() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestBatchCloserExposesTypedUnsupportedError(t *testing.T) {
|
|
closer, err := (*dolt.DoltStore)(nil).BatchCloser()
|
|
if closer != nil {
|
|
t.Fatalf("BatchCloser() closer = %T, want nil", closer)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BatchCloser() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestBatchCreatorLayersHooksOutsideTelemetry is the same pin for the
|
|
// create-many role.
|
|
func TestBatchCreatorLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
creator, err := storage.NewHookFiringStore(instrumented, nil).BatchCreator()
|
|
if err != nil {
|
|
t.Fatalf("BatchCreator() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(creator).String(); got != "*storage.hookBatchCreator" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestBatchCreatorExposesTypedUnsupportedError(t *testing.T) {
|
|
creator, err := (*dolt.DoltStore)(nil).BatchCreator()
|
|
if creator != nil {
|
|
t.Fatalf("BatchCreator() creator = %T, want nil", creator)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BatchCreator() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestDependencyEditorLayersHooksOutsideTelemetry is the same decorator-order
|
|
// pin for the edge-write role.
|
|
func TestDependencyEditorLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
editor, err := storage.NewHookFiringStore(instrumented, nil).DependencyEditor()
|
|
if err != nil {
|
|
t.Fatalf("DependencyEditor() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(editor).String(); got != "*storage.hookDependencyEditor" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
// TestBatchApplierLayersHooksOutsideTelemetry is the same pin for the
|
|
// apply-many role, and it has more to lose than its siblings: this decorator is
|
|
// the one place four hook vocabularies fire from one call, so an accessor that
|
|
// stopped wrapping would silently drop on_create, on_update AND on_close for
|
|
// every plan a caller applies.
|
|
func TestBatchApplierLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
applier, err := storage.NewHookFiringStore(instrumented, nil).BatchApplier()
|
|
if err != nil {
|
|
t.Fatalf("BatchApplier() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(applier).String(); got != "*storage.hookBatchApplier" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestBatchApplierExposesTypedUnsupportedError(t *testing.T) {
|
|
applier, err := (*dolt.DoltStore)(nil).BatchApplier()
|
|
if applier != nil {
|
|
t.Fatalf("BatchApplier() applier = %T, want nil", applier)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BatchApplier() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestCommenterLayersHooksOutsideTelemetry is the same pin for the comment
|
|
// role.
|
|
func TestCommenterLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
commenter, err := storage.NewHookFiringStore(instrumented, nil).Commenter()
|
|
if err != nil {
|
|
t.Fatalf("Commenter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(commenter).String(); got != "*storage.hookCommenter" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
// TestMetadataCASLayersHooksOutsideTelemetry is the same pin for the
|
|
// conditional metadata write, and it is the answer the OTHER destructive-ish
|
|
// write roles do not give: a swap that lands names a bead and moves a column,
|
|
// which is on_update — a hook the vocabulary publishes and a row a script can
|
|
// still read back — so this decorator wraps rather than recursing the way
|
|
// Sweeper and Deleter do.
|
|
func TestMetadataCASLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
cas, err := storage.NewHookFiringStore(instrumented, nil).MetadataCAS()
|
|
if err != nil {
|
|
t.Fatalf("MetadataCAS() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(cas).String(); got != "*storage.hookMetadataCAS" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestMetadataCASExposesTypedUnsupportedError(t *testing.T) {
|
|
cas, err := (*dolt.DoltStore)(nil).MetadataCAS()
|
|
if cas != nil {
|
|
t.Fatalf("MetadataCAS() surface = %T, want nil", cas)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("MetadataCAS() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestReleaserLayersHooksOutsideTelemetry is the same pin for the claim
|
|
// release. It gives the same answer the metadata swap does and for the same
|
|
// reason: a release moves assignee and status, which is on_update — a hook the
|
|
// vocabulary publishes and a row a script can still read back — so this
|
|
// decorator wraps rather than recursing the way Sweeper and Deleter do.
|
|
func TestReleaserLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
releaser, err := storage.NewHookFiringStore(instrumented, nil).Releaser()
|
|
if err != nil {
|
|
t.Fatalf("Releaser() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(releaser).String(); got != "*storage.hookReleaser" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestReleaserExposesTypedUnsupportedError(t *testing.T) {
|
|
releaser, err := (*dolt.DoltStore)(nil).Releaser()
|
|
if releaser != nil {
|
|
t.Fatalf("Releaser() surface = %T, want nil", releaser)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Releaser() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestLeaseReclaimerLayersHooksOutsideTelemetry is the same pin for the
|
|
// lease-sweep role. It gives the same answer the release does and for the
|
|
// same reason: a reclaim moves assignee and status per reverted row, which
|
|
// is on_update — a hook the vocabulary publishes and a row a script can
|
|
// still read back — so this decorator wraps rather than recursing the way
|
|
// Sweeper and Deleter do.
|
|
func TestLeaseReclaimerLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
reclaimer, err := storage.NewHookFiringStore(instrumented, nil).LeaseReclaimer()
|
|
if err != nil {
|
|
t.Fatalf("LeaseReclaimer() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(reclaimer).String(); got != "*storage.hookLeaseReclaimer" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestLeaseReclaimerExposesTypedUnsupportedError(t *testing.T) {
|
|
reclaimer, err := (*dolt.DoltStore)(nil).LeaseReclaimer()
|
|
if reclaimer != nil {
|
|
t.Fatalf("LeaseReclaimer() reclaimer = %T, want nil", reclaimer)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("LeaseReclaimer() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestIssueRelationsKeepsTelemetryOutermost is the READ role's version of the
|
|
// pin, and it is deliberately the other answer: the hook decorator adds no
|
|
// layer to a read, so the outermost thing a caller gets is the instrumented
|
|
// surface. A wrapper appearing here would mean a hook layer landed on a path
|
|
// with nothing to fire.
|
|
func TestIssueRelationsKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
relations, err := storage.NewHookFiringStore(instrumented, nil).IssueRelations()
|
|
if err != nil {
|
|
t.Fatalf("IssueRelations() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(relations).String(); got != "*telemetry.instrumentedIssueRelations" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestDependencyEditorExposesTypedUnsupportedError(t *testing.T) {
|
|
editor, err := (*dolt.DoltStore)(nil).DependencyEditor()
|
|
if editor != nil {
|
|
t.Fatalf("DependencyEditor() editor = %T, want nil", editor)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("DependencyEditor() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestCommenterExposesTypedUnsupportedError(t *testing.T) {
|
|
commenter, err := (*dolt.DoltStore)(nil).Commenter()
|
|
if commenter != nil {
|
|
t.Fatalf("Commenter() commenter = %T, want nil", commenter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Commenter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestIssueRelationsExposesTypedUnsupportedError(t *testing.T) {
|
|
relations, err := (*dolt.DoltStore)(nil).IssueRelations()
|
|
if relations != nil {
|
|
t.Fatalf("IssueRelations() relations = %T, want nil", relations)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("IssueRelations() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestCounterKeepsTelemetryOutermost is the READ answer for the reason
|
|
// TestIssueRelationsKeepsTelemetryOutermost gives: counting fires no completion
|
|
// hooks, so the hook decorator adds no layer.
|
|
func TestCounterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
counter, err := storage.NewHookFiringStore(instrumented, nil).Counter()
|
|
if err != nil {
|
|
t.Fatalf("Counter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(counter).String(); got != "*telemetry.instrumentedCounter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
// TestWorkspaceConfigKeepsTelemetryOutermost is the first place in this file
|
|
// where the read answer is given for a role that WRITES.
|
|
//
|
|
// The hook decorator's vocabulary is on_create / on_update / on_close and every
|
|
// one of them hands a hook script an ISSUE. A settings write changes the
|
|
// workspace rather than a bead, so there is nothing to hand one — and the
|
|
// legacy config verbs this decorator inherits fire nothing either.
|
|
func TestWorkspaceConfigKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
settings, err := storage.NewHookFiringStore(instrumented, nil).WorkspaceConfig()
|
|
if err != nil {
|
|
t.Fatalf("WorkspaceConfig() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(settings).String(); got != "*telemetry.instrumentedWorkspaceConfig" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
// TestMemoriesKeepsTelemetryOutermost is the settings role's answer for the
|
|
// second plane that rides in the config table.
|
|
//
|
|
// Remember and Forget WRITE, so the reflex is to expect the hook wrapper here.
|
|
// The hook vocabulary is what decides it: on_create, on_update and on_close each
|
|
// hand a script an ISSUE, and a remembered insight is not one. There is no
|
|
// on_remember to fire and inventing one is a hook proposal, not a role commit.
|
|
// See internal/storage/hook_memories.go.
|
|
func TestMemoriesKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
memories, err := storage.NewHookFiringStore(instrumented, nil).Memories()
|
|
if err != nil {
|
|
t.Fatalf("Memories() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(memories).String(); got != "*telemetry.instrumentedMemories" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
// TestMemoriesExposesTypedUnsupportedError pins the typed refusal a backend
|
|
// gives when it cannot serve the memory role, reachable through the public
|
|
// alias without importing internal/storage.
|
|
func TestMemoriesExposesTypedUnsupportedError(t *testing.T) {
|
|
memories, err := (*dolt.DoltStore)(nil).Memories()
|
|
if memories != nil {
|
|
t.Fatalf("Memories() memories = %T, want nil", memories)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Memories() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestVersionReconcilerKeepsTelemetryOutermost is the settings role's reason
|
|
// plus one this role has on its own: it runs from PersistentPreRun on every
|
|
// startup, so a hook wrapper here would run a user's script before every
|
|
// command — including the ones that go on to fail on their own arguments —
|
|
// with no bead to hand it.
|
|
func TestVersionReconcilerKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
reconciler, err := storage.NewHookFiringStore(instrumented, nil).VersionReconciler()
|
|
if err != nil {
|
|
t.Fatalf("VersionReconciler() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(reconciler).String(); got != "*telemetry.instrumentedVersionReconciler" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
// TestBootstrapperKeepsTelemetryOutermost has a reason that is neither the
|
|
// settings role's nor the version marker's. A bootstrap writes, and loudly —
|
|
// it is what turns a database into a workspace — but this decorator's hook
|
|
// vocabulary is issue-shaped and a bootstrap names no issue; and on a workspace
|
|
// this new, `bd init` has not installed .beads/hooks/ yet, so a hook fired here
|
|
// would run whatever the previous project in that directory left behind. See
|
|
// internal/storage/hook_bootstrapper.go.
|
|
func TestBootstrapperKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
bootstrapper, err := storage.NewHookFiringStore(instrumented, nil).Bootstrapper()
|
|
if err != nil {
|
|
t.Fatalf("Bootstrapper() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(bootstrapper).String(); got != "*telemetry.instrumentedBootstrapper" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
// TestInitVerifierKeepsTelemetryOutermost is the ordinary read-role pin: reads
|
|
// fire no hooks, so the hook decorator recurses and the telemetry wrapper is
|
|
// what a caller holds.
|
|
func TestInitVerifierKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
verifier, err := storage.NewHookFiringStore(instrumented, nil).InitVerifier()
|
|
if err != nil {
|
|
t.Fatalf("InitVerifier() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(verifier).String(); got != "*telemetry.instrumentedInitVerifier" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestBootstrapperExposesTypedUnsupportedError(t *testing.T) {
|
|
bootstrapper, err := (*dolt.DoltStore)(nil).Bootstrapper()
|
|
if bootstrapper != nil {
|
|
t.Fatalf("Bootstrapper() bootstrapper = %T, want nil", bootstrapper)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Bootstrapper() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestInitVerifierExposesTypedUnsupportedError(t *testing.T) {
|
|
verifier, err := (*dolt.DoltStore)(nil).InitVerifier()
|
|
if verifier != nil {
|
|
t.Fatalf("InitVerifier() verifier = %T, want nil", verifier)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("InitVerifier() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestVersionReconcilerExposesTypedUnsupportedError(t *testing.T) {
|
|
reconciler, err := (*dolt.DoltStore)(nil).VersionReconciler()
|
|
if reconciler != nil {
|
|
t.Fatalf("VersionReconciler() reconciler = %T, want nil", reconciler)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("VersionReconciler() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestWorkspaceConfigExposesTypedUnsupportedError(t *testing.T) {
|
|
settings, err := (*dolt.DoltStore)(nil).WorkspaceConfig()
|
|
if settings != nil {
|
|
t.Fatalf("WorkspaceConfig() settings = %T, want nil", settings)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("WorkspaceConfig() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestStatsReporterKeepsTelemetryOutermost is the READ answer again: reporting
|
|
// fires no completion hooks, so the hook decorator recurses.
|
|
func TestStatsReporterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
reporter, err := storage.NewHookFiringStore(instrumented, nil).StatsReporter()
|
|
if err != nil {
|
|
t.Fatalf("StatsReporter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(reporter).String(); got != "*telemetry.instrumentedStatsReporter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestStatsReporterExposesTypedUnsupportedError(t *testing.T) {
|
|
reporter, err := (*dolt.DoltStore)(nil).StatsReporter()
|
|
if reporter != nil {
|
|
t.Fatalf("StatsReporter() reporter = %T, want nil", reporter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("StatsReporter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestCycleDetectorKeepsTelemetryOutermost is the READ answer again: a cycle
|
|
// sweep fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestCycleDetectorKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
detector, err := storage.NewHookFiringStore(instrumented, nil).CycleDetector()
|
|
if err != nil {
|
|
t.Fatalf("CycleDetector() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(detector).String(); got != "*telemetry.instrumentedCycleDetector" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestCycleDetectorExposesTypedUnsupportedError(t *testing.T) {
|
|
detector, err := (*dolt.DoltStore)(nil).CycleDetector()
|
|
if detector != nil {
|
|
t.Fatalf("CycleDetector() detector = %T, want nil", detector)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("CycleDetector() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestEdgeReaderKeepsTelemetryOutermost is the READ answer again: reading edges
|
|
// fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestEdgeReaderKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
edges, err := storage.NewHookFiringStore(instrumented, nil).EdgeReader()
|
|
if err != nil {
|
|
t.Fatalf("EdgeReader() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(edges).String(); got != "*telemetry.instrumentedEdgeReader" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestEdgeReaderExposesTypedUnsupportedError(t *testing.T) {
|
|
edges, err := (*dolt.DoltStore)(nil).EdgeReader()
|
|
if edges != nil {
|
|
t.Fatalf("EdgeReader() reader = %T, want nil", edges)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("EdgeReader() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestBlockingAnnotatorKeepsTelemetryOutermost is the READ answer again:
|
|
// annotating a page fires no completion hooks, so the hook decorator adds no
|
|
// layer.
|
|
func TestBlockingAnnotatorKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
annotator, err := storage.NewHookFiringStore(instrumented, nil).BlockingAnnotator()
|
|
if err != nil {
|
|
t.Fatalf("BlockingAnnotator() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(annotator).String(); got != "*telemetry.instrumentedBlockingAnnotator" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestBlockingAnnotatorExposesTypedUnsupportedError(t *testing.T) {
|
|
annotator, err := (*dolt.DoltStore)(nil).BlockingAnnotator()
|
|
if annotator != nil {
|
|
t.Fatalf("BlockingAnnotator() annotator = %T, want nil", annotator)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BlockingAnnotator() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestTreeWalkerKeepsTelemetryOutermost is the READ answer again: a tree walk
|
|
// fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestTreeWalkerKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
walker, err := storage.NewHookFiringStore(instrumented, nil).TreeWalker()
|
|
if err != nil {
|
|
t.Fatalf("TreeWalker() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(walker).String(); got != "*telemetry.instrumentedTreeWalker" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestTreeWalkerExposesTypedUnsupportedError(t *testing.T) {
|
|
walker, err := (*dolt.DoltStore)(nil).TreeWalker()
|
|
if walker != nil {
|
|
t.Fatalf("TreeWalker() walker = %T, want nil", walker)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("TreeWalker() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestGraphCounterKeepsTelemetryOutermost is the READ answer again: counting
|
|
// edges fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestGraphCounterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
counter, err := storage.NewHookFiringStore(instrumented, nil).GraphCounter()
|
|
if err != nil {
|
|
t.Fatalf("GraphCounter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(counter).String(); got != "*telemetry.instrumentedGraphCounter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestGraphCounterExposesTypedUnsupportedError(t *testing.T) {
|
|
counter, err := (*dolt.DoltStore)(nil).GraphCounter()
|
|
if counter != nil {
|
|
t.Fatalf("GraphCounter() counter = %T, want nil", counter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("GraphCounter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestBatchGetterKeepsTelemetryOutermost is the READ answer again: reading
|
|
// issues by id fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestBatchGetterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
getter, err := storage.NewHookFiringStore(instrumented, nil).BatchGetter()
|
|
if err != nil {
|
|
t.Fatalf("BatchGetter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(getter).String(); got != "*telemetry.instrumentedBatchGetter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestBatchGetterExposesTypedUnsupportedError(t *testing.T) {
|
|
getter, err := (*dolt.DoltStore)(nil).BatchGetter()
|
|
if getter != nil {
|
|
t.Fatalf("BatchGetter() getter = %T, want nil", getter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BatchGetter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
func TestCounterExposesTypedUnsupportedError(t *testing.T) {
|
|
counter, err := (*dolt.DoltStore)(nil).Counter()
|
|
if counter != nil {
|
|
t.Fatalf("Counter() counter = %T, want nil", counter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Counter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestReadyCounterKeepsTelemetryOutermost is the READ answer again: sizing the
|
|
// ready set fires no completion hooks, so the hook decorator adds no layer.
|
|
func TestReadyCounterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
counter, err := storage.NewHookFiringStore(instrumented, nil).ReadyCounter()
|
|
if err != nil {
|
|
t.Fatalf("ReadyCounter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(counter).String(); got != "*telemetry.instrumentedReadyCounter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestReadyCounterExposesTypedUnsupportedError(t *testing.T) {
|
|
counter, err := (*dolt.DoltStore)(nil).ReadyCounter()
|
|
if counter != nil {
|
|
t.Fatalf("ReadyCounter() counter = %T, want nil", counter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("ReadyCounter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestBlockedListerKeepsTelemetryOutermost is the READ answer again: listing
|
|
// the blocked set fires no completion hooks, so the hook decorator adds no
|
|
// layer.
|
|
func TestBlockedListerKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
lister, err := storage.NewHookFiringStore(instrumented, nil).BlockedLister()
|
|
if err != nil {
|
|
t.Fatalf("BlockedLister() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(lister).String(); got != "*telemetry.instrumentedBlockedLister" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestBlockedListerExposesTypedUnsupportedError(t *testing.T) {
|
|
lister, err := (*dolt.DoltStore)(nil).BlockedLister()
|
|
if lister != nil {
|
|
t.Fatalf("BlockedLister() lister = %T, want nil", lister)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("BlockedLister() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestQuerierKeepsTelemetryOutermost is the READ answer again: a query fires no
|
|
// completion hooks, so the hook decorator adds no layer.
|
|
func TestQuerierKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
querier, err := storage.NewHookFiringStore(instrumented, nil).Querier()
|
|
if err != nil {
|
|
t.Fatalf("Querier() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(querier).String(); got != "*telemetry.instrumentedQuerier" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestQuerierExposesTypedUnsupportedError(t *testing.T) {
|
|
querier, err := (*dolt.DoltStore)(nil).Querier()
|
|
if querier != nil {
|
|
t.Fatalf("Querier() querier = %T, want nil", querier)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Querier() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestSweeperKeepsTelemetryOutermost is a WRITE role that answers the way the
|
|
// reads do: there is no on_delete hook to fire
|
|
// (internal/storage/hook_sweeper.go), so the hook decorator adds no layer.
|
|
// Pinning it here is what keeps that a decision rather than a wrapper someone
|
|
// forgot to write.
|
|
func TestSweeperKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
sweeper, err := storage.NewHookFiringStore(instrumented, nil).Sweeper()
|
|
if err != nil {
|
|
t.Fatalf("Sweeper() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(sweeper).String(); got != "*telemetry.instrumentedSweeper" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestSweeperExposesTypedUnsupportedError(t *testing.T) {
|
|
sweeper, err := (*dolt.DoltStore)(nil).Sweeper()
|
|
if sweeper != nil {
|
|
t.Fatalf("Sweeper() sweeper = %T, want nil", sweeper)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Sweeper() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestDeleterKeepsTelemetryOutermost is the second write role to answer the way
|
|
// the reads do: there is no on_delete hook to fire
|
|
// (internal/storage/hook_deleter.go), so the hook decorator adds no layer.
|
|
func TestDeleterKeepsTelemetryOutermost(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
deleter, err := storage.NewHookFiringStore(instrumented, nil).Deleter()
|
|
if err != nil {
|
|
t.Fatalf("Deleter() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(deleter).String(); got != "*telemetry.instrumentedDeleter" {
|
|
t.Fatalf("outer layer = %s, want the telemetry wrapper unwrapped by the hook decorator", got)
|
|
}
|
|
}
|
|
|
|
func TestDeleterExposesTypedUnsupportedError(t *testing.T) {
|
|
deleter, err := (*dolt.DoltStore)(nil).Deleter()
|
|
if deleter != nil {
|
|
t.Fatalf("Deleter() deleter = %T, want nil", deleter)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Deleter() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|
|
|
|
// TestHeartbeaterLayersHooksOutsideTelemetry is the same pin for the lease
|
|
// refresh. It gives the release's answer: a refresh fires nothing, but a
|
|
// re-arm is recorded as a mutation and fires on_update
|
|
// (internal/storage/hook_heartbeater.go), so this decorator wraps rather than
|
|
// recursing the way Sweeper and Deleter do.
|
|
func TestHeartbeaterLayersHooksOutsideTelemetry(t *testing.T) {
|
|
t.Setenv("BD_OTEL_STDOUT", "true")
|
|
instrumented, ok := telemetry.WrapStorage(&dolt.DoltStore{}).(*telemetry.InstrumentedStorage)
|
|
if !ok {
|
|
t.Fatal("WrapStorage() did not create InstrumentedStorage")
|
|
}
|
|
|
|
heartbeater, err := storage.NewHookFiringStore(instrumented, nil).Heartbeater()
|
|
if err != nil {
|
|
t.Fatalf("Heartbeater() error = %v", err)
|
|
}
|
|
if got := reflect.TypeOf(heartbeater).String(); got != "*storage.hookHeartbeater" {
|
|
t.Fatalf("outer layer = %s, want the hook wrapper", got)
|
|
}
|
|
}
|
|
|
|
func TestHeartbeaterExposesTypedUnsupportedError(t *testing.T) {
|
|
heartbeater, err := (*dolt.DoltStore)(nil).Heartbeater()
|
|
if heartbeater != nil {
|
|
t.Fatalf("Heartbeater() heartbeater = %T, want nil", heartbeater)
|
|
}
|
|
var unsupported *beads.ErrUnsupported
|
|
if !errors.As(err, &unsupported) {
|
|
t.Fatalf("Heartbeater() error = %v, want *beads.ErrUnsupported", err)
|
|
}
|
|
}
|