* feat(storage): honor .beads/config.yaml types.custom in server-side validation (#4024)
ResolveCustomTypesInTx previously consulted config.GetCustomTypesFromYAML
only in a narrow error-fallback path: when both the custom_types table AND
the types.custom config-string read had failed. As a result, a project that
declared types.custom in .beads/config.yaml (the version-controlled config
shape that downstream wrappers like gastownhall/gascity expect) could not
create or update beads of those types — server-side schema validation
rejected them because it never saw the YAML entries.
Overlay model (per #4024's proposed behavior):
- Built-in types stay as the enforced floor (handled by IsValidWithCustom).
- Database custom_types are the next layer (operator-/agent-installed types).
- .beads/config.yaml types.custom is the topmost union-add (project-extension
types declared in version-controlled config).
- A bead whose type is in none of the three still fails validation cleanly.
Extracts mergeWithYAMLCustomTypes(dbTypes, yamlGetter) as a pure helper so
the union logic is unit-testable without sql.Tx mocking. The new helper:
- Preserves order: DB types first, YAML-only types appended in declared order.
- Dedupes whitespace-trimmed entries.
- Drops empty/whitespace-only entries.
- Tolerates nil getter and nil dbTypes.
Tests in internal/storage/issueops/config_helpers_test.go:
- TestMergeWithYAMLCustomTypes — 7 table cases: both empty, yaml-only,
db-only, db+disjoint-yaml union, db+overlapping-yaml dedup, yaml
internal-dup dedup, whitespace dropping.
- TestMergeWithYAMLCustomTypes_NilGetter — explicit nil-getter guard.
The pre-existing ResolveCustomTypesInTx error-fallback path is preserved:
when the config-string read errors AND YAML has types, return the YAML
overlay anyway with the original error — so a stable-bd project running
pre-#3691 doesn't lose its types.custom validation just because the
config-string read errored.
Downstream context: this unblocks gastownhall/gascity#2154 (the Gas City
side, which writes types.custom into .beads/config.yaml via
gc-beads-bd.sh's ensure_types_custom_in_yaml). Once this lands and bd
deployments adopt the fixed build, Gas City projects no longer need the
fallback workaround of mirroring types.custom into the database side.
* fix: address PR #4026 review findings (#4024)
Two findings from Copilot review:
1. ResolveCustomTypesInTx returned the YAML overlay alongside a non-nil
error when the in-tx config-string read failed. In-tx callers
(NewBatchContext, UpdateIssueInTx) treat any error as fatal, so the
YAML-fallback path was effectively unreachable on pre-migration /
degraded DBs — defeating the #4024 overlay goal precisely in the
scenario the overlay was meant to cover. Mirror
ResolveCustomStatusesDetailedInTx: when YAML supplies types, return
them with a nil error; otherwise propagate the DB error. Extracted
into customTypesYAMLFallback for unit testing without sql.Tx mocking.
2. getConfigList (the helper backing GetCustomTypesFromYAML /
GetInfraTypesFromYAML / GetCustomStatusesFromYAML) used
viper.GetString + comma-split, which silently ignored the YAML
sequence form named in #4024 (`types: { custom: [step, wisp] }`).
List-form .beads/config.yaml declarations therefore yielded an empty
overlay. Try viper.GetStringSlice first (supports both block-list
and inline-flow syntaxes), keeping the comma-split fallback for the
legacy `types.custom = "step,wisp"` string form.
Tests: TestCustomTypesYAMLFallback covers the fallback decision;
TestGetCustomTypesFromYAML_ListForm and TestGetCustomTypesFromYAML_InlineListForm
pin both YAML sequence syntaxes.
Refs: gastownhall/beads#4024
---------
Co-authored-by: sjarmak <stephanie.jarmak1@gmail.com>