Ten agents over 216 files, one directory-balanced group each, working to a rubric that named what to cut (duplication narration, restatement of the next line, the governing rule echoed in every command file, throat-clearing) and what to keep (traps, invariants, security, tracker ids, behaviour changes, and the "why a naive simplification destroys this assertion" rationale). Net 1,523 lines. Density against this repo's own per-directory norm on main: cmd/bd 33.6% -> 27.3% (main 10.7%) internal/storage 26.1% -> 23.1% (main 14.1%) backend/conformance 34.0% -> 29.6% (main 22.8%) internal/httpapi 30.9% -> 27.8% (main 30.6%, now below) overall 34.7% -> 31.6% Every agent landed at 18-25% rather than the 30% asked for, and every one gave the same reason independently: what remained was on the keep list. Ten separate judgements agreeing is the most useful result here — the prose is dense, but it is mostly load-bearing, and the shortfall is the honest answer rather than a failure to try. TWO REVERTS, both to protect something worth more than the lines. issueops/ is back to its pre-trim state, giving up 610 lines. The conformance contracts cite the leaf docs BY LINE — "pins treewalker.go:52-66" — 155 times. Trimming the cited files silently repointed those at whatever text moved into those numbers, across agent boundaries so no agent could see it. A semantic remapper recovered 141 of them, but 23 needed judgement and several landed on struct fields. The leaf docs are the spec the contracts are written against; they are the one place in this change where dense prose IS the deliverable, and keeping them stable is worth more than the 610 lines. tree_walker_contract.go and version_reconciler_contract.go went back for the same reason: an agent had deleted a paragraph containing a citation, so positional restoration could not align them. After the reverts, exactly 5 citations point into a still-trimmed file and 2 of those are weak — both in cmd/bd/config_guard_test.go, which this series never touched and whose citations were already wrong on main (init.go:361 pointed at a closing brace; the guard it names is at init.go:1499). VERIFICATION. A guard strips every comment and all whitespace from each of the 193 modified files at HEAD and in the worktree and requires the two to be byte-identical, so a code change cannot hide in a comment diff. It handles `//` inside string and raw-string literals, and was tested against a deliberate code change before being trusted. gofmt clean, go build, go vet, golangci-lint 0 issues, and the two AST-based tests that PARSE trimmed files — the timed provider binding pin over claim.go and the serve database-source gate over serve.go — both pass. One real defect found while trimming: checkDatabaseSource's doc block ran into `// sourceRoles is ...` with no blank line, so godoc attached thirty-one lines of the wrong prose to func sourceRoles and left checkDatabaseSource undocumented. Fixed by separating them.
78 lines
2.6 KiB
Go
78 lines
2.6 KiB
Go
package workapi
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/steveyegge/beads/issueops"
|
|
)
|
|
|
|
// The shared, DATABASE-FREE half of issueops.Deleter: what a delete request
|
|
// means before anything is read, and how the two answers that name rows —
|
|
// the orphan list and the dependents refusal — are ordered.
|
|
//
|
|
// Every implementation runs these, so `bd delete` has one definition of a
|
|
// malformed request rather than one per backend.
|
|
//
|
|
// What is NOT here is the deletion. The existence probe, the guard and the
|
|
// erasure need one transaction (issueops.Deleter.Delete); the bodies live in
|
|
// internal/storage/issueops/delete.go and in the unit-of-work provider.
|
|
|
|
// ValidateDeleteRequest applies the request rules every Deleter implementation
|
|
// shares, before anything is read.
|
|
//
|
|
// There is deliberately no require-a-filter analog of the sweep gate here: a
|
|
// delete request carries no predicate at all, so a caller cannot spell
|
|
// "everything" without typing every id. The guard that does matter — dependents
|
|
// outside the request — needs the graph and therefore lives in the bodies.
|
|
func ValidateDeleteRequest(in issueops.DeleteRequest) error {
|
|
if len(in.IDs) == 0 {
|
|
return fmt.Errorf("%w: delete requires at least one issue id", issueops.ErrValidation)
|
|
}
|
|
for i, id := range in.IDs {
|
|
if strings.TrimSpace(id) == "" {
|
|
return fmt.Errorf("%w: delete id at position %d is blank", issueops.ErrValidation, i)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// NormalizeDeleteIDs collapses duplicates, keeping the caller's FIRST mention
|
|
// of each id, and trims surrounding whitespace.
|
|
//
|
|
// First-mention order rather than sorted, because it is the order the front
|
|
// doors echo back in their "issues not found" line and in the confirmation
|
|
// hint they print.
|
|
//
|
|
// It assumes a request already accepted by ValidateDeleteRequest, so no entry
|
|
// trims to empty.
|
|
func NormalizeDeleteIDs(ids []string) []string {
|
|
seen := make(map[string]bool, len(ids))
|
|
out := make([]string, 0, len(ids))
|
|
for _, id := range ids {
|
|
trimmed := strings.TrimSpace(id)
|
|
if seen[trimmed] {
|
|
continue
|
|
}
|
|
seen[trimmed] = true
|
|
out = append(out, trimmed)
|
|
}
|
|
return out
|
|
}
|
|
|
|
// SortedDeleteIDs copies and sorts a set of ids ascending. It is what puts
|
|
// DeleteResult.Orphaned and DependentsOutsideRequestError.Dependents in the
|
|
// order issueops.DeleteResult promises, from bodies that collect them out of
|
|
// maps and would otherwise publish Go's map order.
|
|
func SortedDeleteIDs(ids map[string]bool) []string {
|
|
if len(ids) == 0 {
|
|
return nil
|
|
}
|
|
out := make([]string, 0, len(ids))
|
|
for id := range ids {
|
|
out = append(out, id)
|
|
}
|
|
sort.Strings(out)
|
|
return out
|
|
}
|