memoryops needed one sentinel — ErrValidation — and the value the whole repo matches lived in issueops. So the memory leaf imported the issue package for one errors.New and pulled internal/types in behind it, claiming memory sits downstream of issues. It does not: the two are sibling planes over one config table. beadserrors now declares the vocabulary that belongs to no plane in particular — ErrValidation, ErrNotFound, ErrNotInitialized, the ErrUnsupported type — and issueops re-exports it by alias, exactly as internal/storage and backend already re-export from issueops. 141 qualified ErrValidation references across the tree, zero edited: a Go alias preserves identity. memoryops now depends on beadserrors and context, nothing more. What belongs down there is what a leaf for a plane nobody has written yet would need. ErrCloseBlocked and ErrDependencyCycle name issue concepts and stay in issueops. beadserrors imports stdlib and nothing else, enforced by a strict depguard rule rather than asked for in a comment, because it sits beneath every leaf and whatever it imports is imported by all of them. Answers Q4 from #5387.
210 lines
9.7 KiB
Go
210 lines
9.7 KiB
Go
package issueops
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/steveyegge/beads/beadserrors"
|
|
)
|
|
|
|
// ErrAlreadyClaimed is returned when attempting to claim an issue that is already
|
|
// claimed by another user. The error message contains the current assignee.
|
|
var ErrAlreadyClaimed = errors.New("issue already claimed")
|
|
|
|
// ErrNotClaimable is returned when attempting to claim an issue that is not in a
|
|
// claimable state, such as closed, deferred, or already in progress without the
|
|
// same actor owning the claim.
|
|
var ErrNotClaimable = errors.New("issue not claimable")
|
|
|
|
// ClaimConflictError reports the state that refused a claim — the current
|
|
// assignee and status, read inside the same transaction that lost the
|
|
// compare-and-set. It wraps the refusal rather than replacing it, so the
|
|
// sentinel still matches, the refusal's carefully-worded prose survives
|
|
// byte-for-byte, and a caller can classify the conflict from typed fields
|
|
// instead of parsing that prose.
|
|
//
|
|
// Err is set by every implementation that returns this type; a Claimer whose
|
|
// same-transaction re-read fails returns the bare refusal instead.
|
|
type ClaimConflictError struct {
|
|
// IssueID names the issue that refused the claim.
|
|
IssueID string
|
|
// Assignee is the holder observed by the losing transaction. It is empty
|
|
// when the refusal was about the status rather than a foreign holder.
|
|
Assignee string
|
|
// Status is the status observed by the losing transaction.
|
|
Status Status
|
|
// Err is the wrapped refusal. It matches ErrAlreadyClaimed or
|
|
// ErrNotClaimable.
|
|
Err error
|
|
}
|
|
|
|
func (e *ClaimConflictError) Error() string { return e.Err.Error() }
|
|
|
|
// Unwrap makes ClaimConflictError match the refusal it carries.
|
|
func (e *ClaimConflictError) Unwrap() error { return e.Err }
|
|
|
|
// ErrUnsupported reports a capability this backend does not serve. It is an
|
|
// alias of beadserrors.ErrUnsupported — the same type, so one errors.As arm
|
|
// matches it under either name — and it is re-exported here because a caller
|
|
// holding an issueops role should not have to discover a second package to
|
|
// classify the refusal.
|
|
//
|
|
// It is declared there rather than here because the capability shell is not an
|
|
// issue concept: a memory role can go unimplemented by a backend exactly as a
|
|
// Reader can.
|
|
type ErrUnsupported = beadserrors.ErrUnsupported
|
|
|
|
// ErrAssigneeMismatch is returned by UnclaimIssueIfAssignee when the issue's
|
|
// current assignee does not match the expected assignee (including when the
|
|
// issue is no longer assigned at all). The caller's view of the claim was
|
|
// stale; the issue is left untouched.
|
|
var ErrAssigneeMismatch = errors.New("assignee mismatch")
|
|
|
|
// The namespace-neutral part of this vocabulary is declared by beadserrors and
|
|
// re-exported here. These are ALIASES, so they are the same values: every
|
|
// existing issueops.ErrX reference and every errors.Is site keeps matching the
|
|
// identical error, and a leaf that never imports issueops still matches it too.
|
|
//
|
|
// They live down there because none of them names an issue: a request can be
|
|
// invalid, a row can be missing and a database can be uninitialized on any
|
|
// plane. The refusals BELOW that name issue concepts stay here.
|
|
var (
|
|
// ErrNotFound is returned when a requested entity does not exist in the database.
|
|
ErrNotFound = beadserrors.ErrNotFound
|
|
// ErrValidation classifies deterministic request-validation failures.
|
|
ErrValidation = beadserrors.ErrValidation
|
|
// ErrNotInitialized is returned when the database has not been initialized
|
|
// (e.g., issue_prefix config is missing).
|
|
ErrNotInitialized = beadserrors.ErrNotInitialized
|
|
)
|
|
|
|
// ErrPrefixMismatch is returned when an issue ID does not match the configured prefix.
|
|
var ErrPrefixMismatch = errors.New("prefix mismatch")
|
|
|
|
// ErrCloseBlocked is returned by CloseIssueChecked when an issue cannot be
|
|
// closed because it is still blocked (is_blocked=1: an open blocking dependency
|
|
// or an open blocking gate). Bypass with CloseIssueOptions.Force.
|
|
var ErrCloseBlocked = errors.New("cannot close blocked issue")
|
|
|
|
// ErrCloseOpenChildren is returned when an unforced close finds open
|
|
// parent-child dependents.
|
|
var ErrCloseOpenChildren = errors.New("cannot close issue with open children")
|
|
|
|
// CloseOpenChildrenError reports the issue and open-child count that refused a
|
|
// guarded close.
|
|
type CloseOpenChildrenError struct {
|
|
IssueID string
|
|
OpenChildren int
|
|
}
|
|
|
|
func (e *CloseOpenChildrenError) Error() string {
|
|
return fmt.Sprintf("cannot close %s: %d open child issue(s); close children first or use --force to override", e.IssueID, e.OpenChildren)
|
|
}
|
|
|
|
// Unwrap makes CloseOpenChildrenError match ErrCloseOpenChildren.
|
|
func (e *CloseOpenChildrenError) Unwrap() error {
|
|
return ErrCloseOpenChildren
|
|
}
|
|
|
|
// ErrAlreadyExists is returned when a create operation is given an ID that is
|
|
// already occupied. The issue and wisp tables share one ID space.
|
|
var ErrAlreadyExists = errors.New("issue already exists")
|
|
|
|
// ErrAlreadyIdentified is returned by Bootstrapper.Bootstrap when the substrate
|
|
// already carries a workspace identity. It is its own sentinel rather than
|
|
// ErrAlreadyExists because that one is about an occupied ISSUE ID in a shared
|
|
// id space, and a caller that classifies the two together would answer a
|
|
// re-init with advice about `bd update`.
|
|
var ErrAlreadyIdentified = errors.New("workspace already identified")
|
|
|
|
// AlreadyIdentifiedError reports the identity a substrate was found carrying
|
|
// when a bootstrap was refused, read inside the same transaction that would
|
|
// have written over it.
|
|
//
|
|
// It carries the pair rather than formatting it away because the two things a
|
|
// caller does next both need the values: adopting the identity needs them, and
|
|
// telling a COMPLETE identity apart from a half-written one — the state a
|
|
// bootstrap that failed partway leaves on a substrate with no transactions —
|
|
// means looking at which of the two is empty.
|
|
type AlreadyIdentifiedError struct {
|
|
// Prefix is the issue prefix found, or "" when the substrate carried none.
|
|
Prefix string
|
|
// ProjectID is the project identity found, or "" when the substrate
|
|
// carried none.
|
|
ProjectID string
|
|
}
|
|
|
|
func (e *AlreadyIdentifiedError) Error() string {
|
|
switch {
|
|
case e.Prefix != "" && e.ProjectID != "":
|
|
return fmt.Sprintf("workspace already identified as prefix %q, project %s", e.Prefix, e.ProjectID)
|
|
case e.Prefix != "":
|
|
return fmt.Sprintf("workspace already identified as prefix %q with no project id", e.Prefix)
|
|
default:
|
|
return fmt.Sprintf("workspace already identified as project %s with no issue prefix", e.ProjectID)
|
|
}
|
|
}
|
|
|
|
// Unwrap makes AlreadyIdentifiedError match ErrAlreadyIdentified.
|
|
func (e *AlreadyIdentifiedError) Unwrap() error { return ErrAlreadyIdentified }
|
|
|
|
// ErrVersionMismatch is returned by a *Checked op given an ExpectedVersion that
|
|
// no longer matches the row's current version (row_lock) — an optimistic
|
|
// concurrency failure. Callers errors.Is it to distinguish a lost-update
|
|
// precondition from other errors.
|
|
var ErrVersionMismatch = errors.New("version mismatch")
|
|
|
|
// ErrStatusMismatch is returned by UpdateIssueChecked given an ExpectedStatus
|
|
// that no longer matches the issue's current status. The caller's view of the
|
|
// issue was stale; the issue is left untouched. The assignee analog is
|
|
// ErrAssigneeMismatch, shared with UnclaimIssueIfAssignee.
|
|
var ErrStatusMismatch = errors.New("status mismatch")
|
|
|
|
// ErrSelfDependency is returned when a dependency edge would point an issue at
|
|
// itself. It is the static prefix of the formatted message, wrapped so callers
|
|
// can errors.Is it while the human-readable text is preserved byte-for-byte.
|
|
var ErrSelfDependency = errors.New("cannot add self-dependency")
|
|
|
|
// ErrDependencyCycle is returned when adding a dependency edge would introduce a
|
|
// scheduling cycle. It is scoped to the dependency-add family — the single and
|
|
// bulk add paths (add/AddDependencies) and the dolt cross-tier check — so
|
|
// callers can errors.Is any dependency-add cycle rejection. The whole-graph
|
|
// construction paths (ApplyIssueGraph/ApplyWispGraph) are a separate family and
|
|
// deliberately do not carry this sentinel yet.
|
|
var ErrDependencyCycle = errors.New("adding dependency would create a cycle")
|
|
|
|
// DependencyTypeConflictError is returned when an edge already exists between
|
|
// the same pair with a DIFFERENT type. Its message is byte-identical to the
|
|
// embedded issueops path (internal/storage/issueops/dependencies.go) so
|
|
// `bd dep add` surfaces the same user-facing retype error on the domain/db seam
|
|
// as on the embedded store. It is a typed error so the use-case can pass it
|
|
// through unwrapped instead of burying it under an "add dep: insert:" prefix.
|
|
type DependencyTypeConflictError struct {
|
|
IssueID string
|
|
DependsOnID string
|
|
ExistingType string
|
|
RequestedType string
|
|
}
|
|
|
|
func (e *DependencyTypeConflictError) Error() string {
|
|
return fmt.Sprintf("dependency %s -> %s already exists with type %q (requested %q); remove it first with 'bd dep remove' then re-add",
|
|
e.IssueID, e.DependsOnID, e.ExistingType, e.RequestedType)
|
|
}
|
|
|
|
// DependencyHierarchyConflictError is returned when a blocking dependency
|
|
// would gate an issue on one of its own ancestors or descendants. Either shape
|
|
// can never clear under the parent-child close/blocking semantics.
|
|
type DependencyHierarchyConflictError struct {
|
|
IssueID string
|
|
BlockerID string
|
|
BlockerIsAncestor bool
|
|
}
|
|
|
|
func (e *DependencyHierarchyConflictError) Error() string {
|
|
if e.BlockerIsAncestor {
|
|
return fmt.Sprintf("%s cannot be blocked by its ancestor %s: %s cannot close until its descendants finish, so the gate would never clear",
|
|
e.IssueID, e.BlockerID, e.BlockerID)
|
|
}
|
|
return fmt.Sprintf("%s cannot be blocked by its descendant %s: blocked status cascades to descendants, so %s would inherit the block and never close",
|
|
e.IssueID, e.BlockerID, e.BlockerID)
|
|
}
|