* build: make repository text EOL deterministic Apply one repository-wide LF policy to detected text so Windows checkout settings cannot turn ordinary Go source or future text formats into CRLF. Preserve concise rationale for LF-sensitive hook templates, embedded Markdown, migration hashes, and generated-doc comparisons; keep the tracked JPEG explicitly binary and remove redundant path selectors. Exercise a real isolated Git checkout with core.autocrlf=true through a narrow test package. Bind the existing required Ubuntu, macOS, and Windows matrix to exact expected GOOS values, fail closed on missing or wrong host identity and skipped or zero EOL coverage, and preserve the original doc-freshness command as a separate step. Resolve and positively identify one canonical Git executable, reuse it under a curated environment with repo-local hooks, and protect the workflow topology with regression tests. Bind the required aggregate to startup-clean absolute Linux Bash and uname identities, require the exact POSIX checkout workspace, and re-enter privileged profile-free Bash with exec so ambient functions or startup state cannot turn a gate failure into success. Exercise the aggregate shell boundary in subprocess regressions with hostile exported source and exit functions, poisoned startup options, paired clean and failing fixtures, wrong-host falsification, and invalid-workspace cases. Agent-Signature: codex-gpt-5-unknown-reasoning on behalf of Ewen Cuthiell * build: split CI-gate hardening from EOL policy Remove the profile-free CI-gate host-binding chain and its structural and subprocess tests from PR #5319 so the final diff matches the accepted repository EOL motivation. Preserve the required three-host EOL policy lane and its CI Gate propagation. The merge-gate hardening will be reconstructed from current main under its own threat model and review vehicle. Agent-Signature: codex-gpt-5-unknown-reasoning on behalf of Ewen Cuthiell
1224 lines
50 KiB
YAML
1224 lines
50 KiB
YAML
name: PR
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [ main ]
|
|
merge_group:
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
BD_DISABLE_METRICS: "1"
|
|
BD_DISABLE_EVENT_FLUSH: "1"
|
|
|
|
jobs:
|
|
|
|
build-artifacts:
|
|
name: Build Artifacts
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Restore non-race Go build cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ${{ runner.temp }}/go-cache/non-race
|
|
key: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-${{ github.sha }}
|
|
restore-keys: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-
|
|
|
|
- name: Build reusable Linux artifacts
|
|
env:
|
|
GOCACHE: ${{ runner.temp }}/go-cache/non-race
|
|
run: |
|
|
set -euo pipefail
|
|
mkdir -p artifacts
|
|
source ./.buildflags
|
|
go_version="$(go version)"
|
|
commit="$(git rev-parse HEAD)"
|
|
go build -tags "$BEADS_BUILD_TAGS" -o artifacts/bd-linux-gms-pure ./cmd/bd
|
|
chmod +x artifacts/bd-linux-gms-pure
|
|
(
|
|
cd artifacts
|
|
sha256sum bd-linux-gms-pure > SHA256SUMS
|
|
)
|
|
{
|
|
echo "commit=${commit}"
|
|
echo "go_version=${go_version}"
|
|
echo "build_tags=${BEADS_BUILD_TAGS}"
|
|
echo "artifact=bd-linux-gms-pure"
|
|
} > artifacts/build-manifest.txt
|
|
|
|
- name: Upload build artifacts
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
|
with:
|
|
name: ci-build-artifacts
|
|
path: artifacts/
|
|
retention-days: 1
|
|
if-no-files-found: error
|
|
|
|
# Fast check: every `go build|test|run|generate|install` invocation in
|
|
# tracked scripts/hooks/CI carries -tags=gms_pure_go. Prevents ICU-linkage
|
|
# regressions from re-entering the build (see engdocs/ICU-POLICY.md).
|
|
check-build-tags:
|
|
name: Check build-tag policy
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
- run: ./scripts/check-build-tags.sh
|
|
- run: ./scripts/check-go-install-guidance.sh
|
|
|
|
# Lock in two CGO-disabled portability boundaries. cmd/bd carries a mix of
|
|
# cgo-only test helpers (embedded Dolt, sql.DB) and pure-Go tests; compiling
|
|
# and running its pure-Go subset prevents test contamination (mybd-ycx /
|
|
# GH#3683 follow-up). internal/hooks also declares a js/wasm boundary where
|
|
# process execution must fail explicitly, so this required leaf job compiles
|
|
# the complete package test binary and executes that exact contract under
|
|
# Node rather than allowing a missing platform implementation to recur.
|
|
check-cmd-bd-puregeo-tests:
|
|
name: Check pure-Go and js/wasm boundaries (CGO_ENABLED=0)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Set up Node.js
|
|
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v6
|
|
with:
|
|
node-version: '24'
|
|
|
|
- name: Run js/wasm hook boundary
|
|
shell: /usr/bin/env -u BASH_ENV -u ENV -u BASHOPTS -u SHELLOPTS /usr/bin/bash --noprofile --norc -p -euo pipefail {0}
|
|
env:
|
|
BASH_ENV: ""
|
|
ENV: ""
|
|
CGO_ENABLED: "0"
|
|
GOARCH: wasm
|
|
GOENV: "off"
|
|
GOFLAGS: ""
|
|
GOOS: js
|
|
GOTOOLCHAIN: local
|
|
GOWORK: "off"
|
|
NODE_OPTIONS: ""
|
|
run: |
|
|
set -euo pipefail
|
|
|
|
[[ -n "${BASH_VERSION:-}" ]]
|
|
[[ "${BASH:-}" == "/usr/bin/bash" ]]
|
|
[[ /bin/bash -ef /usr/bin/bash ]]
|
|
[[ "$-" == *p* ]]
|
|
[[ ! -v BASH_ENV && ! -v ENV ]]
|
|
[[ "${CGO_ENABLED:-}" == "0" ]]
|
|
[[ "${GOARCH:-}" == "wasm" ]]
|
|
[[ "${GOENV:-}" == "off" ]]
|
|
[[ -z "${GOFLAGS:-}" ]]
|
|
[[ "${GOOS:-}" == "js" ]]
|
|
[[ "${GOTOOLCHAIN:-}" == "local" ]]
|
|
[[ "${GOWORK:-}" == "off" ]]
|
|
[[ -z "${NODE_OPTIONS:-}" ]]
|
|
[[ "${RUNNER_TEMP:-}" == /* ]]
|
|
IFS= read -r kernel_family < /proc/sys/kernel/ostype
|
|
[[ "$kernel_family" == "Linux" ]]
|
|
|
|
go_candidate="$(type -P go)"
|
|
node_candidate="$(type -P node)"
|
|
[[ "$go_candidate" == /* && -x "$go_candidate" ]]
|
|
[[ "$node_candidate" == /* && -x "$node_candidate" ]]
|
|
|
|
node_bin="$("$node_candidate" -e 'process.stdout.write(require("node:fs").realpathSync(process.argv[1]))' "$node_candidate")"
|
|
go_bin="$("$node_bin" -e 'process.stdout.write(require("node:fs").realpathSync(process.argv[1]))' "$go_candidate")"
|
|
[[ "$node_bin" == /* && -x "$node_bin" && "$node_candidate" -ef "$node_bin" ]]
|
|
[[ "$go_bin" == /* && -x "$go_bin" && "$go_candidate" -ef "$go_bin" ]]
|
|
|
|
go_version="$("$go_bin" env GOVERSION)"
|
|
node_version="$("$node_bin" --version)"
|
|
printf 'Go host: %s (%s)\n' "$go_bin" "$go_version"
|
|
printf 'Node host: %s (%s)\n' "$node_bin" "$node_version"
|
|
|
|
[[ "$("$go_bin" env GOHOSTOS)" == "linux" ]]
|
|
[[ "$("$go_bin" env GOOS)" == "js" ]]
|
|
[[ "$("$go_bin" env GOARCH)" == "wasm" ]]
|
|
[[ "$("$go_bin" env CGO_ENABLED)" == "0" ]]
|
|
case "$node_version" in
|
|
v24.*) ;;
|
|
*) printf 'unexpected Node version: %s\n' "$node_version" >&2; exit 1 ;;
|
|
esac
|
|
"$node_bin" -e 'if (typeof WebAssembly !== "object" || typeof WebAssembly.instantiate !== "function") process.exit(1)'
|
|
|
|
go_root="$("$node_bin" -e 'process.stdout.write(require("node:fs").realpathSync(process.argv[1]))' "$("$go_bin" env GOROOT)")"
|
|
[[ -x "$go_root/bin/go" && "$go_bin" -ef "$go_root/bin/go" ]]
|
|
wasm_exec_node="$go_root/lib/wasm/wasm_exec_node.js"
|
|
wasm_exec_runtime="$go_root/lib/wasm/wasm_exec.js"
|
|
wasm_test="$RUNNER_TEMP/internal-hooks.test.wasm"
|
|
[[ -r "$wasm_exec_node" ]]
|
|
[[ -r "$wasm_exec_runtime" ]]
|
|
|
|
"$go_bin" test -tags gms_pure_go -c -o "$wasm_test" ./internal/hooks
|
|
[[ -s "$wasm_test" ]]
|
|
# This required lane owns the exact js/wasm refusal contract. If the
|
|
# wasm test surface grows, widen this selector and its count guard
|
|
# together rather than assuming compilation executes new tests.
|
|
test_status=0
|
|
test_output="$("$node_bin" --stack-size=8192 "$wasm_exec_node" "$wasm_test" \
|
|
-test.v -test.timeout=2m \
|
|
-test.run '^TestRunHookReportsUnsupportedExecution$' \
|
|
2>&1)" || test_status=$?
|
|
printf '%s\n' "$test_output"
|
|
(( test_status == 0 )) || exit "$test_status"
|
|
|
|
run_count=0
|
|
exact_run_count=0
|
|
exact_pass_count=0
|
|
nonpass_count=0
|
|
suite_pass_count=0
|
|
pass_pattern='^--- PASS: TestRunHookReportsUnsupportedExecution \([0-9.]+s\)$'
|
|
while IFS= read -r line; do
|
|
if [[ "$line" == "=== RUN "* ]]; then
|
|
((run_count += 1))
|
|
fi
|
|
if [[ "$line" == "=== RUN TestRunHookReportsUnsupportedExecution" ]]; then
|
|
((exact_run_count += 1))
|
|
fi
|
|
if [[ "$line" =~ $pass_pattern ]]; then
|
|
((exact_pass_count += 1))
|
|
fi
|
|
case "$line" in
|
|
"--- FAIL: TestRunHookReportsUnsupportedExecution"*|"--- SKIP: TestRunHookReportsUnsupportedExecution"*)
|
|
((nonpass_count += 1))
|
|
;;
|
|
esac
|
|
if [[ "$line" == "PASS" ]]; then
|
|
((suite_pass_count += 1))
|
|
fi
|
|
done <<< "$test_output"
|
|
if [[ "$run_count" != 1 || "$exact_run_count" != 1 || "$exact_pass_count" != 1 || "$nonpass_count" != 0 || "$suite_pass_count" != 1 ]]; then
|
|
printf 'expected one exact js/wasm hook test run and pass; got runs=%s exact-runs=%s exact-passes=%s nonpasses=%s suite-passes=%s\n' \
|
|
"$run_count" "$exact_run_count" "$exact_pass_count" "$nonpass_count" "$suite_pass_count" >&2
|
|
exit 1
|
|
fi
|
|
|
|
- name: Build cmd/bd (CGO_ENABLED=0, gms_pure_go)
|
|
env:
|
|
CGO_ENABLED: "0"
|
|
run: go build -tags gms_pure_go -o /tmp/bd-puregeo ./cmd/bd
|
|
|
|
- name: Compile pure-Go test binaries (CGO_ENABLED=0, gms_pure_go)
|
|
env:
|
|
CGO_ENABLED: "0"
|
|
run: |
|
|
go test -tags gms_pure_go -c -o /tmp/bd-cmd-puregeo-test ./cmd/bd
|
|
go test -tags gms_pure_go -c -o /tmp/bd-embeddeddolt-puregeo-test ./internal/storage/embeddeddolt
|
|
go test -tags gms_pure_go -c -o /tmp/bd-tracker-puregeo-test ./internal/tracker
|
|
|
|
- name: Run pure-Go cmd/bd test subset (CGO_ENABLED=0)
|
|
env:
|
|
CGO_ENABLED: "0"
|
|
# Restrict to tests that exercise pure-Go code paths. Tests that
|
|
# need a Dolt store skip themselves at runtime when no test server
|
|
# is available; the goal here is to catch compile-time contamination,
|
|
# not run the full suite.
|
|
run: |
|
|
go test -tags gms_pure_go -count=1 -short -run '^Test(Help|CheckRemoteSafety|FormatDestroyToken|ShouldWireInitRemote|ExtractPrefix|IsNumericID|GetWorktreeGitDir|DriftItemStatuses|RunDriftChecks|IsServerProbablyRunning|CheckHooksDriftNotGitRepo|CheckServerDriftNoBeadsDir|CheckRemoteDriftNoBeadsDir)' ./cmd/bd
|
|
|
|
# The lingering-handle liveness regression test is //go:build windows: the
|
|
# Ubuntu job above selects it by name but compiles it out, and main.yml's
|
|
# Windows job runs only on pushes to main (build/smoke, no go test). Run
|
|
# exactly the liveness pair on windows-latest so the regression guard
|
|
# actually executes at PR time.
|
|
test-windows-liveness:
|
|
name: Test (Windows) cmd/bd liveness regression
|
|
runs-on: windows-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Run Windows liveness regression test
|
|
run: go test -tags gms_pure_go -count=1 -run '^TestIsServerProbablyRunning' ./cmd/bd
|
|
|
|
# Destructive worktree removal depends on native Windows path identity.
|
|
# This focused process suite requires NTFS per-directory case sensitivity
|
|
# and fails (rather than skips) when the runner cannot provide it.
|
|
worktree-remove-windows:
|
|
name: Worktree remove boundary (Windows)
|
|
runs-on: windows-latest
|
|
timeout-minutes: 15
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Restore non-race Go build cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ${{ runner.temp }}/go-cache/non-race
|
|
key: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-${{ github.sha }}
|
|
restore-keys: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-
|
|
|
|
- name: Run native Windows worktree removal boundary tests
|
|
env:
|
|
CGO_ENABLED: "0"
|
|
GOCACHE: ${{ runner.temp }}/go-cache/non-race
|
|
run: go test -tags gms_pure_go -count=1 -run '^TestWorktreeRemove' ./cmd/bd
|
|
|
|
# Fast check to ensure all version files are in sync
|
|
check-version-consistency:
|
|
name: Check version consistency
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Check all versions match
|
|
run: ./scripts/check-versions.sh
|
|
|
|
# Migration hygiene: duplicate version numbers, nondeterministic SQL
|
|
# (UUID()/NOW()/RAND(), the #4259 root-cause class), and edits to migration
|
|
# files that already exist on the base branch (shipped migrations are
|
|
# frozen; fix forward with a new version). Fails at PR time, before any
|
|
# test even compiles. Details: scripts/check-migration-hygiene.sh.
|
|
check-migration-hygiene:
|
|
name: Check migration hygiene
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Run migration hygiene checks
|
|
env:
|
|
BASE_SHA: ${{ github.event.pull_request.base.sha || github.event.merge_group.base_sha }}
|
|
run: ./scripts/check-migration-hygiene.sh
|
|
|
|
# Check documentation references match actual CLI flags
|
|
check-doc-flags:
|
|
name: Check doc flags freshness
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
# Full history so check-cli-docs-drift.sh can regenerate docs at the
|
|
# merge-base and only fail PRs for drift they actually introduced.
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Build bd
|
|
run: CGO_ENABLED=0 go build -tags gms_pure_go -o bd ./cmd/bd/
|
|
|
|
- name: Validate docs against CLI
|
|
env:
|
|
DOC_DRIFT_PATCH_OUT: ${{ runner.temp }}/cli-docs-freshness.patch
|
|
run: |
|
|
./scripts/check-doc-flags.sh ./bd
|
|
./scripts/check-doc-freshness.sh
|
|
|
|
# When the drift check fails, it writes the exact regenerated-docs fix
|
|
# (produced with CI's canonical build) so contributors can apply it with
|
|
# `git apply` instead of reproducing CI's environment locally. The
|
|
# docs-autofix.yml workflow_run job consumes this same artifact to push
|
|
# the fix to same-repo PR branches automatically.
|
|
- name: Upload docs fix patch
|
|
if: failure()
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
|
|
with:
|
|
name: cli-docs-freshness-patch
|
|
path: ${{ runner.temp }}/cli-docs-freshness.patch
|
|
if-no-files-found: ignore
|
|
|
|
check-doc-freshness-platforms:
|
|
name: Check doc freshness (${{ matrix.os }})
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 10
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- os: ubuntu-latest
|
|
expected_goos: linux
|
|
- os: macos-latest
|
|
expected_goos: darwin
|
|
- os: windows-latest
|
|
expected_goos: windows
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Exercise native date and Bash process boundary
|
|
run: go test '-tags=integration,gms_pure_go' -count=1 -run '^TestDocFreshness' ./scripts
|
|
|
|
- name: Exercise repository text EOL policy boundary
|
|
run: go test '-tags=integration,gms_pure_go' -count=1 ./scripts/gitattributespolicy -args -required-host -expected-goos '${{ matrix.expected_goos }}'
|
|
|
|
pr-preflight-platforms:
|
|
name: PR preflight process (${{ matrix.os }})
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 20
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [ubuntu-latest, macos-latest, windows-latest]
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Exercise the real Bash process boundary
|
|
shell: bash
|
|
run: go test '-tags=integration,gms_pure_go' -count=1 -run '^TestPRPreflight' ./scripts
|
|
|
|
- name: Exercise test.sh prebuilt binary path
|
|
shell: bash
|
|
run: go test '-tags=gms_pure_go' -count=1 -run '^TestTestScriptPrebuiltBinaryContract$' ./scripts
|
|
|
|
- name: Exercise generated Git hook timeout process boundary
|
|
shell: bash
|
|
run: go test '-tags=gms_pure_go' -count=1 -run '^TestGeneratedHookTimeoutProcessBoundary$' ./cmd/bd
|
|
|
|
# Fast check to catch accidental .beads/issues.jsonl changes from contributors
|
|
check-no-beads-changes:
|
|
name: Check for .beads changes
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request'
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Check for .beads/issues.jsonl changes
|
|
run: |
|
|
if git diff --name-only origin/${{ github.base_ref }}...HEAD | grep -q "^\.beads/issues\.jsonl$"; then
|
|
echo "This PR includes changes to .beads/issues.jsonl"
|
|
echo ""
|
|
echo "This file is the project's issue database and should not be modified in PRs."
|
|
echo ""
|
|
echo "To fix, run:"
|
|
echo " git checkout origin/main -- .beads/issues.jsonl"
|
|
echo " git commit --amend"
|
|
echo " git push --force"
|
|
echo ""
|
|
exit 1
|
|
fi
|
|
echo "No .beads/issues.jsonl changes detected"
|
|
|
|
detect-package-gates:
|
|
name: Detect package gates
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
mcp_package: ${{ steps.detect.outputs.mcp_package }}
|
|
npm_package: ${{ steps.detect.outputs.npm_package }}
|
|
reason: ${{ steps.detect.outputs.reason }}
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Decide package gates
|
|
id: detect
|
|
env:
|
|
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
|
|
PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
|
|
PUSH_BEFORE_SHA: ${{ github.event.before }}
|
|
PUSH_AFTER_SHA: ${{ github.sha }}
|
|
run: ./scripts/ci/detect-package-gates.sh
|
|
|
|
package-mcp:
|
|
name: Package Gate (MCP)
|
|
runs-on: ubuntu-latest
|
|
needs: [detect-package-gates, build-artifacts]
|
|
steps:
|
|
- name: Check applicability
|
|
id: applicability
|
|
run: |
|
|
echo "run=${{ needs.detect-package-gates.outputs.mcp_package }}" >> "$GITHUB_OUTPUT"
|
|
if [[ "${{ needs.detect-package-gates.outputs.mcp_package }}" != "true" ]]; then
|
|
echo "MCP package gate is not applicable: ${{ needs.detect-package-gates.outputs.reason }}"
|
|
fi
|
|
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
if: steps.applicability.outputs.run == 'true'
|
|
|
|
- name: Set up Python
|
|
if: steps.applicability.outputs.run == 'true'
|
|
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
|
|
with:
|
|
python-version: '3.14'
|
|
|
|
- name: Install uv
|
|
if: steps.applicability.outputs.run == 'true'
|
|
run: python -m pip install uv==0.11.16
|
|
|
|
- name: Download build artifacts
|
|
if: steps.applicability.outputs.run == 'true'
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
|
with:
|
|
name: ci-build-artifacts
|
|
path: ci-build-artifacts
|
|
|
|
- name: Verify build artifacts
|
|
if: steps.applicability.outputs.run == 'true'
|
|
run: |
|
|
set -euo pipefail
|
|
cd ci-build-artifacts
|
|
sha256sum -c SHA256SUMS
|
|
chmod +x bd-linux-gms-pure
|
|
|
|
- name: Run MCP package gate
|
|
if: steps.applicability.outputs.run == 'true'
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/ci-build-artifacts/bd-linux-gms-pure
|
|
run: make ci-package-mcp
|
|
|
|
package-npm:
|
|
name: Package Gate (npm)
|
|
runs-on: ubuntu-latest
|
|
needs: [detect-package-gates, build-artifacts]
|
|
steps:
|
|
- name: Check applicability
|
|
id: applicability
|
|
run: |
|
|
echo "run=${{ needs.detect-package-gates.outputs.npm_package }}" >> "$GITHUB_OUTPUT"
|
|
if [[ "${{ needs.detect-package-gates.outputs.npm_package }}" != "true" ]]; then
|
|
echo "npm package gate is not applicable: ${{ needs.detect-package-gates.outputs.reason }}"
|
|
fi
|
|
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
if: steps.applicability.outputs.run == 'true'
|
|
|
|
- name: Set up Node.js
|
|
if: steps.applicability.outputs.run == 'true'
|
|
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v6
|
|
with:
|
|
node-version: '24'
|
|
|
|
- name: Download build artifacts
|
|
if: steps.applicability.outputs.run == 'true'
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
|
with:
|
|
name: ci-build-artifacts
|
|
path: ci-build-artifacts
|
|
|
|
- name: Verify build artifacts
|
|
if: steps.applicability.outputs.run == 'true'
|
|
run: |
|
|
set -euo pipefail
|
|
cd ci-build-artifacts
|
|
sha256sum -c SHA256SUMS
|
|
chmod +x bd-linux-gms-pure
|
|
|
|
- name: Run npm package gate
|
|
if: steps.applicability.outputs.run == 'true'
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/ci-build-artifacts/bd-linux-gms-pure
|
|
run: make ci-package-npm
|
|
|
|
|
|
pr-policy-wrapper:
|
|
name: PR Policy (wrapper timing)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Run PR policy wrapper
|
|
run: make ci-pr-policy
|
|
|
|
pr-core-wrapper:
|
|
name: PR Core (wrapper timing)
|
|
runs-on: ubuntu-latest
|
|
needs: build-artifacts
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Restore race Go build cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ${{ runner.temp }}/go-cache/race
|
|
key: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-race-${{ github.sha }}
|
|
restore-keys: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-race-
|
|
|
|
- name: Install Dolt
|
|
run: curl -fsSL https://github.com/dolthub/dolt/releases/latest/download/install.sh | sudo bash
|
|
|
|
- name: Configure Git and Dolt identity
|
|
run: |
|
|
git config --global user.name "CI Bot"
|
|
git config --global user.email "ci@beads.test"
|
|
dolt config --global --add user.name "CI Bot"
|
|
dolt config --global --add user.email "ci@beads.test"
|
|
|
|
- name: Download build artifacts
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
|
with:
|
|
name: ci-build-artifacts
|
|
path: ci-build-artifacts
|
|
|
|
- name: Verify build artifacts
|
|
run: |
|
|
set -euo pipefail
|
|
cd ci-build-artifacts
|
|
sha256sum -c SHA256SUMS
|
|
chmod +x bd-linux-gms-pure
|
|
|
|
- name: Run PR core wrapper
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/ci-build-artifacts/bd-linux-gms-pure
|
|
GOCACHE: ${{ runner.temp }}/go-cache/race
|
|
run: make ci-pr-core
|
|
|
|
pr-lint-wrapper:
|
|
name: PR Lint (wrapper timing)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
# --new-from-merge-base below walks real history.
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Install golangci-lint
|
|
run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.10.1
|
|
|
|
# Scope the wrapper's lint to what this PR introduces, matching the
|
|
# `lint` job's only-new-issues below. main.yml runs the same wrapper with
|
|
# this unset, so the whole tree is still swept on every push to main.
|
|
# Both PR triggers (pull_request, merge_group) target main.
|
|
- name: Run PR lint wrapper
|
|
env:
|
|
BD_LINT_NEW_FROM_MERGE_BASE: origin/main
|
|
run: make ci-pr-lint
|
|
|
|
# Focused job for the hexagonal storage layer (internal/storage/domain/* and
|
|
# internal/storage/uow). These packages back the proxied-server init path and
|
|
# also live behind the existing ./... matrix, but TestDomainDB requires the
|
|
# Dolt sql-server image cached locally (testcontainers checks `docker image
|
|
# inspect` and skips otherwise). Pulling the image up front guarantees the
|
|
# suite actually runs and surfaces failures here with a clear job name.
|
|
test-domain-uow:
|
|
name: Test (storage domain + uow)
|
|
runs-on: ubuntu-latest
|
|
needs: build-artifacts
|
|
# The race-enabled storage package has outgrown Go's implicit 10-minute
|
|
# timeout. Keep both per-package deadlines inside one finite job budget.
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Install Dolt CLI
|
|
run: curl -fsSL https://github.com/dolthub/dolt/releases/latest/download/install.sh | sudo bash
|
|
|
|
- name: Verify dolt on PATH
|
|
run: dolt version
|
|
|
|
- name: Configure Git and Dolt identity
|
|
run: |
|
|
git config --global user.name "CI Bot"
|
|
git config --global user.email "ci@beads.test"
|
|
dolt config --global --add user.name "CI Bot"
|
|
dolt config --global --add user.email "ci@beads.test"
|
|
|
|
- name: Pull Dolt sql-server image
|
|
# Keep tag in sync with internal/testutil/testdoltcommon.go:DoltDockerImage.
|
|
# Without this, RequireDoltContainer reports doltNoImage and TestDomainDB skips.
|
|
run: ./scripts/ci/pull-dolt-image.sh
|
|
|
|
- name: Download build artifacts
|
|
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
|
|
with:
|
|
name: ci-build-artifacts
|
|
path: ci-build-artifacts
|
|
|
|
- name: Verify build artifacts
|
|
run: |
|
|
set -euo pipefail
|
|
cd ci-build-artifacts
|
|
sha256sum -c SHA256SUMS
|
|
chmod +x bd-linux-gms-pure
|
|
|
|
- name: Test domain + uow + tracker
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/ci-build-artifacts/bd-linux-gms-pure
|
|
run: go test -tags gms_pure_go -race -count=1 -timeout 15m -v ./internal/storage/domain/... ./internal/storage/uow/... ./internal/tracker/...
|
|
|
|
# The doctor/fix DB-backed suite spins its own Dolt container in
|
|
# TestMain. BEADS_FIX_REQUIRE_DOLT=1 turns a missing container into a
|
|
# hard failure so the suite can never silently skip in CI again
|
|
# (bd-nxt5e: it was dark for months); this job pulls the image above.
|
|
- name: Test doctor/fix (Dolt-backed, hard-require container)
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/ci-build-artifacts/bd-linux-gms-pure
|
|
BEADS_FIX_REQUIRE_DOLT: "1"
|
|
run: go test -tags gms_pure_go -race -count=1 -timeout 10m -v ./cmd/bd/doctor/fix/
|
|
|
|
# macOS-only regressions were landing on main undetected: main.yml's Test
|
|
# (macos-latest) leg only runs `if: github.event_name == 'push' &&
|
|
# github.ref == 'refs/heads/main'`, so no PR ever exercises it. On
|
|
# 2026-08-01 that leg went red from three separately-merged PRs in a single
|
|
# day, all $TMPDIR=/var/folders symlink/path-depth consequences that only
|
|
# reproduce on macOS - none of the three could have seen the failure
|
|
# pre-merge, and the local bisect lane can't diagnose it either (Linux
|
|
# host, macOS-only failure). This job mirrors that leg's steps on every PR
|
|
# so the same class of regression fails here instead of on main. It is
|
|
# self-contained (no build-artifacts dependency): the macOS leg in main.yml
|
|
# never downloads or verifies the Linux build-artifacts bundle, it just
|
|
# builds and tests directly.
|
|
#
|
|
# Deliberately NOT continue-on-error: unlike the advisory legs elsewhere in
|
|
# this file that tolerate infrastructure flakiness, a red macOS test here is
|
|
# a real regression, and blocking the merge lane on it is the entire point.
|
|
#
|
|
# Deliberately NOT yet added to ci-gate's `needs`/`CI_GATE_REQUIRED`:
|
|
# promoting a new job to required-for-merge, once it has run clean for a
|
|
# while, is a separate maintainer call - same pattern as other jobs in this
|
|
# file that run on every PR without yet gating the merge.
|
|
test-macos:
|
|
name: Test (macos-latest)
|
|
runs-on: macos-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
id: setup-go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Restore Go module cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/go/pkg/mod
|
|
key: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod', 'go.sum') }}
|
|
restore-keys: beads-go-mod-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-
|
|
|
|
- name: Restore non-race Go build cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ${{ runner.temp }}/go-cache/non-race
|
|
key: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-${{ github.sha }}
|
|
restore-keys: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-non-race-
|
|
|
|
- name: Restore race Go build cache
|
|
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ${{ runner.temp }}/go-cache/race
|
|
key: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-race-${{ github.sha }}
|
|
restore-keys: beads-go-build-v2-${{ runner.os }}-${{ runner.arch }}-go-${{ steps.setup-go.outputs.go-version }}-base-gms_pure_go-race-
|
|
|
|
- name: Install Dolt (Linux/macOS)
|
|
run: curl -fsSL https://github.com/dolthub/dolt/releases/latest/download/install.sh | sudo bash
|
|
|
|
- name: Verify dolt on PATH
|
|
run: dolt version
|
|
|
|
- name: Configure Git and Dolt identity
|
|
run: |
|
|
git config --global user.name "CI Bot"
|
|
git config --global user.email "ci@beads.test"
|
|
dolt config --global --add user.name "CI Bot"
|
|
dolt config --global --add user.email "ci@beads.test"
|
|
|
|
- name: Build
|
|
env:
|
|
GOCACHE: ${{ runner.temp }}/go-cache/non-race
|
|
run: go build -v -tags gms_pure_go ./cmd/bd
|
|
|
|
- name: Test
|
|
env:
|
|
BEADS_TEST_BD_BINARY: ${{ github.workspace }}/bd
|
|
GOCACHE: ${{ runner.temp }}/go-cache/race
|
|
run: go test -tags gms_pure_go -v -race -short -skip '^TestEmbedded' ./...
|
|
|
|
# Producer-side guard for the Beads<->consumer CLI contract. Runs the whole
|
|
# cmd/bd/protocol package: the golden corpus (regenerated from this branch's
|
|
# bd and byte-compared to the committed testdata/corpus/, so an unreviewed
|
|
# wire change is a hard failure — run `make corpus-regen`), the double-run
|
|
# determinism check, and the TestProtocol_/TestJSONContract_ behavioral
|
|
# conformance suite that pins the CLI's JSON payloads and semantics.
|
|
#
|
|
# Run the PACKAGE, never a -run subset: a filter here is what let the
|
|
# conformance tests sit red on main for ~3 months while every CI run was
|
|
# green (they matched no job's -run, and every broad ./... job skips them
|
|
# for want of a Dolt store). Package scope means a newly added protocol test
|
|
# is gated the moment it lands.
|
|
#
|
|
# Needs the Dolt sql-server image (the protocol harness spins a container).
|
|
# ~10 min: each test builds an isolated Dolt-backed workspace. If that ever
|
|
# becomes unacceptable on PRs, shard this job by an exhaustive `go test
|
|
# -list` partition — do not reintroduce a hand-written -run regex.
|
|
contract-corpus:
|
|
name: Contract corpus (golden + determinism + conformance)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Install Dolt CLI
|
|
run: curl -fsSL https://github.com/dolthub/dolt/releases/latest/download/install.sh | sudo bash
|
|
|
|
- name: Configure Git and Dolt identity
|
|
run: |
|
|
git config --global user.name "CI Bot"
|
|
git config --global user.email "ci@beads.test"
|
|
dolt config --global --add user.name "CI Bot"
|
|
dolt config --global --add user.email "ci@beads.test"
|
|
|
|
- name: Pull Dolt sql-server image
|
|
# Keep tag in sync with internal/testutil/testdoltcommon.go:DoltDockerImage.
|
|
run: ./scripts/ci/pull-dolt-image.sh
|
|
|
|
- name: Protocol conformance + corpus golden + determinism
|
|
# Require a live Dolt store here: this is the gate that must exercise the
|
|
# conformance, golden and double-run checks, so a failed container is a
|
|
# hard failure, not a silent skip (see requireDoltStore in the
|
|
# cmd/bd/protocol tests).
|
|
#
|
|
# -timeout is explicit because the package runs well past `go test`'s
|
|
# 10m default; without it a slow runner reports a panic, not a verdict.
|
|
env:
|
|
BEADS_PROTOCOL_REQUIRE_DOLT: "1"
|
|
run: go test -tags gms_pure_go -count=1 -timeout 30m ./cmd/bd/protocol
|
|
|
|
fmt-check:
|
|
name: Check formatting
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: Check gofmt
|
|
run: make fmt-check
|
|
|
|
# Lint lanes are split deliberately: the PR lane reports only the issues a PR
|
|
# introduces, and main.yml's identical job sweeps the whole tree on every
|
|
# push. The tradeoff is that a pre-existing issue in untouched code no longer
|
|
# blocks a PR — but a lint word that lands on main now reds main's own run,
|
|
# where it belongs, instead of reddening every open PR for a change it did
|
|
# not make.
|
|
#
|
|
# "New" is measured off the diff, so MOVED CODE READS AS NEW: a pre-existing
|
|
# violation carried into a PR by a move or a rename is reported against that
|
|
# PR and blocks it. Fix it or //nolint it there — that is the accepted cost of
|
|
# the trade above.
|
|
lint:
|
|
name: Lint
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
# only-new-issues reads the PR patch from the API.
|
|
pull-requests: read
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
with:
|
|
# On merge_group there is no PR patch, so the action falls back to
|
|
# --new-from-rev and needs real history.
|
|
fetch-depth: 0
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
|
|
with:
|
|
go-version-file: 'go.mod'
|
|
cache: false
|
|
|
|
- name: golangci-lint
|
|
uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9
|
|
env:
|
|
GOWORK: "off"
|
|
with:
|
|
version: v2.10.1
|
|
only-new-issues: true
|
|
args: --config=.golangci.yml --modules-download-mode=readonly --timeout=5m --build-tags=gms_pure_go
|
|
|
|
windows-make-shell:
|
|
name: Windows Make shell (${{ matrix.host }})
|
|
runs-on: windows-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
host:
|
|
- native
|
|
- msys2
|
|
- cygwin
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Install native GNU Make
|
|
if: matrix.host == 'native'
|
|
shell: pwsh
|
|
run: choco install make --version=4.4.1 --yes --no-progress
|
|
|
|
- name: Set up MSYS2 GNU Make
|
|
if: matrix.host == 'msys2'
|
|
uses: msys2/setup-msys2@66cd2cce69caa17b53920067426061ca1de3a884 # v2.32.0
|
|
with:
|
|
msystem: MSYS
|
|
install: git make
|
|
path-type: minimal
|
|
|
|
- name: Set up Cygwin GNU Make
|
|
if: matrix.host == 'cygwin'
|
|
id: cygwin
|
|
# cygwin-install-action downloads setup-x86_64.exe from cygwin.com. That
|
|
# download times out often enough to red the required check for a reason
|
|
# unrelated to the change under test. Treat a setup failure as a
|
|
# (non-blocking) warning: the smoke step below is gated on this step
|
|
# succeeding, so a genuine Cygwin Make regression still fails loudly,
|
|
# while a flaky installer download only skips the leg with a warning.
|
|
continue-on-error: true
|
|
uses: cygwin/cygwin-install-action@3f0a3f9f988f7e96b8c18098ae05eaec175f5b52 # v6
|
|
with:
|
|
packages: git make
|
|
add-to-path: 'false'
|
|
|
|
- name: Warn when Cygwin setup was skipped by a download failure
|
|
if: matrix.host == 'cygwin' && steps.cygwin.outcome == 'failure'
|
|
shell: bash
|
|
run: |
|
|
echo "::warning title=Cygwin Make-shell leg skipped::cygwin-install-action could not download the Cygwin installer (network flake); skipping the Cygwin-hosted Make smoke test. This is an infrastructure failure, not a code failure."
|
|
|
|
- name: Exercise native Windows Make
|
|
if: matrix.host == 'native'
|
|
shell: pwsh
|
|
run: |
|
|
$ErrorActionPreference = 'Stop'
|
|
$make = (Get-Command make.exe -ErrorAction Stop).Source
|
|
$hostOutput = & $make --no-print-directory -f NUL --eval '$(info MAKE_HOST=$(MAKE_HOST))' --eval 'noop:;' noop
|
|
$makeHost = (($hostOutput | Where-Object { $_ -like 'MAKE_HOST=*' }) -replace '^MAKE_HOST=', '').Trim()
|
|
if ($LASTEXITCODE -ne 0 -or ($makeHost -ne 'Windows32' -and $makeHost -notmatch '-mingw32$')) {
|
|
throw "Expected native Windows GNU Make, found '$makeHost' at '$make'"
|
|
}
|
|
|
|
$git = (Get-Command git.exe -ErrorAction Stop).Source
|
|
if ($git -notmatch ' ') {
|
|
throw "Expected the hosted Git for Windows path to contain a space, found '$git'"
|
|
}
|
|
|
|
$profile = Join-Path $env:RUNNER_TEMP 'profile with spaces'
|
|
New-Item -ItemType Directory -Force -Path $profile | Out-Null
|
|
$poison = Join-Path $profile 'poison bash env.sh'
|
|
Set-Content -LiteralPath $poison -Encoding utf8 -Value 'exit 97'
|
|
|
|
$env:USERPROFILE = $profile
|
|
$env:BASH_ENV = $poison
|
|
$env:BASHOPTS = 'failglob'
|
|
$env:SHELLOPTS = 'nounset'
|
|
$env:GIT_EXEC_PATH = Join-Path $profile 'missing git exec path'
|
|
$env:PATH = "$(Split-Path $git);$env:SystemRoot\System32"
|
|
|
|
& $make --no-print-directory help | Out-Null
|
|
if ($LASTEXITCODE -ne 0) {
|
|
throw 'Native Make failed while parsing or running help'
|
|
}
|
|
|
|
@'
|
|
include Makefile
|
|
.RECIPEPREFIX := >
|
|
.PHONY: windows-make-shell-smoke
|
|
windows-make-shell-smoke:
|
|
>@case "$(SHELL)" in */bin/bash.exe) ;; *) exit 1;; esac
|
|
>@test -n "$$BASH_VERSION"
|
|
>@test "$$(command -v sed)" = /usr/bin/sed
|
|
>@test "$$(command -v env)" = /usr/bin/env
|
|
>@test -z "$${BASH_ENV+x}"
|
|
>@case "$$-" in *u*) exit 1;; esac
|
|
>@shopt -q failglob && exit 1 || :
|
|
>@test -z "$${GIT_EXEC_PATH+x}"
|
|
>@env printf '%s\n' 'native Windows Make shell smoke passed'
|
|
'@ | & $make --no-print-directory -f - windows-make-shell-smoke
|
|
if ($LASTEXITCODE -ne 0) {
|
|
throw 'Native Make shell smoke failed'
|
|
}
|
|
|
|
- name: Exercise MSYS2-hosted Make
|
|
if: matrix.host == 'msys2'
|
|
shell: msys2 {0}
|
|
run: |
|
|
set -euo pipefail
|
|
make_host="$(
|
|
make --no-print-directory -f /dev/null \
|
|
--eval '$(info $(MAKE_HOST))' \
|
|
--eval 'noop:;' noop |
|
|
sed -n '1p'
|
|
)"
|
|
case "$make_host" in
|
|
*-msys|*-cygwin) ;;
|
|
*) echo "Expected a POSIX-hosted MSYS2 GNU Make, found '$make_host'" >&2; exit 1 ;;
|
|
esac
|
|
|
|
profile="$(cygpath -u "$RUNNER_TEMP")/profile with spaces"
|
|
mkdir -p "$profile"
|
|
bash_env="$profile/compat bash env.sh"
|
|
printf '%s\n' 'exit 97' > "$bash_env"
|
|
export BASH_ENV="$bash_env"
|
|
export GIT_EXEC_PATH="$profile/missing git exec path"
|
|
export PATH=/usr/bin
|
|
|
|
make --no-print-directory help >/dev/null
|
|
cat > "$profile/smoke.mk" <<'MAKE_EOF'
|
|
include Makefile
|
|
.RECIPEPREFIX := >
|
|
.PHONY: windows-make-shell-smoke
|
|
windows-make-shell-smoke:
|
|
>@case "$(SHELL)" in */sh) ;; *) exit 1;; esac
|
|
>@test -n "$$BASH_VERSION"
|
|
>@test "$$(command -v sed)" = /usr/bin/sed
|
|
>@test "$$(command -v env)" = /usr/bin/env
|
|
>@test -f "$$BASH_ENV"
|
|
>@test -n "$$GIT_EXEC_PATH"
|
|
>@case "$$PATH" in *';'*) exit 1;; esac
|
|
>@env printf '%s\n' 'MSYS2 Make shell smoke passed'
|
|
MAKE_EOF
|
|
make --no-print-directory -f "$profile/smoke.mk" windows-make-shell-smoke
|
|
|
|
- name: Exercise Cygwin-hosted Make
|
|
# Only run when the Cygwin toolchain actually installed; a skipped install
|
|
# (download flake) leaves this leg un-exercised rather than failing on a
|
|
# missing bash. A real install success followed by a Make regression here
|
|
# still fails the job as before.
|
|
if: matrix.host == 'cygwin' && steps.cygwin.outcome == 'success'
|
|
shell: pwsh
|
|
env:
|
|
CYGWIN_ROOT: ${{ steps.cygwin.outputs.root }}
|
|
run: |
|
|
$ErrorActionPreference = 'Stop'
|
|
$bash = Join-Path $env:CYGWIN_ROOT 'bin\bash.exe'
|
|
$script = @'
|
|
set -euo pipefail
|
|
export PATH=/usr/bin
|
|
cd "$(cygpath -u "$GITHUB_WORKSPACE")"
|
|
|
|
make_host="$(
|
|
make --no-print-directory -f /dev/null \
|
|
--eval '$(info $(MAKE_HOST))' \
|
|
--eval 'noop:;' noop |
|
|
sed -n '1p'
|
|
)"
|
|
case "$make_host" in
|
|
*-cygwin) ;;
|
|
*) echo "Expected Cygwin GNU Make, found '$make_host'" >&2; exit 1 ;;
|
|
esac
|
|
|
|
profile="$(mktemp -d)"
|
|
trap 'rm -rf -- "$profile"' EXIT
|
|
bash_env="$profile/cygwin bash env.sh"
|
|
printf '%s\n' 'exit 97' > "$bash_env"
|
|
export BASH_ENV="$bash_env"
|
|
export GIT_EXEC_PATH="$profile/missing git exec path"
|
|
|
|
make --no-print-directory help >/dev/null
|
|
cat > "$profile/smoke.mk" <<'MAKE_EOF'
|
|
include Makefile
|
|
.RECIPEPREFIX := >
|
|
.PHONY: windows-make-shell-smoke
|
|
windows-make-shell-smoke:
|
|
>@case "$(SHELL)" in */sh) ;; *) exit 1;; esac
|
|
>@test -n "$$BASH_VERSION"
|
|
>@test "$$(command -v sed)" = /usr/bin/sed
|
|
>@test "$$(command -v env)" = /usr/bin/env
|
|
>@test -f "$$BASH_ENV"
|
|
>@test -n "$$GIT_EXEC_PATH"
|
|
>@case "$$PATH" in *';'*) exit 1;; esac
|
|
>@env printf '%s\n' 'Cygwin Make shell smoke passed'
|
|
MAKE_EOF
|
|
make --no-print-directory -f "$profile/smoke.mk" windows-make-shell-smoke
|
|
'@
|
|
$script = $script.Replace("`r`n", "`n")
|
|
& $bash --noprofile --norc -c $script
|
|
if ($LASTEXITCODE -ne 0) {
|
|
throw 'Cygwin Make shell smoke failed'
|
|
}
|
|
|
|
ci-gate:
|
|
name: CI Gate / Required
|
|
runs-on: ubuntu-latest
|
|
needs:
|
|
- build-artifacts
|
|
- check-build-tags
|
|
- check-cmd-bd-puregeo-tests
|
|
- test-windows-liveness
|
|
- worktree-remove-windows
|
|
- check-version-consistency
|
|
- check-migration-hygiene
|
|
- check-doc-flags
|
|
- check-doc-freshness-platforms
|
|
- pr-preflight-platforms
|
|
- check-no-beads-changes
|
|
- detect-package-gates
|
|
- package-mcp
|
|
- package-npm
|
|
- pr-policy-wrapper
|
|
- pr-core-wrapper
|
|
- pr-lint-wrapper
|
|
- test-domain-uow
|
|
- contract-corpus
|
|
- fmt-check
|
|
- lint
|
|
- windows-make-shell
|
|
if: ${{ always() }}
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v6
|
|
|
|
- name: Evaluate CI gate
|
|
env:
|
|
CI_GATE_NAME: PR baseline gate
|
|
CI_GATE_REQUIRED: >-
|
|
BUILD_ARTIFACTS
|
|
CHECK_BUILD_TAGS
|
|
CHECK_CMD_BD_PUREGEO_TESTS
|
|
TEST_WINDOWS_LIVENESS
|
|
WORKTREE_REMOVE_WINDOWS
|
|
CHECK_VERSION_CONSISTENCY
|
|
CHECK_MIGRATION_HYGIENE
|
|
CHECK_DOC_FLAGS
|
|
CHECK_DOC_FRESHNESS_PLATFORMS
|
|
PR_PREFLIGHT_PLATFORMS
|
|
CHECK_NO_BEADS_CHANGES
|
|
DETECT_PACKAGE_GATES
|
|
PACKAGE_MCP
|
|
PACKAGE_NPM
|
|
PR_POLICY_WRAPPER
|
|
PR_CORE_WRAPPER
|
|
PR_LINT_WRAPPER
|
|
TEST_DOMAIN_UOW
|
|
CONTRACT_CORPUS
|
|
FMT_CHECK
|
|
LINT
|
|
WINDOWS_MAKE_SHELL
|
|
BUILD_ARTIFACTS: ${{ needs.build-artifacts.result }}
|
|
CHECK_BUILD_TAGS: ${{ needs.check-build-tags.result }}
|
|
CHECK_CMD_BD_PUREGEO_TESTS: ${{ needs.check-cmd-bd-puregeo-tests.result }}
|
|
TEST_WINDOWS_LIVENESS: ${{ needs.test-windows-liveness.result }}
|
|
WORKTREE_REMOVE_WINDOWS: ${{ needs.worktree-remove-windows.result }}
|
|
CHECK_VERSION_CONSISTENCY: ${{ needs.check-version-consistency.result }}
|
|
CHECK_MIGRATION_HYGIENE: ${{ needs.check-migration-hygiene.result }}
|
|
CHECK_DOC_FLAGS: ${{ needs.check-doc-flags.result }}
|
|
CHECK_DOC_FRESHNESS_PLATFORMS: ${{ needs.check-doc-freshness-platforms.result }}
|
|
PR_PREFLIGHT_PLATFORMS: ${{ needs.pr-preflight-platforms.result }}
|
|
CHECK_NO_BEADS_CHANGES: ${{ needs.check-no-beads-changes.result }}
|
|
DETECT_PACKAGE_GATES: ${{ needs.detect-package-gates.result }}
|
|
PACKAGE_MCP: ${{ needs.package-mcp.result }}
|
|
PACKAGE_NPM: ${{ needs.package-npm.result }}
|
|
PR_POLICY_WRAPPER: ${{ needs.pr-policy-wrapper.result }}
|
|
PR_CORE_WRAPPER: ${{ needs.pr-core-wrapper.result }}
|
|
PR_LINT_WRAPPER: ${{ needs.pr-lint-wrapper.result }}
|
|
TEST_DOMAIN_UOW: ${{ needs.test-domain-uow.result }}
|
|
CONTRACT_CORPUS: ${{ needs.contract-corpus.result }}
|
|
FMT_CHECK: ${{ needs.fmt-check.result }}
|
|
LINT: ${{ needs.lint.result }}
|
|
WINDOWS_MAKE_SHELL: ${{ needs.windows-make-shell.result }}
|
|
run: |
|
|
skipped_ok=""
|
|
if [[ "$GITHUB_EVENT_NAME" == "merge_group" ]]; then
|
|
skipped_ok="CHECK_NO_BEADS_CHANGES"
|
|
fi
|
|
export CI_GATE_SKIPPED_OK="$skipped_ok"
|
|
bash .github/scripts/ci-gate.sh
|