beads/internal
matt wilkie f0adda46c6 fix: prevent silent fallback to embedded mode when shared-server is active (GH#2949)
Root cause: ResolveServerMode() and IsDoltServerMode() checked
metadata.json dolt_mode=embedded BEFORE runtime env vars, so stale
persisted metadata silently overrode active shared-server config.

Fixes:
- ResolveServerMode: env vars (BEADS_DOLT_SERVER_MODE, BEADS_DOLT_SHARED_SERVER)
  now checked before metadata.json, preventing stale embedded override
- IsDoltServerMode: now checks BEADS_DOLT_SHARED_SERVER env var (shared-server
  implies server-backed storage)
- warnSharedServerEmbeddedMismatch -> repairSharedServerEmbeddedMismatch:
  auto-repairs stale dolt_mode=embedded in metadata.json instead of just warning
- Added 6 regression tests covering the upgrade path

Closes #2949

Amp-Thread-ID: https://ampcode.com/threads/T-019d4b84-cddd-725a-a3c6-ee7e3631f2aa
Co-authored-by: Amp <amp@ampcode.com>
2026-04-01 17:21:17 -07:00
..
ado Merge pull request #2814 from harry-miller-trimble/feat/tracker-hardening-and-core 2026-03-30 20:41:05 -07:00
audit Enforce .beads/ directory permissions at runtime 2026-03-30 09:15:49 -07:00
beads fix(beads): detect embeddeddolt/ directory in database discovery (#2909) 2026-03-30 07:12:32 -07:00
compact fix(ci): get nightly full tests passing (#2835) 2026-03-26 09:52:03 -07:00
config feat: move hook firing into storage layer via decorator (#2891) 2026-03-31 14:32:01 -07:00
configfile fix: prevent silent fallback to embedded mode when shared-server is active (GH#2949) 2026-04-01 17:21:17 -07:00
debug chore: unexport 14 dead symbols across 8 packages 2026-02-07 09:24:22 -08:00
doltserver fix: prevent silent fallback to embedded mode when shared-server is active (GH#2949) 2026-04-01 17:21:17 -07:00
formula fix: include convoy-type formulas in bd formula list text output 2026-03-30 06:45:14 -07:00
git feat: add --list and --doc flags to bd help for CLI doc generation (GH#2527) 2026-03-11 18:25:40 -07:00
github lint: suppress gosec G404 for retry jitter (math/rand is fine for backoff) 2026-03-30 09:15:53 -07:00
gitlab fix: address PR review feedback 2026-03-30 09:15:55 -07:00
hooks fix: increase TestRun_Async polling timeout to 10s (bd-ldi) 2026-02-28 23:11:46 -08:00
idgen fix(idgen): correct test vectors in hash_test.go 2025-12-19 18:13:56 -08:00
jira fix: address PR review feedback 2026-03-30 09:15:55 -07:00
linear fix: address PR review feedback 2026-03-30 09:15:55 -07:00
lockfile chore: remove daemon infrastructure (lockfile, activity signal) (bd-9u8zd) 2026-02-18 19:05:31 -08:00
molecules /{cmd,internal}: update global store to be interface 2026-03-17 13:26:17 -07:00
notion feat: reimplement Notion sync on REST data sources (fix-merge PR #2759) 2026-03-27 19:20:40 -07:00
query fix: allow colons in unquoted query identifier values 2026-03-14 05:02:22 +00:00
recipes Enforce .beads/ directory permissions at runtime 2026-03-30 09:15:49 -07:00
remotecache feat: add remote URL support to multi-repo hydration (PR #2827) 2026-03-26 19:31:40 -07:00
routing Fix init leaving beads.role unset in edge cases (GH#2950) (#2964) 2026-04-01 17:21:17 -07:00
storage fix: add missing //go:build cgo tags to embedded test files and cmd 2026-04-01 07:08:41 -07:00
telemetry feat: add MergeSlot methods to Storage interface (fix-merge PR #2787) 2026-03-26 19:34:21 -07:00
templates/agents fix(init): replace 'bd onboard' references with 'bd prime' in AGENTS.md (#2902) 2026-03-30 10:42:50 -07:00
testutil /{go,internal}: bump driver and dolt version in tests 2026-03-26 11:52:40 -07:00
timeparsing chore: unexport 14 dead symbols across 8 packages 2026-02-07 09:24:22 -08:00
tracker fix: remove dead rig routing code and unused variable after rebase 2026-03-30 09:23:01 -07:00
types feat: support comma-separated status values in bd list --status (GH#2846) (#2929) 2026-03-31 12:49:20 -07:00
ui Merge pull request #2814 from harry-miller-trimble/feat/tracker-hardening-and-core 2026-03-30 20:41:05 -07:00
utils cleanup: remove daemon infrastructure remnants (GH#2431) 2026-03-10 15:24:27 -07:00
validation refactor: remove gastown/Gas Town string references from beads code and docs (bd-1ue8) 2026-03-20 18:39:50 -07:00