* fix(update): resolve metadata/note merges inside the mutation transaction bd update --metadata/--set-metadata/--unset-metadata/--append-notes and bd note resolved their merges client-side: read the issue in one transaction, merge in process memory, write the merged blob back in a later transaction. Two concurrent writers touching DIFFERENT keys of the SAME issue both exited 0, but the later commit silently erased the earlier writer's committed keys. The multiprocess-safety audit proved the loss empirically: 7 of 200 exit-0 --set-metadata writes vanished in an 8-writer same-issue hammer against the stock binary. The first version of this fix moved the merge into the mutation transaction on the direct path only; red-team review blocked it because the proxied-server route still snapshot-merged in buildUpdateSpecForIssue — and worse: on a Dolt serialization rollback, uow.CommitWithRetries retried only the COMMIT, re-committing the rolled-back (now empty) session. Dolt answered "nothing to commit", isDoltNothingToCommit swallowed it, and bd printed "Updated" and exited 0 for a write that never landed. This revision closes both paths: - Merge-shaped edits travel as operation keys (issueops.OpMergeMetadata, OpSetMetadata, OpUnsetMetadata, OpAppendNotes) and are resolved against the row re-read INSIDE the mutation transaction (issueops.ResolveMergeOps) — in both the embedded path (updateIssueInTx) and the domain/db repository used by proxied-server mode. CLI paths (bd update, bd note) no longer pre-merge; the shared merge helpers live in internal/storage. - The in-transaction read takes a row write lock (GetIssueForUpdateInTx, SELECT ... FOR UPDATE) so the read itself serializes on Postgres (READ COMMITTED) and MySQL (REPEATABLE READ). sqlitedialect strips the clause — safe because _txlock=immediate already takes the database write lock at BEGIN. Dolt parses FOR UPDATE as a no-op and relies on commit-time conflict detection plus the whole-attempt retry below. - The proxied server redoes the WHOLE read-merge-write attempt in a fresh unit of work on a serialization failure (new exported uow.IsSerializationError; exponential backoff, 15s budget), commits each attempt exactly once, and fails loudly to stderr when retries exhaust instead of exiting 0. Verification: cross-backend regression body in internal/storage/conformance/lostupdate.go (two independent store handles plus a lock-holding third pool) wired into the sqlite, dolt (embedded and sql-server), mysql, and postgres suites; cmd/bd multi-process race tests for --set-metadata and bd note; proxied-server attempt/retry unit tests. Re-running the audit hammer against the patched binary: 0 lost of 200 exit-0 writes across natural and lock-widened runs (stock binary lost writes in both), with the one contention exhaustion surfacing as a nonzero exit instead of a silent loss. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(update): string --set-metadata, proxied partial-failure exit, drop dead locking scaffolding Maintainer adoption-review fixes for PR #4732 (review iterations 1 and 3): - metadata: MetadataEditValue stores --set-metadata values as JSON strings again (GH#4146) instead of inferring numbers/booleans/null from content, which silently broke map[string]string round-trips. Typed values stay available via --metadata / --metadata-json. Domain merge-op tests now expect string values for --set-metadata. - cmd/bd: restore the proxied multi-ID partial-failure accumulator so a batch with any failed ID exits non-zero (had regressed #4726), and derive success output from the resolved jsonOutput signal so --format json and config json:true are honored on the proxied path. - storage: remove the dead internal/storage/sqlitedialect package (509 LOC, zero importers) and the FOR UPDATE / GetIssueForUpdateInTx row-locking scaffolding. SQLite/Postgres/MySQL are gone and Dolt treats FOR UPDATE as a parse-only no-op; the read-merge-write is made safe by commit-time conflict detection plus the whole-attempt retry. Also drop the uncalled MVCC-only conformance helper. updateIssueInTx returns to baseline complexity via a small read-and-resolve helper. - tests: remove the SQLite-backend race tests (the removed backend can't run them); Dolt concurrency coverage in uow/embeddeddolt/domain-db is load-bearing. - readability: split ResolveMergeOps into resolveMetadataMergeOps and resolveNotesAppendOp (with an isMergeOpKey helper) so each diff-authored merge-op resolver stays below the review complexity gate (cyclomatic <21 / cognitive <26). Pure structure change: same resolution order, error strings, schema validation, and copy-not-mutate semantics. - policy: allowlist TestUOW_ConcurrentMergeOps_NoLostUpdate in scripts/check-testing-short.sh. Its testing.Short() skip is a legitimate runtime/stress skip (it starts a Dolt container and a dbproxy subprocess), matching the other allowlisted Dolt concurrency stress tests; without the entry the ci-pr-policy check fails on the adopted head. - tests: remove the two obsolete cmd/bd multi-ID tests (TestMultiIDUpdatePartialMetadataMergeFailure and TestMultiIDUpdatePartialMetadataEditFailureJSON) and their now-unused seedNonObjectMetadata/showMultiIDUpdateMetadataValue helpers. They seeded a non-object array via `bd update --metadata "[]"` to force a later per-ID metadata-merge failure, but the new in-transaction merge correctly rejects non-object metadata ("new metadata is not a JSON object"), so that seeding path is unreachable and the tests now fail at setup. The four #4726 per-ID exit-code tests in the same file are retained. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Test User <test@test.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| bench-ready-indexes | ||
| ci | ||
| hooks | ||
| migration-test | ||
| repro-dolt-hang | ||
| repro-dolt-prod-timeouts | ||
| bump-version.sh | ||
| check-build-tags.sh | ||
| check-cli-docs-drift.sh | ||
| check-doc-flags.sh | ||
| check-doc-freshness.sh | ||
| check-go-install-guidance.sh | ||
| check-migration-hygiene.sh | ||
| check-testing-short.sh | ||
| check-versions.sh | ||
| clean-test-tmp.sh | ||
| conformance.sh | ||
| cross-version-smoke-test.sh | ||
| docs-autofix-push.sh | ||
| docs.md | ||
| gen-winres.sh | ||
| generate-cli-docs.sh | ||
| generate-newsletter.py | ||
| generate-newsletter_README.md | ||
| gh-body-lint | ||
| install-hooks.sh | ||
| install.sh | ||
| migrate-jsonl-to-dolt.sh | ||
| migrate-sqlite-to-current.sh | ||
| pr-preflight.sh | ||
| pr_preflight_test.go | ||
| README.md | ||
| release.sh | ||
| release_script_test.go | ||
| resolve-docs-bd.sh | ||
| sign-windows.sh | ||
| test-cgo.sh | ||
| test-git-remote.sh | ||
| test-icu-path.sh | ||
| test.sh | ||
| update-nix-vendorhash.sh | ||
| update-versions.sh | ||
| update-winget.sh | ||
| upgrade-smoke-test.sh | ||
| verify-cgo.sh | ||
Beads Scripts
Utility scripts for maintaining the beads project.
ci/
Repository-owned CI command wrappers. These scripts are the source of truth for the target CI tiers; Make targets are aliases for local discoverability.
make ci-pr-core
make ci-pr-policy
make ci-pr-lint
make ci-package-mcp
make ci-package-npm
Each wrapper auto-detects the repository root, sources .buildflags when it
invokes Go in the default build mode, and records per-command timing through
scripts/ci/lib/timing.sh.
Broad Go test wrappers also source scripts/ci/lib/test-env.sh, which creates a
temporary HOME/XDG/Dolt root, isolates Git global/system config, clears runtime
Beads/Dolt environment variables, and sets BEADS_TEST_SKIP=dolt before tests
run. This keeps local make test and make ci-pr-core results comparable to
the fast PR-core contract even on shared agent hosts. Set
BEADS_TEST_ENV_RUN_DOLT=1 only when intentionally running the Dolt-dependent
tests through these broad wrappers, or BEADS_TEST_ENV_DISABLE=1 when debugging
against your real local configuration.
The broad Go wrappers also cap package and test parallelism to 4 by default
(GO_TEST_PKG_PARALLEL and GO_TEST_PARALLEL). This avoids turning high-core
shared hosts into a different test topology than GitHub Actions.
make ci-pr-policy includes scripts/check-testing-short.sh, which enforces
that testing.Short() is only used for runtime, stress, or large-fixture skips.
Use build tags, environment checks, or named wrappers for integration/e2e/API
boundaries.
Package gate wrappers validate publishable/package-adjacent surfaces:
make ci-package-mcpbuilds or consumes abdbinary, puts it onPATHasbd, then runs locked MCP packageuv sync, Ruff, mypy, pytest, and build checks.make ci-package-npmbuilds or consumes the native binary expected bynpm-package/bin/bd, runs the npm package test suite, and checksnpm pack --dry-run.
Set BEADS_TEST_BD_BINARY=/path/to/bd for MCP and npm package gates to reuse a
prebuilt candidate binary instead of rebuilding it inside the wrapper.
pr-preflight.sh
Read-only PR safety check for agents and maintainers.
# Before implementing or opening a related PR
./scripts/pr-preflight.sh --search "topic keywords" --repo gastownhall/beads
# Before changing, closing, or merging an existing PR
./scripts/pr-preflight.sh 123 --repo gastownhall/beads
It reports contributor/fork status, draft/review/merge/check state, risky diff
signals such as .beads/ changes or missing tests, and the required
contributor-protection next steps. It does not replace code review or local
validation.
gh-body-lint
Lint Markdown files before posting them with gh ... --body-file.
./scripts/gh-body-lint body.md
./scripts/gh-body-lint --fix body.md
The lint catches literal \n sequences, which render poorly on GitHub, and
GH#123 references, which do not auto-link like #123 or owner/repo#123.
release.sh (⭐ The Easy Button)
One-command release from version bump to local installation.
Usage
# Full release (does everything)
./scripts/release.sh 0.9.3
# Preview what would happen
./scripts/release.sh 0.9.3 --dry-run
What It Does
This master script automates the entire release process:
- ✅ Stops running Dolt servers (avoids version conflicts)
- ✅ Runs tests and linting
- ✅ Bumps version in all files
- ✅ Commits and pushes version bump
- ✅ Creates and pushes git tag
- ✅ Verifies or opens the Homebrew core formula PR
- ✅ Upgrades local Homebrew installation
- ✅ Verifies everything works
After this script completes, your system is running the new version!
Examples
# Release version 0.9.3
./scripts/release.sh 0.9.3
# Preview a release (no changes made)
./scripts/release.sh 1.0.0 --dry-run
Prerequisites
- Clean git working directory
- All changes committed
- golangci-lint installed
- Homebrew installed (for local upgrade)
- Push access to gastownhall/beads
Output
The script provides colorful, step-by-step progress output:
- 🟨 Yellow: Current step
- 🟩 Green: Step completed
- 🟥 Red: Errors
- 🟦 Blue: Section headers
What Happens Next
After the script finishes:
- GitHub Actions builds binaries for all platforms (~5 minutes)
- PyPI package is published automatically
- Homebrew core formula is verified or tracked through its canonical PR
- Users can
brew upgrade beadsto get the new version after Homebrew merges - GitHub Release is created with binaries and changelog
bump-version.sh
Bumps the version number across all beads components in a single command.
Usage
# Show usage
./scripts/bump-version.sh
# Update versions (shows diff, no commit)
./scripts/bump-version.sh 0.9.3
# Update versions and auto-commit
./scripts/bump-version.sh 0.9.3 --commit
What It Does
Updates version in all these files:
cmd/bd/version.go- bd CLI version constantplugins/beads/.claude-plugin/plugin.json- Claude plugin versionplugins/beads/.codex-plugin/plugin.json- Codex plugin version.claude-plugin/marketplace.json- Claude marketplace plugin versionintegrations/beads-mcp/pyproject.toml- MCP server versionREADME.md- Alpha status versionPLUGIN.md- Version requirements
Features
- Validates semantic versioning format (MAJOR.MINOR.PATCH)
- Verifies all versions match after update
- Shows git diff of changes
- Auto-commits with standardized message (optional)
- Cross-platform compatible (macOS and Linux)
Examples
# Bump to 0.9.3 and review changes
./scripts/bump-version.sh 0.9.3
# Review the diff, then manually commit
# Bump to 1.0.0 and auto-commit
./scripts/bump-version.sh 1.0.0 --commit
git push origin main
Why This Script Exists
Previously, version bumps only updated cmd/bd/version.go, leaving other components out of sync. This script ensures all version numbers stay consistent across the project.
Safety
- Checks for uncommitted changes before proceeding
- Refuses to auto-commit if there are existing uncommitted changes
- Validates version format before making any changes
- Verifies all versions match after update
- Shows diff for review before commit
sign-windows.sh
Signs Windows executables with an Authenticode certificate using osslsigncode.
Usage
# Sign a Windows executable
./scripts/sign-windows.sh path/to/bd.exe
# Environment variables required for signing:
export WINDOWS_SIGNING_CERT_PFX_BASE64="<base64-encoded-pfx>"
export WINDOWS_SIGNING_CERT_PASSWORD="<certificate-password>"
What It Does
This script is called automatically by GoReleaser during the release process:
- Decodes the PFX certificate from base64
- Signs the Windows executable using osslsigncode
- Timestamps the signature using DigiCert's RFC3161 server
- Replaces the original binary with the signed version
- Verifies the signature was applied correctly
Prerequisites
osslsigncodeinstalled (apt install osslsigncodeorbrew install osslsigncode)- EV code signing certificate exported as PFX file
- GitHub secrets configured:
WINDOWS_SIGNING_CERT_PFX_BASE64- base64-encoded PFX fileWINDOWS_SIGNING_CERT_PASSWORD- certificate password
Graceful Degradation
If the signing secrets are not configured:
- The script prints a warning and exits successfully
- GoReleaser continues without signing
- The release proceeds with unsigned Windows binaries
This allows releases to work before a certificate is acquired.
Why This Script Exists
Windows code signing helps reduce antivirus false positives that affect Go binaries.
Kaspersky and other AV software commonly flag unsigned Go executables as potentially
malicious due to heuristic detection. See docs/reference/antivirus.md for details.
Future Scripts
Additional maintenance scripts may be added here as needed.