Maintainer review fixups for #6731. The review found no blocker and no major;
these are its two gate-impact minors plus two nearby nits.
- externaldeps.Store.ReadyCounter built a fresh store-backed counter, so the
documented storage.ReadyCounter.CountReady span stopped being emitted for
every text-mode `bd ready` in the cmd/bd chain (hooks -> externaldeps ->
telemetry -> store). PR-introduced: at base this decorator had no
ReadyCounter at all, so the embedded passthrough reached the instrumented
layer -- and this PR edits the very otel document that lists the span. The
accessor cannot simply recurse, because the exclusions live on this store, so
it now hands the finished counter to the inner store's WrapReadyCounter,
which telemetry already exported for exactly this case and had no caller for.
Pinned by TestExternalDepsReadyCounterSurvivesThisLayer, which fails with the
old body (verified by reverting it).
- CHANGELOG: GetReadyWorkWithCountsAndTotal is a new REQUIRED storage.Storage
method with no optional-interface fallback, so an out-of-tree `backends`
registrant stops compiling on upgrade. The entry names the method, the
contract an implementer owes, and why the compile-time posture is deliberate.
- The ready probe's facts now record each index as its column is appended.
Two conditional columns were read back through a mix of literals and a
computed `next`, so the two conventions disagreed inside one function and a
future column inserted above would silently mis-read a different fact.
Behavior-identical; the four excludeDeferred x wantCollision combinations are
covered by the embedded filter matrix.
- The combined family count wraps as `count ready work: issues+wisps:`, so it
is distinguishable from the issues-only retry beneath it, and
storereadycounter's package doc no longer claims only two importers.
Validation: go build ./...; go vet and go test on issueops, externaldeps,
telemetry; BEADS_TEST_EMBEDDED_DOLT=1 TestReadyWorkPageTotal,
TestReadyWorkPageTotalFilterMatrix, TestReadyWorkStatementBudget
(embeddeddolt) and TestEmbeddedReady (cmd/bd).
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>