beads/internal/workapi
Julian Knutsen a1bc167b54
fix(ready): keep the ReadyCounter span through externaldeps, and announce the interface break (#6748)
Maintainer review fixups for #6731. The review found no blocker and no major;
these are its two gate-impact minors plus two nearby nits.

- externaldeps.Store.ReadyCounter built a fresh store-backed counter, so the
  documented storage.ReadyCounter.CountReady span stopped being emitted for
  every text-mode `bd ready` in the cmd/bd chain (hooks -> externaldeps ->
  telemetry -> store). PR-introduced: at base this decorator had no
  ReadyCounter at all, so the embedded passthrough reached the instrumented
  layer -- and this PR edits the very otel document that lists the span. The
  accessor cannot simply recurse, because the exclusions live on this store, so
  it now hands the finished counter to the inner store's WrapReadyCounter,
  which telemetry already exported for exactly this case and had no caller for.
  Pinned by TestExternalDepsReadyCounterSurvivesThisLayer, which fails with the
  old body (verified by reverting it).

- CHANGELOG: GetReadyWorkWithCountsAndTotal is a new REQUIRED storage.Storage
  method with no optional-interface fallback, so an out-of-tree `backends`
  registrant stops compiling on upgrade. The entry names the method, the
  contract an implementer owes, and why the compile-time posture is deliberate.

- The ready probe's facts now record each index as its column is appended.
  Two conditional columns were read back through a mix of literals and a
  computed `next`, so the two conventions disagreed inside one function and a
  future column inserted above would silently mis-read a different fact.
  Behavior-identical; the four excludeDeferred x wantCollision combinations are
  covered by the embedded filter matrix.

- The combined family count wraps as `count ready work: issues+wisps:`, so it
  is distinguishable from the issues-only retry beneath it, and
  storereadycounter's package doc no longer claims only two importers.

Validation: go build ./...; go vet and go test on issueops, externaldeps,
telemetry; BEADS_TEST_EMBEDDED_DOLT=1 TestReadyWorkPageTotal,
TestReadyWorkPageTotalFilterMatrix, TestReadyWorkStatementBudget
(embeddeddolt) and TestEmbeddedReady (cmd/bd).

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-25 13:53:47 -07:00
..
storecounter Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
storequerier Converge Offset and MaxRows on all three legs, and fix the panic and the breaker hole under them (#5435) 2026-08-08 11:37:09 -07:00
storereader feat(workapi): opt-in BriefDeps projection for the issue detail view (#5547) 2026-08-10 06:51:41 -07:00
storereadycounter fix(ready): keep the ReadyCounter span through externaldeps, and announce the interface break (#6748) 2026-09-25 13:53:47 -07:00
storestats Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
storeversionreconciler Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
storeworkspaceconfig Refuse kv.* point reads on the settings role and stop printing them (#5493) 2026-08-09 11:06:51 -07:00
testdata fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
bootstrap.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
bootstrap_test.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
count.go feat(count): support --metadata-field filtering (#6024) 2026-09-02 17:25:57 -07:00
count_test.go feat(count): support --metadata-field filtering (#6024) 2026-09-02 17:25:57 -07:00
delete.go Add DeleteRequest.ExpectedVersion: a compare-and-delete on the named row (#5481) 2026-08-09 07:17:54 -07:00
delete_test.go Add DeleteRequest.ExpectedVersion: a compare-and-delete on the named row (#5481) 2026-08-09 07:17:54 -07:00
detail.go feat(workapi): opt-in BriefDeps projection for the issue detail view (#5547) 2026-08-10 06:51:41 -07:00
detail_test.go fix(contracts): JSON contract fixes before 1.3.0 freezes them — string revision tokens, --set-metadata scalar typing, create --json nano timestamps (#6053) 2026-08-29 05:20:27 +00:00
doc.go refactor(show): share issue-detail assembly and normalize not-found (bd-hc1) 2026-07-31 07:58:46 +00:00
list.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
list_ephemeral_test.go Admit the ephemeral plane from a list request, on the facade and on the wire (#5476) 2026-08-09 05:06:36 -07:00
list_golden_test.go fix(human): respond/dismiss text sources, bd list parity, and proxied-server support (#5333) 2026-08-10 05:36:11 -07:00
list_keyset_test.go feat(httpapi): serve bd list's order with sort on listIssues (#5666) 2026-08-27 09:21:12 -07:00
list_pinned_test.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
list_ready_status_test.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
list_status_test.go refactor(list): route both bd list paths through internal/workapi and delete list_filter.go (bd-fv4) 2026-07-31 06:01:48 +00:00
metadata.go fix(workapi): refuse an invalid metadata key where the builders can name it 2026-07-31 18:37:25 +00:00
page.go Converge Offset and MaxRows on all three legs, and fix the panic and the breaker hole under them (#5435) 2026-08-08 11:37:09 -07:00
page_test.go docs(workapi): say where the shared epilogue stops, and what limit 0 does 2026-07-31 23:35:16 +00:00
query.go Merge branch 'facade/wave-3' into facade/wave-4 2026-08-06 21:39:05 +00:00
query_test.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
race_detector_off_test.go feat(issueops): put bd purge and bd prune behind the Sweeper role (bd-pn231) 2026-08-05 16:40:26 +00:00
race_detector_on_test.go feat(issueops): put bd purge and bd prune behind the Sweeper role (bd-pn231) 2026-08-05 16:40:26 +00:00
ready.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
ready_count_test.go feat(workapi,storage): opt-in Brief projection for the list and ready pages (#5554) 2026-08-10 10:45:23 -07:00
ready_golden_test.go fix(deps): enforce external capability blockers across ready/claim/close (#4769) (#4753) 2026-09-02 16:56:23 -07:00
ready_test.go feat(issueops): add the Reader role and wire both front doors through it 2026-07-31 18:37:25 +00:00
release.go Add issueops.Releaser: give a claim back, optionally only a named holder's (#5482) 2026-08-09 07:48:56 -07:00
release_test.go Add issueops.Releaser: give a claim back, optionally only a named holder's (#5482) 2026-08-09 07:48:56 -07:00
sort.go fix(list): honor --status when combined with --ready (#5924) 2026-09-02 18:12:07 -07:00
stats.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
stats_test.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
sweep.go fix(sweep): purge/prune select candidates by tier — a typed wisp is ephemeral however it was minted (#5995) 2026-08-27 05:06:50 -07:00
sweep_test.go fix(sweep): purge/prune select candidates by tier — a typed wisp is ephemeral however it was minted (#5995) 2026-08-27 05:06:50 -07:00
versionreconcile.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
versionreconcile_test.go Trim this series' comments toward the repo's own density 2026-08-06 08:06:59 +00:00
workspaceconfig.go docs: the ext-api-store documentation tranche — post-#5516 auth sweep, wave doc coherence, role checklist refresh (#5545) 2026-08-10 08:05:07 -07:00
workspaceconfig_test.go Refuse kv.* point reads on the settings role and stop printing them (#5493) 2026-08-09 11:06:51 -07:00