* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) Lint and vet now run as nogo inside the Bazel build, so they gate wherever the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs leave pr.yml and main.yml. - //tools/nogo (own go.mod, joined to beads' for go_deps only through gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml enables, each a wrapper over the library version golangci-lint v2.10.1 uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert, unparam). - .golangci.yml stays the single lint policy: Bazel embeds it and tools/nogo/internal/golangci applies it as golangci-lint does (enabled set, settings, run.tests: false as library-unit-only analysis, lax generated-file detection, path/path-except/text exclusion rules), with strict decoding so an unimplemented key fails the build. - gascity's rules_go //nolint-range patch and x/tools ctrlflow patch, byte-identical. - Windows/darwin: cross-configured, not a golangci leg. The pure lane's release cross-compile (//tools/bazel:release_cross, every library and binary for all eight release platforms, cgo off) runs nogo on every compile, a superset of golangci-lint's windows and darwin legs. scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64. release_cross skips tools/nogo, a separate Go module `go build ./...` never compiled. - pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache. scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted. - pre-commit hook and .pre-commit-config.yaml run `make lint-changed LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds lint, vet and lint-changed. pr-lint.sh no longer runs gofmt (//scripts/repochecks:fmt_test owns it; ga-96smfk.41). - internal/testutil/integration: five gosec findings in integration-tagged library files golangci-lint never built, now linted by the integration lanes, carry reasoned //nolint directives. Parity: with the exclusion rules removed, golangci-lint and nogo report the same 3,916 findings natively and 3,859 each for windows and darwin (file, line, linter, text); with .golangci.yml as committed both report none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set tools/nogo is its own Go module, so `go test ./...` in the root never runs its tests; Bazel's unit lane does. Its packages are neither expected nor extra. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
86 lines
3.4 KiB
Bash
Executable file
86 lines
3.4 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# Pre-commit hook: auto-format with gofmt, then lint and vet with nogo.
|
|
# Installed via: git config core.hooksPath .githooks
|
|
# See also: make install (sets hooksPath automatically)
|
|
|
|
set -euo pipefail
|
|
|
|
# Only check staged Go files (Added, Copied, Modified). No early exit here:
|
|
# the beads section at the bottom must run for non-Go commits too.
|
|
staged_go_files=$(git diff --cached --name-only --diff-filter=ACM -- '*.go')
|
|
if [ -n "$staged_go_files" ]; then
|
|
# Auto-format and re-stage, through the go.mod-pinned gofmt. A bare PATH
|
|
# gofmt belongs to the host toolchain, and on a host newer than the go
|
|
# directive it rewrites and re-stages files into a form CI's gofmt rejects
|
|
# -- silently, on every Go commit. See scripts/ci/gofmt-bin.sh.
|
|
gofmt_bin="$(./scripts/ci/gofmt-bin.sh)"
|
|
echo "$staged_go_files" | xargs "$gofmt_bin" -w
|
|
echo "$staged_go_files" | xargs git add
|
|
|
|
# Lint and vet: nogo (//tools/nogo) over the staged files' Bazel packages,
|
|
# the analyzers bazel.yml gates on (go test's vet checks plus the
|
|
# golangci-lint linters .golangci.yml enables). Findings fail the commit;
|
|
# nogo prints a `patch -p1` command for the ones with suggested fixes.
|
|
# Needs bazel (or bazelisk) on PATH; the windows/darwin passes run in CI
|
|
# and in `make lint`.
|
|
make lint-changed LINT_CHANGED_SCOPE=staged || exit 1
|
|
fi
|
|
|
|
# --- BEGIN BEADS INTEGRATION v1.3.0 ---
|
|
# This section is managed by beads. Do not remove these markers.
|
|
if command -v bd >/dev/null 2>&1; then
|
|
export BD_GIT_HOOK=1
|
|
_bd_timeout=${BEADS_HOOK_TIMEOUT:-300}
|
|
case "$_bd_timeout" in
|
|
*[!0-9]*|'') _bd_timeout_invalid=1 ;;
|
|
*[1-9]*) _bd_timeout_invalid=0 ;;
|
|
*) _bd_timeout_invalid=1 ;;
|
|
esac
|
|
if [ "$_bd_timeout_invalid" -eq 1 ]; then
|
|
echo >&2 "beads: invalid BEADS_HOOK_TIMEOUT; using 300 seconds"
|
|
_bd_timeout=300
|
|
fi
|
|
_bd_timeout_backend=none
|
|
_bd_timeout_command=
|
|
for _bd_timeout_candidate in timeout gtimeout; do
|
|
if command -v "$_bd_timeout_candidate" >/dev/null 2>&1; then
|
|
if _bd_timeout_version="$("$_bd_timeout_candidate" --version 2>/dev/null)"; then
|
|
case "$_bd_timeout_version" in
|
|
"timeout (GNU coreutils) "*|"timeout (uutils coreutils) "*) _bd_timeout_command=$_bd_timeout_candidate; break ;;
|
|
esac
|
|
fi
|
|
fi
|
|
done
|
|
if [ -n "$_bd_timeout_command" ]; then
|
|
_bd_timeout_backend=coreutils
|
|
if "$_bd_timeout_command" -- "$_bd_timeout" bd hooks run pre-commit "$@"; then
|
|
_bd_exit=0
|
|
else
|
|
_bd_exit=$?
|
|
fi
|
|
elif command -v perl >/dev/null 2>&1; then
|
|
_bd_timeout_backend=perl
|
|
if perl -e 'alarm shift; exec @ARGV' -- "$_bd_timeout" bd hooks run pre-commit "$@"; then
|
|
_bd_exit=0
|
|
else
|
|
_bd_exit=$?
|
|
fi
|
|
else
|
|
echo >&2 "beads: hook 'pre-commit' running without timeout; install coreutils or perl to enable BEADS_HOOK_TIMEOUT"
|
|
if bd hooks run pre-commit "$@"; then
|
|
_bd_exit=0
|
|
else
|
|
_bd_exit=$?
|
|
fi
|
|
fi
|
|
if { [ "$_bd_timeout_backend" = coreutils ] && [ "$_bd_exit" -eq 124 ]; } || { [ "$_bd_timeout_backend" = perl ] && [ "$_bd_exit" -eq 142 ]; }; then
|
|
echo >&2 "beads: hook 'pre-commit' timed out after ${_bd_timeout}s — continuing without beads"
|
|
_bd_exit=0
|
|
fi
|
|
if [ "$_bd_exit" -eq 3 ]; then
|
|
echo >&2 "beads: database not initialized — skipping hook 'pre-commit'"
|
|
_bd_exit=0
|
|
fi
|
|
if [ "$_bd_exit" -ne 0 ]; then exit "$_bd_exit"; fi
|
|
fi
|
|
# --- END BEADS INTEGRATION v1.3.0 ---
|