beads/.github/workflows
Julian Knutsen a4509deb2d
ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341)
* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18)

Lint and vet now run as nogo inside the Bazel build, so they gate wherever
the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs
leave pr.yml and main.yml.

- //tools/nogo (own go.mod, joined to beads' for go_deps only through
  gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set
  scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml
  enables, each a wrapper over the library version golangci-lint v2.10.1
  uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert,
  unparam).
- .golangci.yml stays the single lint policy: Bazel embeds it and
  tools/nogo/internal/golangci applies it as golangci-lint does (enabled
  set, settings, run.tests: false as library-unit-only analysis, lax
  generated-file detection, path/path-except/text exclusion rules), with
  strict decoding so an unimplemented key fails the build.
- gascity's rules_go //nolint-range patch and x/tools ctrlflow patch,
  byte-identical.
- Windows/darwin: cross-configured, not a golangci leg. The pure lane's
  release cross-compile (//tools/bazel:release_cross, every library and
  binary for all eight release platforms, cgo off) runs nogo on every
  compile, a superset of golangci-lint's windows and darwin legs.
  scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build
  --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64.
  release_cross skips tools/nogo, a separate Go module `go build ./...`
  never compiled.
- pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with
  their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache.
  scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted.
- pre-commit hook and .pre-commit-config.yaml run `make lint-changed
  LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds
  lint, vet and lint-changed. pr-lint.sh no longer runs gofmt
  (//scripts/repochecks:fmt_test owns it; ga-96smfk.41).
- internal/testutil/integration: five gosec findings in integration-tagged
  library files golangci-lint never built, now linted by the integration
  lanes, carry reasoned //nolint directives.

Parity: with the exclusion rules removed, golangci-lint and nogo report the
same 3,916 findings natively and 3,859 each for windows and darwin (file,
line, linter, text); with .golangci.yml as committed both report none.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set

tools/nogo is its own Go module, so `go test ./...` in the root never runs
its tests; Bazel's unit lane does. Its packages are neither expected nor
extra.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-07 05:17:22 +00:00
..
bazel-autofix.yml ci: autofix pushes with the gastownhall-autofix App token (no more approve-and-run) (#7215) 2026-10-04 21:27:06 -07:00
bazel-farm.yml ci(bazel): use client-id for the rbe-prewarm app token; drop local plan paths (#7164) 2026-10-03 23:03:41 -07:00
bazel.yml ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341) 2026-10-07 05:17:22 +00:00
ci-measurements.yml ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341) 2026-10-07 05:17:22 +00:00
close-stale-needs.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
deploy-pages-redirect.yml build(deps): bump actions/checkout from 7.0.0 to 7.0.1 (#5016) 2026-07-25 08:52:22 -07:00
docs-autofix.yml ci: autofix pushes with the gastownhall-autofix App token (no more approve-and-run) (#7215) 2026-10-04 21:27:06 -07:00
docs-mintlify.yml ci(bazel): run the conformance e2e tier under Bazel; retire conformance.yml and the docs-mintlify docsync job (#7321) 2026-10-06 22:42:25 +00:00
main.yml ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341) 2026-10-07 05:17:22 +00:00
nightly.yml ci: merge-queue readiness for the required gates; cache test results (fresh nightly) (#7264) 2026-10-05 13:54:15 -07:00
nix-build.yml ci: advisory workflows on Blacksmith with restore-only caches, folded matrices, path filters (F7c) (#7147) 2026-10-03 16:03:39 -07:00
pr-risk.yml ci(bazel): cover fork and Dependabot PRs with the Bazel lanes (BAZEL_COVERS_FORKS=true) (#7315) 2026-10-06 20:51:59 +00:00
pr.yml ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341) 2026-10-07 05:17:22 +00:00
release.yml fix: make release-version checks shell-free (#5614) 2026-10-01 07:46:37 -07:00
remove-needs-info.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
remove-needs-triage.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
request-needs-info.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
test-pypi.yml build(deps): bump the actions group across 1 directory with 3 updates (#5059) 2026-07-25 19:05:02 -07:00
triage-label.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
update-flake-lock.yml chore(deps): bump DeterminateSystems/determinate-nix-action (#6042) 2026-09-02 17:41:12 -07:00
update-vendor-hash.yml ci: advisory workflows on Blacksmith with restore-only caches, folded matrices, path filters (F7c) (#7147) 2026-10-03 16:03:39 -07:00