beads/internal/testutil/integration/diagnostics.go
Julian Knutsen a4509deb2d
ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341)
* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18)

Lint and vet now run as nogo inside the Bazel build, so they gate wherever
the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs
leave pr.yml and main.yml.

- //tools/nogo (own go.mod, joined to beads' for go_deps only through
  gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set
  scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml
  enables, each a wrapper over the library version golangci-lint v2.10.1
  uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert,
  unparam).
- .golangci.yml stays the single lint policy: Bazel embeds it and
  tools/nogo/internal/golangci applies it as golangci-lint does (enabled
  set, settings, run.tests: false as library-unit-only analysis, lax
  generated-file detection, path/path-except/text exclusion rules), with
  strict decoding so an unimplemented key fails the build.
- gascity's rules_go //nolint-range patch and x/tools ctrlflow patch,
  byte-identical.
- Windows/darwin: cross-configured, not a golangci leg. The pure lane's
  release cross-compile (//tools/bazel:release_cross, every library and
  binary for all eight release platforms, cgo off) runs nogo on every
  compile, a superset of golangci-lint's windows and darwin legs.
  scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build
  --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64.
  release_cross skips tools/nogo, a separate Go module `go build ./...`
  never compiled.
- pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with
  their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache.
  scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted.
- pre-commit hook and .pre-commit-config.yaml run `make lint-changed
  LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds
  lint, vet and lint-changed. pr-lint.sh no longer runs gofmt
  (//scripts/repochecks:fmt_test owns it; ga-96smfk.41).
- internal/testutil/integration: five gosec findings in integration-tagged
  library files golangci-lint never built, now linted by the integration
  lanes, carry reasoned //nolint directives.

Parity: with the exclusion rules removed, golangci-lint and nogo report the
same 3,916 findings natively and 3,859 each for windows and darwin (file,
line, linter, text); with .golangci.yml as committed both report none.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set

tools/nogo is its own Go module, so `go test ./...` in the root never runs
its tests; Bazel's unit lane does. Its packages are neither expected nor
extra.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-07 05:17:22 +00:00

88 lines
2.3 KiB
Go

//go:build integration && !windows
package integration
import (
"fmt"
"os"
"path/filepath"
"strings"
"testing"
)
// Diagnostics captures state information for debugging test failures.
type Diagnostics struct {
t *testing.T
beadsDir string
}
// NewDiagnostics creates a diagnostics collector for the given .beads directory.
func NewDiagnostics(t *testing.T, beadsDir string) *Diagnostics {
return &Diagnostics{t: t, beadsDir: beadsDir}
}
// CaptureOnFailure registers a t.Cleanup that dumps diagnostic info if the
// test has failed. Call early in the test setup.
func (d *Diagnostics) CaptureOnFailure() {
d.t.Helper()
d.t.Cleanup(func() {
if !d.t.Failed() {
return
}
d.t.Log("=== DIAGNOSTICS (test failed) ===")
d.dumpStateFiles()
d.dumpProcessList()
})
}
// dumpStateFiles logs the content of PID and port files if they exist.
func (d *Diagnostics) dumpStateFiles() {
for _, name := range []string{"dolt-server.pid", "dolt-server.port", "dolt-server.log"} {
path := filepath.Join(d.beadsDir, name)
data, err := os.ReadFile(path) //nolint:gosec // G304: a fixed state-file name under the test's own .beads dir
if err != nil {
d.t.Logf(" %s: not found", name)
continue
}
content := strings.TrimSpace(string(data))
if len(content) > 500 {
content = content[:500] + "... (truncated)"
}
d.t.Logf(" %s: %s", name, content)
}
}
// dumpProcessList logs any dolt processes visible via /proc or ps.
func (d *Diagnostics) dumpProcessList() {
entries, err := os.ReadDir("/proc")
if err != nil {
d.t.Log(" /proc: not available")
return
}
var doltProcs []string
for _, entry := range entries {
if !entry.IsDir() {
continue
}
// Only numeric directories (PIDs).
pid := entry.Name()
if pid[0] < '0' || pid[0] > '9' {
continue
}
cmdline, err := os.ReadFile(filepath.Join("/proc", pid, "cmdline")) //nolint:gosec // G304: /proc/<numeric pid>/cmdline
if err != nil {
continue
}
if strings.Contains(string(cmdline), "dolt") {
doltProcs = append(doltProcs, fmt.Sprintf("PID %s: %s", pid, strings.ReplaceAll(string(cmdline), "\x00", " ")))
}
}
if len(doltProcs) == 0 {
d.t.Log(" dolt processes: none found")
} else {
d.t.Logf(" dolt processes (%d):", len(doltProcs))
for _, p := range doltProcs {
d.t.Logf(" %s", p)
}
}
}