beads/scripts/embedded_shard_count_test.go
Julian Knutsen a4509deb2d
ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341)
* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18)

Lint and vet now run as nogo inside the Bazel build, so they gate wherever
the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs
leave pr.yml and main.yml.

- //tools/nogo (own go.mod, joined to beads' for go_deps only through
  gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set
  scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml
  enables, each a wrapper over the library version golangci-lint v2.10.1
  uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert,
  unparam).
- .golangci.yml stays the single lint policy: Bazel embeds it and
  tools/nogo/internal/golangci applies it as golangci-lint does (enabled
  set, settings, run.tests: false as library-unit-only analysis, lax
  generated-file detection, path/path-except/text exclusion rules), with
  strict decoding so an unimplemented key fails the build.
- gascity's rules_go //nolint-range patch and x/tools ctrlflow patch,
  byte-identical.
- Windows/darwin: cross-configured, not a golangci leg. The pure lane's
  release cross-compile (//tools/bazel:release_cross, every library and
  binary for all eight release platforms, cgo off) runs nogo on every
  compile, a superset of golangci-lint's windows and darwin legs.
  scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build
  --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64.
  release_cross skips tools/nogo, a separate Go module `go build ./...`
  never compiled.
- pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with
  their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache.
  scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted.
- pre-commit hook and .pre-commit-config.yaml run `make lint-changed
  LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds
  lint, vet and lint-changed. pr-lint.sh no longer runs gofmt
  (//scripts/repochecks:fmt_test owns it; ga-96smfk.41).
- internal/testutil/integration: five gosec findings in integration-tagged
  library files golangci-lint never built, now linted by the integration
  lanes, carry reasoned //nolint directives.

Parity: with the exclusion rules removed, golangci-lint and nogo report the
same 3,916 findings natively and 3,859 each for windows and darwin (file,
line, linter, text); with .golangci.yml as committed both report none.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set

tools/nogo is its own Go module, so `go test ./...` in the root never runs
its tests; Bazel's unit lane does. Its packages are neither expected nor
extra.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-07 05:17:22 +00:00

98 lines
4.5 KiB
Go

package scripts_test
import (
"os/exec"
"regexp"
"strconv"
"testing"
)
// shardCountPattern matches a rule block's ` shard_count = N,` line, the
// same pattern bazelProxiedShardCount (scripts/ci_workflow_test.go) inlines
// for its own single use; shared here since both embedded accessors below
// need it.
var shardCountPattern = regexp.MustCompile(`(?m)^ shard_count = (\d+),$`)
// bazelEmbeddedCmdShardCount returns cmd/bd:bd_embedded_test's own
// shard_count from cmd/bd/BUILD.bazel: the single source of truth for the
// Bazel-only bazel-embedded lane's cmd/bd shard split (slice F1), which no
// longer has to equal PR Risk's/main.yml's legacy "Test (Embedded Dolt Cmd
// N/20)" fork/push jobs' matrix size — mirrors bazelProxiedShardCount (F2;
// see that function's doc comment in scripts/ci_workflow_test.go for the
// shared rationale, not repeated here).
func bazelEmbeddedCmdShardCount(t *testing.T) int {
t.Helper()
root := sourceRepoRoot(t)
rule := bazelRuleBlock(readPolicyFile(t, root, "cmd/bd/BUILD.bazel"), "bd_embedded_test")
m := shardCountPattern.FindStringSubmatch(rule)
if m == nil {
t.Fatalf("cmd/bd:bd_embedded_test has no `shard_count = N,` in cmd/bd/BUILD.bazel:\n%s", rule)
}
n, err := strconv.Atoi(m[1])
if err != nil {
t.Fatalf("cmd/bd:bd_embedded_test shard_count: %v", err)
}
return n
}
// bazelEmbeddedStorageShardCount returns
// embeddeddolt:embeddeddolt_embedded_test's own shard_count from
// internal/storage/embeddeddolt/BUILD.bazel: the single source of truth for
// the Bazel-only bazel-embedded lane's storage shard split (slice F1), which
// no longer has to equal PR Risk's/main.yml's legacy "Test (Embedded Dolt
// Storage N/5)" fork/push jobs' matrix size. Mirrors
// bazelEmbeddedCmdShardCount above; see its doc comment.
func bazelEmbeddedStorageShardCount(t *testing.T) int {
t.Helper()
root := sourceRepoRoot(t)
rule := bazelRuleBlock(readPolicyFile(t, root, "internal/storage/embeddeddolt/BUILD.bazel"), "embeddeddolt_embedded_test")
m := shardCountPattern.FindStringSubmatch(rule)
if m == nil {
t.Fatalf("embeddeddolt:embeddeddolt_embedded_test has no `shard_count = N,` in internal/storage/embeddeddolt/BUILD.bazel:\n%s", rule)
}
n, err := strconv.Atoi(m[1])
if err != nil {
t.Fatalf("embeddeddolt:embeddeddolt_embedded_test shard_count: %v", err)
}
return n
}
// S3 (F1, mirroring F2's TestProxiedShardManifestGeneratorNotStale in
// scripts/pr_risk_bazel_coverage_test.go — see that test's doc comment for
// the full --check rationale, not repeated here): the Bazel-only 50-shard
// cmd block and 15-shard storage block are not frozen like their files'
// legacy 20- and 5-shard blocks. gen_embedded_{cmd,storage}_shard_manifest.py
// --check verifies only that the committed block names every discovered
// test exactly once, failing with the exact command to fix it when a name
// is missing, stale, or duplicated — run here so a drifted block fails `go
// test ./scripts/...` (//scripts:scripts_test under Bazel) instead of only
// surfacing as a test silently never running in any shard. The legacy
// blocks are deliberately excluded: both files document that their 20- and
// 5-shard blocks are frozen (see .github/scripts/embedded-{cmd,storage}-
// test-shards.txt and engdocs/TESTING.md), so a --check against them is
// expected to report "missing" entries by design (see those generators'
// module docstrings) and is not what this test runs.
func TestCmdEmbeddedShardManifestGeneratorNotStale(t *testing.T) {
python := requireHostTool(t, "python3")
root := sourceRepoRoot(t)
shards := strconv.Itoa(bazelEmbeddedCmdShardCount(t))
cmd := exec.Command(python, "scripts/ci/gen_embedded_cmd_shard_manifest.py", shards, "--weights=duration", "--check")
cmd.Dir = root
if out, err := cmd.CombinedOutput(); err != nil {
t.Errorf("gen_embedded_cmd_shard_manifest.py %s --weights=duration --check: %v\n%s", shards, err, out)
}
}
// TestStorageEmbeddedShardManifestGeneratorNotStale mirrors
// TestCmdEmbeddedShardManifestGeneratorNotStale above for the storage tier's
// Bazel-only 15-shard block; see that test's doc comment.
func TestStorageEmbeddedShardManifestGeneratorNotStale(t *testing.T) {
python := requireHostTool(t, "python3")
root := sourceRepoRoot(t)
shards := strconv.Itoa(bazelEmbeddedStorageShardCount(t))
cmd := exec.Command(python, "scripts/ci/gen_embedded_storage_shard_manifest.py", shards, "--weights=duration", "--check")
cmd.Dir = root
if out, err := cmd.CombinedOutput(); err != nil {
t.Errorf("gen_embedded_storage_shard_manifest.py %s --weights=duration --check: %v\n%s", shards, err, out)
}
}