beads/tools/nogo/analyzers/errcheck/errcheck.go
Julian Knutsen a4509deb2d
ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341)
* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18)

Lint and vet now run as nogo inside the Bazel build, so they gate wherever
the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs
leave pr.yml and main.yml.

- //tools/nogo (own go.mod, joined to beads' for go_deps only through
  gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set
  scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml
  enables, each a wrapper over the library version golangci-lint v2.10.1
  uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert,
  unparam).
- .golangci.yml stays the single lint policy: Bazel embeds it and
  tools/nogo/internal/golangci applies it as golangci-lint does (enabled
  set, settings, run.tests: false as library-unit-only analysis, lax
  generated-file detection, path/path-except/text exclusion rules), with
  strict decoding so an unimplemented key fails the build.
- gascity's rules_go //nolint-range patch and x/tools ctrlflow patch,
  byte-identical.
- Windows/darwin: cross-configured, not a golangci leg. The pure lane's
  release cross-compile (//tools/bazel:release_cross, every library and
  binary for all eight release platforms, cgo off) runs nogo on every
  compile, a superset of golangci-lint's windows and darwin legs.
  scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build
  --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64.
  release_cross skips tools/nogo, a separate Go module `go build ./...`
  never compiled.
- pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with
  their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache.
  scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted.
- pre-commit hook and .pre-commit-config.yaml run `make lint-changed
  LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds
  lint, vet and lint-changed. pr-lint.sh no longer runs gofmt
  (//scripts/repochecks:fmt_test owns it; ga-96smfk.41).
- internal/testutil/integration: five gosec findings in integration-tagged
  library files golangci-lint never built, now linted by the integration
  lanes, carry reasoned //nolint directives.

Parity: with the exclusion rules removed, golangci-lint and nogo report the
same 3,916 findings natively and 3,859 each for windows and darwin (file,
line, linter, text); with .golangci.yml as committed both report none.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set

tools/nogo is its own Go module, so `go test ./...` in the root never runs
its tests; Bazel's unit lane does. Its packages are neither expected nor
extra.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-07 05:17:22 +00:00

75 lines
2.1 KiB
Go

// Package errcheck runs github.com/kisielk/errcheck as golangci-lint's errcheck
// linter does, with .golangci.yml's linters.settings.errcheck.
package errcheck
import (
"cmp"
"fmt"
"regexp"
"strings"
"github.com/kisielk/errcheck/errcheck"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/packages"
"github.com/steveyegge/beads/tools/nogo/internal/golangci"
"github.com/steveyegge/beads/tools/nogo/internal/position"
)
// Analyzer reports unchecked errors.
var Analyzer = golangci.Wrap("errcheck", &analysis.Analyzer{
Name: "errcheck",
Doc: "reports unchecked errors",
Run: run,
})
func run(pass *analysis.Pass) (any, error) {
cfg, err := golangci.Load()
if err != nil {
return nil, err
}
settings := cfg.Linters.Settings.Errcheck
checker := errcheck.Checker{
Exclusions: errcheck.Exclusions{
BlankAssignments: !settings.CheckAssignToBlank,
TypeAssertions: !settings.CheckTypeAssertions,
SymbolRegexpsByPackage: map[string]*regexp.Regexp{},
},
}
if !settings.DisableDefaultExclusions {
checker.Exclusions.Symbols = append(checker.Exclusions.Symbols, errcheck.DefaultExcludedSymbols...)
}
checker.Exclusions.Symbols = append(checker.Exclusions.Symbols, settings.ExcludeFunctions...)
pkg := &packages.Package{
Fset: pass.Fset,
Syntax: pass.Files,
Types: pass.Pkg,
TypesInfo: pass.TypesInfo,
}
idx := position.NewIndex(pass)
for _, u := range checker.CheckPackage(pkg).Unique().UncheckedErrors {
pos, ok := idx.Pos(u.Pos)
if !ok {
continue
}
pass.Report(analysis.Diagnostic{Pos: pos, Message: Message(u, settings.Verbose)})
}
return nil, nil
}
// Message is golangci-lint's text for an unchecked error, which
// .golangci.yml's exclusion rules match against.
func Message(u errcheck.UncheckedError, verbose bool) string {
if u.FuncName == "" {
return "Error return value is not checked"
}
code := cmp.Or(u.SelectorName, u.FuncName)
if verbose {
code = u.FuncName
}
if !strings.Contains(code, "`") {
code = "`" + code + "`"
}
return fmt.Sprintf("Error return value of %s is not checked", code)
}