* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) Lint and vet now run as nogo inside the Bazel build, so they gate wherever the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs leave pr.yml and main.yml. - //tools/nogo (own go.mod, joined to beads' for go_deps only through gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml enables, each a wrapper over the library version golangci-lint v2.10.1 uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert, unparam). - .golangci.yml stays the single lint policy: Bazel embeds it and tools/nogo/internal/golangci applies it as golangci-lint does (enabled set, settings, run.tests: false as library-unit-only analysis, lax generated-file detection, path/path-except/text exclusion rules), with strict decoding so an unimplemented key fails the build. - gascity's rules_go //nolint-range patch and x/tools ctrlflow patch, byte-identical. - Windows/darwin: cross-configured, not a golangci leg. The pure lane's release cross-compile (//tools/bazel:release_cross, every library and binary for all eight release platforms, cgo off) runs nogo on every compile, a superset of golangci-lint's windows and darwin legs. scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64. release_cross skips tools/nogo, a separate Go module `go build ./...` never compiled. - pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache. scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted. - pre-commit hook and .pre-commit-config.yaml run `make lint-changed LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds lint, vet and lint-changed. pr-lint.sh no longer runs gofmt (//scripts/repochecks:fmt_test owns it; ga-96smfk.41). - internal/testutil/integration: five gosec findings in integration-tagged library files golangci-lint never built, now linted by the integration lanes, carry reasoned //nolint directives. Parity: with the exclusion rules removed, golangci-lint and nogo report the same 3,916 findings natively and 3,859 each for windows and darwin (file, line, linter, text); with .golangci.yml as committed both report none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set tools/nogo is its own Go module, so `go test ./...` in the root never runs its tests; Bazel's unit lane does. Its packages are neither expected nor extra. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
46 lines
1.8 KiB
Go
46 lines
1.8 KiB
Go
package unparam_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/tools/nogo/analyzers/unparam"
|
|
"github.com/steveyegge/beads/tools/nogo/internal/analyzertest"
|
|
)
|
|
|
|
const lib = `package p
|
|
|
|
func render(n int, unused string) int {
|
|
if n > 1 {
|
|
return n * 2
|
|
}
|
|
return n
|
|
}
|
|
|
|
// Use is exported, so unparam does not check it (check-exported is off).
|
|
func Use(x int) int { return render(1, "a") + render(2, "b") }
|
|
`
|
|
|
|
// golangci-lint v2.10.1 reports the same finding for the same package (a
|
|
// body this small but no smaller: unparam skips trivial functions).
|
|
func TestReportsUnusedParameters(t *testing.T) {
|
|
analyzertest.Equal(t, analyzertest.RunInRepo(t, unparam.Analyzer, "p", map[string]string{"p.go": lib}),
|
|
[]analyzertest.Diagnostic{{File: "p.go", Line: 3, Message: "render - unused is unused"}})
|
|
}
|
|
|
|
// run.tests: false: golangci-lint judged the package without its tests,
|
|
// which is Bazel's library unit; the test unit is not analyzed.
|
|
func TestTestUnitIsSkipped(t *testing.T) {
|
|
got := analyzertest.RunInRepo(t, unparam.Analyzer, "p", map[string]string{
|
|
"p.go": lib,
|
|
"p_test.go": "package p\n\nvar _ = render(1, \"c\")\n",
|
|
})
|
|
analyzertest.Equal(t, got, nil)
|
|
}
|
|
|
|
// .golangci.yml drops unparam's getConfig findings in the tracker adapters.
|
|
func TestPathTextExclusion(t *testing.T) {
|
|
src := map[string]string{"tracker.go": "package jira\n\nfunc getConfig(k string, unused int) string {\n\tif k == \"\" {\n\t\treturn \"none\"\n\t}\n\treturn k\n}\n\n// Use is exported.\nfunc Use() string { return getConfig(\"a\", 1) + getConfig(\"b\", 2) }\n"}
|
|
analyzertest.Equal(t, analyzertest.RunInRepo(t, unparam.Analyzer, "internal/jira", src), nil)
|
|
analyzertest.Equal(t, analyzertest.RunInRepo(t, unparam.Analyzer, "internal/other", src),
|
|
[]analyzertest.Diagnostic{{File: "tracker.go", Line: 3, Message: "getConfig - unused is unused"}})
|
|
}
|