beads/tools/nogo/analyzers_test.go
Julian Knutsen a4509deb2d
ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18) (#7341)
* ci(bazel): nogo replaces go vet and golangci-lint (ga-96smfk.18)

Lint and vet now run as nogo inside the Bazel build, so they gate wherever
the Bazel lanes execute (rbe-west), and the golangci-lint and go vet jobs
leave pr.yml and main.yml.

- //tools/nogo (own go.mod, joined to beads' for go_deps only through
  gazelle.go.work): go test's vet checks (cmd/go's defaultVetFlags, the set
  scripts/ci/go-test-vet.sh ran) plus the eight linters .golangci.yml
  enables, each a wrapper over the library version golangci-lint v2.10.1
  uses (depguard, errcheck, forbidigo, gosec, misspell, sloglint, unconvert,
  unparam).
- .golangci.yml stays the single lint policy: Bazel embeds it and
  tools/nogo/internal/golangci applies it as golangci-lint does (enabled
  set, settings, run.tests: false as library-unit-only analysis, lax
  generated-file detection, path/path-except/text exclusion rules), with
  strict decoding so an unimplemented key fails the build.
- gascity's rules_go //nolint-range patch and x/tools ctrlflow patch,
  byte-identical.
- Windows/darwin: cross-configured, not a golangci leg. The pure lane's
  release cross-compile (//tools/bazel:release_cross, every library and
  binary for all eight release platforms, cgo off) runs nogo on every
  compile, a superset of golangci-lint's windows and darwin legs.
  scripts/pr-lint (make ci-pr-lint, bd preflight) runs `bazel build
  --config=nogo //...` plus release_cross for windows_amd64,darwin_arm64.
  release_cross skips tools/nogo, a separate Go module `go build ./...`
  never compiled.
- pr.yml: scripts-go-checks (vet) and pr-lint-wrapper (x3) are gone, with
  their ci-gate entries; main.yml: pr-lint-wrapper (x6) and go-vet-cache.
  scripts/ci/go-test-vet.sh and install-golangci-lint.sh are deleted.
- pre-commit hook and .pre-commit-config.yaml run `make lint-changed
  LINT_CHANGED_SCOPE=staged` (nogo over the staged packages); Makefile adds
  lint, vet and lint-changed. pr-lint.sh no longer runs gofmt
  (//scripts/repochecks:fmt_test owns it; ga-96smfk.41).
- internal/testutil/integration: five gosec findings in integration-tagged
  library files golangci-lint never built, now linted by the integration
  lanes, carry reasoned //nolint directives.

Parity: with the exclusion rules removed, golangci-lint and nogo report the
same 3,916 findings natively and 3,859 each for windows and darwin (file,
line, linter, text); with .golangci.yml as committed both report none.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): equivalence.py leaves nested Go modules' tests out of go test's set

tools/nogo is its own Go module, so `go test ./...` in the root never runs
its tests; Bazel's unit lane does. Its packages are neither expected nor
extra.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-07 05:17:22 +00:00

104 lines
3.3 KiB
Go

package nogo_test
import (
"os"
"regexp"
"slices"
"strings"
"testing"
"golang.org/x/tools/go/analysis"
"github.com/steveyegge/beads/tools/nogo/analyzers/depguard"
"github.com/steveyegge/beads/tools/nogo/analyzers/errcheck"
"github.com/steveyegge/beads/tools/nogo/analyzers/forbidigo"
"github.com/steveyegge/beads/tools/nogo/analyzers/gosec"
"github.com/steveyegge/beads/tools/nogo/analyzers/misspell"
"github.com/steveyegge/beads/tools/nogo/analyzers/sloglint"
"github.com/steveyegge/beads/tools/nogo/analyzers/unconvert"
"github.com/steveyegge/beads/tools/nogo/analyzers/unparam"
"github.com/steveyegge/beads/tools/nogo/internal/golangci"
)
// starlarkList returns the string elements of `name = [...]` in analyzers.bzl.
func starlarkList(t *testing.T, name string) []string {
t.Helper()
data, err := os.ReadFile("analyzers.bzl")
if err != nil {
t.Fatal(err)
}
m := regexp.MustCompile(`(?ms)^` + name + ` = \[(.*?)^\]`).FindSubmatch(data)
if m == nil {
t.Fatalf("analyzers.bzl has no %s list", name)
}
var out []string
for _, s := range regexp.MustCompile(`"([^"]+)"`).FindAllSubmatch(m[1], -1) {
out = append(out, string(s[1]))
}
return out
}
// TestGolangciLintersAreTheEnabledOnes keeps analyzers.bzl's GOLANGCI_LINTERS
// equal to .golangci.yml's linters.enable: a linter enabled there and missing
// here would silently stop gating, and one listed here but not enabled would
// do nothing (Wrap skips it).
func TestGolangciLintersAreTheEnabledOnes(t *testing.T) {
data, err := os.ReadFile("../../.golangci.yml")
if err != nil {
t.Fatal(err)
}
cfg, err := golangci.Parse(data)
if err != nil {
t.Fatal(err)
}
enabled := slices.Sorted(slices.Values(cfg.Linters.Enable))
listed := slices.Sorted(slices.Values(starlarkList(t, "GOLANGCI_LINTERS")))
if !slices.Equal(enabled, listed) {
t.Errorf(".golangci.yml enables %v; analyzers.bzl's GOLANGCI_LINTERS is %v", enabled, listed)
}
}
// Each wrapper is named after its golangci-lint linter, which is what
// //nolint:<linter> directives and .golangci.yml's exclusion rules name.
func TestWrapperNamesAreLinterNames(t *testing.T) {
for _, a := range []*analysis.Analyzer{
depguard.Analyzer, errcheck.Analyzer, forbidigo.Analyzer, gosec.Analyzer,
misspell.Analyzer, sloglint.Analyzer, unconvert.Analyzer, unparam.Analyzer,
} {
if !slices.Contains(starlarkList(t, "GOLANGCI_LINTERS"), a.Name) {
t.Errorf("analyzer %q is not a GOLANGCI_LINTERS entry", a.Name)
}
}
}
// The embedded copy Wrap applies is the repository's .golangci.yml.
func TestEmbeddedConfigIsTheRepositoryConfig(t *testing.T) {
data, err := os.ReadFile("../../.golangci.yml")
if err != nil {
t.Fatal(err)
}
want, err := golangci.Parse(data)
if err != nil {
t.Fatal(err)
}
got, err := golangci.Load()
if err != nil {
t.Fatal(err)
}
if !slices.Equal(got.Linters.Enable, want.Linters.Enable) || len(got.Linters.Exclusions.Rules) != len(want.Linters.Exclusions.Rules) {
t.Errorf("embedded .golangci.yml differs from the repository's")
}
}
// config.json's _base scope: external repos, Bazel outputs and testdata only.
func TestBaseScope(t *testing.T) {
data, err := os.ReadFile("config.json")
if err != nil {
t.Fatal(err)
}
for _, want := range []string{`"^external/"`, `"(^|/)bazel-out/"`, `"(^|/)testdata/"`} {
if !strings.Contains(string(data), want) {
t.Errorf("config.json does not exclude %s", want)
}
}
}