* test(feat): red — Add sentinelFlooredTables to cursorRealityFloor so events/bd_events_journal/bd_events_seq self-heal (release/1.3.0) (refs be-u14.1)
* feat: green — Add sentinelFlooredTables to cursorRealityFloor so events/bd_events_journal/bd_events_seq self-heal (release/1.3.0) (refs be-u14.1)
* chore: release gate PASS for cursor-reality-floor-sentinel-self-heal (be-g69lt)
* chore: remove leaked internal release-gate doc from PR branch
release-gates/be-g69lt-gate.md
Tracked our internal gc-management/beads-rig release-gate checklist and
should never have been committed to this upstream branch -- it's process
residue from our deploy tooling, not part of the change itself.
Per maintainer bee-ghosttrack's request during review of PR #6571. The
root cause (our deploy tooling auto-committing this file) is already fixed
as of gm-qatxl1; this branch predates that fix, so this commit is cleanup
only -- no other content on this branch is touched.
Ref: be-lk7o3
* fix(schema): pin the floored-sentinel minimum and generalize creator detection
Maintainer review fixups for PR #6547 (adoption review, iteration 1). No
behavior change beyond the probe error-message text.
- Pin the floored loop's intra-loop minimum. Every existing case removed
exactly one floored sentinel, so `st.replayFloor < floor` was never
evaluated against a floor an earlier absent sentinel had already set, and
inverting it to `>` left the whole package green. Adds an "events and
bd_events_journal both absent" case asserting floor 18 and widens
allSentinelTablesExcept to variadic; the inversion now fails (floor = 21,
want 18). The floors ascend in slice order today (18, 21, 21), so this is
what keeps a future reordering or lower-floored addition from silently
regressing to "last absent sentinel wins".
- Distinguish the floored-table probe's error wrap from the floor-0 loop's.
They were byte-identical, so a store-open failure did not say which
sentinel class failed, and the consequences differ sharply (floor 0 and a
full series replay vs. floor 18/21).
- Detect both creator shapes in TestSentinelFlooredTablesAreCreatedByTheSeries
rather than keying on the literal table name "events". The PREPAREd
conditional CREATE is required of any creator whose table carries a named,
database-unique constraint (ignored/0019's own comment), so a future floored
sentinel in that shape would have fallen through to the __temp__ regex and
failed with a misleading "never created by the series". Both arms are
mutation-proved to be load-bearing.
- Record in the sentinelFlooredTables comment that events' dolt_ignore pattern
is version-gated ({"events", 62}) rather than unconditional, and why the
clamp is safe anyway: the ignored plane is only reached after the main pass
succeeds, and a main pass from below 62 applies 0062_events_dolt_ignore,
whose REPLACE INTO dolt_ignore lands before the ignored plane is touched.
Validation: go test -count=1 ./internal/storage/schema/ (ok, 36.5s), go vet
and gofmt clean, git diff --check clean.
---------
Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>