beads/internal
Julian Knutsen c18db4ebbd
feat(storage): add events/bd_events_journal/bd_events_seq to cursorRealityFloor sentinel set (port of #6547 to main) (#7480)
* feat(storage): add events/bd_events_journal/bd_events_seq to cursorRealityFloor sentinel set (port of #6547)

Port of the release/1.3.x commit aa3c43b6bd (PR #6547) to main, where it
never landed: v1.3.1 is cut from a release branch that is not an ancestor
of main.

events (ignored/0019) and bd_events_journal/bd_events_seq (ignored/0022)
are dolt_ignored, so they are never part of committed history and a fresh
clone can arrive with the ignored-plane cursor at-latest but without them.
cursorRealityFloor only knew about wisps/wisp_dependencies (floor 0) and
leases.granted_node (floor 11), so such a clone believed its cursor and
never re-created the missing tables.

A new sentinelFlooredTables list clamps the believable cursor to each
table's own replayFloor (18 for events, 21 for the journal pair) instead
of 0, so the replay re-runs the creating migration without re-running
ignored/0007's unguarded `UPDATE wisps SET is_blocked = 0`. Floored
tables are probed after the floor-0 tables and together with the column
sentinels, taking the minimum across everything found absent.

Tests: TestCursorRealityFloor and TestCurrentVersionClampsToSentinelFloor
gain the three single-absence cases, a two-floored-table case pinning the
intra-loop minimum, and a table+column case pinning the cross-loop
minimum; TestSentinelFlooredTablesAreCreatedByTheSeries asserts each
floored table is created strictly above its floor and that the floor
excludes ignored/0007. The sqlmock probe sequences in lock_test.go and
cursor_reality_test.go expect the extra INFORMATION_SCHEMA.TABLES probes.

The commit applied to main without conflicts; main's ignored series still
creates the three tables at 0019 and 0022.

Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(schema): pin cursorRealityFloor's floored-table probe error

cursorRealityFloor returns a floored-table probe error instead of
reading the table as absent or skipping it, but no test reached that
return. TestCursorProbeErrorIsNotTreatedAsContradicted fails every
table probe, so it returns at the floor-0 wisps probe first. Turning
the return into `continue`, or into "absent", left the whole schema
package green.

TestFlooredTableProbeErrorIsNotTreatedAsContradicted fails exactly one
floored table per subtest (events, bd_events_journal, bd_events_seq),
with every other sentinel table present. It asserts that the error
propagates, that the cursor is not reported as contradicted, and that
no column sentinel is probed afterwards. stubSentinelTables applies one
error to every probe, so the test stubs sentinelTableExists inline
rather than widening a helper the other tests share.

Mutated under a go test -overlay, each of `continue`, "absent", and
returning limited=true alongside the error fails only this test's
three subtests. The unmutated package passes 474 of 474 tests and
subtests, none skipped.

The test is additive and sits between two existing tests. It adds no
conflict hunk to #7213, #7297, or #7409, and #7050's duplicate port
commit still replays as empty on top of this PR, so a rebase drops it.
For that reason the review's suggested rewording of the floored-table
rationale comments is left for after #7050 lands. The comments stay
identical to release commit aa3c43b6bd.

Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Jim Wordelman <jim@wordelman.name>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 23:25:58 +00:00
..
ado ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
atomicfile ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
audit ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
beads ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
ceiling ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
compact ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
config ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
configfile ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
creds ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
debug ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
doltremote ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
doltserver ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
doltversion ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
eventsjournal ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
execenv ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
fdhygiene ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
formula ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
git ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
gitenv ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
githooksenv ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
github ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
gitignore feat(backend/http): public HTTP backend door, OSS registration, and bd connect (S6) (#7288) 2026-10-10 07:19:18 +00:00
gitlab ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
gittraceenv ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
hooks ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
httpapi feat(http): list/show counts/dep tree/ping over http, the advertised external-dependency policy, one-lookup not-found (S6b/S6c/S6d) (#7471) 2026-10-10 18:11:56 +00:00
httpclient feat(http): list/show counts/dep tree/ping over http, the advertised external-dependency policy, one-lookup not-found (S6b/S6c/S6d) (#7471) 2026-10-10 18:11:56 +00:00
idgen ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
jira ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
linear ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
lockfile ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
memoryapi ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
metrics ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
migration ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
molecules ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
notion ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
procid ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
query ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
recipes ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
remotecache ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
routing ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
storage feat(storage): add events/bd_events_journal/bd_events_seq to cursorRealityFloor sentinel set (port of #6547 to main) (#7480) 2026-10-10 23:25:58 +00:00
telemetry feat(roles): LeaseReclaimer role, POST issues:reclaim, and bd reclaim on both routes (S9) (#7412) 2026-10-09 14:56:32 +00:00
templates ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
testutil fix(testutil): sweep Dolt test containers whose owner process exited (#7028) 2026-10-10 02:39:59 +00:00
timeparsing ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
tracker ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
types feat(roles): LeaseReclaimer role, POST issues:reclaim, and bd reclaim on both routes (S9) (#7412) 2026-10-09 14:56:32 +00:00
ui ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
uimd ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
utils feat(http): list/show counts/dep tree/ping over http, the advertised external-dependency policy, one-lookup not-found (S6b/S6c/S6d) (#7471) 2026-10-10 18:11:56 +00:00
validation fix(issueops): enforce the close guards on every close leg (#7425) 2026-10-09 18:30:42 +00:00
versioncheck ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
workapi ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
workspacegate ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00
worktreeremove ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414) 2026-10-09 05:13:07 +00:00